CVE-2021-41120: Authorization Bypass Through User-Controlled Key (CWE-639)
value: sylius/paypal-plugin is a paypal plugin for the Sylius development platform. In affected versions the URL to the payment page done after checkout was created with autoincremented payment id (/pay-with-paypal/{id}) and therefore it was easy to predict. The problem is that the Credit card form has prefilled "credit card holder" field with the Customer's first and last name and hence this can lead to personally identifiable information exposure. Additionally, the mentioned form did not require authentication. The problem has been patched in Sylius/PayPalPlugin 1.2.4 and 1.3.1. If users are unable to update they can override a sylius_paypal_plugin_pay_with_paypal_form route and change its URL parameters to (for example) {orderToken}/{paymentId}, then override the Sylius\PayPalPlugin\Controller\PayWithPayPalFormAction service, to operate on the payment taken from the repository by these 2 values. It would also require usage of custom repository method. Additionally, one could override the @SyliusPayPalPlugin/payWithPaypal.html.twig template, to add contingencies: ['SCA_ALWAYS'] line in hostedFields.submit(...) function call (line 421). It would then have to be handled in the function callback.
CWE description: The system's authorization functionality does not prevent one user from gaining access to another user's data or record by modifying the key value identifying the data.
CVSS v3 base score: 7.5
Published: 2021-10-05T21:15Z
Repository: https://github.com/Sylius/PayPalPlugin
Language: Other
Files changed: src/Resources/views/payWithPaypal.html.twig
Commit date: 2021-10-04 15:57:45 +0200
Commit message: Require 3D Secure and process its response correctly

Diff: diff --git a/src/Resources/views/payWithPaypal.html.twig b/src/Resources/views/payWithPaypal.html.twig
index ef09d17..e164e4d 100644
--- a/src/Resources/views/payWithPaypal.html.twig
+++ b/src/Resources/views/payWithPaypal.html.twig
@@ -327,20 +327,24 @@
                 button.render('#paypal-button-container');
             }
         });
 
         if (paypal.HostedFields.isEligible() === true) {
+            let processingOrderId;
+
             paypal.HostedFields.render({
                 createOrder: function(data, actions) {
                     document.querySelector('#paypal-payment-container').classList.add('loading');
                     document.querySelector('#paypal-button-container').classList.add('low-opacity');
 
                     return fetch(createPayPalOrderUrl, {
                         method: 'POST'
                     }).then(function(res) {
                         return res.json();
                     }).then(function(data) {
+                        processingOrderId = data.orderID;
+
                         return data.orderID;
                     });
                 },
                 styles: {
                     'input': {
@@ -417,33 +421,49 @@
                         return state.fields[key].isValid;
                     });
 
                     if (formValid) {
                         hostedFields.submit({
+                            contingencies: ['SCA_ALWAYS'],
                             cardholderName: document.getElementById('card-holder-name').value,
                             billingAddress: {
                                 streetAddress: document.getElementById('card-billing-address-street').value,
                                 region: document.getElementById('card-billing-address-state').value,
                                 locality: document.getElementById('card-billing-address-city').value,
                                 postalCode: document.getElementById('card-billing-address-zip').value,
                                 countryCodeAlpha2: document.getElementById('card-billing-address-country').value
                             }
                         }).then(payload => {
-                            return fetch(completePayPalOrderUrl, {
-                                method: 'post'
-                            }).then(function(res) {
-                                return res.json();
+                            if (payload.authenticationReason == 'SUCCESSFUL' && payload.authenticationStatus == 'YES') {
+                                return fetch(completePayPalOrderUrl, {
+                                    method: 'post'
+                                }).then(function(res) {
+                                    return res.json();
+                                }).then(function(data) {
+                                    if (data.status == 'processing') {
+                                        return fetch(cancelPayPalPaymentUrl, {
+                                            method: 'post',
+                                            headers: { 'content-type': 'application/json' },
+                                            body: JSON.stringify({ payPalOrderId: data.orderID })
+                                        }).then(window.location.reload());
+                                    }
+
+                                    window.location.href = data.return_url;
+                                });
+                            }
+
+
+                            return fetch(errorPayPalPaymentUrl, {
+                                method: 'post',
+                                headers: { 'content-type': 'application/json' },
+                                body: JSON.stringify('Invalid 3D Secure authentication.')
                             }).then(function(data) {
-                                if (data.status == 'processing') {
-                                    return fetch(cancelPayPalPaymentUrl, {
-                                        method: 'post',
-                                        headers: { 'content-type': 'application/json' },
-                                        body: JSON.stringify({ payPalOrderId: data.orderID })
-                                    }).then(window.location.reload());
-                                }
-
-                                window.location.href = data.return_url;
+                                return fetch(cancelPayPalPaymentUrl, {
+                                    method: 'post',
+                                    headers: { 'content-type': 'application/json' },
+                                    body: JSON.stringify({ payPalOrderId: processingOrderId })
+                                }).then(window.location.reload());
                             });
                         });
                     } else {
                         alert(invalidFormMessage);
                     }

Vulnerable code:                             return fetch(completePayPalOrderUrl, {
                                method: 'post'
                            }).then(function(res) {
                                return res.json();
                                if (data.status == 'processing') {
                                    return fetch(cancelPayPalPaymentUrl, {
                                        method: 'post',
                                        headers: { 'content-type': 'application/json' },
                                        body: JSON.stringify({ payPalOrderId: data.orderID })
                                    }).then(window.location.reload());
                                }

                                window.location.href = data.return_url;
Fixed code:             let processingOrderId;

                        processingOrderId = data.orderID;

                            contingencies: ['SCA_ALWAYS'],
                            if (payload.authenticationReason == 'SUCCESSFUL' && payload.authenticationStatus == 'YES') {
                                return fetch(completePayPalOrderUrl, {
                                    method: 'post'
                                }).then(function(res) {
                                    return res.json();
                                }).then(function(data) {
                                    if (data.status == 'processing') {
                                        return fetch(cancelPayPalPaymentUrl, {
                                            method: 'post',
                                            headers: { 'content-type': 'application/json' },
                                            body: JSON.stringify({ payPalOrderId: data.orderID })
                                        }).then(window.location.reload());
                                    }

                                    window.location.href = data.return_url;
                                });
                            }


                            return fetch(errorPayPalPaymentUrl, {
                                method: 'post',
                                headers: { 'content-type': 'application/json' },
                                body: JSON.stringify('Invalid 3D Secure authentication.')
                                return fetch(cancelPayPalPaymentUrl, {
                                    method: 'post',
                                    headers: { 'content-type': 'application/json' },
                                    body: JSON.stringify({ payPalOrderId: processingOrderId })
                                }).then(window.location.reload());