CVE-2023-48292: Cross-Site Request Forgery (CSRF) (CWE-352)
value: The XWiki Admin Tools Application provides tools to help the administration of XWiki. Starting in version 4.4 and prior to version 4.5.1, a cross site request forgery vulnerability in the admin tool for executing shell commands on the server allows an attacker to execute arbitrary shell commands by tricking an admin into loading the URL with the shell command. A very simple possibility for an attack are comments. When the attacker can leave a comment on any page in the wiki it is sufficient to include an image with an URL like  `/xwiki/bin/view/Admin/RunShellCommand?command=touch%20/tmp/attacked` in the comment. When an admin views the comment, the file `/tmp/attacked` will be created on the server. The output of the command is also vulnerable to XWiki syntax injection which offers a simple way to execute Groovy in the context of the XWiki installation and thus an even easier way to compromise the integrity and confidentiality of the whole XWiki installation. This has been patched by adding a form token check in version 4.5.1 of the admin tools. Some workarounds are available. The patch can be applied manually to the affected wiki pages. Alternatively, the document `Admin.RunShellCommand` can also be deleted if the possibility to run shell commands isn't needed.
CWE description: The web application does not, or can not, sufficiently verify whether a well-formed, valid, consistent request was intentionally provided by the user who submitted the request.
CVSS v3 base score: 8.8
Published: 2023-11-20T18:15Z
Repository: https://github.com/xwiki-contrib/application-admintools
Language: XML
Files changed: src/main/resources/Admin/RunShellCommand.xml, src/main/resources/Admin/Translations.xml
Commit date: 2023-08-03 17:25:07 +0200
Commit message: ADMINTOOL-91: Add a form token check in RunShellCommand

Diff: diff --git a/src/main/resources/Admin/RunShellCommand.xml b/src/main/resources/Admin/RunShellCommand.xml
index 3955440..340a324 100644
--- a/src/main/resources/Admin/RunShellCommand.xml
+++ b/src/main/resources/Admin/RunShellCommand.xml
@@ -47,10 +47,11 @@ if (services.security.authorization.hasAccess(Right.PROGRAM)) {
   def placeHolder = escapeTool.xml(services.localization.render('admintools.server.tools.shellCommand.placeholder'));
   def buttonLabel = services.localization.render('admintools.server.tools.shellCommand.run');
   def shellCmd = request.getParameter("command");
   def htmlForm = """
     &lt;form class="form-horizontal" action="" method="POST"&gt;
+      &lt;input type="hidden" name="form_token" value="${services.csrf.token}" /&gt;
       &lt;div class="form-group"&gt;
         &lt;div class="col-sm-10"&gt;
           &lt;input type="text" name="command" value="${shellCmd != null ? escapeTool.xml(shellCmd) : ''}" class="form-control col-md-12" style="width: 100%;" placeholder="${placeHolder}"&gt;
       &lt;/div&gt;
       &lt;div class="col-sm-2"&gt;
@@ -58,18 +59,23 @@ if (services.security.authorization.hasAccess(Right.PROGRAM)) {
       &lt;/div&gt;
     &lt;/div&gt;
   &lt;/form&gt;""";
   println("{{warning}}${services.localization.render('admintools.server.tools.shellCommand.warning')}{{/warning}}\n\n");
   println("{{html}}${htmlForm}{{/html}}\n\n");
-  if (shellCmd != null ) {
-    String[] cmd = ["sh", "-c", shellCmd];
-    stdout = new java.io.BufferedReader(new java.io.InputStreamReader(Runtime.getRuntime().exec(cmd).getInputStream()));
-    println("{{code language=none}}")
-    while ((s = stdout.readLine()) != null) {
-      println(s);
+  def tokenValid = services.csrf.isTokenValid(request.getParameter('form_token'));
+  if (shellCmd != null) {
+    if (!tokenValid) {
+      println("{{error}}${services.localization.render('admintools.server.tools.shellCommand.invalidToken')}{{/error}}\n\n");
+    } else {
+      String[] cmd = ["sh", "-c", shellCmd];
+      stdout = new java.io.BufferedReader(new java.io.InputStreamReader(Runtime.getRuntime().exec(cmd).getInputStream()));
+      println("{{code language=none}}")
+      while ((s = stdout.readLine()) != null) {
+        println(s);
+      }
+      println("{{/code}}")
     }
-    println("{{/code}}")
   }
 }
 {{/groovy}}</content>
   <object>
     <name>Admin.RunShellCommand</name>
diff --git a/src/main/resources/Admin/Translations.xml b/src/main/resources/Admin/Translations.xml
index 05cee62..993ec96 100755
--- a/src/main/resources/Admin/Translations.xml
+++ b/src/main/resources/Admin/Translations.xml
@@ -49,11 +49,12 @@ admintools.database.tools.query=Tool to run queries on the database
 admintools.server.tools=Server tools
 admintools.server.tools.shellCommand=Run Shell Command
 admintools.server.tools.shellCommand.description=Tool to run shell commands on the server **(Only works on linux servers)**
 admintools.server.tools.shellCommand.run=Run
 admintools.server.tools.shellCommand.placeholder=Enter shell command
-admintools.server.tools.shellCommand.warning=This tool works only on Linux servers. It can create processes which do not stop, it's up to you to then find and kill the processes.</content>
+admintools.server.tools.shellCommand.warning=This tool works only on Linux servers. It can create processes which do not stop, it's up to you to then find and kill the processes.
+admintools.server.tools.shellCommand.invalidToken=Invalid form token. Please verify the command and resubmit.</content>
   <object>
     <name>Admin.Translations</name>
     <number>0</number>
     <className>XWiki.TranslationDocumentClass</className>
     <guid>bd47cb26-9e37-4cb4-8f3e-3dd8a2a44e8f</guid>

Vulnerable code:   if (shellCmd != null ) {
    String[] cmd = ["sh", "-c", shellCmd];
    stdout = new java.io.BufferedReader(new java.io.InputStreamReader(Runtime.getRuntime().exec(cmd).getInputStream()));
    println("{{code language=none}}")
    while ((s = stdout.readLine()) != null) {
      println(s);
    println("{{/code}}")
admintools.server.tools.shellCommand.warning=This tool works only on Linux servers. It can create processes which do not stop, it's up to you to then find and kill the processes.</content>
Fixed code:       &lt;input type="hidden" name="form_token" value="${services.csrf.token}" /&gt;
  def tokenValid = services.csrf.isTokenValid(request.getParameter('form_token'));
  if (shellCmd != null) {
    if (!tokenValid) {
      println("{{error}}${services.localization.render('admintools.server.tools.shellCommand.invalidToken')}{{/error}}\n\n");
    } else {
      String[] cmd = ["sh", "-c", shellCmd];
      stdout = new java.io.BufferedReader(new java.io.InputStreamReader(Runtime.getRuntime().exec(cmd).getInputStream()));
      println("{{code language=none}}")
      while ((s = stdout.readLine()) != null) {
        println(s);
      }
      println("{{/code}}")
admintools.server.tools.shellCommand.warning=This tool works only on Linux servers. It can create processes which do not stop, it's up to you to then find and kill the processes.
admintools.server.tools.shellCommand.invalidToken=Invalid form token. Please verify the command and resubmit.</content>