CVE-2023-48293: Cross-Site Request Forgery (CSRF) (CWE-352)
value: The XWiki Admin Tools Application provides tools to help the administration of XWiki. Prior to version 4.5.1, a cross-site request forgery vulnerability in the query on XWiki tool allows executing arbitrary database queries on the database of the XWiki installation. Among other things, this allows modifying and deleting all data of the wiki. This could be both used to damage the wiki and to create an account with elevated privileges for the attacker, thus impacting the confidentiality, integrity and availability of the whole XWiki instance. A possible attack vector are comments on the wiki, by embedding an image with wiki syntax like `[[image:path:/xwiki/bin/view/Admin/QueryOnXWiki?query=DELETE%20FROM%20xwikidoc]]`, all documents would be deleted from the database when an admin user views this comment. This has been patched in Admin Tools Application 4.5.1 by adding form token checks. Some workarounds are available. The patch can also be applied manually to the affected pages. Alternatively, if the query tool is not needed, by deleting the document `Admin.SQLToolsGroovy`, all database query tools can be deactivated.
CWE description: The web application does not, or can not, sufficiently verify whether a well-formed, valid, consistent request was intentionally provided by the user who submitted the request.
CVSS v3 base score: 8.8
Published: 2023-11-20T19:15Z
Repository: https://github.com/xwiki-contrib/application-admintools
Language: XML
Files changed: src/main/resources/Admin/Query.xml, src/main/resources/Admin/QueryOnXWiki.xml, src/main/resources/Admin/SQLToolsGroovy.xml
Commit date: 2023-08-03 18:09:07 +0200
Commit message: ADMINTOOL-92: Add a form token check to Query tools

Diff: diff --git a/src/main/resources/Admin/Query.xml b/src/main/resources/Admin/Query.xml
index 5b17e1d..36ef1ed 100644
--- a/src/main/resources/Admin/Query.xml
+++ b/src/main/resources/Admin/Query.xml
@@ -43,16 +43,20 @@
   <hidden>true</hidden>
   <content>{{velocity}}
 #if($hasProgramming)
   #set($sqlTools = $xwiki.parseGroovyFromPage('Admin.SQLToolsGroovy'))
   = Query =
-  $sqlTools.getForm($request, $doc, true, true, $xcontext)
+  $sqlTools.getForm($request, $doc, true, true, $xcontext, $services.csrf.token)
   #if($request.query)
-    #set($connection = $sqlTools.getConnectionFromRequest($request))
-    #set($results = $sqlTools.getResults($connection, $request.query, true))
-    = Results =
-    $results
+    #if ($services.csrf.isTokenValid($request.getParameter('form_token')))
+      #set($connection = $sqlTools.getConnectionFromRequest($request))
+      #set($results = $sqlTools.getResults($connection, $request.query, true))
+      = Results =
+      $results
+    #else
+      {{error}}Invalid form token. Please verify the query and resubmit.{{/error}}
+    #end
   #end
 #else
 {{error}}Sorry, you need the programming rights to use this tool{{/error}}
 #end
 {{/velocity}}
diff --git a/src/main/resources/Admin/QueryOnXWiki.xml b/src/main/resources/Admin/QueryOnXWiki.xml
index 0de02c6..7203ba8 100644
--- a/src/main/resources/Admin/QueryOnXWiki.xml
+++ b/src/main/resources/Admin/QueryOnXWiki.xml
@@ -45,16 +45,20 @@
 #if($hasProgramming)
   #set($sqlTools = $xwiki.parseGroovyFromPage('Admin.SQLToolsGroovy'))
   #set($system = $sqlTools.getXWikiDatabaseSystem($xwiki, $xcontext))
   = Query =
   Your database is: **$system**
-  $sqlTools.getForm($request, $doc, false, true, $xcontext)
+  $sqlTools.getForm($request, $doc, false, true, $xcontext, $services.csrf.token)
   #if($request.query)
-    #set($connection = $sqlTools.getXWikiConnection($xwiki, $xcontext))
-    #set($results = $sqlTools.getResults($connection, $request.query, false))
-    = Results =
-    $results
+    #if ($services.csrf.isTokenValid($request.getParameter('form_token')))
+      #set($connection = $sqlTools.getXWikiConnection($xwiki, $xcontext))
+      #set($results = $sqlTools.getResults($connection, $request.query, false))
+      = Results =
+      $results
+    #else
+      {{error}}Invalid form token. Please verify the query and resubmit.{{/error}}
+    #end
   #end
 #else
 {{error}}Sorry, you need the programming rights to use this tool{{/error}}
 #end
 {{/velocity}}
diff --git a/src/main/resources/Admin/SQLToolsGroovy.xml b/src/main/resources/Admin/SQLToolsGroovy.xml
index d1c6fb4..ce8bc7b 100644
--- a/src/main/resources/Admin/SQLToolsGroovy.xml
+++ b/src/main/resources/Admin/SQLToolsGroovy.xml
@@ -112,19 +112,20 @@ class SQLTools{
   }
 
   /**
    * Get Form
    */
-  String getForm(request, doc, withJDBCForm, withQuery, xcontext){
+  String getForm(request, doc, withJDBCForm, withQuery, xcontext, csrfToken){
     def databaseConfiguration = new DatabaseConfiguration(request, xcontext)
     def escapeTool = new EscapeTool()
     def spageUrl = escapeTool.xml(doc.getURL())
     
     // &lt;form&gt;
     def toReturn = """
       {{html clean=="false"}}
       &lt;form action="${spageUrl}#HResults" class="xform" method="post"&gt;
+        &lt;input type="hidden" name="form_token" value="${csrfToken}" /&gt;
     """;
     // JDB Form (user, password driver, url)
     if(withJDBCForm){
       // Get/Escape datas
       def surl = escapeTool.xml(databaseConfiguration.getUrl())

Vulnerable code:   $sqlTools.getForm($request, $doc, true, true, $xcontext)
    #set($connection = $sqlTools.getConnectionFromRequest($request))
    #set($results = $sqlTools.getResults($connection, $request.query, true))
    = Results =
    $results
  $sqlTools.getForm($request, $doc, false, true, $xcontext)
    #set($connection = $sqlTools.getXWikiConnection($xwiki, $xcontext))
    #set($results = $sqlTools.getResults($connection, $request.query, false))
    = Results =
    $results
  String getForm(request, doc, withJDBCForm, withQuery, xcontext){
Fixed code:   $sqlTools.getForm($request, $doc, true, true, $xcontext, $services.csrf.token)
    #if ($services.csrf.isTokenValid($request.getParameter('form_token')))
      #set($connection = $sqlTools.getConnectionFromRequest($request))
      #set($results = $sqlTools.getResults($connection, $request.query, true))
      = Results =
      $results
    #else
      {{error}}Invalid form token. Please verify the query and resubmit.{{/error}}
    #end
  $sqlTools.getForm($request, $doc, false, true, $xcontext, $services.csrf.token)
    #if ($services.csrf.isTokenValid($request.getParameter('form_token')))
      #set($connection = $sqlTools.getXWikiConnection($xwiki, $xcontext))
      #set($results = $sqlTools.getResults($connection, $request.query, false))
      = Results =
      $results
    #else
      {{error}}Invalid form token. Please verify the query and resubmit.{{/error}}
    #end
  String getForm(request, doc, withJDBCForm, withQuery, xcontext, csrfToken){
        &lt;input type="hidden" name="form_token" value="${csrfToken}" /&gt;