CVE-2024-25117: Insufficient Information (NVD-CWE-noinfo)
value: php-svg-lib is a scalable vector graphics (SVG) file parsing/rendering library. Prior to version 0.5.2, php-svg-lib fails to validate that font-family doesn't contain a PHAR url, which might leads to RCE on PHP < 8.0, and doesn't validate if external references are allowed. This might leads to bypass of restrictions or RCE on projects that are using it, if they do not strictly revalidate the fontName that is passed by php-svg-lib. The `Style::fromAttributes(`), or the `Style::parseCssStyle()` should check the content of the `font-family` and prevents it to use a PHAR url, to avoid passing an invalid and dangerous `fontName` value to other libraries. The same check as done in the `Style::fromStyleSheets` might be reused. Libraries using this library as a dependency might be vulnerable to some bypass of restrictions, or even remote code execution, if they do not double check the value of the `fontName` that is passed by php-svg-lib. Version 0.5.2 contains a fix for this issue.
CWE description: There is insufficient information about the issue to classify it; details are unkown or unspecified.
Published: 2024-02-21T17:15Z
Repository: https://github.com/dompdf/php-svg-lib
Language: PHP
Files changed: src/Svg/Tag/Image.php
Commit date: 2024-02-07 07:49:40 -0500
Commit message: Remove invalid condition around image href validation

Diff: diff --git a/src/Svg/Tag/Image.php b/src/Svg/Tag/Image.php
index 1689954..de397c4 100644
--- a/src/Svg/Tag/Image.php
+++ b/src/Svg/Tag/Image.php
@@ -56,18 +56,16 @@ class Image extends AbstractTag
             $this->href = $attributes['href'];
         }
 
         $this->document->getSurface()->transform(1, 0, 0, -1, 0, $height);
 
-        if ($from === "font-family") {
-            $scheme = \strtolower(parse_url($this->href, PHP_URL_SCHEME) ?: "");
-            if (
-                $scheme === "phar" || \strtolower(\substr($this->href, 0, 7)) === "phar://"
-                || ($this->document->allowExternalReferences === false && $scheme !== "data")
-            ) {
-                return;
-            }
+        $scheme = \strtolower(parse_url($this->href, PHP_URL_SCHEME) ?: "");
+        if (
+            $scheme === "phar" || \strtolower(\substr($this->href, 0, 7)) === "phar://"
+            || ($this->document->allowExternalReferences === false && $scheme !== "data")
+        ) {
+            return;
         }
 
         $this->document->getSurface()->drawImage($this->href, $this->x, $this->y, $this->width, $this->height);
     }
 

Vulnerable code:         if ($from === "font-family") {
            $scheme = \strtolower(parse_url($this->href, PHP_URL_SCHEME) ?: "");
            if (
                $scheme === "phar" || \strtolower(\substr($this->href, 0, 7)) === "phar://"
                || ($this->document->allowExternalReferences === false && $scheme !== "data")
            ) {
                return;
            }
Fixed code:         $scheme = \strtolower(parse_url($this->href, PHP_URL_SCHEME) ?: "");
        if (
            $scheme === "phar" || \strtolower(\substr($this->href, 0, 7)) === "phar://"
            || ($this->document->allowExternalReferences === false && $scheme !== "data")
        ) {
            return;