Repository: softwaremill/sttp-openai (scala)

Issue:
How to change request timeout for createChatCompletion
I am using the chat completion function like so: `val response: ChatResponse = openAI.createChatCompletion(chatRequestBody)`

When I run it against the current top model, 'p1-preview', I run into 30 second timeouts. '01-preview' is designed to take longer to reason, so it is ok if it takes longer.

The timeout I get: `java.util.concurrent.TimeoutException: test timed out after 30 seconds`

I did not find a parameter on 'createChatCompletion' to increase the timeout. How to do it?

edit: By using a DefaultSyncBackend I can adjust the connection timeout: `val backend = DefaultSyncBackend(BackendOptions.connectionTimeout(5.minutes))`

But that does not help in my case, because I need a larger request timeout.

Pull request:
Closes #219

Patch:
diff --git a/README.md b/README.md
index 5066a28d..2d89c94c 100644
--- a/README.md
+++ b/README.md
@@ -211,6 +211,8 @@ object Main extends IOApp {
 
 If you want to make use of other effects, you have to use `OpenAI` and pass the chosen backend directly to `request.send(backend)` function.
 
+To customize a request when using the `OpenAISyncClient`, e.g. by adding a header, or changing the timeout (via request options), you can use the `.customizeRequest` method on the client.
+
 Example below uses `HttpClientCatsBackend` as a backend, make sure to [add it to the dependencies](https://sttp.softwaremill.com/en/latest/backends/catseffect.html)
 or use backend of your choice.
 
diff --git a/core/src/main/scala/sttp/openai/OpenAISyncClient.scala b/core/src/main/scala/sttp/openai/OpenAISyncClient.scala
index 67ab219f..fcc398cf 100644
--- a/core/src/main/scala/sttp/openai/OpenAISyncClient.scala
+++ b/core/src/main/scala/sttp/openai/OpenAISyncClient.scala
@@ -50,7 +50,13 @@ import sttp.openai.requests.vectorstore.file.VectorStoreFileResponseData.{
 
 import java.io.File
 
-class OpenAISyncClient private (authToken: String, backend: SyncBackend, closeClient: Boolean, baseUri: Uri) {
+class OpenAISyncClient private (
+    authToken: String,
+    backend: SyncBackend,
+    closeClient: Boolean,
+    baseUri: Uri,
+    customizeRequest: CustomizeOpenAIRequest
+) {
 
   private val openAI = new OpenAI(authToken, baseUri)
 
@@ -801,20 +807,44 @@ class OpenAISyncClient private (authToken: String, backend: SyncBackend, closeCl
   def deleteVectorStoreFile(vectorStoreId: String, fileId: String): DeleteVectorStoreFileResponse =
     sendOrThrow(openAI.deleteVectorStoreFile(vectorStoreId, fileId))
 
-  /** Closes and releases resources of http client if was not provided explicitly, otherwise works no-op.
-    */
+  /** Closes and releases resources of http client if was not provided explicitly, otherwise works no-op. */
   def close(): Unit = if (closeClient) backend.close() else ()
 
+  /** Specifies a function, which will be applied to the generated request before sending it. If a function has been specified before, it
+    * will be applied before the given one.
+    */
+  def customizeRequest(customize: CustomizeOpenAIRequest): OpenAISyncClient =
+    new OpenAISyncClient(authToken, backend, closeClient, baseUri, customizeRequest.andThen(customize))
+
   private def sendOrThrow[A](request: Request[Either[OpenAIException, A]]): A =
-    request.send(backend).body match {
+    customizeRequest.apply(request).send(backend).body match {
       case Right(value)    => value
       case Left(exception) => throw exception
     }
 }
 
 object OpenAISyncClient {
-  def apply(authToken: String) = new OpenAISyncClient(authToken, DefaultSyncBackend(), true, OpenAIUris.OpenAIBaseUri)
-  def apply(authToken: String, backend: SyncBackend) = new OpenAISyncClient(authToken, backend, false, OpenAIUris.OpenAIBaseUri)
-  def apply(authToken: String, backend: SyncBackend, baseUrl: Uri) = new OpenAISyncClient(authToken, backend, false, baseUrl)
-  def apply(authToken: String, baseUrl: Uri) = new OpenAISyncClient(authToken, DefaultSyncBackend(), true, baseUrl)
+  def apply(authToken: String) =
+    new OpenAISyncClient(authToken, DefaultSyncBackend(), true, OpenAIUris.OpenAIBaseUri, CustomizeOpenAIRequest.Identity)
+  def apply(authToken: String, backend: SyncBackend) =
+    new OpenAISyncClient(authToken, backend, false, OpenAIUris.OpenAIBaseUri, CustomizeOpenAIRequest.Identity)
+  def apply(authToken: String, backend: SyncBackend, baseUrl: Uri) =
+    new OpenAISyncClient(authToken, backend, false, baseUrl, CustomizeOpenAIRequest.Identity)
+  def apply(authToken: String, baseUrl: Uri) =
+    new OpenAISyncClient(authToken, DefaultSyncBackend(), true, baseUrl, CustomizeOpenAIRequest.Identity)
+}
+
+trait CustomizeOpenAIRequest {
+  def apply[A](request: Request[Either[OpenAIException, A]]): Request[Either[OpenAIException, A]]
+
+  def andThen(customize: CustomizeOpenAIRequest): CustomizeOpenAIRequest = new CustomizeOpenAIRequest {
+    override def apply[A](request: Request[Either[OpenAIException, A]]): Request[Either[OpenAIException, A]] =
+      customize.apply(CustomizeOpenAIRequest.this(request))
+  }
+}
+
+object CustomizeOpenAIRequest {
+  val Identity: CustomizeOpenAIRequest = new CustomizeOpenAIRequest {
+    override def apply[A](request: Request[Either[OpenAIException, A]]): Request[Either[OpenAIException, A]] = request
+  }
 }


Test patch:
diff --git a/core/src/test/scala/sttp/openai/client/SyncClientSpec.scala b/core/src/test/scala/sttp/openai/client/SyncClientSpec.scala
index 621feb9f..eec6587f 100644
--- a/core/src/test/scala/sttp/openai/client/SyncClientSpec.scala
+++ b/core/src/test/scala/sttp/openai/client/SyncClientSpec.scala
@@ -9,6 +9,9 @@ import sttp.openai.OpenAIExceptions.OpenAIException
 import sttp.openai.OpenAISyncClient
 import sttp.openai.fixtures.ErrorFixture
 import sttp.openai.requests.models.ModelsResponseData._
+import sttp.openai.CustomizeOpenAIRequest
+import java.util.concurrent.atomic.AtomicReference
+import sttp.client4.testing.ResponseStub
 
 class SyncClientSpec extends AnyFlatSpec with Matchers with EitherValues {
   for ((statusCode, expectedError) <- ErrorFixture.testData)
@@ -21,11 +24,11 @@ class SyncClientSpec extends AnyFlatSpec with Matchers with EitherValues {
       val caught = intercept[OpenAIException](syncClient.getModels)
 
       // then
-      caught.getClass shouldBe expectedError.getClass
-      caught.message shouldBe expectedError.message
-      caught.cause shouldBe expectedError.cause
-      caught.code shouldBe expectedError.code
-      caught.param shouldBe expectedError.param
+      caught.getClass shouldBe expectedError.getClass: Unit
+      caught.message shouldBe expectedError.message: Unit
+      caught.cause shouldBe expectedError.cause: Unit
+      caught.code shouldBe expectedError.code: Unit
+      caught.param shouldBe expectedError.param: Unit
       caught.`type` shouldBe expectedError.`type`
     }
 
@@ -67,4 +70,30 @@ class SyncClientSpec extends AnyFlatSpec with Matchers with EitherValues {
     // when & then
     syncClient.getModels shouldBe deserializedModels
   }
+
+  "Customizing the request" should "be additive" in {
+    // given
+    val capturedRequest = new AtomicReference[GenericRequest[_, _]](null)
+    val syncBackendStub = DefaultSyncBackend.stub.whenAnyRequest.thenRespondF { request =>
+      capturedRequest.set(request)
+      ResponseStub.ok(sttp.openai.fixtures.ModelsGetResponse.singleModelResponse)
+    }
+    val syncClient = OpenAISyncClient(authToken = "test-token", backend = syncBackendStub)
+
+    // when
+    syncClient
+      .customizeRequest(new CustomizeOpenAIRequest {
+        override def apply[A](request: Request[Either[OpenAIException, A]]): Request[Either[OpenAIException, A]] =
+          request.header("X-Test", "test")
+      })
+      .customizeRequest(new CustomizeOpenAIRequest {
+        override def apply[A](request: Request[Either[OpenAIException, A]]): Request[Either[OpenAIException, A]] =
+          request.header("X-Test-2", "test-2")
+      })
+      .getModels: Unit
+
+    // then
+    capturedRequest.get().headers.find(_.is("X-Test")).map(_.value) shouldBe Some("test"): Unit
+    capturedRequest.get().headers.find(_.is("X-Test-2")).map(_.value) shouldBe Some("test-2")
+  }
 }