Repository: node-fetch/node-fetch (js)

Issue:
MaxListenersExceededWarning: Possible EventEmitter memory leak detected.
Hi there,

I think there is a regression in version 3.0.

When I'm using [Custom Agent](https://github.com/node-fetch/node-fetch#custom-agent) (`https`) with `keepAlive: true` option and then just make a bunch of requests. Pretty soon such warnings show up:

> (node:24083) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 data listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 data listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
    at _addListener (node:events:469:17)
    at TLSSocket.addListener (node:events:491:10)
    at TLSSocket.Readable.on (node:internal/streams/readable:876:35)
    at ClientRequest.<anonymous> (.../node_modules/node-fetch/src/index.js:316:10)
    at ClientRequest.emit (node:events:394:28)
    at tickOnSocket (node:_http_client:755:7)
    at onSocketNT (node:_http_client:815:5)
    at processTicksAndRejections (node:internal/process/task_queues:84:21)

The same thing with `http`, just listeners added not to `TLSSocket` but to just `Socket`.

**Reproduction**

Here is a really simple example.

```js
import https from 'node:https'
import fetch from 'node-fetch'

const agent = new https.Agent({ keepAlive: true })

async function start () {
  for (let i = 1; i < 1000; i++) {
    await fetch('https://example.com', { agent })
  }
}

process.on('warning', e => console.warn(e.stack))

start().catch(e => console.error(e))
```

Steps to reproduce the behavior:

1. Run this code with `node-fetch@3` installed and you will start getting warnings.
2. Install `node-fetch@2` as a dependency, run the same code, and boom, no warnings.

**Expected behavior**

Version 2.6.2 does not produce any warning on the same code.
Version 3.0.0 produces warnings.

**Your Environment**

I have been running this on node.js 14 (LTS) and 16 (latest) with the same results.

| software         | version
| ---------------- | -------
| node-fetch       | 3.0.0
| node             | v14.17.6 & v16.9.1
| npm              | 6.14.15 & 7.21.1
| Operating System | MacOS 11.5.2 (20G95) & Docker with alpine linux


Pull request:
fix: Prevent unsubscribe from leaking listeners (#1295)
Since 8eeeec1 it seems listeners have been leaking on keep-alive sockets.

Apparently abort() has been deprecated since v17, using close() the onSocketClose listener is properly removed, and by creating a new onData function I'm able to remove the 'data' listener too.

___

- [ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue
- [ ] I updated ./docs/v3-UPGRADE-GUIDE
- [ ] I updated readme
- [ ] I added unit test(s)

___
- fix #1295


Patch:
diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml
index 17f583a..bad6a5a 100644
--- a/.github/ISSUE_TEMPLATE/config.yml
+++ b/.github/ISSUE_TEMPLATE/config.yml
@@ -1,5 +1,11 @@
 blank_issues_enabled: true
 contact_links:
-  - name: Discord Server 
+  - name: ✨ Feature Request
+    url: https://github.com/node-fetch/node-fetch/discussions/new?category=ideas
+    about: Suggest an idea or feature
+  - name: 🤔 Support or Usage Question
+    url: https://github.com/node-fetch/node-fetch/discussions/new?category=q-a
+    about: Get help using node-fetch
+  - name: Discord Server
     url: https://discord.gg/Zxbndcm
     about: You can alternatively ask any questions here.
diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md
deleted file mode 100644
index cd179d3..0000000
--- a/.github/ISSUE_TEMPLATE/feature-request.md
+++ /dev/null
@@ -1,21 +0,0 @@
----
-name: '✨ Feature Request'
-about: Suggest an idea or feature
-labels: feature
----
-
-**Is your feature request related to a problem? Please describe.**
-
-<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
-
-**Describe the solution you'd like**
-
-<!-- A clear and concise description of what you want to happen. -->
-
-**Describe alternatives you've considered**
-
-<!-- A clear and concise description of any alternative solutions or features you've considered. -->
-
-**Additional context**
-
-<!-- Add any other context or screenshots about the feature request here. -->
diff --git a/.github/ISSUE_TEMPLATE/support-or-usage.md b/.github/ISSUE_TEMPLATE/support-or-usage.md
deleted file mode 100644
index bc8389f..0000000
--- a/.github/ISSUE_TEMPLATE/support-or-usage.md
+++ /dev/null
@@ -1,40 +0,0 @@
----
-name: "\U0001F914 Support or Usage Question"
-about: Get help using node-fetch
-labels: question
----
-
-<!--
-Please read and follow the instructions before submitting an issue:
-
-- Ensure you've read our documentation, especially the [README](https://github.com/node-fetch/node-fetch/blob/master/README.md) since it may contain information that helps you solve your issue.
-- If you're reporting a bug, ensure it isn't already fixed in the latest version of node-fetch.
--->
-
-<!--- Provide a clear and concise description of what the bug is. -->
-
-**Example Code**
-
-<!--- Provide a ode snippet to illustrate your question. -->
-
-```js
-```
-
-**Expected behavior, if applicable**
-
-A clear and concise description of what you expected to happen.
-
-### Your Environment
-
-<!--- Include as many relevant details about the environment you experienced the bug in -->
-
-| software         | version
-| ---------------- | -------
-| node-fetch       |
-| node             |
-| npm              |
-| Operating System |
-
-**Additional context/Screenshots**
-
-Add any other context about the problem here. If applicable, add screenshots to help explain.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 59326bf..96fc199 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -12,12 +12,10 @@
 ___
 
 <!-- Mark the ones you have done and remove unnecessary ones. Add new tasks that fit (like TODOs). -->
-- [ ] I updated ./docs/CHANGELOG.md with a link to this PR or Issue
-- [ ] I updated ./docs/v3-UPGRADE-GUIDE
 - [ ] I updated readme
 - [ ] I added unit test(s)
 
 ___
 
-<!-- Add `- Fixes #_NUMBER_` line for every PR/Issue this PR solves. Do not comma separate them. -->
-- Fixes #000
+<!-- Add `- fix #_NUMBER_` line for every PR/Issue this PR solves. Do not comma separate them. -->
+- fix #000
diff --git a/@types/index.d.ts b/@types/index.d.ts
index c0e78bc..2a482f6 100644
--- a/@types/index.d.ts
+++ b/@types/index.d.ts
@@ -1,7 +1,8 @@
 /// <reference types="node" />
 /// <reference lib="dom" />
 
-import {Agent} from 'http';
+import {RequestOptions} from 'http';
+import {FormData} from 'formdata-polyfill/esm.min.js';
 import {
 	Blob,
 	blobFrom,
@@ -21,6 +22,7 @@ type AbortSignal = {
 export type HeadersInit = Headers | Record<string, string> | Iterable<readonly [string, string]> | Iterable<Iterable<string>>;
 
 export {
+	FormData,
 	Blob,
 	blobFrom,
 	blobFromSync,
@@ -98,7 +100,7 @@ export interface RequestInit {
 	referrerPolicy?: ReferrerPolicy;
 
 	// Node-fetch extensions to the whatwg/fetch spec
-	agent?: Agent | ((parsedUrl: URL) => Agent);
+	agent?: RequestOptions['agent'] | ((parsedUrl: URL) => RequestOptions['agent']);
 	compress?: boolean;
 	counter?: number;
 	follow?: number;
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 4e20528..6d231e8 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -2,7 +2,7 @@
 
 Thank you for considering to contribute to `node-fetch` 💖
 
-Please note that this project is released with a [Contributor Code of Conduct][./CODE_OF_CONDUCT.md].
+Please note that this project is released with a [Contributor Code of Conduct](CODE_OF_CONDUCT.md).
 By participating you agree to abide by its terms.
 
 ## Setup
diff --git a/README.md b/README.md
index a12ad28..37fd608 100644
--- a/README.md
+++ b/README.md
@@ -171,7 +171,7 @@ Using an old version of node-fetch? Check out the following files:
 
 - [2.x to 3.x upgrade guide](docs/v3-UPGRADE-GUIDE.md)
 - [1.x to 2.x upgrade guide](docs/v2-UPGRADE-GUIDE.md)
-- [Changelog](docs/CHANGELOG.md)
+- [Changelog](https://github.com/node-fetch/node-fetch/releases)
 
 ## Common Usage
 
@@ -423,7 +423,7 @@ node-fetch comes with a spec-compliant [FormData] implementations for posting
 multipart/form-data payloads
 
 ```js
-import fetch {FormData, File, fileFrom} from 'node-fetch'
+import fetch, { FormData, File, fileFrom } from 'node-fetch'
 
 const httpbin = 'https://httpbin.org/post'
 const formData = new FormData()
@@ -470,7 +470,7 @@ You may cancel requests with `AbortController`. A suggested implementation is [`
 An example of timing out a request after 150ms could be achieved as the following:
 
 ```js
-import fetch from 'node-fetch';
+import fetch, { AbortError } from 'node-fetch';
 
 // AbortController was added in node v14.17.0 globally
 const AbortController = globalThis.AbortController || await import('abort-controller')
@@ -484,7 +484,7 @@ try {
 	const response = await fetch('https://example.com', {signal: controller.signal});
 	const data = await response.json();
 } catch (error) {
-	if (error instanceof fetch.AbortError) {
+	if (error instanceof AbortError) {
 		console.log('request was aborted');
 	}
 } finally {
@@ -669,7 +669,7 @@ See [options](#fetch-options) for exact meaning of these extensions.
 <small>_(spec-compliant)_</small>
 
 - `input` A string representing a URL, or another `Request` (which will be cloned)
-- `options` [Options][#fetch-options] for the HTTP(S) request
+- `options` [Options](#fetch-options) for the HTTP(S) request
 
 Constructs a new `Request` object. The constructor is identical to that in the [browser](https://developer.mozilla.org/en-US/docs/Web/API/Request/Request).
 
@@ -868,4 +868,4 @@ Thanks to [github/fetch](https://github.com/github/fetch) for providing a solid
 [error-handling.md]: https://github.com/node-fetch/node-fetch/blob/master/docs/ERROR-HANDLING.md
 [FormData]: https://developer.mozilla.org/en-US/docs/Web/API/FormData
 [Blob]: https://developer.mozilla.org/en-US/docs/Web/API/Blob
-[File]: https://developer.mozilla.org/en-US/docs/Web/API/File
\ No newline at end of file
+[File]: https://developer.mozilla.org/en-US/docs/Web/API/File
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
deleted file mode 100644
index a15478e..0000000
--- a/docs/CHANGELOG.md
+++ /dev/null
@@ -1,445 +0,0 @@
-# Changelog
-All notable changes will be recorded here.
-
-The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
-and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
-
-## What's Changed
-* core: update fetch-blob by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1371
-* docs: Fix typo around sending a file by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1381
-* core: (http.request): Cast URL to string before sending it to NodeJS core by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1378
-* core: handle errors from the request body stream by @mdmitry01 in https://github.com/node-fetch/node-fetch/pull/1392
-* core: Better handle wrong redirect header in a response by @tasinet in https://github.com/node-fetch/node-fetch/pull/1387
-* core: Don't use buffer to make a blob by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1402
-* docs: update readme for TS @types/node-fetch by @adamellsworth in https://github.com/node-fetch/node-fetch/pull/1405
-* core: Fix logical operator priority to disallow GET/HEAD with non-empty body by @maxshirshin in https://github.com/node-fetch/node-fetch/pull/1369
-* core: Don't use global buffer by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1422
-* ci: fix main branch by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1429
-* core: use more node: protocol imports by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1428
-* core: Warn when using data by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1421
-* docs: Create SECURITY.md by @JamieSlome in https://github.com/node-fetch/node-fetch/pull/1445
-* core: don't forward secure headers to 3th party by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1449
-
-## New Contributors
-* @mdmitry01 made their first contribution in https://github.com/node-fetch/node-fetch/pull/1392
-* @tasinet made their first contribution in https://github.com/node-fetch/node-fetch/pull/1387
-* @adamellsworth made their first contribution in https://github.com/node-fetch/node-fetch/pull/1405
-* @maxshirshin made their first contribution in https://github.com/node-fetch/node-fetch/pull/1369
-* @JamieSlome made their first contribution in https://github.com/node-fetch/node-fetch/pull/1445
-
-**Full Changelog**: https://github.com/node-fetch/node-fetch/compare/v3.1.0...v3.1.2
-
-## 3.1.0
-
-## What's Changed
-* fix(Body): Discourage form-data and buffer() by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1212
-* fix: Pass url string to http.request by @serverwentdown in https://github.com/node-fetch/node-fetch/pull/1268
-* Fix octocat image link by @lakuapik in https://github.com/node-fetch/node-fetch/pull/1281
-* fix(Body.body): Normalize `Body.body` into a `node:stream` by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/924
-* docs(Headers): Add default Host request header to README.md file by @robertoaceves in https://github.com/node-fetch/node-fetch/pull/1316
-* Update CHANGELOG.md by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1292
-* Add highWaterMark to cloned properties by @davesidious in https://github.com/node-fetch/node-fetch/pull/1162
-* Update README.md to fix HTTPResponseError by @thedanfernandez in https://github.com/node-fetch/node-fetch/pull/1135
-* docs: switch `url` to `URL` by @dhritzkiv in https://github.com/node-fetch/node-fetch/pull/1318
-* fix(types): declare buffer() deprecated by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1345
-* chore: fix lint by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1348
-* refactor: use node: prefix for imports by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1346
-* Bump data-uri-to-buffer from 3.0.1 to 4.0.0 by @dependabot in https://github.com/node-fetch/node-fetch/pull/1319
-* Bump mocha from 8.4.0 to 9.1.3 by @dependabot in https://github.com/node-fetch/node-fetch/pull/1339
-* Referrer and Referrer Policy by @tekwiz in https://github.com/node-fetch/node-fetch/pull/1057
-* Add typing for Response.redirect(url, status) by @c-w in https://github.com/node-fetch/node-fetch/pull/1169
-* chore: Correct stuff in README.md by @Jiralite in https://github.com/node-fetch/node-fetch/pull/1361
-* docs: Improve clarity of "Loading and configuring" by @serverwentdown in https://github.com/node-fetch/node-fetch/pull/1323
-* feat(Body): Added support for `BodyMixin.formData()` and constructing bodies with FormData by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1314
-
-## New Contributors
-* @serverwentdown made their first contribution in https://github.com/node-fetch/node-fetch/pull/1268
-* @lakuapik made their first contribution in https://github.com/node-fetch/node-fetch/pull/1281
-* @robertoaceves made their first contribution in https://github.com/node-fetch/node-fetch/pull/1316
-* @davesidious made their first contribution in https://github.com/node-fetch/node-fetch/pull/1162
-* @thedanfernandez made their first contribution in https://github.com/node-fetch/node-fetch/pull/1135
-* @dhritzkiv made their first contribution in https://github.com/node-fetch/node-fetch/pull/1318
-* @dnalborczyk made their first contribution in https://github.com/node-fetch/node-fetch/pull/1345
-* @dependabot made their first contribution in https://github.com/node-fetch/node-fetch/pull/1319
-* @c-w made their first contribution in https://github.com/node-fetch/node-fetch/pull/1169
-
-**Full Changelog**: https://github.com/node-fetch/node-fetch/compare/v3.0.0...v3.1.0
-
-## v3.0.0
-
-- other: Marking v3 as stable
-- docs: Add example for loading ESM from CommonJS (#1236)
-
-## v3.0.0-beta.10
-
-- **Breaking:** minimum supported Node.js version is now 12.20.
-- **Breaking:** node-fetch is now a pure ESM module.
-- Other: update readme to inform users about ESM.
-- Other: update dependencies.
-
-## v3.0.0-beta.9
-
-**This is an important security release. It is strongly recommended to update as soon as possible.**
-
-- Fix: honor the `size` option after following a redirect.
-
-## v3.0.0-beta.8
-
-- Enhance: remove string-to-arraybuffer (#882).
-- Enhance: remove parted dependency (#883).
-- Fix: export package.json (#908).
-- Fix: minimum Node.js version (#874).
-- Other: fix typo.
-
-## v3.0.0-beta.7
-
-- **Breaking:** minimum supported Node.js version is now 10.17.
-- Enhance: update `fetch-blob`.
-- Enhance: add insecureHTTPParser Parameter (#856).
-- Enhance: drop custom Promises and refactor to `async` functions (#845).
-- Enhance: polyfill `http.validateHeaderName` and `http.validateHeaderValue` (#843).
-- Enhance: should check body _source_ on redirect (#866).
-- Enhance: remove code duplication in custom errors (#842).
-- Enhance: implement form-data encoding (#603).
-- Fix: improve TypeScript types (#841).
-- Fix: data URI handling and drop all URL analysis RegExps (#853).
-- Fix: headers import statement (#859).
-- Fix: correct Node versions were not installed on test matrix (#846).
-- Other: test CommonJS build artifact (#838).
-- Other: create Code of Conduct (#849).
-- Other: readme update.
-
-## v3.0.0-beta.6-exportfix
-
-- Fix: `fetch` function export & declaration, which broke the previous release.
-
-## v3.0.0-beta.6
-
-- **Breaking:** minimum supported Node.js version is now 10.16.
-- **Breaking:** removed `timeout` option.
-- **Breaking:** revamp TypeScript declarations.
-- Enhance: improve coverage.
-- Enhance: drop Babel (while keeping ESM) (#805).
-- Enhance: normalize export (#827).
-- Enhance: remove guard for Stream.Readable.destroy (#824).
-- Enhance: remove custom isArrayBuffer (#822).
-- Enhance: use normal class inheritance instead of Body.mixIn (#828).
-- Enhance: follow xo linter rules more strictly (#829).
-- Enhance: revamp Headers module (#834).
-- Fix: export the `AbortError` class.
-- Fix: example using `file-type` (#804).
-- Fix: settle `consumeBody` promise when the response closes prematurely (#768).
-- Fix: disambiguate timeout behavior for response headers and body (#770).
-- Fix: make sure the default `highWaterMark` equals 16384.
-- Fix: default user agent (#818).
-- Other: readme update.
-- Other: update copyright information.
-
-## v3.0.0-beta.5
-
-> NOTE: Since the previous beta version included serious issues, such as [#749](https://github.com/node-fetch/node-fetch/issues/749), they will now be deprecated.
-
-- Enhance: use built-in AbortSignal for typings.
-- Enhance: compile CJS modules as a seperate set of files.
-- Enhance: add more complete stream download example.
-- Fix: question mark stripped from url when no params are given.
-- Fix: path to tests file in error handling doc.
-- Fix: import URL and URLSearchParams in typings.
-- Fix: Ensure search parameters are included in URL path (#759).
-
-## v3.0.0-beta.2
-
-- Fix: exporting `main` and `types` at the correct path, oops.
-
-## v3.0.0-beta.1
-
-- **Breaking:** minimum supported Node.js version is now 10.
-- Enhance: added new node-fetch-only option: `highWaterMark`.
-- Enhance: `AbortError` now uses a w3c defined message.
-- Enhance: data URI support.
-- Enhance: drop existing blob implementation code and use fetch-blob as dependency instead.
-- Enhance: modernise the code behind `FetchError` and `AbortError`.
-- Enhance: replace deprecated `url.parse()` and `url.replace()` with the new WHATWG's `new URL()`
-- Enhance: allow excluding a `user-agent` in a fetch request by setting it's header to null.
-- Fix: `Response.statusText` no longer sets a default message derived from the HTTP status code.
-- Fix: missing response stream error events.
-- Fix: do not use constructor.name to check object.
-- Fix: convert `Content-Encoding` to lowercase.
-- Fix: propagate size and timeout to cloned response.
-- Other: bundle TypeScript types.
-- Other: replace Rollup with @pika/pack.
-- Other: introduce linting to the project.
-- Other: simplify Travis CI build matrix.
-- Other: dev dependency update.
-- Other: readme update.
-
-
-# 2.x release
-
-## v2.6.1
-
-**This is an important security release. It is strongly recommended to update as soon as possible.**
-
-- Fix: honor the `size` option after following a redirect.
-
-## v2.6.0
-
-- Enhance: `options.agent`, it now accepts a function that returns custom http(s).Agent instance based on current URL, see readme for more information.
-- Fix: incorrect `Content-Length` was returned for stream body in 2.5.0 release; note that `node-fetch` doesn't calculate content length for stream body.
-- Fix: `Response.url` should return empty string instead of `null` by default.
-
-## v2.5.0
-
-- Enhance: `Response` object now includes `redirected` property.
-- Enhance: `fetch()` now accepts third-party `Blob` implementation as body.
-- Other: disable `package-lock.json` generation as we never commit them.
-- Other: dev dependency update.
-- Other: readme update.
-
-## v2.4.1
-
-- Fix: `Blob` import rule for node < 10, as `Readable` isn't a named export.
-
-## v2.4.0
-
-- Enhance: added `Brotli` compression support (using node's zlib).
-- Enhance: updated `Blob` implementation per spec.
-- Fix: set content type automatically for `URLSearchParams`.
-- Fix: `Headers` now reject empty header names.
-- Fix: test cases, as node 12+ no longer accepts invalid header response.
-
-## v2.3.0
-
-- Enhance: added `AbortSignal` support, with README example.
-- Enhance: handle invalid `Location` header during redirect by rejecting them explicitly with `FetchError`.
-- Fix: update `browser.js` to support react-native environment, where `self` isn't available globally.
-
-## v2.2.1
-
-- Fix: `compress` flag shouldn't overwrite existing `Accept-Encoding` header.
-- Fix: multiple `import` rules, where `PassThrough` etc. doesn't have a named export when using node <10 and `--experimental-modules` flag.
-- Other: Better README.
-
-## v2.2.0
-
-- Enhance: Support all `ArrayBuffer` view types
-- Enhance: Support Web Workers
-- Enhance: Support Node.js' `--experimental-modules` mode; deprecate `.es.js` file
-- Fix: Add `__esModule` property to the exports object
-- Other: Better example in README for writing response to a file
-- Other: More tests for Agent
-
-## v2.1.2
-
-- Fix: allow `Body` methods to work on `ArrayBuffer`-backed `Body` objects
-- Fix: reject promise returned by `Body` methods when the accumulated `Buffer` exceeds the maximum size
-- Fix: support custom `Host` headers with any casing
-- Fix: support importing `fetch()` from TypeScript in `browser.js`
-- Fix: handle the redirect response body properly
-
-## v2.1.1
-
-Fix packaging errors in v2.1.0.
-
-## v2.1.0
-
-- Enhance: allow using ArrayBuffer as the `body` of a `fetch()` or `Request`
-- Fix: store HTTP headers of a `Headers` object internally with the given case, for compatibility with older servers that incorrectly treated header names in a case-sensitive manner
-- Fix: silently ignore invalid HTTP headers
-- Fix: handle HTTP redirect responses without a `Location` header just like non-redirect responses
-- Fix: include bodies when following a redirection when appropriate
-
-## v2.0.0
-
-This is a major release. Check [our upgrade guide](https://github.com/node-fetch/node-fetch/blob/master/docs/v2-UPGRADE-GUIDE.md) for an overview on some key differences between v1 and v2.
-
-### General changes
-
-- Major: Node.js 0.10.x and 0.12.x support is dropped
-- Major: `require('node-fetch/lib/response')` etc. is now unsupported; use `require('node-fetch').Response` or ES6 module imports
-- Enhance: start testing on Node.js v4.x, v6.x, v8.x LTS, as well as v9.x stable
-- Enhance: use Rollup to produce a distributed bundle (less memory overhead and faster startup)
-- Enhance: make `Object.prototype.toString()` on Headers, Requests, and Responses return correct class strings
-- Other: rewrite in ES2015 using Babel
-- Other: use Codecov for code coverage tracking
-- Other: update package.json script for npm 5
-- Other: `encoding` module is now optional (alpha.7)
-- Other: expose browser.js through package.json, avoid bundling mishaps (alpha.9)
-- Other: allow TypeScript to `import` node-fetch by exposing default (alpha.9)
-
-### HTTP requests
-
-- Major: overwrite user's `Content-Length` if we can be sure our information is correct (per spec)
-- Fix: errors in a response are caught before the body is accessed
-- Fix: support WHATWG URL objects, created by `whatwg-url` package or `require('url').URL` in Node.js 7+
-
-### Response and Request classes
-
-- Major: `response.text()` no longer attempts to detect encoding, instead always opting for UTF-8 (per spec); use `response.textConverted()` for the v1 behavior
-- Major: make `response.json()` throw error instead of returning an empty object on 204 no-content response (per spec; reverts behavior changed in v1.6.2)
-- Major: internal methods are no longer exposed
-- Major: throw error when a `GET` or `HEAD` Request is constructed with a non-null body (per spec)
-- Enhance: add `response.arrayBuffer()` (also applies to Requests)
-- Enhance: add experimental `response.blob()` (also applies to Requests)
-- Enhance: `URLSearchParams` is now accepted as a body
-- Enhance: wrap `response.json()` json parsing error as `FetchError`
-- Fix: fix Request and Response with `null` body
-
-### Headers class
-
-- Major: remove `headers.getAll()`; make `get()` return all headers delimited by commas (per spec)
-- Enhance: make Headers iterable
-- Enhance: make Headers constructor accept an array of tuples
-- Enhance: make sure header names and values are valid in HTTP
-- Fix: coerce Headers prototype function parameters to strings, where applicable
-
-### Documentation
-
-- Enhance: more comprehensive API docs
-- Enhance: add a list of default headers in README
-
-
-# 1.x release
-
-## Backport releases (v1.7.0 and beyond)
-
-See [changelog on 1.x branch](https://github.com/node-fetch/node-fetch/blob/1.x/CHANGELOG.md) for details.
-
-## v1.6.3
-
-- Enhance: error handling document to explain `FetchError` design
-- Fix: support `form-data` 2.x releases (requires `form-data` >= 2.1.0)
-
-## v1.6.2
-
-- Enhance: minor document update
-- Fix: response.json() returns empty object on 204 no-content response instead of throwing a syntax error
-
-## v1.6.1
-
-- Fix: if `res.body` is a non-stream non-formdata object, we will call `body.toString` and send it as a string
-- Fix: `counter` value is incorrectly set to `follow` value when wrapping Request instance
-- Fix: documentation update
-
-## v1.6.0
-
-- Enhance: added `res.buffer()` api for convenience, it returns body as a Node.js buffer
-- Enhance: better old server support by handling raw deflate response
-- Enhance: skip encoding detection for non-HTML/XML response
-- Enhance: minor document update
-- Fix: HEAD request doesn't need decompression, as body is empty
-- Fix: `req.body` now accepts a Node.js buffer
-
-## v1.5.3
-
-- Fix: handle 204 and 304 responses when body is empty but content-encoding is gzip/deflate
-- Fix: allow resolving response and cloned response in any order
-- Fix: avoid setting `content-length` when `form-data` body use streams
-- Fix: send DELETE request with content-length when body is present
-- Fix: allow any url when calling new Request, but still reject non-http(s) url in fetch
-
-## v1.5.2
-
-- Fix: allow node.js core to handle keep-alive connection pool when passing a custom agent
-
-## v1.5.1
-
-- Fix: redirect mode `manual` should work even when there is no redirection or broken redirection
-
-## v1.5.0
-
-- Enhance: rejected promise now use custom `Error` (thx to @pekeler)
-- Enhance: `FetchError` contains `err.type` and `err.code`, allows for better error handling (thx to @pekeler)
-- Enhance: basic support for redirect mode `manual` and `error`, allows for location header extraction (thx to @jimmywarting for the initial PR)
-
-## v1.4.1
-
-- Fix: wrapping Request instance with FormData body again should preserve the body as-is
-
-## v1.4.0
-
-- Enhance: Request and Response now have `clone` method (thx to @kirill-konshin for the initial PR)
-- Enhance: Request and Response now have proper string and buffer body support (thx to @kirill-konshin)
-- Enhance: Body constructor has been refactored out (thx to @kirill-konshin)
-- Enhance: Headers now has `forEach` method (thx to @tricoder42)
-- Enhance: back to 100% code coverage
-- Fix: better form-data support (thx to @item4)
-- Fix: better character encoding detection under chunked encoding (thx to @dsuket for the initial PR)
-
-## v1.3.3
-
-- Fix: make sure `Content-Length` header is set when body is string for POST/PUT/PATCH requests
-- Fix: handle body stream error, for cases such as incorrect `Content-Encoding` header
-- Fix: when following certain redirects, use `GET` on subsequent request per Fetch Spec
-- Fix: `Request` and `Response` constructors now parse headers input using `Headers`
-
-## v1.3.2
-
-- Enhance: allow auto detect of form-data input (no `FormData` spec on node.js, this is form-data specific feature)
-
-## v1.3.1
-
-- Enhance: allow custom host header to be set (server-side only feature, as it's a forbidden header on client-side)
-
-## v1.3.0
-
-- Enhance: now `fetch.Request` is exposed as well
-
-## v1.2.1
-
-- Enhance: `Headers` now normalized `Number` value to `String`, prevent common mistakes
-
-## v1.2.0
-
-- Enhance: now fetch.Headers and fetch.Response are exposed, making testing easier
-
-## v1.1.2
-
-- Fix: `Headers` should only support `String` and `Array` properties, and ignore others
-
-## v1.1.1
-
-- Enhance: now req.headers accept both plain object and `Headers` instance
-
-## v1.1.0
-
-- Enhance: timeout now also applies to response body (in case of slow response)
-- Fix: timeout is now cleared properly when fetch is done/has failed
-
-## v1.0.6
-
-- Fix: less greedy content-type charset matching
-
-## v1.0.5
-
-- Fix: when `follow = 0`, fetch should not follow redirect
-- Enhance: update tests for better coverage
-- Enhance: code formatting
-- Enhance: clean up doc
-
-## v1.0.4
-
-- Enhance: test iojs support
-- Enhance: timeout attached to socket event only fire once per redirect
-
-## v1.0.3
-
-- Fix: response size limit should reject large chunk
-- Enhance: added character encoding detection for xml, such as rss/atom feed (encoding in DTD)
-
-## v1.0.2
-
-- Fix: added res.ok per spec change
-
-## v1.0.0
-
-- Enhance: better test coverage and doc
-
-
-# 0.x release
-
-## v0.1
-
-- Major: initial public release
-
-[Unreleased]: https://github.com/node-fetch/node-fetch/compare/v3.0.0-beta.10...HEAD
diff --git a/src/body.js b/src/body.js
index b0fe16b..714e27e 100644
--- a/src/body.js
+++ b/src/body.js
@@ -145,8 +145,8 @@ export default class Body {
 	 * @return  Promise
 	 */
 	async json() {
-		const buffer = await consumeBody(this);
-		return JSON.parse(buffer.toString());
+		const text = await this.text();
+		return JSON.parse(text);
 	}
 
 	/**
@@ -156,7 +156,7 @@ export default class Body {
 	 */
 	async text() {
 		const buffer = await consumeBody(this);
-		return buffer.toString();
+		return new TextDecoder().decode(buffer);
 	}
 
 	/**
diff --git a/src/index.js b/src/index.js
index f5f3984..513b052 100644
--- a/src/index.js
+++ b/src/index.js
@@ -387,13 +387,7 @@ function fixResponseChunkedTransferBadEnding(request, errorCallback) {
 			}
 		};
 
-		socket.prependListener('close', onSocketClose);
-
-		request.on('abort', () => {
-			socket.removeListener('close', onSocketClose);
-		});
-
-		socket.on('data', buf => {
+		const onData = buf => {
 			properLastChunkReceived = Buffer.compare(buf.slice(-5), LAST_CHUNK) === 0;
 
 			// Sometimes final 0-length chunk and end of message code are in separate packets
@@ -405,6 +399,14 @@ function fixResponseChunkedTransferBadEnding(request, errorCallback) {
 			}
 
 			previousChunk = buf;
+		};
+
+		socket.prependListener('close', onSocketClose);
+		socket.on('data', onData);
+
+		request.on('close', () => {
+			socket.removeListener('close', onSocketClose);
+			socket.removeListener('data', onData);
 		});
 	});
 }
diff --git a/src/request.js b/src/request.js
index 76d7576..a63f7e6 100644
--- a/src/request.js
+++ b/src/request.js
@@ -57,11 +57,13 @@ export default class Request extends Body {
 		}
 
 		if (parsedURL.username !== '' || parsedURL.password !== '') {
-			throw new TypeError(`${parsedURL} is an url with embedded credentails.`);
+			throw new TypeError(`${parsedURL} is an url with embedded credentials.`);
 		}
 
 		let method = init.method || input.method || 'GET';
-		method = method.toUpperCase();
+		if (/^(delete|get|head|options|post|put)$/i.test(method)) {
+			method = method.toUpperCase();
+		}
 
 		if ('data' in init) {
 			doBadDataWarn();


Test patch:
diff --git a/@types/index.test-d.ts b/@types/index.test-d.ts
index 4b24dcb..6277665 100644
--- a/@types/index.test-d.ts
+++ b/@types/index.test-d.ts
@@ -78,6 +78,8 @@ async function run() {
 	expectAssignable<Body>(request);
 
 	/* eslint-disable no-new */
+	new Request('url', {agent: false});
+
 	new Headers({Header: 'value'});
 	// new Headers(['header', 'value']); // should not work
 	new Headers([['header', 'value']]);
diff --git a/test/request.js b/test/request.js
index b8ba107..03cbe3c 100644
--- a/test/request.js
+++ b/test/request.js
@@ -151,6 +151,24 @@ describe('Request', () => {
 		expect(request.headers.get('a')).to.equal('1');
 	});
 
+	it('should uppercase DELETE, GET, HEAD, OPTIONS, POST and PUT methods', () => {
+		const url = base;
+		for (const method of ['DELETE', 'GET', 'HEAD', 'OPTIONS', 'POST', 'PUT']) {
+			const request = new Request(url, {
+				method: method.toLowerCase()
+			});
+			expect(request.method).to.equal(method);
+		}
+	});
+
+	it('should not uppercase unknown methods and patch', () => {
+		const url = base;
+		for (const method of ['patch', 'chicken']) {
+			const request = new Request(url, {method});
+			expect(request.method).to.equal(method);
+		}
+	});
+
 	it('should support arrayBuffer() method', () => {
 		const url = base;
 		const request = new Request(url, {
diff --git a/test/response.js b/test/response.js
index 714cda1..b515762 100644
--- a/test/response.js
+++ b/test/response.js
@@ -77,6 +77,21 @@ describe('Response', () => {
 		expect(res.headers.get('a')).to.equal('1');
 	});
 
+	it('should decode responses containing BOM to json', async () => {
+		const json = await new Response('\uFEFF{"a":1}').json();
+		expect(json.a).to.equal(1);
+	});
+
+	it('should decode responses containing BOM to text', async () => {
+		const text = await new Response('\uFEFF{"a":1}').text();
+		expect(text).to.equal('{"a":1}');
+	});
+
+	it('should keep BOM when getting raw bytes', async () => {
+		const ab = await new Response('\uFEFF{"a":1}').arrayBuffer();
+		expect(ab.byteLength).to.equal(10);
+	});
+
 	it('should support text() method', () => {
 		const res = new Response('a=1');
 		return res.text().then(result => {