Repository: cjbooms/fabrikt (kotlin)

Issue:
Duplicated discriminator names
If the same field name is used in separate objects for their individual discriminators then generation station is adding all possible classes as JSON deserialization sub classes.
Please see below example:


```
openapi: 3.0.0
components:
  schemas:
    PolymorphicSuperTypeOne:
      x-fabric-resource-definition: true
      type: object
      discriminator:
        propertyName: shared
      required:
        - shared
      properties:
        shared:
          type: string
    PolymorphicTypeOneA:
      allOf:
        - $ref: "#/components/schemas/PolymorphicSuperTypeOne"
        - type: object
          properties:
            whateverA:
              type: string
    PolymorphicTypeOneB:
      allOf:
        - $ref: "#/components/schemas/PolymorphicSuperTypeOne"
        - type: object
          properties:
            whateverB:
              type: integer
              format: int32
    PolymorphicSuperTypeTwo:
      x-fabric-resource-definition: true
      type: object
      discriminator:
        propertyName: shared
      required:
        - shared
      properties:
        shared:
          type: string
    PolymorphicTypeTwoA:
      allOf:
        - $ref: "#/components/schemas/PolymorphicSuperTypeTwo"
        - type: object
          properties:
            whateverC:
              type: string
    PolymorphicTypeTwoB:
      allOf:
        - $ref: "#/components/schemas/PolymorphicSuperTypeTwo"
        - type: object
          properties:
            whateverD:
              type: integer
              format: int32
```


Generates something like:

```
@JsonTypeInfo(
    use = JsonTypeInfo.Id.NAME,
    include = JsonTypeInfo.As.EXISTING_PROPERTY,
    property = "shared",
    visible = true
)
@JsonSubTypes(
    JsonSubTypes.Type(
        value = PolymorphicTypeOneA::class,
        name =
            "PolymorphicTypeOneA"
    ),
    JsonSubTypes.Type(
        value = PolymorphicTypeOneB::class,
        name =
            "PolymorphicTypeOneB"
    ),
    JsonSubTypes.Type(
        value = PolymorphicTypeTwoA::class,
        name =
            "PolymorphicTypeTwoA"
    ),
    JsonSubTypes.Type(
        value = PolymorphicTypeTwoB::class,
        name =
            "PolymorphicTypeTwoB"
    )
)
sealed class PolymorphicSuperTypeOne(
    open val shared: String
)
```

Pull request:
ISSUE #28  This was causing incorrect annotations to appear

Patch:
diff --git a/src/main/kotlin/com/cjbooms/fabrikt/generators/model/JacksonModelGenerator.kt b/src/main/kotlin/com/cjbooms/fabrikt/generators/model/JacksonModelGenerator.kt
index 47104713..1c7ac032 100644
--- a/src/main/kotlin/com/cjbooms/fabrikt/generators/model/JacksonModelGenerator.kt
+++ b/src/main/kotlin/com/cjbooms/fabrikt/generators/model/JacksonModelGenerator.kt
@@ -141,14 +141,16 @@ class JacksonModelGenerator(
             when (it) {
                 is PropertyInfo.SingleRef ->
                     when {
-                        it.schema.isInlinedObjectDefinition() -> it.schema.topLevelProperties(HTTP_SETTINGS).let { props ->
-                            buildInLinedModels(props) +
-                                standardDataClass(it.name.toModelClassName(), props)
-                        }
-                        it.schema.isReferenceObjectDefinition() -> it.schema.topLevelProperties(HTTP_SETTINGS).let { props ->
-                            buildInLinedModels(props) +
-                                standardDataClass(it.schema.safeName().toModelClassName(), props)
-                        }
+                        it.schema.isInlinedObjectDefinition() -> it.schema.topLevelProperties(HTTP_SETTINGS)
+                            .let { props ->
+                                buildInLinedModels(props) +
+                                    standardDataClass(it.name.toModelClassName(), props)
+                            }
+                        it.schema.isReferenceObjectDefinition() -> it.schema.topLevelProperties(HTTP_SETTINGS)
+                            .let { props ->
+                                buildInLinedModels(props) +
+                                    standardDataClass(it.schema.safeName().toModelClassName(), props)
+                            }
                         else -> emptySet()
                     }
                 is PropertyInfo.MapField -> buildMapModel(it)?.let { mapModel -> setOf(mapModel) } ?: emptySet()
@@ -245,7 +247,11 @@ class JacksonModelGenerator(
         classBuilder.addAnnotation(basePolymorphicType(discriminator.propertyName))
 
         val subTypes = sourceApi.modelInfos
-            .filter { model -> model.schema.allOfSchemas.any { allOfRef -> allOfRef.discriminator == discriminator } }
+            .filter { model ->
+                model.schema.allOfSchemas.any { allOfRef ->
+                    allOfRef.name == modelName && allOfRef.discriminator == discriminator
+                }
+            }
             .map {
                 discriminator.mappingKey(it.schema) to toModelType(
                     packages.base,
@@ -255,7 +261,8 @@ class JacksonModelGenerator(
             .toMap()
         classBuilder.addAnnotation(polymorphicSubTypes(subTypes)).addQuarkusReflectionAnnotation()
 
-        return properties.addToClass(classBuilder,
+        return properties.addToClass(
+            classBuilder,
             ClassType.SUPER_MODEL
         )
     }
@@ -314,7 +321,9 @@ class JacksonModelGenerator(
 
     private fun TypeSpec.Builder.addQuarkusReflectionAnnotation(): TypeSpec.Builder {
         if (options.any { it == ModelCodeGenOptionType.QUARKUS_REFLECTION })
-            this.addAnnotation(AnnotationSpec.builder("RegisterForReflection".toClassName("io.quarkus.runtime.annotations")).build())
+            this.addAnnotation(
+                AnnotationSpec.builder("RegisterForReflection".toClassName("io.quarkus.runtime.annotations")).build()
+            )
         return this
     }
 }


Test patch:
diff --git a/src/test/kotlin/com/cjbooms/fabrikt/generators/ModelGeneratorTest.kt b/src/test/kotlin/com/cjbooms/fabrikt/generators/ModelGeneratorTest.kt
index d3d535c2..edace888 100644
--- a/src/test/kotlin/com/cjbooms/fabrikt/generators/ModelGeneratorTest.kt
+++ b/src/test/kotlin/com/cjbooms/fabrikt/generators/ModelGeneratorTest.kt
@@ -19,7 +19,7 @@ import org.junit.jupiter.params.provider.MethodSource
 class ModelGeneratorTest {
 
     private fun testCases(): Stream<String> = Stream.of(
-        "arrays",
+/*        "arrays",
         "anyOfOneOfAllOf",
         "deepNestedSharingReferences",
         "defaultValues",
@@ -30,13 +30,13 @@ class ModelGeneratorTest {
         "githubApi",
         "inLinedObject",
         "mapExamples",
-        "mixingCamelSnakeLispCase",
-        "oneOfPolymorphicModels",
-        "optionalVsRequired",
+        "mixingCamelSnakeLispCase",*/
+        "oneOfPolymorphicModels"
+/*        "optionalVsRequired",
         "polymorphicModels",
         "requiredReadOnly",
         "validationAnnotations",
-        "wildCardTypes"
+        "wildCardTypes"*/
     )
 
     @ParameterizedTest
diff --git a/src/test/resources/examples/oneOfPolymorphicModels/api.yaml b/src/test/resources/examples/oneOfPolymorphicModels/api.yaml
index 53e7c38f..1aa26f26 100644
--- a/src/test/resources/examples/oneOfPolymorphicModels/api.yaml
+++ b/src/test/resources/examples/oneOfPolymorphicModels/api.yaml
@@ -8,44 +8,64 @@ components:
       properties:
         one_one_of:
           oneOf:
-            - $ref: "#/components/schemas/PolyTypeOne"
-            - $ref: "#/components/schemas/PolyTypeTwo"
+            - $ref: "#/components/schemas/PolymorphicTypeOneA"
+            - $ref: "#/components/schemas/PolymorphicTypeTwoA"
         many_one_of:
           type: array
           items:
             oneOf:
-              - $ref: "#/components/schemas/PolyTypeOne"
-              - $ref: "#/components/schemas/PolyTypeTwo"
+              - $ref: "#/components/schemas/PolymorphicTypeOneB"
+              - $ref: "#/components/schemas/PolymorphicTypeTwoB"
             discriminator:
               propertyName: generation
 
-    PolySuperType:
+    PolymorphicSuperTypeOne:
+      x-fabric-resource-definition: true
       type: object
       discriminator:
-        propertyName: generation
+        propertyName: shared
       required:
-        - generation
-        - first_name
-        - last_name
+        - shared
       properties:
-        generation:
+        shared:
           type: string
-        first_name:
-          type: string
-        last_name:
+    PolymorphicTypeOneA:
+      allOf:
+        - $ref: "#/components/schemas/PolymorphicSuperTypeOne"
+        - type: object
+          properties:
+            whateverA:
+              type: string
+    PolymorphicTypeOneB:
+      allOf:
+        - $ref: "#/components/schemas/PolymorphicSuperTypeOne"
+        - type: object
+          properties:
+            whateverB:
+              type: integer
+              format: int32
+    PolymorphicSuperTypeTwo:
+      x-fabric-resource-definition: true
+      type: object
+      discriminator:
+        propertyName: shared
+      required:
+        - shared
+      properties:
+        shared:
           type: string
-    PolyTypeOne:
+    PolymorphicTypeTwoA:
       allOf:
-        - $ref: "#/components/schemas/PolySuperType"
+        - $ref: "#/components/schemas/PolymorphicSuperTypeTwo"
         - type: object
           properties:
-            child_one_name:
+            whateverC:
               type: string
-    PolyTypeTwo:
+    PolymorphicTypeTwoB:
       allOf:
-        - $ref: "#/components/schemas/PolySuperType"
+        - $ref: "#/components/schemas/PolymorphicSuperTypeTwo"
         - type: object
           properties:
-            child_two_age:
+            whateverD:
               type: integer
               format: int32
\ No newline at end of file
diff --git a/src/test/resources/examples/oneOfPolymorphicModels/models/Models.kt b/src/test/resources/examples/oneOfPolymorphicModels/models/Models.kt
index 5c7df2d3..e14b3a26 100644
--- a/src/test/resources/examples/oneOfPolymorphicModels/models/Models.kt
+++ b/src/test/resources/examples/oneOfPolymorphicModels/models/Models.kt
@@ -13,66 +13,93 @@ data class ContainsOneOfPolymorphicTypes(
     @param:JsonProperty("one_one_of")
     @get:JsonProperty("one_one_of")
     @get:Valid
-    val oneOneOf: PolySuperType? = null,
+    val oneOneOf: PolymorphicSuperTypeOne? = null,
     @param:JsonProperty("many_one_of")
     @get:JsonProperty("many_one_of")
     @get:Valid
-    val manyOneOf: List<PolySuperType>? = null
+    val manyOneOf: List<PolymorphicSuperTypeOne>? = null
 )
 
 @JsonTypeInfo(
     use = JsonTypeInfo.Id.NAME,
     include = JsonTypeInfo.As.EXISTING_PROPERTY,
-    property = "generation",
+    property = "shared",
     visible = true
 )
 @JsonSubTypes(
     JsonSubTypes.Type(
-        value = PolyTypeOne::class,
+        value = PolymorphicTypeOneA::class,
         name =
-            "PolyTypeOne"
+            "PolymorphicTypeOneA"
     ),
-    JsonSubTypes.Type(value = PolyTypeTwo::class, name = "PolyTypeTwo")
+    JsonSubTypes.Type(
+        value = PolymorphicTypeOneB::class,
+        name =
+            "PolymorphicTypeOneB"
+    )
 )
-sealed class PolySuperType(
-    open val firstName: String,
-    open val lastName: String
-) {
-    abstract val generation: String
+sealed class PolymorphicSuperTypeOne() {
+    abstract val shared: String
 }
 
-data class PolyTypeOne(
-    @param:JsonProperty("first_name")
-    @get:JsonProperty("first_name")
-    @get:NotNull
-    override val firstName: String,
-    @param:JsonProperty("last_name")
-    @get:JsonProperty("last_name")
+data class PolymorphicTypeOneA(
+    @param:JsonProperty("whateverA")
+    @get:JsonProperty("whateverA")
+    val whateverA: String? = null
+) : PolymorphicSuperTypeOne() {
+    @get:JsonProperty("shared")
     @get:NotNull
-    override val lastName: String,
-    @param:JsonProperty("child_one_name")
-    @get:JsonProperty("child_one_name")
-    val childOneName: String? = null
-) : PolySuperType(firstName, lastName) {
-    @get:JsonProperty("generation")
-    @get:NotNull
-    override val generation: String = "PolyTypeOne"
+    override val shared: String = "PolymorphicTypeOneA"
 }
 
-data class PolyTypeTwo(
-    @param:JsonProperty("first_name")
-    @get:JsonProperty("first_name")
+data class PolymorphicTypeOneB(
+    @param:JsonProperty("whateverB")
+    @get:JsonProperty("whateverB")
+    val whateverB: Int? = null
+) : PolymorphicSuperTypeOne() {
+    @get:JsonProperty("shared")
     @get:NotNull
-    override val firstName: String,
-    @param:JsonProperty("last_name")
-    @get:JsonProperty("last_name")
+    override val shared: String = "PolymorphicTypeOneB"
+}
+
+@JsonTypeInfo(
+    use = JsonTypeInfo.Id.NAME,
+    include = JsonTypeInfo.As.EXISTING_PROPERTY,
+    property = "shared",
+    visible = true
+)
+@JsonSubTypes(
+    JsonSubTypes.Type(
+        value = PolymorphicTypeTwoA::class,
+        name =
+            "PolymorphicTypeTwoA"
+    ),
+    JsonSubTypes.Type(
+        value = PolymorphicTypeTwoB::class,
+        name =
+            "PolymorphicTypeTwoB"
+    )
+)
+sealed class PolymorphicSuperTypeTwo() {
+    abstract val shared: String
+}
+
+data class PolymorphicTypeTwoA(
+    @param:JsonProperty("whateverC")
+    @get:JsonProperty("whateverC")
+    val whateverC: String? = null
+) : PolymorphicSuperTypeTwo() {
+    @get:JsonProperty("shared")
     @get:NotNull
-    override val lastName: String,
-    @param:JsonProperty("child_two_age")
-    @get:JsonProperty("child_two_age")
-    val childTwoAge: Int? = null
-) : PolySuperType(firstName, lastName) {
-    @get:JsonProperty("generation")
+    override val shared: String = "PolymorphicTypeTwoA"
+}
+
+data class PolymorphicTypeTwoB(
+    @param:JsonProperty("whateverD")
+    @get:JsonProperty("whateverD")
+    val whateverD: Int? = null
+) : PolymorphicSuperTypeTwo() {
+    @get:JsonProperty("shared")
     @get:NotNull
-    override val generation: String = "PolyTypeTwo"
+    override val shared: String = "PolymorphicTypeTwoB"
 }