Repository: gitify-app/gitify (ts)

Issue:
Default Settings: update to enable detailedNotifications
### 📝 Provide a description of the new feature

With the improvements around error handling, and upcoming improvements around #1124, we should be able to default `detailedNotifications` to `true`

### ➕ Additional Information

_No response_

Pull request:
feat(settings): enable `detailed notifications` by default
I think we're in a good space to default `detailed notifications` on, which will provide users with a richer initial experience.


Closes #1125 

Patch:
diff --git a/src/__mocks__/mock-state.ts b/src/__mocks__/mock-state.ts
index 6594be1d..4a930d0e 100644
--- a/src/__mocks__/mock-state.ts
+++ b/src/__mocks__/mock-state.ts
@@ -15,7 +15,7 @@ export const mockSettings: SettingsState = {
   showNotificationsCountInTray: false,
   openAtStartup: false,
   theme: Theme.SYSTEM,
-  detailedNotifications: false,
+  detailedNotifications: true,
   markAsDoneOnOpen: false,
   showAccountHostname: false,
   delayNotificationState: false,
diff --git a/src/context/App.tsx b/src/context/App.tsx
index 45eacda1..77c32fe2 100644
--- a/src/context/App.tsx
+++ b/src/context/App.tsx
@@ -41,7 +41,7 @@ export const defaultSettings: SettingsState = {
   showNotificationsCountInTray: false,
   openAtStartup: false,
   theme: Theme.SYSTEM,
-  detailedNotifications: false,
+  detailedNotifications: true,
   markAsDoneOnOpen: false,
   showAccountHostname: false,
   delayNotificationState: false,


Test patch:
diff --git a/src/context/App.test.tsx b/src/context/App.test.tsx
index f687aeed..bf8c297f 100644
--- a/src/context/App.test.tsx
+++ b/src/context/App.test.tsx
@@ -330,7 +330,7 @@ describe('context/App.tsx', () => {
         showNotificationsCountInTray: false,
         openAtStartup: false,
         theme: 'SYSTEM',
-        detailedNotifications: false,
+        detailedNotifications: true,
         markAsDoneOnOpen: false,
         showAccountHostname: false,
         delayNotificationState: false,
@@ -375,7 +375,7 @@ describe('context/App.tsx', () => {
         showNotificationsCountInTray: false,
         openAtStartup: true,
         theme: 'SYSTEM',
-        detailedNotifications: false,
+        detailedNotifications: true,
         markAsDoneOnOpen: false,
         showAccountHostname: false,
         delayNotificationState: false,
diff --git a/src/hooks/useNotifications.test.ts b/src/hooks/useNotifications.test.ts
index 11b96b29..29e4be3b 100644
--- a/src/hooks/useNotifications.test.ts
+++ b/src/hooks/useNotifications.test.ts
@@ -34,7 +34,10 @@ describe('hooks/useNotifications.ts', () => {
         const { result } = renderHook(() => useNotifications());
 
         act(() => {
-          result.current.fetchNotifications(mockAccounts, mockSettings);
+          result.current.fetchNotifications(mockAccounts, {
+            ...mockSettings,
+            detailedNotifications: false,
+          });
         });
 
         expect(result.current.status).toBe('loading');
@@ -116,7 +119,10 @@ describe('hooks/useNotifications.ts', () => {
         const { result } = renderHook(() => useNotifications());
 
         act(() => {
-          result.current.fetchNotifications(accounts, mockSettings);
+          result.current.fetchNotifications(accounts, {
+            ...mockSettings,
+            detailedNotifications: false,
+          });
         });
 
         await waitFor(() => {
@@ -179,7 +185,10 @@ describe('hooks/useNotifications.ts', () => {
         const { result } = renderHook(() => useNotifications());
 
         act(() => {
-          result.current.fetchNotifications(accounts, mockSettings);
+          result.current.fetchNotifications(accounts, {
+            ...mockSettings,
+            detailedNotifications: false,
+          });
         });
 
         await waitFor(() => {
@@ -417,7 +426,10 @@ describe('hooks/useNotifications.ts', () => {
       const { result } = renderHook(() => useNotifications());
 
       act(() => {
-        result.current.fetchNotifications(mockAccounts, mockSettings);
+        result.current.fetchNotifications(mockAccounts, {
+          ...mockSettings,
+          detailedNotifications: false,
+        });
       });
 
       await waitFor(() => {
diff --git a/src/routes/Settings.test.tsx b/src/routes/Settings.test.tsx
index 9f256605..3484ef88 100644
--- a/src/routes/Settings.test.tsx
+++ b/src/routes/Settings.test.tsx
@@ -113,7 +113,10 @@ describe('routes/Settings.tsx', () => {
       fireEvent.click(screen.getByLabelText('Detailed notifications'));
 
       expect(updateSetting).toHaveBeenCalledTimes(1);
-      expect(updateSetting).toHaveBeenCalledWith('detailedNotifications', true);
+      expect(updateSetting).toHaveBeenCalledWith(
+        'detailedNotifications',
+        false,
+      );
     });
   });
 
diff --git a/src/routes/__snapshots__/Settings.test.tsx.snap b/src/routes/__snapshots__/Settings.test.tsx.snap
index ad020946..212b0003 100644
--- a/src/routes/__snapshots__/Settings.test.tsx.snap
+++ b/src/routes/__snapshots__/Settings.test.tsx.snap
@@ -133,6 +133,7 @@ exports[`routes/Settings.tsx General should render itself & its children 1`] = `
             class="flex items-center h-5"
           >
             <input
+              checked=""
               class="focus:ring-indigo-500 h-4 w-4 text-indigo-600 border-gray-300 rounded"
               id="detailedNotifications"
               type="checkbox"
@@ -266,7 +267,6 @@ exports[`routes/Settings.tsx General should render itself & its children 1`] = `
             <input
               checked=""
               class="focus:ring-indigo-500 h-4 w-4 text-indigo-600 border-gray-300 rounded"
-              disabled=""
               id="showBots"
               type="checkbox"
             />
@@ -277,7 +277,6 @@ exports[`routes/Settings.tsx General should render itself & its children 1`] = `
             <label
               class="font-medium text-gray-700 dark:text-gray-200"
               for="showBots"
-              style="text-decoration: line-through;"
             >
               Show notifications from Bot accounts
               <span