Repository: ember-cli/ember-cli (js)

Issue:
Generating new app includes deprecated @types/eslint__js stub
When generating a typescript app with the latest ember-cli, the dependency ` "@types/eslint__js": "^8.42.3",` is included, which is deprecated because eslint provides it's own type definitions. I think this dependency can just be removed? If I do that in my newly generated app the typescript check still passes.

Steps to recreate:

```
npx ember-cli@latest new test-app --typescript --pnpm
```

Pull request:
[BUGFIX] Remove deprecated `@types/eslint__js` dependency from `app` blueprint
Fixes #10683 

Patch:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 12a7d0fab..1c06a187b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,18 +1,5 @@
 # ember-cli Changelog
 
-## v6.4.0-beta.1
-
-#### Blueprint Changes
-
-- [`ember new` diff](https://github.com/ember-cli/ember-new-output/compare/v6.4.0-beta.0...v6.4.0-beta.1)
-- [`ember addon` diff](https://github.com/ember-cli/ember-addon-output/compare/v6.4.0-beta.0...v6.4.0-beta.1)
-
-#### Changelog
-
-- [#10685](https://github.com/ember-cli/ember-cli/pull/10685) Add configuration to ember-cli-build to opt new projects out of the deprecated behavior of the Store class extending EmberObject [@kategengler](https://github.com/kategengler)
-
-Thank you to all who took the time to contribute!
-
 ## v6.4.0-beta.0
 
 #### Blueprint Changes
@@ -30,19 +17,6 @@ Thank you to all who took the time to contribute!
 
 Thank you to all who took the time to contribute!
 
-## v6.3.1
-
-#### Blueprint Changes
-
-- [`ember new` diff](https://github.com/ember-cli/ember-new-output/compare/v6.3.0...v6.3.1)
-- [`ember addon` diff](https://github.com/ember-cli/ember-addon-output/compare/v6.3.0...v6.3.1)
-
-#### Changelog
-
-- [#10685](https://github.com/ember-cli/ember-cli/pull/10685) Add configuration to ember-cli-build to opt new projects out of the deprecated behavior of the Store class extending EmberObject [@kategengler](https://github.com/kategengler)
-
-Thank you to all who took the time to contribute!
-
 ## v6.3.0
 
 #### Blueprint Changes
diff --git a/blueprints/app/files/ember-cli-build.js b/blueprints/app/files/ember-cli-build.js
index 4680730da..00131bf19 100644
--- a/blueprints/app/files/ember-cli-build.js
+++ b/blueprints/app/files/ember-cli-build.js
@@ -4,16 +4,7 @@ const EmberApp = require('ember-cli/lib/broccoli/ember-app');
 
 module.exports = function (defaults) {
   const app = new EmberApp(defaults, {
-    <% if (emberData) {%>emberData: {
-      deprecations: {
-        // New projects can safely leave this deprecation disabled.
-        // If upgrading, to opt-into the deprecated behavior, set this to true and then follow:
-        // https://deprecations.emberjs.com/id/ember-data-deprecate-store-extends-ember-object
-        // before upgrading to Ember Data 6.0
-        DEPRECATE_STORE_EXTENDS_EMBER_OBJECT: false,
-      },
-    },
-    <% } %><% if (typescript) {%>'ember-cli-babel': { enableTypeScriptTransform: true },
+    <% if (typescript) {%>'ember-cli-babel': { enableTypeScriptTransform: true },
 
     <% } %>// Add options here
   });
diff --git a/blueprints/app/files/package.json b/blueprints/app/files/package.json
index afeff16d0..f0618043b 100644
--- a/blueprints/app/files/package.json
+++ b/blueprints/app/files/package.json
@@ -54,7 +54,6 @@
     "@glint/environment-ember-template-imports": "^1.5.2",
     "@glint/template": "^1.5.2",
     "@tsconfig/ember": "^3.0.10",
-    "@types/eslint__js": "^8.42.3",
     "@types/qunit": "^2.19.12",
     "@types/rsvp": "^4.0.9<% if (emberData) {%>",
     "@warp-drive/core-types": "~0.0.2<% }} %>",
diff --git a/package.json b/package.json
index a3af25bfc..01386b23f 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ember-cli",
-  "version": "6.4.0-beta.1",
+  "version": "6.4.0-beta.0",
   "description": "Command line tool for developing ambitious ember.js apps",
   "keywords": [
     "app",


Test patch:
diff --git a/tests/acceptance/new-test.js b/tests/acceptance/new-test.js
index 59a2a0162..7b27e0395 100644
--- a/tests/acceptance/new-test.js
+++ b/tests/acceptance/new-test.js
@@ -90,7 +90,7 @@ describe('Acceptance: ember new', function () {
     confirmBlueprintedForDir('blueprints/app', 'bar');
   });
 
-  it('ember new @foo/bar, when parent directory hierarchy contains `foo`', async function () {
+  it('ember new @foo/bar, when parent directory heirarchy contains `foo`', async function () {
     let scopedDirectoryPath = path.join(process.cwd(), 'foo', 'packages');
     fs.mkdirsSync(scopedDirectoryPath);
     process.chdir(scopedDirectoryPath);
@@ -722,7 +722,6 @@ describe('Acceptance: ember new', function () {
 
       checkFileWithJSONReplacement(fixturePath, 'config/ember-cli-update.json', 'packages[0].version', currentVersion);
       checkFileWithJSONReplacement(fixturePath, 'package.json', 'devDependencies.ember-cli', `~${currentVersion}`);
-      checkEmberCLIBuild(fixturePath, 'ember-cli-build.js');
     });
 
     it('app + typescript + no-ember-data', async function () {
@@ -738,7 +737,6 @@ describe('Acceptance: ember new', function () {
       checkFile('tsconfig.json', path.join(__dirname, '../fixtures', fixturePath, 'tsconfig.json'));
       checkFileWithJSONReplacement(fixturePath, 'config/ember-cli-update.json', 'packages[0].version', currentVersion);
       checkFileWithJSONReplacement(fixturePath, 'package.json', 'devDependencies.ember-cli', `~${currentVersion}`);
-      checkEmberCLIBuild(fixturePath, 'ember-cli-build.js');
     });
   });
 });
diff --git a/tests/fixtures/addon/typescript/package.json b/tests/fixtures/addon/typescript/package.json
index 9b9686a16..79f337f4b 100644
--- a/tests/fixtures/addon/typescript/package.json
+++ b/tests/fixtures/addon/typescript/package.json
@@ -67,7 +67,6 @@
     "@glint/environment-ember-template-imports": "^1.5.2",
     "@glint/template": "^1.5.2",
     "@tsconfig/ember": "^3.0.10",
-    "@types/eslint__js": "^8.42.3",
     "@types/qunit": "^2.19.12",
     "@types/rsvp": "^4.0.9",
     "broccoli-asset-rev": "^3.0.0",
diff --git a/tests/fixtures/app/defaults/ember-cli-build.js b/tests/fixtures/app/defaults/ember-cli-build.js
index 0582fad75..ed991bd98 100644
--- a/tests/fixtures/app/defaults/ember-cli-build.js
+++ b/tests/fixtures/app/defaults/ember-cli-build.js
@@ -4,15 +4,6 @@ const EmberApp = require('ember-cli/lib/broccoli/ember-app');
 
 module.exports = function (defaults) {
   const app = new EmberApp(defaults, {
-    emberData: {
-      deprecations: {
-        // New projects can safely leave this deprecation disabled.
-        // If upgrading, to opt-into the deprecated behavior, set this to true and then follow:
-        // https://deprecations.emberjs.com/id/ember-data-deprecate-store-extends-ember-object
-        // before upgrading to Ember Data 6.0
-        DEPRECATE_STORE_EXTENDS_EMBER_OBJECT: false,
-      },
-    },
     // Add options here
   });
 
diff --git a/tests/fixtures/app/embroider-no-ember-data/ember-cli-build.js b/tests/fixtures/app/embroider-no-ember-data/ember-cli-build.js
deleted file mode 100644
index f7f127db3..000000000
--- a/tests/fixtures/app/embroider-no-ember-data/ember-cli-build.js
+++ /dev/null
@@ -1,22 +0,0 @@
-'use strict';
-
-const EmberApp = require('ember-cli/lib/broccoli/ember-app');
-
-module.exports = function (defaults) {
-  const app = new EmberApp(defaults, {
-    // Add options here
-  });
-
-  const { Webpack } = require('@embroider/webpack');
-  return require('@embroider/compat').compatBuild(app, Webpack, {
-    staticAddonTestSupportTrees: true,
-    staticAddonTrees: true,
-    staticEmberSource: true,
-    staticInvokables: true,
-    skipBabel: [
-      {
-        package: 'qunit',
-      },
-    ],
-  });
-};
diff --git a/tests/fixtures/app/embroider/ember-cli-build.js b/tests/fixtures/app/embroider/ember-cli-build.js
index 3c70314ae..f7f127db3 100644
--- a/tests/fixtures/app/embroider/ember-cli-build.js
+++ b/tests/fixtures/app/embroider/ember-cli-build.js
@@ -4,15 +4,6 @@ const EmberApp = require('ember-cli/lib/broccoli/ember-app');
 
 module.exports = function (defaults) {
   const app = new EmberApp(defaults, {
-    emberData: {
-      deprecations: {
-        // New projects can safely leave this deprecation disabled.
-        // If upgrading, to opt-into the deprecated behavior, set this to true and then follow:
-        // https://deprecations.emberjs.com/id/ember-data-deprecate-store-extends-ember-object
-        // before upgrading to Ember Data 6.0
-        DEPRECATE_STORE_EXTENDS_EMBER_OBJECT: false,
-      },
-    },
     // Add options here
   });
 
diff --git a/tests/fixtures/app/no-ember-data/ember-cli-build.js b/tests/fixtures/app/no-ember-data/ember-cli-build.js
deleted file mode 100644
index ed991bd98..000000000
--- a/tests/fixtures/app/no-ember-data/ember-cli-build.js
+++ /dev/null
@@ -1,11 +0,0 @@
-'use strict';
-
-const EmberApp = require('ember-cli/lib/broccoli/ember-app');
-
-module.exports = function (defaults) {
-  const app = new EmberApp(defaults, {
-    // Add options here
-  });
-
-  return app.toTree();
-};
diff --git a/tests/fixtures/app/typescript-embroider-no-ember-data/ember-cli-build.js b/tests/fixtures/app/typescript-embroider-no-ember-data/ember-cli-build.js
deleted file mode 100644
index ec43ac11a..000000000
--- a/tests/fixtures/app/typescript-embroider-no-ember-data/ember-cli-build.js
+++ /dev/null
@@ -1,24 +0,0 @@
-'use strict';
-
-const EmberApp = require('ember-cli/lib/broccoli/ember-app');
-
-module.exports = function (defaults) {
-  const app = new EmberApp(defaults, {
-    'ember-cli-babel': { enableTypeScriptTransform: true },
-
-    // Add options here
-  });
-
-  const { Webpack } = require('@embroider/webpack');
-  return require('@embroider/compat').compatBuild(app, Webpack, {
-    staticAddonTestSupportTrees: true,
-    staticAddonTrees: true,
-    staticEmberSource: true,
-    staticInvokables: true,
-    skipBabel: [
-      {
-        package: 'qunit',
-      },
-    ],
-  });
-};
diff --git a/tests/fixtures/app/typescript-embroider-no-ember-data/package.json b/tests/fixtures/app/typescript-embroider-no-ember-data/package.json
index 0911d5310..5ed655097 100644
--- a/tests/fixtures/app/typescript-embroider-no-ember-data/package.json
+++ b/tests/fixtures/app/typescript-embroider-no-ember-data/package.json
@@ -44,7 +44,6 @@
     "@glint/environment-ember-template-imports": "^1.5.2",
     "@glint/template": "^1.5.2",
     "@tsconfig/ember": "^3.0.10",
-    "@types/eslint__js": "^8.42.3",
     "@types/qunit": "^2.19.12",
     "@types/rsvp": "^4.0.9",
     "broccoli-asset-rev": "^3.0.0",
diff --git a/tests/fixtures/app/typescript-embroider/ember-cli-build.js b/tests/fixtures/app/typescript-embroider/ember-cli-build.js
index 21f49d2f1..ec43ac11a 100644
--- a/tests/fixtures/app/typescript-embroider/ember-cli-build.js
+++ b/tests/fixtures/app/typescript-embroider/ember-cli-build.js
@@ -4,15 +4,6 @@ const EmberApp = require('ember-cli/lib/broccoli/ember-app');
 
 module.exports = function (defaults) {
   const app = new EmberApp(defaults, {
-    emberData: {
-      deprecations: {
-        // New projects can safely leave this deprecation disabled.
-        // If upgrading, to opt-into the deprecated behavior, set this to true and then follow:
-        // https://deprecations.emberjs.com/id/ember-data-deprecate-store-extends-ember-object
-        // before upgrading to Ember Data 6.0
-        DEPRECATE_STORE_EXTENDS_EMBER_OBJECT: false,
-      },
-    },
     'ember-cli-babel': { enableTypeScriptTransform: true },
 
     // Add options here
diff --git a/tests/fixtures/app/typescript-embroider/package.json b/tests/fixtures/app/typescript-embroider/package.json
index fe146aa29..82b4390c7 100644
--- a/tests/fixtures/app/typescript-embroider/package.json
+++ b/tests/fixtures/app/typescript-embroider/package.json
@@ -54,7 +54,6 @@
     "@glint/environment-ember-template-imports": "^1.5.2",
     "@glint/template": "^1.5.2",
     "@tsconfig/ember": "^3.0.10",
-    "@types/eslint__js": "^8.42.3",
     "@types/qunit": "^2.19.12",
     "@types/rsvp": "^4.0.9",
     "@warp-drive/core-types": "~0.0.2",
diff --git a/tests/fixtures/app/typescript-no-ember-data/ember-cli-build.js b/tests/fixtures/app/typescript-no-ember-data/ember-cli-build.js
deleted file mode 100644
index 12f8dea58..000000000
--- a/tests/fixtures/app/typescript-no-ember-data/ember-cli-build.js
+++ /dev/null
@@ -1,13 +0,0 @@
-'use strict';
-
-const EmberApp = require('ember-cli/lib/broccoli/ember-app');
-
-module.exports = function (defaults) {
-  const app = new EmberApp(defaults, {
-    'ember-cli-babel': { enableTypeScriptTransform: true },
-
-    // Add options here
-  });
-
-  return app.toTree();
-};
diff --git a/tests/fixtures/app/typescript-no-ember-data/package.json b/tests/fixtures/app/typescript-no-ember-data/package.json
index 3e69998df..c597425bf 100644
--- a/tests/fixtures/app/typescript-no-ember-data/package.json
+++ b/tests/fixtures/app/typescript-no-ember-data/package.json
@@ -41,7 +41,6 @@
     "@glint/environment-ember-template-imports": "^1.5.2",
     "@glint/template": "^1.5.2",
     "@tsconfig/ember": "^3.0.10",
-    "@types/eslint__js": "^8.42.3",
     "@types/qunit": "^2.19.12",
     "@types/rsvp": "^4.0.9",
     "broccoli-asset-rev": "^3.0.0",
diff --git a/tests/fixtures/app/typescript/ember-cli-build.js b/tests/fixtures/app/typescript/ember-cli-build.js
index d05950bb4..12f8dea58 100644
--- a/tests/fixtures/app/typescript/ember-cli-build.js
+++ b/tests/fixtures/app/typescript/ember-cli-build.js
@@ -4,15 +4,6 @@ const EmberApp = require('ember-cli/lib/broccoli/ember-app');
 
 module.exports = function (defaults) {
   const app = new EmberApp(defaults, {
-    emberData: {
-      deprecations: {
-        // New projects can safely leave this deprecation disabled.
-        // If upgrading, to opt-into the deprecated behavior, set this to true and then follow:
-        // https://deprecations.emberjs.com/id/ember-data-deprecate-store-extends-ember-object
-        // before upgrading to Ember Data 6.0
-        DEPRECATE_STORE_EXTENDS_EMBER_OBJECT: false,
-      },
-    },
     'ember-cli-babel': { enableTypeScriptTransform: true },
 
     // Add options here
diff --git a/tests/fixtures/app/typescript/package.json b/tests/fixtures/app/typescript/package.json
index 0e38d8a53..0f84e0e45 100644
--- a/tests/fixtures/app/typescript/package.json
+++ b/tests/fixtures/app/typescript/package.json
@@ -51,7 +51,6 @@
     "@glint/environment-ember-template-imports": "^1.5.2",
     "@glint/template": "^1.5.2",
     "@tsconfig/ember": "^3.0.10",
-    "@types/eslint__js": "^8.42.3",
     "@types/qunit": "^2.19.12",
     "@types/rsvp": "^4.0.9",
     "@warp-drive/core-types": "~0.0.2",