Repository: typescript-eslint/tslint-to-eslint-config (ts)

Issue:
Supplying `--prettier` always results in a broken configuration
<!--
👋 Hi, thanks for filing an issue on tslint-to-eslint-config! 💖
Please fill out all fields below to ensure your issue is addressed.

If your issue doesn't provide enough info to fully explain or reproduce your bug, it will be closed. 😦
-->

### 🐛 Bug Report

-   `tslint-to-eslint-config` version: `2.11.0`
-   ESLint version: `8.10.0`
-   Node version: `v14.19.0`

#### Actual Behavior

Running `tslint-to-eslint-config` with the `--prettier` flag, and subsequently running ESLint runs into the following:

```txt
Oops! Something went wrong! :(

ESLint: 8.10.0

Error: Cannot read config file: /tmp/tmp.oUi9YFaB6U/comment-divider/node_modules/.pnpm/eslint-config-prettier@8.4.0_eslint@8.10.0/node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Referenced from: /tmp/tmp.oUi9YFaB6U/comment-divider/.eslintrc.js
    at Object.<anonymous> (/tmp/tmp.oUi9YFaB6U/comment-divider/node_modules/.pnpm/eslint-config-prettier@8.4.0_eslint@8.10.0/node_modules/eslint-config-prettier/@typescript-eslint.js:1:69)
    at Module._compile (/tmp/tmp.oUi9YFaB6U/comment-divider/node_modules/.pnpm/v8-compile-cache@2.3.0/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at Object.module.exports [as default] (/tmp/tmp.oUi9YFaB6U/comment-divider/node_modules/.pnpm/import-fresh@3.3.0/node_modules/import-fresh/index.js:32:59)
    at loadJSConfigFile (/tmp/tmp.oUi9YFaB6U/comment-divider/node_modules/.pnpm/@eslint+eslintrc@1.2.0/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2559:47)
    at loadConfigFile (/tmp/tmp.oUi9YFaB6U/comment-divider/node_modules/.pnpm/@eslint+eslintrc@1.2.0/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2643:20)
    at ConfigArrayFactory._loadConfigData (/tmp/tmp.oUi9YFaB6U/comment-divider/node_modules/.pnpm/@eslint+eslintrc@1.2.0/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2947:42)
```

#### Expected Behavior

No errors

#### Reproduction

```sh
$ yarn add tslint-to-eslint-config eslint
$ echo '{}' >| tslint.json
$ yarn run tslint-to-eslint-config --prettier
...
```

<details>
<summary>.eslintrc.js</summary>

```js
/*
👋 Hi! This file was autogenerated by tslint-to-eslint-config.
https://github.com/typescript-eslint/tslint-to-eslint-config

It represents the closest reasonable ESLint configuration to this
project's original TSLint configuration.

We recommend eventually switching this configuration to extend from
the recommended rulesets in typescript-eslint. 
https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md

Happy linting! 💖
*/
module.exports = {
    "env": {
        "browser": true,
        "es6": true
    },
    "extends": [
        "prettier",
        "prettier/@typescript-eslint"
    ],
    "parser": "@typescript-eslint/parser",
    "parserOptions": {
        "project": "tsconfig.json",
        "sourceType": "module"
    },
    "plugins": [
        "@typescript-eslint"
    ]
};
```

</details>

The issue wasn't systemic and the fix seemed pretty [trivial](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21), so I went ahead and made a PR for this

Pull request:
No longer extend from removed/deprected Prettier ESLint configs
## PR Checklist

-   [x] Addresses an existing issue: fixes #1396 
-   [x] That issue was marked as [`status: accepting prs`](https://github.com/typescript-eslint/tslint-to-eslint-config/labels/status%3A%20accepting%20prs)

## Overview

Since `v8.0.0` of `eslint-config-prettier`, [all configs have merged](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21) into `prettier` and supplying the extraneous configs like `"prettier/@typescript-eslint"`, etc. results in error

This fix simply removes the no-longer-needed configs to extend from

Patch:
diff --git a/src/converters/lintConfigs/summarization/retrieveExtendsValues.ts b/src/converters/lintConfigs/summarization/retrieveExtendsValues.ts
index bd5f5ac..54ff089 100644
--- a/src/converters/lintConfigs/summarization/retrieveExtendsValues.ts
+++ b/src/converters/lintConfigs/summarization/retrieveExtendsValues.ts
@@ -20,10 +20,6 @@ const builtInExtensions = new Map([
 
 const pluginExtensions = new Map([
     ["eslint-plugin-prettier", "node_modules/eslint-config-prettier/index.js"],
-    [
-        "eslint-plugin-prettier/@typescript-eslint",
-        "node_modules/eslint-config-prettier/@typescript-eslint.js",
-    ],
     [
         "plugin:@typescript-eslint/all",
         "node_modules/@typescript-eslint/eslint-plugin/dist/configs/all.json",
diff --git a/src/converters/lintConfigs/summarization/summarizePackageRules.ts b/src/converters/lintConfigs/summarization/summarizePackageRules.ts
index 891b6d4..a8db8bb 100644
--- a/src/converters/lintConfigs/summarization/summarizePackageRules.ts
+++ b/src/converters/lintConfigs/summarization/summarizePackageRules.ts
@@ -35,7 +35,7 @@ export const summarizePackageRules = async (
 
     // 3a. If no output rules conflict with `eslint-config-prettier`, it's added in
     if (dependencies.checkPrettierExtension(ruleConversionResults, prettierRequested)) {
-        allExtensions.push("prettier", "prettier/@typescript-eslint");
+        allExtensions.push("prettier");
     }
 
     if (allExtensions.length === 0) {


Test patch:
diff --git a/src/converters/lintConfigs/reporting/reportConfigConversionResults.test.ts b/src/converters/lintConfigs/reporting/reportConfigConversionResults.test.ts
index 842f68a..0897303 100644
--- a/src/converters/lintConfigs/reporting/reportConfigConversionResults.test.ts
+++ b/src/converters/lintConfigs/reporting/reportConfigConversionResults.test.ts
@@ -6,7 +6,7 @@ import { createEmptyConfigConversionResults } from "../configConversionResults.s
 import { ESLintRuleOptions } from "../rules/types";
 import { reportConfigConversionResults } from "./reportConfigConversionResults";
 
-const basicExtends = ["prettier", "prettier/@typescript-eslint"];
+const basicExtends = ["prettier"];
 
 describe("reportConfigConversionResults", () => {
     it("logs a successful conversion without notices when there is one converted rule without notices", async () => {
diff --git a/src/converters/lintConfigs/summarization/summarizePackageRules.test.ts b/src/converters/lintConfigs/summarization/summarizePackageRules.test.ts
index 23fcd6a..b325b6f 100644
--- a/src/converters/lintConfigs/summarization/summarizePackageRules.test.ts
+++ b/src/converters/lintConfigs/summarization/summarizePackageRules.test.ts
@@ -75,7 +75,7 @@ describe("summarizePackageRules", () => {
         expect(summarizedResults).toEqual({
             ...ruleConversionResults,
             converted: new Map(),
-            extends: ["prettier", "prettier/@typescript-eslint"],
+            extends: ["prettier"],
         });
     });