Repository: streamich/memfs (ts)

Issue:
.rename/.renameSync could not trigger FSWatcher when changes are recursive
Renaming the direct child in the folder works as expect.

When I watch `/` (with `recursive: true`) and rename the `/test/hello.txt` file, the watcher is not triggered.

Here is the online demo: https://codesandbox.io/s/stoic-jerry-juxpw4?file=/src/index.js:0-264

```javascript
// demo code
import { fs } from "memfs";

fs.mkdirSync("/test");
fs.writeFileSync("/test/hello.txt", "World!");

fs.watch("/", { recursive: true }, (eventType, filename) => {
  console.log("watch:", eventType, filename);
});

fs.renameSync("/test/hello.txt", "/test/hello1.txt");
// expect print: watch: change /
```

Such code works in Node.js (v14.19.3).

Pull request:
feat(volume): support the recursive option for fs.watch()
The `fs.watch` API has `recursive` option but it did not implement it. For example, the watching listener below will not be triggered:

```js
const vol = new Volume();
vol.mkdirSync('/test');

vol.watch('/', { recursive: true }, (eventType, filename) => {
  // won't be triggered
  console.log('fs.watch', eventType, filename);
});

setTimeout(() => {
  vol.writeFileSync('/test/lol.txt', '2');
}, 1000);
```

---

Besides when a child file's content (not recursive) is changed, the listener will not be triggered too:

```js
const vol = new Volume();
vol.mkdirSync('/test');
vol.writeFileSync('/test/lol.txt', 'foo')

vol.watch('/test', { recursive: false }, (eventType, filename) => {
  // won't be triggered
  console.log('fs.watch', eventType, filename);
});

setTimeout(() => {
  vol.writeFileSync('/test/lol.txt', 'bar');
}, 1000);
```

Resolves #883 

Patch:
diff --git a/src/volume.ts b/src/volume.ts
index 1a5c1702..2c152006 100644
--- a/src/volume.ts
+++ b/src/volume.ts
@@ -230,7 +230,7 @@ function optsGenerator<TOpts>(defaults: TOpts): (opts) => TOpts {
   return options => getOptions(defaults, options);
 }
 
-type AssertCallback<T> = T extends Function ? T : never;
+type AssertCallback<T> = T extends () => void ? T : never;
 
 function validateCallback<T>(callback: T): AssertCallback<T> {
   if (typeof callback !== 'function') throw TypeError(ERRSTR.CB);
@@ -2688,6 +2688,9 @@ export class FSWatcher extends EventEmitter {
 
   _timer; // Timer that keeps this task persistent.
 
+  // inode -> removers
+  private _listenerRemovers = new Map<number, Array<() => void>>();
+
   constructor(vol: Volume) {
     super();
     this._vol = vol;
@@ -2711,10 +2714,6 @@ export class FSWatcher extends EventEmitter {
     return this._steps[this._steps.length - 1];
   }
 
-  private _onNodeChange = () => {
-    this._emit('change');
-  };
-
   private _onParentChild = (link: Link) => {
     if (link.getName() === this._getName()) {
       this._emit('rename');
@@ -2751,10 +2750,79 @@ export class FSWatcher extends EventEmitter {
       throw error;
     }
 
-    this._link.getNode().on('change', this._onNodeChange);
+    const watchLinkNodeChanged = (link: Link) => {
+      const filepath = link.getPath();
+      const node = link.getNode();
+      const onNodeChange = () => this.emit('change', 'change', relative(this._filename, filepath));
+      node.on('change', onNodeChange);
+
+      const removers = this._listenerRemovers.get(node.ino) ?? [];
+      removers.push(() => node.removeListener('change', onNodeChange));
+      this._listenerRemovers.set(node.ino, removers);
+    };
+
+    const watchLinkChildrenChanged = (link: Link) => {
+      const node = link.getNode();
+
+      // when a new link added
+      const onLinkChildAdd = (l: Link) => {
+        this.emit('change', 'rename', relative(this._filename, l.getPath()));
 
-    this._link.on('child:add', this._onNodeChange);
-    this._link.on('child:delete', this._onNodeChange);
+        setTimeout(() => {
+          // 1. watch changes of the new link-node
+          watchLinkNodeChanged(l);
+          // 2. watch changes of the new link-node's children
+          watchLinkChildrenChanged(l);
+        });
+      };
+
+      // when a new link deleted
+      const onLinkChildDelete = (l: Link) => {
+        // remove the listeners of the children nodes
+        const removeLinkNodeListeners = (curLink: Link) => {
+          const ino = curLink.getNode().ino;
+          const removers = this._listenerRemovers.get(ino);
+          if (removers) {
+            removers.forEach(r => r());
+            this._listenerRemovers.delete(ino);
+          }
+          Object.values(curLink.children).forEach(childLink => {
+            if (childLink) {
+              removeLinkNodeListeners(childLink);
+            }
+          });
+        };
+        removeLinkNodeListeners(l);
+
+        this.emit('change', 'rename', relative(this._filename, l.getPath()));
+      };
+
+      // children nodes changed
+      Object.values(link.children).forEach(childLink => {
+        if (childLink) {
+          watchLinkNodeChanged(childLink);
+        }
+      });
+      // link children add/remove
+      link.on('child:add', onLinkChildAdd);
+      link.on('child:delete', onLinkChildDelete);
+
+      const removers = this._listenerRemovers.get(node.ino) ?? [];
+      removers.push(() => {
+        link.removeListener('child:add', onLinkChildAdd);
+        link.removeListener('child:delete', onLinkChildDelete);
+      });
+
+      if (recursive) {
+        Object.values(link.children).forEach(childLink => {
+          if (childLink) {
+            watchLinkChildrenChanged(childLink);
+          }
+        });
+      }
+    };
+    watchLinkNodeChanged(this._link);
+    watchLinkChildrenChanged(this._link);
 
     const parent = this._link.parent;
     if (parent) {
@@ -2769,7 +2837,10 @@ export class FSWatcher extends EventEmitter {
   close() {
     clearTimeout(this._timer);
 
-    this._link.getNode().removeListener('change', this._onNodeChange);
+    this._listenerRemovers.forEach(removers => {
+      removers.forEach(r => r());
+    });
+    this._listenerRemovers.clear();
 
     const parent = this._link.parent;
     if (parent) {


Test patch:
diff --git a/src/__tests__/volume.test.ts b/src/__tests__/volume.test.ts
index 298993b8..fe7b134c 100644
--- a/src/__tests__/volume.test.ts
+++ b/src/__tests__/volume.test.ts
@@ -1080,6 +1080,75 @@ describe('volume', () => {
         });
       });
     });
+    describe('.watch(path[, options], listener)', () => {
+      it('Calls listener on .watch when renaming with recursive=true', done => {
+        const vol = new Volume();
+        vol.mkdirSync('/test');
+        vol.writeFileSync('/test/lol.txt', 'foo');
+        setTimeout(() => {
+          const listener = jest.fn();
+          const watcher = vol.watch('/', { recursive: true }, listener);
+
+          vol.renameSync('/test/lol.txt', '/test/lol-2.txt');
+
+          setTimeout(() => {
+            watcher.close();
+            expect(listener).toBeCalledTimes(2);
+            expect(listener).nthCalledWith(1, 'rename', 'test/lol.txt');
+            expect(listener).nthCalledWith(2, 'rename', 'test/lol-2.txt');
+            done();
+          }, 10);
+        });
+      });
+      it('Calls listener on .watch with recursive=true', done => {
+        const vol = new Volume();
+        vol.writeFileSync('/lol.txt', '1');
+        vol.mkdirSync('/test');
+        setTimeout(() => {
+          const listener = jest.fn();
+          const watcher = vol.watch('/', { recursive: true }, listener);
+          vol.writeFileSync('/lol.txt', '2');
+          vol.writeFileSync('/test/lol.txt', '2');
+          vol.rmSync('/lol.txt');
+          vol.rmSync('/test/lol.txt');
+          vol.mkdirSync('/test/foo');
+
+          setTimeout(() => {
+            watcher.close();
+            expect(listener).toBeCalledTimes(6);
+            expect(listener).nthCalledWith(1, 'change', 'lol.txt');
+            expect(listener).nthCalledWith(2, 'change', 'lol.txt');
+            expect(listener).nthCalledWith(3, 'rename', 'test/lol.txt');
+            expect(listener).nthCalledWith(4, 'rename', 'lol.txt');
+            expect(listener).nthCalledWith(5, 'rename', 'test/lol.txt');
+            expect(listener).nthCalledWith(6, 'rename', 'test/foo');
+            done();
+          }, 10);
+        });
+      });
+      it('Calls listener on .watch with recursive=false', done => {
+        const vol = new Volume();
+        vol.writeFileSync('/lol.txt', '1');
+        vol.mkdirSync('/test');
+        setTimeout(() => {
+          const listener = jest.fn();
+          const watcher = vol.watch('/', { recursive: false }, listener);
+          vol.writeFileSync('/lol.txt', '2');
+          vol.rmSync('/lol.txt');
+          vol.writeFileSync('/test/lol.txt', '2');
+          vol.rmSync('/test/lol.txt');
+
+          setTimeout(() => {
+            watcher.close();
+            expect(listener).toBeCalledTimes(3);
+            expect(listener).nthCalledWith(1, 'change', 'lol.txt');
+            expect(listener).nthCalledWith(2, 'change', 'lol.txt');
+            expect(listener).nthCalledWith(3, 'rename', 'lol.txt');
+            done();
+          }, 10);
+        });
+      });
+    });
     describe('.watchFile(path[, options], listener)', () => {
       it('Calls listener on .writeFile', done => {
         const vol = new Volume();