Repository: ceph/go-ceph (go)

Issue:
APIs pending stability updates in v0.19.0
## Preview APIs due to become stable
* rados: IOContext.SetAllocationHint
* rados: WriteOp.SetAllocationHint
* rados: IOContext.Alignment
* rados: IOContext.RequiresAlignment
* rgw/admin: API.ListUsersBuckets
* rgw/admin: API.ListUsersBucketsWithStat
* rgw/admin: API.CreateKey
* rgw/admin: API.RemoveKey
* rgw/admin: API.SetIndividualBucketQuota


## Deprecated APIs due to be removed
n/a


> NOTE: This issue was automatically filed by a script.



Pull request:
Make preview APIs stable for v0.19
Two packages had APIs becoming stable for release v0.19, scheduled for 13th December 2022.

Fixes #793 

Patch:
diff --git a/docs/api-status.json b/docs/api-status.json
index cc1e6fb..e142517 100644
--- a/docs/api-status.json
+++ b/docs/api-status.json
@@ -1012,34 +1012,33 @@
       {
         "name": "IOContext.SetLocator",
         "comment": "SetLocator sets the key for mapping objects to pgs within an io context.\nUntil a different locator key is set, all objects in this io context will be placed in the same pg.\nTo reset the locator, an empty string must be set.\n\nImplements:\n void rados_ioctx_locator_set_key(rados_ioctx_t io, const char *key);\n"
-      }
-    ],
-    "preview_api": [
+      },
       {
         "name": "IOContext.SetAllocationHint",
         "comment": "SetAllocationHint sets allocation hint for an object. This is an advisory\noperation, it will always succeed (as if it was submitted with a\nLIBRADOS_OP_FLAG_FAILOK flag set) and is not guaranteed to do anything on\nthe backend.\n\nImplements:\n int rados_set_alloc_hint2(rados_ioctx_t io,\n                           const char *o,\n                           uint64_t expected_object_size,\n                           uint64_t expected_write_size,\n                           uint32_t flags);\n",
         "added_in_version": "v0.17.0",
-        "expected_stable_version": "v0.19.0"
+        "became_stable_version": "v0.19.0"
       },
       {
         "name": "WriteOp.SetAllocationHint",
         "comment": "SetAllocationHint sets allocation hint for an object. This is an advisory\noperation, it will always succeed (as if it was submitted with a\nLIBRADOS_OP_FLAG_FAILOK flag set) and is not guaranteed to do anything on\nthe backend.\n\nImplements:\n void rados_write_op_set_alloc_hint2(rados_write_op_t write_op,\n                                     uint64_t expected_object_size,\n                                     uint64_t expected_write_size,\n                                     uint32_t flags);\n",
         "added_in_version": "v0.17.0",
-        "expected_stable_version": "v0.19.0"
+        "became_stable_version": "v0.19.0"
       },
       {
         "name": "IOContext.Alignment",
         "comment": "Alignment returns the required stripe size in bytes for pools supporting/requiring it, or an error if unsuccessful.\nFor an EC pool, a buffer size multiple of its stripe size is required to call Append. To know if the pool requires\nalignment or not, use RequiresAlignment.\n\nImplements:\n int rados_ioctx_pool_required_alignment2(rados_ioctx_t io, uint64_t *alignment)\n",
         "added_in_version": "v0.17.0",
-        "expected_stable_version": "v0.19.0"
+        "became_stable_version": "v0.19.0"
       },
       {
         "name": "IOContext.RequiresAlignment",
         "comment": "RequiresAlignment returns true if the pool supports/requires alignment or an error if not successful.\nFor an EC pool, a buffer size multiple of its stripe size is required to call Append. See\nAlignment to know how to get the stripe size for pools requiring it.\n\nImplements:\n int rados_ioctx_pool_requires_alignment2(rados_ioctx_t io, int *req)\n",
         "added_in_version": "v0.17.0",
-        "expected_stable_version": "v0.19.0"
+        "became_stable_version": "v0.19.0"
       }
-    ]
+    ],
+    "preview_api": []
   },
   "rbd": {
     "deprecated_api": [
@@ -1751,38 +1750,7 @@
     ]
   },
   "rgw/admin": {
-    "preview_api": [
-      {
-        "name": "API.ListUsersBuckets",
-        "comment": "ListUsersBuckets will return the list of all users buckets without stat.\n",
-        "added_in_version": "v0.17.0",
-        "expected_stable_version": "v0.19.0"
-      },
-      {
-        "name": "API.ListUsersBucketsWithStat",
-        "comment": "ListUsersBucketsWithStat will return the list of all users buckets with stat.\n",
-        "added_in_version": "v0.17.0",
-        "expected_stable_version": "v0.19.0"
-      },
-      {
-        "name": "API.CreateKey",
-        "comment": "CreateKey will generate new keys or add specified to keyring.\nhttps://docs.ceph.com/en/latest/radosgw/adminops/#create-key.\n",
-        "added_in_version": "v0.17.0",
-        "expected_stable_version": "v0.19.0"
-      },
-      {
-        "name": "API.RemoveKey",
-        "comment": "RemoveKey will remove an existing key.\nhttps://docs.ceph.com/en/latest/radosgw/adminops/#remove-key\nKeySpec.SecretKey parameter shouldn't be provided and will be ignored.\n",
-        "added_in_version": "v0.17.0",
-        "expected_stable_version": "v0.19.0"
-      },
-      {
-        "name": "API.SetIndividualBucketQuota",
-        "comment": "SetIndividualBucketQuota sets quota to a specific bucket.\nhttps://docs.ceph.com/en/latest/radosgw/adminops/#set-quota-for-an-individual-bucket.\n",
-        "added_in_version": "v0.17.0",
-        "expected_stable_version": "v0.19.0"
-      }
-    ],
+    "preview_api": [],
     "stable_api": [
       {
         "name": "API.ListBuckets",
@@ -1878,6 +1846,36 @@
       {
         "name": "API.ModifySubuser",
         "comment": "ModifySubuser - https://docs.ceph.com/en/latest/radosgw/adminops/#modify-subuser\n"
+      },
+      {
+        "name": "API.ListUsersBuckets",
+        "comment": "ListUsersBuckets will return the list of all users buckets without stat\n",
+        "added_in_version": "v0.17.0",
+        "became_stable_version": "v0.19.0"
+      },
+      {
+        "name": "API.ListUsersBucketsWithStat",
+        "comment": "ListUsersBucketsWithStat will return the list of all users buckets with stat\n",
+        "added_in_version": "v0.17.0",
+        "became_stable_version": "v0.19.0"
+      },
+      {
+        "name": "API.CreateKey",
+        "comment": "CreateKey will generate new keys or add specified to keyring\nhttps://docs.ceph.com/en/latest/radosgw/adminops/#create-key\n",
+        "added_in_version": "v0.17.0",
+        "became_stable_version": "v0.19.0"
+      },
+      {
+        "name": "API.RemoveKey",
+        "comment": "RemoveKey will remove an existing key\nhttps://docs.ceph.com/en/latest/radosgw/adminops/#remove-key\nKeySpec.SecretKey parameter shouldn't be provided and will be ignored\n",
+        "added_in_version": "v0.17.0",
+        "became_stable_version": "v0.19.0"
+      },
+      {
+        "name": "API.SetIndividualBucketQuota",
+        "comment": "SetIndividualBucketQuota sets quota to a specific bucket\nhttps://docs.ceph.com/en/latest/radosgw/adminops/#set-quota-for-an-individual-bucket\n",
+        "added_in_version": "v0.17.0",
+        "became_stable_version": "v0.19.0"
       }
     ]
   },
diff --git a/docs/api-status.md b/docs/api-status.md
index e33a8b7..6606c47 100644
--- a/docs/api-status.md
+++ b/docs/api-status.md
@@ -12,14 +12,7 @@ No Preview/Deprecated APIs found. All APIs are considered stable.
 
 ## Package: rados
 
-### Preview APIs
-
-Name | Added in Version | Expected Stable Version | 
----- | ---------------- | ----------------------- | 
-IOContext.SetAllocationHint | v0.17.0 | v0.19.0 | 
-WriteOp.SetAllocationHint | v0.17.0 | v0.19.0 | 
-IOContext.Alignment | v0.17.0 | v0.19.0 | 
-IOContext.RequiresAlignment | v0.17.0 | v0.19.0 | 
+No Preview/Deprecated APIs found. All APIs are considered stable.
 
 ## Package: rbd
 
@@ -37,15 +30,7 @@ No Preview/Deprecated APIs found. All APIs are considered stable.
 
 ## Package: rgw/admin
 
-### Preview APIs
-
-Name | Added in Version | Expected Stable Version | 
----- | ---------------- | ----------------------- | 
-API.ListUsersBuckets | v0.17.0 | v0.19.0 | 
-API.ListUsersBucketsWithStat | v0.17.0 | v0.19.0 | 
-API.CreateKey | v0.17.0 | v0.19.0 | 
-API.RemoveKey | v0.17.0 | v0.19.0 | 
-API.SetIndividualBucketQuota | v0.17.0 | v0.19.0 | 
+No Preview/Deprecated APIs found. All APIs are considered stable.
 
 ## Package: common/admin/manager
 
diff --git a/rados/ioctx_pool_alignment.go b/rados/ioctx_pool_alignment.go
index 7ea47df..5e47aaa 100644
--- a/rados/ioctx_pool_alignment.go
+++ b/rados/ioctx_pool_alignment.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package rados
 
 // #cgo LDFLAGS: -lrados
diff --git a/rados/ioctx_pool_requires_alignment.go b/rados/ioctx_pool_requires_alignment.go
index 0ec5fed..a1b4c5c 100644
--- a/rados/ioctx_pool_requires_alignment.go
+++ b/rados/ioctx_pool_requires_alignment.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package rados
 
 // #cgo LDFLAGS: -lrados
diff --git a/rados/ioctx_set_alloc_hint.go b/rados/ioctx_set_alloc_hint.go
index dbb7518..7cc2df5 100644
--- a/rados/ioctx_set_alloc_hint.go
+++ b/rados/ioctx_set_alloc_hint.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package rados
 
 // #cgo LDFLAGS: -lrados
diff --git a/rados/write_op_set_alloc_hint.go b/rados/write_op_set_alloc_hint.go
index c9cc657..83cfe9e 100644
--- a/rados/write_op_set_alloc_hint.go
+++ b/rados/write_op_set_alloc_hint.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package rados
 
 // #cgo LDFLAGS: -lrados
diff --git a/rgw/admin/bucket_quota.go b/rgw/admin/bucket_quota.go
index 87b225c..3522dec 100644
--- a/rgw/admin/bucket_quota.go
+++ b/rgw/admin/bucket_quota.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package admin
 
 import (
diff --git a/rgw/admin/keys.go b/rgw/admin/keys.go
index 711cb16..28c98a0 100644
--- a/rgw/admin/keys.go
+++ b/rgw/admin/keys.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package admin
 
 import (
diff --git a/rgw/admin/user_bucket.go b/rgw/admin/user_bucket.go
index db24fc3..182d39b 100644
--- a/rgw/admin/user_bucket.go
+++ b/rgw/admin/user_bucket.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package admin
 
 import (


Test patch:
diff --git a/rados/ioctx_pool_alignment_test.go b/rados/ioctx_pool_alignment_test.go
index 4102dc1..1b091a8 100644
--- a/rados/ioctx_pool_alignment_test.go
+++ b/rados/ioctx_pool_alignment_test.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package rados
 
 import (
diff --git a/rados/ioctx_pool_requires_alignment_test.go b/rados/ioctx_pool_requires_alignment_test.go
index 6b7424d..fa8a59c 100644
--- a/rados/ioctx_pool_requires_alignment_test.go
+++ b/rados/ioctx_pool_requires_alignment_test.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package rados
 
 import (
diff --git a/rgw/admin/bucket_quota_test.go b/rgw/admin/bucket_quota_test.go
index 70bd383..f4a5844 100644
--- a/rgw/admin/bucket_quota_test.go
+++ b/rgw/admin/bucket_quota_test.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package admin
 
 import (
diff --git a/rgw/admin/keys_test.go b/rgw/admin/keys_test.go
index 00d1d4f..ede5906 100644
--- a/rgw/admin/keys_test.go
+++ b/rgw/admin/keys_test.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package admin
 
 import (
diff --git a/rgw/admin/user_bucket_test.go b/rgw/admin/user_bucket_test.go
index ffae0bb..8d3d598 100644
--- a/rgw/admin/user_bucket_test.go
+++ b/rgw/admin/user_bucket_test.go
@@ -1,6 +1,3 @@
-//go:build ceph_preview
-// +build ceph_preview
-
 package admin
 
 import (