Repository: apigee/registry (go)

Issue:
Registry tool: Use global flags for config create
If a user specifies any of flags that set a stored value during `config create`, the created config should save them. Eg.

      --registry.address string    the server and port of the registry api (eg. localhost:8080)
      --registry.insecure          if specified, client connects via http (not https)
      --registry.location string   the registry location
      --registry.project string    the registry project


Pull request:
 clone active w/ flags on config create
Clones current active configuration using any flag overrides when creating a new configuration.

Fixes #692

Patch:
diff --git a/cmd/registry/cmd/config/configurations/create.go b/cmd/registry/cmd/config/configurations/create.go
index 6d2853b..4e2067a 100644
--- a/cmd/registry/cmd/config/configurations/create.go
+++ b/cmd/registry/cmd/config/configurations/create.go
@@ -41,8 +41,15 @@ func createCommand() *cobra.Command {
 				return fmt.Errorf("Cannot create config %q, it already exists.", name)
 			}
 
-			s := config.Configuration{}
-			err := s.Write(name)
+			// attempt to clone the active config or at least the current flags
+			s, err := config.Active()
+			if err != nil {
+				if s, err = config.ReadValid(""); err != nil {
+					s = config.Configuration{}
+				}
+			}
+
+			err = s.Write(name)
 			if err != nil {
 				return fmt.Errorf("Cannot create config %q: %v", name, err)
 			}


Test patch:
diff --git a/cmd/registry/cmd/config/configurations/configurations_test.go b/cmd/registry/cmd/config/configurations/configurations_test.go
index d8b892c..bc0c35c 100644
--- a/cmd/registry/cmd/config/configurations/configurations_test.go
+++ b/cmd/registry/cmd/config/configurations/configurations_test.go
@@ -186,3 +186,56 @@ Do you want to continue (Y/n)? Deleted "config2".
 		t.Errorf("unexpected diff: (-want +got):\n%s", diff)
 	}
 }
+
+func TestCreateConfiguration(t *testing.T) {
+	t.Cleanup(test.CleanConfigDir(t))
+
+	want := config.Configuration{
+		Registry: config.Registry{
+			Address:  "address",
+			Insecure: true,
+		},
+	}
+
+	cmd := createCommand()
+	cmd.PersistentFlags().AddFlagSet(config.Flags)
+	// cmd.PersistentFlags().AddFlagSet(config.CreateFlagSet())
+	cmd.SetArgs([]string{"config1", "--registry.address=address", "--registry.insecure=true"})
+	if err := cmd.Execute(); err != nil {
+		t.Fatal(err)
+	}
+	c, err := config.Read("config1")
+	if err != nil {
+		t.Fatal(err)
+	}
+	if diff := cmp.Diff(want, c); diff != "" {
+		t.Errorf("unexpected diff: (-want +got):\n%s", diff)
+	}
+
+	cmd = createCommand()
+	cmd.PersistentFlags().AddFlagSet(config.Flags)
+	cmd.SetArgs([]string{"config2"})
+	if err := cmd.Execute(); err != nil {
+		t.Fatal(err)
+	}
+	if c, err = config.Read("config2"); err != nil {
+		t.Fatal(err)
+	}
+	if diff := cmp.Diff(want, c); diff != "" {
+		t.Errorf("unexpected diff: (-want +got):\n%s", diff)
+	}
+
+	cmd = createCommand()
+	cmd.PersistentFlags().AddFlagSet(config.Flags)
+	cmd.SetArgs([]string{"config3", "--registry.location", "location"})
+	if err := cmd.Execute(); err != nil {
+		t.Fatal(err)
+	}
+	if c, err = config.Read("config3"); err != nil {
+		t.Fatal(err)
+	}
+	want.Registry.Location = "location"
+	if diff := cmp.Diff(want, c); diff != "" {
+		t.Errorf("unexpected diff: (-want +got):\n%s", diff)
+	}
+}