Repository: SpoonLabs/gumtree-spoon-ast-diff (java)

Issue:
API for returning children of `CtVirtualElement`
From `diffmin`'s point of view, it would be great if I can get children of `CtVirtualElement` - usually modifiers. They would be helpful while setting modifiers on a `CtType` using the `setModifiers` API. This API would be analogous to `CtWrapper`'s `getValue` API.

Pull request:
Add API to retrieve children of `CtVirtualElement`
Fixes #162 

- Did not write a test case as the API is not _computing_ anything. It just returns the `children`. We could test for visibility but I think that is out of scope.
- I hope the API name `getChildren()` is not confused with `getDirectChildren()` in spoon. If that is the case, I am open to suggestion for a better name. 

Patch:
diff --git a/src/main/java/gumtree/spoon/builder/CtVirtualElement.java b/src/main/java/gumtree/spoon/builder/CtVirtualElement.java
index 63e1606..e195cf2 100644
--- a/src/main/java/gumtree/spoon/builder/CtVirtualElement.java
+++ b/src/main/java/gumtree/spoon/builder/CtVirtualElement.java
@@ -1,6 +1,7 @@
 package gumtree.spoon.builder;
 
 import java.util.Collection;
+import java.util.Collections;
 
 import spoon.reflect.declaration.CtElement;
 import spoon.reflect.path.CtRole;
@@ -25,6 +26,10 @@ public class CtVirtualElement extends CtWrapper<String> {
 		this.children = children;
 	}
 
+	public Collection<?> getChildren() {
+		return Collections.unmodifiableCollection(children);
+	}
+
 	@Override
 	public String toString() {
 		return "VE: " + ((value != null) ? (value.toString()) : null);


Test patch:
diff --git a/src/test/java/gumtree/spoon/diff/support/SpoonSupportTest.java b/src/test/java/gumtree/spoon/diff/support/SpoonSupportTest.java
index 85e2867..6245e3e 100644
--- a/src/test/java/gumtree/spoon/diff/support/SpoonSupportTest.java
+++ b/src/test/java/gumtree/spoon/diff/support/SpoonSupportTest.java
@@ -24,6 +24,8 @@ import spoon.reflect.declaration.ModifierKind;
 import spoon.reflect.path.CtRole;
 
 import java.io.File;
+import java.util.HashSet;
+import java.util.Set;
 
 public class SpoonSupportTest {
 
@@ -192,4 +194,24 @@ public class SpoonSupportTest {
 
 		assertEquals(CtRole.MODIFIER, modifiers.getRoleInParent());
 	}
+
+	@Test
+	public void testGettingChildrenOfCtVirtualElement() {
+		String c1 = "class Test { }";
+		String c2 = "public abstract final class Test { }";
+
+		Diff editScript = new AstComparator().compare(c1, c2);
+
+		CtVirtualElement srcNode = (CtVirtualElement) editScript.getRootOperations().get(0).getSrcNode();
+		Set<?> modifiers = new HashSet<>(srcNode.getChildren());
+
+		Set<ModifierKind> expectedModifiers = new HashSet<>();
+		expectedModifiers.add(ModifierKind.PUBLIC);
+		expectedModifiers.add(ModifierKind.ABSTRACT);
+		expectedModifiers.add(ModifierKind.FINAL);
+
+
+		assertEquals(3, modifiers.size());
+		assertTrue(modifiers.containsAll(expectedModifiers));
+	}
 }