Repository: urlaubsverwaltung/urlaubsverwaltung (java)

Issue:
"Antrag stellen" im Menü entfernen
"Antrag stellen" wurd eim Menü durch den + Button ersetzt und kann entfernt werden.

Pull request:
Remove "Antrag stellen" from navbar
closes #1835 

Patch:
diff --git a/src/main/java/org/synyx/urlaubsverwaltung/web/FrameDataProvider.java b/src/main/java/org/synyx/urlaubsverwaltung/web/FrameDataProvider.java
index 9116efc73..15f5f8e0b 100644
--- a/src/main/java/org/synyx/urlaubsverwaltung/web/FrameDataProvider.java
+++ b/src/main/java/org/synyx/urlaubsverwaltung/web/FrameDataProvider.java
@@ -74,7 +74,6 @@ public class FrameDataProvider implements HandlerInterceptor {
         final ArrayList<NavigationItemDto> elements = new ArrayList<>();
 
         elements.add(new NavigationItemDto("home-link", "/web/overview", "nav.home.title", "home"));
-        elements.add(new NavigationItemDto("application-new-link", "/web/application/new", "nav.apply.title", "plus-circle"));
         elements.add(new NavigationItemDto("application-link", "/web/application", "nav.vacation.title", "calendar"));
 
         final boolean overtime = overtimeEnabled(user);
diff --git a/src/main/resources/messages.properties b/src/main/resources/messages.properties
index dc099d627..a36288e63 100644
--- a/src/main/resources/messages.properties
+++ b/src/main/resources/messages.properties
@@ -8,7 +8,6 @@ locale.en=Englisch
 header.title=Urlaubsverwaltung
 nav.urlaubsverwaltung.title=Urlaubsverwaltung
 nav.home.title=Übersicht
-nav.apply.title=Antrag stellen
 nav.help.title=Hilfe
 nav.signout.title=Abmelden
 nav.vacation.title=Abwesenheiten
diff --git a/src/main/resources/messages_de_AT.properties b/src/main/resources/messages_de_AT.properties
index e1c7bcadf..b9f25a31a 100644
--- a/src/main/resources/messages_de_AT.properties
+++ b/src/main/resources/messages_de_AT.properties
@@ -8,7 +8,6 @@ locale.en=Englisch
 header.title=Urlaubsverwaltung
 nav.urlaubsverwaltung.title=Urlaubsverwaltung
 nav.home.title=Übersicht
-nav.apply.title=Antrag stellen
 nav.help.title=Hilfe
 nav.signout.title=Abmelden
 nav.vacation.title=Abwesenheiten
diff --git a/src/main/resources/messages_el.properties b/src/main/resources/messages_el.properties
index e588bda0d..529f3480e 100644
--- a/src/main/resources/messages_el.properties
+++ b/src/main/resources/messages_el.properties
@@ -7,7 +7,6 @@ locale.en=Αγγλικά
 # HEADER / NAVBAR
 header.title=Σύστημα διαχείρισης αδειών
 nav.home.title=Επισκόπηση
-nav.apply.title=Αίτημα για άδεια
 nav.help.title=Βοήθεια
 nav.signout.title=Έξοδος
 nav.vacation.title=Άδεια
diff --git a/src/main/resources/messages_en.properties b/src/main/resources/messages_en.properties
index c6bda1202..d6057cbec 100644
--- a/src/main/resources/messages_en.properties
+++ b/src/main/resources/messages_en.properties
@@ -8,7 +8,6 @@ locale.en=English
 header.title=Vacation Management
 nav.urlaubsverwaltung.title=Vacation Management
 nav.home.title=Overview
-nav.apply.title=Apply for leave
 nav.help.title=Help
 nav.signout.title=Sign out
 nav.vacation.title=Absence


Test patch:
diff --git a/src/test/java/org/synyx/urlaubsverwaltung/web/FrameDataProviderTest.java b/src/test/java/org/synyx/urlaubsverwaltung/web/FrameDataProviderTest.java
index 9ec6cf356..21bd8834f 100644
--- a/src/test/java/org/synyx/urlaubsverwaltung/web/FrameDataProviderTest.java
+++ b/src/test/java/org/synyx/urlaubsverwaltung/web/FrameDataProviderTest.java
@@ -96,7 +96,6 @@ class FrameDataProviderTest {
                 final NavigationDto dto = (NavigationDto) navigation;
                 assertThat(dto.getElements()).containsExactly(
                     new NavigationItemDto("home-link", "/web/overview", "nav.home.title", "home"),
-                    new NavigationItemDto("application-new-link", "/web/application/new", "nav.apply.title", "plus-circle"),
                     new NavigationItemDto("application-link", "/web/application", "nav.vacation.title", "calendar"),
                     new NavigationItemDto("overtime-link", "/web/overtime", "nav.overtime.title", "clock"),
                     new NavigationItemDto("sicknote-link", "/web/sickdays", "nav.sicknote.title", "medkit", "navigation-sick-notes-link"),
@@ -134,7 +133,6 @@ class FrameDataProviderTest {
                 final NavigationDto dto = (NavigationDto) navigation;
                 assertThat(dto.getElements()).containsExactly(
                     new NavigationItemDto("home-link", "/web/overview", "nav.home.title", "home"),
-                    new NavigationItemDto("application-new-link", "/web/application/new", "nav.apply.title", "plus-circle"),
                     new NavigationItemDto("application-link", "/web/application", "nav.vacation.title", "calendar"),
                     new NavigationItemDto("overtime-link", "/web/overtime", "nav.overtime.title", "clock"),
                     new NavigationItemDto("sicknote-link", "/web/sickdays", "nav.sicknote.title", "medkit", "navigation-sick-notes-link"),
@@ -172,7 +170,6 @@ class FrameDataProviderTest {
                 final NavigationDto dto = (NavigationDto) navigation;
                 assertThat(dto.getElements()).containsExactly(
                     new NavigationItemDto("home-link", "/web/overview", "nav.home.title", "home"),
-                    new NavigationItemDto("application-new-link", "/web/application/new", "nav.apply.title", "plus-circle"),
                     new NavigationItemDto("application-link", "/web/application", "nav.vacation.title", "calendar"),
                     new NavigationItemDto("overtime-link", "/web/overtime", "nav.overtime.title", "clock"),
                     new NavigationItemDto("sicknote-link", "/web/sickdays", "nav.sicknote.title", "medkit", "navigation-sick-notes-link"),
@@ -211,7 +208,6 @@ class FrameDataProviderTest {
                 final NavigationDto dto = (NavigationDto) navigation;
                 assertThat(dto.getElements()).containsExactly(
                     new NavigationItemDto("home-link", "/web/overview", "nav.home.title", "home"),
-                    new NavigationItemDto("application-new-link", "/web/application/new", "nav.apply.title", "plus-circle"),
                     new NavigationItemDto("application-link", "/web/application", "nav.vacation.title", "calendar"),
                     new NavigationItemDto("overtime-link", "/web/overtime", "nav.overtime.title", "clock"),
                     new NavigationItemDto("sicknote-link", "/web/sickdays", "nav.sicknote.title", "medkit", "navigation-sick-notes-link"),
@@ -248,7 +244,6 @@ class FrameDataProviderTest {
                 final NavigationDto dto = (NavigationDto) navigation;
                 assertThat(dto.getElements()).containsExactly(
                     new NavigationItemDto("home-link", "/web/overview", "nav.home.title", "home"),
-                    new NavigationItemDto("application-new-link", "/web/application/new", "nav.apply.title", "plus-circle"),
                     new NavigationItemDto("application-link", "/web/application", "nav.vacation.title", "calendar"),
                     new NavigationItemDto("overtime-link", "/web/overtime", "nav.overtime.title", "clock"),
                     new NavigationItemDto("sicknote-link", "/web/sickdays", "nav.sicknote.title", "medkit", "navigation-sick-notes-link"),
@@ -285,7 +280,6 @@ class FrameDataProviderTest {
                 final NavigationDto dto = (NavigationDto) navigation;
                 assertThat(dto.getElements()).containsExactly(
                     new NavigationItemDto("home-link", "/web/overview", "nav.home.title", "home"),
-                    new NavigationItemDto("application-new-link", "/web/application/new", "nav.apply.title", "plus-circle"),
                     new NavigationItemDto("application-link", "/web/application", "nav.vacation.title", "calendar"),
                     new NavigationItemDto("overtime-link", "/web/overtime", "nav.overtime.title", "clock"),
                     new NavigationItemDto("sicknote-link", "/web/sickdays", "nav.sicknote.title", "medkit", "navigation-sick-notes-link"),
@@ -322,7 +316,6 @@ class FrameDataProviderTest {
                 final NavigationDto dto = (NavigationDto) navigation;
                 assertThat(dto.getElements()).containsExactly(
                     new NavigationItemDto("home-link", "/web/overview", "nav.home.title", "home"),
-                    new NavigationItemDto("application-new-link", "/web/application/new", "nav.apply.title", "plus-circle"),
                     new NavigationItemDto("application-link", "/web/application", "nav.vacation.title", "calendar"),
                     new NavigationItemDto("overtime-link", "/web/overtime", "nav.overtime.title", "clock"),
                     new NavigationItemDto("sicknote-link", "/web/sickdays", "nav.sicknote.title", "medkit", "navigation-sick-notes-link"),