Repository: JoshuaKGoldberg/tslint-to-eslint-config (ts)

Issue:
@typescript/eslint plugin should always be included in outputs
Right now it never is. Incorrect!

Pull request:
Always included typescript-eslint plugin in ESLint plugins
Fixes #46.

Patch:
diff --git a/src/creation/writeConversionResults.ts b/src/creation/writeConversionResults.ts
index 378b680..c512603 100644
--- a/src/creation/writeConversionResults.ts
+++ b/src/creation/writeConversionResults.ts
@@ -13,15 +13,18 @@ export const writeConversionResults = async (
     ruleConversionResults: RuleConversionResults,
     originalConfigurations: OriginalConfigurations,
 ) => {
+    const plugins = ["@typescript-eslint"];
+
+    if (ruleConversionResults.missing.length !== 0) {
+        plugins.push("@typescript-eslint/tslint");
+    }
     const output = {
         env: createEnv(originalConfigurations),
         parser: "@typescript-eslint/parser",
         parserOptions: {
             project: "tsconfig.json",
         },
-        ...(ruleConversionResults.missing.length && {
-            plugins: ["@typescript-eslint/tslint"],
-        }),
+        plugins,
         rules: formatConvertedRules(ruleConversionResults, originalConfigurations.tslint),
     };
 


Test patch:
diff --git a/src/creation/writeConversionResults.test.ts b/src/creation/writeConversionResults.test.ts
index 64deb35..6f02a2a 100644
--- a/src/creation/writeConversionResults.test.ts
+++ b/src/creation/writeConversionResults.test.ts
@@ -33,6 +33,7 @@ describe("writeConversionResults", () => {
                     parserOptions: {
                         project: "tsconfig.json",
                     },
+                    plugins: ["@typescript-eslint"],
                     rules: {},
                 },
                 undefined,
@@ -72,7 +73,7 @@ describe("writeConversionResults", () => {
                     parserOptions: {
                         project: "tsconfig.json",
                     },
-                    plugins: ["@typescript-eslint/tslint"],
+                    plugins: ["@typescript-eslint", "@typescript-eslint/tslint"],
                     rules: {
                         "@typescript-eslint/tslint/config": [
                             "error",