Redmine - Patch #20661
Show visible spent time link for users allowed to view time entries.
2015-09-02 15:29 - Martin Dubé

ステータス:

Closed

開始日:

優先度:

Normal

期日:担当者:

Jean-Philippe Lang

進捗率:0%

カテゴリ:Time tracking

予定工数:0.00時間対象バージョン:3.2.6

説明With this little change, the spent time is back, but showing only hours visible by the user according to the new "time log visibility"
permission.
関連するチケット:
関連している Redmine - Patch #25526: Revert API change in spent...

Closed

関係しているリビジョン
リビジョン 16292 - 2017-01-29 11:28 - Jean-Philippe LangShow visible spent time link for users allowed to view time entries (#20661).
Patch by Go MAEDA.
リビジョン 16306 - 2017-01-30 18:41 - Jean-Philippe Lang
Merged r16292 (#20661).
リビジョン 16308 - 2017-01-30 18:47 - Jean-Philippe Lang
Merged r16292 (#20661).

履歴#1 - 2015-10-02 05:47 - Toshi MARUYAMA- ステータス を New から Needs feedback に変更
There are many "show.html.erb". Which show.html.erb?
#2 - 2015-10-02 05:52 - Martin Dubé
app/views/issues/show.html.erb
Thanks#3 - 2015-10-02 06:03 - Toshi MARUYAMA- ステータス を Needs feedback から New に変更#4 - 2017-01-06 23:36 - Robert Korulczyk+1
Works great on 3.3.1. Thanks.
#5 - 2017-01-18 01:31 - Go MAEDA- カテゴリ を UI から Time tracking に変更
By this patch, different spent hours value is displayed for each user.
I am worried that it may cause confusion.
#6 - 2017-01-18 09:12 - Robert Korulczyk
Go MAEDA wrote:
By this patch, different spent hours value is displayed for each user.

2024-10-10

1/3

I am worried that it may cause confusion.

It already work in this way in multiple places (issues list for example) - user can see only his own time log.
Personally I think that much more confusing is situation, where issues list contain more details about issue than issue detail view, and user can't
easily see how many hours his spend on the issue.
#7 - 2017-01-19 13:35 - Go MAEDA- ファイル spent-time-issues-index.png を追加- ファイル spent-time-issues-show.png を追加
Robert Korulczyk wrote:
Go MAEDA wrote:
By this patch, different spent hours value is displayed for each user.
I am worried that it may cause confusion.

It already work in this way in multiple places (issues list for example) - user can see only his own time log.

Thank you for letting me know it. I didn't know. I agree with you now. I think that it is inconsistent.

#8 - 2017-01-19 14:01 - Go MAEDA- ファイル 20661-show-visible-spent-time.diff を追加
Updated the patch.
Also Issue.load̲visible̲total̲spent̲hours should be called to show correct value of total̲spent̲hours.
#10 - 2017-01-23 06:20 - Go MAEDA- 対象バージョン を Candidate for next minor release にセット
#11 - 2017-01-26 04:35 - Go MAEDA

2024-10-102/3

- 対象バージョン を Candidate for next minor release から 3.3.3 に変更
Let's resolve the inconsistency.
Setting target version to 3.3.3.
#12 - 2017-01-29 11:29 - Jean-Philippe Lang- ステータス を New から Resolved に変更- 担当者 を Jean-Philippe Lang にセット
Committed, thanks.
#13 - 2017-01-30 18:42 - Jean-Philippe Lang- ステータス を Resolved から Closed に変更#14 - 2017-01-30 18:47 - Jean-Philippe Lang
- 対象バージョン を 3.3.3 から 3.2.6 に変更#15 - 2017-04-05 18:10 - Jean-Philippe Lang
- 関連している Patch #25526: Revert API change in spent̲hours field in issue#show を追加

ファイル
show.html.erb.patch

631 Bytes

2015-09-02

Martin Dubéspent-time-issues-index.png

10.8 KB

2017-01-19

Go MAEDA

spent-time-issues-show.png

17.8 KB

2017-01-19

Go MAEDA

20661-show-visible-spent-time.diff

1.23 KB

2017-01-19

Go MAEDA

2024-10-10

3/3