Redmine - Patch #24313
Use the regular "icon icon-*" classes for all elements with icons
2016-11-09 22:27 - Marius B

LTEANU

ステータス:

Closed

開始日:

優先度:

Normal

期日:担当者:

Jean-Philippe Lang

進捗率:0%

カテゴリ:

Code cleanup/refactoring

予定工数:0.00時間対象バージョン:3.4.0

説明
Working at #23980 we discovered that some links or other elements with icons (background image) doesn't use the regular "iconicon-*" classes.
I think that for consistency, better theme support and easier styling, we should add the "icon icon-*" also to these elements.
The attached patch is a first patch that implements this for admin menu links.
関連するチケット:
関連している Redmine - Patch #28605: Add the missing icon class...

Closed関連している Redmine - Patch #31433: Use "icon icon-*" classes ...

Closed

関係しているリビジョン
リビジョン 15972 - 2016-11-18 15:44 - Jean-Philippe Lang
Use the regular "icon icon-*" for admin menu links (#24313).
Patch by Marius BALTEANU.
リビジョン 15973 - 2016-11-18 15:45 - Jean-Philippe Lang
Use the regular "icon icon-*" on project overview (#24313).
Patch by Marius BALTEANU.
リビジョン 15975 - 2016-11-18 17:04 - Jean-Philippe Lang
Use the regular "icon icon-*" on activity view (#24313).
Patch by Marius BALTEANU.
リビジョン 15976 - 2016-11-18 17:06 - Jean-Philippe Lang
Use the regular "icon icon-*" on roadmap (#24313).
Patch by Marius BALTEANU.
リビジョン 15977 - 2016-11-19 09:26 - Jean-Philippe Lang
Use the regular "icon icon-*" on search results (#24313).
リビジョン 15978 - 2016-11-19 09:53 - Jean-Philippe Lang
Use the regular "icon icon-*" in other pages (#24313).
リビジョン 15979 - 2016-11-19 09:57 - Jean-Philippe Lang
Small improvement (#24313).
Patch by Marius BALTEANU.
リビジョン 15980 - 2016-11-19 10:36 - Jean-Philippe LangFix icon-news class (#24313).

履歴#1 - 2016-11-10 01:10 - Marius B

2024-10-07

LTEANU

1/4

- ファイル 02̲use̲regular̲icons̲in̲overview̲tab.patch を追加- ファイル 03̲use̲regular̲icons̲in̲activity̲tab.patch を追加- ファイル 04̲use̲regular̲icons̲in̲version̲tab.patch を追加
Another patches for overview, activity and roadmap tabs.
#2 - 2016-11-12 15:16 - Marius B

LTEANU- ファイル 05̲use̲regular̲icons̲in̲search̲results.patch を追加- ファイル 06̲other̲pages.patch を追加- ファイル 07̲small̲improvement.patch を追加- ファイル 02̲use̲regular̲icons̲in̲overview̲tab̲v2.patch を追加
Added the last patches:- 05̲use̲regular̲icons̲in̲search̲results.patch:
The change from the view (app/views/search/index.html) was required because the classes in the search page are delimited by space and not by "-"like in the activity page even if are the same events. I think that this fix should be made in the Search and libs modules in order to return the sameevent̲type for closed issues, but I wasn't able to do it.
event type: closed issueclass in activity: "issue-closed"class in search: "issue closed"- 06̲other̲pages.patch
Changes in various pages: like favorite projects, members, attachments, forums.

- 07̲small̲improvement.patch:
The class "icon" should not have the rules with padding-top and padding-bottom because these are required only when the font size is smaller thanthe default one (like is in the contextual block or calendar).

- Updated an already uploaded patch to use the background-image rule and not just the background rule.
- There are some rules in the CSS file that I wasn't able to find them in the application:
table.boards

a.board{background:url(../images/comment.png)

span.add̲attachmenta{padding-left:16px;

background:no-repeat0%50%;

url(../images/bullet̲add.png)

padding-left:
no-repeat

020px;50%;}}.task̲late { background:#f66 url(../images/task̲late.png); border: 1px solid #f66; }.task̲done { background:#00c600 url(../images/task̲done.png); border: 1px solid #00c600; }.task̲todo { background:#aaa url(../images/task̲todo.png); border: 1px solid #aaa; }...
.project.task̲late { background:#f66 url(../images/milestone̲late.png); border: 1px solid #f66; height: 2px; margin-top: 3px;}.project.task̲done { background:#00c600 url(../images/milestone̲done.png); border: 1px solid #00c600; height: 2px; margin-top: 3px;}.project.task̲todo { background:#fff url(../images/milestone̲todo.png); border: 1px solid #fff; height: 2px; margin-top: 3px;}.project.marker { background-image:url(../images/project̲marker.png); background-repeat: no-repeat; border: 0; margin-left: -4px; margin-top:x; }Any feedback is welcome on this issue.
#3 - 2016-11-18 15:40 - Jean-Philippe Lang
- 対象バージョン を 3.4.0 にセット
#4 - 2016-11-18 17:05 - Jean-Philippe Lang
Activity view: event type class preserved in addition to the icon-* class.
#5 - 2016-11-18 18:52 - Marius B

LTEANU- ファイル 05̲use̲regular̲icons̲in̲search̲results̲v2.patch を追加
Jean-Philippe Lang wrote:
Activity view: event type class preserved in addition to the icon-* class.

2024-10-07

2/4

I've updated the patch 05̲use̲regular̲icons̲in̲search̲results.patch in order to preserve the event type class like you made in the activity.
Thanks for committing this patch so fast.
#6 - 2016-11-19 09:28 - Jean-Philippe Lang
Marius BALTEANU wrote:- 05̲use̲regular̲icons̲in̲search̲results.patch:
The change from the view (app/views/search/index.html) was required because the classes in the search page are delimited by space and notby "-" like in the activity page even if are the same events. I think that this fix should be made in the Search and libs modules in order to returnthe same event̲type for closed issues, but I wasn't able to do it.

There was a difference between Issue and Journal acts̲as̲event definition. It's fixed and I've removed the #parameterize call from the patch.
#7 - 2016-11-19 09:55 - Jean-Philippe LangPatch 6 committed with several changes. I've added a few icon-* (eg. icon-sticky) classes that are more meaningful than icon-arrow-right, even if
they actually use the same image in the default CSS.
#8 - 2016-11-19 09:58 - Jean-Philippe Lang- ステータス を New から Closed に変更- 担当者 を Jean-Philippe Lang にセット
And I've hidden the user icon on the member list, just like it was before the patches.
All patches are now committed, thanks.
#9 - 2016-11-19 10:04 - Marius B

LTEANU

Thanks Jean-Philippe Lang for your feedback on these patches.
I think that one more change is required, you committed the 02̲use̲regular̲icons̲in̲overview̲tab.patch and not the second version of the patch02̲use̲regular̲icons̲in̲overview̲tab̲v2.patch which contains a small fix for .icon-new class.

.icon-news{background:url(../images/news.png);{background-image:}should be.icon-news

url(../images/news.png);}#10 - 2016-11-19 10:36 - Jean-Philippe Lang
Marius BALTEANU wrote:
I think that one more change is required

Committed, thanks.
#11 - 2017-07-02 07:31 - Mischa The Evil
- 題名 を Use the regular "icon icon-*" classes for all elements with iconsに変更#12 - 2018-04-23 07:36 - Marius B

から Use the regular "icon icon-*" classes for all elements with icons

LTEANU- 関連している Patch #28605: Add the missing icon class to the items with icons from the contextual menu を追加#13 - 2019-05-27 21:42 - Marius B

LTEANU- 関連している Patch #31433: Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions を追加

ファイル
01̲user̲regular̲icons̲for̲admin̲links.patch

2024-10-07

5.62 KB

2016-11-09

Marius B

3/4

LTEANU02̲use̲regular̲icons̲in̲overview̲tab.patch

3.59 KB

2016-11-10

Marius B

LTEANU

03̲use̲regular̲icons̲in̲activity̲tab.patch

6.91 KB

2016-11-10

Marius B

LTEANU04̲use̲regular̲icons̲in̲version̲tab.patch

1.75 KB

2016-11-10

Marius B

LTEANU05̲use̲regular̲icons̲in̲search̲results.patch

10.1 KB

2016-11-12

Marius B

LTEANU07̲small̲improvement.patch

1.33 KB

2016-11-12

Marius B

LTEANU06̲other̲pages.patch

15 KB

2016-11-12

Marius B

LTEANU

02̲use̲regular̲icons̲in̲overview̲tab̲v2.patch

3.58 KB

2016-11-12

Marius B

LTEANU05̲use̲regular̲icons̲in̲search̲results̲v2.patch

1.9 KB

2016-11-18

Marius B

LTEANU

2024-10-07

4/4