Redmine - Patch #25775
Show assignee's icon in addition to author's icon
2017-05-06 08:01 - Go MAEDA

ステータス:

Closed

開始日:

優先度:

Normal

期日:担当者:

Jean-Philippe Lang

進捗率:0%

カテゴリ:

UI

予定工数:

0.00時間対象バージョン:3.4.0

説明In current versions of Redmine, author's icon is displayed in the upper left corner of issues if "Use Gravatar user icons" setting isenabled.
I think it would be very useful if we can see assignee's icon in addition to author's icon because who is the person in charge isimportant information to manage projects.
Currently we can see very small (14px) assignee's icon in "Assignee" field but it is not noticeable. If attached patch (0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch) is applied, assignee's icon will be much noticeable and we can easily
know current assignee.
assignee-icon-with-author-icon@2x.png
関連するチケット:
関連している Redmine - Feature #19648: Ability to show the Issu...

Closed関連している Redmine - Patch #26689: Add title to author's and ...

Closed関連している Redmine - Defect #26699: Anonymous user should hav...

Closed

関係しているリビジョン
リビジョン 16655 - 2017-06-10 14:09 - Jean-Philippe LangShow assignee's icon in addition to author's icon (#25775).
Patch by Go MAEDA.
リビジョン 16656 - 2017-06-10 14:18 - Jean-Philippe Lang
Adds tests for #25775.
リビジョン 16657 - 2017-06-10 14:19 - Jean-Philippe Lang
Removes duplicate avatar of assignee (#25775).
リビジョン 16658 - 2017-06-10 14:25 - Jean-Philippe Lang
Adds some margin to issue gravatar (#25775).

履歴#1 - 2017-05-06 08:39 - Go MAEDA- 関連している Feature #19648: Ability to show the Issue Assigne avatar instead of Author avatar を追加#2 - 2017-05-08 01:28 - Akiko Takano- ファイル 25775-test.patch を追加
i ve just tried above patch and it works fine. (Including responsive layout).
Since I made simple test for this patch, I hope this would be any help.
BTW, I m using not Gravatar but local avatar plugin to display avatars, https://github.com/ncoders/redmine̲local̲avatars.
It seems this plugin does not append / override class setting, such as "gravatar-child" to second avatar icon (for assignee), so that icon for assignee
does not appear at the expected position. (Not Lower right, but Upper right)
Of course, this is plugin2024-11-10

s reason, but if you could, please apply the same style to div.gravatar-with-child > img:nth-child(2).

1/3hg diff public/stylesheets/application.css
diff -r f5c7cc60ead2 public/stylesheets/application.css--- a/public/stylesheets/application.css
Tue Apr 25 17:44:08 2017 +0000+++ b/public/stylesheets/application.css
Mon May 08 08:14:29 2017 +0900@@ -1313,6 +1313,18 @@margin: 0 6px 0 0;}+div.gravatar-with-child {+position: relative;+}++img.gravatar-child, div.gravatar-with-child > img:nth-child(2)+position: absolute;+
top: 30px;+left: 30px;+
border-radius: 20%;+
border: 2px solid rgba(255, 255, 255, 0.9);+}{

Sorry, I failed to attach the patch for UI test. I'll attache it later.
#3 - 2017-05-08 09:24 - Go MAEDA- ファイル 0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch を追加
Akiko-san, thank you for adding tests and pointing out redmine̲local̲avatars plugin.
I have updated patch. Now it is compatible with the plugin.
#4 - 2017-05-08 13:54 - Akiko Takano- ファイル 25775-ui-test.patch を追加
Maeda-san, thank you for picking up my request.
As I wrote above, attach an additional ui test, I m glad if this would be help for reviewing or release planning.
(I tested with using Chromedriver and PhantomJS)
Sincerely,
Go MAEDA wrote:
Akiko-san, thank you for adding tests and pointing out redmine̲local̲avatars plugin.
I have updated patch. Now it is compatible with the plugin.

#5 - 2017-05-10 15:54 - Go MAEDA- 対象バージョン を 3.4.0 にセット
I am sure that this feature is useful for most users. And the feature got many likes on Twitter:
https://twitter.com/g̲maeda/status/861485901389504512
Let's merge this feature into trunk along with tests by Akiko Takano. Setting target version to 3.4.0.
#6 - 2017-05-10 16:14 - Marius B

LTEANU

Just a note regarding the tests, IMHO, there are no reasons to have UI tests with PhantomJS (which are slower) for this feature. The same assertions
can be made as well in a functional test.
#7 - 2017-05-11 02:58 - Akiko Takano
Marius, thanks for your comment.
The same assertions can be made as well in a functional test.

Sorry, since I do not know what kind of test is required, I uploaded both types of test.
Looking forward to the next release.
#8 - 2017-05-11 08:07 - Marius B

LTEANU

Akiko Takano wrote:2024-11-10

2/3

Sorry, since I do not know what kind of test is required, I uploaded both types of test.
Looking forward to the next release.

Ah, sorry, I didn't see the functional tests from 25775-test.patch. They look good to me.
#9 - 2017-05-12 09:03 - Jan from Planio www.plan.io
I think this feature would be a great UI improvement!
#10 - 2017-05-14 18:38 - Vasili Korol
It would be very nice to have this feature. Sometimes users mistake the author's avatar for the assignee.
#11 - 2017-06-10 14:27 - Jean-Philippe Lang- ステータス を New から Closed に変更- 担当者 を Jean-Philippe Lang にセット
Patch is committed with fixed functional tests. UI tests are not appropriate for this indeed.
I've also removed the duplicate assignee avatar to clean up the display.
Thanks.
#12 - 2017-08-14 22:49 - Marius B

LTEANU- 関連している Patch #26689: Add title to author's and assignee's icon を追加#13 - 2017-08-15 17:01 - Go MAEDA- 関連している Defect #26699: Anonymous user should have their icon を追加

ファイル
assignee-icon-with-author-icon@2x.png

90.3 KB

2017-05-06

Go MAEDA

0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch

1.52 KB

2017-05-06

Go MAEDA

25775-test.patch

1.01 KB

2017-05-07

Akiko Takano

0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch

1.56 KB

2017-05-08

Go MAEDA

25775-ui-test.patch

1.46 KB

2017-05-08

Akiko Takano

2024-11-10

3/3