Redmine - Feature #4866
New permission: view forum
2010-02-17 18:26 - Miah Xiccen

ステータス:

Closed開始日:

2010-02-17

優先度:

Normal

期日:担当者:

Jean-Philippe Lang

進捗率:0%

カテゴリ:

Permissions and roles

予定工数:

0.00時間対象バージョン:3.4.0

Resolution:

Fixed

説明
Currently it would be nice to be able to forbid viewing project forums to anonymous users.
A "Can view forums" checkbox in role permissions would suffice.
関連するチケット:
関連している Redmine - Feature #7555: Private forumsNew

2011-02-05

次のチケットが重複 Redmine - Feature #8618: New Permission: View F...

Closed2011-06-15

次のチケットが重複 Redmine - Feature #2224: add view persmission f...

Closed2008-11-24

関係しているリビジョン
リビジョン 16637 - 2017-06-07 22:20 - Jean-Philippe Lang
New Permission: View Forum (#4866).
Patch by Felix Schäfer.

履歴#1 - 2011-11-10 19:19 - Mischa The Evil
- 題名 を Forum view permissions から New Permission: View Forum に変更
This would solve several use-cases I think. Some quotes from #8618 (duplicating issue):Jochen Manz wrote:
Most of the Permission do have a View XXXX checkbox, but not the forum. In my case i wanted to give a customer access to our redmine. Infact he is able to see our discussion forum which is not ment to be public. Its definetly a missing thing.

mark B. wrote:
I've got the same problem. Work-around was to move the forum to another private project, but this is less than ideal, as it really should all bein the same project. Causes confusion and extra clicks.

#2 - 2013-11-08 05:28 - Mischa The Evil
- 関連している Feature #7555: Private forums を追加#3 - 2017-04-19 16:50 - Felix Schäfer- ファイル 4866.patch を追加
The attached patch makes the "view messages" permission configurable, similar to #7068#note-5. This patch does not include translations as thoseare already present.
#4 - 2017-04-21 07:13 - Go MAEDA- 対象バージョン を Candidate for next major release にセット
Felix, thank you for the patch. It works fine but breaks some tests on my environment. Could you take a look?
ruby test/functional/boards̲controller̲test.rbruby test/functional/boards̲controller̲test.rb

2024-11-09

1/3

Run
#options:--seed48663

Running:

F.F....FF.F..FF.....
Finishedin

1.551336s,

12.8921runs/s,30.9411assertions/s.

1) Failure:
BoardsControllerTest#test̲show [test/functional/boards̲controller̲test.rb:50]:
Expected response to be a <success>, but was <302>2) Failure:
BoardsControllerTest#test̲index [test/functional/boards̲controller̲test.rb:29]:
Expected response to be a <success>, but was <302>3) Failure:
BoardsControllerTest#test̲show̲with̲permission̲should̲display̲the̲new̲message̲form
Expected response to be a <success>, but was <403>
4) Failure:
BoardsControllerTest#test̲show̲should̲display̲sticky̲messages̲first
Expected response to be a <success>, but was <302>[test/functional/boards̲controller̲test.rb:92]:[test/functional/boards̲controller̲test.rb:62]:

5) Failure:
BoardsControllerTest#test̲index̲should̲show̲messages̲if̲only̲one̲board
Expected response to be a <success>, but was <302>[test/functional/boards̲controller̲test.rb:42]:

6) Failure:
BoardsControllerTest#test̲show̲atom [test/functional/boards̲controller̲test.rb:101]:
Expected response to be a <success>, but was <302>7) Failure:
BoardsControllerTest#test̲show̲should̲display̲message̲with̲last̲reply̲first
Expected response to be a <success>, but was <302>
20

runs,

48

assertions,7

failures,0errors,0[test/functional/boards̲controller̲test.rb:81]:

skips

ruby test/functional/messages̲controller̲test.rbruby test/functional/messages̲controller̲test.rb
Run#options:--seed480

Running:

F............FFFF..
Finishedin2.647736s,

7.1759runs/s,18.5064

assertions/s.

1) Failure:
MessagesControllerTest#test̲show [test/functional/messages̲controller̲test.rb:29]:
Expected response to be a <success>, but was <302>2) Failure:
MessagesControllerTest#test̲show̲with̲pagination [test/functional/messages̲controller̲test.rb:58]:
Expected response to be a <success>, but was <302>3) Failure:
MessagesControllerTest#test̲show̲should̲contain̲reply̲field̲tags̲for̲quoting
Expected response to be a <success>, but was <403>
4) Failure:
MessagesControllerTest#test̲post̲new
Expected nil to not be nil.

[test/functional/messages̲controller̲test.rb:37]:[test/functional/messages̲controller̲test.rb:113]:

5) Failure:
MessagesControllerTest#test̲show̲with̲reply̲permission [test/functional/messages̲controller̲test.rb:67]:
Expected response to be a <success>, but was <403>
19runs,49assertions,

5failures,

0errors,

0skips#5 - 2017-04-21 11:02 - Felix Schäfer

2024-11-09

2/3

- ファイル 4866-2.patch を追加
You are correct, the tests make the assumption that this permission is public. I have added the permission to the test fixtures and they work now.
#6 - 2017-04-22 04:53 - Go MAEDA- 対象バージョン を Candidate for next major release から 3.4.0 に変更
The patch works fine and passed all tests.
I think that delivering this feature along with #7068 makes permission control system of Redmine more consistent. Setting target version to 3.4.0.
#7 - 2017-06-07 22:22 - Jean-Philippe Lang- ステータス を New から Closed に変更- 担当者 を Jean-Philippe Lang にセット
- Resolution を Fixed にセット
Committed, thanks for the patch.
#8 - 2017-06-09 08:47 - Mischa The Evil
- 題名 を New Permission: View Forum から New permission: view forum に変更#9 - 2017-09-04 14:34 - Go MAEDA- 次のチケットが重複 Feature #2224: add view persmission for board を追加

ファイル
4866.patch

3.59 KB

2017-04-19

Felix Schäfer

4866-2.patch

4.69 KB

2017-04-21

Felix Schäfer

2024-11-09

3/3