Project: Eclipse_Platform_UI
Bug 109281 [Viewers] ContentViewer does not null out input on handleDisposed
Reported: 2005-09-12 07:57:38 | Status: verified fixed

While tracking down a possible leak I were calling viewer.setInput(null) when viewer.getInput()!=null but that gave an assert exception because the ContentProvider had been nulled out in handleDisposed(). I suggest you also null out Input to keep the state consistent since the code actually call inputChanged as if input had been nulled out. protected void handleDispose(DisposeEvent event) { if (contentProvider != null) { contentProvider.inputChanged(this, getInput(), null); contentProvider.dispose(); contentProvider = null; input = null; // add this line for consistency } if (labelProvider != null) { labelProvider.removeListener(labelProviderListener); labelProvider.dispose(); labelProvider = null; } }

Files changed in fix:
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/ContentViewer.java