Project: Eclipse_Platform_UI
Bug 252940 [Dialogs] DialogPage's dispose() method has a false javadoc specification
Reported: 2008-10-31 05:47:42 | Status: verified fixed

The DialogPage class's dispose() method is spec'ed as... /** * The <code>DialogPage</code> implementation of an * <code>IDialogPage</code> method does nothing. Subclasses may extend. */ ...unfortunately, the truth is that it actually does something rather important. public void dispose() { // deallocate SWT resources if (image != null) { image.dispose(); image = null; } } I am marking this as major since unwary subclasses that extends this method without calling super.dispose() will end up having a memory leak.

Files changed in fix:
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogPage.java