Project: JDT
Bug 118479 [api] Need a way to get a shared instance of JavaTextTools
Reported: 2005-11-29 13:45:52 | Status: verified fixed

JavaTextTools contains tools required to cofigure a java text viewer, and those tools can be shared via JavaTextTools. Currently, when clients want to use those tools, they need to first create a new instance of JavaTextTools and then share their instance of JavaTextTools in order to share the tools in JavaTextTools. This seems like it goes against the purpose of JavaTextTools. You should only really have 1 instance of JavaTextTools (at least per preferenceStore) Plus, you also need to make sure you dispose JavaTextTools, so by having only 1 instance, it'll be easier to keep track of to dispose. JDT is already kind of doing this by only creating one instance of JavaTextTools in JavaPlugin. I think this one instance should be shared amongst other clients instead of just the jdt plugin. A new method should be added to JavaUI, getJavaTextTools, which gets JavaTextTools from JavaPlugin.

Files changed in fix:
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/JavaUI.java org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/JavaTextTools.java