Project: Eclipse_Platform_UI
Bug 212894 [About] AboutDialog doesn't properly handle invalid plugin certificates
Reported: 2007-12-13 11:02:29 | Status: verified fixed

Build: 3.4 M4. Steps: - Alter the signature of a bundle in the platform (add some random chars to ECLIPSE.RSA file of some bundle). - Open Help > About - Click Plugin Details - An "internal error" dialog pops up complaining of an IllegalStateException, and there is some spew in the log. When a plugin has a bad signature, it should just have an appropriate icon in the "Signed" column. It shouldn't open an error dialog or write errors to the log. !ENTRY org.eclipse.core.jobs 4 2 2007-12-13 10:43:53.359 !MESSAGE An internal error occurred during: "org.apache.commons.logging.source". !STACK 0 java.lang.IllegalStateException at org.eclipse.ui.internal.about.AboutBundleData.isSigned(AboutBundleData.java:112) at org.eclipse.ui.internal.dialogs.AboutPluginsDialog$2.run(AboutPluginsDialog.java:105) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55) Caused by: java.io.IOException: Not a valid PKCS#7 file at org.eclipse.osgi.internal.verifier.PKCS7Processor.<init>(PKCS7Processor.java:131) at org.eclipse.osgi.internal.verifier.SignedBundleFile.processSigner(SignedBundleFile.java:520) at org.eclipse.osgi.internal.verifier.SignedBundleFile.setBundleFile(SignedBundleFile.java:472) at org.eclipse.osgi.internal.verifier.SignedBundleHook.getVerifier(SignedBundleHook.java:165) at org.eclipse.osgi.internal.verifier.SignedBundleHook.getVerifier(SignedBundleHook.java:177) at org.eclipse.ui.internal.about.AboutBundleData.isSigned(AboutBundleData.java:107) ... 2 more

Files changed in fix:
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutBundleData.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/BundleSigningInfo.java