Project: JDT
Bug 157480 [clean up] Add paranoical parantheses does mess up expressions
Reported: 2006-09-15 11:07:52 | Status: verified fixed

While running cleanup on our whole codebase, I've found a particular file that is incorrectly modified by the cleanup process. Specifically, this: if(target == null && other.target == null || (target != null && target.equals(other.target))) targetEquals = true; return sourceEquals && targetEquals; } becomes this: if(( && (other.target == null))(target == null) || ((target != null) && target.equals(other.target))) { targetEquals = true; } I'll attach source before/after cleanup attached plus screenshots of every steps (including options selected for the cleanup.

Files changed in fix:
org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/CleanUpTest.java org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CleanUpRefactoring.java