Project: Eclipse_Platform_UI
Bug 298130 Cannot add parameters to commands through Ecore editor
Reported: 2009-12-17 17:38:13 | Status: resolved fixed

Build Identifier: I20091210-2100 [Apologies for mangling terminology: I'm not very familiar with EMF.] The definitions in UIElements.ecore of HandledItems and KeyBinding don't mark their "parameters" field as being contained. Since there's no other container for parameters, you cannot define parameters from the Ecore editor. Reproducible: Always Steps to Reproduce: 1. Open up an Application.xmi 2. Create a command that takes a parameter. 3. Add a handled item (e.g., a toolbar item). Set its command to to the command defined in step #2. 4. Right click on the handled item and ask to add a child. See that Command Parameter does not appear.

Files changed in fix:
bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/MApplicationPackage.java bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/MHandledItem.java bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/MKeyBinding.java bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/impl/ApplicationPackageImpl.java bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/impl/HandledItemImpl.java bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/impl/HandledMenuItemImpl.java bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/impl/HandledToolItemImpl.java bundles/org.eclipse.e4.ui.model.workbench/src/org/eclipse/e4/ui/model/application/impl/KeyBindingImpl.java