Project: JDT
Bug 31281 Push down refactoring: Dialog details + exception
Reported: 2003-02-07 08:54:19 | Status: resolved fixed

20030206 Select a method and choose Refactoring->Push down - The message at the botton says '1 element(s) selected'. It should end with a dot (I would use 'member' istead of 'element' - double click should open the edit view - deselect all methods. An error icon comes up, the message says 'Select members to push down or declare abstract' As this is an error message (it has a big error icon) it should better be 'No members selected to push down' - the images in the table could be small (option of the label provider) - the edit dialog needs a title that is capitalized - the edit dialog should be initialized with the current values -deselect all elements, and press 'add required', you get an exception java.lang.reflect.InvocationTargetException: java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 at java.util.ArrayList.get(ArrayList.java(Compiled Code)) at java.util.ArrayList.get(ArrayList.java(Compiled Code)) at org.eclipse.jdt.internal.corext.refactoring.structure.PushDownRefactoring.getAdd itionalRequiredMembers(PushDownRefactoring.java:438) at org.eclipse.jdt.internal.corext.refactoring.structure.PushDownRefactoring.comput eAdditionalRequiredMembersToPushDown(PushDownRefactoring.java:426) at org.eclipse.jdt.internal.ui.refactoring.PushDownInputPage$6.run (PushDownInputPage.java:338) at org.eclipse.jface.operation.ModalContext.runInCurrentThread (ModalContext.java:296) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:246)

Files changed in fix:
org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/structure/PullUpRefactoring.java org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/structure/PushDownRefactoring.java org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/ComboSelectionDialog.java org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/PullUpInputPage1.java org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/PushDownInputPage.java