Project: Eclipse_Platform_UI
Bug 121709 [Commands] parameters: Add types
Reported: 2005-12-21 05:07:37 | Status: verified fixed

I'm going to attach a patch that adds support for typed command parameters. This addresses several issues: - parameter values are strings, but handlers may want to work on objects - multiple handlers of a command should have a consistent way of converting string parameter values to objects - tooling to construct parameterized commands that starts with object parameter values needs a way of producing string parameter values that will work when the command is executed - there should be a way to classify commands by their object parameter types so, given an object, a set of commands that may work with it can be suggested To address these issues, the patch allows parameter types to be declared in the extension-point XML. The example below defines a command for negating integers and a parameter type that works with it. <extension point="org.eclipse.ui.commands"> <command id="org.example.commands.negateInteger" defaultHandler="org.example.commands.NegateIntegerHandler" name="Negate an Integer"> <commandParameter id="param" name="the param" optional="false" typeId="org.example.commands.Integer"/> </command> <commandParameterType id="org.example.commands.Integer" converter="org.example.commands.IntegerConverter" type="java.lang.Integer"/> </extension> In addition to extending the schema for org.eclipse.ui.commands, code has been added to a number of plugins (primarily org.eclipse.core.commands) to support the notion of typed parameters.

Files changed in fix:
bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/AbstractParameterValueConverter.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/Command.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/CommandManager.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/CommandManagerEvent.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/ExecutionEvent.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/ExecutionException.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/IParameterTypeListener.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/ITypedParameter.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/ParameterType.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/ParameterTypeEvent.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/ParameterValueConversionException.java bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/ParameterizedCommand.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/ICommandService.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/handlers/CommandLegacyActionWrapper.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/commands/CommandLegacyWrapper.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/commands/CommandPersistence.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/commands/CommandService.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/commands/Parameter.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/commands/ParameterValueConverterProxy.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/IRegistryConstants.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/commands/CommandParameterTypeTest.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/commands/CommandsTestSuite.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/commands/IntegerConverter.java tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/commands/SubtractIntegerHandler.java