Project: Eclipse_Platform_UI
Bug 230449 [KeyBindings] NPE in KPP when deleting conflicting keybinding
Reported: 2008-05-06 14:09:20 | Status: verified fixed

Reproduced with I20080502-0100 and I20080502-0100 base + HEAD code in runtime workspace. 1. Window > Preferences > General > Keys 2. 'Activate Editor' should be bound to F12 (this should be the second entry). 3. Select 'About' (this should be the first entry). 4. Click the 'Binding' text field, hit 'F12'. 5. The conflict table is updated showing a conflict between 'About' and 'Activate Editor'. 6. Hit Ctrl+C, the keybinding is now > F12, Ctrl+C 7. Use the backspace to clear the keybinding. 8. 'About' has no keybinding, but so does 'Activate Editor' (!). 9. NPE is logged in .log. java.lang.NullPointerException at org.eclipse.ui.internal.keys.model.KeyController.updateTrigger(KeyController.java:352) at org.eclipse.ui.internal.keys.model.KeyController$4.propertyChange(KeyController.java:228) at org.eclipse.ui.internal.keys.model.KeyController.firePropertyChange(KeyController.java:100) at org.eclipse.ui.internal.keys.model.BindingElement.setTrigger(BindingElement.java:113) at org.eclipse.ui.internal.keys.NewKeysPreferencePage$5.propertyChange(NewKeysPreferencePage.java:698) at org.eclipse.jface.bindings.keys.KeySequenceText.firePropertyChangeEvent(KeySequenceText.java:736) at org.eclipse.jface.bindings.keys.KeySequenceText.setKeySequence(KeySequenceText.java:929) at org.eclipse.jface.bindings.keys.KeySequenceText$KeyTrapListener.handleEvent(KeySequenceText.java:129) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)

Files changed in fix:
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/model/KeyController.java