Project: Eclipse_Platform_UI
Bug 296822 NullProgressMonitor is not thread safe for expected usage
Reported: 2009-12-03 10:47:18 | Status: resolved fixed

NullProgressMonitor.setCanceled and isCanceled access the cancelled field, but there's no synchronization. The expected use is that setCanceled is called from a thread other than the one doing the work, which polls isCanceled(), so this needs to be thread safe. Could either make these two methods synchronized or make the field volatile. Should check other progress monitor implementations too.

Files changed in fix:
bundles/org.eclipse.jface/src/org/eclipse/jface/action/StatusLine.java bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/ProgressMonitorDialog.java bundles/org.eclipse.jface/src/org/eclipse/jface/wizard/ProgressMonitorPart.java