Project: Eclipse_Platform_UI
Bug 358739 MinMaxAddon has a dependency on o.e.u.workbench
Reported: 2011-09-23 11:37:22 | Status: verified fixed

This was introduced by me late in M2 in order to get the animation effects out for review. We should likely just clone the required classes into some consumable e4 bundle... At the same time we should move the MinMax constants out of the addon itself and into IPresentationEngine (with comments indicating that presentation engine implementations should honor these tags if they support min/max). This will allow us to remove the current hack in WorkbenchPage where we are using copies of these strings directly.

Files changed in fix:
bundles/org.eclipse.e4.ui.workbench.addons.swt/src/org/eclipse/e4/ui/workbench/addons/minmax/MinMaxAddon.java bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/AnimationEngine.java bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/AnimationFeedbackBase.java bundles/org.eclipse.e4.ui.workbench.swt/src/org/eclipse/e4/ui/internal/workbench/swt/FaderAnimationFeedback.java bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/workbench/IPresentationEngine.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java