Project: Eclipse_Platform_UI
Bug 265204 [About] Consider revising button contribution strategy in InstallationPage
Reported: 2009-02-17 15:07:55 | Status: verified fixed

Some of the things that are provided in the platform installation pages might be of general use to more clients. Consider promoting these concepts to API...They are listed in order of importance. - The about CopyHandler redirects the copy command to the page. We could make this handler API and add the copy protocol in InstallationPage so that any page could use this handler for easy copy support. Otherwise each page has to come up with their own handler. - The support for setting selection variables is currently provided in ProductInfoPage. We could consider promoting this concept to InstallationPage so that client pages need only hook selection handlers on their list and call some framework method. I'm not even sure a client could get this working without us doing something here (because InstallationDialogSourceProvider is not API). - We could consider a common handler and command for getting the details of a selection inside an installation page. This could open a properties page or expand a tray. - ConfigureColumnsHandler and columns command. If an installation page provides a table, the same handler and command could be used to manipulate columns. (Another thought is to just get rid of this dialog.)

Files changed in fix:
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/about/ActiveInstallationPageExpression.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/about/IInstallationPageContainer.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/about/IInstallationPageSources.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/about/InstallationPage.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutPluginsPage.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/ConfigureColumnsHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/CopyHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/InstallationDialog.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/InstallationDialogSourceProvider.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/OpenBrowserHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/ProductInfoDialog.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/ProductInfoPage.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/ProductInfoPageHandler.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/TableListPage.java bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/ViewErrorLogHandler.java