Project: Eclipse_Platform_UI
Bug 89246 [EditorMgmt] PartInitException: No saved state can be found for this editor, when closing editors
Reported: 2005-03-28 12:31:27 | Status: verified fixed

build N20050328 I've seen this in my own workspace as well, since I20050315. When this happens, it leaves zombie editors around in the list (e.g. they show up in the Ctrl+F6 list). Could this be due to recent EditorManager changes? It should not be trying to restore editors while closing all editors. Also, why does unzooming trigger part restoration? Unzooming should not change the active part, which should already be restored. [java] !ENTRY org.eclipse.ui 4 0 2005-03-28 08:48:52.656 [java] !MESSAGE Unable to create editor ID : No saved state can be found for this editor [java] !STACK 1 [java] org.eclipse.ui.PartInitException: No saved state can be found for this editor [java] at org.eclipse.ui.internal.EditorManager$Editor.getRestoredInput(EditorManager.java:1693) [java] at org.eclipse.ui.internal.EditorManager.busyRestoreEditorHelper(EditorManager.java:1152) [java] at org.eclipse.ui.internal.EditorManager.busyRestoreEditor(EditorManager.java:1077) [java] at org.eclipse.ui.internal.EditorManager$7.run(EditorManager.java:1039) [java] at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) [java] at org.eclipse.ui.internal.EditorManager.restoreEditor(EditorManager.java:1037) [java] at org.eclipse.ui.internal.EditorManager$Editor.getEditor(EditorManager.java:1623) [java] at org.eclipse.ui.internal.EditorManager$Editor.getPart(EditorManager.java:1614) [java] at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:260) [java] at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:126) [java] at org.eclipse.ui.internal.presentations.newapi.TabbedStackPresentation.setVisible(TabbedStackPresentation.java:310) [java] at org.eclipse.ui.internal.PartStack.setVisible(PartStack.java:924) [java] at org.eclipse.ui.internal.PartSashContainer.zoomOut(PartSashContainer.java:925) [java] at org.eclipse.ui.internal.PartSashContainer.childRequestZoomOut(PartSashContainer.java:867) [java] at org.eclipse.ui.internal.PartSashContainer.remove(PartSashContainer.java:670) [java] at org.eclipse.ui.internal.EditorSashContainer.removeEditor(EditorSashContainer.java:221) [java] at org.eclipse.ui.internal.EditorAreaHelper.closeEditor(EditorAreaHelper.java:119) [java] at org.eclipse.ui.internal.EditorAreaHelper.closeEditor(EditorAreaHelper.java:108) [java] at org.eclipse.ui.internal.EditorManager.closeEditor(EditorManager.java:225) [java] at org.eclipse.ui.internal.WorkbenchPage.closeEditors(WorkbenchPage.java:1021) [java] at org.eclipse.ui.internal.WorkbenchPage.closeAllEditors(WorkbenchPage.java:959) [java] at org.eclipse.ui.internal.WorkbenchPage.dispose(WorkbenchPage.java:1329) [java] at org.eclipse.ui.internal.WorkbenchWindow.closeAllPages(WorkbenchWindow.java:654) [java] at org.eclipse.ui.internal.WorkbenchWindow.hardClose(WorkbenchWindow.java:1243) [java] at org.eclipse.ui.internal.WorkbenchWindow.busyClose(WorkbenchWindow.java:537) [java] at org.eclipse.ui.internal.WorkbenchWindow.access$0(WorkbenchWindow.java:518) [java] at org.eclipse.ui.internal.WorkbenchWindow$1.run(WorkbenchWindow.java:619) [java] at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) [java] at org.eclipse.ui.internal.WorkbenchWindow.close(WorkbenchWindow.java:617) [java] at org.eclipse.ui.tests.util.UITestCase.closeAllTestWindows(UITestCase.java:186) [java] at org.eclipse.ui.tests.util.UITestCase.doTearDown(UITestCase.java:148) [java] at org.eclipse.ui.tests.zoom.ZoomTestCase.doTearDown(ZoomTestCase.java:75) [java] at org.eclipse.ui.tests.util.UITestCase.tearDown(UITestCase.java:136) [java] at junit.framework.TestCase.runBare(TestCase.java:130) [java] at junit.framework.TestResult$1.protect(TestResult.java:106) [java] at junit.framework.TestResult.runProtected(TestResult.java:124) [java] at junit.framework.TestResult.run(TestResult.java:109) [java] at junit.framework.TestCase.run(TestCase.java:118) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:313) [java] at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:199) [java] at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188) [java] at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) [java] at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:118) [java] at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:2871) [java] at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2530) [java] at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1563) [java] at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1527) [java] at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:306) [java] at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) [java] at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) [java] at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:131) [java] at org.eclipse.test.UITestApplication.run(UITestApplication.java:58) [java] at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) [java] at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:338) [java] at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:151) [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [java] at java.lang.reflect.Method.invoke(Method.java:324) [java] at org.eclipse.core.launcher.Main.invokeFramework(Main.java:315) [java] at org.eclipse.core.launcher.Main.basicRun(Main.java:268) [java] at org.eclipse.core.launcher.Main.run(Main.java:942) [java] at org.eclipse.core.launcher.Main.main(Main.java:926) [java] !SUBENTRY 1 org.eclipse.ui 4 0 2005-03-28 08:48:52.656 [java] !MESSAGE No saved state can be found for this editor [java] ----- testCloseActiveFastView [java] testCloseActiveFastView: setUp... [java] testCloseActiveFastView: tearDown...

Files changed in fix:
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/EditorManager.java