Project: JDT
Bug 60557 Inline method: creates same AST 4 times [refactoring]
Reported: 2004-04-30 08:16:01 | Status: resolved fixed

I20040430 The current implementation of InlineAction#run(ITextSelection) is rather expensive. If you set the caret to a method call and run Refactor > Inline, the same AST (with bindings) is created 4 times: 3 times for each try... method and a last time when the refactoring is finally executed. The problem is that we don't pass the AST around.

Files changed in fix:
org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/RefactoringExecutionStarter.java org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/InlineTempRefactoring.java org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/util/RefactoringASTParser.java org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/actions/InlineConstantAction.java org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/actions/InlineMethodAction.java org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/InlineAction.java org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/actions/InlineTempAction.java