Project: Eclipse_Platform_UI
Bug 158020 Lazy initialize ViewerComparator.comparator
Reported: 2006-09-20 12:40:13 | Status: verified fixed

20060920 In the ViewerSorter I remember that a performance problem was that that the default constructor called Collator.getInstance() which can be expensive for the first caller. So in JDT we overrode getCollator() to do a lazy initialization. Couldn't this be added to the ViewerComparator by default? In ViewerSorter it wasn't possible as collator was protected. In ViewerComparator this isn't a problem. -> public ViewerComparator(){ this(null); } protected Comparator getComparator() { if (comparator == null) comparator= Policy.getComparator(); return comparator; }

Files changed in fix:
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/ViewerComparator.java