Project: Eclipse_Platform_UI
Bug 284265 [JFace] DialogSettings.save() silently ignores IOException
Reported: 2009-07-22 09:35:16 | Status: verified fixed

Build ID: M20090211-1700 (Problem still in HEAD) STEPS TO REPRODUCE Call DialogSettings.save() on a Writer that produced a IOException or with a file which causes trouble during output (e.g. full drive). EXPECTED The original exception thrown by the underlying output should be propagated to the caller -- as "save() throws IOException" suggests. ACTUAL The IOException is silently ignored. ANALYSIS The internal DialogSettings.XMLWriter is based in a java.io.PrintWriter, which catches all IOExceptions.

Files changed in fix:
bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogSettings.java tests/org.eclipse.ui.tests/Eclipse JFace Tests/org/eclipse/jface/tests/dialogs/DialogSettingsTest.java