Going to tag 0.9.2 final

Going to tag 0.9.2 final
2014-06-13 11:21 ` Pavel Janík
  2014-06-13 19:24 ` xor
  
From: Wladimir @ 2014-06-13 10:18 UTC (permalink / raw)
  To: Bitcoin Dev

Hello,

I haven't heard of any new issues with either Bitcoin Core 0.9.2rc1 or
0.9.2rc2. This means that it is time to tag 0.9.2 final.

If you have a critical issue that you haven't reported yet please let
me know as soon as possible. If I do not hear anything, I will do a
last-minute language import and tag the release at the end of the
(UTC) day so that gitian builds can be started.

Corrections to the release notes
(https://github.com/bitcoin/bitcoin/blob/0.9.2/doc/release-notes.md)
should also be submitted before then.

Thanks,
Wladimir



 permalink raw reply	[|nested]
2014-06-13 10:18 [Bitcoin-development] Going to tag 0.9.2 final Wladimir

  2014-06-13 11:58   ` Wladimir
  2014-06-13 19:24 ` xor
  
From: Pavel Janík @ 2014-06-13 11:21 UTC (permalink / raw)
  To: Bitcoin Dev

Wladimir,

On Jun 13, 2014, at 12:18 PM, Wladimir wrote:

> If I do not hear anything, I will do a last-minute language import

this import can actually break things. I'd avoid it.
-- 
Pavel Janík






 permalink raw reply	[|nested]
2014-06-13 11:21 ` Pavel Janík

  2014-06-13 12:02     ` Pavel Janík
  
From: Wladimir @ 2014-06-13 11:58 UTC (permalink / raw)
  To: Pavel Janík;  Bitcoin Dev

[-- Attachment #1: Type: text/plain, Size: 38 bytes --]

It cannot, it is just data.

Wladimir

[-- Attachment #2: Type: text/html, Size: 71 bytes --]

 permalink raw reply	[|nested]
2014-06-13 11:58   ` Wladimir

  
From: Pavel Janík @ 2014-06-13 12:02 UTC (permalink / raw)
  To: Wladimir;  Bitcoin Dev


On Jun 13, 2014, at 1:58 PM, Wladimir wrote:

> It cannot, it is just data.

The (new) data can break user interface (at least).
-- 
Pavel Janík






 permalink raw reply	[|nested]
2014-06-13 10:18 [Bitcoin-development] Going to tag 0.9.2 final Wladimir
  2014-06-13 11:21 ` Pavel Janík

  2014-06-13 20:06   ` Matt Whitlock
  2014-06-13 20:12   ` Jeff Garzik
  
From: xor @ 2014-06-13 19:24 UTC (permalink / raw)
  To: bitcoin-development

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Friday, June 13, 2014 12:18:37 PM Wladimir wrote:
> If I do not hear anything, I will do a
> last-minute language import

High risk projects as Bitcoin should NOT see ANY changes between release 
candidates and releases.

You can cause severe havoc with ANY changes. Humans make mistakes!
Please do not do such things!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iQIcBAEBCAAGBQJTm0/pAAoJEMtmZ+8tjWt5/NMP/Ap+/wCXJD4pWod0zerg0kZF
+GV43rxONVhxKzktoU7DhHI4c0qcv1K4nmpxhsgtzt+WIig0jAew+p3KrXoseYtn
g91Wx2rquPMYc+2hQ5w0G3iYinn3YJAWKgMAlFO+Ri4TGkhq90P/sM1uVvdZFaMT
0QGXA+cANk21NF9jZcL+7C3yYtFwWY9hgRLXtq6YWL0aFwD0pXFmFicg76Sfs+XL
7Aty+eJeCFxlxf9gdIUnQobOu4+ptPPZt4WRBIvBQUWYt6FzvCfc3+RgSAkJZqfi
3+61eW/akfZBUS/Avp0bWgsVSovScJrqPG0JNuJfqH2cEtS9STDggnelRmQ+KLfM
JtcnfXGJ4PPCt8mRsrtrEHXTAAlyfC69FV8tUk2eaPjVzoa5XR0s/4Zz/+hGSZ4a
x+AIzMgK0OlclVWWf9hMYvKu4GE/C4WR5egnK1sUmphbcgZu1+N5/s/lDR1N3Yze
rOr89zyc3dLedMeWHaT0ohxa9OP2i87mRyUGglgGctcR9R5PTUokYHkoAZpORLDS
sfLnClvGwPFLT4nAt9cBfyW3fr9766lZrYFTc0DyKbNTIpNSV+6ZDPQoxlO7MFn1
mqfTleP8ENLJ+2WCtFXZMcym9gQ8Relw0n7rm7TqqKayePLwE05vKecvKf6psbcn
M8tAv0jhS3T8g9btAFyU
=LSGU
-----END PGP SIGNATURE-----




 permalink raw reply	[|nested]
2014-06-13 19:24 ` xor

  2014-06-13 20:12   ` Jeff Garzik
  
From: Matt Whitlock @ 2014-06-13 20:06 UTC (permalink / raw)
  To: bitcoin-development

On Friday, 13 June 2014, at 9:24 pm, xor wrote:
> On Friday, June 13, 2014 12:18:37 PM Wladimir wrote:
> > If I do not hear anything, I will do a
> > last-minute language import
> 
> High risk projects as Bitcoin should NOT see ANY changes between release
> candidates and releases.
> 
> You can cause severe havoc with ANY changes. Humans make mistakes!
> Please do not do such things!

Agreed. Does Bitcoin Core not have a release cycle policy? Typically mission-critical projects will enter a code and resource freeze prior to tagging a release candidate, after which point only critical bugfixes are allowed into the release branch. A language translation update does not qualify as a critical bugfix and should be merged during the next release cycle.



 permalink raw reply	[|nested]
2014-06-13 19:24 ` xor
  2014-06-13 20:06   ` Matt Whitlock

  2014-06-14  5:28     ` Wladimir
  
From: Jeff Garzik @ 2014-06-13 20:12 UTC (permalink / raw)
  To: xor;  Bitcoin Dev

On Fri, Jun 13, 2014 at 3:24 PM, xor <xor@freenetproject•org> wrote:
> On Friday, June 13, 2014 12:18:37 PM Wladimir wrote:
>> If I do not hear anything, I will do a
>> last-minute language import
>
> High risk projects as Bitcoin should NOT see ANY changes between release
> candidates and releases.
>
> You can cause severe havoc with ANY changes. Humans make mistakes!
> Please do not do such things!

As a general principle, I agree.  Other projects have translation
freeze points to address this.  Although it is a small holistic risk,
in theory, someone could maliciously change strings at the last minute
in a language maintainers don't know well.

-- 
Jeff Garzik
Bitcoin core developer and open source evangelist
BitPay, Inc.      https://bitpay.com/



 permalink raw reply	[|nested]
2014-06-13 20:12   ` Jeff Garzik

  2014-06-14  5:42       ` Un Ix
  
From: Wladimir @ 2014-06-14  5:28 UTC (permalink / raw)
  To: Jeff Garzik;  Bitcoin Dev

On Fri, Jun 13, 2014 at 10:12 PM, Jeff Garzik <jgarzik@bitpay•com> wrote:
> As a general principle, I agree.  Other projects have translation
> freeze points to address this.  Although it is a small holistic risk,
> in theory, someone could maliciously change strings at the last minute
> in a language maintainers don't know well.

I was just doing what was always done. In practice, the translations
follow a very different cycle than the rest of the code. Entering
translations as well as reviewing them happens inside Transifex.

Sure, someone could "maliciously change strings". It's typical that
this little bikeshedding topic attracts so much attention.

But if it makes all of you happy I won't do the translation update.

Wladimir



 permalink raw reply	[|nested]
2014-06-14  5:28     ` Wladimir

  2014-06-14  5:49         ` Matt Whitlock
  2014-06-14  6:23         ` Wladimir
  
From: Un Ix @ 2014-06-14  5:42 UTC (permalink / raw)
  To: Wladimir;  Bitcoin Dev

How about a prize for anyone who can spot any "malicious" strings within next hour?

;-)

> On 14/06/2014, at 1:32 pm, "Wladimir" <laanwj@gmail•com> wrote:
> 
>> On Fri, Jun 13, 2014 at 10:12 PM, Jeff Garzik <jgarzik@bitpay•com> wrote:
>> As a general principle, I agree.  Other projects have translation
>> freeze points to address this.  Although it is a small holistic risk,
>> in theory, someone could maliciously change strings at the last minute
>> in a language maintainers don't know well.
> 
> I was just doing what was always done. In practice, the translations
> follow a very different cycle than the rest of the code. Entering
> translations as well as reviewing them happens inside Transifex.
> 
> Sure, someone could "maliciously change strings". It's typical that
> this little bikeshedding topic attracts so much attention.
> 
> But if it makes all of you happy I won't do the translation update.
> 
> Wladimir
> 
> ------------------------------------------------------------------------------
> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
> Find What Matters Most in Your Big Data with HPCC Systems
> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
> Leverages Graph Analysis for Fast Processing & Easy Data Exploration
> http://p.sf.net/sfu/hpccsystems
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists•sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development



 permalink raw reply	[|nested]
2014-06-14  5:42       ` Un Ix

  2014-06-14  5:58           ` Un Ix
  2014-06-14  6:23         ` Wladimir
  
From: Matt Whitlock @ 2014-06-14  5:49 UTC (permalink / raw)
  To: Un Ix;  bitcoin-development

On Saturday, 14 June 2014, at 1:42 pm, Un Ix wrote:
> How about a prize for anyone who can spot any "malicious" strings within next hour?

I think it's more an issue of accidental breakage than any maliciousness. One character in the wrong place in a language bundle somewhere can make the difference between success and runtime failure, and it may not be immediately apparent when running in unaffected locales. This kind of problem isn't likely to result in data loss (or money loss, where money is data, is in Bitcoin), but it could be enough to necessitate scrapping the whole release, which would look bad and prompt users to question the dev team's quality control process.



 permalink raw reply	[|nested]
2014-06-14  5:49         ` Matt Whitlock

  2014-06-14  6:01             ` Mark Friedenbach
  2014-06-14  6:12             ` Wladimir
  
From: Un Ix @ 2014-06-14  5:58 UTC (permalink / raw)
  To: Matt Whitlock;  bitcoin-development

Was joking, but isn't the translation process back-ended with runtime tests to ensure that any stray chars etc cause the application to fail?

> On 14/06/2014, at 1:49 pm, "Matt Whitlock" <bip@mattwhitlock•name> wrote:
> 
>> On Saturday, 14 June 2014, at 1:42 pm, Un Ix wrote:
>> How about a prize for anyone who can spot any "malicious" strings within next hour?
> 
> I think it's more an issue of accidental breakage than any maliciousness. One character in the wrong place in a language bundle somewhere can make the difference between success and runtime failure, and it may not be immediately apparent when running in unaffected locales. This kind of problem isn't likely to result in data loss (or money loss, where money is data, is in Bitcoin), but it could be enough to necessitate scrapping the whole release, which would look bad and prompt users to question the dev team's quality control process.



 permalink raw reply	[|nested]
2014-06-14  5:58           ` Un Ix

  2014-06-14  6:12             ` Wladimir
  
From: Mark Friedenbach @ 2014-06-14  6:01 UTC (permalink / raw)
  To: bitcoin-development

Not when failure is defined as, e.g., extra text pushing a UI element
down such that the button the user needs to click is no longer visible.
You don't test that except by having a human being run through some
example workflows, which is presumably happening during the release process.

On 06/13/2014 10:58 PM, Un Ix wrote:
> Was joking, but isn't the translation process back-ended with runtime
> tests to ensure that any stray chars etc cause the application to
> fail?
> 
>> On 14/06/2014, at 1:49 pm, "Matt Whitlock" <bip@mattwhitlock•name>
>> wrote:
>> 
>>> On Saturday, 14 June 2014, at 1:42 pm, Un Ix wrote: How about a
>>> prize for anyone who can spot any "malicious" strings within next
>>> hour?
>> 
>> I think it's more an issue of accidental breakage than any
>> maliciousness. One character in the wrong place in a language
>> bundle somewhere can make the difference between success and
>> runtime failure, and it may not be immediately apparent when
>> running in unaffected locales. This kind of problem isn't likely to
>> result in data loss (or money loss, where money is data, is in
>> Bitcoin), but it could be enough to necessitate scrapping the whole
>> release, which would look bad and prompt users to question the dev
>> team's quality control process.
> 



 permalink raw reply	[|nested]
2014-06-14  5:58           ` Un Ix
  2014-06-14  6:01             ` Mark Friedenbach

  
From: Wladimir @ 2014-06-14  6:12 UTC (permalink / raw)
  To: Un Ix;  bitcoin-development

On Sat, Jun 14, 2014 at 7:58 AM, Un Ix <slashdevnull@hotmail•com> wrote:
> Was joking, but isn't the translation process back-ended with runtime tests to ensure that any stray chars etc cause the application to fail?

There is some postprocessing done in the script that fetches
translation files (see
https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/update-translations.py
). It removes stray control characters, but for example there is no
check for number and presence of formatting characters. I generally
check that by manually looking through the diffs. But would be great
if someone added that.

Wladimir



 permalink raw reply	[|nested]
2014-06-14  5:42       ` Un Ix
  2014-06-14  5:49         ` Matt Whitlock

  
From: Wladimir @ 2014-06-14  6:23 UTC (permalink / raw)
  To: Un Ix;  Bitcoin Dev

On Sat, Jun 14, 2014 at 7:42 AM, Un Ix <slashdevnull@hotmail•com> wrote:
> How about a prize for anyone who can spot any "malicious" strings within next hour?
>
> ;-)

Hah, if there was to be a prize I'd rather have people looking out for
icebergs than for wrongly arranged deck chairs :-)

Wladimir



 permalink raw reply	[|nested]