Roles and procedures around adding a bitcoin core maintainer

Roles and procedures around adding a bitcoin core maintainer
2022-12-20 18:44 ` Michael Folkson
  
From: alicexbt @ 2022-12-19 21:58 UTC (permalink / raw)
  To: Bitcoin Protocol Discussion

Hi Bitcoin Developers,

List of present bitcoin core maintainers:

|   Username    |    Focus Area   |
| ------------- | -------------   |
|  MarcoFalke   | General, QA     | 
|  fanquake     | General, Build  |
|  hebasto      | General, UI/UX  |
|  achow101     | General, Wallet |
|  glozow       | General, Mempool|

Last 2 developers that stepped down as bitcoin core maintainer:

|   Username    | 
| ------------- | 
|     sipa      | 
|     laanwj    | 

Process followed in adding last maintainer:

1) fanquake [nominated][0] glowzow as rbf/mempool/validation maintainer. 
2) It was discussed in an IRC [meeting][1] and most of the developers agreed to add her as new maintainer except mild NACK from Jeremy Rubin. Some contributors did not like different opinions being shared in the meeting.
3) A [pull request][2] was opened by glowzow to add keys. There were several ACKs, 2 NACKs and 1 meta concept NACK.
   My NACK: https://github.com/bitcoin/bitcoin/pull/25524#issuecomment-1172518409
   NACK by jamesob: https://github.com/bitcoin/bitcoin/pull/25524#issuecomment-1172570635
   Meta concept NACK by luke-jr: https://github.com/bitcoin/bitcoin/pull/25524#issuecomment-1175625779

   Eventually everyone agreed to add glowzow as maintainer and improve the process of adding maintainers. Pull request was merged by MarcoFalke.

Initiatives to improve the process and documentation:

1) Jeremy opened a [pull request][3] and there were lot of disagreements with the documentation. It was closed since a related PR with less changes could be easy to agree upon. 
2) Related [pull request][4] with minimal documentation was also closed by Jeremy with a comment that desire to improve docs seems to be missing based on reviews.
3) Jeremy opened an [issue][5] with title 'Call for Maintainer: P2P & Networking + Privacy' which was changed later and 'Privacy' was removed. He nominated jonatack and vasild was already self nominated so mentioned in the pull request. Nobody appreciated this effort to nominate self or others for a new maintainer. Later this was closed.
4) I had opened an [issue][6] with title Call for Maintainer: Privacy'. This even involved privacy of contributors and not just bitcoin core. It received some comments that made no sense and I eventually closed the issue. 

Process being followed for adding vasild as maintainer:

1) vasild volunteered to be a new maintainer on [IRC][7]
2) It was discussed in IRC [meeting][8], some developers ACKed it and there were no issues.
3) A [pull request][9] was opened by vasild to add keys which is still open and its been 4 months. There were already some ACKs from the IRC meeting and pull request also received some ACKs (16 until now). fanquake, dergoegge and JeremyRubin had some disagreements. Jeremy had recently withdrawn all ACK/NACK from bitcoin core repository for some reasons, fanquake has not replied yet and dergoegge had some new disagreements although don't mind if the pull request is merged.
4) Earlier disagreements were related to scoping and it was changed by vasild
4) There was even a comment that disrespected vasild's contributions in bitcoin core and we had to literally share pull requests in which vasild has improved bitcoin core.
5) I tried adding the topic for a bitcoin core dev weekly meeting but did not achieve anything.


Since Bitcoin Core is the reference implementation for Bitcoin and used by 90% nodes, what should be the ideal process or changes you would expect in roles, procedures etc.?

- 'Call for maintainers' issue should be opened if contributors or maintainers need a new maintainer.
- Discussion about nominated contributors in an IRC meeting where everyone is allowed to share their opinion.
- One of the nominated contributor that gets most ACKs could open pull request to add keys. Everyone can ACK/NACK this PR with reasons.
- Maintainers should be unbiased in merging these pull requests.
- New maintainer should not be funded by the organization that already does it for most of the maintainers.
- Long term contributors that are not living in a first world country should be encouraged.
- Either we should agree every maintainer is a general maintainer that can merge pull request from different modules or define scope for present and new maintainers. We can't do both.
- Self merging pull requests should be avoided.

Let me know if you have any thoughts that could improve this process and involve less politics. 
   

[0]: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-06-28#826651
[1]: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-06-30#827695
[2]: https://github.com/bitcoin/bitcoin/pull/25524
[3]: https://github.com/bitcoin/bitcoin/pull/25560
[4]: https://github.com/bitcoin/bitcoin/pull/25839
[5]: https://github.com/bitcoin/bitcoin/issues/25870
[6]: https://github.com/bitcoin/bitcoin/issues/25875
[7]: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-08-12#842847;
[8]: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-08-18#844523
[9]: https://github.com/bitcoin/bitcoin/pull/25871

/dev/fd0
'floppy disc guy'

Sent with Proton Mail secure email.


 permalink raw reply	[|nested]
2022-12-19 21:58 [bitcoin-dev] Roles and procedures around adding a bitcoin core maintainer alicexbt

  2023-01-07  5:11   ` alicexbt
  
From: Michael Folkson @ 2022-12-20 18:44 UTC ( / )
  To: alicexbt, Bitcoin Protocol Discussion

Hi alicexbt

There does seem to be some confusion on this which I'm going to look into. I don't think ranting and raving or throwing toys out the pram on the mailing list is the productive way to go though. I'll chat to some people offline and see what the confusion is and hopefully this can be resolved without unnecessary drama. I'll respond in the new year. I don't know if you celebrate but if you do Happy Holidays.

Thanks
Michael

--
Michael Folkson
Email: michaelfolkson at protonmail.com
Keybase: michaelfolkson
PGP: 43ED C999 9F85 1D40 EAF4 9835 92D6 0159 214C FEE3


------- Original Message -------
On Monday, December 19th, 2022 at 23:58, alicexbt via bitcoin-dev <bitcoin-dev@lists•linuxfoundation.org> wrote:


> Hi Bitcoin Developers,
> 
> List of present bitcoin core maintainers:
> 
> Username
> 
> Focus Area
> 
> MarcoFalke
> 
> General, QA
> 
> fanquake
> 
> General, Build
> 
> hebasto
> 
> General, UI/UX
> 
> achow101
> 
> General, Wallet
> 
> glozow
> 
> General, Mempool
> 
> Last 2 developers that stepped down as bitcoin core maintainer:
> 
> Username
> 
> -------------
> 
> sipa
> 
> laanwj
> 
> Process followed in adding last maintainer:
> 
> 1) fanquake [nominated][0] glowzow as rbf/mempool/validation maintainer.
> 
> 2) It was discussed in an IRC [meeting][1] and most of the developers agreed to add her as new maintainer except mild NACK from Jeremy Rubin. Some contributors did not like different opinions being shared in the meeting.
> 
> 3) A [pull request][2] was opened by glowzow to add keys. There were several ACKs, 2 NACKs and 1 meta concept NACK.
> 
> My NACK: https://github.com/bitcoin/bitcoin/pull/25524#issuecomment-1172518409
> 
> NACK by jamesob: https://github.com/bitcoin/bitcoin/pull/25524#issuecomment-1172570635
> 
> Meta concept NACK by luke-jr: https://github.com/bitcoin/bitcoin/pull/25524#issuecomment-1175625779
> 
> Eventually everyone agreed to add glowzow as maintainer and improve the process of adding maintainers. Pull request was merged by MarcoFalke.
> 
> Initiatives to improve the process and documentation:
> 
> 1) Jeremy opened a [pull request][3] and there were lot of disagreements with the documentation. It was closed since a related PR with less changes could be easy to agree upon.
> 
> 2) Related [pull request][4] with minimal documentation was also closed by Jeremy with a comment that desire to improve docs seems to be missing based on reviews.
> 
> 3) Jeremy opened an [issue][5] with title 'Call for Maintainer: P2P & Networking + Privacy' which was changed later and 'Privacy' was removed. He nominated jonatack and vasild was already self nominated so mentioned in the pull request. Nobody appreciated this effort to nominate self or others for a new maintainer. Later this was closed.
> 
> 4) I had opened an [issue][6] with title Call for Maintainer: Privacy'. This even involved privacy of contributors and not just bitcoin core. It received some comments that made no sense and I eventually closed the issue.
> 
> Process being followed for adding vasild as maintainer:
> 
> 1) vasild volunteered to be a new maintainer on [IRC][7]
> 
> 2) It was discussed in IRC [meeting][8], some developers ACKed it and there were no issues.
> 
> 3) A [pull request][9] was opened by vasild to add keys which is still open and its been 4 months. There were already some ACKs from the IRC meeting and pull request also received some ACKs (16 until now). fanquake, dergoegge and JeremyRubin had some disagreements. Jeremy had recently withdrawn all ACK/NACK from bitcoin core repository for some reasons, fanquake has not replied yet and dergoegge had some new disagreements although don't mind if the pull request is merged.
> 
> 4) Earlier disagreements were related to scoping and it was changed by vasild
> 
> 4) There was even a comment that disrespected vasild's contributions in bitcoin core and we had to literally share pull requests in which vasild has improved bitcoin core.
> 
> 5) I tried adding the topic for a bitcoin core dev weekly meeting but did not achieve anything.
> 
> Since Bitcoin Core is the reference implementation for Bitcoin and used by 90% nodes, what should be the ideal process or changes you would expect in roles, procedures etc.?
> 
> - 'Call for maintainers' issue should be opened if contributors or maintainers need a new maintainer.
> 
> - Discussion about nominated contributors in an IRC meeting where everyone is allowed to share their opinion.
> 
> - One of the nominated contributor that gets most ACKs could open pull request to add keys. Everyone can ACK/NACK this PR with reasons.
> 
> - Maintainers should be unbiased in merging these pull requests.
> 
> - New maintainer should not be funded by the organization that already does it for most of the maintainers.
> 
> - Long term contributors that are not living in a first world country should be encouraged.
> 
> - Either we should agree every maintainer is a general maintainer that can merge pull request from different modules or define scope for present and new maintainers. We can't do both.
> 
> - Self merging pull requests should be avoided.
> 
> Let me know if you have any thoughts that could improve this process and involve less politics.
> 
> [0]: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-06-28#826651
> 
> [1]: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-06-30#827695
> 
> [2]: https://github.com/bitcoin/bitcoin/pull/25524
> 
> [3]: https://github.com/bitcoin/bitcoin/pull/25560
> 
> [4]: https://github.com/bitcoin/bitcoin/pull/25839
> 
> [5]: https://github.com/bitcoin/bitcoin/issues/25870
> 
> [6]: https://github.com/bitcoin/bitcoin/issues/25875
> 
> [7]: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-08-12#842847;
> 
> [8]: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2022-08-18#844523
> 
> [9]: https://github.com/bitcoin/bitcoin/pull/25871
> 
> /dev/fd0
> 
> 'floppy disc guy'
> 
> Sent with Proton Mail secure email.
> 
> _______________________________________________
> 
> bitcoin-dev mailing list
> 
> bitcoin-dev@lists•linuxfoundation.org
> 
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev
2022-12-20 18:44 ` Michael Folkson

  
From: alicexbt @ 2023-01-07  5:11 UTC (permalink / raw)
  To: Michael Folkson;  Bitcoin Protocol Discussion

Hi Michael,

> I don't think ranting and raving or throwing toys out the pram on the mailing list is the productive way to go though.

It was the best possible way I found to summarize everything, look for opinions to improve the process, feedback about PR #25871 open since 140 days and includes no raving.

> I'll chat to some people offline and see what the confusion is and hopefully this can be resolved without unnecessary drama. 

I like all my Bitcoin and Bitcoin Core communication to be public for transparency and documentation purposes. Except reporting vulnerabilities although some bitcoin core developers even post vulns in public as GitHub issue when it involves other implementations.


/dev/fd0
floppy disc guy

Sent with Proton Mail secure email.


------- Original Message -------
On Wednesday, December 21st, 2022 at 12:14 AM, Michael Folkson michaelfolkson@protonmail•com wrote:



> Hi alicexbt
> 
> There does seem to be some confusion on this which I'm going to look into. I don't think ranting and raving or throwing toys out the pram on the mailing list is the productive way to go though. I'll chat to some people offline and see what the confusion is and hopefully this can be resolved without unnecessary drama. I'll respond in the new year. I don't know if you celebrate but if you do Happy Holidays.
> 
> Thanks
> Michael
> 
> --
> Michael Folkson
> Email: michaelfolkson at protonmail.com
> Keybase: michaelfolkson
> PGP: 43ED C999 9F85 1D40 EAF4 9835 92D6 0159 214C FEE3
> 
> ------- Original Message -------
> On Monday, December 19th, 2022 at 23:58, alicexbt via bitcoin-dev bitcoin-dev@lists•linuxfoundation.org wrote:
> 
> > Hi Bitcoin Developers,
> > 
> > List of present bitcoin core maintainers:
> > 
> > Username
> > 
> > Focus Area
> > 
> > MarcoFalke
> > 
> > General, QA
> > 
> > fanquake
> > 
> > General, Build
> > 
> > hebasto
> > 
> > General, UI/UX
> > 
> > achow101
> > 
> > General, Wallet
> > 
> > glozow
> > 
> > General, Mempool
> > 
> > Last 2 developers that stepped down as bitcoin core maintainer:
> > 
> > Username
> > 
> > -------------
> > 
> > sipa
> > 
> > laanwj
> > 
> > Process followed in adding last maintainer:
> > 
> > 1) fanquake nominated glowzow as rbf/mempool/validation maintainer.
> > 
> > 2) It was discussed in an IRC meeting and most of the developers agreed to add her as new maintainer except mild NACK from Jeremy Rubin. Some contributors did not like different opinions being shared in the meeting.
> > 
> > 3) A pull request was opened by glowzow to add keys. There were several ACKs, 2 NACKs and 1 meta concept NACK.
> > 
> > My NACK: https://github.com/bitcoin/bitcoin/pull/25524#issuecomment-1172518409
> > 
> > NACK by jamesob: https://github.com/bitcoin/bitcoin/pull/25524#issuecomment-1172570635
> > 
> > Meta concept NACK by luke-jr: https://github.com/bitcoin/bitcoin/pull/25524#issuecomment-1175625779
> > 
> > Eventually everyone agreed to add glowzow as maintainer and improve the process of adding maintainers. Pull request was merged by MarcoFalke.
> > 
> > Initiatives to improve the process and documentation:
> > 
> > 1) Jeremy opened a pull request and there were lot of disagreements with the documentation. It was closed since a related PR with less changes could be easy to agree upon.
> > 
> > 2) Related pull request with minimal documentation was also closed by Jeremy with a comment that desire to improve docs seems to be missing based on reviews.
> > 
> > 3) Jeremy opened an issue with title 'Call for Maintainer: P2P & Networking + Privacy' which was changed later and 'Privacy' was removed. He nominated jonatack and vasild was already self nominated so mentioned in the pull request. Nobody appreciated this effort to nominate self or others for a new maintainer. Later this was closed.
> > 
> > 4) I had opened an issue with title Call for Maintainer: Privacy'. This even involved privacy of contributors and not just bitcoin core. It received some comments that made no sense and I eventually closed the issue.
> > 
> > Process being followed for adding vasild as maintainer:
> > 
> > 1) vasild volunteered to be a new maintainer on IRC
> > 
> > 2) It was discussed in IRC meeting, some developers ACKed it and there were no issues.
> > 
> > 3) A pull request was opened by vasild to add keys which is still open and its been 4 months. There were already some ACKs from the IRC meeting and pull request also received some ACKs (16 until now). fanquake, dergoegge and JeremyRubin had some disagreements. Jeremy had recently withdrawn all ACK/NACK from bitcoin core repository for some reasons, fanquake has not replied yet and dergoegge had some new disagreements although don't mind if the pull request is merged.
> > 
> > 4) Earlier disagreements were related to scoping and it was changed by vasild
> > 
> > 4) There was even a comment that disrespected vasild's contributions in bitcoin core and we had to literally share pull requests in which vasild has improved bitcoin core.
> > 
> > 5) I tried adding the topic for a bitcoin core dev weekly meeting but did not achieve anything.
> > 
> > Since Bitcoin Core is the reference implementation for Bitcoin and used by 90% nodes, what should be the ideal process or changes you would expect in roles, procedures etc.?
> > 
> > - 'Call for maintainers' issue should be opened if contributors or maintainers need a new maintainer.
> > 
> > - Discussion about nominated contributors in an IRC meeting where everyone is allowed to share their opinion.
> > 
> > - One of the nominated contributor that gets most ACKs could open pull request to add keys. Everyone can ACK/NACK this PR with reasons.
> > 
> > - Maintainers should be unbiased in merging these pull requests.
> > 
> > - New maintainer should not be funded by the organization that already does it for most of the maintainers.
> > 
> > - Long term contributors that are not living in a first world country should be encouraged.
> > 
> > - Either we should agree every maintainer is a general maintainer that can merge pull request from different modules or define scope for present and new maintainers. We can't do both.
> > 
> > - Self merging pull requests should be avoided.
> > 
> > Let me know if you have any thoughts that could improve this process and involve less politics.
> > 
> > /dev/fd0
> > 
> > 'floppy disc guy'
> > 
> > Sent with Proton Mail secure email.
> > 
> > _______________________________________________
> > 
> > bitcoin-dev mailing list
> > 
> > bitcoin-dev@lists•linuxfoundation.org
> > 
> > https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev


 permalink raw reply	[|nested]