Repository: prompt-toolkit/python-prompt-toolkit (branch: nested-scrolling)
Commit date: 2024-01-17T18:43:30Z

Workflow file: .github/workflows/test.yaml (test)
name: test

on:
  push: # any branch
  pull_request:
    branches: [master]

env:
  FORCE_COLOR: '1'
  PIP_INDEX_URL: http://localhost:8629/2024-01-17
  UV_INDEX_URL: http://localhost:8629/2024-01-17

jobs:
  test-ubuntu:
    runs-on: ubuntu-latest
    services:
      pypi_wayback:
        image: ghcr.io/waleko/pypi-wayback
        ports:
          - 8629:8080
    strategy:
      fail-fast: false
      matrix:
        python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]

    steps:
      - uses: actions/checkout@v4
      - name: Setup Python ${{ matrix.python-version }}
        uses: actions/setup-python@v4
        with:
          python-version: ${{ matrix.python-version }}
          allow-prereleases: true
      - name: Install Dependencies
        run: |
          sudo apt remove python3-pip
          python -m pip install --upgrade pip
          python -m pip install . ruff typos coverage codecov mypy pytest readme_renderer types-contextvars asyncssh
          pip list
      - name: Ruff
        run: |
          ruff .
          ruff format --check .
          typos .
      - name: Tests
        run: |
          coverage run -m pytest
      - if: "matrix.python-version != '3.7'"
        name: Mypy
        # Check whether the imports were sorted correctly.
        # When this fails, please run ./tools/sort-imports.sh
        run: |
          mypy --strict src/prompt_toolkit --platform win32
          mypy --strict src/prompt_toolkit --platform linux
          mypy --strict src/prompt_toolkit --platform darwin
      - name: Validate README.md
        # Ensure that the README renders correctly (required for uploading to PyPI).
        run: |
          python -m readme_renderer README.rst > /dev/null
      - name: Run codecov
        run: |
          codecov


Failed build logs:
step_name: test-ubuntu (3.7)/5_Ruff.txt
log: ##[group]Run ruff .
[36;1mruff .[0m
[36;1mruff format --check .[0m
[36;1mtypos .[0m
shell: /usr/bin/bash -e {0}
env:
  FORCE_COLOR: 1
  pythonLocation: /opt/hostedtoolcache/Python/3.7.17/x64
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.7.17/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.7.17/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.7.17/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.7.17/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.7.17/x64/lib
##[endgroup]
src/prompt_toolkit/layout/containers.py:2562:31: UP037 [*] Remove quotes from type annotation
src/prompt_toolkit/layout/containers.py:2577:29: UP037 [*] Remove quotes from type annotation
Found 2 errors.
[*] 2 fixable with the `--fix` option.
##[error]Process completed with exit code 1.

step_name: test-ubuntu (3.8)/5_Ruff.txt
log: ##[group]Run ruff .
[36;1mruff .[0m
[36;1mruff format --check .[0m
[36;1mtypos .[0m
shell: /usr/bin/bash -e {0}
env:
  FORCE_COLOR: 1
  pythonLocation: /opt/hostedtoolcache/Python/3.8.18/x64
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.8.18/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.8.18/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.8.18/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.8.18/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.18/x64/lib
##[endgroup]
src/prompt_toolkit/layout/containers.py:2562:31: UP037 [*] Remove quotes from type annotation
src/prompt_toolkit/layout/containers.py:2577:29: UP037 [*] Remove quotes from type annotation
Found 2 errors.
[*] 2 fixable with the `--fix` option.
##[error]Process completed with exit code 1.

step_name: test-ubuntu (3.9)/5_Ruff.txt
log: ##[group]Run ruff .
[36;1mruff .[0m
[36;1mruff format --check .[0m
[36;1mtypos .[0m
shell: /usr/bin/bash -e {0}
env:
  FORCE_COLOR: 1
  pythonLocation: /opt/hostedtoolcache/Python/3.9.18/x64
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib
##[endgroup]
src/prompt_toolkit/layout/containers.py:2562:31: UP037 [*] Remove quotes from type annotation
src/prompt_toolkit/layout/containers.py:2577:29: UP037 [*] Remove quotes from type annotation
Found 2 errors.
[*] 2 fixable with the `--fix` option.
##[error]Process completed with exit code 1.

step_name: test-ubuntu (3.10)/5_Ruff.txt
log: ##[group]Run ruff .
[36;1mruff .[0m
[36;1mruff format --check .[0m
[36;1mtypos .[0m
shell: /usr/bin/bash -e {0}
env:
  FORCE_COLOR: 1
  pythonLocation: /opt/hostedtoolcache/Python/3.10.13/x64
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib
##[endgroup]
src/prompt_toolkit/layout/containers.py:2562:31: UP037 [*] Remove quotes from type annotation
src/prompt_toolkit/layout/containers.py:2577:29: UP037 [*] Remove quotes from type annotation
Found 2 errors.
[*] 2 fixable with the `--fix` option.
##[error]Process completed with exit code 1.

step_name: test-ubuntu (3.11)/5_Ruff.txt
log: ##[group]Run ruff .
[36;1mruff .[0m
[36;1mruff format --check .[0m
[36;1mtypos .[0m
shell: /usr/bin/bash -e {0}
env:
  FORCE_COLOR: 1
  pythonLocation: /opt/hostedtoolcache/Python/3.11.7/x64
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.7/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.7/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.7/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.7/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.7/x64/lib
##[endgroup]
src/prompt_toolkit/layout/containers.py:2562:31: UP037 [*] Remove quotes from type annotation
src/prompt_toolkit/layout/containers.py:2577:29: UP037 [*] Remove quotes from type annotation
Found 2 errors.
[*] 2 fixable with the `--fix` option.
##[error]Process completed with exit code 1.

step_name: test-ubuntu (3.12)/5_Ruff.txt
log: ##[group]Run ruff .
[36;1mruff .[0m
[36;1mruff format --check .[0m
[36;1mtypos .[0m
shell: /usr/bin/bash -e {0}
env:
  FORCE_COLOR: 1
  pythonLocation: /opt/hostedtoolcache/Python/3.12.1/x64
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.1/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.1/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.1/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.1/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.1/x64/lib
##[endgroup]
src/prompt_toolkit/layout/containers.py:2562:31: UP037 [*] Remove quotes from type annotation
src/prompt_toolkit/layout/containers.py:2577:29: UP037 [*] Remove quotes from type annotation
Found 2 errors.
[*] 2 fixable with the `--fix` option.
##[error]Process completed with exit code 1.


Changed files:
src/prompt_toolkit/layout/containers.py

Fix diff:
diff --git a/src/prompt_toolkit/layout/containers.py b/src/prompt_toolkit/layout/containers.py
index ee714017..a0d1e005 100644
--- a/src/prompt_toolkit/layout/containers.py
+++ b/src/prompt_toolkit/layout/containers.py
@@ -2559,7 +2559,7 @@ class Window(Container):
 
         return NotImplemented
 
-    def _scroll_down(self) -> "NotImplementedOrNone":
+    def _scroll_down(self) -> NotImplementedOrNone:
         "Scroll window down."
         info = self.render_info
 
@@ -2574,7 +2574,7 @@ class Window(Container):
 
         return NotImplemented
 
-    def _scroll_up(self) -> "NotImplementedOrNone":
+    def _scroll_up(self) -> NotImplementedOrNone:
         "Scroll window up."
         info = self.render_info