Repository: encode/httpx (branch: add-ssl-context-argument)
Commit date: 2023-12-28T12:53:22Z

Workflow file: .github/workflows/test-suite.yml (Test Suite)
---
name: Test Suite

on:
  push:
    branches: ["master"]
  pull_request:
    branches: ["master"]

jobs:
  tests:
    name: "Python ${{ matrix.python-version }}"
    runs-on: "ubuntu-latest"
    services:
      pypi_wayback:
        image: ghcr.io/waleko/pypi-wayback
        ports:
          - 8629:8080

    strategy:
      matrix:
        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]

    steps:
      - uses: "actions/checkout@v4"
      - uses: "actions/setup-python@v4"
        with:
          python-version: "${{ matrix.python-version }}"
          allow-prereleases: true
      - name: "Install dependencies"
        run: "scripts/install"
      - name: "Run linting checks"
        run: "scripts/check"
      - name: "Build package & docs"
        run: "scripts/build"
      - name: "Run tests"
        run: "scripts/test"
      - name: "Enforce coverage"
        run: "scripts/coverage"

env:
  PIP_INDEX_URL: http://localhost:8629/2023-12-28
  UV_INDEX_URL: http://localhost:8629/2023-12-28


Failed build logs:
step_name: Python 3.10/5_Run linting checks.txt
log: ##[group]Run scripts/check
[36;1mscripts/check[0m
shell: /usr/bin/bash -e {0}
env:
  pythonLocation: /opt/hostedtoolcache/Python/3.10.13/x64
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib
##[endgroup]
+ ./scripts/sync-version
CHANGELOG_VERSION: 0.26.0
VERSION: 0.26.0
+ ruff format httpx tests --diff
60 files left unchanged
+ mypy httpx tests
httpx/_client.py:1456: error: Unexpected keyword argument "verify" for "AsyncHTTPTransport"  [call-arg]
httpx/_client.py:1458: error: Name "verify" is not defined  [name-defined]
httpx/_client.py:1459: error: Name "cert" is not defined  [name-defined]
httpx/_transports/default.py:260: note: "AsyncHTTPTransport" defined here
httpx/_client.py:1456: error: Unexpected keyword argument "cert" for "AsyncHTTPTransport"  [call-arg]
httpx/_transports/default.py:260: note: "AsyncHTTPTransport" defined here
Found 4 errors in 1 file (checked 60 source files)
##[error]Process completed with exit code 1.

step_name: Python 3.11/5_Run linting checks.txt
log: ##[group]Run scripts/check
[36;1mscripts/check[0m
shell: /usr/bin/bash -e {0}
env:
  pythonLocation: /opt/hostedtoolcache/Python/3.11.7/x64
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.7/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.7/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.7/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.7/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.7/x64/lib
##[endgroup]
+ ./scripts/sync-version
CHANGELOG_VERSION: 0.26.0
VERSION: 0.26.0
+ ruff format httpx tests --diff
60 files left unchanged
+ mypy httpx tests
httpx/_client.py:1456: error: Unexpected keyword argument "verify" for "AsyncHTTPTransport"  [call-arg]
httpx/_client.py:1458: error: Name "verify" is not defined  [name-defined]
httpx/_client.py:1459: error: Name "cert" is not defined  [name-defined]
httpx/_transports/default.py:260: note: "AsyncHTTPTransport" defined here
httpx/_client.py:1456: error: Unexpected keyword argument "cert" for "AsyncHTTPTransport"  [call-arg]
httpx/_transports/default.py:260: note: "AsyncHTTPTransport" defined here
Found 4 errors in 1 file (checked 60 source files)
##[error]Process completed with exit code 1.

step_name: Python 3.12/5_Run linting checks.txt
log: ##[group]Run scripts/check
[36;1mscripts/check[0m
shell: /usr/bin/bash -e {0}
env:
  pythonLocation: /opt/hostedtoolcache/Python/3.12.1/x64
  PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.1/x64/lib/pkgconfig
  Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.1/x64
  Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.1/x64
  Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.1/x64
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.1/x64/lib
##[endgroup]
+ ./scripts/sync-version
CHANGELOG_VERSION: 0.26.0
VERSION: 0.26.0
+ ruff format httpx tests --diff
60 files left unchanged
+ mypy httpx tests
httpx/_client.py:1456: error: Unexpected keyword argument "verify" for "AsyncHTTPTransport"  [call-arg]
httpx/_client.py:1458: error: Name "verify" is not defined  [name-defined]
httpx/_client.py:1459: error: Name "cert" is not defined  [name-defined]
httpx/_transports/default.py:260: note: "AsyncHTTPTransport" defined here
httpx/_client.py:1456: error: Unexpected keyword argument "cert" for "AsyncHTTPTransport"  [call-arg]
httpx/_transports/default.py:260: note: "AsyncHTTPTransport" defined here
Found 4 errors in 1 file (checked 60 source files)
##[error]Process completed with exit code 1.


Changed files:
httpx/_client.py

Fix diff:
diff --git a/httpx/_client.py b/httpx/_client.py
index e5cff5d..4dd2d07 100644
--- a/httpx/_client.py
+++ b/httpx/_client.py
@@ -1455,8 +1455,6 @@ class AsyncClient(BaseClient):
     ) -> AsyncBaseTransport:
         return AsyncHTTPTransport(
             ssl_context=ssl_context,
-            verify=verify,
-            cert=cert,
             http1=http1,
             http2=http2,
             limits=limits,