Title: Complaint___quality_of_writing_in_EIP_4337
Category: Magicians

Author: luke
Date: 2024-02-23T12:53:06.214Z

Hello all,
Firstly, I’m sorry that my first engagement with the community is to whinge. However, I sincerely feel that my moaning is in the very best interests of Ethereum. It’s also possible that I’m wrong or shouldn’t be poking around this deep.
As part of learning Ethereum, I’ve been picking the most well known EIPs, reading them and making notes. All has been fine until I reached 4337.


Ethereum Improvement Proposals


ERC-4337: Account Abstraction Using Alt Mempool
An account abstraction proposal which completely avoids consensus-layer protocol changes, instead relying on higher-layer infrastructure.





The quality of writing is very poor, to the point of me either failing to comprehend large parts of it, or making guesses in my notes. I’m new to Ethereum but I have fully read and made notes on Mastering Ethereum, O’Reilly, and I’ve been coding almost daily for 39 years.
This particular EIP is long and complicated, and so I suspect the collaborators are a) time-poor b) experts with tacit knowledge who subconsciously infer what’s meant by vague terms (Curse of Knowledge) c) are being extemporaneous, i.e. working it out, as they type.
I won’t list all its problems but there are faults in almost every sentence, and concepts and terms are mixed or ill-defined, not meticulously stuck to.
At points, there aren’t even capital letters starting some of the sentences, which demonstrates extreme lack of care or time. Even the code has sloppy use of whitespace.
When someone saves a minute in writing clearly, they steal that minute from thousands of other readers. Harsh, but true.
I can’t fix it or suggest edits or rewrite it for other’s benefit because I can’t grasp what it’s saying with any confidence.
Anyway, I’m drawing attention to this, at risk of looking rude and demanding, because I strongly believe that adoption follows documentation and developer experience (think of Cuda vs. ROCm in AI and its impact on Nvidia’s sales).
The ultimate worry is that those companies that make something hard, much simpler for the early majority, tend to become tomorrows big centres of influence and control, which I think runs contra to Ethereum’s values. In a sense, this is how regulatory capture works.
In other words, documentation quality is critical to decentralisation.
Thank you
Luke Puplett

Author: abcoathup
Date: 2024-02-23T21:35:49.831Z

ERC-4337 is still draft.  You could make suggestions to improve the language, reach out to some of the authors.

Author: luke
Date: 2024-02-23T22:44:25.677Z

Thanks for your quick reply.
Can I mention the authors or will they get notified if I tag my message properly? Should I retag this one?



I got the impression that AA was done, to the extent that it’s being implemented by all kinds of companies providing APIs and stuff, and it’s labeled “Standards Track: ERC”.
To be honest, I don’t even know where to start with this one. It’s so long and so badly written, it’d take me a week to compile all the issues and I’d just upset everyone.
I feel like this one is a lost cause, but in general, would everyone please raise their expectations from each other around quality, think about Curse of Knowledge, and the importance of documentation on democracy and fair participation.
Much appreciated.

Author: abcoathup
Date: 2024-02-25T21:33:47.934Z

The ERC is still in draft.
You can offer to help the authors improve the language, which may be ignored or appreciated.  Try DMing them on social media.

Author: ZWJKFLC
Date: 2024-02-26T08:48:18.469Z

This is the simplest EIP-4337, and the rest are in-depth supplements.
pragma solidity ^0.8.20;
import "@openzeppelin/contracts/access/Ownable.sol";
contract MyContract is Ownable {
    constructor(address initialOwner) Ownable(initialOwner) {}
    function all(address add,bytes calldata a,uint256 _gas,uint256 _value)payable public {
        unchecked {
            (bool success,) = add.call{gas: _gas,value: _value}(a);
            require(success,"error call");
        }
    }
}

Author: robertgenito
Date: 2024-02-27T02:43:46.589Z

I hope you look at the ERC I will soon post for discussion…definitely want to hear people’s thoughts and constructive criticism!  Good post, Luke, and good point.  It’s beneficial to all incoming developers–and there will be many of them in the smart contract ecosystem!–for even ERCs to be written clearly and understood.  Why?  Because it’s the application layer; the layer that most incoming smart contract developers will want to know about.