GHSA-vh64-54px-qgf8 Goroutine Leak in Abacus SSE Implementation
Goroutine Leak in Abacus SSE ImplementationSummaryA critical goroutine leak vulnerability has been identified in the Abacus server's Server-Sent Events (SSE) implementation. The issue occurs when clients disconnect from the `/stream` endpoint, as the server fails to properly clean up resources and terminate associated goroutines. This leads to resource exhaustion where the server continues running but eventually stops accepting new SSE connections while maintaining high memory usage. The vulnerability specifically involves improper channel cleanup in the event handling mechanism, causing goroutines to remain blocked indefinitely.[POC](https://github.com/JasonLovesDoggo/abacus/blob/main/docs/bugs/GHSA-vh64-54px-qgf8/test.py)ImpactThis vulnerability affects all versions of Abacus prior to v1.4.0. The issue causes:Permanent unresponsiveness of the `/stream` endpoint after prolonged useMemory growth that stabilizes at a high level but prevents proper functionalitySelective denial of service affecting only SSE connections while other endpoints remain functionalAccumulated orphaned goroutines that cannot be garbage collectedHigh resource consumption under sustained client connection/disconnection patternsSystems running Abacus in production with client applications that frequently establish and terminate SSE connections are most vulnerable. The issue becomes particularly apparent in high-traffic environments or during connection stress testing.PatchesThe vulnerability has been patched in Abacus v1.4.0. The fix includes:Implementing buffered channels to prevent blocking operations during cleanupAdding proper mutex-protected cleanup logic to ensure resources are released exactly onceImplementing timeout protection for channel operations to prevent deadlocksEnsuring consistent cleanup when connections terminate unexpectedlyAdding improved monitoring for client disconnections using request contextRestructuring the event broadcasting system to safely handle client removalUsers should upgrade to v1.4.0 or later versions as soon as possible.WorkaroundsIf upgrading is not immediately possible, the following workarounds can help mitigate the issue:**Limit maximum connections**: Configure your reverse proxy to limit the maximum number of concurrent connections to the `/stream` endpoints.**Implement request timeouts**: Configure your infrastructure to terminate long-lived SSE connections after a reasonable period.**Restart regularly**: Schedule regular restarts of the Abacus service to reclaim resources.**Monitor memory usage**: Set up alerts for abnormal memory growth patterns.**Separate instance for SSE**: Run a dedicated Abacus instance solely for handling SSE connections, allowing it to be restarted without affecting the main API functionality.References[Go Concurrency Patterns: Context](https://blog.golang.org/context)[CWE-772: Missing Release of Resource after Effective Lifetime](https://cwe.mitre.org/data/definitions/772.html)[OWASP Top 10: Resource Exhaustion](https://owasp.org/www-project-top-ten/2017/A5_2017-Broken_Access_Control)[Resource Management in Go](https://go.dev/blog/defer-panic-and-recover)For More InformationPlease contact the Abacus security team at abacus@jsn.cam for additional information or to report further security issues.
CVSS v3.1 score: 7.5