BrandonFors/pandas-github-issues huggingface dataset:
#7211 @dsm2173 @jmp392 updated KeyError text to be more informative i…
State: closed

…n this particular common error type

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
closing. not really sure what motiviated this PR. sure we want informative error messages, but at a high  level, so this would need to be shown as a problem in user code. changing at such a low level is generally not great as indicted by @toobaz comments.
TST: tweak Hypothesis configuration and idioms
State: closed

#19831 saw a flaky test, where a slow VM on Travis [went over the default deadline](https://travis-ci.org/pandas-dev/pandas/jobs/448750638#L2895).  This PR therefore configures the per-test-case deadline to a higher value, and disables the global timeout (which is deprecated - we know it's confusing but haven't bumped a major version in years...).

I've also moved a custom strategy from a method on the class to a standalone function, which should avoid some confusion as to where the `draw` argument comes from!

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: CI
description: Continuous Integration

Comments:
Hello @Zac-HD! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/conftest.py`](https://github.com/Zac-HD/pandas/blob/bf05e077a427c34a83c3d233e69f0e1c565df937/pandas/conftest.py) !

 - There are no PEP8 issues in the file [`pandas/tests/frame/test_apply.py`](https://github.com/Zac-HD/pandas/blob/bf05e077a427c34a83c3d233e69f0e1c565df937/pandas/tests/frame/test_apply.py) !



##### Comment last updated on November 01, 2018 at 06:20 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23441?src=pr&el=h1) Report
> Merging [#23441](https://codecov.io/gh/pandas-dev/pandas/pull/23441?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9019582c45d17035098941a666a8b6072c13a357?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23441/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23441?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23441   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         161      161           
  Lines       51187    51187           
=======================================
  Hits        47202    47202           
  Misses       3985     3985
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.64% <ø> (ø)` | :arrow_up: |
| #single | `42.21% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23441?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23441?src=pr&el=footer). Last update [9019582...bf05e07](https://codecov.io/gh/pandas-dev/pandas/pull/23441?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

CC @TomAugspurger @jreback FYI.
Thanks!
BUG-23428 Series.get fills in defaults correctly for multiple indices
State: closed

- [X] closes #23428
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

This PR makes the default parameter in `Series.get` behave as expected with multiple indices. Some of the testing classes had to be altered to make them work with receiving `None` (the default value for the `default` parameter in `Series.get`).

Labels:

Comments:
Hello @JustinZhengBC! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/generic.py`](https://github.com/JustinZhengBC/pandas/blob/6f29e8d4076413e83cb9cb7a3d09fd011c9a755d/pandas/core/generic.py) !

 - There are no PEP8 issues in the file [`pandas/tests/extension/decimal/array.py`](https://github.com/JustinZhengBC/pandas/blob/6f29e8d4076413e83cb9cb7a3d09fd011c9a755d/pandas/tests/extension/decimal/array.py) !

 - There are no PEP8 issues in the file [`pandas/tests/extension/json/array.py`](https://github.com/JustinZhengBC/pandas/blob/6f29e8d4076413e83cb9cb7a3d09fd011c9a755d/pandas/tests/extension/json/array.py) !

 - There are no PEP8 issues in the file [`pandas/tests/series/indexing/test_indexing.py`](https://github.com/JustinZhengBC/pandas/blob/6f29e8d4076413e83cb9cb7a3d09fd011c9a755d/pandas/tests/series/indexing/test_indexing.py) !


Oh I was just looking at the issue this PR is meant to fix. In the example given in that thread, it looked like `.get()` was supposed to work with multiple indices. If that's not the case then this can be closed.
thanks, closing.
CI: Move durations to pytest call
State: closed

Having it in the setup.cfg meant it was used with doctests, which
pushed errors further from the exit code.


Labels:
name: Docs
name: CI
description: Continuous Integration

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23434?src=pr&el=h1) Report
> Merging [#23434](https://codecov.io/gh/pandas-dev/pandas/pull/23434?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/de39bfc5e5c6483cb2669773fa10ddc2e32ca111?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23434/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23434?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23434   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         161      161           
  Lines       51173    51173           
=======================================
  Hits        47190    47190           
  Misses       3983     3983
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.65% <ø> (ø)` | :arrow_up: |
| #single | `42.23% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23434?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23434?src=pr&el=footer). Last update [de39bfc...ee7d86c](https://codecov.io/gh/pandas-dev/pandas/pull/23434?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Would it make sense to override in the doctest command rather than repeat in all the others?
It's not possible to override with a duration of 0. 0 is treated as "all".

On Wed, Oct 31, 2018 at 3:01 PM jbrockmendel <notifications@github.com>
wrote:

> Would it make sense to override in the doctest command rather than repeat
> in all the others?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/23434#issuecomment-434863185>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIu1aXH8iAdL9HFMJjg1bvA-1uD_oks5uqh3IgaJpZM4YE5fW>
> .
>

thanks, this makes sense
CLN: small clean-up PeriodIndex (easy parts of #23416)
State: closed

xref #23416

Labels:
name: Period
description: Period data type
name: Clean

Comments:
Hello @jbrockmendel! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/arrays/datetimelike.py`](https://github.com/jbrockmendel/pandas/blob/1573d21f6bc43e671ec792627d34042821171e40/pandas/core/arrays/datetimelike.py) !

 - There are no PEP8 issues in the file [`pandas/core/indexes/period.py`](https://github.com/jbrockmendel/pandas/blob/1573d21f6bc43e671ec792627d34042821171e40/pandas/core/indexes/period.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23423?src=pr&el=h1) Report
> Merging [#23423](https://codecov.io/gh/pandas-dev/pandas/pull/23423?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7191af9b47f6f57991abdb20625d9563877370a2?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23423/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23423?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23423      +/-   ##
==========================================
+ Coverage   92.19%   92.21%   +0.02%     
==========================================
  Files         161      161              
  Lines       51192    51173      -19     
==========================================
- Hits        47197    47190       -7     
+ Misses       3995     3983      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.65% <100%> (+0.02%)` | :arrow_up: |
| #single | `42.23% <100%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/arrays/datetimelike.py](https://codecov.io/gh/pandas-dev/pandas/pull/23423/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2RhdGV0aW1lbGlrZS5weQ==) | `96.11% <100%> (+2.1%)` | :arrow_up: |
| [pandas/core/indexes/period.py](https://codecov.io/gh/pandas-dev/pandas/pull/23423/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9wZXJpb2QucHk=) | `92.15% <100%> (+1.11%)` | :arrow_up: |
| [pandas/io/feather\_format.py](https://codecov.io/gh/pandas-dev/pandas/pull/23423/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2ZlYXRoZXJfZm9ybWF0LnB5) | `77.14% <0%> (-8.58%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23423?src=pr&el=footer). Last update [7191af9...1573d21](https://codecov.io/gh/pandas-dev/pandas/pull/23423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
Data type of new assigned DataFrame column #23326
State: closed

- [ ] closes #23326
- [ ] tests added / pass
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Needs Info
description: Clarification about behavior needed to assess issue
name: DataFrame
description: DataFrame data structure

Comments:
Hello @charlesdong1991! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/indexing.py`](https://github.com/charlesdong1991/pandas/blob/a9c4a14ac8ba1c2d905681adfe2f87990299cf4b/pandas/core/indexing.py) !

 - There are no PEP8 issues in the file [`pandas/tests/indexing/test_loc.py`](https://github.com/charlesdong1991/pandas/blob/a9c4a14ac8ba1c2d905681adfe2f87990299cf4b/pandas/tests/indexing/test_loc.py) !


@charlesdong1991 : Thanks for the PR!  It looks like there is no associated issue for this PR, and it's a little tricky to understand what you're fixing here.

Do you mind providing sample code that illustrates the problem you're seeing?
@gfyoung  sorry, i was trying to debug the issue listed in #23326 which brings up a wrong type when assigning a int type value, and getting float value as output...  probably i cause more errors when dealing with it. sorry for this...
`df = pd.DataFrame([list('abc')])`
`df.loc[:, 'col1'] = int(5)`
and then the value in column is 5.0 instead of 5...
happy to know if you think it's necessary, and any suggestion of which file might cause this issue is welcome... 
@charlesdong1991 : Ah, no worries.  Thanks for linking the existing the issue!
sorry, wasn't able to find the issue and had some holidays... will leave it to other people.
DOC: Add DateOffsets to api.rst
State: closed

- [x] closes #22447


Labels:
name: Docs
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23405?src=pr&el=h1) Report
> Merging [#23405](https://codecov.io/gh/pandas-dev/pandas/pull/23405?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/a2e599499667b256bc5b8b13a75f0601eccfd432?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23405/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23405?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23405   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         161      161           
  Lines       51184    51184           
=======================================
  Hits        47185    47185           
  Misses       3999     3999
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.62% <ø> (ø)` | :arrow_up: |
| #single | `42.23% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23405?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23405?src=pr&el=footer). Last update [a2e5994...cd03431](https://codecov.io/gh/pandas-dev/pandas/pull/23405?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks. I actually think there might be another issue about this if you can find it (to close it)
@jorisvandenbossche I don't quite follow your comment. IIRC `offsets` can be pulled in from the top level although these offsets live in `pandas/tseries/offsets/`?
CLN: Follow-up comments to gh-23392
State: closed

* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs

Follow-up to #23392.

Labels:
name: Docs
name: Datetime
description: Datetime data dtype
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
Hello @gfyoung! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/dtypes/cast.py`](https://github.com/gfyoung/pandas/blob/4796ccb35406014293128ccab67244df135448a7/pandas/core/dtypes/cast.py) !

 - There are no PEP8 issues in the file [`pandas/tests/series/test_constructors.py`](https://github.com/gfyoung/pandas/blob/4796ccb35406014293128ccab67244df135448a7/pandas/tests/series/test_constructors.py) !

 - There are no PEP8 issues in the file [`pandas/tests/series/test_dtypes.py`](https://github.com/gfyoung/pandas/blob/4796ccb35406014293128ccab67244df135448a7/pandas/tests/series/test_dtypes.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23401?src=pr&el=h1) Report
> Merging [#23401](https://codecov.io/gh/pandas-dev/pandas/pull/23401?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b9e2278ef29170b051fe519d7512d0a1f011be49?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23401/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23401?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23401   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         161      161           
  Lines       51155    51155           
=======================================
  Hits        47157    47157           
  Misses       3998     3998
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.61% <100%> (ø)` | :arrow_up: |
| #single | `42.24% <50%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23401?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/dtypes/cast.py](https://codecov.io/gh/pandas-dev/pandas/pull/23401/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL2Nhc3QucHk=) | `88.92% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23401?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23401?src=pr&el=footer). Last update [b9e2278...4796ccb](https://codecov.io/gh/pandas-dev/pandas/pull/23401?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jbrockmendel is satisfied that the changes address his concerns, so merging.
DOC: Remove Series.sortlevel from api.rst
State: closed

https://travis-ci.org/pandas-dev/pandas/jobs/447288079#L1918

Was dropped in #15099 but accidentally added back in #18202.

Follow-up to #23375.

Labels:
name: Docs
name: API Design
name: Deprecate
description: Functionality to remove in pandas

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23395?src=pr&el=h1) Report
> Merging [#23395](https://codecov.io/gh/pandas-dev/pandas/pull/23395?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/62a15fa4071d0711b2b97771b981d527c1c4af10?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23395/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23395?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23395   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         166      166           
  Lines       51224    51224           
=======================================
  Hits        47212    47212           
  Misses       4012     4012
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <ø> (ø)` | :arrow_up: |
| #single | `42.23% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23395?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23395?src=pr&el=footer). Last update [62a15fa...cf7e71f](https://codecov.io/gh/pandas-dev/pandas/pull/23395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

https://travis-ci.org/pandas-dev/pandas/jobs/447320891#L1920

No more warning! 🎉 
thanks!
ENH: Add FrozenList.union and .difference
State: closed

Re-attempt of #15506.

Hopefully no doc slowdowns on Travis this time 🙏 ! (xref #15559)

Closes #15475.

No deprecation of `__add__` and `__iadd__` because we rely on overloading `+` internally when operating on array-likes (in general) in some cases (e.g. [here](https://github.com/pandas-dev/pandas/blob/62a15fa4071/pandas/core/reshape/melt.py#L82)).  In some cases, that array-like will be `FrozenList`.

Labels:
name: Enhancement
name: API Design

Comments:
Hello @gfyoung! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/indexes/frozen.py`](https://github.com/gfyoung/pandas/blob/570e9e3e425c83fe4776bdf0ab26099d8563bc47/pandas/core/indexes/frozen.py) !

 - There are no PEP8 issues in the file [`pandas/tests/indexes/test_frozen.py`](https://github.com/gfyoung/pandas/blob/570e9e3e425c83fe4776bdf0ab26099d8563bc47/pandas/tests/indexes/test_frozen.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23394?src=pr&el=h1) Report
> Merging [#23394](https://codecov.io/gh/pandas-dev/pandas/pull/23394?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9019582c45d17035098941a666a8b6072c13a357?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23394/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23394?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23394      +/-   ##
==========================================
+ Coverage   92.21%   92.21%   +<.01%     
==========================================
  Files         161      161              
  Lines       51187    51191       +4     
==========================================
+ Hits        47202    47206       +4     
  Misses       3985     3985
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.65% <100%> (ø)` | :arrow_up: |
| #single | `42.21% <57.14%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23394?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/frozen.py](https://codecov.io/gh/pandas-dev/pandas/pull/23394/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9mcm96ZW4ucHk=) | `92.1% <100%> (+0.43%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23394?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23394?src=pr&el=footer). Last update [9019582...c1a375e](https://codecov.io/gh/pandas-dev/pandas/pull/23394?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jreback @jorisvandenbossche : Any thoughts on this?
@jreback : Changes addressed, and all is green.  PTAL.
@jreback : Any thoughts on this?
LGTM
thanks @gfyoung