check azure build
State: closed

This should fail the numpydev build on azure.

Labels:
name: CI
description: Continuous Integration

Comments:
I'll try to turn this into a proper test that can actually be merged later.
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=6513 failed, so this check seems to be working correctly.

Most likely the old warnings are coming from code that are skipped in the (rather limited) numpy-dev env.

One possible option is to add a filterwarning to raise all warnings coming from pandas itself to all the builds. I think pytest supports something like that.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=h1) Report
> Merging [#24616](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/19f715c51d16995fc6cd0c102fdba2f213a83a0f?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/24616/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #24616      +/-   ##
==========================================
+ Coverage   92.37%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52396    52396              
==========================================
+ Hits        48403    48404       +1     
+ Misses       3993     3992       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.8% <ø> (ø)` | :arrow_up: |
| #single | `43% <ø> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/24616/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `88.09% <0%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=footer). Last update [19f715c...f027368](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=h1) Report
> Merging [#24616](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/19f715c51d16995fc6cd0c102fdba2f213a83a0f?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/24616/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #24616      +/-   ##
==========================================
+ Coverage   92.37%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52396    52396              
==========================================
+ Hits        48403    48404       +1     
+ Misses       3993     3992       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.8% <ø> (ø)` | :arrow_up: |
| #single | `43% <ø> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/24616/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `88.09% <0%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=footer). Last update [19f715c...f027368](https://codecov.io/gh/pandas-dev/pandas/pull/24616?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> One possible option is to add a filterwarning to raise all warnings coming from pandas itself to all the builds. I think pytest supports something like that.

this is what setting PANDAS_TESTING_MODE is for (but could migrate to pytest explicity), though using
``-W error::DeprecationWarning`` I could not get things to fail
Something else: locally my pytest "warning summary" includes which test the warning is coming from. Anybody know why this is not the case on travis / azure?
Do you get the test name when running multiple jobs with pytest-xdist?

On Fri, Jan 4, 2019 at 10:02 AM Joris Van den Bossche <
notifications@github.com> wrote:

> Something else: locally my pytest "warning summary" includes which test
> the warning is coming from. Anybody know why this is not the case on travis
> / azure?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/24616#issuecomment-451485771>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIoRUV_7ZtQYWNDSz2hDDMJaYy_qwks5u_3slgaJpZM4ZpyOP>
> .
>

I typically don't use that, but tested now some tests with `-n 2`, and still get the name of the test in the warning summary:

```
(dev) joris@joris-XPS-13-9350:~/scipy/pandas$ pytest pandas/tests/io/test_pytables.py -n 2
=============================================================================================== test session starts ================================================================================================
platform linux -- Python 3.5.5, pytest-3.6.2, py-1.5.4, pluggy-0.6.0
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/home/joris/scipy/pandas/.hypothesis/examples')
rootdir: /home/joris/scipy/pandas, inifile: setup.cfg
plugins: xdist-1.25.0, repeat-0.4.1, forked-0.2, hypothesis-3.70.3
gw0 [182] / gw1 [182]
......................................................................................................x.................................................s.............................                       [100%]
================================================================================================= warnings summary =================================================================================================
pandas/tests/io/test_pytables.py::TestHDFStore::()::test_legacy_table_read
  /home/joris/scipy/pandas/pandas/io/pytables.py:3953: FutureWarning: 
  Panel is deprecated and will be removed in a future version.
  The recommended way to represent these types of 3-dimensional data are with a MultiIndex on a DataFrame, via the Panel.to_frame() method
  Alternatively, you can use the xarray package http://xarray.pydata.org/en/stable/.
  Pandas provides a `.to_xarray()` method to help automate this conversion.
  
    return super(LegacyFrameTable, self).read(*args, **kwargs)['value']
  /home/joris/scipy/pandas/pandas/io/pytables.py:730: FutureWarning: 
  Panel is deprecated and will be removed in a future version.
  The recommended way to represent these types of 3-dimensional data are with a MultiIndex on a DataFrame, via the Panel.to_frame() method
  Alternatively, you can use the xarray package http://xarray.pydata.org/en/stable/.
  Pandas provides a `.to_xarray()` method to help automate this conversion.
  
    columns=columns)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
========================================================================== 180 passed, 1 skipped, 1 xfailed, 2 warnings in 25.33 seconds ===========================================================================
```
Should we consider expanding the installed libraries / test set that is run on this build to catch more of the possible warnings?
The downside is that new warnings from those libraries, and their dependencies, now fail our build. It’s maybe worth trying for a bit provisionally.


________________________________
From: Joris Van den Bossche <notifications@github.com>
Sent: Sunday, January 6, 2019 3:24 PM
To: pandas-dev/pandas
Cc: Tom Augspurger; Author
Subject: Re: [pandas-dev/pandas] check azure build (#24616)


Should we consider expanding the installed libraries / test set that is run on this build to catch more of the possible warnings?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/pandas-dev/pandas/pull/24616#issuecomment-451776221>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIp5vmAW1eZtnbCuN1_sQXEMKJJSwks5vAmmLgaJpZM4ZpyOP>.

I'm probably not getting back to this anytime soon. Closing for now.