BrandonFors/pandas-github-issues huggingface dataset:
adding closed and dtype parameters in timedeltasIndex docs
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the pull request @keiyanishio but it appears that @MarceloCMiguel has already put up a PR earlier: https://github.com/pandas-dev/pandas/pull/49167

Going to close to let that earlier PR continue but happy to have your contribution on other issues!
DOC: add closed and dtype in TimedeltaIndex parameters
State: closed

- [x] closes #49153 
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).


Labels:
name: Docs
name: Timedelta
description: Timedelta data type
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
PERF: Fix performance regression for isin with mismatching dtypes
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

From the asv run you did. This restores 1.4.0 performance. The cast to object avoided the fast path we hit before
cc @jbrockmendel 

Not a blocker for 1.5.1, will move whatsnew if it is released before

Labels:
name: Performance
description: Memory or execution speed performance
name: Regression
description: Functionality that used to work in a prior pandas version
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
LGTM pending green
@phofl - this may have induced a performance regression, please have a look and open an issue if necessary. This is a semi-automated message.

https://asv-runner.github.io/asv-collection/pandas/#algos.isin.IsIn.time_isin_empty?p-dtype='string%5Bpyarrow%5D'

[new link](https://asv-runner.github.io/asv-collection/pandas/#algos.isin.IsIn.time_isin_empty?p-dtype='string%5Bpyarrow%5D')
@rhshadrach the diagram is empty, is this expected?
Hmm, it seems GitHub does not like me ending a URL with a single quote. I've edited the comment above, and will be updating my script :smile:
BUG: loc casting to object for multi block case when setting with list indexer
State: closed

- [x] closes #49159 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
Thanks @phofl
Replace pylint message types with explicit message names
State: closed

- [ ] Updates #48855 
- Replaces "C", "R", and "W" message types with explicit message names to be disabled.
- Groups messages by type

Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
For some reason my local pylint wasn't catching the warning at `pandas/_libs/tslibs/__init__.py:38:0: W0406: Module import itself (import-self)`.
BLD: Python changes to make meson build work
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Build
description: Library building on various platforms

Comments:
FWIW I wouldn't mind if we consolidated some of these PRs into bigger ones. Its a bit difficult to know the context of changes here and the conversation is getting fragmented
Gotcha, how about if I combine the CI/pyproject.toml changes here too? The diff should be ~200 LOC. We would be good to go after this PR if I combined everything here.
Cool let's give it a look. I might even prefer if you combined this with the meson files
Moved to the build files.
TST/CLN: Use fixtures instead of setup_method in tests/indexing
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Clean

Comments:
thanks @mroeschke
API: Change Series/DataFrame.other default to no_default instead of np.nan
State: closed

- [x] closes #49111 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Since 2.0 will be the next version, IMO this should be okay for a "Other API" change.


Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: API - Consistency
description: Internal Consistency of API/Behavior

Comments:
thx @mroeschke
BUG: NA with binary operation with bytes
State: closed

- [x] closes #49108 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
thx @mroeschke
TST/CLN: Use monkeypatch fixture instead of setup_method
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).



Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
thx @mroeschke
DOC Replace gitter badge with one for slack
State: closed

- [x] closes #49143
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @roadswitcher
CLN use pd.Timestamp for single element in converter
State: closed

Only a single element is being parsed, and there's no way for a user to pass any options (like `dayfirst`) through `ax.set_xlim`, so might as well use `pd.Timestamp`.

Otherwise with https://github.com/pandas-dev/pandas/pull/49024 users might get a warning they wouldn't be able to do anything about

Example of test that hits this: `pytest pandas/tests/plotting/test_datetimelike.py -k test_time_change_xlim`

Labels:
name: Clean

Comments:
thx @MarcoGorelli
REGR: read_csv and nullable dtypes fails if dtype is specified
State: closed

- [x] closes #49146 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: IO CSV
description: read_csv, to_csv

Comments:
Thanks @phofl
BUG: guess_datetime_format fails to read 13/2019 in dateutil==2.8.1
State: closed

- [ ] closes #49144 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Datetime
description: Datetime data dtype
name: Dependencies
description: Required and optional dependencies

Comments:
Thanks @MarcoGorelli
Revert "PERF: faster corrwith method for pearson and spearman correlation when other is a Series and axis = 0 (column-wise) (#46174)"
State: closed

- [x] closes #48826 (Replace xxxx with the GitHub issue number)
- [x] closes #49141
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Reverting for now - I've a test fix and whatsnew note from https://github.com/pandas-dev/pandas/pull/49032 , but have reverted the change and added the issue as a test so we can go ahead with 1.5.1. A fixed version of the performance improvement can go into 2.0.0

Labels:
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
Thanks @MarcoGorelli
CLN: Replace _obj_with_exclusions with _select_obj for Series
State: closed

Part of #46944

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

When `obj` is a Series, `_select_obj` and `_obj_with_exclusions` are the same.

Labels:
name: Groupby
name: Clean

Comments:
thx @rhshadrach
DOC: Add missing parameter to Timedelta.view
State: closed

- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thx @bashtage
DOC/BUG: Enforce that freq is required in Period.now
State: closed

- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.


Labels:
name: Docs
name: Period
description: Period data type

Comments:
xref pandas-dev/pandas-stubs#383
No. It looks optional but if not provided it raises.  This just makes it crystal clear that it is required. 
Got it, thx. Could you fix pre-commit?
@phofl Code check is fixed.  
thx @bashtage
BUG: pd.offsets.MonthEnd() delevers wrong month
State: closed

[DOC] - Added more examples and explanation regarding MonthEnd method.

- [ ] closes #48779
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.




Labels:
name: Docs
name: Frequency
description: DateOffsets
name: Stale

Comments:
you'll also need
```
closes #48779
```
in the PR description (as per the template)
and finally, you should check that `pre-commit run --files pandas/_libs/tslibs/offsets.pyx` passes
@MarcoGorelli Thanks for your comments. Very useful. I've made some updates now and another updates will follow this evening!
@MarcoGorelli  I still receive error regarding trailing white spaces:

![image](https://user-images.githubusercontent.com/61096773/196181362-07aab0f5-a2ff-47ef-983d-ca146ed47f17.png)

However I removed all the white spaces in the end of lines. Not sure what else I could do. Do you have any idea, what may cause this problem?
the hook has taken care of it for you - now you can just do `git add -u` and `git commit` again

as an aside, [please don't post images of code](https://youtu.be/svlsnZFWWDE)
> the hook has taken care of it for you - now you can just do `git add -u` and `git commit` again
> 
> as an aside, [please don't post images of code](https://youtu.be/svlsnZFWWDE)

Ok, sure. Let me do it tomorrow. Today I am editing directly on the website, as I don't have access to my personal laptop to run git commands. I'll let you know tomorrow evening, in case the issue remains. Thanks.

And ok.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
> This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.

closing for now, but feel free to ping if you want to keep working on this and I can reopen
BUG: groupby reorders categorical categories
State: closed

Ref: #48749

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

~Still needs more tests and a whatsnew~

Labels:
name: Bug
name: Groupby
name: Categorical
description: Categorical Data Type

Comments:
@mroeschke - this doesn't tackle the performance aspect of #48749, only the behavior. It's not clear to me but it seems possible there is still something that can be done in regards to performance, so I think we should leave #48749 open for now.
> I think we should leave https://github.com/pandas-dev/pandas/issues/48749 open for now.

Agreed

Also looks like a ASV benchmark needs addressing: https://github.com/pandas-dev/pandas/actions/runs/3261927947/jobs/5357896059
Regarding the failing ASV, not sure how to approach here. ~I can't reproduce locally~ with `asv continuous -f 1.1 upstream/main HEAD --quick` and the log doesn't give any indication of what's failing.

Edit: I can reproduce locally, I just missed it in the output:

```
       before           after         ratio
     [aa051b8f]       [1bde9f0f]
     <main>           <groupby_cat_order>
!     1.08±0.02ms           failed      n/a  groupby.Categories.time_groupby_extra_cat_nosort
```
ASVs in groupby:

```
       before           after         ratio
     [890d0975]       [8166c13b]
     <groupby_cat_order~2^2>       <groupby_cat_order>
+         258±4μs      1.31±0.01ms     5.08  groupby.Categories.time_groupby_extra_cat_sort
+       271±0.5μs      1.35±0.01ms     4.98  groupby.Categories.time_groupby_ordered_sort
+       270±0.8μs      1.34±0.01ms     4.97  groupby.Categories.time_groupby_sort
+     1.08±0.02ms      2.34±0.01ms     2.18  groupby.Categories.time_groupby_extra_cat_nosort
+     1.27±0.01ms      2.50±0.01ms     1.97  groupby.Categories.time_groupby_nosort
+     1.44±0.01ms      2.50±0.07ms     1.73  groupby.Categories.time_groupby_ordered_nosort
+         105±5μs          118±2μs     1.12  groupby.GroupByMethods.time_dtype_as_field('int16', 'quantile', 'direct', 1)
-      12.0±0.1ms       10.8±0.3ms     0.90  groupby.AggEngine.time_dataframe_cython(True)
```

These benchmarks use data with length 100000 and 10000 categories.
Awesome, thanks @rhshadrach
PERF: pd.concat with EA-backed indexes
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.0.0.rst` file if fixing a bug or adding a new feature.


Perf improvement for `pd.concat` when objects contain EA-backed indexes. The bottleneck was `EA.tolist`. Still relatively slow vs non-EA, but an improvement. 

```
$ asv continuous -f 1.1 upstream/main ea-tolist -b join_merge.ConcatIndexDtype

       before           after         ratio
     [90b4add7]       [77a21f8d]
     <main>           <ea-tolist>
-      19.4±0.2ms      12.0±0.07ms     0.62  join_merge.ConcatIndexDtype.time_concat_series('Int64', 1, True, False)
-      14.6±0.2ms       6.78±0.2ms     0.46  join_merge.ConcatIndexDtype.time_concat_series('Int64', 1, True, True)
-      14.2±0.2ms       6.57±0.1ms     0.46  join_merge.ConcatIndexDtype.time_concat_series('Int64', 1, False, False)
-      14.1±0.2ms      6.47±0.09ms     0.46  join_merge.ConcatIndexDtype.time_concat_series('Int64', 1, False, True)
-      23.9±0.1ms       10.3±0.1ms     0.43  join_merge.ConcatIndexDtype.time_concat_series('string[python]', 1, True, False)
-      19.7±0.3ms      5.53±0.05ms     0.28  join_merge.ConcatIndexDtype.time_concat_series('string[python]', 1, True, True)
-      19.0±0.2ms      5.16±0.03ms     0.27  join_merge.ConcatIndexDtype.time_concat_series('string[python]', 1, False, True)
-      18.5±0.2ms      4.82±0.03ms     0.26  join_merge.ConcatIndexDtype.time_concat_series('string[python]', 1, False, False)
-         108±1ms       24.5±0.4ms     0.23  join_merge.ConcatIndexDtype.time_concat_series('string[pyarrow]', 1, True, False)
-      98.4±0.6ms       17.0±0.3ms     0.17  join_merge.ConcatIndexDtype.time_concat_series('string[pyarrow]', 1, True, True)
-      97.6±0.8ms       15.9±0.3ms     0.16  join_merge.ConcatIndexDtype.time_concat_series('string[pyarrow]', 1, False, True)
-      99.2±0.5ms       16.0±0.3ms     0.16  join_merge.ConcatIndexDtype.time_concat_series('string[pyarrow]', 1, False, False)
```

```
$ asv continuous -f 1.1 upstream/main ea-tolist -b array.ArrowStringArray

       before           after         ratio
     [90b4add7]       [77a21f8d]
     <main>           <ea-tolist>
-      16.5±0.2ms          399±6μs     0.02  array.ArrowStringArray.time_tolist(True)
-      17.1±0.2ms          404±6μs     0.02  array.ArrowStringArray.time_tolist(False)
```



Labels:
name: Performance
description: Memory or execution speed performance
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
thx @lukemanley