BrandonFors/pandas-github-issues huggingface dataset:
Fix Series.__sub__ non-nano datetime64
State: closed

The original bug report was for `Series`.  This fixes that bug and includes a test that checks for `DatetimeIndex` while we're at it.  I checked and this does _not_ fix the analogous problem in `DataFrame.  I'm hoping someone else will pick up the torch on that b/c the broadcast/dispatch is still something of a mystery to me.

- [x] closes #7996
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18783?src=pr&el=h1) Report
> Merging [#18783](https://codecov.io/gh/pandas-dev/pandas/pull/18783?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/cdebcf374598e9141df7dc23bc75c9528e92c004?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18783/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/18783?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18783      +/-   ##
==========================================
+ Coverage   91.59%   91.59%   +<.01%     
==========================================
  Files         150      150              
  Lines       48959    48961       +2     
==========================================
+ Hits        44843    44847       +4     
+ Misses       4116     4114       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.96% <100%> (ø)` | :arrow_up: |
| #single | `41.13% <50%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18783?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/18783/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvb3BzLnB5) | `90.2% <100%> (+0.03%)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/18783/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.9% <0%> (+0.21%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18783?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18783?src=pr&el=footer). Last update [cdebcf3...0dbe62c](https://codecov.io/gh/pandas-dev/pandas/pull/18783?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Timeout on circleCI in collection, test_geopandas in travis.  Will wait to re-push until given the go-ahead.
yeah don't re-push anything.
Ping
This somehow doesn't need a whatsnew merge
thanks!
COMPAT: 32-bit compat for tz-conversions
State: closed

xref #18777


Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions
name: 32bit
description: 32-bit systems

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18778?src=pr&el=h1) Report
> Merging [#18778](https://codecov.io/gh/pandas-dev/pandas/pull/18778?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/265e3272b8709a7be274321ee8b505a0e74b8e10?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18778/graphs/tree.svg?token=eZ4WkYLtcO&height=150&src=pr&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/18778?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18778      +/-   ##
==========================================
- Coverage   91.61%    91.6%   -0.02%     
==========================================
  Files         153      153              
  Lines       51367    51367              
==========================================
- Hits        47061    47054       -7     
- Misses       4306     4313       +7
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.46% <ø> (ø)` | :arrow_up: |
| #single | `40.76% <ø> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18778?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18778/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18778/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.81% <0%> (-0.1%)` | :arrow_down: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/18778/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `82.52% <0%> (+0.19%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18778?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18778?src=pr&el=footer). Last update [265e327...94ca87f](https://codecov.io/gh/pandas-dev/pandas/pull/18778?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Added pyarrow to OSX build script
State: closed

- [X] closes #18714
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
see #18715

seems numpy is getting upgraded here
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18766?src=pr&el=h1) Report
> Merging [#18766](https://codecov.io/gh/pandas-dev/pandas/pull/18766?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/265e3272b8709a7be274321ee8b505a0e74b8e10?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18766/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18766?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18766      +/-   ##
==========================================
- Coverage   91.61%    91.6%   -0.02%     
==========================================
  Files         153      153              
  Lines       51367    51367              
==========================================
- Hits        47061    47054       -7     
- Misses       4306     4313       +7
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.46% <ø> (ø)` | :arrow_up: |
| #single | `40.76% <ø> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18766?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18766/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18766/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.81% <0%> (-0.1%)` | :arrow_down: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/18766/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `82.52% <0%> (+0.19%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18766?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18766?src=pr&el=footer). Last update [265e327...e22cee9](https://codecov.io/gh/pandas-dev/pandas/pull/18766?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks for the info. Assuming this will be addressed within one of those threads I'm going to close this out
[WIP] implement tests using hypothesis
State: closed

[skipci]

Related: #17978 

Exposes a whole bunch of broken cases.  Many of them look like they are not currently caught because the large majority of offset tests use tz-naive pydatetime inputs.

Note this does _not_ fix these bugs.  The goal here is a Proof Of Concept for using hypothesis and discuss if/how we can make it useful.

It also doesn't add hypothesis to the requirements because I have no idea what the appropriate file is for that.

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
so you *could* add this to ``ci/requirements_dev.txt``. but also in this test module you need a ``pytest.importorskip('hypthosesis')``
are these determinstic tests on a single run? e.g. we are *not* saving state for travis runs
@jreback I don't think hypothesis tests are deterministic, but in my experience they are "deterministic enough" (they will usually find the most significant edge cases very quickly - they don't sample the space randomly). If you find edge cases, rather than trying to save the state of the database between runs, you can add specific examples with the `@hypothesis.example` decorator.
After a couple of days of poking at this, I think it is worth implementing, but it is much too slow to run in the CI.

Running locally has turned up dozens of broken cases.  To the extent that we can phrase tests as "for all A such that B, assert C" this can be a useful tool for identifying corner cases.  When they are found they should just be made into regular tests (and uh, fixed).
> After a couple of days of poking at this, I think it is worth implementing, but it is much too slow to run in the CI.

You can always tune the `hypothesis` tests to reduce the amount run on any given CI run. Maybe on each PR you run 50 test cases or something and then set up a master branch build that runs once a week that runs 500 or so.
I'm still interested in this, but closing because it is not actionable at the moment.
BUG: Fix IntervalIndex.to_tuples() with NA values
State: closed

- [X] closes #18756
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Bug
name: Interval
description: Interval data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18757?src=pr&el=h1) Report
> Merging [#18757](https://codecov.io/gh/pandas-dev/pandas/pull/18757?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7b4229aa1b95b2050b31cc93e38fda1a72258675?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18757/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18757?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18757      +/-   ##
==========================================
- Coverage   91.63%   91.59%   -0.05%     
==========================================
  Files         154      154              
  Lines       51419    51422       +3     
==========================================
- Hits        47120    47102      -18     
- Misses       4299     4320      +21
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.46% <100%> (-0.03%)` | :arrow_down: |
| #single | `40.82% <20%> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18757?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/interval.py](https://codecov.io/gh/pandas-dev/pandas/pull/18757/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9pbnRlcnZhbC5weQ==) | `93.83% <100%> (+0.03%)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18757/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/18757/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `64.78% <0%> (-1.74%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18757/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.68% <0%> (-0.11%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18757?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18757?src=pr&el=footer). Last update [7b4229a...7c330c6](https://codecov.io/gh/pandas-dev/pandas/pull/18757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Added the `na_tuple` kwarg.  Had to do some explicit checks of the NA value in the test, due equality issues with tuples of NA (see https://github.com/pandas-dev/pandas/issues/18756#issuecomment-351881631 for an example)
thanks @jschendel 
Indeed, thanks!
CLN: factor apply out of frame.py
State: closed

xref #18577 

Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Clean

Comments:
this is a factoring out of the apply code to a separate module. Then in #18577  can refactor properly to handle the many cases.

This doesn't change any functionailty or API.

cc @jorisvandenbossche @chris-b1 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18754?src=pr&el=h1) Report
> Merging [#18754](https://codecov.io/gh/pandas-dev/pandas/pull/18754?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9705a480615201ce1e89e5385f48fde155726e8b?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `99.45%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18754/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18754?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18754      +/-   ##
==========================================
- Coverage   91.61%    91.6%   -0.01%     
==========================================
  Files         153      154       +1     
  Lines       51363    51423      +60     
==========================================
+ Hits        47058    47108      +50     
- Misses       4305     4315      +10
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.47% <99.45%> (+0.01%)` | :arrow_up: |
| #single | `40.81% <56.83%> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18754?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/sparse/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18754/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3BhcnNlL2ZyYW1lLnB5) | `94.8% <100%> (+0.02%)` | :arrow_up: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18754/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.68% <100%> (-0.23%)` | :arrow_down: |
| [pandas/core/apply.py](https://codecov.io/gh/pandas-dev/pandas/pull/18754/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXBwbHkucHk=) | `99.42% <99.42%> (ø)` | |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18754/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18754?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18754?src=pr&el=footer). Last update [9705a48...0f5e6ae](https://codecov.io/gh/pandas-dev/pandas/pull/18754?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

+1, looks like a good refactor! 
Can you add some docstrings when working further on it?
yep next pr 
going to rip this apart
CLN: remove doc/plots directory (dead code)
State: closed

- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

As part of my work on #18723, I've stumbled upon the ``doc/plots`` directory. I've searched for usages of files in this directory and have turned up blanks only, so this whole directory seems to be dead code. I assume the dir existed and had uses from the time before ``@savefig`` could be used in ipython directives, and now is outdated.

As the pandas docs now relies on ``@savefig`` decorators, I propose just removing this directory.

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18751?src=pr&el=h1) Report
> Merging [#18751](https://codecov.io/gh/pandas-dev/pandas/pull/18751?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/d2fd22e1f995a638f1e84b0ef091eaf70e171fdc?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18751/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/18751?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18751      +/-   ##
==========================================
- Coverage   91.59%   91.57%   -0.02%     
==========================================
  Files         153      153              
  Lines       51364    51364              
==========================================
- Hits        47046    47037       -9     
- Misses       4318     4327       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.44% <ø> (ø)` | :arrow_up: |
| #single | `40.74% <ø> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18751?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18751/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18751/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.81% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18751?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18751?src=pr&el=footer). Last update [d2fd22e...abaf232](https://codecov.io/gh/pandas-dev/pandas/pull/18751?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Created decorators for skip_if locale functions
State: closed

- [ ] progress towards #18190 
- [ ] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18745?src=pr&el=h1) Report
> Merging [#18745](https://codecov.io/gh/pandas-dev/pandas/pull/18745?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/96439fb13e941100080a8fb5c78b7b291a2dd2fe?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `90.9%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18745/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/18745?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18745      +/-   ##
==========================================
+ Coverage   91.59%   91.59%   +<.01%     
==========================================
  Files         153      153              
  Lines       51364    51363       -1     
==========================================
+ Hits        47046    47047       +1     
+ Misses       4318     4316       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.46% <90.9%> (+0.02%)` | :arrow_up: |
| #single | `40.75% <90.9%> (-0.11%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18745?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/18745/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `82.32% <ø> (-0.21%)` | :arrow_down: |
| [pandas/util/\_test\_decorators.py](https://codecov.io/gh/pandas-dev/pandas/pull/18745/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX3Rlc3RfZGVjb3JhdG9ycy5weQ==) | `93.33% <90.9%> (-0.79%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18745/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18745/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.81% <0%> (-0.1%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/18745/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.52% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18745?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18745?src=pr&el=footer). Last update [96439fb...bfec968](https://codecov.io/gh/pandas-dev/pandas/pull/18745?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Update parsers.py usecols description
State: closed

Added note on the description of usecols in parsers.py file to clarify that order of parsers.py doesn't matter in the read_csv() method. Regardless of what order usecols is inputted in, read_csv() will return a DataFrame of the columns in ascending order.

Labels:
name: Duplicate Report
description: Duplicate issue or pull request
name: IO CSV
description: read_csv, to_csv

Comments:
Hello @jocelynshen! Thanks for submitting the PR.

 - In the file [`pandas/io/parsers.py`](https://github.com/pandas-dev/pandas/blob/a74f3930d9e8b78b722cba3feb9839ba342f04a5/pandas/io/parsers.py), following are the PEP8 issues :

> [Line 111:80](https://github.com/pandas-dev/pandas/blob/a74f3930d9e8b78b722cba3feb9839ba342f04a5/pandas/io/parsers.py#L111): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (87 > 79 characters)


this duplicates #18729 (just a little bit before). thanks! would be happy to take a PR on other issues!
DOC: fix options table
State: closed


Labels:
name: Docs

Comments:
@jorisvandenbossche can you fix the groupby tuple issue in `groupby.rst` here? I have https://github.com/pandas-dev/pandas/pull/18731 for the warning, but that'll get squashed down to a commit, and the warning doesn't need to be backported.
But a revert to interpret tuple should go in 0.21.1 no? 
Otherwise what is the point of warning for it in 0.22
Oh sorry I was being silly. That example builds correctly on the 0.21.x branch, yes? So nothing needs to be backported.
> That example builds correctly on the 0.21.x branch, yes?

Ah, no that is a good question! Have to check
Yeah, sorry, I was looking at a travis build of master, not 0.21.x, so this change was only introduced in 0.22.dev. So nothing urgent for today. Sorry! 

But the patch itself is looking good to me though.