BrandonFors/pandas-github-issues huggingface dataset:
ENH: Number formatting support for excel styles
State: closed

- [x] closes #22027 
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

Add number formatting support to the excel styles using a fake css entry. 

```css
number-format: 0%;
```

Added new tests, updated docs, and manually verified outputs using both excel output engines that support styling. 

Labels:
name: Enhancement
name: IO Excel
description: read_excel, to_excel
name: Code Style
description: Code style, linting, code_checks

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22015?src=pr&el=h1) Report
> Merging [#22015](https://codecov.io/gh/pandas-dev/pandas/pull/22015?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b97545563f724c55bc40271adab64e0239e65328?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22015/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/22015?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22015      +/-   ##
==========================================
+ Coverage      92%      92%   +<.01%     
==========================================
  Files         168      168              
  Lines       50603    50605       +2     
==========================================
+ Hits        46555    46557       +2     
  Misses       4048     4048
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.4% <100%> (ø)` | :arrow_up: |
| #single | `42.19% <50%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22015?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/formats/excel.py](https://codecov.io/gh/pandas-dev/pandas/pull/22015/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2Zvcm1hdHMvZXhjZWwucHk=) | `97.39% <100%> (+0.01%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22015?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22015?src=pr&el=footer). Last update [b975455...4c28407](https://codecov.io/gh/pandas-dev/pandas/pull/22015?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Haven't reviewed code in detail yet but does this reference an existing issue? If not can you open and add reference in whatsnew?
Done 
@marknsikora : This looks good at the moment.  Could you add `whatsnew` entry for `0.24.0` ?
Thanks @marknsikora .
BUG: ValueError in Py3 applying stats over column level with skipna=False (#19720)
State: closed


- [x] closes #19720
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Groupby

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22010?src=pr&el=h1) Report
> Merging [#22010](https://codecov.io/gh/pandas-dev/pandas/pull/22010?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/322dbf4f812f47d4eaee5d8afa10e17acf6dbc67?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `83.33%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22010/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/22010?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22010      +/-   ##
==========================================
- Coverage   91.99%   91.99%   -0.01%     
==========================================
  Files         167      167              
  Lines       50578    50583       +5     
==========================================
+ Hits        46530    46534       +4     
- Misses       4048     4049       +1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.39% <83.33%> (-0.01%)` | :arrow_down: |
| #single | `42.17% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22010?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/22010/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS9vcHMucHk=) | `96.17% <83.33%> (-0.19%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22010?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22010?src=pr&el=footer). Last update [322dbf4...3b7f44a](https://codecov.io/gh/pandas-dev/pandas/pull/22010?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you rebase
closing as stale. ping if you want to continue.
CLN: remove F821 flake8 error in test case
State: closed

Kill flake8 error: F821 undefined name 'unicode'
`compat.text_type == unicode if PY2`

Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22009?src=pr&el=h1) Report
> Merging [#22009](https://codecov.io/gh/pandas-dev/pandas/pull/22009?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/322dbf4f812f47d4eaee5d8afa10e17acf6dbc67?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22009/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22009?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22009   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         167      167           
  Lines       50578    50578           
=======================================
  Hits        46530    46530           
  Misses       4048     4048
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.4% <ø> (ø)` | :arrow_up: |
| #single | `42.17% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22009?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22009?src=pr&el=footer). Last update [322dbf4...9a00a35](https://codecov.io/gh/pandas-dev/pandas/pull/22009?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@holymonson Thanks!
core: fix DatetimeBlock operated with timedelta
State: closed

- [X] closes #22005
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22007?src=pr&el=h1) Report
> Merging [#22007](https://codecov.io/gh/pandas-dev/pandas/pull/22007?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2c7c79779f1ef353d02446504d3b5f5c5cc68759?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22007/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/22007?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22007      +/-   ##
==========================================
+ Coverage   92.02%   92.02%   +<.01%     
==========================================
  Files         170      170              
  Lines       50710    50715       +5     
==========================================
+ Hits        46664    46669       +5     
  Misses       4046     4046
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.43% <100%> (ø)` | :arrow_up: |
| #single | `42.3% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22007?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/internals/blocks.py](https://codecov.io/gh/pandas-dev/pandas/pull/22007/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzL2Jsb2Nrcy5weQ==) | `94.47% <100%> (+0.01%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22007?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22007?src=pr&el=footer). Last update [2c7c797...518b3aa](https://codecov.io/gh/pandas-dev/pandas/pull/22007?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

cc @jbrockmendel 
Pending requested fleshing out in tests (and rebase), this looks like a fine stop-gap solution until we rip out Block-based arithmetic altogether.
The issue #22005 this was written for was closed by #22163.  @holymonson are there other bugs this fixes?
>The issue #22005 this was written for was closed by #22163. @holymonson are there other bugs this fixes?

Nope, I will close this.
CLN: Remove Unneeded BlockManager methods
State: closed

BlockManager.get_scalar is never used outside of tests, 
BlockManager._is_indexed_like is only ever called from `merge`, which is only called once in Panel, before which the indexed_like check is already done.

Also BlockPlacements.iadd was more complicated than it needed to be, so tore out bits of that.

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22002?src=pr&el=h1) Report
> Merging [#22002](https://codecov.io/gh/pandas-dev/pandas/pull/22002?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/171076cc4f37af3f1d050237d0aa3e8000d2bca3?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22002/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22002?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22002      +/-   ##
==========================================
- Coverage      92%   91.99%   -0.01%     
==========================================
  Files         170      170              
  Lines       50609    50594      -15     
==========================================
- Hits        46561    46546      -15     
  Misses       4048     4048
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.4% <ø> (-0.01%)` | :arrow_down: |
| #single | `42.2% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22002?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/internals/managers.py](https://codecov.io/gh/pandas-dev/pandas/pull/22002/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzL21hbmFnZXJzLnB5) | `96.47% <ø> (-0.06%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22002?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22002?src=pr&el=footer). Last update [171076c...4504ccf](https://codecov.io/gh/pandas-dev/pandas/pull/22002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks, always +1 on removing code!
Sparse get dummies perf
State: closed

Previously, we did a scalar `elem == -1` for every element in the ndarray.

This replaces that check with a vectorized `array == -1`.

Running the ASV now. In the meantime, here's a simple timeit on the same problem

```python
# HEAD
In [3]: %timeit pd.get_dummies(s, sparse=True)
561 ms ± 4.96 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

# Master
In [3]: %timeit pd.get_dummies(s, sparse=True)
        2.18 s ± 273 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
```

Labels:
name: Performance
description: Memory or execution speed performance
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Sparse
description: Sparse Data Type

Comments:
Hello @TomAugspurger! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on July 20, 2018 at 15:48 Hours UTC
Here's the ASV (only a 3x speedup).

```
[100.00%] ··· Running reshape.GetDummies.time_get_dummies_1d_sparse                                                                                    1.79s       before           after         ratio
     [272bbdc7]       [bc658b03]
-           1.79s       1.05±0.02s     0.59  reshape.GetDummies.time_get_dummies_1d_sparse

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
```
lgtm.
thanks!
TST: tuple and namedtuple multiindex tests for read_csv
State: closed

- [x] closes #7589
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: MultiIndex

Comments:
#21995 should probably be resolved before this is considered for merging.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21994?src=pr&el=h1) Report
> Merging [#21994](https://codecov.io/gh/pandas-dev/pandas/pull/21994?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1f6ddc4592728c1a09fc0a81ca2a00c685b60a8e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21994/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21994?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21994   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         166      166           
  Lines       50334    50334           
=======================================
  Hits        46292    46292           
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.36% <ø> (ø)` | :arrow_up: |
| #single | `42.22% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21994?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21994?src=pr&el=footer). Last update [1f6ddc4...4aea4ed](https://codecov.io/gh/pandas-dev/pandas/pull/21994?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> #21995 should probably be resolved before this is considered for merging. 

is orthogonal no? 
@jreback wrote:

> is orthogonal no?

Possibly you're right. In any case, I think this PR does what it is supposed to, and #21995 seems likely to be resolved by extending the `to_csv`/`read_csv` docs rather than changing any behaviour. Please let me know if you think I missed something obvious in this PR.
@dahlbaek as I said that #21995 is orthogonal.

thanks
Move FrequencyInferer out of libresolution
State: closed

Discussed briefly, FrequencyInferer doesn't benefit much from cython, isn't needed elsewhere in tslibs, and with this move loses the dependency on khash.

Labels:
name: Frequency
description: DateOffsets
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21992?src=pr&el=h1) Report
> Merging [#21992](https://codecov.io/gh/pandas-dev/pandas/pull/21992?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2d0c96119391c85bd4f7ffbb847759ee3777162a?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `98.05%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21992/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21992?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21992      +/-   ##
==========================================
+ Coverage      92%   92.02%   +0.01%     
==========================================
  Files         170      170              
  Lines       50553    50705     +152     
==========================================
+ Hits        46510    46659     +149     
- Misses       4043     4046       +3
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.42% <98.05%> (+0.02%)` | :arrow_up: |
| #single | `42.31% <74.67%> (+0.09%)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21992?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tseries/frequencies.py](https://codecov.io/gh/pandas-dev/pandas/pull/21992/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvZnJlcXVlbmNpZXMucHk=) | `97.08% <98.05%> (+1.17%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21992?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21992?src=pr&el=footer). Last update [2d0c961...ebb6d52](https://codecov.io/gh/pandas-dev/pandas/pull/21992?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
CLN: Unreachable code, Boolean comparison, duplicate functions
State: closed

Breaking up #21974.

This batch is:

- Unreachable code
- Redefined function (in asv)
- Boolean equality comparison


Labels:
name: Clean

Comments:
LGTM.  

@jorisvandenbossche IIRC you wanted to keep numpydoc changes separate from others?
> IIRC you wanted to keep numpydoc changes separate from others?

Yes, numpydoc is vendored. So if we want to make changes to it, it should be done upstream.
lgtm. not sure by @jorisvandenbossche comments 

ok to make the numpydoc change here and push upstream as well? 
No, no reason to do it here. That only makes updating our version with upstream afterwards harder.
@mroeschke ok then if you'd pull the numpydoc changes out
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21985?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@27ebb3e`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21985/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21985?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #21985   +/-   ##
=========================================
  Coverage          ?   91.97%           
=========================================
  Files             ?      166           
  Lines             ?    50328           
  Branches          ?        0           
=========================================
  Hits              ?    46287           
  Misses            ?     4041           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.36% <ø> (?)` | |
| #single | `42.23% <ø> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21985?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/period.py](https://codecov.io/gh/pandas-dev/pandas/pull/21985/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9wZXJpb2QucHk=) | `93.39% <ø> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21985?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21985?src=pr&el=footer). Last update [27ebb3e...1a5a486](https://codecov.io/gh/pandas-dev/pandas/pull/21985?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
[CLN] Collect __repr__ and rendering methods together
State: closed

Motivation here is in looking at options for rendering EA subclasses.

There's a decent argument to be made that `to_html` and/or `to_latex` should be included in "rendering methods", in large part because they both call `fmt.Formatter`.  Holding off on that pending feedback.

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Closing to clear the queue.