BrandonFors/pandas-github-issues huggingface dataset:
0.23.4 backports 1
State: closed

Closes https://github.com/pandas-dev/pandas/issues/22166

Labels:

Comments:
> Closes #22166

@TomAugspurger : I thought we were experimenting with a bot that auto-backported?

Separate note: some weird `pytables` failures on Travis and Circle.  Not sure what happened but rerunning to confirm.
> I thought we were experimenting with a bot that auto-backported?

Yes, tagging an issue with a milestone will automatically backport it if possible.

I think the whatsnew changes weren't tagged with the 0.23.4 milestone, because it contained changes that shouldn't be backported.

The window fix had a merge conflict.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22178?src=pr&el=h1) Report
> Merging [#22178](https://codecov.io/gh/pandas-dev/pandas/pull/22178?src=pr&el=desc) into [0.23.x](https://codecov.io/gh/pandas-dev/pandas/commit/6a0a95058659cec7515b0233d7795417dfb074fe?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22178/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/22178?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           0.23.x   #22178      +/-   ##
==========================================
+ Coverage   91.83%   91.83%   +<.01%     
==========================================
  Files         153      153              
  Lines       49592    49592              
==========================================
+ Hits        45541    45545       +4     
+ Misses       4051     4047       -4
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.24% <ø> (ø)` | :arrow_up: |
| #single | `41.79% <ø> (-0.06%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22178?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/22178/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.24% <0%> (+0.05%)` | :arrow_up: |
| [pandas/core/panel.py](https://codecov.io/gh/pandas-dev/pandas/pull/22178/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcGFuZWwucHk=) | `97.32% <0%> (+0.44%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22178?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22178?src=pr&el=footer). Last update [6a0a950...7300fe7](https://codecov.io/gh/pandas-dev/pandas/pull/22178?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
DOC: updating the Series.str.cat docstring
State: closed

- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`



Labels:
name: Docs

Comments:
We have run ``validate_docstrings.py`` and gotten the following error:

```
Errors found:
  Errors in parameters section
       Parameter "join" description should finish with "."
```
This is nothing to do with our PR.  We're great.
I think the error is because the "." is followed by "`other`" @datapythonista may be you can varify
Pretty sure that error is from the `.. versionadded:: `. We need to update the script to not complain when there isn't an ending period for those.
Thanks!
Fix Series v Index bool ops
State: closed

Series boolean ops tests need some serious cleanup and fleshing out.  This gets separates out one fix before going in to clean up the tests.

Labels:
name: Bug
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22173?src=pr&el=h1) Report
> Merging [#22173](https://codecov.io/gh/pandas-dev/pandas/pull/22173?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1c113db60b68c5a262d64e92dc9de72bfe59aed5?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22173/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22173?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22173      +/-   ##
==========================================
+ Coverage   92.17%   92.18%   +<.01%     
==========================================
  Files         169      169              
  Lines       50778    50783       +5     
==========================================
+ Hits        46807    46814       +7     
+ Misses       3971     3969       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.59% <100%> (ø)` | :arrow_up: |
| #single | `42.33% <65.21%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/22173/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvb3BzLnB5) | `97.37% <100%> (+0.29%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22173?src=pr&el=footer). Last update [1c113db...44aa551](https://codecov.io/gh/pandas-dev/pandas/pull/22173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

let me have another look, can you rebase
Rebased+green
Hello @jbrockmendel! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/core/ops.py`](https://github.com/jbrockmendel/pandas/blob/5f484822e32cfb3af8c89cbe307680f419c06142/pandas/core/ops.py) !

 - There are no PEP8 issues in the file [`pandas/tests/series/test_operators.py`](https://github.com/jbrockmendel/pandas/blob/5f484822e32cfb3af8c89cbe307680f419c06142/pandas/tests/series/test_operators.py) !


doesn't this overlap with #22293 ?
Yep, commented to that effect over there.
ok then, merge that one first?
>ok then, merge that one first?

Sure.  After rebase this'll be a small follow-up
TST: Check DatetimeIndex.drop on DST boundary
State: closed

Title is self-explanatory.

Closes #18031.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Datetime
description: Datetime data dtype
name: Timezones
description: Timezone data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22165?src=pr&el=h1) Report
> Merging [#22165](https://codecov.io/gh/pandas-dev/pandas/pull/22165?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/35dd15ba150175e8522e2d443ee4118b0d5c57ce?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22165/graphs/tree.svg?token=eZ4WkYLtcO&width=650&src=pr&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/22165?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22165   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         169      169           
  Lines       50694    50694           
=======================================
  Hits        46671    46671           
  Misses       4023     4023
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.47% <ø> (ø)` | :arrow_up: |
| #single | `42.32% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22165?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22165?src=pr&el=footer). Last update [35dd15b...4bd3607](https://codecov.io/gh/pandas-dev/pandas/pull/22165?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
CLN: Use public method to capture UTC offsets
State: closed

xref https://github.com/pandas-dev/pandas/pull/21822#discussion_r207023121

Per @pganssle's suggestion, avoiding using private dateutil methods to access the timezone offset and more succinctly using `utcoffset` instead


Labels:
name: Timezones
description: Timezone data dtype
name: Clean

Comments:
Does this mean instead of capturing eg US/Pacific we get -0800? (Never mind that date until doesn’t yet parse US/Pacific)
Essentially any datetime string with some sort of timezone information (that gets successfully parsed) will be returned as a fixed offset.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22164?src=pr&el=h1) Report
> Merging [#22164](https://codecov.io/gh/pandas-dev/pandas/pull/22164?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/647f3f091eedd715b7966829a36ef345de4d7a4d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22164/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/22164?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22164   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         170      170           
  Lines       50720    50720           
=======================================
  Hits        46694    46694           
  Misses       4026     4026
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.47% <ø> (ø)` | :arrow_up: |
| #single | `42.29% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22164?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22164?src=pr&el=footer). Last update [647f3f0...f6755fa](https://codecov.io/gh/pandas-dev/pandas/pull/22164?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @mroeschke and @pganssle
Fix deprecation warning in SeriesGroupBy.count
State: closed

See https://github.com/pandas-dev/pandas/pull/21957#issuecomment-409527005

Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22155?src=pr&el=h1) Report
> Merging [#22155](https://codecov.io/gh/pandas-dev/pandas/pull/22155?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/5d661c8ee06dc361ae49a63ba1e51d18e44e2255?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22155/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22155?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22155      +/-   ##
==========================================
+ Coverage   92.06%   92.06%   +<.01%     
==========================================
  Files         170      170              
  Lines       50707    50709       +2     
==========================================
+ Hits        46682    46684       +2     
  Misses       4025     4025
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.47% <100%> (ø)` | :arrow_up: |
| #single | `42.3% <50%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22155?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/22155/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS9nZW5lcmljLnB5) | `86.82% <100%> (+0.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22155?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22155?src=pr&el=footer). Last update [5d661c8...8221d85](https://codecov.io/gh/pandas-dev/pandas/pull/22155?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @topper-123
~Finish collecting m8[ns] tests, start collecting division by zero tests
State: closed

The division by zero tests aren't yet parametrized, are mostly just moved as-is.  Both these and the newly moved m8[ns] tests will need a bunch of de-duplication in the next pass.

Tons of DataFrame tests failing.  #22074 is the PR we need, though maybe not the one we deserve.

Started in on fixtures.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timedelta
description: Timedelta data type

Comments:
k, rebase on top as merged #22074
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22153?src=pr&el=h1) Report
> Merging [#22153](https://codecov.io/gh/pandas-dev/pandas/pull/22153?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/def50e26f78c507a743fa11fee98230412ae50a8?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22153/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22153?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22153      +/-   ##
==========================================
+ Coverage   92.06%   92.06%   +<.01%     
==========================================
  Files         169      169              
  Lines       50694    50694              
==========================================
+ Hits        46671    46672       +1     
+ Misses       4023     4022       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.47% <ø> (ø)` | :arrow_up: |
| #single | `42.32% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22153?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/22153/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.43% <0%> (+0.05%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22153?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22153?src=pr&el=footer). Last update [def50e2...29c9738](https://codecov.io/gh/pandas-dev/pandas/pull/22153?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

One build is failing because it says there is no "box" fixture, but there is.  Seen this before?
<b>update</b> never mind, dumb mistake on my part.
@jreback this should go before others for easiest rebasing
ok lgtm. can you rebase and merge on green (just to make sure). can you make the next followup to split this to a sub-dir (i know its all td atm but just to make it clear / easier)
implement tslibs/src to make tslibs self-contained
State: closed


Labels:
name: Period
description: Period data type
name: Clean

Comments:
Hello @jbrockmendel! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on August 01, 2018 at 18:11 Hours UTC
looks good. a build is failing, maybe rebase and push again.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22152?src=pr&el=h1) Report
> Merging [#22152](https://codecov.io/gh/pandas-dev/pandas/pull/22152?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9c118668256d2e36d2d310d46e604392a92bbee7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22152/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/22152?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22152   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         170      170           
  Lines       50707    50707           
=======================================
  Hits        46682    46682           
  Misses       4025     4025
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.47% <ø> (ø)` | :arrow_up: |
| #single | `42.3% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22152?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22152?src=pr&el=footer). Last update [9c11866...54ac680](https://codecov.io/gh/pandas-dev/pandas/pull/22152?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks, progress bit-by-bit
Catch IntervalIndex.itemsize deprecation warning in tests and remove IntervalArray.itemsize
State: closed

- [X] closes #22049
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

I don't think a whatsnew entry is needed.  This was already deprecated for `IntervalIndex`, but wasn't being caught in the tests, and was displaying the name from the underlying `left`/`right` values.  Likewise, `IntervalArray` was created after the deprecation, so no reason to even add it.


Labels:
name: Interval
description: Interval data type

Comments:
thanks!
use memoryviews instead of ndarrays
State: closed

For lookups and slicing memoryviews are supposed to be more performant than ndarrays.  I haven't been able to detect any difference.  @xhochy IIRC you've looked at this in some depth; are memoryviews unambiguously better for our purposes?

Getting rid of `from numpy cimport [...]` is necessary (but not sufficient) for getting rid of numpy 1.7 deprecation warnings.

Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
I also had the feeling that they are more performant and flexible than using `ndarray` but they don't support `const object[:]` at the moment which was problematic in my case. I actually have the feeling that this is a bug in the type parsing of Cython as `const object` is not possible but `const object[:]` should be. Asked for clarification at https://github.com/cython/cython/issues/2485 but got no answer yet and I did not fully understand the Cython codebase to answer it myself.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22147?src=pr&el=h1) Report
> Merging [#22147](https://codecov.io/gh/pandas-dev/pandas/pull/22147?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/57c7daa3251e8fed3f3f709ab5bc8e707db99e98?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22147/graphs/tree.svg?token=eZ4WkYLtcO&width=650&src=pr&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/22147?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22147   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         170      170           
  Lines       50694    50694           
=======================================
  Hits        46674    46674           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.47% <ø> (ø)` | :arrow_up: |
| #single | `42.29% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22147?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22147?src=pr&el=footer). Last update [57c7daa...4cfe9e8](https://codecov.io/gh/pandas-dev/pandas/pull/22147?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

so this is not faster, but not slower? is it worth it at all?
> so this is not faster, but not slower? is it worth it at all?

Based on %timeit results, the memoryviews do appear to be every-so-slightly faster.

The other upsides I have in mind are:
- weens us off of being numpy-specific (think: arrow)
- easier to lint (though we're a few steps away from that)
- getting rid of `from numpy cimport ...` is prerequisite to getting rid of deprecation warnings
ok thanks
Replace (private) _checknull with (public) is_nan
State: closed

`util._checknull(x)` is equivalent to `x is None or isnan(x)`.  On several occasions I have had to go remind myself what `_checknull` covers.  It is much clearer to write out `x is None or util.is_nan(x)`, which is what this PR does.

In at least one place where `_checknull` is currently used, the `is None` part of it can be skipped.

Also gets rid of usages of private functions, and trades a no-docstring func for a nice-docstring func.

Small assorted cleanups along the way.



Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22146?src=pr&el=h1) Report
> Merging [#22146](https://codecov.io/gh/pandas-dev/pandas/pull/22146?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/def50e26f78c507a743fa11fee98230412ae50a8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22146/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/22146?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22146   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         169      169           
  Lines       50694    50694           
=======================================
  Hits        46671    46671           
  Misses       4023     4023
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.47% <ø> (ø)` | :arrow_up: |
| #single | `42.32% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22146?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22146?src=pr&el=footer). Last update [def50e2...70e339e](https://codecov.io/gh/pandas-dev/pandas/pull/22146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you rebase and merge on green (just to be sure).