.ne fails if comparing a list of columns containing column name 'dtype' #22383
State: closed

hello, this is my first pr in open source.
so , i think some things have problem.

if this pr has problem , tell me. i will fix again.

this issue occur Dataframe has column defined 'dtype' when execute  .ne function.

i asked some advice which way is more better.

i) when make dataframe instance column name is dtype, make exception.
ii) make exception in ne function.

i receive answer try first. so i try to modifiy _has_bool_dtype function.

- [x] closes #22383
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
@gfyoung thank you your review :) i modified the code you reviewed.

and reason i rename 'dtype' to 'temporary_dtype' is when dataframe has 'dtype' column and call ne() function, dataframe's dtype member variable don't use and occur error as issue 22383.
so i temporarily change column name.

thank you!
Indeed, I saw!  It seems like you have test failures (based on your previous commit).  Should look into that.
![image](https://user-images.githubusercontent.com/23095231/44308277-42514880-a3ed-11e8-8bda-e06554da38b6.png)

@gfyoung 
could i ask how to check test failures (based on your previous commit). i just run test file which i added test. shoud i check all tests? 

thank you your help. 
@gfyoung ah, sorry. i understood now. i will check ci/circleci . thank you :)
@gfyoung just left continuous intergration test thanks to you. but i don't know how to run that test. 
if error's cause is some branch hare  merged , but i did not rebase, tell me you need rebase. 
i'm really thank you!
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22416?src=pr&el=h1) Report
> Merging [#22416](https://codecov.io/gh/pandas-dev/pandas/pull/22416?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/100ffffa0ace51baac7045ca51fecf228e54bc5b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `60%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22416/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22416?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22416   +/-   ##
=======================================
  Coverage   31.89%   31.89%           
=======================================
  Files         166      166           
  Lines       52421    52421           
=======================================
  Hits        16722    16722           
  Misses      35699    35699
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `30.29% <60%> (ø)` | :arrow_up: |
| #single | `31.89% <60%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22416?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/computation/expressions.py](https://codecov.io/gh/pandas-dev/pandas/pull/22416/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tcHV0YXRpb24vZXhwcmVzc2lvbnMucHk=) | `58.82% <60%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22416?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22416?src=pr&el=footer). Last update [100ffff...1fe9eff](https://codecov.io/gh/pandas-dev/pandas/pull/22416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

FYI, http://pandas-docs.github.io/pandas-docs-travis/contributing.html may be helpful.
Hello @baidoosik! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on December 27, 2018 at 17:46 Hours UTC
@baidoosik can you merge master and update
@jreback okay thank you ! i try it
@jreback now my development environment is not properly working. so i will fix my environment and f test code to use parameterize style. and i will push. thank you!
@baidoosik can you merge master
@jreback today i will update ! really sorry !
@baidoosik pls merge master and update
@jreback today i merge master and apply to parameterize in test code..! thank you. if CI is failed, i will fix it !
thanks!
@jreback thanks you so much your kind review! thanks to your kindness, i contributed opensource at first! thank you!