CI: add __init__.py to isort skip list
State: closed

4.3.5 - February 24, 2019 - last Python 2.7 Maintenance Release
This is the final Python 2.x release of isort, and includes the following major changes:

Potentially Interface Breaking:

The -r option for removing imports has been renamed -rm to avoid accidental deletions and confusion with the -rc recursive option.
__init__.py has been removed from the default ignore list. The default ignore list is now empty - with all items needing to be explicitly ignored....

Labels:
name: CI
description: Continuous Integration
name: Code Style
description: Code style, linting, code_checks

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=h1) Report
> Merging [#25455](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/aa084162bcaa7ce0efdc044bc8077f6bfca70674?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25455/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #25455   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         173      173           
  Lines       52923    52923           
=======================================
  Hits        48554    48554           
  Misses       4369     4369
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.31% <ø> (ø)` | :arrow_up: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=footer). Last update [aa08416...06ef7b4](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=h1) Report
> Merging [#25455](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/aa084162bcaa7ce0efdc044bc8077f6bfca70674?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25455/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #25455   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         173      173           
  Lines       52923    52923           
=======================================
  Hits        48554    48554           
  Misses       4369     4369
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.31% <ø> (ø)` | :arrow_up: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=footer). Last update [aa08416...674d42d](https://codecov.io/gh/pandas-dev/pandas/pull/25455?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@simonjayhawkins : Do we have instances in our `__init__` files where custom import order matters?  I understand maintaining `status quo`, but I just would like to double check, since that would be the major reason for ignoring `isort`.

cc @jreback 
@simonjayhawkins can you just isort these?
also, I don't see us actually installing isort; it seems we are relying on a version that is on the system somehow? @simonjayhawkins can you add isort to each of the ci/deps files fore the azure builds (I guess can't hurt on the travis ones too); put on the universal section
ping on green
@MeeseeksDev backport to 0.24.x
Asked to backport this to get CI green on 0.24.x. 
Another question: @simonjayhawkins why did you add `isort` to all of the CI environments? Don't we only run it and "Checks_and_doc Job" job?
> Another question: @simonjayhawkins why did you add `isort` to all of the CI environments? Don't we only run it and "Checks_and_doc Job" job?

@jorisvandenbossche 

see https://github.com/pandas-dev/pandas/pull/25455#issuecomment-467876419. I was at the London Python Sprint at the time, CI was failing and I would have been AFK while travelled home so didn't question it. Seemed harmless enough, but feel free to change.