DOC: pin sphinx to 1.8.5
State: closed

xref https://github.com/pandas-dev/pandas/issues/26058

Labels:
name: Docs

Comments:
Context for doing this would be the styling changes introduced in sphinx 2, for which we should first update our custom css (described in #26058)
cc @datapythonista @TomAugspurger 

If we would release right now, I would build the docs with sphinx 1.8.5 for the release. 
Given that, the question is then: do we want to use 1.8.5 in the travis build as well, to make sure everything is working with that release (to match our release process), or do we rather already want to build with the newest possible sphinx to also catch possible new errors with newer sphinx? (both have value IMO)
I think pin to 1.8.5 for now.
Agreed pinning is fine (i think we have pinned sphinx in the past frequently)
Updated
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=h1) Report
> Merging [#26781](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ea06f8d1157601b5fdb48598e27b02149828fba0?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26781/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26781      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         178      178              
  Lines       50779    50779              
==========================================
- Hits        46579    46575       -4     
- Misses       4200     4204       +4
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.31% <ø> (ø)` | :arrow_up: |
| #single | `41.21% <ø> (-0.06%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `96.88% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=footer). Last update [ea06f8d...124504f](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=h1) Report
> Merging [#26781](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ea06f8d1157601b5fdb48598e27b02149828fba0?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26781/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26781      +/-   ##
==========================================
+ Coverage   91.72%   91.76%   +0.03%     
==========================================
  Files         178      178              
  Lines       50779    50751      -28     
==========================================
- Hits        46579    46570       -9     
+ Misses       4200     4181      -19
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.35% <ø> (+0.03%)` | :arrow_up: |
| #single | `41.22% <ø> (-0.05%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `96.88% <0%> (-0.12%)` | :arrow_down: |
| [pandas/plotting/\_matplotlib/tools.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19tYXRwbG90bGliL3Rvb2xzLnB5) | `78.4% <0%> (ø)` | :arrow_up: |
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `94.1% <0%> (ø)` | :arrow_up: |
| [pandas/plotting/\_matplotlib/style.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19tYXRwbG90bGliL3N0eWxlLnB5) | `85.96% <0%> (ø)` | :arrow_up: |
| [pandas/plotting/\_matplotlib/timeseries.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19tYXRwbG90bGliL3RpbWVzZXJpZXMucHk=) | `66.32% <0%> (ø)` | :arrow_up: |
| [pandas/core/internals/blocks.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzL2Jsb2Nrcy5weQ==) | `94.38% <0%> (+0.25%)` | :arrow_up: |
| [pandas/plotting/\_matplotlib/boxplot.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19tYXRwbG90bGliL2JveHBsb3QucHk=) | `75.59% <0%> (+0.48%)` | :arrow_up: |
| [pandas/plotting/\_matplotlib/misc.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19tYXRwbG90bGliL21pc2MucHk=) | `38.93% <0%> (+0.9%)` | :arrow_up: |
| [pandas/core/internals/managers.py](https://codecov.io/gh/pandas-dev/pandas/pull/26781/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzL21hbmFnZXJzLnB5) | `95.21% <0%> (+1.34%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=footer). Last update [ea06f8d...d79c80d](https://codecov.io/gh/pandas-dev/pandas/pull/26781?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Ok travic job very good

Vào 12 Th6, 2019 13:47, Marc Garcia <notifications@github.com> đã viết:

@datapythonista commented on this pull request.

+1 on pinning

I'd probably migrate to sphinx 2 when we change the theme. And surely after we fail the CI on doc warnings.

But can you also pin the version in environment.yml please, so we build the docs locally with the same version as travis.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://github.com/pandas-dev/pandas/pull/26781?email_source=notifications&email_token=AJLD4SJOYLFKZHYXYERY3PLP2CLWZA5CNFSM4HW5UGBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3IOMOY#pullrequestreview-248571451>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJLD4SJPJWRITYN4HBSMXULP2CLWZANCNFSM4HW5UGBA>.


thanks @jorisvandenbossche