Deprecate using `xlrd` engine
State: closed

- [x] closes #28547
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry 


Labels:
name: IO Excel
description: read_excel, to_excel
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks! Does this also warn if just using `read_excel`?
> Thanks! Does this also warn if just using `read_excel`?

Yes - if you call read_excel there are two cases:
1.  io arg is not an instance of ExcelFile --> ExcelFile is then initialized resulting in Future warning if necessary.
2. io arg is an instance of ExcelFile  --> For this to have happened, the future warning would have already been raised when the io object was initialized.
Hello @cruzzoe! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



* In the file [`pandas/tests/io/excel/test_xlrd.py`](https://github.com/pandas-dev/pandas/blob/a1bb8704431dd9da1cab7eccdcb49a88d6f6aaad/pandas/tests/io/excel/test_xlrd.py):

> [Line 54:78](https://github.com/pandas-dev/pandas/blob/a1bb8704431dd9da1cab7eccdcb49a88d6f6aaad/pandas/tests/io/excel/test_xlrd.py#L54): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace



##### Comment last updated at 2020-01-26 16:36:12 UTC
@cruzzoe can you merge master?
> @cruzzoe can you merge master?

Sorry- not sure what you mean. This is a merge request of my branch to master. Are you asking me to update my branch off the tip of master?
Yep that's it!
@WillAyd - done 
@cruzzoe unfortunately looks like something went awry with merging master - any idea what steps you might have done?
I think might have not pulled the latest from upstream before merging. Typically would want to do

```sh
git fetch upstream
git merge upstream/master
# fix any merge conflicts
git merge --continue
git push origin YOUR_BRANCH
```
> I think might have not pulled the latest from upstream before merging. Typically would want to do
> 
> ```shell
> git fetch upstream
> git merge upstream/master
> # fix any merge conflicts
> git merge --continue
> git push origin YOUR_BRANCH
> ```

I originally did:
git fetch upstream
git rebase upstream/master

When comparing my branch against upstream/master I see only my new changes. 

I have reset and redone using merge instead of rebase. 
@cruzzoe can you filter out this warning in the tests? I think OK to apply at the module level - right now this generates a lot of warnings in the CI logs so want to clean that up
@cruzzoe you still interested in working on this?
Yes. Sorry for delay. I'll get back to this very shortly!

On Mon, 23 Dec 2019, 16:06 alimcmaster1, <notifications@github.com> wrote:

> @cruzzoe <https://github.com/cruzzoe> you still interested in working on
> this?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/29375?email_source=notifications&email_token=ACXR24QSRVJPWAJFKSB33BLQ2DOZ7A5CNFSM4JIH46F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRNJJY#issuecomment-568513703>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACXR24WES7JIR2CNL7E7WX3Q2DOZ7ANCNFSM4JIH46FQ>
> .
>

> @cruzzoe can you filter out this warning in the tests? I think OK to apply at the module level - right now this generates a lot of warnings in the CI logs so want to clean that up

Ive implemented what I think is what you are suggesting. Please could you take a look - I believe this will stop warnings in CI now. Also, I looked at CI to confirm my changes are all good, but I see lots of things failing. Are these related to my change?
Doc failure I think is related:

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=23821&view=logs&jobId=5291ec4e-9543-503b-43ce-895cf0e06ba3&j=5291ec4e-9543-503b-43ce-895cf0e06ba3&t=ba0a2b35-e1f8-54df-fd66-2b9fde6f4b1f&line=55

So need to update block where this is throwing the warning
can you merge master; ping when green.
> can you merge master; ping when green.

all good.
Looks like a merge conflict and still some red CI - @cruzzoe can you fix that up?
@cruzzoe still active? Can you fix up conflicts and get green?
Yep. Will aim for tonight. Thanks for reminder.

On Wed, 4 Mar 2020, 01:25 William Ayd, <notifications@github.com> wrote:

> @cruzzoe <https://github.com/cruzzoe> still active? Can you fix up
> conflicts and get green?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/29375?email_source=notifications&email_token=ACXR24TCBY5YOOKXHXCVOXDRFWUXRA5CNFSM4JIH46F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENV3HKI#issuecomment-594260905>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACXR24UTHOEZKGB6XEDP3ITRFWUXRANCNFSM4JIH46FQ>
> .
>

@cruzzoe ping on this one again - looks like some merge conflicts to fix
@cruzzoe can you merge master and get fix up the test?
Nice PR but looks like this has gone stale. @cruzzoe ping if you’d like to pick backup - still very welcome