BrandonFors/pandas-github-issues huggingface dataset:
Separate test_numeric_compat into method-specific tests
State: closed

A more reasonably-scoped attempt at #19255.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19321?src=pr&el=h1) Report
> Merging [#19321](https://codecov.io/gh/pandas-dev/pandas/pull/19321?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1245f0673074316b53d1d1ee10abd6077058b133?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19321/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19321?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19321   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         150      150           
  Lines       48739    48739           
=======================================
  Hits        44612    44612           
  Misses       4127     4127
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.9% <ø> (ø)` | :arrow_up: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19321?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19321?src=pr&el=footer). Last update [1245f06...3df8a1f](https://codecov.io/gh/pandas-dev/pandas/pull/19321?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks, nice scope, means merge faster :>
Centralize and de-duplicate comparison and arith tests
State: closed

These are almost all cut/paste moving tests to the appropriate places.  Two exceptions:

- Some "TODO: de-duplicate this with that" notes (mostly to myself)
- `TestTimedeltaIndexArithmetic.test_numeric_compat` badly needed to be split into more specific tests, so that is done here.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Datetime
description: Datetime data dtype
name: Timedelta
description: Timedelta data type
name: Period
description: Period data type

Comments:
Hello @jbrockmendel! Thanks for updating the PR.























Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on January 19, 2018 at 18:52 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19317?src=pr&el=h1) Report
> Merging [#19317](https://codecov.io/gh/pandas-dev/pandas/pull/19317?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f0cd23ca6485940e3a6572cc4f5afdce4c3921ab?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19317/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19317?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19317      +/-   ##
==========================================
- Coverage   91.53%    91.5%   -0.03%     
==========================================
  Files         150      150              
  Lines       48738    48738              
==========================================
- Hits        44611    44599      -12     
- Misses       4127     4139      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.87% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.72% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19317/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19317?src=pr&el=footer). Last update [f0cd23c...77ffa9a](https://codecov.io/gh/pandas-dev/pandas/pull/19317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks.

~~are we missing a pandas/tests/indexes/period/test_artithmetic.py?~~

actually there is one, I guess nothing to move there
Refactor core.internals into core/internals/ dir
State: closed

Discussed  in #19268, not sure if the time is right for this since it causes some rebase headaches, but may be worth it.

Note that git is of the opinion that the file core/internals.py was moved to core/internals/blocks.py, not sure if that matters for e.g. blame.


Labels:
name: Refactor
description: Internal refactoring of code
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
I'm gonna hold off on rebasing this until I get an idea of team's interest in this change.
FIX: Raise errors when wrong string arguments are passed to `resample`
State: closed

- [x] closes #19303
- [x] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

As a first step, the initial commit just extends the resampling tests so that they fail when a misstyped string argument, e.g. for `label`, passes silently without raising.

I have the fix for the code ready and will commit when the tests have failed once.

Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Resample
description: resample method

Comments:
tests look good. pls push the fix when you can.
Hello @cchwala! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on January 21, 2018 at 15:47 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19307?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@b286789`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19307/graphs/tree.svg?height=150&src=pr&token=eZ4WkYLtcO&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/19307?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19307   +/-   ##
=========================================
  Coverage          ?    91.5%           
=========================================
  Files             ?      150           
  Lines             ?    48745           
  Branches          ?        0           
=========================================
  Hits              ?    44606           
  Misses            ?     4139           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.87% <100%> (?)` | |
| #single | `41.72% <0%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19307?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/resample.py](https://codecov.io/gh/pandas-dev/pandas/pull/19307/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzYW1wbGUucHk=) | `96.43% <100%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19307?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19307?src=pr&el=footer). Last update [b286789...c026767](https://codecov.io/gh/pandas-dev/pandas/pull/19307?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @cchwala
separate _libs/src/reduce.pyx to _libs.reduction
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
needs a rebase
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19306?src=pr&el=h1) Report
> Merging [#19306](https://codecov.io/gh/pandas-dev/pandas/pull/19306?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f0cd23ca6485940e3a6572cc4f5afdce4c3921ab?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19306/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19306?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19306      +/-   ##
==========================================
- Coverage   91.53%    91.5%   -0.03%     
==========================================
  Files         150      150              
  Lines       48738    48738              
==========================================
- Hits        44611    44599      -12     
- Misses       4127     4139      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.87% <100%> (-0.03%)` | :arrow_down: |
| #single | `41.72% <37.5%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19306?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby.py](https://codecov.io/gh/pandas-dev/pandas/pull/19306/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS5weQ==) | `92.14% <100%> (ø)` | :arrow_up: |
| [pandas/core/apply.py](https://codecov.io/gh/pandas-dev/pandas/pull/19306/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXBwbHkucHk=) | `99.42% <100%> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19306/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19306?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19306?src=pr&el=footer). Last update [f0cd23c...a63da0f](https://codecov.io/gh/pandas-dev/pandas/pull/19306?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

ok, this at least de-couples some lib.pyx, which is good.
Implement libinternals
State: closed

A bunch of functions from `lib` that are only used in core.internals, have light dependencies.

Small optimizations: made `slice_getitem` a `cdef` instead of `def`, use PySlice_Check instead of isinstance.

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
pls just do a move. do a followup to change things. when you move a file its impossible to tell diffs.
OK, just changed to be pure cut/paste, will do optimizations in follow-up.
shouldn't this be called internals and not libinternals?
> shouldn't this be called internals and not libinternals?

The filename is "internals.pyx".  I've gotten used to the convention `import pandas._libs.internals as libinternals`
thanks!
follow up for docs and small optimizations ok
Huh? Was this meant to be closed or merged?
it is merged 

see the hash above
DOC: add `source activate` for older versions of Anaconda and fix a typo
State: closed

In the contrib docs, `conda activate` should be `source activate`, and there was also an extraneous period after the "continuous integration" heading.

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19282?src=pr&el=h1) Report
> Merging [#19282](https://codecov.io/gh/pandas-dev/pandas/pull/19282?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/4086e420c8c7a5f72fb9090a7d2d97045cf443bb?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19282/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19282?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19282   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         148      148           
  Lines       48870    48870           
=======================================
  Hits        44737    44737           
  Misses       4133     4133
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.91% <ø> (ø)` | :arrow_up: |
| #single | `41.66% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19282?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19282?src=pr&el=footer). Last update [4086e42...7c1e95d](https://codecov.io/gh/pandas-dev/pandas/pull/19282?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
BUG: timezone comparisions are inconsistent, manifesting in bugs in .concat
State: closed

closes #18523 
superseded #18596

Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Timezones
description: Timezone data dtype

Comments:
cc @jschendel 
cc @jbrockmendel 
cc @MridulS 
cc @pganssle 
cc @rockg 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19281?src=pr&el=h1) Report
> Merging [#19281](https://codecov.io/gh/pandas-dev/pandas/pull/19281?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/65d1b62dfe46cd5cfd80d8b1aafd633575c72ee6?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19281/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/19281?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19281   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         148      148           
  Lines       48874    48874           
=======================================
  Hits        44751    44751           
  Misses       4123     4123
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.93% <100%> (ø)` | :arrow_up: |
| #single | `41.69% <66.66%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19281?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/19281/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.23% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19281?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19281?src=pr&el=footer). Last update [65d1b62...e95f16f](https://codecov.io/gh/pandas-dev/pandas/pull/19281?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
remove unused block attribute
State: closed

grepping across the code, `_downcast_dtype` doesn't show up anywhere else.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Clean

Comments:
ping on green.
After 11 hours Travis hasn't started.  I think they've had some recent infrastructure problems; may need to be cancelled and re-started.
thanks.

yeah travis was really borked yesterday / today.
Remove timeop
State: closed

We're finally able to remove `ops._Op` and `ops._TimeOp`.  This PR makes one final compatibility fix:

ATM:
```
tdi = pd.TimedeltaIndex(['1 Day'])
ser = pd.Series(tdi)

>>> tdi + np.nan
TypeError: unsupported operand type(s) for +: 'TimedeltaIndex' and 'float'

>>> ser + np.nan
0   NaT
dtype: timedelta64[ns]
```

Same deal for subtracting np.nan.  See #19274.  This makes the TimedeltaIndex canonical and updates the appropriate Series tests.

- [x] closes #19274
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype
name: Clean

Comments:
Travis cancelled. Repush or let sit?
i restarted
Looks like OSX build got killed again, otherwise OK
lgtm. just waiting on travis.
thanks.

now would be a good time to split the test_operators into sub-modules :>
Fix tzawareness_compat for DatetimeIndex comparisons with NaT
State: closed

ATM `pd.date_range('2016-01-01', periods=1, tz='US/Pacific') < pd.NaT` raises `TypeError` because `NaT` is tz-naive.  This fixes that.

- [ ] closes #xxxx
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19276?src=pr&el=h1) Report
> Merging [#19276](https://codecov.io/gh/pandas-dev/pandas/pull/19276?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/04a6815f7da0f6d879725d553c7a45f47bb4a15c?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19276/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19276?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19276      +/-   ##
==========================================
- Coverage   91.56%   91.53%   -0.03%     
==========================================
  Files         148      148              
  Lines       48874    48876       +2     
==========================================
- Hits        44751    44741      -10     
- Misses       4123     4135      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.91% <100%> (-0.03%)` | :arrow_down: |
| #single | `41.69% <66.66%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19276?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/19276/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.24% <100%> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19276/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19276?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19276?src=pr&el=footer). Last update [04a6815...c97e166](https://codecov.io/gh/pandas-dev/pandas/pull/19276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
CLN: put mgr_locs setter next to property definition
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
lgtm.
I don't know why this bugged me so much, but it did :)
thanks!
BUG: Patch handling of keep_default_na=False
State: closed

Patches very buggy behavior of `keep_default_na=False` whenever `na_values` is a dict

* Respect `keep_default_na` for column that doesn't exist in `na_values` dictionary
* Don't crash / break when `na_value` is a scalar in the `na_values` dictionary.

In addition, clarifies documentation on the handling of the keep `keep_default_na` parameter with respect to `na_filter` and `na_values`.

Closes #19227.

cc @neilser

Labels:
name: Bug
name: IO CSV
description: read_csv, to_csv

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19260?src=pr&el=h1) Report
> Merging [#19260](https://codecov.io/gh/pandas-dev/pandas/pull/19260?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/04a6815f7da0f6d879725d553c7a45f47bb4a15c?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19260/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19260?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19260      +/-   ##
==========================================
+ Coverage   91.56%   91.56%   +<.01%     
==========================================
  Files         148      148              
  Lines       48874    48878       +4     
==========================================
+ Hits        44751    44755       +4     
  Misses       4123     4123
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.94% <100%> (ø)` | :arrow_up: |
| #single | `41.69% <21.42%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19260?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/parsers.py](https://codecov.io/gh/pandas-dev/pandas/pull/19260/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnNlcnMucHk=) | `95.49% <100%> (+0.01%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19260?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19260?src=pr&el=footer). Last update [04a6815...63faf8d](https://codecov.io/gh/pandas-dev/pandas/pull/19260?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jreback : The OSX builds on Travis seemed to have stalled completely (all of the other tests have been done for a LONG time now).
thanks @gfyoung
move panel-specific swaplevel to panel
State: closed

NDFrame.swaplevel is overriden by both Series and DataFrame, so in practice the "generic" implementation is specific to Panel.  This PR just moves the method from NDFrame to Panel.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
I'd like to do the opposite, consolidate the series/frame impl to generic. 
Works for me; closing.