BrandonFors/pandas-github-issues huggingface dataset:
GroupBy enhancement unifies the return of iterating over GroupBy #42795
State: closed

- [x] closes #42795 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Applied the deprecation in #47761

Labels:
name: Enhancement
name: Groupby
name: Stale

Comments:
Hello @ahmedibrhm! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



















There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-07-26 22:07:40 UTC
@rhshadrach 
Do you think in changing the behaviour we should change it from its root or only the final result.

What I mean is that when iterating over groupby the `group_keys_seq` variable appear, so do you think we should change the variable itself in case the user passed single element in a list or just change the `iter` function to return the required behavior?
I am asking this because `group_keys_seq` appear in other different functions so it may affect them as well.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
@ahmedibrhm are you interested in continuing this PR and applying the deprecation? We are looking to enforce this for the next release
Thanks for the pull request, but I believe this was handled by https://github.com/pandas-dev/pandas/pull/50064 so closing. If I misunderstood happy to reopen
TST: add test for groupby with dropna=False on multi-index
State: closed

- [x] closes #39895
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby

Comments:
Thanks @GYHHAHA
opt out of bottleneck for nanmean
State: closed

- [x] closes #42878
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dependencies
description: Required and optional dependencies
name: Reduction Operations
description: sum, mean, min, max, etc.

Comments:
Hello @sebasv! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-07-17 13:11:07 UTC
I added 2 unit tests to validate that numerical precision is bounded by log(n). If anyone has suggestions how to improve these tests let me know
@mroeschke I will verify this. Addition is pure for integers so depending on the bottleneck implementation it should be almost exact
Glad to see this update.  Should it be targeting pandas 1.5.0 or 1.4.4 release?
> Glad to see this update. Should it be targeting pandas 1.5.0 or 1.4.4 release?

1.5. Point releases are reserved for regression in behavior from recent releases.
Integer mean should also be opted out of. In the case of integer arrays it seems that bottleneck accumulates the sum in a float64 type, wich means that the problem persists there as well. I'm adding int types to the unit test as well

Example 
```python
>>> a = np.full((1_000_000_000, 1), 1_000_000_000_000, dtype=np.int64)
>>> bottleneck.nanmean(a)
1000000022905.4894
>>> np.nanmean(a)
1000000000000.0
```
Thanks @sebasv and @JMBurley for review
TST: Test for the Enum triggering TypeError (#22551 issue)
State: closed

- [x] closes #22551



Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Hello @Shadimrad! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-07-16 02:19:24 UTC
I believe it's done! @mroeschke 
Thanks, great job @Shadimrad!
BUG: df.fillna ignores axis when df is single block
State: closed

- [x] closes #47713
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
Hello @GYHHAHA! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-07-14 04:27:41 UTC
Thanks @GYHHAHA
DOC: fix typos in "See also" documentation section
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Hello @partev! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-07-16 11:54:24 UTC
GH: Add CITATION.cff
State: closed

Enables a citation widget on the side of the repository that provides a copy-pastable ABA & Bibtex citation: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files

Followed this schema: https://github.com/citation-file-format/citation-file-format/blob/1.2.0/schema-guide.md


Labels:
name: Admin
description: Administrative tasks related to the pandas project

Comments:
check that this displays ok :->
<img width="352" alt="Screen Shot 2022-07-16 at 10 35 16 AM" src="https://user-images.githubusercontent.com/10647082/179365944-b9dc88ce-85fa-4b3f-a2d6-bb7728e34305.png">
BUG: json_normalize raises boardcasting error with list-like metadata
State: closed

- [x] closes #37782
- [x] closes #47182
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO JSON
description: read_json, to_json, json_normalize
name: Stale

Comments:
Hello @GYHHAHA! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-08-18 02:41:26 UTC
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
WEB: Governance community members
State: closed

xref #47694

Draft of the different groups of the pandas community worth mentioning in the governance. I personally find this format (a concise description with responsibilities, and a section for how membership works) the best. I think it keeps simple, while having all the information so decision making is clear.

The exact content is an initial version what makes sense to me, but feedback more than welcome. I think having an initial proposal make things easier to discuss, but surely things can be improved.

Topics like how a technical decision in the project is made are not in the scope of this PR, and will be addressed separately. What I try to do here is to formalize which are the different groups that are relevant in the pandas community, and when and how people and institutions become part of them, or when stop being part.

Labels:
name: Admin
description: Administrative tasks related to the pandas project
name: Web
description: pandas website

Comments:
Thanks for the feedback. I addressed all comments.
I think it's too ambitious to try to change the governance at this point. I think the amount of energy and time required to get a document with 80% of core dev approvals is just too much. Closing, maybe things look better in the future.
GH: Convert feature request template to GH form
State: closed

Mostly a 1:1 transfer. I removed the `API breaking implications` section though as the reviewers should have more/just-as-good insight into potential API impacts.

Labels:
name: Admin
description: Administrative tasks related to the pandas project

Comments:
check if this displays ok
Yup looks okay! https://github.com/pandas-dev/pandas/issues/new?assignees=&labels=Enhancement%2CNeeds+Triage&template=feature_request.yaml&title=ENH%3A+
Specify that both ``by`` and ``level`` should not be specified in ``groupby`` - GH40378
State: closed

- [ ] closes #40378 (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Please review the documentation check errors: https://github.com/pandas-dev/pandas/runs/7312164428?check_suite_focus=true
It seems as if there is something wrong with my local machine. I will be closing this PR and opening a new one soon. Thanks for the help!
First proj
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Hello @GivyBoy! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

* In the file [`pandas/core/frame.py`](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py):

> [Line 8336:57](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8336): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace
> [Line 8337:42](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8337): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace
> [Line 8338:61](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8338): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace
> [Line 8342:63](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8342): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace
> [Line 8343:58](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8343): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace


Seems like you are working on https://github.com/pandas-dev/pandas/pull/47690 instead, so closing. Next time please just update the same pull request with the latest changes
updated the docstring in accordance with GH40378
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Hello @GivyBoy! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

* In the file [`pandas/core/frame.py`](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py):

> [Line 8336:57](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8336): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace
> [Line 8337:42](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8337): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace
> [Line 8338:61](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8338): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace
> [Line 8342:63](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8342): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace
> [Line 8343:58](https://github.com/pandas-dev/pandas/blob/4a3e79d418e66d8e6e5f6660c9f724ef672ed1ab/pandas/core/frame.py#L8343): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace



##### Comment last updated at 2022-07-12 20:52:49 UTC
TST: avoid sort when concat int-index Dataframes with sort=False
State: closed

- [x] closes #37937
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

This issue may have been fixed by #36299. Add the test and close.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Hello @GYHHAHA! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-07-12 19:20:34 UTC
Thanks @GYHHAHA
DOC: Clarify that FrozenList is hashable
State: closed

- [x] closes #47683 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @pyrito
WEB: Update sponsors in website
State: closed

Still waiting for the logos of the new sponsors, and final confirmation that we want to replace Ursa Labs by Voltron, but opening early in case there is feedback.

Labels:
name: Admin
description: Administrative tasks related to the pandas project
name: Web
description: pandas website

Comments:
> Can probably add Nvidia, will confirm and find what image to use

I forgot about Nvidia, sorry. Thanks for the heads up, added it now.
This should be ready now. This is how the home page look with the new sponsors:

![Screenshot at 2022-07-22 12-08-47](https://user-images.githubusercontent.com/10058240/180368415-bc3d1f45-ee97-4614-9b9c-732f896c6750.png)

@mroeschke I found the nvidia logo online, I think it should be fine.

I watched @jreback recent talk, and I'm wondering whether we should also add USC (who sponsored @jbrockmendel to work on the non-nanosecond stuff via Quansight), and NASA (I don't know much about that grant). No strong opinion, but if we add them let's do it in a follow up PR, since getting the logos takes a while and this is ready now.
 > @mroeschke I found the nvidia logo online, I think it should be fine.
 
Thanks. I am still inquiring within my company to get approval to use the logo, but if you'd like to merge this and add Nvidia's logo (and the others) in a followup I would be fine with that
I'll split this in two and have nvidia in a separate PR, so we can get the rest merged, and nvidia is ready for whenever the decision is made. Thanks for letting me know.
@datapythonista I just got approval now that the Nvidia logo usage is good!
TYP: make na_value consistently a property
State: closed

Similar to `_engine_type`, `na_value` is sometimes a property and sometimes a class variable.

There were multiple places that access `StringDtype.na_value` (works with class variables but not properties). I replaced these cases with the value of `StringDtype().na_value`.


(and one `_engine_type` class variable I forgot in another PR)

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Thanks @twoertwein
ENH: Move database error to error/__init__.py per GH27656
State: closed

- [x] xref #27656. this GitHub issue is being done in multiple parts
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
Thanks @dataxerik
Bug fix using GroupBy.resample produces inconsistent behavior when calling it over empty df #47705
State: closed

- [X] closes #47705
- [X] Tests added and passed(https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/v1.5.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Groupby

Comments:
Hello @ahmedibrhm! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-08-15 17:40:17 UTC
@mroeschke it's ready for another look if you wanna review again
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
@rhshadrach sorry for the delay I was traveling and couldn't check that at all. It's hard to combine the tests because one test has the name of the column "date". So it won't be feasible to construct the expected one.
No problem @ahmedibrhm! Looks like the whatsnew note got dropped - can you add that back in to 1.6.0.
@rhshadrach how about now
Thanks @ahmedibrhm