BrandonFors/pandas-github-issues huggingface dataset:
Split and parametrize test_operators
State: closed

Orthogonal to #19166 since this does not touch `TestTimedeltaSeriesArithmetic`.

Fix (some) flake8 complaints about 1-letter variable names.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Datetime
description: Datetime data dtype
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19173?src=pr&el=h1) Report
> Merging [#19173](https://codecov.io/gh/pandas-dev/pandas/pull/19173?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/787ab5556f23d2e10b798d2e58e66789d79fd4d5?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19173/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19173?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19173      +/-   ##
==========================================
- Coverage   91.55%   91.53%   -0.03%     
==========================================
  Files         147      147              
  Lines       48812    48812              
==========================================
- Hits        44690    44678      -12     
- Misses       4122     4134      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.9% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.7% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19173?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19173/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19173?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19173?src=pr&el=footer). Last update [787ab55...c3cd064](https://codecov.io/gh/pandas-dev/pandas/pull/19173?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

ping
lgtm. needs a rebase as I just merged a pr fixing some delta things. png on green.
ping
thanks. next PR should be to split operators tests up into sub-files.
Doc: Add example of merging a Series with a Dataframe
State: closed

- [X] closes #12550


Labels:
name: Docs
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Fixed comment: closes CR #12550.
you need to rebase on master and push again, don't see any changes
This PR can be closed - resubmitted as PR #19235.
in he future pls just push to thme same PR with changes

I see. Will do.
No SettingWithCopyWarning on groupby results
State: closed

The dataframe referred to in the warning is a result of an
internal slicing operation and should not lead to a warning
in userspace.

- [x] closes #19151
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Groupby

Comments:
see my comments on the issue. This is as expected. mutation is non-idiomatic, and this is a correct warning. If you really really want to mutate, you must copy first.
simplify CBMonth.apply to remove roll_monthday
State: closed

The implementations of CustomBusinessMonthBegin.apply and CustomBusinessMonthEnd.apply are merged.

Simplify CustomBusinessMonth.apply so that it uses liboffsets.roll_convention instead of liboffsets.roll_monthday (the latter being much more of a footgun).  This is the last place where roll_monthday was used, so this removes it.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Frequency
description: DateOffsets
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19146?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@9d8dbef`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19146/graphs/tree.svg?height=150&src=pr&token=eZ4WkYLtcO&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/19146?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19146   +/-   ##
=========================================
  Coverage          ?   91.51%           
=========================================
  Files             ?      148           
  Lines             ?    48782           
  Branches          ?        0           
=========================================
  Hits              ?    44641           
  Misses            ?     4141           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.88% <100%> (?)` | |
| #single | `41.61% <19.04%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19146?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/19146/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `96.98% <100%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19146?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19146?src=pr&el=footer). Last update [9d8dbef...4ee7c82](https://codecov.io/gh/pandas-dev/pandas/pull/19146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Fix URL in FutureWarning for .loc[list-of-labels] with missing labels
State: closed

- [X] closes #19143
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`



Labels:
name: Docs

Comments:
Do you know if sphinx let's you have multiple labels for the same header? It'd be nice to add a 

    .. deprecate_loc_reindex_listlike

in the same spot, so that both URLs point to the same spot.

>Do you know if sphinx let's you have multiple labels for the same header?

Yeah, was wondering that myself since it seems like it'd be a nicer solution to just make the URL work than to change it.  Had to try a few variations, but eventually got the second label working, at least for my local build of the docs.

No real point in changing to URL in this case; I'll make it https but leave everything else as is.  Assuming this is fine, will check the docs generated by travis after this gets merged to make sure it's working there too.
  
thanks!
Doc: Example of merging Dataframe and Series
State: closed

- [ ] closes #12550

Labels:

Comments:
@pdpark you seem to picking up *other* PR's commits. start with a fresh master and checkout a branch from that with your changes.
@jreback, sorry, still learning the process. So I make a branch for a change, commit my changes on my fork and submit a PR. How do I get a fresh master on my fork at that point? Thanks.
Looking at the How to Contribute document, it looks like I need to execute these git commands:

git remote add upstream <link to parent repo>
git fetch upstream
git rebase upstream/master
Submitted a new pull request. Let me know if it looks okay this time.
This PR can be closed. I am resubmitting these changes as separate PRs.
DOC: Add documentation regarding no compression in to_parquet
State: closed


Labels:
name: Docs
name: IO Parquet
description: parquet, feather

Comments:
@TomAugspurger 👍  Done.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19131?src=pr&el=h1) Report
> Merging [#19131](https://codecov.io/gh/pandas-dev/pandas/pull/19131?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f6c0f8a17005e7aaffa6de1b429b2cdf9889459f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19131/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19131?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19131   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         148      148           
  Lines       48780    48780           
=======================================
  Hits        44651    44651           
  Misses       4129     4129
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.9% <ø> (ø)` | :arrow_up: |
| #single | `41.59% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19131?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/19131/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.62% <ø> (ø)` | :arrow_up: |
| [pandas/io/parquet.py](https://codecov.io/gh/pandas-dev/pandas/pull/19131/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnF1ZXQucHk=) | `69.9% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19131?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19131?src=pr&el=footer). Last update [f6c0f8a...5b65ed8](https://codecov.io/gh/pandas-dev/pandas/pull/19131?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks @ylogx. Was there an issue for this?
@TomAugspurger  Nope, I felt that this change could be discussed over the PR itself.
Parametrized test_json_table_schema module
State: closed

- [X] closes #19070 
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Could potentially consolidate all of the ``dtype`` tests further but didn't want to rock the boat too much

Labels:
name: Refactor
description: Internal refactoring of code
name: Testing
description: pandas testing functions or related to the test suite

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19128?src=pr&el=h1) Report
> Merging [#19128](https://codecov.io/gh/pandas-dev/pandas/pull/19128?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f6c0f8a17005e7aaffa6de1b429b2cdf9889459f?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19128/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19128?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19128      +/-   ##
==========================================
- Coverage   91.53%   91.51%   -0.03%     
==========================================
  Files         148      148              
  Lines       48780    48780              
==========================================
- Hits        44651    44639      -12     
- Misses       4129     4141      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.88% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.61% <ø> (+0.01%)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19128?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19128/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19128?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19128?src=pr&el=footer). Last update [f6c0f8a...16d0262](https://codecov.io/gh/pandas-dev/pandas/pull/19128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
TST: Add test for setting with loc on DataFrame with one row
State: closed

- [X] closes #15494
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Issue appears to be have been fixed for a while, since 0.21.x at least, just added a test to ensure there's no regression.
  

Labels:
name: Bug
name: Testing
description: pandas testing functions or related to the test suite
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19127?src=pr&el=h1) Report
> Merging [#19127](https://codecov.io/gh/pandas-dev/pandas/pull/19127?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/d5194e5692a3327e05e9d0f2544e2512708921f3?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19127/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19127?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19127   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         148      148           
  Lines       48780    48780           
=======================================
  Hits        44639    44639           
  Misses       4141     4141
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.88% <ø> (ø)` | :arrow_up: |
| #single | `41.59% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19127?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19127?src=pr&el=footer). Last update [d5194e5...f3a2bbf](https://codecov.io/gh/pandas-dev/pandas/pull/19127?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks. will merge after fixing travis :<
thanks @jschendel
Fix and test TimedeltaIndex.__rfloordiv__ bug
State: closed

I thought we were ready to get rid of _TimeOp, but doing so turned up a couple of new bugs.

Setup:
```
scalar_td = pd.Timedelta('10m7s')
tdi = TimedeltaIndex(['00:05:03', '00:05:03', pd.NaT], freq=None)
```

Before:
```
>>> tdi.__rfloordiv__(scalar_td)
Float64Index([0.0, 0.0, nan], dtype='float64')
```

After:
```
>>> tdi.__rfloordiv__(scalar_td)
Float64Index([2.0, 2.0, nan], dtype='float64')
```

- [ ] closes #xxxx
- [x] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19125?src=pr&el=h1) Report
> Merging [#19125](https://codecov.io/gh/pandas-dev/pandas/pull/19125?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1265f66860a1a108b835881ef41ca4e52d397b3f?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19125/graphs/tree.svg?width=650&height=150&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19125?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19125      +/-   ##
==========================================
+ Coverage   91.51%   91.53%   +0.02%     
==========================================
  Files         148      148              
  Lines       48777    48780       +3     
==========================================
+ Hits        44636    44651      +15     
+ Misses       4141     4129      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.9% <100%> (+0.02%)` | :arrow_up: |
| #single | `41.59% <25%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19125?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/19125/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.45% <100%> (ø)` | :arrow_up: |
| [pandas/core/indexes/timedeltas.py](https://codecov.io/gh/pandas-dev/pandas/pull/19125/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy90aW1lZGVsdGFzLnB5) | `90.63% <100%> (+0.05%)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19125/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19125?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19125?src=pr&el=footer). Last update [1265f66...d76237b](https://codecov.io/gh/pandas-dev/pandas/pull/19125?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
BUG: Avoid using realpath to make list_future_warnings.sh compatible on macosx
State: closed

…with Mac

- [ ] closes #xxxx
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Admin
description: Administrative tasks related to the pandas project
name: Deprecate
description: Functionality to remove in pandas

Comments:
thanks!
DEPR: Removing previously deprecated flavor parameter from SQLiteData…
State: closed

…base (#6581)

- [X] related to #6581
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: IO SQL
description: to_sql, read_sql, read_sql_query
name: Deprecate
description: Functionality to remove in pandas

Comments:
hmm, these are not building on travis for some reason.
It's a great reason for you to take a break today, it's Sunday! ;)
thanks!
DEPR: Removing previously deprecated Categorical.labels (#6581)
State: closed

- [X] related to #6581
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Categorical
description: Categorical Data Type
name: Deprecate
description: Functionality to remove in pandas

Comments:
thanks!
DEPR: Removing previously deprecated datetools module (#6581)
State: closed

- [X] related to #6581
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype
name: Deprecate
description: Functionality to remove in pandas

Comments:
lgtm. though not running on travis for some reason.
cc @TomAugspurger 

maybe need to login to travis and turn on pandas-dev for your fork?
@datapythonista needs rebase, hopefully CI problem will fix itself.
can you rebase, for some reason travis is not running either - not sure why
thanks @datapythonista
DEPR: Changing default of str.extract(expand=False) to str.extract(expand=True)
State: closed

…o str.extract(expand=True) (#6581)

- [X] related to #6581
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Strings
description: String extension data type and string data
name: Deprecate
description: Functionality to remove in pandas

Comments:
I changed the section in the wantsnew, and updated the text and the issue number, but I left the default parameter.

In the signature, `expand` had a default value of `None`, but in practice [1] it was False, as it was also said in the docstring [2]. I'll change the message if you disagree, but I think it makes more sense to say that by default was `False` before.

1. https://github.com/pandas-dev/pandas/blob/master/pandas/core/strings.py#L687
2. https://github.com/pandas-dev/pandas/blob/master/pandas/core/strings.py#L613
Thank you for the comments @jreback I understood it now. If you want to take a look, I think it should be much better, and with the examples now. Let me know if any other change is needed.
Thanks for the comments @TomAugspurger. I made the changes. In text.rst, there was no example with expand unspecified or None, so the text was already correct. I added a quick note about the default value in the warning.

Please let me know if that looks good, or you've got a better idea.
All the comments from the reviews were addressed, right? Just double checking that the PR doesn't need anything from my side.
Thanks for the info @jorisvandenbossche, didn't know about the `.. ipython::` directive.

It should be all right now.
@datapythonista Thanks!
DEPR: Adding script to detect deprecated features by version (#6581)
State: closed

- [ ] closes #xxxx
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
thanks!
hmm

```
(pandas) bash-3.2$ ./list_future_warnings.sh 
./list_future_warnings.sh: line 31: realpath: command not found
usage: dirname path
usage: dirname path
^C
```

?
Oh, didn't know realpath was not available on Mac, I thougt it was standard unix. Let me check how can avoid using it.
DEPR: removing deprecated stuff: Categorical.labels, pandas.core.date…
State: closed

…tools, SQLiteDatabase.flavor, str.extract(expand=None) (#6581)

- [X] related to #6581
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry

@jreback, from the ones that we discussed, this PR removes all them except Resampler, which is a bit tricky, and I left it for a separate PR.

Labels:

Comments:
@datapythonista I need you to split this up into PR's for each piece. We like to PR's that do one thing.

I don't think we can remove datetools yet as statsmodels needs another release, so you can put that up, but will have to wait to merge.
Ok, sorry, didn't know, will do. Thanks!
closing this one, just open up separate PR's