BrandonFors/pandas-github-issues huggingface dataset:
Skip converts na values to strings
State: closed

- [✓] closes #44156 
- [✓] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [✓] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-02-14 11:20:26 UTC
@phofl Hi This issue is already closed. I close this PR. Thank for review.
Fix scatter norm keyword
State: closed

- [x] closes #45809
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

This PR addresses a bug where the `norm` parameter is used for a scatter plot where the `c` color is a non-categorical type (e.g. a numeric type). This combination of inputs would result in the `norm` parameter being specified both as an explicit keyword argument and in `self.kwds`.

The behavior has changed such that `norm` is only ever specified once, and in the scenario described above the value specified by the user will be honored.

I tried to test that the specific `norm` value ended up in the plot, but there doesn't seem to be a good way of comparing `norm._scale` objects without comparing the individual attributes. I'm happy to add this in if required.

Labels:
name: Bug
name: Visualization
description: plotting

Comments:
small comment & if you can merge master; ping on green
Great PR @Andy-Grigg, thanks. 
sure can do another PR to update
Bug fix - Astype Timedelta64[ns] fails when np.nan is included
State: closed

- [x] closes #45798
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Timedelta
description: Timedelta data type

Comments:
@jreback @jbrockmendel 
Hi The test pipeline check in green. 
thanks @weikhor
BUG: Fix implementation of temp_setattr
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Doesn't fix any user-facing bug (at least, that I'm aware of), but the current implementation will not restore the original attribute if an exception is raised within the context manager.

Labels:
name: Bug
name: Groupby

Comments:
thanks @rhshadrach
BUG: Fix some cases of groupby(...).transform with dropna=True
State: closed

Part of #17093

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Plan to expand the whatsnew note as more parts of #45839 are merged.

Ran groupby ASVs; `groupby.Nth.time_frame_nth` showed a performance decrease, then increase, then twice not significantly changed. No other ASVs had significant changes.

Labels:
name: Groupby
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Apply
description: Apply, Aggregate, Transform, Map

Comments:
Thanks @jbrockmendel - changes made and green (so far, at least)
thanks @rhshadrach very nice!
TST: Check network URL statuses in tests
State: closed

This run failed because a test that hit a url was able to download content but the page displayed a 404 page

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=73924&view=logs&jobId=054c7612-f473-5cf0-0a65-77b54574553a&j=054c7612-f473-5cf0-0a65-77b54574553a&t=7218990d-7c28-52cc-5797-2fee2b0645b4

Checking more urls in our test suite and the response status. 


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO Network
description: Local or Cloud (AWS, GCS, etc.) IO Issues

Comments:
any reason we shouldn't backport?
> any reason we shouldn't backport?

Fair, this would help the tests in 1.4.x
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
Test case multiplying large series by NA
State: closed

- [ ✔] closes #33701
- [✔] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [✔] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-02-19 04:29:01 UTC
Thanks again @weikhor!
ENH: exclude html table border w/False value
State: closed

Per the HTML5 spec, border attributes on table elements are obsolete.
Borders should be implemented via CSS instead.
https://html.spec.whatwg.org/multipage/obsolete.html#attr-table-border
This enhancement will retain the default behavior of the border keyword of to_html,
but will exclude the attribute entirely upon receiving a falsy value.

closes  #22692


Labels:
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap
name: Stale

Comments:
@github-actions pre-commit
Excluding the border attribute upon `border=0` failed this test case: `pandas\tests\io\formats\test_to_html.test_to_html_border`

So I have revised the enhancement to only exclude the border attribute when border=False

**fixed typo

This is one of the reasons I am trying to push `styler.to_html` as the architecture for `Dataframe.to_html`.

`Dataframe.to_html()` produces other officially deprecated HTML: #39951

Whilst this commit solves this problem, it shouldn't be the long term solution, and its only a half measure since it still allows the old behaviour.
can you move the whatsnew note to the I/O section
@jreback done
This test has failed twice for reasons that I'm unclear on

**Code Checks / ASV Benchmarks**

``` bash
[ 50.00%] ··· ...a.TimedeltaProperties.time_timedelta_seconds           3.80±0μs
Error: Process completed with exit code 1.
```
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
pls merge master
@jreback done
thanks @z3c0
DO NOT MERGE: Testing if benchmarks build is slow with latest asv
State: closed

xref https://github.com/airspeed-velocity/asv/issues/1026 #44450

We pinned asv in #45886 since the benchmarks build took a very long time to complete after the release.

Testing here if this is consistent, and can be reproduced, or if it was something that happened just once.

CC: @LucyJimenez

Labels:

Comments:
Confirmed that asv 0.5 makes pandas benchmarks run super slow, at least in the CI. Closing this, hopefully we can release an asv 0.5.2 soon with a fix.
BUG: Concatenating categorical datetime columns raises a ValueError since v1.2
State: closed

- [x] closes #39443
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Stale

Comments:
Hello @eshirvana! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-03-28 16:33:33 UTC
can you merge master and ping when passing
> can you merge master and ping when passing

@jreback  done
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appear to have gone stale. If interested in continuing, please merge in main, address the failures in the CI, and we can reopen.
BUG: rolling(axis=1).apply() raising ValueError
State: closed

- [x] closes #45912
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Window
description: rolling, ewma, expanding

Comments:
i suppose could backport
Thanks @mroeschke
DOC: add Python 3.10 to doc
State: closed

- [x] closes #45921 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Python 3.10

Comments:
Thanks @eshirvana 
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
DOC: fix URLs, formatting and typos
State: closed

"## Development tools" is not formatted correctly here: https://pandas.pydata.org/community/ecosystem.html
![Screenshot 2022-02-10 10 22 42](https://user-images.githubusercontent.com/23830955/153439086-c356f348-0e12-4888-9f46-a8729eab8bc7.png)



Labels:
name: Docs

Comments:
> Thanks @partev - btw, if you have many more changes like these, it's OK to group them together into the same PR
> 

yes, please don't fill up the PRs with a number of one line typos fixes. 

It is probably better to close the other PRs and include them all here. Thx
> > Thanks @partev - btw, if you have many more changes like these, it's OK to group them together into the same PR
> 
> yes, please don't fill up the PRs with a number of one line typos fixes.
> 
> It is probably better to close the other PRs and include them all here. Thx

ok, I will combine them here.
thanks @partev 
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
fix URL redirect
State: closed

http://www.cython.org/ -> https://cython.org

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
consolidated with other merge requests
DOC: fix incorrect documentation
State: closed

first_valid_index() returns None if no non-NA values are found.

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
consolidated into other merge request
DOC: fix a typo
State: closed

all other plotting functions refer to :meth:`DataFrame.plot`. for **kwargs

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
consolidated with other merger requests
TST/CI: Set hypothesis deadline to None to avoid flaky failures
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Avoid these flaky hypothesis failures in our CI:

```
2022-02-09T18:42:22.5859159Z C:\Miniconda\envs\pandas-dev\lib\site-packages\hypothesis\core.py:886: Flaky
2022-02-09T18:42:22.5859944Z --------------------------------- Hypothesis ----------------------------------
2022-02-09T18:42:22.5860630Z Falsifying example: test_range_difference(
2022-02-09T18:42:22.5861315Z     start1=8, stop1=-20, step1=1, start2=8, stop2=-8, step2=11,
2022-02-09T18:42:22.5861919Z )
2022-02-09T18:42:22.5863006Z Unreliable test timings! On an initial run, this test took 2344.29ms, which exceeded the deadline of 500.00ms, but on a subsequent run it took 0.82 ms, which did not. If you expect this sort of variability in your test timings, consider turning deadlines off for this test by setting deadline=None.
```

Most of the time they go away and not sure if anyone is knowledgeable to know why they happen.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: CI
description: Continuous Integration

Comments:
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
BUG: DateOffset(n) not defaulting to days
State: closed

- [x] closes #45890 (Replace xxxx with the Github issue number)
- [x] closes #45643
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Regression from 1.3.5

Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: Frequency
description: DateOffsets

Comments:
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
Use Mamba in Azure CI
State: closed

Use Mamba in Azure CI to save ~10 minutes of setup time.

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration

Comments:
ping @mroeschke 
Did mamba solve unpinned dependencies differently than conda for builds in Azure?

For example in GHA builds, I noticed mamba would install pyarrow=2 while conda would install pyarrow=6
It seems like it always installs Arrow 6, so no change in version.

Edit: Ran a diff of all versions, no changes except for build numbers which are due to different start times I am assuming.
@jonashaag please don't force push after an approval.
@simonjayhawkins Thanks, will keep that in mind in the future. In this case it was a rebase to latest `main` using the GitHub UI.
Hmm, seems like there is a problem with Azure and Mamba, see https://github.com/mamba-org/mamba/issues/488

```
    RuntimeError: Operation not permitted: '/usr/local/miniconda/pkgs/cache/dd44a73b.json'

```
> Hmm, seems like there is a problem with Azure and Mamba, see [mamba-org/mamba#488](https://github.com/mamba-org/mamba/issues/488)
> 
> ```
>     RuntimeError: Operation not permitted: '/usr/local/miniconda/pkgs/cache/dd44a73b.json'
> ```

Is this a full blocker for implementing this?
Let's try the workaround suggested there.
This seems to fix the issue, although I'm not sure if will reappear. The other repos that have this implemented successfully for some time indicate that it's not the case but I don't feel confident about that.
thanks @jonashaag very nice!
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
Testcase Subtracting two series with unordered index and all-nan index produces unexpected result
State: closed

- [x] closes #38439
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-02-11 15:22:31 UTC
Thanks again @weikhor!
TST: Test change axis in boxplot
State: closed

- [X] closes #2980 
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).




Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Visualization
description: plotting

Comments:
Thanks @NumberPiOso! Great as always
BUG: Error reporting str.startswith and str.endswith
State: closed

- [X] closes #3485
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added an entry in the latest `doc/source/whatsnew/v1.5.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Strings
description: String extension data type and string data

Comments:
Thanks again! (Failures were unreleated)
DOC: Imbalanced backticks.
State: closed

Screw up some RST parsers.

<!--
- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.
-->

Labels:
name: Docs

Comments:
Thanks @Carreau
TST: add test for DataFrame with duplicate indices concat
State: closed

- [x] closes #36263
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Previously DataFrame with duplicate indices will raise ValueError. With some changes, this will raise InvalidIndexError. This PR add a test for this behavior.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
@github-actions pre-commit
Merged and seems more checks are queued, let's wait and see。
Hello @zhengfeiwang! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-02-11 11:41:58 UTC
Thanks @zhengfeiwang
CI: Debug ASV timeout
State: closed

Appears ASV runs in the CI take 3+ hours recently. Confirming that this isn't due to the latest ASV release.

Note: Appears it may have been due to the new release so pinning in environment.yml


Labels:
name: CI
description: Continuous Integration
name: Benchmark
description: Performance (ASV) benchmarks

Comments:
Thanks @mroeschke 
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.