BrandonFors/pandas-github-issues huggingface dataset:
split off scalar tests to submodules
State: closed

Spun off from #19738, implements test_arithmetic for timedeltas, _moves_ and organizes tests without changing anything in the non-test code.

A handful of xfail tests are implemented (these are fixed in #19378)

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19752?src=pr&el=h1) Report
> Merging [#19752](https://codecov.io/gh/pandas-dev/pandas/pull/19752?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c1f0c63191e318981b5a244a3f240090df63f1d0?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19752/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19752?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19752      +/-   ##
==========================================
+ Coverage    91.6%    91.6%   +<.01%     
==========================================
  Files         150      150              
  Lines       48864    48864              
==========================================
+ Hits        44761    44762       +1     
+ Misses       4103     4102       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.98% <ø> (ø)` | :arrow_up: |
| #single | `41.77% <ø> (+0.01%)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19752?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/19752/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvb3BzLnB5) | `96.62% <0%> (+0.16%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19752?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19752?src=pr&el=footer). Last update [c1f0c63...6d45594](https://codecov.io/gh/pandas-dev/pandas/pull/19752?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

moved the rest of the scalar files. ping on green.
@jbrockmendel you will need to rebase anything that involves scalar tests
FIX: const-correctness in numpy helpers
State: closed

In python 3.7 the return type of PyUnicode_AsUTF8 changed
from (char *) to (const char *).

PyUnicode_FromString also takes (const char *) as input, also be
explicit about that.

https://bugs.python.org/issue28769
commit 2a404b63d48d73bbaa007d89efb7a01048475acd in cpython

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
thanks @tacaswell 

haven't touched 3.7 yet!!!
ping on green.
@tcaswell do you have a 3.7 going on CI?
my day-to-day enviroment at home is cpython master + master branch of most of the scipy stack :smiling_imp: .
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19749?src=pr&el=h1) Report
> Merging [#19749](https://codecov.io/gh/pandas-dev/pandas/pull/19749?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c086a518fe728deda168a4f800e4224e497ad19a?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19749/graphs/tree.svg?height=150&src=pr&token=eZ4WkYLtcO&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/19749?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19749      +/-   ##
==========================================
- Coverage    91.6%    91.6%   -0.01%     
==========================================
  Files         150      150              
  Lines       48864    48864              
==========================================
- Hits        44763    44761       -2     
- Misses       4101     4103       +2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.97% <ø> (-0.01%)` | :arrow_down: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/19749/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `83.64% <0%> (-0.21%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19749?src=pr&el=footer). Last update [c086a51...f97a40c](https://codecov.io/gh/pandas-dev/pandas/pull/19749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @tacaswell happy to have these
DOC: Updated tutorials.rst, added 3 recent video tutorials
State: closed

I have made the following changes to  `tutorials.rst` (found [here](http://pandas-docs.github.io/pandas-docs-travis/tutorials.html)):
- Updated the version of the [pandas-cookbook](https://github.com/jvns/pandas-cookbook) from `v0.1` to `v0.2`.
- Added an introductory paragraph to the tutorial series by @TomAugspurger.
- Added 3 recent, high-quality video tutorials (Youtube).



Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19748?src=pr&el=h1) Report
> Merging [#19748](https://codecov.io/gh/pandas-dev/pandas/pull/19748?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c8d83311611814b36aff9edab8bac902f2ec74ee?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19748/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19748?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19748      +/-   ##
==========================================
- Coverage    91.6%   91.58%   -0.03%     
==========================================
  Files         150      150              
  Lines       48862    48862              
==========================================
- Hits        44762    44750      -12     
- Misses       4100     4112      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.95% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19748?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19748/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19748?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19748?src=pr&el=footer). Last update [c8d8331...cd768cf](https://codecov.io/gh/pandas-dev/pandas/pull/19748?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks. I'm surprised we didn't already link to Brandon Rhode's tutorial.
DOC/BLD: Pinning sphinx to 1.5, as 1.7 has been released and it's incompatible with vendored numpydoc
State: closed

- [X] closes #19742
- [ ] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Build
description: Library building on various platforms
name: Docs

Comments:
thanks
Ahh this should have gone in `environment-dev.yaml` and been auto-generated by `scripts/convert_deps.py`. Can you make another PR @datapythonista?
ahh that's right.
If the performance problems are solved with Sphinx 1.7, I would rather do the small fix in our vendored numpydoc version instead of keep pinning sphinx to 1.5. 
I am trying to test this in https://github.com/pandas-dev/pandas/pull/19687, but the problem it keeps installing sphinx 1.6 because it is not yet available on defaults. Will change it temporarily to install from conda-forge to test it.
Updated the other PR, let's see what it does: https://travis-ci.org/pandas-dev/pandas/jobs/343064791
I reverted this in https://github.com/pandas-dev/pandas/pull/19687, and the last commit there tested sphinx 1.7 on travis, and it ran without failure and without time-out. So it seems we are good for sphinx 1.7.
finish off tests.tseries.test_timezones
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timezones
description: Timezone data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19739?src=pr&el=h1) Report
> Merging [#19739](https://codecov.io/gh/pandas-dev/pandas/pull/19739?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/44c822de8dee0bf0e1ed2e8bc15424bb323b786f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19739/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19739?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19739   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         150      150           
  Lines       48862    48862           
=======================================
  Hits        44750    44750           
  Misses       4112     4112
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.95% <ø> (ø)` | :arrow_up: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19739?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19739?src=pr&el=footer). Last update [44c822d...ff15992](https://codecov.io/gh/pandas-dev/pandas/pull/19739?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Implement missing tests, fix offset floordiv, rfloordiv, fix return types
State: closed

This splits off of #19365 a bunch of peripheral changes that were never intended to be part of #19365 in the first place.

- Implements many tests in the "how is there not already a test for that!?" category
- Fixes(+tests) Timedelta // DateOffset and DateOffset // Timedelta
- Fixes(+tests) return types for `Timedelta.__add__, __radd__, __sub__, __rsub__(np.timedelta64)` (ATM returns `timedelta64`) 
- Fixes a typo in test_construction that causes a dummy assertion to be made instead of the intended assertion.

- [ ] closes #xxxx
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19738?src=pr&el=h1) Report
> Merging [#19738](https://codecov.io/gh/pandas-dev/pandas/pull/19738?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/44c822de8dee0bf0e1ed2e8bc15424bb323b786f?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19738/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19738?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19738      +/-   ##
==========================================
+ Coverage   91.58%   91.61%   +0.02%     
==========================================
  Files         150      150              
  Lines       48862    48862              
==========================================
+ Hits        44750    44763      +13     
+ Misses       4112     4099      -13
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.98% <ø> (+0.02%)` | :arrow_up: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19738?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/19738/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvb3BzLnB5) | `97.01% <0%> (+0.17%)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19738/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19738?src=pr&el=footer). Last update [44c822d...edcd7e0](https://codecov.io/gh/pandas-dev/pandas/pull/19738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Closing n favor of #19752 plus  followups
DOC: correct merge_asof example
State: closed

- [ ] closes #19489 
- [x] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

- update of incorrect documentation example for merge_asof.
- add a test corresponding to this example.

Labels:
name: Docs
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Hello @ZhuBaohe! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on February 18, 2018 at 17:46 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19737?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@c4770c7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19737/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19737?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19737   +/-   ##
=========================================
  Coverage          ?   91.58%           
=========================================
  Files             ?      150           
  Lines             ?    48862           
  Branches          ?        0           
=========================================
  Hits              ?    44750           
  Misses            ?     4112           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.95% <ø> (?)` | |
| #single | `41.75% <ø> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19737?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/reshape/merge.py](https://codecov.io/gh/pandas-dev/pandas/pull/19737/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzaGFwZS9tZXJnZS5weQ==) | `94.25% <ø> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19737?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19737?src=pr&el=footer). Last update [c4770c7...16d4260](https://codecov.io/gh/pandas-dev/pandas/pull/19737?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Split+Parametrize Timedelta tests
State: closed

Started splitting non-contentious parts off of #19365.  This even-easier bit got split off of that.  Just organizing+splitting+parametrizing tests.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19736?src=pr&el=h1) Report
> Merging [#19736](https://codecov.io/gh/pandas-dev/pandas/pull/19736?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/718d0679600fa025872d8b66c198a6781b312d70?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19736/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19736?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19736      +/-   ##
==========================================
+ Coverage    91.6%   91.61%   +<.01%     
==========================================
  Files         150      150              
  Lines       48864    48887      +23     
==========================================
+ Hits        44763    44786      +23     
  Misses       4101     4101
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.98% <ø> (ø)` | :arrow_up: |
| #single | `41.8% <ø> (+0.02%)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/panel.py](https://codecov.io/gh/pandas-dev/pandas/pull/19736/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcGFuZWwucHk=) | `97.3% <0%> (ø)` | :arrow_up: |
| [pandas/core/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/19736/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvb3BzLnB5) | `96.74% <0%> (+0.12%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19736?src=pr&el=footer). Last update [718d067...a852a4b](https://codecov.io/gh/pandas-dev/pandas/pull/19736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

For now I'll update this PR to make timedeltas/test_construction.py, will move the others after #19744 (a not just-refactoring PR) goes through.
This didn't get an explicit "ping on green", but pretty close.  ping.
lgtm ping on green
thanks!
CLN: Removed Unnecessary Conditionals in groupby_helper
State: closed

- [X] closes #19724 
- [X] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

ASV results are pretty inconsistent but I couldn't find anything directly related from this change. Of the marks below, only `max` was touched by this change, and that doesn't appear consistently in the results

```bash
       before           after         ratio
     [2fdf1e25]       [458210c1]
+         155±1μs          173±4μs     1.12  groupby.GroupByMethods.time_method('float', 'max')
+         324±1μs          361±5μs     1.12  groupby.GroupByMethods.time_method('float', 'median')
-         722±5μs          638±8μs     0.88  groupby.GroupByMethods.time_method('int', 'cumprod')
-        540±10μs          463±1μs     0.86  groupby.GroupByMethods.time_method('int', 'cummax')
-        551±20μs          459±1μs     0.83  groupby.GroupByMethods.time_method('int', 'cummin')
-      1.17±0.1ms          475±7μs     0.40  groupby.GroupByMethods.time_method('float', 'sem')
```

Labels:
name: Groupby
name: Clean

Comments:
Same Travis failures we've been having recently - appear unrelated to change
thanks @WillAyd even if this were slower it reduces code complexity which is good.
Remove redundant parentheses from if conditions
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Hello @Giftlin! Thanks for submitting the PR.

 - In the file [`pandas/plotting/_timeseries.py`](https://github.com/pandas-dev/pandas/blob/ed9a40fd396c7c6c646e4bb4a5d45f9f4ef59cce/pandas/plotting/_timeseries.py), following are the PEP8 issues :

> [Line 112:13](https://github.com/pandas-dev/pandas/blob/ed9a40fd396c7c6c646e4bb4a5d45f9f4ef59cce/pandas/plotting/_timeseries.py#L112): [E113](https://duckduckgo.com/?q=pep8%20E113) unexpected indentation