DEPR: remove pandas.core.common is_*
State: closed

xref #13990
xref #19304 

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Ah, I see.

In that cause, probably best to just remove. I would split that off into
it's own subitem in the release notes though (we could also add it to
pandas_compat, right?).

On Mon, Feb 19, 2018 at 2:35 PM, Joris Van den Bossche <
notifications@github.com> wrote:

> *@jorisvandenbossche* commented on this pull request.
> ------------------------------
>
> In doc/source/whatsnew/v0.23.0.txt
> <https://github.com/pandas-dev/pandas/pull/19769#discussion_r169167270>:
>
> > @@ -624,6 +624,7 @@ Removal of prior version deprecations/changes
>  - The modules `pandas.tools.hashing` and `pandas.util.hashing` have been removed (:issue:`16223`)
>  - The top-level functions ``pd.rolling_*``, ``pd.expanding_*`` and ``pd.ewm*`` have been removed (Deprecated since v0.18).
>    Instead, use the DataFrame/Series methods :attr:`~DataFrame.rolling`, :attr:`~DataFrame.expanding` and :attr:`~DataFrame.ewm` (:issue:`18723`)
> +- Imports from ``pandas.core.common`` for api like functions such as ``is_datetime64_dtype`` are now removed. These are located in ``pandas.api.types``. Furthermore, errors are removed as well from ``pandas.core.common`` and are available in ``pandas.errors`` (:issue:`13990`)
>
> I think the only way this can really be solved is by renaming
> core/common.py to eg core/utils.py, and then you can deprecate the whole
> core/common.py module, and already raise warning on importing it.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/19769#discussion_r169167270>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIrRypQg_tMPT3DGCGcQi0w5F1Mojks5tWdslgaJpZM4SK5Eh>
> .
>

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19769?src=pr&el=h1) Report
> Merging [#19769](https://codecov.io/gh/pandas-dev/pandas/pull/19769?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e022d9a0886b245afe4af4cc43904a112cd00882?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `50%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19769/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19769?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19769      +/-   ##
==========================================
- Coverage   91.61%   91.57%   -0.05%     
==========================================
  Files         150      150              
  Lines       48887    48865      -22     
==========================================
- Hits        44786    44746      -40     
- Misses       4101     4119      +18
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.94% <50%> (-0.05%)` | :arrow_down: |
| #single | `41.79% <16.66%> (-0.02%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19769?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/pull/19769/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `92.9% <ø> (-0.52%)` | :arrow_down: |
| [pandas/core/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/19769/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYmFzZS5weQ==) | `96.8% <40%> (ø)` | :arrow_up: |
| [pandas/core/resample.py](https://codecov.io/gh/pandas-dev/pandas/pull/19769/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzYW1wbGUucHk=) | `96.43% <57.14%> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19769/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |
| [pandas/core/dtypes/common.py](https://codecov.io/gh/pandas-dev/pandas/pull/19769/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL2NvbW1vbi5weQ==) | `93.91% <0%> (-1.46%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19769?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19769?src=pr&el=footer). Last update [e022d9a...56017ca](https://codecov.io/gh/pandas-dev/pandas/pull/19769?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).