BrandonFors/pandas-github-issues huggingface dataset:
DOC: Follows ISO 639-1 code
State: closed

## Changes
- change suffix `_JP` to `_JA` according to `ISO 639`
- fixed typo in `Pandas_Cheat_Sheet_JA.pdf`
- translated `Pandas_Cheat_Sheet_JA.pptx` in Japanese

Labels:
name: Docs

Comments:
What is this fixing / changing?
thanks @TomAugspurger .

## Changes
- change suffix `_JP` to `_JA` according to `ISO 639`
- fixed typo in `Pandas_Cheat_Sheet_JA.pdf`
- translated `Pandas_Cheat_Sheet_JA.pptx` in Japanese

I updated description.
Are these linked to anywhere on pandas.pydata.org? We'll need to put in a redirect on github.com/pandas-dev/pandas-website if so.

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22657?src=pr&el=h1) Report
> Merging [#22657](https://codecov.io/gh/pandas-dev/pandas/pull/22657?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/0976e1261781153603064eb67d66630a099edcd7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22657/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22657?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22657   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         169      169           
  Lines       50708    50708           
=======================================
  Hits        46740    46740           
  Misses       3968     3968
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.58% <ø> (ø)` | :arrow_up: |
| #single | `42.35% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22657?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22657?src=pr&el=footer). Last update [0976e12...d757f66](https://codecov.io/gh/pandas-dev/pandas/pull/22657?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Seems like the Japanese cheatsheets are not linked anywhere. Merging the fixes, and we can take care of adding links in a separate PR.

Thanks for the PR @KangYoosam, and for taking care of the Japanese translation.
pythonize cython code
State: closed

Use python-style type annotations instead of cython-style in a few places.

Use python-style isinstance checks in cases where cython will automatically optimize them into C calls.

Part of the hope is that we can get the code close enough to valid python that we can trick flake8 into working on it.

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22638?src=pr&el=h1) Report
> Merging [#22638](https://codecov.io/gh/pandas-dev/pandas/pull/22638?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/0976e1261781153603064eb67d66630a099edcd7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22638/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22638?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22638   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         169      169           
  Lines       50708    50708           
=======================================
  Hits        46740    46740           
  Misses       3968     3968
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.58% <ø> (ø)` | :arrow_up: |
| #single | `42.35% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22638?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22638?src=pr&el=footer). Last update [0976e12...f9c0c26](https://codecov.io/gh/pandas-dev/pandas/pull/22638?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks. maybe add a note somewhere that we *can* use type annotation in cython files (*maybe* at the top of each file?)
> Use python-style type annotations instead of cython-style in a few places.

Sorry, why do we think this is an improvement? Now we have two ways of doing things? 
Can you provide a bit more background / reasoning?
Some discussion in #22180.

Main motivation: I _think_ that if we can get the code close enough to valid python, we can trick flake8 into running on it.
DOC: improve doc string for .aggregate and df.transform
State: closed

Since #21224, operations using ``axis=1`` in df.aggregate and df.transform now work the same as when ``axis=0``.

This PR updates the methods' doc strings to reflect that. For example, we can now pass a dict to DataFrame.agg/transform, also when ``axis=1``, and DataFrame.transform now accepts an ``axis`` parameter.

Also some related minor clarifications.

Labels:

Comments:
Hello @topper-123! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/generic.py`](https://github.com/topper-123/pandas/blob/dfbf8e90ae4fea5f9f1aee09fa15a7b0bd55f14d/pandas/core/generic.py) !
BUG: NaN should have pct rank of NaN
State: closed

Backport of #22600.

Labels:
name: Groupby
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
Hello @gfyoung! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/groupby/test_rank.py`](https://github.com/gfyoung/pandas/blob/d12f1d044802b2cd50b6d7038683599785e4bd49/pandas/tests/groupby/test_rank.py) !


@jreback @TomAugspurger : Looks like we need to backport #22601 and #21814 too?
@gfyoung yep those CI backport are needed 
can u PR?
@jreback : Yep, sounds good.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22634?src=pr&el=h1) Report
> Merging [#22634](https://codecov.io/gh/pandas-dev/pandas/pull/22634?src=pr&el=desc) into [0.23.x](https://codecov.io/gh/pandas-dev/pandas/commit/183e92f1309a15e34c890e6c18dd5c7c53f61210?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22634/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22634?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           0.23.x   #22634   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         153      153           
  Lines       49588    49588           
=======================================
  Hits        45543    45543           
  Misses       4045     4045
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.24% <ø> (ø)` | :arrow_up: |
| #single | `41.79% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22634?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22634?src=pr&el=footer). Last update [183e92f...349e939](https://codecov.io/gh/pandas-dev/pandas/pull/22634?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

This is a clean backport, and with all tests now passing, going to merge this.
CLN/DEPR: removed deprecated as_indexer arg from str.match()
State: closed

- [x] closes #22316
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

This is the renewal of #22356, as the git got tangled up I re-forked the repo.

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Hello @HyunTruth! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/strings.py`](https://github.com/HyunTruth/pandas/blob/1bc05c298c8df1e7834ab91a86e204d2dbf001fe/pandas/core/strings.py) !

 - There are no PEP8 issues in the file [`pandas/tests/test_strings.py`](https://github.com/HyunTruth/pandas/blob/1bc05c298c8df1e7834ab91a86e204d2dbf001fe/pandas/tests/test_strings.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22626?src=pr&el=h1) Report
> Merging [#22626](https://codecov.io/gh/pandas-dev/pandas/pull/22626?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/14ccdd22f158b7944a403e02082402bc85fb11a5?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22626/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22626?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22626      +/-   ##
==========================================
- Coverage   92.04%   92.04%   -0.01%     
==========================================
  Files         169      169              
  Lines       50782    50778       -4     
==========================================
- Hits        46744    46740       -4     
  Misses       4038     4038
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <100%> (-0.01%)` | :arrow_down: |
| #single | `42.27% <66.66%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22626?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/strings.py](https://codecov.io/gh/pandas-dev/pandas/pull/22626/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3RyaW5ncy5weQ==) | `98.63% <100%> (-0.01%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22626?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22626?src=pr&el=footer). Last update [14ccdd2...a95baf7](https://codecov.io/gh/pandas-dev/pandas/pull/22626?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Did the small change, thanks a lot @HyunTruth !
Thanks @jorisvandenbossche!
Test in scripts/validate_docstrings.py that the short summary is always one line long
State: closed

- [x] closes #22615
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

The previous test to check if the summary property should be empty was based on the non-existence of the extended summary which doesn't seem to make sense. The test case I added failed before changing the script.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Docs

Comments:
Hello @Moisan! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`scripts/tests/test_validate_docstrings.py`](https://github.com/Moisan/pandas/blob/108d092a50f7a374ef1f914e6e93fbe239c439f8/scripts/tests/test_validate_docstrings.py) !

 - There are no PEP8 issues in the file [`scripts/validate_docstrings.py`](https://github.com/Moisan/pandas/blob/108d092a50f7a374ef1f914e6e93fbe239c439f8/scripts/validate_docstrings.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22617?src=pr&el=h1) Report
> Merging [#22617](https://codecov.io/gh/pandas-dev/pandas/pull/22617?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/46abe186d21f2bab3c5df53c906b6a62d07e922b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22617/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22617?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22617   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50782    50782           
=======================================
  Hits        46744    46744           
  Misses       4038     4038
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <ø> (ø)` | :arrow_up: |
| #single | `42.26% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22617?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22617?src=pr&el=footer). Last update [46abe18...8e08dd6](https://codecov.io/gh/pandas-dev/pandas/pull/22617?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@datapythonista pls merge if ok
thanks @Moisan
BLD: Fix openpyxl to 2.5.5
State: closed

`2.5.5` --> `2.5.6` broke compatibility with pandas `Timestamp` objects.

Closes #22595.

Labels:
name: Build
description: Library building on various platforms
name: CI
description: Continuous Integration
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22601?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@a5fe9cf`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22601/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22601?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #22601   +/-   ##
=========================================
  Coverage          ?   92.04%           
=========================================
  Files             ?      169           
  Lines             ?    50787           
  Branches          ?        0           
=========================================
  Hits              ?    46746           
  Misses            ?     4041           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <ø> (?)` | |
| #single | `42.29% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22601?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22601?src=pr&el=footer). Last update [a5fe9cf...8a1614c](https://codecov.io/gh/pandas-dev/pandas/pull/22601?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
Fix string format in test runner
State: closed

`.format()` was expecting keyword arguments. Updated to match other skips nearby.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Strings
description: String extension data type and string data

Comments:
Hello @rhysparry! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/util/testing.py`](https://github.com/rhysparry/pandas/blob/80db0b25bc9f4b2d0eaed6a71170431677ad791f/pandas/util/testing.py) !

 - Complete extra results for this file :

> file_to_check.py:2442:-258: W605 invalid escape sequence '\('
file_to_check.py:2442:-255: W605 invalid escape sequence '\)'
---


If you fetch and merge master the CI failures should be fixed.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22598?src=pr&el=h1) Report
> Merging [#22598](https://codecov.io/gh/pandas-dev/pandas/pull/22598?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e2e1a1051576a48f210ce17272fc24b90ebcf24a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22598/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22598?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22598   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50782    50782           
=======================================
  Hits        46742    46742           
  Misses       4040     4040
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <ø> (ø)` | :arrow_up: |
| #single | `42.3% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22598?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/22598/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `85.75% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22598?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22598?src=pr&el=footer). Last update [e2e1a10...7525271](https://codecov.io/gh/pandas-dev/pandas/pull/22598?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@rhysparry : Thanks!
Set hypothesis healthcheck
State: closed

- [y] closes #22593
- [pending] tests added / passed
- [y] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [N/A] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: CI
description: Continuous Integration

Comments:
Hello @alimcmaster1! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/conftest.py`](https://github.com/alimcmaster1/pandas/blob/91042cedfe8aa7bb705f98b1811d27ff187e4a41/pandas/conftest.py) !


If you fetch and merge master the CI failures should be fixed.
thanks @alimcmaster1
CLN: tests for str.cat
State: closed

Cleaning up some left-overs from #20347 and preparing the tests for changing the default of `join` to `'left'` in 1.0 (which would break some tests that assume no alignment currently). As a side benefit, this has:
* nicer parametrization
* nicer switches (and reduced usage of them within the tests)
* now follows `result / expected` pattern instead of calculating result within `assert_..._equal`

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Strings
description: String extension data type and string data
name: Clean

Comments:
@h-vetinari : Anaconda servers are experiencing some `503` issues.  I'll restart tests later.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22575?src=pr&el=h1) Report
> Merging [#22575](https://codecov.io/gh/pandas-dev/pandas/pull/22575?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e2e1a1051576a48f210ce17272fc24b90ebcf24a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22575/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22575?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22575   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50782    50782           
=======================================
  Hits        46742    46742           
  Misses       4040     4040
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <ø> (ø)` | :arrow_up: |
| #single | `42.3% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22575?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22575?src=pr&el=footer). Last update [e2e1a10...2e1a3b6](https://codecov.io/gh/pandas-dev/pandas/pull/22575?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hello @h-vetinari! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/tests/test_strings.py`](https://github.com/h-vetinari/pandas/blob/54721b988c1ec6c718d943eaae7f1f9037fd3ed9/pandas/tests/test_strings.py) !



##### Comment last updated on September 04, 2018 at 23:02 Hours UTC
@jreback 
> pls don't use abbreviations, eg. always use expected

This module's full of `exp` (maybe even the majority), but I replaced it in the diff I'm working on now.
not sure what's up with these `TestExcelWriter` test failures...? rebasing didn't help.

Edit: saw that 22601 solved it. Rebased again.
@jreback All green
thanks @h-vetinari