BrandonFors/pandas-github-issues huggingface dataset:
API: Treat 1D vectors as columns in some cases for arith/cmp ops
State: closed

Definitely needs discussion.

There are a bunch of GH issues (will track down the list in a bit) that boil down to users expecting DataFrame+(Series|ndarray|listlike) ops to operate column-by-column.  This PR implements that behavior for a subset of cases.  In particular:

- `other` is a `Series`: indexes match exactly (and columns do not)
- `other` is a list/tuple/np.ndarray: length matches df.index (and not df.columns)

This means that things like `df == df['A']` will now work.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Hello @jbrockmendel! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/core/frame.py`](https://github.com/jbrockmendel/pandas/blob/9100010585fce40a97d823c7b506e064260ebdb0/pandas/core/frame.py) !

 - There are no PEP8 issues in the file [`pandas/core/ops.py`](https://github.com/jbrockmendel/pandas/blob/9100010585fce40a97d823c7b506e064260ebdb0/pandas/core/ops.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arithmetic/conftest.py`](https://github.com/jbrockmendel/pandas/blob/9100010585fce40a97d823c7b506e064260ebdb0/pandas/tests/arithmetic/conftest.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arithmetic/test_datetime64.py`](https://github.com/jbrockmendel/pandas/blob/9100010585fce40a97d823c7b506e064260ebdb0/pandas/tests/arithmetic/test_datetime64.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arithmetic/test_period.py`](https://github.com/jbrockmendel/pandas/blob/9100010585fce40a97d823c7b506e064260ebdb0/pandas/tests/arithmetic/test_period.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arithmetic/test_timedelta64.py`](https://github.com/jbrockmendel/pandas/blob/9100010585fce40a97d823c7b506e064260ebdb0/pandas/tests/arithmetic/test_timedelta64.py) !

 - There are no PEP8 issues in the file [`pandas/tests/frame/test_operators.py`](https://github.com/jbrockmendel/pandas/blob/9100010585fce40a97d823c7b506e064260ebdb0/pandas/tests/frame/test_operators.py) !



##### Comment last updated on October 24, 2018 at 02:56 Hours UTC
this is really confusing

we have .eq for this exact reason

pls justify why this should change
> pls justify why this should change

I'm not 100% sure that it should.  But it is only now feasible following #23132 and it does come up often enough to merit discussion.  I'll try to fill out the list of Issues over the next couple days.

Can you first open an issue for this to propose a specific behaviour and discuss it?
fix and test incorrect case in delta_to_nanoseconds
State: closed

Some minor cython cleanup along the way

Labels:
name: Bug
name: Timedelta
description: Timedelta data type

Comments:
Hello @jbrockmendel! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/tslibs/test_timedeltas.py`](https://github.com/jbrockmendel/pandas/blob/e3caa49bc35315f1e35c69d1b63122e34892dc72/pandas/tests/tslibs/test_timedeltas.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23302?src=pr&el=h1) Report
> Merging [#23302](https://codecov.io/gh/pandas-dev/pandas/pull/23302?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/5a0c91e5a5bc61c71da08d6968d973255829678d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23302/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23302?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23302   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         169      169           
  Lines       50897    50897           
=======================================
  Hits        46940    46940           
  Misses       3957     3957
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.65% <ø> (ø)` | :arrow_up: |
| #single | `42.29% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23302?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23302?src=pr&el=footer). Last update [5a0c91e...e3caa49](https://codecov.io/gh/pandas-dev/pandas/pull/23302?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

does this have any perf issue?
> does this have any perf issue?

Haven't checked, but should even out, to very slight improvement.  Replace one never-true (early, c-speed) type check with a (late, c-speed) type check.

thanks!
Categorical take fill value
State: closed

Closes https://github.com/pandas-dev/pandas/issues/23296

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Categorical
description: Categorical Data Type

Comments:
Hello @TomAugspurger! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/core/arrays/categorical.py`](https://github.com/TomAugspurger/pandas/blob/fb64335479f7a3ec13db7decf55c77448857b2bc/pandas/core/arrays/categorical.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arrays/categorical/test_algos.py`](https://github.com/TomAugspurger/pandas/blob/fb64335479f7a3ec13db7decf55c77448857b2bc/pandas/tests/arrays/categorical/test_algos.py) !



##### Comment last updated on October 23, 2018 at 14:07 Hours UTC
Ah, forgot to revert a change. 1 sec.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23297?src=pr&el=h1) Report
> Merging [#23297](https://codecov.io/gh/pandas-dev/pandas/pull/23297?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/5a0c91e5a5bc61c71da08d6968d973255829678d?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23297/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23297?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23297      +/-   ##
==========================================
+ Coverage   92.22%   92.22%   +<.01%     
==========================================
  Files         169      169              
  Lines       50897    50903       +6     
==========================================
+ Hits        46940    46946       +6     
  Misses       3957     3957
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.65% <100%> (ø)` | :arrow_up: |
| #single | `42.29% <28.57%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23297?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/arrays/categorical.py](https://codecov.io/gh/pandas-dev/pandas/pull/23297/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2NhdGVnb3JpY2FsLnB5) | `95.56% <100%> (+0.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23297?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23297?src=pr&el=footer). Last update [5a0c91e...fb64335](https://codecov.io/gh/pandas-dev/pandas/pull/23297?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Barplot add space option
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] Adds `space` option to bar charts, which adds space between columns. This is nice especially if the user is making a grouped bar chart.

Example figure
![example](https://user-images.githubusercontent.com/7705285/47348034-3ddd3080-d6b9-11e8-8380-3ada4f8b6cbe.png)
:


Labels:
name: Visualization
description: plotting
name: API Design

Comments:
Hello @Pingviinituutti! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/plotting/_core.py`](https://github.com/Pingviinituutti/pandas/blob/e909f0d76c2fe4fed73fcfb4ae7421c14d6fa9d0/pandas/plotting/_core.py) !


Good comments! I'll allocate some time to add that stuff :)
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23292?src=pr&el=h1) Report
> Merging [#23292](https://codecov.io/gh/pandas-dev/pandas/pull/23292?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/14f25bb8b7ba0c709dd36d79966abea648d0f48b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23292/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23292?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23292      +/-   ##
==========================================
+ Coverage   92.22%   92.22%   +<.01%     
==========================================
  Files         169      169              
  Lines       50900    50902       +2     
==========================================
+ Hits        46943    46945       +2     
  Misses       3957     3957
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.65% <100%> (ø)` | :arrow_up: |
| #single | `42.29% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23292?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_core.py](https://codecov.io/gh/pandas-dev/pandas/pull/23292/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb3JlLnB5) | `83.65% <100%> (+0.02%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23292?src=pr&el=footer). Last update [14f25bb...944e565](https://codecov.io/gh/pandas-dev/pandas/pull/23292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@Pingviinituutti can you merge master, update to comments, and add a test
Closing as stale. Ping if you'd like to continue
Revert "implement TimedeltaArray asm8, to_timedelta64 (#23205)"
State: closed

This reverts commit 6e507133916fc5a8434e21eb267043fc9a3ba8d7 (https://github.com/pandas-dev/pandas/pull/23205)

Labels:

Comments:
Hello @jorisvandenbossche! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/arrays/datetimes.py`](https://github.com/jorisvandenbossche/pandas/blob/a5020955ab9fbcde9e37b93063d1922ac0143827/pandas/core/arrays/datetimes.py) !

 - There are no PEP8 issues in the file [`pandas/core/arrays/timedeltas.py`](https://github.com/jorisvandenbossche/pandas/blob/a5020955ab9fbcde9e37b93063d1922ac0143827/pandas/core/arrays/timedeltas.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arrays/test_datetimelike.py`](https://github.com/jorisvandenbossche/pandas/blob/a5020955ab9fbcde9e37b93063d1922ac0143827/pandas/tests/arrays/test_datetimelike.py) !
CLN: simplify try_coerce_args
State: closed

Small simplication available following #23132.

Labels:
name: Clean

Comments:
Hello @jbrockmendel! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/internals/blocks.py`](https://github.com/jbrockmendel/pandas/blob/546d36c41c2016751ad277a2c4ee430870f30b96/pandas/core/internals/blocks.py) !


looks fine. ping on green.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23288?src=pr&el=h1) Report
> Merging [#23288](https://codecov.io/gh/pandas-dev/pandas/pull/23288?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/5a0c91e5a5bc61c71da08d6968d973255829678d?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23288/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23288?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23288      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         169      169              
  Lines       50897    50883      -14     
==========================================
- Hits        46940    46926      -14     
  Misses       3957     3957
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.64% <100%> (-0.01%)` | :arrow_down: |
| #single | `42.29% <76.92%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23288?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/internals/blocks.py](https://codecov.io/gh/pandas-dev/pandas/pull/23288/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzL2Jsb2Nrcy5weQ==) | `94.02% <100%> (-0.06%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23288?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23288?src=pr&el=footer). Last update [5a0c91e...657cc5d](https://codecov.io/gh/pandas-dev/pandas/pull/23288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Ping
TST: xfail gbq & feather tests for now as version incompat
State: closed

need to revert these when fixed
https://travis-ci.org/pandas-dev/pandas/builds/444265455


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
cc @tswast is this a newer pandas-gbq?
ok that's fine. can you PR to pandas to fix this up? 
Hello @jreback! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/io/test_feather.py`](https://github.com/jreback/pandas/blob/edca284e221a12af3ac80bea9550f9ab633c051e/pandas/tests/io/test_feather.py) !

 - There are no PEP8 issues in the file [`pandas/tests/io/test_gbq.py`](https://github.com/jreback/pandas/blob/edca284e221a12af3ac80bea9550f9ab633c051e/pandas/tests/io/test_gbq.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23281?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@4cac923`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23281/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23281?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #23281   +/-   ##
=========================================
  Coverage          ?   92.19%           
=========================================
  Files             ?      169           
  Lines             ?    50970           
  Branches          ?        0           
=========================================
  Hits              ?    46991           
  Misses            ?     3979           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.62% <ø> (?)` | |
| #single | `42.25% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23281?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23281?src=pr&el=footer). Last update [4cac923...093b2c9](https://codecov.io/gh/pandas-dev/pandas/pull/23281?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

PR for gbq tests: https://github.com/pandas-dev/pandas/pull/23303
DOC: added examples to mean and fixed quotes
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Hello @rscheiwe! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/core/generic.py`](https://github.com/rscheiwe/pandas/blob/8811b5e2acf1fae4f52af5f883a56f5033ace99c/pandas/core/generic.py) !



##### Comment last updated on October 22, 2018 at 21:14 Hours UTC
Ok, fixed those! 
Why was `doc/test.parquet` committed? That should have been out of scope of this PR?
I'll have to restore and restart. I'm not sure why that pushed.
BUG: Decrement start date with a negative, non-Tick frequency
State: closed

- [x] closes #23270
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Frequency
description: DateOffsets

Comments:
Hello @mroeschke! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/indexes/datetimes/test_date_range.py`](https://github.com/mroeschke/pandas/blob/0791095550ffccdb601c3ac22a43293b6f78b0d2/pandas/tests/indexes/datetimes/test_date_range.py) !

 - There are no PEP8 issues in the file [`pandas/tseries/offsets.py`](https://github.com/mroeschke/pandas/blob/0791095550ffccdb601c3ac22a43293b6f78b0d2/pandas/tseries/offsets.py) !


lgtm. pls rebase after CI is green (soon).
thanks!
added rolling_window
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Hello @alansammarone! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/__init__.py`](https://github.com/alansammarone/pandas/blob/786e43f96d1b7583e8e400f5f89854a9e4c3e523/pandas/__init__.py) !
TST: Condense tests in test_interval_new.py and add new test based on TODO
State: closed

- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Combined a some pairs of similar tests into single tests, e.g. `test_get_indexer_with_interval_multiple_queries` and `test_get_indexer_with_interval_single_queries` are essentially testing the same functionality but with different input to `get_indexer`, so just needed a couple of superficial changes to combine into a single test.

I also added one test based on a TODO, `test_get_indexer_errors`, which verifies that `get_indexer` raises if the `IntervalIndex` is overlapping.  Note that this is consistent with `get_indexer`  raising for other indexes if the index is non-unique; for intervals uniqueness is not enough to ensure unique query results, as a scalar query against an overlapping `IntervalIndex` can return non-unique indices.

I've got all these tests to pass on my WIP branch implementing the new behavior, with the exception of the `slice_locs` tests, so will hopefully have a PR for that soon.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Interval
description: Interval data type
name: Clean

Comments:
Hello @jschendel! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/indexes/interval/test_interval_new.py`](https://github.com/jschendel/pandas/blob/5ec24321ed2e16cef1cec2c7c366d62ea17e105f/pandas/tests/indexes/interval/test_interval_new.py) !


thanks!
Implement Series.__rdivmod__, un-xfail tests
State: closed

- [x] closes #19252
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
do we need to add anything to extension tests to exercise this? I think we are just testing divmod atm

```
    def test_divmod_series_array(self, data):
        s = pd.Series(data)
        self._check_divmod_op(s, divmod, data)
```
in pandas/tests/extension/base/ops.py
> do we need to add anything to extension tests to exercise this?

I'm not very familiar with that test directory.  I expect that will change after the current crop of PRs is done and I get started on Datetime/TimedeltaArray.

After Datetime/Timedelta/PeriodArray are all in place, I'm planning to add them to something like the `box` fixture used in tests/arithmetic.  IntNA should be added there, too.

ok, let me create an issue for this then.
CI: Fix pyarrow compat
State: closed

It looks like the last couple days of CI failures are caused by pyarrow (required by feather-format) bumping from 0.9.0 to 0.11.0.  This checks the version and adapts the passed kwarg as appropriate.

Do we need to pin pyarrow in the CI config to make sure both versions are tested?

Labels:

Comments:
Hello @jbrockmendel! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/io/feather_format.py`](https://github.com/jbrockmendel/pandas/blob/d7b0ff1488472222b96bbc05713fc32bc1f230e7/pandas/io/feather_format.py) !



##### Comment last updated on October 21, 2018 at 21:13 Hours UTC
there is already another PR with this change 
Great, closing in favor of #23112.