BrandonFors/pandas-github-issues huggingface dataset:
TST: Allow “no setter” messages from Python 3.11
State: closed

Loosen “`can't set attribute`” expected messages to also allow messages of the form “`property … of … object has no setter`”, fixing several assertion failures in the tests on Python 3.11.

- [ ] closes #xxxx (Replace xxxx with the Github issue number) **This is a partial fix for https://github.com/pandas-dev/pandas/issues/46680, but does not close it.**
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature **This PR fixes tests.**
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions. **N/A**
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature. **N/A, only a partial bug fix**

Labels:

Comments:
Hello @musicinmybrain! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:







There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-08-02 05:53:44 UTC
@musicinmybrain 
Thanks for your contribution. There is currently another PR #47442 aimed at addressing #46680, and I think some of these messages have already been changed there. In the interest of keeping all 3.11 changes together, I think it would be better for you to comment any additional fixes you might have there.
Thank you for the pointer! I see that the PR you linked already contains a somewhat nicer version of the changes suggested here.
ENH: Support For Interval __contains__ Other Interval (#46613)
State: closed

- [x] closes #46613
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Interval
description: Interval data type

Comments:
Apologies for the mess in the history! I suggested @kapiliyer rebase rather than merge and I'm seeing now that the history's in a weird state. Later today I'll work with him to get his branch into a cleaner state.
History should be in a saner state now. Apologies again for the trouble!
Thanks @kapiliyer!
TYP: pandas.core.series annotations from pandas-stubs
State: closed

contains also changes in generic/frame.py but only to keep them consistent with series.py

edit: and added annotations for frame.py

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Hello @twoertwein! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

























There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-08-15 19:26:20 UTC
Appears to be some typing failures
> Appears to be some typing failures

The typing checks are now green :)
Thanks @twoertwein (failures were unreleated)
Backport PR #47905: BUG: Fix read_xml raising syntax error when reading XML with Chinese tags
State: closed

Manual Backport #47905 

- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/v1.4.4.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO XML
description: read_xml, to_xml

Comments:
IMO I would say the code changes here shouldn't be risky. But since this affects a feature that was added only since in 1.4, for peace of mind I think it's okay if this applies to 1.5.

@ParfaitG would you mind instead changing this PR to only moving the whatsnew note for this change from 1.4.4 to 1.5?
> @ParfaitG would you mind instead changing this PR to only moving the whatsnew note for this change from 1.4.4 to 1.5?

this PR is against 1.4.x where the move only needs to happen on main if I close this backport now
DOC: Move whatsnew for indexing regression
State: closed

xref #47921, https://github.com/pandas-dev/pandas/issues/47867#issuecomment-1198412271

Moves the whatsnew


Labels:
name: Docs

Comments:
milestone 1.4.4 but does not need to be backported (@phofl note that sometimes that the release notes go out of sync and need to be corrected)

Do you think we should also add the code sample from #47867 to close that issue? (the test would also be backported so could be a separate PR) 
Yes. would do this as a follow up
@phofl i'm not sure about #47925 so have resolved the conflict, but if that gets merged we would probably have conflicts here again.
urgh I should have left it in otherwise we will get more conflicts if we have to move the release note for that one.

don't merge this yet. although i'm doing something else at the moment (fixing the typing on 1.4.x) so probably won't fix this till tomorrow.
No worries, added it back in
Thanks. sorry for interfering. I thought it'd be quicker to just resolve the conflicts on the web interface than ping you.
No worries. I am doing this in Pycharm anyway, so did not create additional work for me. Thanks for helping
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.4.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 6e998a6c7c9bb42adb529597d2a12a029f26c297
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #47924: DOC: Move whatsnew for indexing regression'
```

4. Push to a named branch:

```
git push YOURFORK 1.4.x:auto-backport-of-pr-47924-on-1.4.x
```

5. Create a PR against branch 1.4.x, I would have named this PR:

> "Backport PR #47924 on branch 1.4.x (DOC: Move whatsnew for indexing regression)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
Don't have to backport this
Manual Backport PR #47905 on branch 1.4.x (BUG: Fix read_xml raising syntax error when reading XML with Chinese tags)
State: closed

Manual Backport PR #47905
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/v1.4.4.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
@mroeschke - First time backporting. Why am I seeing all these hundreds of commits? Your last manual backport starts only with one commit. I followed [meeseeksdev](https://github.com/apps/meeseeksdev) instructions. I closed this thinking I missed something but each re-try is same 200+ commits.
Ah, when you make the pull request in the Github UI, you'll need to target the `1.4.x` branch instead of the `main` branch.
DOC: Add pandas-stubs and potential 2.0 API breaks to 1.5 whatsnew
State: closed

- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/v1.5.0.rst` file if fixing a bug or adding a new feature.

* Added note about `pandas-stubs` library
* Added note about potential 2.0 API breaks: https://github.com/pandas-dev/pandas/issues/44823

Labels:
name: Docs

Comments:
> wouldn't be opposed to moving the pandas-stubs note up to the top or just under exchange protocol - I think this deserves visibility.

agreed.
Backport PR #45287 on branch 1.4.x (BUG: frame[x].loc[y] inconsistent with frame.at[x, y]) (#45287)
State: closed

Backport PR #45287, see https://github.com/pandas-dev/pandas/issues/47867#issuecomment-1198412271

Lets see if this works

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
don't worry about the mypy failures. imo it is main that is wrong since we have traditionally always run the typing validation against the latest numpy release, which is what's happening here.
Yep thx
> Lets see if this works

Thanks @phofl merge when ready.
Failure unrelated, see #47945
TYP: pandas.core.generic from pandas-stubs
State: closed

Some annotations from pandas-stubs and some from the underlying io functions.

Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Hello @twoertwein! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:







There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-08-01 12:59:42 UTC
Thanks @twoertwein
Fix stacklevel dayfirst warning
State: closed

- [ ] closes #47907 (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
OK thanks, I've stuck with the original import then

I've made a separate issue about catching this incorrect stacklevel in tests, will address that separately if that's OK https://github.com/pandas-dev/pandas/issues/47919
closing as I'm taking this forwards in #47998
BUG: Fix read_xml raising syntax error when reading XML with Chinese tags
State: closed

- [X] closes #47902 (Replace xxxx with the Github issue number)
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/v1.4.4.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO XML
description: read_xml, to_xml

Comments:
Thanks for the quick fix @ParfaitG 
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.4.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 72da7b24c22eb00b791ffc0370015393788de021
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #47905: BUG: Fix read_xml raising syntax error when reading XML with Chinese tags'
```

4. Push to a named branch:

```
git push YOURFORK 1.4.x:auto-backport-of-pr-47905-on-1.4.x
```

5. Create a PR against branch 1.4.x, I would have named this PR:

> "Backport PR #47905 on branch 1.4.x (BUG: Fix read_xml raising syntax error when reading XML with Chinese tags)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@ParfaitG mind applying the backport PR with the instructions above if you have the time?
@mroeschke it's a bit late in the release cycle for bug fixes. Is this considered low risk? and 1.5 is may be not far anyway.
https://github.com/pandas-dev/pandas/pull/47925#issuecomment-1207597669 mentions I think it's okay pushing to 1.5 instead
ENH: Move warnings to error/__init__.py per GH27656
State: closed

- [x] xref #27656. this GitHub issue is being done in multiple parts
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

I noticed one of the strings didn't have a `Final` so I've added it. 

Besides the tslibs and OptionError errors, I think I've moved all the exceptions/warnings to the __errors.py. Is there anything else I should do?

Labels:
name: Enhancement
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
In a follow up PR, you could maybe add a pre-commit hook to validate that errors are only defined in `pandas/_libs` or `pandas/errors/__init__.py` to close out the issue
> In a follow up PR, you could maybe add a pre-commit hook to validate that errors are only defined in `pandas/_libs` or `pandas/errors/__init__.py` to close out the issue

Gotcha, I'll work on that next
Thanks again @dataxerik!
BUG: preserve _id in MultiIndex.copy(deep=False)
State: closed

- [x] closes #47878 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: MultiIndex

Comments:
> Worth a whatsnew note?

Not really.  Affects perf in corner cases.
Revert "CI: Pin cython on 32bit build"
State: closed

Reverts pandas-dev/pandas#47889

Let's see if cython 0.29.32 fixes this

Labels:
name: Build
description: Library building on various platforms
name: CI
description: Continuous Integration

Comments:
Looks like the conda packages for 0.29.32 might not be uploaded fully yet, so jobs just need to be retrigerred later on in the day.
FWIW `cython=0.29.30` is pinned in all the other `ci/deps/` yaml files except `actions-310-numpydev.yaml` which is supposed to test cython master.

So actually pinning in the 32 bit build makes it consistent with the rest of the builds which would be a good thing.

Or should `cython>=0.29.30` be specified here and the other builds instead?
I don't think we should pin Cython, otherwise we could have some surprising failures when we bump Cython for the new Python version.
Hey @lithomas1 - could you please drop me an email at <NAME><SURNAME> @ protonmail . com ? Or add me on LinkedIn and contact me there
ENH: parse 8 or 9 digit delimited dates
State: closed

- [x] closes #47880 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timestamp
description: pd.Timestamp and associated methods

Comments:
Thanks @MarcoGorelli
CLN: Rename "add" to "sum" in groupby
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

sum is the one method whose name doesn't agree with the corresponding `how`

Labels:
name: Groupby
name: Clean

Comments:
When looking at this it reminded me of Pokemon: 'are you sure you caught them all?'
@attack68 - I think our test coverage is sufficient to feel good I got all the code changes. For comments, I would guess it's possible I missed some. I used `grep -nr --include \*.p* "add"` in both the groupby and the _libs directories and went through the results (and just double checked now).
Thanks @rhshadrach
CI: Pin cython on 32bit build
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).



Labels:
name: CI
description: Continuous Integration
name: 32bit
description: 32-bit systems

Comments:
Merging to get the CI back to green
@mroeschke Can you pin this everywhere? (xref https://github.com/pandas-dev/pandas/pull/47891#pullrequestreview-1054894065). We should probably also report this to Cython.
Looks like someone already reported this. The fix is in https://github.com/cython/cython/pull/4929
REF: Change _NULL_DESCRIPTION[datetime] to use NaT sentinel
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

xref https://github.com/data-apis/dataframe-api/pull/74#discussion_r921464588

cc @vnlitvinov @jorisvandenbossche 


Labels:
name: Interchange
description: Dataframe Interchange Protocol

Comments:
no tests needed updating?
> no tests needed updating?

Looks like there was no existing test so added one
Thanks for the feedback everyone. For the pandas implementation, I changed our sentinel to use the integer representation of `pd.NaT`
REF: PandasColumn.describe_categorical returns categores instead of mapping 
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

xref: https://github.com/data-apis/dataframe-api/pull/69

cc @shwina @vnlitvinov

Labels:
name: Interchange
description: Dataframe Interchange Protocol

Comments:
@vnlitvinov ok?
BUG: fix Dataframe.join with categorical index leads to unexpected reordering
State: closed

- [ ] closes #47812(Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Categorical
description: Categorical Data Type

Comments:
Thanks @xr-chen
DOC: Additions/updates to documentation-GH46359
State: closed

Added examples of DataFrame.mul with dicts.

- [x] closes #46359
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
thanks @BarkotBeyene 
@jreback Sure thanks.
DOC: fix broken link in getting started tutorials
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

This PR fixes a link in the getting started tutorial which previously pointed to a non-existing .ipynb file resulting in 404 error.

Labels:
name: Docs

Comments:
Thanks @rhkarls
DOC: Minor fixes in the IO user guide
State: closed

- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Removes a comment on unsupported ``engine='python'`` (added in #14295) in the io user guide (text now in sync with API reference); Additional minor formatting fixes

Labels:
name: Docs
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
Thanks @SandroCasagrande