add (partial) linting to asvs
State: closed

1) Add linting,
2) fix a bunch of lint warnings, 
3) add ignore/excludes so that it passes for now.

Labels:

Comments:
Just a heads up, #18611 is overhauling `groupyby.py` and passes my local flake8 check.

Also, I'd be much appreciated if you could replace `from .pandas_vb_common import *` with `from .pandas_vb_common import setup # noqa`. The `setup` function will set up the random seed for all the setup functions. 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=h1) Report
> Merging [#18620](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/6e56195fcb021e7c53301722804087ef2a83bc39?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18620/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18620      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47051       -9     
- Misses       4389     4398       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.32% <ø> (ø)` | :arrow_up: |
| #single | `40.6% <ø> (-0.11%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18620/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18620/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.81% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=footer). Last update [6e56195...a302e7f](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=h1) Report
> Merging [#18620](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/6e56195fcb021e7c53301722804087ef2a83bc39?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18620/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18620      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51449    51449              
==========================================
- Hits        47060    47051       -9     
- Misses       4389     4398       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.32% <ø> (ø)` | :arrow_up: |
| #single | `40.6% <ø> (-0.11%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18620/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18620/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.81% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=footer). Last update [6e56195...a302e7f](https://codecov.io/gh/pandas-dev/pandas/pull/18620?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

yeah prefer these be linted / cleaned in smaller batches.
> Also, I'd be much appreciated if you could replace from .pandas_vb_common import * with from .pandas_vb_common import setup # noqa. The setup function will set up the random seed for all the setup functions.

@mroeschke I'll make a note of it for next time around.