BrandonFors/pandas-github-issues huggingface dataset:
TST: skip -> xfail
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).



Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
@mroeschke ive started getting local test failures at collect-time with "ERROR: Unknown config option: asyncio_mode".  commenting out the 'asyncio_mode = "strict"' line in pyproject.toml seems to fix it.  Could this be related to any of the recent CI stuff you've been doing?
> @mroeschke ive started getting local test failures at collect-time with "ERROR: Unknown config option: asyncio_mode". commenting out the 'asyncio_mode = "strict"' line in pyproject.toml seems to fix it. Could this be related to any of the recent CI stuff you've been doing?

Hmm do you have `pytest-asyncio` in your virtual environment?
> Hmm do you have pytest-asyncio in your virtual environment?

Yes.  should i get rid of it?
Hmm odd I've seen the CI complain if it wasn't installed. What are your pytest & plugin versions? Or maybe it's a pytest cache issue?

```
(pandas-dev) ...  % pytest pandas --collect-only
========================================================= test session starts ==========================================================
platform darwin -- Python 3.8.12, pytest-7.0.0, pluggy-1.0.0
rootdir: /Users/... , configfile: pyproject.toml, testpaths: pandas
plugins: xdist-2.5.0, forked-1.4.0, cython-0.1.1.post0, hypothesis-6.36.1, instafail-0.4.1, asyncio-0.18.0, cov-3.0.0
asyncio: mode=strict

...
========================================== 166393 tests collected in 49.85s ===========================================
```
looks like upgrading from 0.14..0 to 0.18.0 fixed it, thanks.  sorry for derailing.
CI: Test Pyarrow Less
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

CI has been really clogged w/ 2-3hr queue times.

Cut down on number of builds by only testing Pyarrow on one python version(if behavior is different based on Python version, that is pyarrow's problem). 

If compat continues to be an issue in the future, I would suggest that pyarrow test a "pandas-dev" build, similar to our numpydev builds. I have added one of these builds to fastparquet in the past, and it seems to be effective as there haven't been any recent issues with new fastparquet versions breaking CI IIRC.

Labels:
name: CI
description: Continuous Integration
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
BUG: Nullable _get_common_dtype match non-nullable behavior
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
nice! i think needs a whatsnew note
mypy complaint is in io.clipboard, unrelated
whatsnew added + greenish
Thanks @jbrockmendel
BUG:error in reading a boolean column with blanks from excel file #45903
State: closed

- [x] closes #45903 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/v1.5.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: IO Excel
description: read_excel, to_excel
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
TST: Fix warnings & skip -> xfail
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
small questions on which ill trust your judgement.  LGTM.
the pytest plugins i cant comment on but the rest LGTM
@meeseeksdev backport 1.4.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.4.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 60cc2f37e8f52fc571da147584b703bb7fd2552e
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #46370: TST: Fix warnings & skip -> xfail'
```

4. Push to a named branch:

```
git push YOURFORK 1.4.x:auto-backport-of-pr-46370-on-1.4.x
```

5. Create a PR against branch 1.4.x, I would have named this PR:

> "Backport PR #46370 on branch 1.4.x (TST: Fix warnings & skip -> xfail)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
BUG: Fix remaining cases of groupby(...).transform with dropna=True
State: closed

- [x] closes #17093 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Groupby
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
Last thought before I go guzzle some caffeine: this looks tangentially related to #43943.  Might be something worth salvaging from that.
Thanks for all the feedback @jbrockmendel and @jreback - ready for another review.
thanks @rhshadrach
Fixed `Period` and `PeriodIndex` formatting
State: closed

- [x] closes #46252
- [x] Improved docstring for `PeriodIndex.strftime` and `Period.strftime`
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Note: this is the first PR extracted from #46116. More to come soon :)

Labels:
name: Output-Formatting
description: __repr__ of pandas objects, to_string
name: Period
description: Period data type

Comments:
The error in CI seems related to usage of `assert_produces_warning`. What is strange is that it worked in #46116 .. were there any change on main related to this that could explain the issue ?
Ready for review @jreback @mroeschke .
Thanks @jbrockmendel and @mroeschke for the review !
I left one comment pending (parametrization) and all others were taken into account
All set (thanks @mroeschke for resolving the last comment).
The last failing mypy check seems unrelated (pandas/io/clipboard/__init__.py:97: error: Module has no attribute "WinError"  [attr-defined])
Could you merge main in one more time just to be sure?
thanks @smarie very nice!
Thank you all for the quick review !
CI: Debug Windows stack overflow
State: closed

```
Thread 0x0000142c (most recent call first):
  File "C:\Miniconda\en.vs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 400 in read
  File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 432 in from_io
  File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 967 in _thread_receiver
  File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 220 in run
  File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 285 in _perform_spawn

Current thread 0x00000520 (most recent call first):
  File "D:\a\1\s\pandas\core\construction.py", line 850 in is_empty_data
  File "D:\a\1\s\pandas\core\construction.py", line 887 in create_series_with_explicit_dtype
  File "D:\a\1\s\pandas\core\series.py", line 515 in _init_dict
  File "D:\a\1\s\pandas\core\series.py", line 422 in __init__
  File "D:\a\1\s\pandas\core\construction.py", line 889 in create_series_with_explicit_dtype
  File "D:\a\1\s\pandas\core\series.py", line 515 in _init_dict
  File "D:\a\1\s\pandas\core\series.py", line 422 in __init__
  File "D:\a\1\s\pandas\core\construction.py", line 889 in create_series_with_explicit_dtype
  File "D:\a\1\s\pandas\core\series.py", line 515 in _init_dict
  File "D:\a\1\s\pandas\core\series.py", line 422 in __init__

```


Labels:
name: CI
description: Continuous Integration

Comments:
@mroeschke LMK if extra eyeballs can be made helpful here
@jbrockmendel thanks that would be helpful. Here's the logs of the crashing build (gw1 is crashing)

https://dev.azure.com/pandas-dev/e01c9671-576d-40f3-a1a1-7bef78604087/_apis/build/builds/75338/logs/45

From what I've deduced, something changed such that recursion in our test suite leads to stack overflows in Windows. Appears there might be another one somewhere in `pandas/tests/extension` but not exactly sure where
@jbrockmendel look okay to you?
not wild about the is_ci_environment part but dont have any better ideas.  LGTM
Thanks @jbrockmendel yeah same. I have no idea why Windows is acting different suddenly but with is_ci_environment hopefully people can still check the test locally.
@meeseeksdev backport 1.4.x
ENH: consistency of input args for boundaries -  pd.interval_range
State: closed

- [x] xref #40245 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Interval
description: Interval data type

Comments:
see the other PRs on that issue for how to do this.
> pandas/core/indexes/interval.py:1152: error: Argument "closed" to "from_breaks" of "IntervalIndex" has incompatible type "Optional[str]"; expected "str"  [arg-type]
Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

























There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-04-03 07:28:29 UTC
thanks @weikhor
PERF: Index[StringArray]
State: closed

- [x] closes #45652 (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

bandaid until we can improve perf in ExtensionEngine

Labels:
name: Performance
description: Memory or execution speed performance

Comments:
for 1.4.2?
> for 1.4.2?

should be harmless
just doing for 1.5
Fix snappy version
State: closed

Fix for https://github.com/pandas-dev/pandas/pull/46260

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration

Comments:
Should we also add `python-snappy` to one of the CI envs?
> Should we also add `python-snappy` to one of the CI envs?

Yes should be added to:

actions-38.yaml
actions-38-downstream_compat.yaml
actions-38-minimum_versions.yaml  (pick latest as a pin)
actions-39.yaml
actions-310.yaml


And noted in `install.rst` (under compression section)
thanks @jonashaag
Refactor CI code
State: closed

I know this is a lot of changes. Happy to split into multiple PRs if it is too much to review.

Side effect of the changes is that most jobs are ~ 10 minutes faster.

- Drop Azure (move to GHA).
- Use mamba-org/provision-with-micromamba to set up Conda envs.
- Cache Conda envs.
- Use hendrikmuhs/ccache-action to cache C compiliation.
- Add Windows 32 bit build.
- Drop Ubuntu 32 bit build. (Can also bring back, have code for that.)
- Factor out common GHA code into reusable actions.

Labels:
name: CI
description: Continuous Integration

Comments:
@mroeschke would love your feedback here.
+1 to all the changes, but it would be easier to review (and probably safer) if each of these changes could be made in separate PRs
I can make the following PRs; anything else would require more work but I can do it as well if you want me to.

- PR 1
  - Drop Azure (move to GHA).
  - Drop Ubuntu 32 bit build.
  - Factor out common GHA code into reusable actions.
- PR 2: Add Windows 32 bit build.
- PR 3: Use mamba-org/provision-with-micromamba to set up Conda envs.
- PR 4: Cache Conda envs.
- PR 5: Use hendrikmuhs/ccache-action to cache C compiliation. 
Yup those steps would be more digestible to review.
why do we care about windows 32 build?
Acted on this comment. https://github.com/pandas-dev/pandas/issues/44453#issuecomment-974937782
TYP: Add typing for pd.to_timedelta, fix Timedelta operator return types
State: closed

Add typing for pd.to_timedelta
Change operators on `Timedelta` to return `Timedelta` rather than `timedelta`


Labels:
name: Timedelta
description: Timedelta data type
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
thanks @Dr-Irv
Bug fix -  groupby sum removed columns
State: closed

- [x] closes #44132 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Groupby

Comments:
Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-03-14 14:40:29 UTC
I close this since I stuck this for long time. I get simpler task. Thank for review.
PERF: use bisect_right_i8 in vectorized
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Performance
description: Memory or execution speed performance

Comments:
and specific asv improvements?
> and specific asv improvements?

haven't run any.  the improvements for the scalar cases we already did were about 2x
ran some asvs/timeits and this appeared to be a wash, so the main benefit is standardizing code patterns.
ran some asvs/timeits and this appeared to be a wash, so the main benefit is standardizing code patterns.
REF: de-duplicate hard-coded unit code
State: closed

I had hoped  to go further and get rid of one of the dtypes.pyx/pxd classes entirely, but ATM i dont think thats feasible.

Labels:
name: Refactor
description: Internal refactoring of code

Comments:
https://github.com/pandas-dev/pandas/runs/5519720530?check_suite_focus=true
mypy complaint fixed; looks like the remaining CI fails are happening on many prs
Thanks @jbrockmendel
BUG: replace with value also being replaced
State: closed

- [x] closes #46306
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in `doc/source/whatsnew/v1.4.2.rst`


Labels:
name: Bug
name: Regression
description: Functionality that used to work in a prior pandas version
name: replace
description: replace method

Comments:
@jreback - greenish
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
REF/PERF: MultiIndex.get_locs to use boolean arrays internally
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Use boolean arrays internally within `MultiIndex.get_locs` rather than int64 indexes. Logical operations show performance improvements over intersecting int64 indexes. The output remains an integer positional indexer. 

```
       before           after         ratio
     [17dda440]       [94121581]
     <main>           <multiindex-get-locs-bool-arrays>
-        563±10μs          519±8μs     0.92  indexing.MultiIndexing.time_loc_all_scalars(True)
-      33.9±0.6ms       30.4±0.4ms     0.89  indexing.MultiIndexing.time_loc_all_null_slices(True)
-        38.7±1ms         34.5±1ms     0.89  indexing.MultiIndexing.time_loc_all_null_slices(False)
-     1.62±0.02ms      1.43±0.01ms     0.88  indexing.MultiIndexing.time_loc_all_slices(True)
-     6.40±0.06ms       5.53±0.1ms     0.86  indexing.MultiIndexing.time_loc_all_bool_indexers(True)
-         107±1ms       41.6±0.6ms     0.39  indexing.MultiIndexing.time_loc_all_lists(True)
-      34.6±0.8ms       8.24±0.4ms     0.24  indexing.MultiIndexing.time_loc_all_slices(False)
-         236±4ms       23.6±0.2ms     0.10  indexing.MultiIndexing.time_loc_all_lists(False)
-      97.3±0.7ms       9.16±0.4ms     0.09  indexing.MultiIndexing.time_loc_null_slice_plus_slice(False)
-      36.5±0.5ms      1.36±0.03ms     0.04  indexing.MultiIndexing.time_loc_null_slice_plus_slice(True)
```


Labels:
name: Refactor
description: Internal refactoring of code
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Performance
description: Memory or execution speed performance
name: MultiIndex

Comments:
wow. cc @mroeschke @phofl @jbrockmendel if comments.
yep needs a rebase :->
> yep needs a rebase :->

rebased this one
LGTM
can you merge master once again
@jreback - merged main and greenish. I don't think the error is related as I see it showing up in other PRs as well
thanks @lukemanley
CLN/DOC: typos
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Fix various typos


Labels:
name: Docs
name: Clean

Comments:
Thanks @lukemanley
BUG: Index.reindex raising with level and no MultiIndex
State: closed

- [x] closes #35132 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

We have basically three options:

- raising when level is specified without a MultiIndex (would have to deprecate probably, because if self equals target this works currently)
- just ignoring level
- checking if index.name == level when no MultiIndex is given

Labels:
name: MultiIndex

Comments:
this is reasonable
Regression in read csv causing segfault for invalid file input
State: closed

- [x] closes #45957 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: Error Reporting
description: Incorrect or improved errors from pandas
name: IO CSV
description: read_csv, to_csv

Comments:
thanks @phofl 
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.