BrandonFors/pandas-github-issues huggingface dataset:
BUG: pandas.to_datetime() does not respect exact format string with ISO8601
State: closed

- [ ] closes #12649 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

---

EDIT (by MarcoGorelli): this is something @nikitaved, @FDRocha, and I started working on together at a company retreat

Labels:
name: Datetime
description: Datetime data dtype

Comments:
This is vendored from numpy - can you also check if there's something like this upstream? If not may be worth doing there as well
Thanks @WillAyd for your review, I've learned a few new things!

I wasn't sure how to pass a character (like `ymd_sep`) to `strncmp`, so I did `const char tmp[1] = {ymd_sep}`, is that alright?
Just a merge conflict otherwise very nice!
Thanks Will and Matthew for your reviews/approvals!

Let's ship this then, and thanks @nikitaved and @fdrocha for the collaboration
Thank you very much, @MarcoGorelli, @fdrocha , @WillAyd , @mroeschke , for this amazing experience! I would really love to contribute more :)
BUG: excel read from file
State: closed

- [x] closes #48946 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `io/excel/_base.py` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the pull request, but it appears the issue is already closed without need for any changes.

Closing, but happy to have contributions to any issues not taken by other users and labeled `good first issue`: https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
ENH: anti joins
State: closed

- [x] closes #42916  (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.



Labels:
name: Enhancement
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Stale

Comments:
Thanks @WillAyd for the review. 
I think I have addressed most of the changes, let me know how this look.

xrefing a PR for the same bug I did sometime back https://github.com/pandas-dev/pandas/pull/43056. This PR is branched from the old one.
I had done something similar previously. 
But for `dtypes` native to pandas those doesn't work / requires special handling.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: Updates to documentation for Series functions
State: closed

- [ ] closes #15580
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

I wanted to update some functions that are missing documentation in Series, and ended up updating `Series.shape`, `Series.size`, `Series.dtype`, `Series.dtypes`, and `Series.hasnans`.

I might have done too much in one PR, so I hope this is okay!

Labels:
name: Docs
name: Stale

Comments:
Admittedly, I forgot to run pre-commit, so I ran it after. However, since I use conda, it now returns a strange issue when I try to commit. Here's the log from the pre-commit.
![image](https://user-images.githubusercontent.com/61007845/198009309-170b8192-8dc4-48bf-a192-8de37191f9b6.png)

I downgraded `virtualenv` in conda, but it still doesn't seem to work...

Were you able to create you contribution environment according to: https://pandas.pydata.org/pandas-docs/stable/development/contributing.html and then run `pre-commit install`?
> Were you able to create you contribution environment according to: https://pandas.pydata.org/pandas-docs/stable/development/contributing.html and then run `pre-commit install`?

Aah, so I was missing that. My apologies! Let me try making my contribution environment and then I'll try running pre-commit install again.

My pre-commit turned out fine, but I'm not sure about these other checks. Is there any way I can pass them?
Looks like another docstring needs to be aligned with the changes you made

```
     def test_hasnans_uncached_for_series():
        # GH#19700
        idx = Index([0, 1])
        assert idx.hasnans is False
        assert "hasnans" in idx._cache
        ser = idx.to_series()
        assert ser.hasnans is False
        assert not hasattr(ser, "_cache")
        ser.iloc[-1] = np.nan
        assert ser.hasnans is True
>       assert Series.hasnans.__doc__ == Index.hasnans.__doc__
E       AssertionError: assert '\n        Re...rue\n        ' == '\n        Re...ps.\n        '
E         Skipping 81 identical leading characters in diff, use -v to show
E           speedups.
E         + 
E         +         Returns
E         +         --------
E         +         bool
E         +             Whether the Series contains a NaN....
E         
E         ...Full output truncated (8 lines hidden), use '-vv' to show
```
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DEPR: SparseArray.astype
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Astype

Comments:
Thanks @jbrockmendel
DEPR: remove inplace arg in Categorical methods
State: closed

- [x] closes #37643
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.0.0.rst` file if fixing a bug or adding a new feature.

I combined these into a single PR given they're all roughly the same deprecation of removing the `inplace` arg from Categorical methods. This can be split into smaller PRs if preferred. 

Deprecations introduced in: #37981, #41118, #41133, #47834
 




Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
thanks @lukemanley 
shoot, looks like the whatsnew for 2.0.0 got lost somewhere.  can you do a follow-up to re-push that?  and make sure to update #30228
DEPR: stop inferring dt64/td64 from strings in Series construtor
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks @jbrockmendel
BUG: Consistent result ordering for groupbys with categorical groupings
State: closed

- [x] closes #49223  
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/v2.0.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Groupby
name: Categorical
description: Categorical Data Type

Comments:
Replaced by #49373
DEPR: Remove SparseDataFrame/Series pickle compat
State: closed

Follow up to https://github.com/pandas-dev/pandas/pull/49218

Also some pickles generated with 0.20.3 contained these objects, so thought to remove since the pandas version is very old


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
> no whatsnew needed?

Thanks. Noted in the whatsnew removal of SparseFrame/Series that pickle support was also removed.
@mroeschke this caused a regression, was there a decision to stop support 0.20? If so I can update the documentation, which says we do support 0.20 pickle files.
I think it would be great if backwards compatibility could be maintained. I don't think it's sufficient to just update the documentation now, because promises of backwards compatibility (as `pd.read_pickle()` has) can't be un-promised in the same way that other aspects of the API can be updated, especially without a deprecation warning first. If this were a major version change (e.g. `pandas 2.x → 3.x`) it would be more understandable, but as it is, this seems like a major inconvenience to some users (disclosure: including me 🙂).
DEPR: DataFrame dtype keyword match Series behavior
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
LGTM. Just a merge conflict
rebased + greenish (the failure is an unrelated file leak)
Thanks @jbrockmendel
Removed unnecessary depends arguments in setup.py
State: closed

The point of a dependency in build systems is to declare that target X needs to be built before target Y. We use the depends keyword a lot, but list source files as the dependency. This is best case a no-op as we don't build source files, in the worst case these add complexity to the current and future build systems


Labels:
name: Build
description: Library building on various platforms

Comments:
@lithomas1 
@WillAyd can you re-push to get circleci to run
@lithomas1 thoughts here?  you've been doing a lot of build-related work lately
Does modifying a header still trigger a rebuild?
Ah that's a good point @lithomas1 and something I overlooked. We can just table this for now - hopefully the meson stuff won't be too far off anyway
DEPR: disallow subclass-specific keywords in Index.__new__
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks @jbrockmendel
Backport PR #48890 on branch 1.5.x (ERR: Improve error message when assigning a complete row using 'at' m…)
State: closed

Backport PR #48890: ERR: Improve error message when assigning a complete row using 'at' m…

Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
cc @ambujpawar This fails on the backport. Could you check?


Edit: Sorry forget it, this is a more general issue
Hi, just glanced through the error messages. The error doesnt seem to be in running this command:
`xvfb-run pytest -r fEs -n auto --dist=loadfile -s --cov=pandas --cov-report=xml --cov-append pandas -m "not slow and not network and not single_cpu"`

And the error message seems to be: 
`INTERNALERROR> ModuleNotFoundError: No module named 'py.log'; 'py' is not a package
`

I have not seen this before(and doesnt seem much related to the #48890 ), maybe you guys might have seen it before and have some tips on how to solve it?

Otherwise, I will just look more into it during the evening :)
DOC: Added pre-commit link inside the guideline for developers.
State: closed

- [x] closes #48941

Updated the contributor guidelines doc to include the redirection url for pre-commit. 
Help developers to setup the environment.




Labels:
name: Docs

Comments:
I think rather than creating a new section the idea is to link to the already-existing section on pre-commit in contributing_codebase.rst - can you give that a look? @Dr-Irv @MarcoGorelli 
> I think rather than creating a new section the idea is to link to the already-existing section on pre-commit in contributing_codebase.rst - can you give that a look? @Dr-Irv @MarcoGorelli

Yes, I agree.  Just create a link (and make sure you use the short form link, not the http) with text that says "Be sure to also install the pre-commit hooks", where the phrase "pre-commit hooks" links to that section of the docs.

@Dr-Irv , I have updated the text as per your instructions. Thanks.
@Dr-Irv . I have made the respective changes.
I understand it now. There are two kinds of links in the file, one with http and the other short form link with ref format. Although both work the same way, the short form link redirects in an offline manner.

 Did I understand it correctly ?
> Thanks for your PR
> 
> Not keen on this location as it's only visible to anyone reading "option 1b"
> 
> I'd suggest placing it right after the first paragraph, just after
> 
> ```
> but if you skip creating the development environment you won't be able to build the documentation locally before pushing your changes.
> ```
> 
> I also agree on changing `be sure to`, e.g. to `it's recommended to`

Thanks for your help !. Applied the changes,
DEPR: store SparseArray directly in Index
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks @jbrockmendel
BUG: Fix .loc/.iloc/.at/iat cast unexpectedly with object dtype
State: closed

- [ ] closes #48933 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Thanks for reopening, I have merged in the main branch. Any suggestions for this pull request?
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
STYLE: fix pylint consider-iterating-dictionary warnings
State: closed

Related to https://github.com/pandas-dev/pandas/issues/48855
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

The `consider-iterating-dictionary` is also removed from the ignored warnings in `pyproject.toml`.


Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
Thanks again @Moisan!
DEPR: non-keyword arguments
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks @jbrockmendel
DEPR: inplace arg in Categorical.remove_unused_categories
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.0.0.rst` file if fixing a bug or adding a new feature.

deprecation introduced in #37918

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks @lukemanley
API: Series.astype(td64_unsupported) raise
State: closed

- [x] closes #48979 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

.astype analogue to #49285.

cc @jreback @mroeschke

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Astype
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
Thanks @jbrockmendel
API: raise on unsupported dtype instead of silently swapping
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Looks like ATM the DataFrame case raises bc it goes through a different path, while the Series case does not.

mentioned in (but this does not close) #48979

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
@jreback little help with the docbuild?  (also thoughts on the API change?)
@jreback still struggling with the docbuild
Thanks @jbrockmendel 
sweet!  the only big constructor-behavior-matching one left is #49348