Updated code_checks.sh with PR06
State: closed

- [ ✔] closes #28724
- [ ] tests added / passed
- [✔ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
> you just need to add PR06, no need to remove any other codes / add blank lines

Actually the PR was having merge conflicts so I resolved one, maybe during this process it might have add any kind of space.
> Why did you remove GL02?

Yeah, I really don't know how did that happen. I will fix this asap.
> Looks like there's at least a couple of PR06 errors which still need fixing up
> 
> ```
> Error: /home/runner/work/pandas/pandas/pandas/core/tools/numeric.py:27:PR06:pandas.to_numeric:Parameter "downcast" type should use "int" instead of "integer"
> Error: /home/runner/work/pandas/pandas/pandas/core/arrays/sparse/array.py:248:PR06:pandas.arrays.SparseArray:Parameter "kind" type should use "int" instead of "integer"
> ```

<img width="419" alt="kind" src="https://user-images.githubusercontent.com/75975268/133045448-de435838-19e4-4fab-a7b0-7d015e952d37.png">
Here should I change integer to int in both the list and default as well?
> Here should I change integer to int in both the list and default as well?

For the sparse case, "integer" means something different than "int" (is referring to the type of index to construct, not a datatype), so I don't think it should change. Maybe this is a false positive?
hmm, yeah, this might be a bug in numpydoc..I'll get back to this, might be worth checking if it also happens with the latest release
<img width="474" alt="downcast" src="https://user-images.githubusercontent.com/75975268/133206895-af28842a-e1c6-40ac-86c6-6b4b4228fa86.png">
Similar thing with downcast parameter, What should I do here @mzeitlin11 ?
> Similar thing with downcast parameter, What should I do here @mzeitlin11 ?

You could look into what @MarcoGorelli was saying above - whether this is an issue with `numpydoc` that has been fixed in a later release, or if there is some other way to work around it.

> hmm, yeah, this might be a bug in numpydoc..I'll get back to this, might be worth checking if it also happens with the latest release

Till then Can I work on issue#21749
yes, of course!
> yes, of course!

Please do assign it to me as the bot is not responding to the "take" command.
multiple people can work on that issue, there's no need to be assigned
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
@MarcoGorelli This issue has been labeled stale due to inactivity. I was just wondering if there's anything that I have to do or you are handling it from your side.
Thanks @Varun270 - I haven't had a chance to look at this yet, I'll have a look at whether it needs reporting to NumpyDoc
I reported this to NumpyDoc in https://github.com/numpy/numpydoc/issues/341 

Perhaps we can just work around it with something like
```
kind : str
    Can be 'integer' or 'block', default is 'integer'.
```
until/if it's fixed upstream
> I reported this to NumpyDoc in [numpy/numpydoc#341](https://github.com/numpy/numpydoc/issues/341)
> 
> Perhaps we can just work around it with something like
> 
> ```
> kind : str
>     Can be 'integer' or 'block', default is 'integer'.
> ```
> 
> until/if it's fixed upstream



> I reported this to NumpyDoc in [numpy/numpydoc#341](https://github.com/numpy/numpydoc/issues/341)
> 
> Perhaps we can just work around it with something like
> 
> ```
> kind : str
>     Can be 'integer' or 'block', default is 'integer'.
> ```
> 
> until/if it's fixed upstream

So should I create a PR to add the changes that you suggested?
you can update this one
> you can update this one

alright will do it
@MarcoGorelli I pushed the changes can you tell me what's wrong?
thanks @Varun270 
looks like this wasn't green
```
Error: /home/runner/work/pandas/pandas/pandas/core/frame.py:1104:PR06:pandas.DataFrame.to_string:Parameter "header" type should use "str" instead of "string"
```