cut/paste _Timestamp+Timestamp to tslibs.timestamps
State: closed

Then remove unused imports in tslibs.

If/when this is merged, it'll be official: we've taken tslib from a 5500 line beast down to ~1k.

Labels:
name: Datetime
description: Datetime data dtype
name: Clean

Comments:
> If/when this is merged, it'll be official: we've taken tslib from a 5500 line beast down to ~1k.

sure but still some things things to move to the subs :> (I know already on your TODO).

in the end of the day tslibx.pyx could/should just be imports :>

maybe even not that!
lgtm. ping on green.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=h1) Report
> Merging [#18369](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/a172ff9dd32d7f6ba077c82b6cf6a31dcc7f2b45?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18369/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18369      +/-   ##
==========================================
- Coverage   91.38%   91.34%   -0.05%     
==========================================
  Files         164      164              
  Lines       49797    49799       +2     
==========================================
- Hits        45508    45487      -21     
- Misses       4289     4312      +23
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.14% <ø> (-0.03%)` | :arrow_down: |
| #single | `39.55% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `63.44% <0%> (-1.82%)` | :arrow_down: |
| [pandas/core/indexes/interval.py](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9pbnRlcnZhbC5weQ==) | `92.52% <0%> (-0.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.8% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=footer). Last update [a172ff9...414fa43](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=h1) Report
> Merging [#18369](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1647a724ae5c9038cdd3cf4ebbf2273d1b6ab109?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18369/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18369      +/-   ##
==========================================
- Coverage   91.36%   91.34%   -0.02%     
==========================================
  Files         164      164              
  Lines       49718    49718              
==========================================
- Hits        45426    45417       -9     
- Misses       4292     4301       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.14% <ø> (ø)` | :arrow_up: |
| #single | `39.61% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.8% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=footer). Last update [1647a72...c00d36b](https://codecov.io/gh/pandas-dev/pandas/pull/18369?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Ping
rebase
ping
thanks!