BrandonFors/pandas-github-issues huggingface dataset:
Backport PR #25171 on branch 0.24.x
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: IO JSON
description: read_json, to_json, json_normalize

Comments:
why did u push this? backports are done automatically
ic you followed the manual back port instructions, ok.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25248?src=pr&el=h1) Report
> Merging [#25248](https://codecov.io/gh/pandas-dev/pandas/pull/25248?src=pr&el=desc) into [0.24.x](https://codecov.io/gh/pandas-dev/pandas/commit/b134253f7a5e4cf310682444152a660c88410f52?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25248/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25248?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           0.24.x   #25248      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +<.01%     
==========================================
  Files         166      166              
  Lines       52404    52405       +1     
==========================================
+ Hits        48410    48411       +1     
  Misses       3994     3994
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.8% <100%> (ø)` | :arrow_up: |
| #single | `42.88% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/25248?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/json/table\_schema.py](https://codecov.io/gh/pandas-dev/pandas/pull/25248/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2pzb24vdGFibGVfc2NoZW1hLnB5) | `98.3% <100%> (+0.01%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25248?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25248?src=pr&el=footer). Last update [b134253...748819c](https://codecov.io/gh/pandas-dev/pandas/pull/25248?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jreback yes, I was asked to backport manually. All checks have passed.
thanks @albertvillanova
fix MacPython pandas-wheels failure
State: closed

xref https://github.com/pandas-dev/pandas/pull/25175#discussion_r254256331

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
unrelated ci failure

```
Unable to download 3.5 archive. The archive may not exist. Please consider a different version.
```
thanks @simonjayhawkins
BUG: Rewrite _make_concat_multiindex
State: closed

- [x] closes #20565
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: MultiIndex

Comments:
Hello @toobaz! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on February 03, 2019 at 15:53 Hours UTC
closing as stale
DOC: Example from docstring was proposing wrong interpolation order
State: closed

Currently doctring explaining interpolation proposes using polynomial interpolation with order equal to 4. Unfortunately, scipy does not allow that value to be used, throwing an ValueError from here: https://github.com/scipy/scipy/blob/5875fd397eb4e6adcfa0c65f7b9006424c066cb0/scipy/interpolate/_bsplines.py#L583
Looking at the blame, last edit was 5 years ago so that rather do not depend on any reasonable scipy version.

Interpolations with order equal to 2 that are spread around docstrings (and doctests) do not pass through the method throwing that exception so they are okay.

- [-] closes #xxxx
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [-] whatsnew entry


Labels:
name: Docs
name: Dependencies
description: Required and optional dependencies

Comments:
sure
DOC: Start 0.24.2.rst
State: closed

[ci skip]


Labels:
name: Docs

Comments:
Thoughts on how we should handle tagging / backporting these? I made a 0.24.2 milestone that will backport, but I don't think we should actually use that until 0.24.1 is released (since we don't want 0.24.2 changes on 0.24.x until 0.24.1 is released).

This documentation change is an exception, since it doesn't affect the output, and we do want this back ported.
I would simply wait with merging such PRs until the 0.24.1 release is out? (or, even just wait with merging the backport PRs, meeseeksdev can already create them in principle)
Yes, either of those should work.

On Wed, Jan 30, 2019 at 10:06 AM Joris Van den Bossche <
notifications@github.com> wrote:

> I would simply wait with merging such PRs until the 0.24.1 release is out?
> (or, even just wait with merging the backport PRs, meeseeksdev can already
> create them in principle)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/25026#issuecomment-459001624>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIpnbC4AoGjAMSv5oFkarZ7s2F_FHks5vIcMhgaJpZM4aaTDU>
> .
>

This one can already be merged right? (it's only other PRs targeted to 0.24.2 that need to wait)
Yes.
DEPS: Bump pyarrow min version to 0.9.0
State: closed

xref: 

* https://github.com/pandas-dev/pandas/issues/24617#issuecomment-451702104
* https://github.com/pandas-dev/pandas/issues/24767#issuecomment-455468954
* https://github.com/pandas-dev/pandas/issues/24617#issuecomment-451774147

Closes #24767.

Labels:
name: Docs
name: IO Data
description: IO issues that don't fit into a more specific label
name: Dependencies
description: Required and optional dependencies
name: Segfault
description: Non-Recoverable Error

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24854?src=pr&el=h1) Report
> Merging [#24854](https://codecov.io/gh/pandas-dev/pandas/pull/24854?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/01e7872b018f8ceb1c5d1217caf03d5ba4da3602?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `66.66%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/24854/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/24854?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #24854      +/-   ##
==========================================
- Coverage   92.39%   92.39%   -0.01%     
==========================================
  Files         166      166              
  Lines       52391    52391              
==========================================
- Hits        48407    48406       -1     
- Misses       3984     3985       +1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.81% <33.33%> (ø)` | :arrow_up: |
| #single | `42.9% <33.33%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/24854?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/parquet.py](https://codecov.io/gh/pandas-dev/pandas/pull/24854/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnF1ZXQucHk=) | `84.61% <100%> (ø)` | :arrow_up: |
| [pandas/io/feather\_format.py](https://codecov.io/gh/pandas-dev/pandas/pull/24854/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2ZlYXRoZXJfZm9ybWF0LnB5) | `89.74% <50%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/24854/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `88.04% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24854?src=pr&el=footer). Last update [01e7872...1a725a5](https://codecov.io/gh/pandas-dev/pandas/pull/24854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Given the amount of prior favor of this change, merging.
> you may need to update io.rst slightly as well

I didn't see anything, but if there is, let me know - I'll do a follow-up if necessary.
ERR/TST: Add pytest idiom to dtypes/test_cast.py
State: closed

Also corrects error message in `infer_dtype_from_scalar`.

Labels:
name: Refactor
description: Internal refactoring of code
name: Testing
description: pandas testing functions or related to the test suite
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Clean

Comments:
thanks @gfyoung
BUG: Format mismatch doesn't coerce to NaT
State: closed

- [x] closes #24763 
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
lgtm. @jbrockmendel any issues?
Hmm I worry a bit about users typoing the format string, and ending up with all NaT values. But, I don't suppose there's a way to say that `H%:M%:S%` is necessarily an invalid format string, since we don't require that the year, month, or day be specified...
I wonder, are there two cases? Something like

```
format="Y%:%M:%D
```

the user probably has a typo in the year formatter, but it's hard to say. With something like

```python
format="Y%:H%:M%
```

it's (AFAIK) impossible for that to ever parse anything, since there's no valid format substring. Could we raise or warn in that case?
@TomAugspurger Yeah, always raise format parse error is another option.

Maybe should `OutOfBounds` respect `errors` kw, but `ValueError`  (format parse error) shouldn't (always raise)?
> Maybe should OutOfBounds respect errors kw, but ValueError (format parse error) shouldn't (always raise)?

I haven't looked, but that seems reasonable to me.
I don't think we *need* to differentiate a bad parse error when ``errors='coerce'``, we don't have a mode to handle this. Maybe can address in a future PR, but this lgtm. @TomAugspurger ?
If possible, I'd prefer that an invalid format string raises immediately.
But I'm not really sure if that's possible, and won't have time to look.
This is probably an improvement for the original issue.

On Mon, Jan 21, 2019 at 7:18 AM Jeff Reback <notifications@github.com>
wrote:

> I don't think we *need* to differentiate a bad parse error when
> errors='coerce', we don't have a mode to handle this. Maybe can address
> in a future PR, but this lgtm. @TomAugspurger
> <https://github.com/TomAugspurger> ?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/24815#issuecomment-456071162>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIkcZFrZQ3bssufugj-jijNO8a9P2ks5vFb4wgaJpZM4aFC0i>
> .
>

actually I think this conforms to our errors keyword.
TST/CLN: follow-up to #24750
State: closed

cc @jreback 

`test_where_unsafe_itemsize_fail` changed to `test_where_upcast` in #24750

this follow-on PR merges `test_where_upcast` into `test_where_unsafe_upcast` to avoid duplication.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24810?src=pr&el=h1) Report
> Merging [#24810](https://codecov.io/gh/pandas-dev/pandas/pull/24810?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/17a6bc56e5ab6ad3dab12d3a8b20ed69a5830b6f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/24810/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/24810?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #24810   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52382    52382           
=======================================
  Hits        48395    48395           
  Misses       3987     3987
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.81% <ø> (ø)` | :arrow_up: |
| #single | `42.92% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24810?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24810?src=pr&el=footer). Last update [17a6bc5...f8e5af0](https://codecov.io/gh/pandas-dev/pandas/pull/24810?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
PERF: support parallel calculation of nancorr
State: closed

This is a proposal for using openmp to speedup the nancorr function (used by pd.DataFrame.corr).

If this is something that is useful, it can probably be implemented for other cython algorithms implemented in algos.pyx.

Also, the interface has to be decided on: how to choose whether to use parallelization or not, how many cpus, schedule strategy for the prange, etc.

I am not sure what the implications are for adding openmp to compilation and linkage in terms of portability.

Using 4 cpus I got ~60% speedup on a pd.DataFrame.corr (of size 20000 x 1300).

Labels:
name: Build
description: Library building on various platforms
name: Performance
description: Memory or execution speed performance
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff
name: Needs Discussion
description: Requires discussion from core team before further action

Comments:
Hello @noamher! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on January 16, 2019 at 08:57 Hours UTC
@noamher : Thanks for opening this PR!  While the performance increases sounds appealing from the onset, a couple of points that could improve this proposal:

* Given the degree of personal uncertainty in your own implementation, we generally prefer that you open an issue **PRIOR TO** the PR.  The issue is a better place to iron out those uncertainties before making a concrete proposal to change the code.

* You should run the ASV benchmarks (under the `asv_bench` directory) to provide more concrete evidence that this is indeed a performance speedup.  If the tests don't indicate any performance speedup, trying adding your new benchmark to provide that evidence.
I don't think we're quite ready for this. We need to do some more discussion on when and how we'll use parallelism.
I agree, this is out of scope for now w/o further API discussion. We don't have a generic parallelism story ATM. this would have to be threaded down to the function and have the abilitty to generically turn parallelism on/off at a much higher level for other frameworks.

@noamher if you would open an issue and try to reference a couple of open issues (pls do a search). for discussions.
@noamher the memory view changes are ok, would take a PR on those.
@jreback I'll open a relevant issue and see if I can find other relevant issues.

I'll do the memory view changes.
Include tables module in required libraries
State: closed

Using `to_hdf` method without the tables module installed may results in infinite recursion crash: Fatal Python error: Cannot recover from stack overflow.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: IO HDF5
description: read_hdf, HDFStore
name: Needs Discussion
description: Requires discussion from core team before further action
name: Dependencies
description: Required and optional dependencies

Comments:
huh? this is an optional dependency. 
All right, I understand.
BUG: Switched shapes in ValueError msg in DataFrame construct (#20742)
State: closed


- [x] closes #20742
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:

Comments:
Hello @meiermark! Thanks for submitting the PR.



 - In the file [`pandas/tests/frame/test_constructors.py`](https://github.com/pandas-dev/pandas/blob/e5081fc45106b5c1b826e60bd3945914c422828b/pandas/tests/frame/test_constructors.py), following are the PEP8 issues :

> [Line 398:80](https://github.com/pandas-dev/pandas/blob/e5081fc45106b5c1b826e60bd3945914c422828b/pandas/tests/frame/test_constructors.py#L398): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 398:80](https://github.com/pandas-dev/pandas/blob/e5081fc45106b5c1b826e60bd3945914c422828b/pandas/tests/frame/test_constructors.py#L398): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (87 > 79 characters)
> [Line 398:82](https://github.com/pandas-dev/pandas/blob/e5081fc45106b5c1b826e60bd3945914c422828b/pandas/tests/frame/test_constructors.py#L398): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 403:79](https://github.com/pandas-dev/pandas/blob/e5081fc45106b5c1b826e60bd3945914c422828b/pandas/tests/frame/test_constructors.py#L403): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
> [Line 403:80](https://github.com/pandas-dev/pandas/blob/e5081fc45106b5c1b826e60bd3945914c422828b/pandas/tests/frame/test_constructors.py#L403): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (85 > 79 characters)
> [Line 403:81](https://github.com/pandas-dev/pandas/blob/e5081fc45106b5c1b826e60bd3945914c422828b/pandas/tests/frame/test_constructors.py#L403): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','
BUG: Fix segfault in Categorical.set_categories
State: closed

- [X] closes #24675
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry

---

The fix basically amounts to changing `self._codes` --> `cat._codes` in the code block below:
https://github.com/pandas-dev/pandas/blob/caf462c2a7699daf4b149d49f5aeaff822700113/pandas/core/arrays/categorical.py#L850-L855

Since the new object is being referred to as `cat` instead of `self`, the existing version didn't actually change the `_codes` of the resulting object.  The segfault would occur when try to view the resulting `Categorical`, as you'd have `take_1d` trying to take out of bounds `_codes` here:

https://github.com/pandas-dev/pandas/blob/caf462c2a7699daf4b149d49f5aeaff822700113/pandas/core/arrays/categorical.py#L1297



Labels:
name: Bug
name: Categorical
description: Categorical Data Type
name: Segfault
description: Non-Recoverable Error

Comments:
thanks @jschendel
DOC: Fixes to the whatsnew structure
State: closed

- [X] xref #24499
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Changes in this PR:
- Moving `releases.rst` to `whatsnew/index.rst`, which is more consistent with the new structure of the documentation
- Sorting the `whatsnew/index` from the newest to the oldest (was from newest to oldest for the major version, but inside them, the minor versions were sorted from oldest to newest, except for 0.23).

CC: @TomAugspurger 


Labels:
name: Docs

Comments:
lgtm. @TomAugspurger 
thanks.
STY: use pytest.raises context syntax
State: closed

xref #24332

Labels:
name: Refactor
description: Internal refactoring of code
name: Testing
description: pandas testing functions or related to the test suite
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
@simonjayhawkins : Even though it's just a handful of files, I have to commend the acrobatics you had to do to make this all work. 👍 
@gfyoung 

> @simonjayhawkins : Even though it's just a handful of files, I have to commend the acrobatics you had to do to make this all work

Thanks!

this could be because either the error messages should be more consistent, or maybe it would have been better to put the expected error messages in the parametrization. The 'acrobatics' would then be scoped to just the variations due to platform/interpreter/compiler.
thanks @simonjayhawkins
XLSB support in read_excel()  - #8540
State: closed

XLSB support in read_excel() #8540

Labels:
name: Enhancement
name: IO Excel
description: read_excel, to_excel

Comments:
@subhsaha : Thanks for the PR!  Unfortunately, it seems like your PR has a ton of commits that aren't necessary to your change.  Can you create a new branch off `master` and make your changes there?
@subhsaha I didn't see any changes to `io/excel.py` in the current diff though may be overlooking. I think it would be easier as @gfyoung mentioned if you start from a new branch off of master and submit a new PR, so closing this one
REF/TST: use pytest builtin monkeypatch fixture and remove mock fixture
State: closed

- [n/a ] xref https://github.com/pandas-dev/pandas/pull/24557#issuecomment-451174496
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [n/a ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24624?src=pr&el=h1) Report
> Merging [#24624](https://codecov.io/gh/pandas-dev/pandas/pull/24624?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/cb31b2b0912c99e40b22a26e598e640548ea8f14?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/24624/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/24624?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #24624      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52395    52395              
==========================================
- Hits        48403    48402       -1     
- Misses       3992     3993       +1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.8% <ø> (ø)` | :arrow_up: |
| #single | `43% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/24624?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/24624/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `88% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24624?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24624?src=pr&el=footer). Last update [cb31b2b...9460d52](https://codecov.io/gh/pandas-dev/pandas/pull/24624?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@simonjayhawkins in followup could add a check for ``mock`` in the ``ci/code_checks`` (meaning we should *not* find it)
thanks!