BUG: Fix lxml import in show_versions
State: closed

Fixed lxml import issue

- [x] closes #23934
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Labels:
name: Build
description: Library building on various platforms

Comments:
Hello @nixphix! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/util/_print_versions.py`](https://github.com/nixphix/pandas/blob/bdbac45c6a20c8074349c2d5bab77821c51d14ca/pandas/util/_print_versions.py) !


can you add a test for this? 

somethign like

``subprocess.check_call([sys.executable, "-c", "import pandas; pandas.show_versions()"])``

would be enough
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23949?src=pr&el=h1) Report
> Merging [#23949](https://codecov.io/gh/pandas-dev/pandas/pull/23949?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2712c8ff8d46b49868ec8704fb915cfbd9cf5c7a?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23949/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23949?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23949      +/-   ##
==========================================
+ Coverage   92.31%   92.31%   +<.01%     
==========================================
  Files         161      161              
  Lines       51473    51513      +40     
==========================================
+ Hits        47517    47554      +37     
- Misses       3956     3959       +3
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.71% <ø> (ø)` | :arrow_up: |
| #single | `42.42% <ø> (-0.02%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23949?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/\_print\_versions.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX3ByaW50X3ZlcnNpb25zLnB5) | `15.71% <ø> (ø)` | :arrow_up: |
| [pandas/core/arrays/timedeltas.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL3RpbWVkZWx0YXMucHk=) | `96.25% <0%> (-0.19%)` | :arrow_down: |
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `96.84% <0%> (-0.14%)` | :arrow_down: |
| [pandas/core/groupby/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS9vcHMucHk=) | `96.75% <0%> (-0.05%)` | :arrow_down: |
| [pandas/core/indexes/interval.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9pbnRlcnZhbC5weQ==) | `94.69% <0%> (ø)` | :arrow_up: |
| [pandas/core/indexes/multi.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9tdWx0aS5weQ==) | `95.49% <0%> (ø)` | :arrow_up: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.02% <0%> (ø)` | :arrow_up: |
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `96.84% <0%> (ø)` | :arrow_up: |
| [pandas/core/indexes/period.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9wZXJpb2QucHk=) | `93.07% <0%> (ø)` | :arrow_up: |
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.48% <0%> (ø)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/pandas-dev/pandas/pull/23949/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23949?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23949?src=pr&el=footer). Last update [2712c8f...0f9bae9](https://codecov.io/gh/pandas-dev/pandas/pull/23949?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jreback Added test case
hmm then why didn’t our build fail?
Possibly we didn't have an environment with lxml but not openpyxl.

On Wed, Nov 28, 2018 at 12:14 PM Jeff Reback <notifications@github.com>
wrote:

> hmm then why didn’t our build fail?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/23949#issuecomment-442549316>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIrsdFKOtG5nQjQvMduBoAw_wJfTEks5uztJqgaJpZM4Y2AZF>
> .
>

Thanks @nixphix!