[CLN] cy cleanup, de-duplication
State: closed

Small cleanups, remove some unnecessary casting, add typing in timezones.

Labels:
name: Datetime
description: Datetime data dtype
name: Clean

Comments:
looks fine. may want to run a perf check as touching some sensitive paths.
Traveling today, will run asv when home.  It should be a clear but very
small improvement.

On Mon, Jul 9, 2018 at 7:52 AM Jeff Reback <notifications@github.com> wrote:

> looks fine. may want to run a perf check as touching some sensitive paths.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/21826#issuecomment-403467994>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AHtGeKQPUh8dHkqNsKzOa0T71CV1h4AIks5uE1IPgaJpZM4VHkva>
> .
>

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21826?src=pr&el=h1) Report
> Merging [#21826](https://codecov.io/gh/pandas-dev/pandas/pull/21826?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/5380fcd4485498ea54210cf9e26fc5000a3d8555?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21826/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21826?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21826   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         160      160           
  Lines       49892    49892           
=======================================
  Hits        45852    45852           
  Misses       4040     4040
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.28% <ø> (ø)` | :arrow_up: |
| #single | `42.1% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21826?src=pr&el=footer). Last update [5380fcd...13c4e8a](https://codecov.io/gh/pandas-dev/pandas/pull/21826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

asv is raising git-related errors for me on both linux and mac.  Is anyone else getting these?
<b>update</b> caused by me messing up the cloning, never mind.
Results are probably meaningless, but at least they're all good-meaningless.

```
asv continuous -E virtualenv -f 1.1 master HEAD -b timeseries
[...]
    before     after       ratio
  [da6e26db] [13c4e8a0]
-    8.39ms     7.61ms      0.91  timeseries.ToDatetimeISO8601.time_iso8601_nosep
-    2.36ms     2.11ms      0.89  timeseries.ResampleSeries.time_resample('datetime', '1D', 'ohlc')
-    6.98μs     6.21μs      0.89  timeseries.DatetimeIndex.time_get('tz_aware')
-    5.91μs     5.01μs      0.85  timeseries.DatetimeIndex.time_get('tz_naive')
```
thanks !