BUG: TypeError when doing equality comparison with Extension Dtype
State: closed

- #43038 closes #xxxx
- 1 tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Hello @fotino21! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

* In the file [`pandas/tests/dtypes/test_common.py`](https://github.com/pandas-dev/pandas/blob/6e9d9f13c5b7870db3224edd245240bae3adcfb1/pandas/tests/dtypes/test_common.py):

> [Line 400:89](https://github.com/pandas-dev/pandas/blob/6e9d9f13c5b7870db3224edd245240bae3adcfb1/pandas/tests/dtypes/test_common.py#L400): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (100 > 88 characters)



##### Comment last updated at 2021-12-05 10:54:23 UTC
@fotino21 thanks, tests appear to be failing
> @fotino21 thanks, tests appear to be failing

@jreback i made the change requested here and my last commit passed all the tests

https://github.com/pandas-dev/pandas/pull/44686/commits/ca133127c9aeafca5b86731bb3c6f3bf470e9959
@phofl I made all the changes you requested and my latest commit passed all the tests. Is this pr ready to merge?
@jreback @phofl Is there anything else i need to do before merge?
something when wrong
> 

@jreback I didn't understand 
@fotino21 you are updating a huge amount of code. make sure you are merging in master
> @fotino21 you are updating a huge amount of code. make sure you are merging in master

@jreback My changes are small and they are only in test_common file. What do i need to do for other commits by other people. And sorry for the inconvenience. This is my first contribution to a huge code base. 
@jreback @phofl Do I need to do anything else before merge?
> @jreback @phofl Do I need to do anything else before merge?

yes you need to rebase against upstream master
> > @jreback @phofl Do I need to do anything else before merge?
> 
> yes you need to rebase against upstream master

@jreback I made it following this link: https://timonweb.com/misc/how-to-update-a-forked-repo-from-an-upstream-with-git-rebase-or-merge/
@jreback @phofl Do I need to do anything else before merge?
@fotino21 this has included lots of other changes u need to merge upstream/master
> @fotino21 this has included lots of other changes u need to merge upstream/master



> @fotino21 this has included lots of other changes u need to merge upstream/master

How can i do that? I already based my master branch to upstream/master
can you try
```
git fetch upstream
git rebase -i upstream/master
git push origin HEAD -f
```
?
In the second step, you should get an interactive window, and you can choose which commits to keep / edit
> @MarcoGorelli 

In the second step, I only see this message:

noop
# Rebase bc17343f93..bc17343f93 onto bc17343f93 (1 command)
#
# Commands:
# p, pick <commit> = use commit
# r, reword <commit> = use commit, but edit the commit message
# e, edit <commit> = use commit, but stop for amending
# s, squash <commit> = use commit, but meld into previous commit
# f, fixup [-C | -c] <commit> = like "squash" but keep only the previous
#                    commit's log message, unless -C is used, in which case
#                    keep only this commit's message; -c is same as -C but
#                    opens the editor
# x, exec <command> = run command (the rest of the line) using shell
# b, break = stop here (continue rebase later with 'git rebase --continue')
# d, drop <commit> = remove commit
# l, label <label> = label current HEAD with a name
# t, reset <label> = reset HEAD to a label
# m, merge [-C <commit> | -c <commit>] <label> [# <oneline>]
# .       create a merge commit using the original merge commit's
# .       message (or the oneline, if no original merge commit was
# .       specified); use -c <commit> to reword the commit message
#
# These lines can be re-ordered; they are executed from top to bottom.
#
# If you remove a line here THAT COMMIT WILL BE LOST.
#
# However, if you remove everything, the rebase will be aborted.
#

🤔  to be honest I don't know, I can't even tell how you opened this PR as it doesn't appear to have come from a branch

the other PR (https://github.com/pandas-dev/pandas/pull/44840) does come from a branch, so maybe it's OK to continue there, then I can check it out locally if necessary
closing in favor of #44840 

@fotino21 ideallly we only have a single, original PR as it makes more work for maintaining.