BrandonFors/pandas-github-issues huggingface dataset:
REF: implement TestExtension
State: closed

- [x] closes #54420 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Implements TestExtension and refactors the IntervalArray tests to use it (turning up some problems in those tests along the way).  If we go this route, I'll follow up with incremental PRs to move the other tests files to use this pattern.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks @jbrockmendel
ENH: Implement arrow string option for various I/O methods
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO Data
description: IO issues that don't fit into a more specific label
name: Arrow
description: pyarrow functionality

Comments:
Nice thanks @phofl
ENH: allow opt-in to inferring pyarrow strings
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

This is a simple opt-in for now without warning by default. Can adjust this for 2.2

cc @jbrockmendel

Labels:
name: Strings
description: String extension data type and string data
name: Arrow
description: pyarrow functionality

Comments:
cc @jbrockmendel thoughts about the option name?
> thoughts about the option name?

I think future.infer_string is reasonable 
I’ll add this With the general arrow announcement
Thanks @phofl
REF: move misplaced tests
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks @jbrockmendel
BUG: fix AttributeError raised with pd.concat between a None and timezone-aware Timestamp
State: closed

Take over #53042. I updated the test. It should produce a FutureWarning.

- [x] closes #52093 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Timezones
description: Timezone data dtype
name: Stale

Comments:
I notice something weird in the test for reindex with fill_value below.
https://github.com/pandas-dev/pandas/blob/14a6c9ac6873c8afe519a8b47481a12f2f66c5d2/pandas/tests/frame/methods/test_reindex.py#L139-L148
Though the test passes, the representation seems weird. `print(res)` shows,
```console
   0                                   1
0  1 1969-12-31 16:00:01.681173120-08:00
```
while it should be as `print(expected)`:
```console
   0                         1
0  1 2023-04-10 17:32:00-07:00
```
It seems `DatetimeArray` only works when unit is 'ns'. Could you have a further look? @jbrockmendel 
https://github.com/pandas-dev/pandas/blob/14a6c9ac6873c8afe519a8b47481a12f2f66c5d2/pandas/core/internals/managers.py#L2298-L2302
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Still waiting for requested review, any update needed from my side?
This looks good to me.  can you move the whatsnew note to 2.2
> This looks good to me. can you move the whatsnew note to 2.2

Thanks. I've moved the note.
Thanks @yuanx749
DOC: add missing parameters to offsets classes: Second, Minute, Hour and Day
State: closed

- [ x] partially completes #52431 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Frequency
description: DateOffsets

Comments:
/preview
No preview found for PR #54427. Did the docs build complete?
Thanks @dullibri
Update conftest.py
State: closed

complex numbers now appear to work for GH #23554.

There are no examples as to how to update the whatsnew documentation for conftest.py, so I don't know whether or how to add an entry for this change.

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks @MichaelTiemannOSC
REF: de-duplicate _compare_other
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks @jbrockmendel
REF: de-duplicate test_combine_add
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks @jbrockmendel
REF: de-duplicate test_divmod_series_array
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks @jbrockmendel
REF: de-duplicate test_add_series_with_extension_array
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Looks good just needs a rebase
thx @jbrockmendel
CI: Build sdist again on macOS
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

The race condition still exists :(

Labels:
name: Build
description: Library building on various platforms

Comments:
Darn, should we report this to cibuildwheel?
It's the unreproducible Github bug from the issue with macOS failing a couple weeks back :(.

I'd love to report it, but can't figure out how the archive is getting corrupted, and only on macOS.
Thanks @lithomas1
REF: de-duplicate test_direct_arith_with_ndframe_returns_not_implemented
State: closed

Also extends it to test for Index and all the arithmetic/comparison methods instead of just `__add__`.  Uses a loop inside the test bc im leaning towards trying to slow the expansion of the test suite, but not super-opposed to parametrizing if reviewers have strong opinions.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks @jbrockmendel
Fix #54391: Use memcpy() for unaligned loads
State: closed

- [x] closes #54391
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

@jonashaag 

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: ARM
description: aarch64 architecture

Comments:
@WillAyd I've coalesced all the changes together now
Thanks @SoapGentoo
ENH: Update numpy exceptions imports
State: closed

Due to NumPy's main namespace being changed in https://github.com/numpy/numpy/pull/24316, here I update warning imports.

- [ ] closes #xxxx
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
Thanks @mtsokol
CI: remove test cases which would have globbed pandas.tests
State: closed

This came up here https://github.com/pandas-dev/pandas/pull/54365#issuecomment-1664639342

I've removed the test cases which would've ended up triggering globbing of pandas/tests, this should remove the noise observed in that PR

Labels:
name: CI
description: Continuous Integration

Comments:
Thanks for the quick fix @MarcoGorelli
DEPR: 'A' in favour of 'Y'
State: closed

- [x] closes #54275

xref #54061
deprecated `'A'` in favour of `'Y'`.

* Deprecated `'A'`  in Timedelta units in favour of `'Y'`
* Deprecated alias `'A'`, `'AS'`, `'A-DEC'`, etc. for time series frequencies in favour of `'Y'`, `'YS'`, `'Y-DEC'`, etc.
* Deprecated resolution `'A'`   for Timedelta.resolution_string in favour of `'Y'`

Labels:
name: Frequency
description: DateOffsets
name: Deprecate
description: Functionality to remove in pandas
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
@natmokval this seems to be stale and with many conflicts, are you planning to continue work on this PR or should we close it? I guess it may make sense to start over and try to split it in multiple PRs, to make things manageable.
> @natmokval this seems to be stale and with many conflicts, are you planning to continue work on this PR or should we close it? I guess it may make sense to start over and try to split it in multiple PRs, to make things manageable.

Thank you, @datapythonista
Sorry, I forgot to close this PR. `Deprecation 'A' in favour of 'Y'` is done in my PR #55252. I will close this one.
Fix #54391: Invalid pointer aliasing in SAS7BDAT parser
State: closed

@thesamesam please review.

- [x] closes #54391 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
#54407 supersedes this PR
Closing in favor of https://github.com/pandas-dev/pandas/pull/54407
TYP: Enable pyright's reportInconsistentConstructor
State: closed

reportInconsistentConstructor checks that `__new__` and `__init__` should be consistent (argument names and their types)

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Renaming the arguments (`value` -> `name`) technically changes the runtime behavior (if code calls the renamed argument as a keyword argument - probably not as it is the first argument) @jbrockmendel 
> if code calls the renamed argument as a keyword argument - probably not as it is the first argument

AFAICT none of the affected places are public, so I don't think thats a problem
Thanks @twoertwein
DEPR: Positional arguments in to_sql except name
State: closed

- [X] xref #54229
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO SQL
description: to_sql, read_sql, read_sql_query
name: Deprecate
description: Functionality to remove in pandas

Comments:
@mroeschke pinging on green
@mroeschke pinging on green
Thanks @rmhowe425
CLN/DOC: DataFrame.count remove references to "level"
State: closed

1. Removed mention of `level` in `DataFrame.count` docstring as it has been deprecated and removed.
2. Removed "level" from `frame_methods.Count` benchmark name and the `MultiIndex` since it was only relevant when using `level`.



Labels:
name: Docs
name: Clean

Comments:
Thanks @lukemanley
REF: simplify extension reduction tests
State: closed

- [x] closes #44742 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Will clean up the pyarrow tests usage in a follow-up.

Didn't remove the no-longer-used test classes since downstream projects might be using them.  Are we OK just ripping those out or does that require a deprecation cycle?

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
> Are we OK just ripping those out or does that require a deprecation cycle?

Probably should deprecate them since we advertise users to test with them, but since it's not extremely public maybe we can do a 3.0 change?
> Probably should deprecate them since we advertise users to test with them, but since it's not extremely public maybe we can do a 3.0 change?

Works for me
> Probably should deprecate them since we advertise users to test with them, but since it's not extremely public maybe we can do a 3.0 change?

Just checking: you mean OK to move forward with this PR as is then remove the old classes in 3.0?
> you mean OK to move forward with this PR as is then remove the old classes in 3.0?

Yeah I think deprecating tests is sticky business and probably just worth noting in 3.0 to use a different test class
Thanks @jbrockmendel
REF: de-duplicate check_reduce_frame
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks @jbrockmendel
bug fix 54251
State: closed

- [x] closes #54251 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.1.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
Thanks @taytzehao
DOC: Fixing EX01 - Added example
State: closed

- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

closes https://github.com/pandas-dev/pandas/issues/37875

Labels:
name: Docs

Comments:
Nice looks like that was the last one @DeaMariaLeon 🎉 
Thank you @mroeschke 🥳