BrandonFors/pandas-github-issues huggingface dataset:
BUG: Add ``is_any_real_numeric_dtype`` to solve discrepancy between ```Index.is_numeric()``` and ```is_numeric_dtype()```
State: closed

- [x] closes #51152 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.0.0.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Could you check the failing builds?
thx @ABCPAN-rank
BUG: catch decimal.InvalidOperation exception from dateutil
State: closed

- [X] closes #51084  
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
Thank you!
REF: remove _get_grouper, make Grouper.__init__ less stateful
State: closed

Having a BaseGrouper._get_grouper, BinGrouper._get_grouper, and Grouper._get_grouper that all do different things is making my eye twitch.

L509-513 the case where `isinstance(newgrouper, ops.BaseGrouper)` looks like things might go wrong if we ever get there with `len(newgrouper.groupings) > 1`, but we have no tests that get there and this is too spaghettified for me to be sure.  cc @jreback

Labels:
name: Refactor
description: Internal refactoring of code
name: Groupby

Comments:
Thanks @jbrockmendel
DOC: Additions to month_name & day_name
State: closed

- [x] closes #51138
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

In the issue #51138 I was trying to set a column in my DF for the month and day's names in portuguese, then a good guy told me about the `locale -a` command from terminal to look for the right way to set the `locale` string parameter for my code to work properly.

So I thought I would be nice if the respective docs, [month_name](https://pandas.pydata.org/docs/reference/api/pandas.Series.dt.month_name.html) & [day_name](https://pandas.pydata.org/docs/reference/api/pandas.Series.dt.day_name.html), had these informations for the user to know about.

So I added these infos plus a quick example for each method in the docstrings from `/pandas/core/arrays/datetimes.py`

**PS.:** I just don't know why the `validade_docstrings.py` don't recognize the changes I made in the method's docstring...

<details>
<summary>Output: <code>validate_docstrings.py pandas.Series.dt.month_name</code></summary>

![Screenshot from 2023-02-03 21-02-04](https://user-images.githubusercontent.com/95307858/216732753-d33fcda2-d183-4092-8bf4-bb20101abe64.png)

</details>

<details>
<summary>Output: <code>validate_docstrings.py pandas.Series.dt.day_name</code></summary>

![Screenshot from 2023-02-03 21-00-58](https://user-images.githubusercontent.com/95307858/216732668-6ba0bc13-6002-4f09-b43f-48d9215166a7.png)

</details>

<details>
<summary>Output: <code>pre-commit run --files pandas/core/arrays/datetimes.py</code></summary>

![Screenshot from 2023-02-03 22-11-09](https://user-images.githubusercontent.com/95307858/216737306-d8701a47-8f8b-48b6-9853-69e654d36728.png)

</details>


Labels:
name: Docs

Comments:
The CI is getting a `UNEXPECTED EXCEPTION: Error('unsupported locale setting')` error for my example with `locale='pt_BR.utf8'`. And I don't know exactly why, cause I tried the exact same code on my machine and it worked. Maybe this locale isn't installed on the machine in which does the CI.
You will probably need to add `   # doctest: +SKIP` to the example due to the locale being unavailable 
> You will probably need to add ` # doctest: +SKIP` to the example due to the locale being unavailable

I added it in the same line where the function was called with `locate='pt_BR.utf8` (for both month_name & day_name) and the CI went well.
Thanks @eduardochaves1
DOC: Clean whatsnews
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @phofl
Upgrade pyarrow minimum version to 7.0
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dependencies
description: Required and optional dependencies
name: Arrow
description: pyarrow functionality

Comments:
Was this discussed somewhere?  I'm fine with bumping this pretty aggressively but not sure if we have a policy
Informal policy was support for packages released up to a year ago for 2.0, pyarrow 7 was released 2nd or 3rd of February 2022
+1 here for bumping
Thanks @phofl
REF: avoid passing silently-ignored kwargs to Resampler
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Refactor
description: Internal refactoring of code
name: Resample
description: resample method

Comments:
thx @jbrockmendel
DOC: Add CoW optimizations to whatsnew
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

cc @lithomas1 @jorisvandenbossche 

Let's add them on a pr basis after this is merged

Labels:
name: Docs

Comments:
Thanks @phofl 
FWIW, while this list is getting long (and basically becoming just a list of all pandas methods ;)), I am not sure how useful it is to explicitly list them (it makes this item in the whatsnew section quite long and potentially distracting from the more important content). 

It might be nice if we could just say "A new lazy copy mechanism that defers the copy until the object in question is modified was added to _all relevant_ methods." ? 
(if that would actually be the case ..)
Generally, I agree. But as long as we don't have everything we should reference all methods that already have the optimization somewhere.

Linking to our issue might be confusing, since we will update this after we released 2.0. But open for suggestions, as long as the information is available somewhere
We could add a user guide section (wanted to do this anyway before the final 2.0 release is out) and have all optimised methods there
BUG: interpolate not respecting CoW
State: closed

- [x] closes #51126 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

this is independent of #51144 

Labels:
name: Copy / view semantics

Comments:
merging this, it's the same technique we are using in other methods and I am planning on optimizing this before 2.0 anyway when the other pr is through
REF/API: dont alter Grouper in _get_grouper
State: closed

This doesn't break any tests and I haven't concocted any new cases in which it would matter, but the logic is hard enough to disentangle (xref #51134) that I can't promise it won't

Labels:
name: Refactor
description: Internal refactoring of code
name: Groupby

Comments:
Thanks @jbrockmendel
DOC Correcting EX02 errors 
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Towards https://github.com/pandas-dev/pandas/issues/37875 and https://github.com/pandas-dev/pandas/issues/27977

Labels:
name: Docs

Comments:
Thank you @MarcoGorelli :-)
DEPR: Remove NumericIndex
State: closed

- [x] closes #42717
- [x] closes #51020

This finishes the removal of `NumericIndex` from the code base. Note that this PR builds atop of #51132, so you might want to merge that first.

Everything should be finished now after this PR, e.g. the doc updates  have been merged (#51111) and the doc string has been updated (#51089). I'll have a final look once this is merged, but this should pretty much finish this issue. 

Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Index
description: Related to the Index class or subclasses

Comments:
thx @topper-123 
This removal is the partially the cause of a regression unpickling files from "pandas<2", #53300
This remove action caused a bug `ModuleNotFoundError: No module named 'pandas.core.indexes.numeric` when use `pandas>=2.0.0 `
CLN: Partially revert #29553
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
pandas/core/internals/blocks.py:683: error: Unused "type: ignore" comment
I'll be happy to see this compat code go
Thanks @lithomas1
REF: Resampler.groupby -> _timegrouper
State: closed

GroupBy object is very different from a TimeGrouper object.  Hopefully this will make this code slightly less confusing (xref #51134 this is a PITA)

Labels:
name: Refactor
description: Internal refactoring of code
name: Groupby
name: Resample
description: resample method

Comments:
Thanks @jbrockmendel
CI: Change development python version to 3.10
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Mypy passes locally now. Lets see if ci passes as well.

Labels:
name: CI
description: Continuous Integration
name: Dependencies
description: Required and optional dependencies

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
/preview
Website preview of this PR available at: https://pandas.pydata.org/preview/51133/
cc @mroeschke any idea why it's not including the Series.dt file?
It looks like it's being included in https://pandas.pydata.org/preview/51133/docs/reference/api/pandas.Series.dt.date.html?
I meant https://pandas.pydata.org/docs/reference/api/pandas.Series.dt.html in our current docs. Sphinx raises a warning that the document isn't included in any toctree. the str and cat accessors work
Ah hmm yeah I'm not too sure off the top of my head why it's not included. None of the sphinx versions changed with the bump right?
No they are the same. This is really weird, the inheritance logic is a bit weird for the date accessor, so I think that's the problem. Would you be ok with merging anyway?
I guess it shouldn't necessarily block dropping 3.8, but lets definitely raise an issue about Series.dt being missing from API reference potentially
is the sphinx issue blocking this?
We should address the sphinx stuff but can do as a follow up. Have to get ci green here
I skipped Pypy for now. @lithomas1 any idea how to install PyPy for 3.9?

Otherwise this looks good now, but should merge the unpin matplotlib pr first.
Thx, this should be good now
This would need a whatsnew in 2.1 that 3.8 support has been dropped
Some grepped results where we still mention 3.8

```
./doc/source/getting_started/install.rst:Officially Python 3.8, 3.9, 3.10 and 3.11.
./doc/source/development/contributing_gitpod.rst:We have built a python 3.8 environment and all development dependencies will
```
Thx, completely forgot the docs. Updated
This is getting bigger and bigger (underestimated it when starting to rip out 3.8), would prefer merging and then doing the rest as follow ups
Sounds good to me.
thanks @phofl
DEPR: float/int(Series[single_elemet])
State: closed

- [ ] closes #51101 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
thx @mroeschke
CLN: Use fixture dtype_backend in nullable tests
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @phofl
ENH: Implement arrow support for read_csv with engine=c
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Not really sure if this is the best way forward, but want to see if ci passes everywhere

Labels:
name: IO CSV
description: read_csv, to_csv
name: Arrow
description: pyarrow functionality

Comments:
is there any scenario in which the user might want our cython engine rather than the pyarrow engine?
Yes, the arrow engine basically does not support any keywords. c is way more feature complete
Thanks @phofl
CLN: Put exit_stack inside _query_iterator.
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

This closes up a follow up item from the pull request #49967 .

Labels:
name: IO SQL
description: to_sql, read_sql, read_sql_query
name: Clean

Comments:
Thanks @cdcadman
DOC: remove inplace usage from docstring examples
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Removes the inplace=True usage examples from the docstring examples. 

Labels:
name: Docs

Comments:
Removed 2 additional examples advertising copy=False
is using `copy` discouraged as well? I may have missed that

if so, no objections, lgtm
copy=False will be the new default with CoW. copy=True can be done through ``df.func().copy()``, so we will propose removing the copy argument as well in PDEP7. Copy won't have any use in the future, so should remove the reference I guess.
makes sense, thanks! anything else you wanted to get in here or good to merge?
Nothing I can think of right now, so good to go I think
let's ship it, thanks @phofl !
TYP: suppress pyright's information-level output
State: closed

`pre-commit run --hook-stage manual -av pyright_reportGeneralTypeIssues` is currently very verbose as pyright prints a line for each un-annotated function it skips. This PR removes these information-level messages (still prints warnings and errors).

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Thanks @twoertwein
CI: Pin pyarrow to < 11.0
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

cc @MarcoGorelli 

Labels:
name: CI
description: Continuous Integration

Comments:
I think you'll need to fix the sed too, like was done in https://github.com/pandas-dev/pandas/pull/50055/files
thx, adjusted
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 f3015e39439920d3d00a328714c06b6805f7f32b
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #51120: CI: Pin pyarrow to < 11.0'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-51120-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #51120 on branch 1.5.x (CI: Pin pyarrow to < 11.0)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
no need to backport, it's pinned to <10 on 1.5.x