BrandonFors/pandas-github-issues huggingface dataset:
ENH: Index.infer_objects
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Enhancement
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Index
description: Related to the Index class or subclasses

Comments:
Thanks @jbrockmendel
TST: adding new test for groupby cumsum with named aggregate
State: closed

- [ ] closes #41720 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.


Labels:
name: Groupby
name: Timedelta
description: Timedelta data type
name: Apply
description: Apply, Aggregate, Transform, Map
name: Needs Tests
description: Unit test(s) needed to prevent regressions

Comments:
Thanks @seanjedi!
API: make FloatingArray.astype consistent with IntegerArray/BooleanArray
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays
name: Astype

Comments:
thx @jbrockmendel
DOC: add examples BusinessMonthEnd(0) and SemiMonthEnd(0)
State: closed

This PR is related to PR #49958.
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Updated docs for `BusinessMonthEnd` and `SemiMonthEnd`. Added more examples to highlight “the last day of the month” behavior. Gave examples that use the parameter n equals 0.

Labels:
name: Docs

Comments:
Hi, @MarcoGorelli, I updated docs for `BusinessMonthEnd` and `SemiMonthEnd`. To clarify  “the last day of the month” behavior I added examples with `n=0`. Could you please take a look at my PR?
REF: remove NDFrame._convert
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Refactor
description: Internal refactoring of code

Comments:
Nice! Glad this was wholly similar to `infer_objects()`
BUG: when flooring, ambiguous parameter unnecessarily used (and raising Error)
State: closed

- [x] closes #49565
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
Thanks for approving the PR!!! This is the first time I contribute to an open-source project and it was really fun. I really appreciate your help :)
Thanks @jcaoun
BUG: pd.DateOffset handle milliseconds
State: closed

- [X] closes #49897
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Frequency
description: DateOffsets

Comments:
IMO after this fix, `_determine_offset` needs some rework. The function has been continuously patched over-time and has become unreadable. 

I'm testing some implementations in a separate branch
I made it:
- milliseconds now work in combination with _sub-/above-daily_ args (see tests)
- code is cleaned
- no existing tests are broken

It was tough to maintain compatibility with older tests. If new issues about this or related modules come up, feel free to tag me. 
thanks for working on this, I'll take a look soon

looks like CI didn't run for some reason, could you resolve the merge conflicts and push please? that should restart it
Thanks @markopacak
TST: Add test for isin for filtering with mixed types
State: closed

- [x] closes #20883
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Added tests to check that `.isin` works as expected with different types in the series.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks @ltoniazzi !
DOC: align description of sort argument with implementation
State: closed

If sort is provided to concat, the non-concatenation axis is always sorted, so remove the conditional.

- [x] closes #49646
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Sprints
description: Sprint Pull Requests

Comments:
thx @wence-
ENH: add copy on write for df reorder_levels GH49473
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.

Added copy-on-write to `df.reorder_levels()`.

Progress towards #49473 via [PyData pandas sprint](https://github.com/noatamir/pydata-global-sprints/issues/11).

Changed type hint because following the existing one caused an error.

Labels:
name: Copy / view semantics
name: Sprints
description: Sprint Pull Requests

Comments:
Looks like there is a merge conflict. Could you resolve it?
Hope this resolves it.
I think the issue was that I made two branches from main and submitted two PRs that added to the same file. After the first PR got merged into main, the second caused the conflict.
Yep, thx.
Thx @seljaks
BUG: frame[object].astype(M8[unsupported]) not raising
State: closed

Already has a whatsnew _whatsnew_200.api_breaking.astype_to_unsupported_datetimelike

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
Thanks @jbrockmendel
STYLE double-quote cython strings #21
State: closed

task here is:

add id: double-quote-cython-strings to

https://github.com/pandas-dev/pandas/blob/3d0d197cec32ed5ce30d28b922f329510c03f153/.pre-commit-config.yaml#L29

run pre-commit run double-quote-cython-strings --all-files

git add -u, git commit -m 'double quote cython strings', git push origin HEAD`

Motivation for this comes from https://github.com/pandas-dev/pandas/pull/49866#discussion_r1030853463

pyData 2022 sprint 
https://github.com/noatamir/pydata-global-sprints/issues/21

@jorisvandenbossche, @MarcoGorelli, @WillAyd, @rhshadrach, @phofl @noatamir


Labels:
name: Code Style
description: Code style, linting, code_checks
name: Sprints
description: Sprint Pull Requests

Comments:
Cool! Could you merge main? There seems to be a conflict
> Cool! Could you merge main? There seems to be a conflict

Locally? or here? I got lost 
Locally, and then you can push to this branch
you'll do it locally, and then push - something like
```
git fetch upstream
git merge upstream/main
<fix up merge conflicts>
git add -u
git commit
git push origin HEAD
```
> git fetch upstream
> git merge upstream/main
> fixed conflicts
> git add -u
> git commit

Run the previous commands. After that there is a test that failed
```
double-quote Cython strings.............................................................................Failed
- hook id: double-quote-cython-strings
- exit code: 1
- files were modified by this hook
```
I still tried to push to my origin (maybe I shouldn't have) but then there is a message "Everything up-to-date"
after that, you'll need to stage and commit again:
```
git add -u
git commit -a -m 'your commit message goes here'
```
Yep this means that the code you pulled still had single quotes. pre-commit fixed it, so if you commit again you should be good
> after that, you'll need to stage and commit again:
> 
> ```
> git add -u
> git commit -a -m 'your commit message goes here'
> ```

after fixing merge conflicts, git add and commit has to be done twice?
Only if pre commit fails
`pre-commit` will block your commit if any of the hooks' checks fail, or if they modified your files. here, one of them modified your files. so you'll need to stage (`git add -u`) and commit (`git commit -m 'commit message'`) again
Should I just wait now? :) 
Yep the ci runs around 2 hours. We will merge after everything is green
thanks @DeaMariaLeon ! in before more merge conflicts
Thanks All for your patience :)
TST/DEV: remove geopandas downstream test + remove from environment.yml
State: closed

See https://github.com/pandas-dev/pandas/pull/49994 for context

- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit)


Labels:
name: Dependencies
description: Required and optional dependencies
name: Sprints
description: Sprint Pull Requests

Comments:
thanks @StefanieSenger - can you run the pre-commit checks too please? check the contributing guide for how
Hey @MarcoGorelli, thanks for coming back to me. I had run the pre-commit tests on `environment.yml ` and `pandas/tests/test_downstream.py`, but but unfortunately didn't notice that one of the tests didn't pass:
```
Generate pip dependency from conda......................................................................Failed
- hook id: pip-to-conda
- files were modified by this hook
```
This explains, why geopandas is still listed in requirements-dev.txt and didn't autogenerate from the .yml file, I suppose.
I think I should now investigate why that happened, but I'm a bit lost here, I need to admit. Any advice?
you just need to stage and commit again:
```
git add -u
git commit -m 'your commit message goes here'
```
@StefanieSenger I updated the title of the PR to something more descriptive (the title is used for the resulting commit message)
@MarcoGorelli @jorisvandenbossche Awesome, thanks you much for your support! :)
TYP #37715: Fix mypy errors in accessor.py
State: closed

- [ ] xref #37715 
- [ ] Tests added and passed if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Typing
description: type annotations, mypy/pyright type checking
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: remove okwarning from scale guide
State: closed

- [ ] closes #29960
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Updating an entry in the latest `doc/source/user_guide/scale.rst`


Labels:
name: Docs

Comments:
lgtm. want to move it out of draft status?
thx @seanjedi
Adding to the function docs that groupby.transform() function parameter can be a string
State: closed

Docs change: Adding to the function docs that groupby.transform() function parameter can be a string

- [ ] closes #49961 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @seanjedi 
@WillAyd I feel examples should be added for both, DataFrameGroupBy.transform() and SeriesGroupBy.transform() with strings
API: dont do inference on object-dtype arithmetic results
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Broken off from #49714, which also changes TimedeltaArray inference behavior.  This is exclusively Index/Series/DataFrame.

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
Thanks @jbrockmendel 
Looks like this caused a slowdown. Is this expected?

https://asv-runner.github.io/asv-collection/pandas/#arithmetic.NumericInferOps.time_add?p-dtype=%3Cclass%20'numpy.int8'%3E
best guess is #50306 will address that
Sounds reasonable, thanks for the quick response
DOC: Add example for read_csv with nullable dtype
State: closed

The first issue in the link: https://github.com/noatamir/pyladies-berlin-sprints/issues/4

Labels:
name: Docs
name: IO CSV
description: read_csv, to_csv
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays
name: Sprints
description: Sprint Pull Requests

Comments:
@noatamir, @phofl @mroeschke 
Thanks @Idilismiguzel
DEV: remove geopandas from the environment.yml file
State: closed

- [x] closes #https://github.com/noatamir/pyladies-berlin-sprints/issues/9
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for working on this

@mroeschke you'd said you wanted the environment to enable people to run anything - should this single downstream test be removed?
Hi @StefanieSenger - did you close this by accident? I think it looks right, I just wanted to double-check with Matthew whether we should also remove the downstream test or whether this is fine as-is
@MarcoGorelli I must have, though I didn't realise I did ... I'd like to keep it open. Sorry, was my first ever open source contribution.
Yeah I would be partial to be consistent and remove geopandas everywhere if we also want to remove it from the `environment.yml` for consistency (CI dependency files, unit tests, any ASVs, any doc reference)
@StefanieSenger could you remove it from the environment.yml again? 

Additionally, you can delete the test ``test_geopandas`` in pandas/tests/test_downstream.py to get the ci passing. We can reopen the pr then
Specifically for geopandas, I think we can indeed remove the test as well, and then the concern of not having all optional test dependencies installed is also gone (geopandas runs its CI with pandas main, so that should catch any potential compatibility issue relative fast as well). 

For the more general issue about other dependencies in little usage in environment.yml, I opened https://github.com/pandas-dev/pandas/issues/49998  
(removing geopandas from environment.yml won't actually remove it from the env, because it is also indirectly a dependency of pandas_gbq, another optional dependency only needed for a very few number of tests)
@StefanieSenger if you want to reopen the PR, you will first have to "restore" the branch (there should be a button somewhere in the UI)
Thanks for the instructions and the beginner friendly atmosphere. I will do this some time today.
Add new mamba environment creation command
State: closed

- [X] closes #49959 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
@noatamir @phofl @mroeschke 
I'm from the PyLadies sprint in Berlin.
@meeseeksdev please backport to 1.5.x
fixed up standart library imports part 1 of 2
State: closed

all but the pandas/tests files in this draft PR


Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
@MarcoGorelli I will work on these changes on Tuesday/Wednesday and reach out to you if I need any direction. 
Did you get a chance to look at the issue with pandas/io/clipboard/__init__.py? We discussed it on Wednesday on Slack #newcomers.  Thank you.
closing draft pull request.
TST/CoW: copy-on-write tests for add_prefix and add_suffix
State: closed

[Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature

    All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

This PR is related to https://github.com/pandas-dev/pandas/issues/49473
`add_suffix` and `add_prefix` already had Copy-on-Write implemented, this PR will add test cases that explicitly tests the Copy-on-Write feature.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Copy / view semantics

Comments:
thx @andrewchen1216
Fix dataframe.replace when columns contain pd.na
State: closed

- [x] closes #47480
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature

Labels:

Comments:
Thanks for the pull request but we already have a pull request open working on this issue: https://github.com/pandas-dev/pandas/pull/49805

Since the above PR doesn't appear stale yet, we'll let that user to continue to work on this issue so closing this PR for now. If you're interested in contributing, we recommend tackling issues labeled `good first issue` not assigned to any users  yet
DOC: fix RT02 errors in pd.io.formats.style #49968
State: closed

Simplified return type for several Styler methods in pd.io.formats.style.

- [x] xref #49968
- [ ] tests added and passed
- [x] passes pre-commit code checks
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
I'm happy to add a CI check for RT02, but I'm not sure how to exclude the files that still need doing from #49968.