BrandonFors/pandas-github-issues huggingface dataset:
BLD: Build wheels using numpy 2.0rc1
State: closed

- [ ] closes #55519  (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Build
description: Library building on various platforms

Comments:
Thanks @lithomas1 
@lithomas1 @mroeschke this doesn't look correct to me. I just checked [one CI log](https://github.com/pandas-dev/pandas/actions/runs/8492584989/job/23265753591) and it shows this _after_ the "before build" step (re-installs numpy 1.26.4):
```
     Successfully installed Cython-3.0.9 meson-1.2.1 meson-python-0.13.1 numpy-1.26.4 packaging-24.0 pyproject-metadata-0.7.1 tomli-2.0.1 versioneer-0.29 wheel-0.43.0
    Installing build dependencies: finished with status 'done'
```

This is due to build isolation. The `[build-requires]` section in `pyproject.toml` needs updating instead, it needs something like `"numpy>=2.0.0rc1,<2.3",` (or `<3` if you prefer) EDIT: in release branches, and `"numpy>=2.0.0rc1` in `main`. I recommend copying what SciPy does (except change `2.0.0b1` to `2.0.0rc1` now):
https://github.com/scipy/scipy/blob/2a8c4ca6edceba5daaac60bbd213a84e7c03c361/pyproject.toml#L28-L34
> @lithomas1 @mroeschke this doesn't look correct to me. I just checked [one CI log](https://github.com/pandas-dev/pandas/actions/runs/8492584989/job/23265753591) and it shows this _after_ the "before build" step (re-installs numpy 1.26.4):
> 
> ```
>      Successfully installed Cython-3.0.9 meson-1.2.1 meson-python-0.13.1 numpy-1.26.4 packaging-24.0 pyproject-metadata-0.7.1 tomli-2.0.1 versioneer-0.29 wheel-0.43.0
>     Installing build dependencies: finished with status 'done'
> ```
> 
> This is due to build isolation. The `[build-requires]` section in `pyproject.toml` needs updating instead, it needs something like `"numpy>=2.0.0rc1,<2.3",` (or `<3` if you prefer) EDIT: in release branches, and `"numpy>=2.0.0rc1` in `main`. I recommend copying what SciPy does (except change `2.0.0b1` to `2.0.0rc1` now): https://github.com/scipy/scipy/blob/2a8c4ca6edceba5daaac60bbd213a84e7c03c361/pyproject.toml#L28-L34

Nice catch, thanks!

I was thinking in my head that editable installations would be messed up by the `build-requires`, but that obviously uses ``-no-build-isolation`` 🤦 .

I'll put up another PR fixing this.
ENH: Enable fillna(value=None)
State: closed

- [x] closes #57723 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

The one behavior introduced here I think is important to highlight is using `None` with non-object dtypes. In such a case we treat `None` as the NA value for the given dtype for NumPy float/datetime and pandas' EA dtypes. However for external EAs, by default we try to put `None` in the values and raise if this fails.

For object dtype, we replace any NA value with `None`.

cc @Dr-Irv 

Labels:
name: Enhancement
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
Thanks @rhshadrach
Improve MultiIndex label rename checks
State: closed

- [x] closes #55169 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Labels:
name: Stale

Comments:
@mroeschke - this is ready for your review
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Hi @mroeschke,
The merge conflict was only against the `doc/source/whatsnew/v3.0.0.rst` file which I've fixed.
After the merge, pandas is failing to compile on my dev environment due to what I'm assuming is an unrelated error:
```
[9/71] Compiling C object pandas/_libs/interval.cpython-311-x86_64-linux-gnu.so.p/meson-generated_pandas__libs_interval.pyx.c.o ninja: build stopped: subcommand failed.
```
I'll rebuild my dev environment and update once I can confirm that tests are still passing
ENH: Implement round dunder methods for Timestamp and Timedelta
State: closed

- [x] closes #58071
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
pre-commit.ci autofix
Makes sense, I apologize, I was too hasty to make a PR.
Should I close this and wait until a decision is made?
I would recommend closing this PR until discussion in the issue has resolved
> I don't think `__round__` should be implemented for these objects. Since `round` is only well specified for numeric values, I think it's too opaque to apply for datelike objects.

@mroeschke @MarcoGorelli @rhshadrach 

Hello, I was the one that created the issue.

There is already an implementation of a round method for timedelta 

pd.Timedelta.round('s') works. (https://pandas.pydata.org/docs/reference/api/pandas.Timedelta.round.html)
so round(pd.Timedelta) feel intuitive and just need to be added ?

(I'm going on again because I still use the fix I made here https://github.com/pandas-dev/pandas/issues/58071 on my production server and I would be happy to not have to handle this manually but to see the library handle it).
> so round(pd.Timedelta) feel intuitive and just need to be added ?

As commented above (https://github.com/pandas-dev/pandas/pull/58081#discussion_r1545673887):

> If this just happens to work due to an implementation detail in CPython, then it seems to me to be an abuse of the Python API and could break in the future.

Do you disagree that making `round(pd.Timedelta)` work as it's implemented in this PR is an abuse of the Python API?

Alternatively, if you are wanting the signature to be something like `def __round__(self, n=None):` and have the `n` mean seconds, then I am still of the opinion expressed in https://github.com/pandas-dev/pandas/issues/58071#issuecomment-2028743089 and quite negative on adding this. 
So because round(td, n=5) isn't really clear, you don't want to implement round(td).
I understand your point of view.

I disagree that it's a good enough reason to not do it.
with or without this feature, round(td, n=5) would crash.
by doing this feature, hundreds/thousand of developers throughs ages would feel the library even more intuitive with round(td).
But the philosophical defense is understandable. It feels like the defense of a C++ dev rather than python dev but I understand.

Have a nice day boys and thanks for this library (I use it every day at work and I love it !<3)
DOC: Update Categorical/CategoricalDtype methods' docstring to pass docstring validation
State: closed

- [x] closes #58064 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @Aloqeely
CLN: Remove unnecessary block in apply_str
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Due to #57109, "axis" will not be an argument for groupby ops.

Hat tip to @jbrockmendel for finding this.

Labels:
name: Groupby
name: Clean
name: Apply
description: Apply, Aggregate, Transform, Map

Comments:
Thanks @rhshadrach
DOC: docstring fix for pandas.DataFrame.where method
State: closed

- [x] xref #58065 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @YashpalAhlawat
DOC: whatsnew note for #57553
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

xref #58008

Labels:
name: Docs

Comments:
Thanks @jbrockmendel
DOC: fixed docstrings for pandas.DatetimeIndex.to_period and pandas.DatetimeIndex.to_pydatetime
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Stale

Comments:
Getting ```Error: /home/runner/work/pandas/pandas/pandas/core/accessor.py:112:RT03:pandas.Series.dt.to_period:EXPECTED TO FAIL, BUT NOT FAILING```

It's not failing, so it's fine? I'm not sure what this means.
You'll need to remove the `RT03` check on `Series.dt.to_period` in `code_checks.sh`
> You'll need to remove the `RT03` check on `Series.dt.to_period` in `code_checks.sh`

Thanks!
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DEPR: unsupported dt64/td64 dtypes in pd.array
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @jbrockmendel
DEPR: Index.insert dtype inference
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @jbrockmendel
DEPR: allowing non-standard types in unique, factorize, isin
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @jbrockmendel
BUG: Allow using numpy in `DataFrame.eval` and `DataFrame.query` via @-notation
State: closed

- [x] closes #58041
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] ~~Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.~~ (not applicable)
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: expressions
description: pd.eval, query

Comments:
Can you have a look at the CI errors please, your test might be failing.
Thanks for the review @Aloqeely . I've managed to make all the CIs green. Unfortunately, I've encountered different bug when doing so, filed as #58069 . Which is the reason I had to skip checking for series name in the tests. Strictly speaking this PR and #58069 are unrelated -- one can easily encounter the bug in current `main` even without accepting the PR, as explained in the bug description. That being said I can see how accepting this PR may nudge users to actually encounter the bug a bit more often. Let me know what would you like to do with this PR.
Thanks @domsmrz
DEPR: ignoring empty entries in pd.concat
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @jbrockmendel
DEPR: remove deprecated extension test classes
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @jbrockmendel
BUG: fixed to_numeric loss in precision when converting decimal type to integer
State: closed

- [X] closes #57213
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions. _(Not applicable)_
- [X] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Labels:

Comments:
There were errors in the checks, will be fixing those.
DEPR: passing pandas type to Index.view
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @jbrockmendel
ENH: raise ImportError if pyarrow is not defined when using ArrowDtyp…
State: closed



- [x] closes #57928
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Stale
name: Arrow
description: pyarrow functionality

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
BUG: DataFrame slice selection treated as hashable in Python 3.12 #57500
State: closed

- [X] closes #57500
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions. _(Not applicable)_
- [X] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: MultiIndex

Comments:
My commits are out of order, but I confirmed the unit test behaves correctly by backing out the bug fix and running my unit test on 3.12. As expected, it failed.
Thanks @tehunter
DEPR: replace without passing value
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @jbrockmendel
DEPR: replace method/limit keywords
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @jbrockmendel