BrandonFors/pandas-github-issues huggingface dataset:
TST: move misplaced modulo test
State: closed

Found this while looking at tests for reduction ops.  I'm wondering if we should collect+parametrize those over DataFrame/Series/Index/EA the same way we do for arithmetic.  Thoughts?

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
Hello @jbrockmendel! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/arithmetic/test_numeric.py`](https://github.com/jbrockmendel/pandas/blob/14cb2de443072d19f7a4b3169c6ec039e24df644/pandas/tests/arithmetic/test_numeric.py) !

 - There are no PEP8 issues in the file [`pandas/tests/series/test_analytics.py`](https://github.com/jbrockmendel/pandas/blob/14cb2de443072d19f7a4b3169c6ec039e24df644/pandas/tests/series/test_analytics.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23827?src=pr&el=h1) Report
> Merging [#23827](https://codecov.io/gh/pandas-dev/pandas/pull/23827?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/99df7da9ef5b3b210f3045ee19279808368def28?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23827/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23827?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23827   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51493    51493           
=======================================
  Hits        47524    47524           
  Misses       3969     3969
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.68% <ø> (ø)` | :arrow_up: |
| #single | `42.32% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23827?src=pr&el=footer). Last update [99df7da...14cb2de](https://codecov.io/gh/pandas-dev/pandas/pull/23827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> I'm wondering if we should collect+parametrize those over DataFrame/Series/Index/EA the same way we do for arithmetic. Thoughts?

That seems like a reasonable proposal.
lgtm. ex @jorisvandenbossche comment (though certainly fine to do this later).
BUG: fixed plotting of boolean dataframes
State: closed

Boolean data was not recognised as plottable data. Adding it to the list of valid dtypes fixed this and allows plotting.

- [x] closes #23719
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Bug
name: Visualization
description: plotting

Comments:
Hello @BSchilperoort! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/plotting/_core.py`](https://github.com/BSchilperoort/pandas/blob/e0888a90144758583b3bc2a92ed9ffb18508338a/pandas/plotting/_core.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23813?src=pr&el=h1) Report
> Merging [#23813](https://codecov.io/gh/pandas-dev/pandas/pull/23813?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/df5eeece8ed28462832ee6e762192629c446670c?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23813/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23813?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23813   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         161      161           
  Lines       51457    51457           
=======================================
  Hits        47489    47489           
  Misses       3968     3968
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.68% <ø> (ø)` | :arrow_up: |
| #single | `42.31% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23813?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_core.py](https://codecov.io/gh/pandas-dev/pandas/pull/23813/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb3JlLnB5) | `83.63% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23813?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23813?src=pr&el=footer). Last update [df5eeec...e0888a9](https://codecov.io/gh/pandas-dev/pandas/pull/23813?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Needs tests and a release note.

I would probably include a new keyword `include_bool` for whether or not boolean data should be included. Currently, this will be a breaking change for people relying on boolean data being dropped. I don't have a strong opinion on what the long-term behavior should be, but for now we can make it `False` or `None` if we want to issue a warning and change it to True in the future.
pls merge master, needs a test & a whatsnew note.
Closing as stale. Ping if you'd like to continue
TST: Add test cases for GH6173, appending to empty df
State: closed

- [X] closes #6173
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Hmm, previous check-in for GH4861 still showing in this branch, thought it wouldn't show as a diff after syncing to upstream (sorry, new to git)

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
Hello @eoveson! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/indexing/test_loc.py`](https://github.com/eoveson/pandas/blob/8d0bb3770fe9971ce7a9c4d2eaac55ba8ac3e58a/pandas/tests/indexing/test_loc.py) !

 - There are no PEP8 issues in the file [`pandas/tests/indexing/test_multiindex.py`](https://github.com/eoveson/pandas/blob/8d0bb3770fe9971ce7a9c4d2eaac55ba8ac3e58a/pandas/tests/indexing/test_multiindex.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23806?src=pr&el=h1) Report
> Merging [#23806](https://codecov.io/gh/pandas-dev/pandas/pull/23806?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/3e01c384b532e32872053bcd71e627c69ec61cb3?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23806/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23806?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23806   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51500    51500           
=======================================
  Hits        47531    47531           
  Misses       3969     3969
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.68% <ø> (ø)` | :arrow_up: |
| #single | `42.31% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23806?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23806?src=pr&el=footer). Last update [3e01c38...39ab773](https://codecov.io/gh/pandas-dev/pandas/pull/23806?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @eoveson
TST: Mark test_pct_max_many_rows with pytest.mark.single
State: closed

- [X] closes #23726
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

See this comment for context: https://github.com/pandas-dev/pandas/issues/23726#issuecomment-440076164

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff
name: Unreliable Test
description: Unit tests that occasionally fail

Comments:
Hello @jschendel! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/frame/test_rank.py`](https://github.com/jschendel/pandas/blob/2c05f5a63c946414f548a13a76f8ea3cc3babe69/pandas/tests/frame/test_rank.py) !

 - There are no PEP8 issues in the file [`pandas/tests/series/test_rank.py`](https://github.com/jschendel/pandas/blob/2c05f5a63c946414f548a13a76f8ea3cc3babe69/pandas/tests/series/test_rank.py) !

 - There are no PEP8 issues in the file [`pandas/tests/test_algos.py`](https://github.com/jschendel/pandas/blob/2c05f5a63c946414f548a13a76f8ea3cc3babe69/pandas/tests/test_algos.py) !


thanks @jschendel 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23799?src=pr&el=h1) Report
> Merging [#23799](https://codecov.io/gh/pandas-dev/pandas/pull/23799?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/deb7b4d5003b939f47e525bcdaceeea48622a73a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23799/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23799?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23799   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         161      161           
  Lines       51451    51451           
=======================================
  Hits        47483    47483           
  Misses       3968     3968
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.68% <ø> (ø)` | :arrow_up: |
| #single | `42.31% <ø> (+0.03%)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23799?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23799?src=pr&el=footer). Last update [deb7b4d...2c05f5a](https://codecov.io/gh/pandas-dev/pandas/pull/23799?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
TST: For GH4861, Period and datetime in multiindex
State: closed

- [X] closes #4861
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry (only test added)


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Period
description: Period data type

Comments:
Hello @eoveson! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/indexes/period/test_period.py`](https://github.com/eoveson/pandas/blob/eecede19e4ac4afc97802f2496e7fe98343b8039/pandas/tests/indexes/period/test_period.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23776?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@c9c9912`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23776/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23776?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #23776   +/-   ##
=========================================
  Coverage          ?   92.28%           
=========================================
  Files             ?      161           
  Lines             ?    51434           
  Branches          ?        0           
=========================================
  Hits              ?    47467           
  Misses            ?     3967           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.68% <ø> (?)` | |
| #single | `42.29% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23776?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23776?src=pr&el=footer). Last update [c9c9912...4f16c8b](https://codecov.io/gh/pandas-dev/pandas/pull/23776?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @eoveson
BUG: Don't warn if default conflicts with dialect
State: closed

xref #23761

Also introduces a context manager for setting CSV dialect.

Labels:
name: Bug
name: Error Reporting
description: Incorrect or improved errors from pandas
name: IO CSV
description: read_csv, to_csv

Comments:
Hello @gfyoung! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/io/parsers.py`](https://github.com/gfyoung/pandas/blob/ab3cd03cdd50c4368968cd91c853e98bd42e3d22/pandas/io/parsers.py) !

 - There are no PEP8 issues in the file [`pandas/tests/io/parser/test_dialect.py`](https://github.com/gfyoung/pandas/blob/ab3cd03cdd50c4368968cd91c853e98bd42e3d22/pandas/tests/io/parser/test_dialect.py) !

 - There are no PEP8 issues in the file [`pandas/util/testing.py`](https://github.com/gfyoung/pandas/blob/ab3cd03cdd50c4368968cd91c853e98bd42e3d22/pandas/util/testing.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23775?src=pr&el=h1) Report
> Merging [#23775](https://codecov.io/gh/pandas-dev/pandas/pull/23775?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/0ab8eb26817191bb88b6fa45b02443c4aba04326?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `94.73%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23775/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23775?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23775      +/-   ##
==========================================
+ Coverage   92.28%   92.28%   +<.01%     
==========================================
  Files         161      161              
  Lines       51434    51449      +15     
==========================================
+ Hits        47467    47481      +14     
- Misses       3967     3968       +1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.68% <94.73%> (ø)` | :arrow_up: |
| #single | `42.28% <21.05%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23775?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/parsers.py](https://codecov.io/gh/pandas-dev/pandas/pull/23775/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnNlcnMucHk=) | `95.57% <100%> (+0.01%)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/23775/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `86.04% <87.5%> (+0.01%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23775?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23775?src=pr&el=footer). Last update [0ab8eb2...ab3cd03](https://codecov.io/gh/pandas-dev/pandas/pull/23775?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
DEPS: bump xlrd min version to 1.0.0
State: closed

remove numpy warnings on np.diff in boolean arrays


Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions
name: Dependencies
description: Required and optional dependencies

Comments:
removes all of those annoying warnings on 2.7 build :>
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23774?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@2946745`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23774/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23774?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #23774   +/-   ##
=========================================
  Coverage          ?   92.28%           
=========================================
  Files             ?      161           
  Lines             ?    51451           
  Branches          ?        0           
=========================================
  Hits              ?    47483           
  Misses            ?     3968           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.68% <100%> (?)` | |
| #single | `42.28% <33.33%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23774?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/period.py](https://codecov.io/gh/pandas-dev/pandas/pull/23774/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9wZXJpb2QucHk=) | `93.07% <100%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23774?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23774?src=pr&el=footer). Last update [2946745...b1cf09f](https://codecov.io/gh/pandas-dev/pandas/pull/23774?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hello @jreback! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/core/indexes/period.py`](https://github.com/jreback/pandas/blob/64d00972ad0d7bc27d16ab618f2fc60ce1ecfc5b/pandas/core/indexes/period.py) !


@TomAugspurger if any comments
TST: Extend datetime64 arith tests to array classes, fix several broken cases
State: closed

Some of the DateOffset arithmetic didn't work with the EA classes; this fixed that.  Other pieces of the DateOffset arithmetic will have to wait until TimedeltaArray gets a few more methods.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Hello @jbrockmendel! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/core/arrays/datetimelike.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/core/arrays/datetimelike.py) !

 - There are no PEP8 issues in the file [`pandas/core/arrays/datetimes.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/core/arrays/datetimes.py) !

 - There are no PEP8 issues in the file [`pandas/core/arrays/timedeltas.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/core/arrays/timedeltas.py) !

 - There are no PEP8 issues in the file [`pandas/core/ops.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/core/ops.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arithmetic/conftest.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/tests/arithmetic/conftest.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arithmetic/test_datetime64.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/tests/arithmetic/test_datetime64.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arithmetic/test_period.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/tests/arithmetic/test_period.py) !

 - There are no PEP8 issues in the file [`pandas/tests/arithmetic/test_timedelta64.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/tests/arithmetic/test_timedelta64.py) !

 - There are no PEP8 issues in the file [`pandas/tseries/frequencies.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/tseries/frequencies.py) !

 - There are no PEP8 issues in the file [`pandas/tseries/offsets.py`](https://github.com/jbrockmendel/pandas/blob/1fbb5d53e938d5c7fb55d23fa30bfc38feccec53/pandas/tseries/offsets.py) !



##### Comment last updated on November 18, 2018 at 21:11 Hours UTC
looks good. ping on green.
> looks good. ping on green.

Travis fail is the test_apply segfault.  gentle ping
thanks