BrandonFors/pandas-github-issues huggingface dataset:
CI/DOC: pin jinja2 to 3.0.3
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Opened #46514 to track

Labels:
name: Docs
name: CI
description: Continuous Integration

Comments:
cool, merge on green (and backport) if you would.
TYP: misc
State: closed

Small set of typing changes to reduce the number of errors of pyright's reportGeneralTypeIssues from 1365 to 1309:

- return value for `_format_native_types`
- TypeVar for `tile_compat`
- When assigning literals to an instance variable, they need explicit type annotations (in this case for `CompressionOptions`), see https://github.com/microsoft/pyright/issues/3256

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Hello @twoertwein! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





















There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-03-26 02:32:25 UTC
return nan on empty groups
State: closed

- [ ] closes #46496

I'm not sure where in the rst file to specify this behavior change. If its a bug fix or just an enhancement. Any help would be appreciated. 

I also ran some of the `test...apply` files and they passed, please let me know what else I should do.
thank you!

Labels:
name: Bug
name: Groupby
name: Apply
description: Apply, Aggregate, Transform, Map
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Closing this PR as stale. @eytanohana - respond here if you are interested in continuing and would be happy to reopen!
Backport PR #46119 on branch 1.4.x (REF: isinstance(x, int) -> is_integer(x))
State: closed

Backport PR #46119: REF: isinstance(x, int) -> is_integer(x)

Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: Styler
description: conditional formatting using DataFrame.style

Comments:
Alternative to #46500, is to backport and follow-up with a test and release note.

As this is not atomic, personally I prefer the revert and redo option.
I think either might work, i probably prefer just the add tests and whats new option personally due to simplicity.
I think this PR is fine
Revert "REF: isinstance(x, int) -> is_integer(x)"
State: closed

Reverts pandas-dev/pandas#46119

It looks like this can be auto reverted. (won't know till ci has run)

@attack68 if we revert this, we could redo and add a regression test for #46384 to address https://github.com/pandas-dev/pandas/pull/46119#issuecomment-1049069600, add a release note for the bugfix and maybe backport to 1.4.x. wdyt?

I think should probably reopen #46384 and add a test to close that issue off anyway.

Labels:
name: Refactor
description: Internal refactoring of code

Comments:
closing in favor of #46501 https://github.com/pandas-dev/pandas/pull/46501#issuecomment-1080836198
DOC: setting allows_duplicate_labels=False(#46480)
State: closed

- [ ] closes #46480 (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @kwhkim!
BLD: Fix black to match pre-commit black version
State: closed

Black version is not synced now across relevant files (pre-commit's version is higher than requirements-dev's and environment's). This PR aims to fix that.

I am not aware of any issue mentioning this problem, hence no reference.

Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
Thanks @FactorizeD for the PR.

> I am not aware of any issue mentioning this problem, hence no reference.

This is surprising that this has not caused anyone any issues since was changed for pre-commit in #45752 which was merged a few weeks back now.
Fix CI
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Timezones
description: Timezone data dtype

Comments:
merging to get ci to green. But not approving since I have not looked at https://github.com/pandas-dev/pandas/pull/46460
WEB: Add benchmarks grant write up as a blog post
State: closed

Closes #45049

Create a new entry on the blog for the asv-pandas grant.

Labels:
name: Web
description: pandas website

Comments:
Thanks @LucyJimenez, I guess the CI problems are unrelated. 

@dorothykiz1 can you have a look and make any comment if needed, and approve when it's ready please?

Did any of you render the website with this post to see if everything shows as expected?
The errors don't seem related to the file added, let me render it first 
@LucyJimenez just added a few comments, you can take a look . The rendering of this post on a website is great.
Thank you @datapythonista and @dorothykiz1. 

@dorothykiz1 I am not able to see the comments yet. Could you please send it again?
@datapythonista and @dorothykiz1 I included the comments, and the PR is ready for your review. Thanks!
Can you merge master? I think CI should be green now.
> Can you merge master? I think CI should be green now.

Cool, I'll do it!
@datapythonista the PR is ready to review. Thank you :)
Thanks, @datapythonista for your comments ,I am learning from this.
@datapythonista, I will include your suggestions and let you know when it is ready. 
@datapythonista, I included your suggestion in the blog. Please, take a look at it.
Thanks @LucyJimenez and @dorothykiz1, especially your contributions to ASV!
BUG: Allow passing of args/kwargs to groupby.apply with str func
State: closed

- [x] closes #46479 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Precursor to #46072, where users doing `.groupby(...).apply("sum")` may get a warning that would not be able to be silenced without passing numeric_only.

Labels:
name: Bug
name: Groupby
name: Apply
description: Apply, Aggregate, Transform, Map
name: API - Consistency
description: Internal Consistency of API/Behavior

Comments:
thanks @rhshadrach
Fix problem about loongarch install by pip
State: closed

- [x] closes #xxxx (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


From numpy [v1.22.0](https://github.com/numpy/numpy/releases/tag/v1.22.0) support loongarch

Labels:
name: Build
description: Library building on various platforms
name: Stale

Comments:
Should I merge to 1.4.x branch ?
> Should I merge to 1.4.x branch ?

Targetting master is fine. meeksmachine will backport if required
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to be stale. If interested in continuing, please merge in the main branch, address the review and we can reopen.
ENH: implement pandas_timedelta_to_timedeltastruct for other resos
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

cc @WillAyd IIRC you implemented the original here.  The new cases this implements are mostly copy/paste, so it wouldn't surprise me if there is a more elegant alternative.  Thoughts?

Labels:
name: Timedelta
description: Timedelta data type

Comments:
> If so you might want to opt for a macro'ed approach similar to what's in khash.h rather than copy / pasting these.

my thought was to follow the pattern for the dt64 code in the same file, which would probably mean refactoring out some helper functions but not using macros.  Is getting comfortable with macros the next step of leveling up my C-fu?

The macros would definitely be more advanced, at least as far as I understand. I am by no means an expert and not in a good enough position to teach, but from my personal experience the biggest things I've found to help grasp C are:

  - Treating every warning as an error. -Wall, -Wextra and -Werror are great switches; while C has some historic cruft in what the language will allow, most compilers do a great job of warning you about things that may be technically valid but not what you want
  - Getting comfortable with the debugger. gdb and lldb are great tools, and aren't a huge leap from pdb. The only thing to be aware of here is that if you want to debug a library you will also want to compile that library with debugging enabled, otherwise a lot of the function names, symbols and bodies will be stripped down to assembly

https://pandas.pydata.org/pandas-docs/stable/development/debugging_extensions.html might also help
Thanks.  Any objection to merging as-is?  We may implement more units later, but this gets all the ones we're definitely doing.
i guess it would make sense to have a corresponding function to go from tdstruct to td64. was that just not necessary at the time when it was nanos-only?
None from me. My feedback is just long term consideration but I think it’s great to move forward with what’s there and consolidate later
> Not user facing necessarily right?

nope, just needed to implement non-nano Timedelta
BUG: tz_localize(UTC) not making a copy
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timezones
description: Timezone data dtype

Comments:
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=75654&view=logs&j=915dbb23-6529-54ae-059d-ec0b59ba10e8&t=86b091c2-17fe-52fe-2454-5f56a371e155 looks legit
I think thats the test that #46450 fixed
You may be aware, but looks like this PR didn't fully pass the CI checks

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=75723&view=logs&jobId=f64eb602-b0ed-5dcc-0a60-a7288ad39597&j=f64eb602-b0ed-5dcc-0a60-a7288ad39597&t=129bd72d-2137-55bd-1811-c4ce50c6dce8

```
_______________________ test_tz_localize_to_utc_copies ________________________
[gw1] win32 -- Python 3.8.12 C:\Miniconda\envs\pandas-dev\python.exe

    def test_tz_localize_to_utc_copies():
        # GH#46460
        arr = np.arange(5, dtype="i8")
        result = tzconversion.tz_convert_from_utc(arr, tz=UTC)
        tm.assert_numpy_array_equal(result, arr)
        assert not np.shares_memory(arr, result)
    
>       result = tzconversion.tz_convert_from_utc(arr, tz=None)

pandas\tests\tslibs\test_conversion.py:60: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
pandas\_libs\tslibs\tzconversion.pyx:506: in pandas._libs.tslibs.tzconversion.tz_convert_from_utc
    converted = _tz_convert_from_utc(vals, tz)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

>   local_val = utc_val + deltas[pos]
E   UnboundLocalError: local variable 'deltas' referenced before assignment

pandas\_libs\tslibs\tzconversion.pyx:571: UnboundLocalError
```
yah, #46478 includes a fix
also #46489 is a targeted fix
Add On being part of the pandas Benchmarks Grant blog
State: closed

The pandas Benchmarks Grant blog


Labels:
name: Docs

Comments:
@datapythonista this PR is ready for your review
CI is red. Also, my understanding that you were going to write this post together with @LucyJimenez, that would still be my preference. IMHO it'd also be nice to provide more context at the beginning on what this post is about 

Also, would be helpful if you could limit the line lengths as you do with code, makes it easier to review and edit the file if ever needed.

Finally, did you build the website as we discussed to see if the blog home and the html of your post is rendered as expected?
Hi @datapythonista. I thought each one was going to write a blog. I'm preparing mine, that's why I asked you if it was okay to hand it over the next weekend, @dorothykiz1 says that she can finished in Wednesday.
Yes ,thats what I had thought so too.Everyone writing their experience.
But you can advise otherwise ,also for the last part i had drafted it on medium (the blog site) and the layout was fine, should i still create a website?
closed to be modified
BUG: url regex in `style_render` does not pass colon and other valid
State: closed

URLs containing some valid characters such as colon in port numbers get
cut off when html-formatting. As a workaround, expanded the regex to
match a wider variety of URLs.

- [x] closes #46389 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/v1.4.2.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap
name: Styler
description: conditional formatting using DataFrame.style

Comments:
Thanks @kianelbo 
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
REF: Move value_counts, take, factorize to ArrowExtensionArray
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).



Labels:
name: Arrow
description: pyarrow functionality

Comments:
These are all methods for which we're effectively just dispatching to pyarrow's native implementations?
> These are all methods for which we're effectively just dispatching to pyarrow's native implementations?

Correct, effectively dispatches to `ChunkArray.value_counts` and `pc.is_in`
`isin` needs better thought around dtype. Probably need to create an `ArrowExtensionType` or something
As ArrowExtensionArray becomes more of The Default, i think it becomes increasingly important to address #45419.  Is `__setitem__` (or other setitem-like ops) going to Break The World?
BUG: groupby.value_counts subset arg not working
State: closed

- [x] closes #46383
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests)
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

It works but I'm not sure it is the right approach. Alternatively I could add an if-else in l.1712 to check for subset and create `keys` with two separate list comprehensions and leave the rest as it was.

Labels:

Comments:
One check is failing but can't reproduce locally. Not sure what to do.
TST: GH38947 creating function to test bar plot index
State: closed

- [X] closes #38947
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I just implemented all [changes](https://github.com/pandas-dev/pandas/pull/44033) done by @SabrinaMD

But I updated the small corrections

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Visualization
description: plotting

Comments:
> FAILED pandas/tests/io/parser/test_parse_dates.py::test_hypothesis_delimited_date[%m %Y-True-.]

From [here](https://github.com/pandas-dev/pandas/runs/5620530571?check_suite_focus=true). Does it mean that it failed because of a test in test_parse_dates.py? If so, isn't it weird since I only edited the file in ```pandas/tests/plotting/test_misc.py```?
There are also 4 error messages, all the same:

Error: The runner has received a shutdown signal...' in GHA. GH 45651
Error: The runner has received a shutdown signal...' in GHA. GH 45651
Error: The runner has received a shutdown signal...' in GHA. GH 45651
Error: The runner has received a shutdown signal...' in GHA. GH 45651

From [GH 45651](https://github.com/pandas-dev/pandas/pull/45651) it seems the test pandas/tests/io/parser/test_parse_dates.py::test_hypothesis_delimited_date is causing GHA to crash? If so what would be the solution?
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
I'm still interested in working on this but I need some high level guidance
to deep dive into the CI pipeline

Em qui., 21 de abr. de 2022 às 02:06, github-actions[bot] <
***@***.***> escreveu:

> This pull request is stale because it has been open for thirty days with
> no activity. Please update
> <https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request>
> and respond to this comment if you're still interested in working on this.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/46451#issuecomment-1104566413>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AL7M5HMVH5M2XIFKBVSBNMDVGCLXTANCNFSM5RGEM7PQ>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>

Thanks @Daquisu, sorry for the long delay. (The CI failure was unrelated). Happy to have more PRs with regression tests!
Typ: Fix io stata type ignores
State: closed

xref #37715

Hi all, first time contributing, please let me know if all is OK process-wise (e.g. commit message, if it is OK that the changes are not squashed)

Regarding the changed code - I added c_data_large for consistency (c_data_small was required to fix type: ignore), can remove if you think that it is unnecessary

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
@twoertwein lgtm merge on green.
Thank you @FactorizeD doc failure looks unrelated.
Fixing typo in docstrings
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the pull request, but IMO these docstrings/comments are already clear and the changes don't significantly improve the status quo. Additionally appears there's an errant import as well.

Going to close, but we would appreciate a contribution to any issue labeled `good first issue`. Thanks.
DOC: conveting Index object into a set(#46440)
State: closed

- [x] closes #46440 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Index
description: Related to the Index class or subclasses

Comments:
Will create another pull request
No need to create a separate pull request, each time you push changes to your PR branch the checks/tests will rerun.
Fix showing "None" as ylabel in :meth:`Series.plot` when not setting ylabel
State: closed

- [ ] closes #46129
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

[here](https://github.com/pandas-dev/pandas/issues/46129#issuecomment-1055224345), Mctoel mentioned that if series.plot(kind=pie) does not specify `ylabel`, "None" will appear as ylabel in the figure.
![image](https://user-images.githubusercontent.com/42494185/159170646-8e4013f3-9be5-4873-92f7-7b948666efbc.png)


Labels:
name: Bug
name: Visualization
description: plotting

Comments:
thanks @iansheng