BrandonFors/pandas-github-issues huggingface dataset:
Issue #58812 : DOC : Added doc string to announce.py and contibutors.py
State: closed

- [x] closes #58812  (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
@Aloqeely Okay so should i remove the long summary or examples from doc string
iirc this file is vendored so we wouldn’t want to edit it
@jbrockmendel Sorry im new to this, can you give me some more detail about what to do, i didn't understand
> iirc this file is vendored so we wouldn’t want to edit it

Ah, I didn't know that. After further search it seems most of the copied code is from scipy `tools/authors.py` which has "This script is in the public domain." written at the top of the file, so I think it's ok to edit it
> so I think it's ok to edit it

We _can_ edit it, but generally don't.  If someone thinks there is an improvement to be made in this file, it should be done upstream.
@Aloqeely I have removed the examples from doc string and added full stop to the shot summary, is there any other change that needs to be made?
@malhar2460 I am sorry but as mentioned here, this file is vendored so it isn't touched very often and I don't think we're gonna update it just to add the docstrings. Really sorry for taking much of your time!

On a note I'm still OK with this going through since the functions here are different from the ones upstream, but leaving final decision for @jbrockmendel
Okay, np👍🏻
committed new function parallel_apply
State: closed

- [x] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the PR, but one-off code snippets like this are not appropriate for the pandas library. If you're interested in contributing, feel free to tackle any of the issues labeled `good first issue`. Closing
committed new function advanced_groupby
State: closed

- [x] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the PR, but one-off code snippets like this are not appropriate for the pandas library. If you're interested in contributing, feel free to tackle any of the issues labeled `good first issue`. Closing
committed new function plotly-visualize
State: closed

- [x] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the PR, but one-off code snippets like this are not appropriate for the pandas library. If you're interested in contributing, feel free to tackle any of the issues labeled `good first issue`. Closing
PERF: future_stack=True with non-MulitIndex columns
State: closed

- [x] closes #58391 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


```python
df = pd.DataFrame(np.random.random(size=(10000, 100)))
%timeit df.unstack()
17.2 ms ± 159 μs per loop (mean ± std. dev. of 7 runs, 100 loops each)  <--- PR
205 ms ± 3.37 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)     <--- main
```

Labels:
name: Performance
description: Memory or execution speed performance
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Stale

Comments:
@jbrockmendel - the failing tests are:

```
FAILED pandas/tests/extension/test_numpy.py::TestNumpyExtensionArray::test_stack[float-True-columns0] - AssertionError: (<class 'numpy.dtypes.Float64DType'>, dtype('float64')) vs (<class 'pandas.core.dtypes.dtypes.NumpyEADtype'>, NumpyEADtype('float64'))
FAILED pandas/tests/extension/test_numpy.py::TestNumpyExtensionArray::test_stack[object-True-columns0] - AssertionError: (<class 'numpy.dtypes.ObjectDType'>, dtype('O')) vs (<class 'pandas.core.dtypes.dtypes.NumpyEADtype'>, NumpyEADtype('object'))
```

This happens because of some monkey-patching

https://github.com/pandas-dev/pandas/blame/3b48b17e52f3f3837b9ba8551c932f44633b5ff8/pandas/tests/extension/test_numpy.py#L72-L73

It's not clear to me if the code should handle this case, or if this behavior is okay and the test should be modified. Was wondering if you had any experience dealing with this.
The behavior is fine, the test should be patched
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks @rhshadrach
DOC: Instruct to run git bisect when triaging a regression report
State: closed

@rhshadrach (ref #55311)
The issue suggested to include the results of a git bisect when triaging regressions.

As for step 7, it says "what labels and milestones should I add" but has no instructions on adding milestones, the only thing I'm aware of is generally regressions are to be fixed as soon as possible so add to the next patch release, if that is not correct then I'll just rename the section.

Another note is that many steps suggest to edit the original post/title but triage permissions aren't sufficient for that, should I delete those?

Labels:
name: Docs

Comments:
>  the only thing I'm aware of is generally regressions are to be fixed as soon as possible so add to the next patch release

Yeah I would say this is generally correct. Any other milestone (major or minor release) are used by some core team members as "issues that would be nice to address by this release", so no need to include that in triage instructions
Thanks @Aloqeely
REF: Make _slice_take_blocks_ax0 a generator
State: closed

In some cases, the old `list[Block]` result was re-iterated over.

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
Do these actually improve perf? Or just for the principle of the thing?
> Do these actually improve perf? Or just for the principle of the thing?

More principle and in theory save some list allocations (which don't really register in a speed improvement)
Going to merge this PR, but happy to follow up if needed
REF: Remove BlockManager.arrays in favor of BlockManager.blocks usage
State: closed

Appears `.arrays` was a historical artifact of `ArrayManager` to have agnostic way to get "arrays" between it and `BlockManager`. Since `ArrayManager` no longer exists, we might as well clean this out

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
Looks like tests are passing here so merging. Happy to follow up if needed
Added cache argument to memory_usage function.
State: closed

- [x] closes #58529  (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the PR but the issue is labeled `needs discussion` so this feature needs more consensus before moving forward with a PR so closing for now. If interested in contributing, feel free to tackle issues labeled `good first issue`
Fix : #58748 BUG: eval fails for ExtensionArray
State: closed

- [x] closes #58748  (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.
name: expressions
description: pd.eval, query

Comments:
Hey @mutricyl thanks for mentioning it, I have worked on it and did the necessary changes. Let me know if any other changes need to be made I will work on it. Thanks
Thanks @rhshadrach @mutricyl I will work on this and update the PR as well
Although, I tried making necessary changes, and I run the pre-commits as well didn't faced any issues in it but while doing here some checks are failing any guidance how can I move forward to this?
@rhshadrach @mutricyl pushed one more PR, I fixed the issues, sorry from my end once again. Let me know if this works perfectly. Once again thanks for the help.
Hey @rhshadrach @mutricyl just a follow up message that could you check the PR that I have pushed a while ago I hope this works for your guys do check and let me know if any more changes are required to be done from my end as well. Thanks!
@rhshadrach updated the docs and committed the changes do check the PR and let me know if this works, Thanks!
Thanks @SiddheshBangar 
Welcome, thanks for helping and the guidance @rhshadrach, @mutricyl
REF: Break up stack_v3
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Just moving code around. Precursor for tackling #58391

Labels:
name: Refactor
description: Internal refactoring of code
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Thanks @rhshadrach
Typo fix in `MilliSecondLocator` for #35393
State: closed

Simple typo fix: this locator takes effect when a datetime x-range axis is < 5 seconds (among a few other conditions), and the typo causes only one xtick (at the very left) to be displayed on the x-axis.

- [x] Fixes a typo introduced in #35393: https://github.com/pandas-dev/pandas/pull/35393/files#diff-38fbb5842cbeba026592b58e1385c50f4fe71ac4658c1518f1c04f519623977eR395, discovered while looking at #52895
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Visualization
description: plotting

Comments:
Thanks @azhu-tower
DOC: fix PR02 for pandas.tseries.offsets.BQuarterEnd and pandas.tseries.offsets.QuarterEnd
State: closed

- [ ] xref #58536

fixes
```
pandas.tseries.offsets.BQuarterEnd PR02
pandas.tseries.offsets.QuarterEnd PR02
```

Labels:
name: Docs

Comments:
Thanks @tuhinsharma121
DOC: fix PR02 for pandas.tseries.offsets.BMonthBegin and pandas.tseries.offsets.BusinessMonthBegin
State: closed

- [ ] xref #58536

fixes
```
pandas.tseries.offsets.BMonthBegin PR02
pandas.tseries.offsets.BusinessMonthBegin PR02
```

Labels:
name: Docs

Comments:
Thanks @tuhinsharma121
DOC: add PR07,SA01 for pandas.Timedelta
State: closed

- [ ] xref #58505 

fixes
```
pandas.Timedelta PR07,SA01
pandas.Timestamp.resolution PR07,SA01
pandas.Timedelta.max PR07,SA01
pandas.Timedelta.min PR07,SA01
pandas.Timedelta.resolution PR07,SA01
```



Labels:
name: Docs

Comments:
Thanks @tuhinsharma121
pandas 210 has no win32 wheels
State: closed

- [ x] closes #54979


Labels:
name: Docs

Comments:
Thanks for the PR! I think the suggestion in the issue was to document the supported platforms under the [installation page](https://pandas.pydata.org/docs/getting_started/install.html#python-version-support)
Having looked at the installation page, I don't see a sensible place to add this note, since it's PyPI-specific, and so I'm happy with just a changelog note.
It does not make sense to put this information in the 2.1 changelog since that was released more than half a year ago. 

The suggestion was to add it in it's own section called 'Supported platforms' right below Python version support, which will be more visible since anyone installing pandas will check the installation page rather than the changelog, what do you think?
As you say, it's been long enough that this probably doesn't matter much; I'm happy with whatever maintainers think will close the issue.
Agreed with @Aloqeely's suggestion 
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
BUG: Fix inconsistent GroupBy.aggregate behavior with as_index=False when grouping by external Series with conflicting names #58337
State: closed

- [x] closes #58337 
- [x] [Tests added and passed]
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations]
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Groupby
name: Apply
description: Apply, Aggregate, Transform, Map
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Enh/group by.transform should accept similar arguments to group by.agg
State: closed

- [x] closes #58318 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Labels:
name: Groupby
name: Apply
description: Apply, Aggregate, Transform, Map

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
ENH add *args support for numba apply
State: closed

- [ ] closes #58712
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

added `*args` to `nb_looper()`. 
use `get_jit_arguments()` to disallow `**kwargs` in raw + numba engine.

Labels:
name: Enhancement
name: Apply
description: Apply, Aggregate, Transform, Map
name: numba
description: numba-accelerated operations

Comments:
@lithomas1 
I notice that `*args` support for raw=False + numba engine can be also added, should I open a another PR or just put them together?
> @lithomas1 I notice that `*args` support for raw=False + numba engine can be also added, should I open a another PR or just put them together?

If it's not too involved to add support there, you're welcome to put it in the same PR. 

Thanks for the quick PR btw.
It's all done. Could you take a look when you have time?
Does this also handle **kwargs by e.g. passing them as *args?

It might be worth exploring that.

This LGTM otherwise.
That's a good point, I'll have a try later when I have time.
BTW, since this PR was labeled as enhancement, should I move it to the enhancement section in whatsnew?
@lithomas1 
Hi, I added an util function as you suggested. It would be nice if you spare some time to have a look at it.
We can also extend `prepare_function_arguments` by adding a option: `num_required_args`, so that all the numba functions' args & kwargs stuff can be handled by this function, instead of in `get_jit_arguments` .
For example in groupby, we have `numba_func(group, group_index, *args)`, in this case `num_required_args = 2`:
https://github.com/pandas-dev/pandas/blob/3b48b17e52f3f3837b9ba8551c932f44633b5ff8/pandas/core/groupby/numba_.py#L102-L120
> We can also extend `prepare_function_arguments` by adding a option: `num_required_args`, so that all the numba functions' args & kwargs stuff can be handled by this function, instead of in `get_jit_arguments` . For example in groupby, we have `numba_func(group, group_index, *args)`, in this case `num_required_args = 2`:
> 
> https://github.com/pandas-dev/pandas/blob/3b48b17e52f3f3837b9ba8551c932f44633b5ff8/pandas/core/groupby/numba_.py#L102-L120

Good idea.

Do you mind doing this in a separate PR after this? 
> Good idea.
> 
> Do you mind doing this in a separate PR after this?

Sure, I'll do that after I finish this PR.
Looks all green :) @lithomas1 
@lithomas1  Hi, if you may have time, please take a look so that I will start the other PR which enhances `prepare_function_arguments`.
Thanks @auderson
DOC: add PR02,SA01 for pandas.tseries.offsets.BusinessDay and pandas.tseries.offsets.BDay
State: closed

- [ ] xref #58536

fixes
```
        pandas.tseries.offsets.BusinessDay PR02,SA01
        pandas.tseries.offsets.BDay PR02,SA01
```

Labels:
name: Stale

Comments:
its failing due to 
```
docstring of pandas._libs.tslibs.offsets.BusinessDay:41: WARNING: autosummary: stub file not found 'pandas.tseries.offsets.BusinessDay.offset'. Check your autosummary_generate setting.
```

I am not able to reproduce this error when I build the doc in local environment. 
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: Fixed PR01 for pandas.Series.cat
State: closed

Ref #58504 

Fixes PR01 for
```
-i "pandas.Series.cat.add_categories PR01,PR02" \
-i "pandas.Series.cat.as_ordered PR01" \
-i "pandas.Series.cat.as_unordered PR01" \
-i "pandas.Series.cat.remove_categories PR01,PR02" \
-i "pandas.Series.cat.remove_unused_categories PR01" \
-i "pandas.Series.cat.rename_categories PR01,PR02" \
-i "pandas.Series.cat.reorder_categories PR01,PR02" \
-i "pandas.Series.cat.set_categories PR01,PR02" \
```
I couldn't figure out how to fix PR02. If I'm getting it right, numpydoc detects PR02 errors if there are parameters described in the docstring that are not in the method signature. I dug into how the docstring validation works and found that it uses the signature of f defined in `pandas/core/accessor.py` instead of the actual signature of the methods defined in `pandas/core/arrays/categorical.py`

For reference, here's that delegator:
```
def _create_delegator_method(name: str):
    def f(self, *args, **kwargs):
        return self._delegate_method(name, *args, **kwargs)

    f.__name__ = name
    f.__doc__ = getattr(delegate, accessor_mapping(name)).__doc__

    return f
```
So PR02 is always detected if the method has any parameters. How should this be handled?

Labels:

Comments:
You're right, this seems to be a problem on pandas' end. If you can investigate and open a separate PR to fix the problem that would be really appreciated!