BrandonFors/pandas-github-issues huggingface dataset:
TST: Replace parameterize with existing test fixture
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
thx @mroeschke
TST: Skip test_rolling_var_numerical_issues on power platforms 
State: closed

Discovered while working on https://github.com/conda-forge/pandas-feedstock/pull/147. cc @jakirkham 

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Unreliable Test
description: Unit tests that occasionally fail

Comments:
Thx @mroeschke 
Thanks Matthew! 🙏
BUG: Timestamp.replace handle out-of-pydatetime range
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution
name: Timestamp
description: pd.Timestamp and associated methods

Comments:
yah i havent been able to reproduce the npdev failure.  will add GH refs in the next commit once i figure that out
@seberg any thoughts on reproducing this locally?
Hmmm, unfortunately, can't repro on M1 and I can't think of anything that may have changed in NumPy.
ooh, looks like this fixes https://github.com/pandas-dev/pandas/issues/51291, nice!
> @pytest.mark.xfail(is_numpy_dev, reason="result year is 1973, unclear why")

btw I can't reproduce this locally with numpy-dev, the correct answer shows for me
let's ship this - thanks @jbrockmendel
CI: Use regular solver for docker build
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration
name: Dependencies
description: Required and optional dependencies

Comments:
Newest numpy and numba are incompatible, so the docker build fails without taking dependencies into account
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 083d030d473260456dabd7d4fd924830e557d97a
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #50341: CI: Use regular solver for docker build'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-50341-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #50341 on branch 1.5.x (CI: Use regular solver for docker build)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
the dockerfile in 1.5.x is very different, does this need backporting?
Wasn't aware of that, are we using mamba there? If yes, then we don't have to backport
yup
we've backported the docker changes, so let's backport this too

@meeseeksdev please backport to 1.5.x
CI: add minimal requirements file
State: closed

- [ ] closes #48828 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration
name: Dependencies
description: Required and optional dependencies

Comments:
Love the idea - needed something similar for #50046 

Wondering if we shouldn't make this actually a minimal requirements file though, which would exclude pytest-cov and pytest-xdist (I think only CI needs those). Might be nice to have a true minimal file and compose the CI required-elements on top of that
Any other thoughts on this? @mroeschke @lithomas1 @fangchenli 
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
We've got 2 approvals on this. Rather then let it go stale let's merge in on next conflict fixup, unless someone objects
this workflow isn't actually running at the moment, so marking as draft until it's re-enabled https://github.com/pandas-dev/pandas/pull/50696#discussion_r1100477141
closing to clear the queue, might pick it up again in the future
DEPR: Enforce deprecation of args/kwargs in Window
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Window
description: rolling, ewma, expanding

Comments:
Thanks @rhshadrach (I think the failures have been addressed on main)
WEB: Add blog to our feed
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Web
description: pandas website

Comments:
Thanks @phofl
DOC: don't teach infer_datetime_format in user_guide
State: closed

- [x] edited the file `doc/user_guide/io.rst`.

Just removed the `infer_datetime_format` from the docs. 

It's my first pull request & it's not fully complete, so can you guide me on what else changes should be made.

closes #35296

Labels:
name: Docs

Comments:
@MarcoGorelli any updates?
Yeah sorry if I wasn't clear enough. That's exactly what I wanted to do 
@MarcoGorelli thanks! 
Had a great experience working with you and learned a lot.
BUG: to_string ignoring formatter for FloatingArray
State: closed

- [x] closes #39336 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Lets see if this passes the ci

Labels:
name: Bug
name: Output-Formatting
description: __repr__ of pandas objects, to_string
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
LGTM pending CI
Thanks @phofl
BUG: read_json raising with table orient and NA values
State: closed

- [x] closes #40255 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO JSON
description: read_json, to_json, json_normalize
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
LGTM, not sure what's going on with GH Actions
Thanks @phofl (I think you fixed the unrelated issue on main)
BUG: to_numpy for PandasArray does not handle na_value
State: closed

- [x] closes #40638 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
LGTM pending CI
Thanks @phofl
BUG: Series constructor raising with NA and bools and Int dtype
State: closed

- [x] closes #42137 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Converting here makes more sense than raising imo

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Series
description: Series data structure
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
LGTM, not sure what's going on with GH Actions
Thanks @phofl
PERF: Calculate mask in interpolate only once
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Gives us an easy 10% speedup

```
PR: 15.4 ms ± 266 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
Main: 17 ms ± 69.3 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
```

Labels:
name: Performance
description: Memory or execution speed performance
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
LGTM pending CI
Thanks @phofl
ENH: Allow `ArrowDtype(pa.string())` to be compatable with str methods
State: closed

This implementation is somewhat similar but kept separate to the methods in `ArrowStringArray` because I tailored `ArrowExtensionArray` to always return `ArrowExtensionArray` (most obvious in `_str_map`) as opposed to falling back to pandas masked arrays.


Additionally:

* `any_string_method` pytest fixture to `pandas/conftest.py` so it can be used by `extensions/test_arrow.py`
* Removed some imports into `pandas/core/strings/__init__.py` as it was causing a circular dependency when adding this to `ArrowExtensionArray`


Labels:
name: Strings
description: String extension data type and string data
name: Arrow
description: pyarrow functionality

Comments:
Closing in favor of https://github.com/pandas-dev/pandas/pull/51207
BUG: to_json segfaults when exception occurs in UTF8 encoding of string
State: closed

- [ ] closes #50307 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: IO JSON
description: read_json, to_json, json_normalize
name: Segfault
description: Non-Recoverable Error

Comments:
LGTM pending CI
Awesome thanks @lithomas1 would take an audit of any of these to support https://github.com/pandas-dev/pandas/issues/49756
it looks like this causes the 32bit built to time out on main. Any ideas why this is happening?
Not sure, do you know the exact test that is timing out?
Pretty sure it's `pandas/tests/io/json/test_ujson.py`

CI passes if I skip it https://github.com/pandas-dev/pandas/pull/50381
I can confirm that it hangs on the test added in this PR. I'm going to debug more, but feel free to revert this PR in the meantime.
Are there any warnings being generated in the logs? I would also maybe check what happens if we get rid of some of the casts - generally we do this too much in the C code
I've pulled the 32 bit docker container onto my machine, so hopefully I'll be able to debug with gdb soon.
My other guess  is that `enc->errorMsg = "Encoding failed.";` is problematic. I think the rhs of this is a `char[]` with auto storage, and it is possible that the memory for it has been reused after the function exists and by the time ultrajson actually evaluates it. This could cause undefined behavior

You could try heap allocating that string and see if it allows tests to pass (though it will cause a memory leak)
Looks like I was wrong about the duration of the string literal

https://stackoverflow.com/questions/9970295/life-time-of-a-string-literal-in-c
Looks like its getting stuck in Buffer_ReAlloc
```
#0  Buffer_Realloc (enc=0xffa2ac0c, cbNeeded=3079809510)
    at pandas/_libs/src/ujson/lib/ultrajsonenc.c:373
#1  0xf3ede5f8 in encode (obj=0xf1ace110, enc=0xffa2ac0c, name=0x0, cbName=0)
    at pandas/_libs/src/ujson/lib/ultrajsonenc.c:1083
#2  0xf3ede240 in encode (obj=0xf1a55828, enc=0xffa2ac0c, name=0x0, cbName=0)
    at pandas/_libs/src/ujson/lib/ultrajsonenc.c:993
#3  0xf3edea7d in JSON_EncodeObject (obj=0xf1a55828, enc=0xffa2ac0c, 
    _buffer=0xffa2acc4 "[", _cbBuffer=65536)
```
Maybe I need to set the length of the string to zero.

Looks like that did it. PR incoming.
ENH: Include column for ea comparison in asserters
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


The previous exception message did not include the column which made debugging harder than necessary.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
LGTM, not sure what's going on with GH Actions
Thanks @phofl
BUG: arithmetic ops not propagating mask when combining mask arrays and numpy
State: closed

- [x] closes #45810 (Replace xxxx with the GitHub issue number)
- [x] closes #42630 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
Thanks @phofl
BUG: add date_format to read_csv / Date parsing mistake. read_csv
State: closed

#50319 will happen to close #2586

This PR will make sure that bugs like #2586 don't appear again

Closes #2586 

Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
I don't think so, I don't have any example of where this makes a difference to users

Basically, PDEP4 was supposed to fix https://github.com/pandas-dev/pandas/issues/2586, but didn't because of an exception which was being swallowed by this try-except block
The raising of that exception was fixed in https://github.com/pandas-dev/pandas/pull/50319
and now this except block doesn't make a difference (all tests pass without it).

Given that PDEP4 hasn't had an effect on users yet, I'd consider this just be part of that change and not have a separate whatsnew
Thanks @MarcoGorelli 
With the removal of the dateutil code path, the docstring of `date_parser` is outdated?

```
date_parser : function, optional
    Function to use for converting a sequence of string columns to an array of
    datetime instances. The default uses ``dateutil.parser.parser`` to do the
    conversion. Pandas will try to call `date_parser` in three different ways,
    advancing to the next if an exception occurs: 1) Pass one or more arrays
    (as defined by `parse_dates`) as arguments; 2) concatenate (row-wise) the
    string values from the columns defined by `parse_dates` into a single array
    and pass that; and 3) call `date_parser` once for each row using one or
    more strings (corresponding to the columns defined by `parse_dates`) as
    arguments.
```

Although I suppose it was already outdated, because dateutil.parser was already a fallback after `to_datetime`?
BUG guess_Datetime_format doesn't guess 27.03.2003 14:55:00.000
State: closed

- [ ] closes #50317 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
> LGTM. Doesn't need a whatsnew right?

thanks! and no, this wouldn't (yet) make a user-facing difference

it fixes https://github.com/pandas-dev/pandas/issues/2586 by accident, but I'd say that that fits into the PDEP4-related part of the whatsnew (as in, PDEP4 should have fixed that, it just didn't quite because of an error in implementation here)
merging as there's been an approval, and this is quite minor, and it unblocks another PR - if there's any other concerns / feedback I can address them in a follow-up
Add pyarrow support to python engine in read_csv
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO CSV
description: read_csv, to_csv
name: Arrow
description: pyarrow functionality

Comments:
Thanks @phofl