BrandonFors/pandas-github-issues huggingface dataset:
TYP: Signature of "reindex" incompatible with supertype "NDFrame"
State: closed

- [ ] closes #40980
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
still working?
Yes, ready for review
thanks @MarcoGorelli
REF: enforce annotation in maybe_downcast_to_dtype
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Refactor
description: Internal refactoring of code
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
> no user facing change right?

correct
TST: use expected_html for to_html tests
State: closed

xref https://github.com/pandas-dev/pandas/pull/40850#discussion_r611022208

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap

Comments:
thanks @mzeitlin11
TYP: Signature of "rename" incompatible with supertype "NDFrame"
State: closed

- [x] closes #40977
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

---

@WillAyd this should still be backwards compatible, it just makes the signature compatible with its parent's

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
can we remove rewrite_axis_style_signature from DataFrame.rename?
> can we remove rewrite_axis_style_signature from DataFrame.rename?

I haven't yet made sense fo what `rewrite_axis_style_signature` does, but I"ll look into it
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
still working?
Yup, ready for review
needs rebase
thanks @MarcoGorelli i realize now why this is convoluted, will be glad to remove this in 2.0
TYP add some missing types to series
State: closed

Noticed this while working on #40973 

Those without any types won't be checked by `mypy`

e.g.:
```console
$ cat t.py
from typing import final

class Foo:
    @final
    def foo(x) -> None:
        pass

class Bar(Foo):
    def foo(x):
        pass
$ mypy t.py
Success: no issues found in 1 source file
```
Adding in `-> None`:
```console
$ cat t.py
from typing import final

class Foo:
    @final
    def foo(x) -> None:
        pass

class Bar(Foo):
    def foo(x) -> None:
        pass
$ mypy t.py
t.py:9: error: Cannot override final attribute "foo" (previously declared in base class "Foo")  [misc]
Found 1 error in 1 file (checked 1 source file)
```

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Thanks @MarcoGorelli
BUG: Fix pd.read_orc raising AttributeError
State: closed

- [x] closes #40918
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

---

I am not sure if this is a reasonable solution. Cause If users install PyArrow from PyPI on MacOS or Win10(works fine on Linux), it will always raise an `AttributeError` exception. 

Should we add some operating system requirments to `pd.read_orc`? ([Related to PyArrow's JIRA #7811](https://issues.apache.org/jira/browse/ARROW-7811)).


Labels:
name: IO Parquet
description: parquet, feather

Comments:
Thanks @amznero for the PR. 

I think it might be worth deprecating pd.read_orc. Looking at the code, read_orc is a very simple wrapper around pyarrow, so it might be better for the user to call the pyarrow code themselves. 

Looks good generally(few comments), but needs whatsnew(https://github.com/pandas-dev/pandas/blob/master/doc/source/whatsnew/v1.3.0.rst and also maybe operating system requirements in docs). 
thanks @amznero
Updated qcut for Float64DType Issue #40730
State: closed

This PR is used to address #40730 . qcut is now able to support both intdtype and floatdtype

Labels:
name: Bug
name: cut
description: cut, qcut
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
@github-actions pre-commit 
Thanks for the pr @taytzehao! Can you please add tests that fail before this fix, but pass after? I think `pandas/tests/reshape/test_qcut.py` is the right place (and has some good examples). Can you also add a whatsnew note for 1.3 (see examples in `doc/source/whatsnew/v1.3.0.rst`)
Hello @taytzehao! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-04-19 09:51:16 UTC
@github-actions pre-commit


@mzeitlin11 , let me know what you think
thanks @taytzehao nice way to fix!
CLN: de-duplicate reindex/align code
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Clean

Comments:
> FAILED pandas/tests/reductions/test_reductions.py::TestSeriesReductions::test_empty_multi[sum-0.0]

on AM
unrelated ResourceWarning
> unrelated ResourceWarning

yep started seeing that
TST: Add test for union with duplicates
State: closed

- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them



Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
> pandas/core/indexes/base.py:3003: error: unused 'type: ignore' comment
Thx @jbrockmendel 

Could add a test additionally but no typing anymore
thanks @phofl
REF: move union_categoricals call outside of cython
State: closed

There's no real perf bump to calling union_categoricals inside cython, better to do it in the python code where we can e.g. get the benefit of mypy. Plus gets us closer to dependency structure goals.



Labels:
name: Refactor
description: Internal refactoring of code
name: IO CSV
description: read_csv, to_csv

Comments:
gentle ping; lots of annotations to be done around these functions
id like to get this in before the upcoming PR doing annotations for io.parsers, which has recently become a blocker for #41059
thanks, can you catch @simonjayhawkins comment in next pass.
Add 'virt' and 'group' settings for arm64-graviton2
State: closed

https://github.com/pandas-dev/pandas/pull/40868 tried to change from `arm64` to `arm64-graviton2` but actually changed it to `amd64` because of the missing `virt` and `group` settings, as explained at https://blog.travis-ci.com/2020-09-11-arm-on-aws, section "Quick tips"

Labels:
name: CI
description: Continuous Integration
name: ARM
description: aarch64 architecture

Comments:
> Generally LGTM, I can't believe I missed that. However, Travis CI isn't running again(lack of credits again).

:_<
thanks @martin-g 
Welcome!
CLN: refactor tests outside of class setup in `style/test_matplotlib.py`
State: closed

This is a refactor to remove the pytest class setup structure, reverting to class-less fixtures.
It also parametrises some of the tests.
No test is altered or removed.

```
def test_background_gradient(styler):
def test_background_gradient_color(styler):
def test_background_gradient_axis(styler, axis, expected):
def test_text_color_threshold(cmap, expected):
def test_background_gradient_vmin_vmax():
def test_background_gradient_int64():
def test_background_gradient_gmap_array(styler_blank, axis, gmap, expected):
def test_background_gradient_gmap_array_raises(gmap, axis):
def test_background_gradient_gmap_dataframe_align(styler_blank, gmap, subset, exp_gmap):
def test_background_gradient_gmap_series_align(styler_blank, gmap, axis, exp_gmap):
def test_background_gradient_gmap_wrong_dataframe(styler_blank, gmap, axis):
def test_background_gradient_gmap_wrong_series(styler_blank):
```

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Styler
description: conditional formatting using DataFrame.style

Comments:
thanks!
Add keyword sort to pivot_table
State: closed

- [x] closes #39143
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

This adds support for sort=False to pivot_table if we want to do this

Labels:
name: Enhancement
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
thanks @phofl very nice!
Will keyword sort be added to pivot?
see #15105
Clarify docs for MultiIndex drops and levels
State: closed

- [x] closes #36227
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them


I did something like this in the past but this got lost back then between prs.


Labels:
name: Docs
name: MultiIndex

Comments:
thanks @phofl
BUG: various groupby ewm times issues
State: closed

- [x] closes #40951
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Bug
name: Window
description: rolling, ewma, expanding

Comments:
cc @mroeschke 
Thanks for your comments, I've incorporated them into the PR. Please have a look when you get a chance.

From what I can tell the failing checks seem to be due to test_empty_multi in test_reductions.py. I saw another recent PR with the same issue (https://github.com/pandas-dev/pandas/actions/runs/751397894). Is there a way to re-run the checks without pushing a commit?
A few small whatsnew comments otherwise LGTM (the follow up commit should hopefully clear the CI)
@jreback: I have incorporated your latest comments. CI is green.
Thanks @stevenschaerer nice patch!
TYP use typeddict to define cssdict
State: closed

xref https://github.com/pandas-dev/pandas/pull/39942#issuecomment-783363832 - here's a solution, the [docs](https://docs.python.org/3/library/typing.html#typing.TypedDict) say that

> At runtime it is a plain dict

Labels:
name: Typing
description: type annotations, mypy/pyright type checking
name: Styler
description: conditional formatting using DataFrame.style

Comments:
Thanks @attack68 - I've merged master and the tests pass, so looks like they were unrelated
@simonjayhawkins ok here?
Thanks @MarcoGorelli
TYP: timestamps.pyi
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
> happy to merge as is to add more types and work on the ignores as a follow-up.

yah lets do as follow-ups if OK
> yah lets do as follow-ups if OK

sure. have merged master
Thanks @jbrockmendel
REF: handle dtype dispatch in libhashtable, share Vector/Hashtable code
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Refactor
description: Internal refactoring of code
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
can you rebase (havne't looked yet)
ok looks fine, any perf diffs? (maybe expect small marginal improvements)
> ok looks fine, any perf diffs? (maybe expect small marginal improvements)

i expect it to be a wash
BUG: Dataframe mask method does not work properly with pd.StringDtype() 
State: closed

- [x] closes #40824
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Strings
description: String extension data type and string data

Comments:
thanks @DriesSchaumont
DOC: clarify (un)aware logic in tz_localize() docstring
State: closed

A simple hopefully no-brainer documentation patch; came across this while reading https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DatetimeIndex.tz_localize.html#pandas-datetimeindex-tz-localize.


Labels:
name: Docs

Comments:
Pushed another commit, PTAL @mroeschke! 
thanks @jgehrcke
call pytest with python3 -m
State: closed

This runs pytest as
```sh
python3 -m pytest  # ...
```
This allows running the tests in a venv. (Otherwise, if pytest is not installed in the venv, it falls back to the system pytest, leading to some surprises down the road.)

Labels:

Comments:
Hi @nschloe ,

> if pytest is not installed in the venv

why would it not be installed in the venv? If someone has followed the contributing guide, then it should be there
> If someone has followed the contributing guide, then it should be there

Indeed. It's just a safety net for "anyone" :smile: who missed an installation step.
Did this happen to you?

If they miss this installation step, then they will also miss all the other dev dependencies
> Did this happen to you?

Indeed. I thought I contribute this as it hits you on the head if you made a mistake, but feel free to close the PR if you don't think it's useful.
> Indeed. I thought I contribute this as it hits you on the head if you made a mistake

I'd just like to understand how it happened - which set of instructions from [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_environment.html) did you follow, and which step did you skip? If you start and Python repl and write `import pandas`, does it work fine?
> I'd just like to understand how it happened - which set of instructions from here did you follow, and which step did you skip?

[This one](https://pandas.pydata.org/pandas-docs/dev/development/contributing_environment.html#creating-a-python-environment-pip), and i skipped installing `requirements-dev.txt`.

> If you start and Python repl and write import pandas, does it work fine?

I don't know what "repl" means, but yeah, it imports fine.
Ah OK, thanks! Then you'll also be missing all the other dev dependencies, and this script will still not work even with `python -m`. If you install `requirements-dev.txt`, does this script work as it is? If so, I'd suggest keeping it as is
Sure.
DOC/CI: add missing import to ipython directive in `whatsnew/v0.11.0.rst`
State: closed

some of the builds have failed recently due to this ipython directive, so I added the fix as advised in the error warning.

Labels:
name: Docs
name: CI
description: Continuous Integration

Comments:
no objection, but where did you see this?
here: https://github.com/pandas-dev/pandas/pull/40926/checks?check_run_id=2341068381
and: https://github.com/pandas-dev/pandas/pull/40731/checks?check_run_id=2336499675
and: https://github.com/pandas-dev/pandas/pull/40422/checks?check_run_id=2340597878

3 different pull requests, all of which I don't think have anything to do with this error.
Thanks!
CLN: remove unused out kwd from take functions
State: closed

Un-revert part of #40510 in the hopes of tracking down where the perf impact was.  xref #40852 which un-reverted a different part.

Let's not merge for a few days to make sure that any surprising effects from #40852 show up in the asvs.


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Clean

Comments:
@jorisvandenbossche you said the other one didnt show any regressions; think we're OK here?
TYP: fix mypy on master
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
cool merge on green.
CLN: preliminary refactor before `Styler.highlight_quantile`
State: closed

The current structure is:

```
def highlight_between:
    def f:
        return x
    return self.apply(f)
```

So that `Styler.highlight_quantile` can reuse code this PR refactors the above to:

```
def highlight_between:
    return self.apply(_new_name)

def _new_name:
    return x
```

Labels:
name: Refactor
description: Internal refactoring of code
name: Styler
description: conditional formatting using DataFrame.style

Comments:
sure
Fix 40420:  Interpret NaN in clip() as no bound.
State: closed

- [x] closes #40420
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
@dsaxton, I have openend this draft PR to fix #40420. Just to be clear: is the behavior proposed in this PR the expected one? 
I still need to do some cleanup on the proposed code, but I wanted to make sure that the behavior we are targetting is correct.
> @dsaxton, I have openend this draft PR to fix #40420. Just to be clear: is the behavior proposed in this PR the expected one?
> I still need to do some cleanup on the proposed code, but I wanted to make sure that the behavior we are targetting is correct.

Yes, I believe according to @jreback and this issue we want to treat any "nullish" value as no bound: https://github.com/pandas-dev/pandas/issues/17276
I think non-green is not related here.
thanks @DriesSchaumont
ENH: `Styler.highlight_quantile` method
State: closed


![Screen Shot 2021-04-14 at 08 43 54](https://user-images.githubusercontent.com/24256554/114679634-a185c900-9d0c-11eb-9865-38a3aac1802c.png)





Labels:
name: Enhancement
name: Styler
description: conditional formatting using DataFrame.style

Comments:
thanks @attack68
DOC: inconsistency in doc argument types #40560
State: closed

This PR is used to address documentation inconsistencies as in issue #40560. All Array_like has been changed to array-like. However, Array_like that is used as a parameter cannot be changed as it would be identified as "array minus like".

Labels:

Comments:
It looks like you are doing a lot of different things here apart from the doc things, is this intended?
I suppose so. Maybe can you describe examples of the unintended changes?
Just check the diff of this pr
BUG: concat with DTI and all-None Index
State: closed

- [x] closes #40841
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Regression
description: Functionality that used to work in a prior pandas version
name: Index
description: Related to the Index class or subclasses

Comments:
@jbrockmendel can you add a release note for 1.2.5
oh 

> pandas/core/groupby/generic.py:181: error: Cannot override final attribute "_obj_with_exclusions" (previously declared in base class "SelectionMixin")  [misc]
> pandas/core/groupby/generic.py:934: error: Cannot override final attribute "_obj_with_exclusions" (previously declared in base class "SelectionMixin")  [misc]

is on master

cc @jbrockmendel 
@meeseeksdev backport 1.2.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.2.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 918e9f42e8250fb0a2422050e4b65644574e49a4
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #40924: BUG: concat with DTI and all-None Index'
```

4. Push to a named branch :

```
git push YOURFORK 1.2.x:auto-backport-of-pr-40924-on-1.2.x
```

5. Create a PR against branch 1.2.x, I would have named this PR:

> "Backport PR #40924 on branch 1.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
PR for DOC: inconsistency in doc argument types #40560
State: closed

This PR is used to address documentation inconsistencies as in issue #40560. Array_like have been changed to array-like 

Labels:

Comments:
Hello @taytzehao! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:











* In the file [`pandas/core/indexes/multi.py`](https://github.com/pandas-dev/pandas/blob/44aa1ea871c12b59f8045a7c6b663d7fb388d860/pandas/core/indexes/multi.py):

> [Line 3896:33](https://github.com/pandas-dev/pandas/blob/44aa1ea871c12b59f8045a7c6b663d7fb388d860/pandas/core/indexes/multi.py#L3896): [E226](https://duckduckgo.com/?q=pep8%20E226) missing whitespace around arithmetic operator
ENH: Nullable integer/boolean/floating support in lib inferencing functions
State: closed

Precursor for #40687 


Labels:
name: Enhancement
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
@jreback Not sure I follow here. I'm just following
> hmm can we simply make the return value _always_ a tuple, e.g. (values, mask) where mask could be None

so that would be tuple[np.ndarray, np.ndarray | None]. We are not returning the masked EA directly since it is an anti-pattern.


thanks @lithomas1 

if you wouldn't mind doing a PR to add doc-strings to the maybe_* routines, the issue is the Returns is now not super obvious.

thanks.
Thanks a lot @lithomas1 !