BUG: addresses #14855 by fixing color kwarg conflict
State: closed

 - [x] closes #14855 
 - [x] tests passed
 - [x] passes ``git diff upstream/master | flake8 --diff``




Labels:
name: Visualization
description: plotting

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/14871?src=pr&el=h1) Report
> Merging [#14871](https://codecov.io/gh/pandas-dev/pandas/pull/14871?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9d3554c26aa85d66cbfe6f481464f1a357af5e12?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `50%`.


```diff
@@            Coverage Diff             @@
##           master   #14871      +/-   ##
==========================================
- Coverage   91.01%   90.99%   -0.03%     
==========================================
  Files         143      143              
  Lines       49400    49399       -1     
==========================================
- Hits        44963    44952      -11     
- Misses       4437     4447      +10
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/14871?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tools/plotting.py](https://codecov.io/gh/pandas-dev/pandas/compare/9d3554c26aa85d66cbfe6f481464f1a357af5e12...3245f09b90d1ce8fe4627f229010448e466b1324?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL3Bsb3R0aW5nLnB5) | `71.75% <50%> (-0.02%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/9d3554c26aa85d66cbfe6f481464f1a357af5e12...3245f09b90d1ce8fe4627f229010448e466b1324?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/9d3554c26aa85d66cbfe6f481464f1a357af5e12...3245f09b90d1ce8fe4627f229010448e466b1324?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `90.96% <0%> (-0.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/9d3554c26aa85d66cbfe6f481464f1a357af5e12...3245f09b90d1ce8fe4627f229010448e466b1324?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.86% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/14871?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/14871?src=pr&el=footer). Last update [9d3554c...3245f09](https://codecov.io/gh/pandas-dev/pandas/compare/9d3554c26aa85d66cbfe6f481464f1a357af5e12...3245f09b90d1ce8fe4627f229010448e466b1324?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
pls add a whatsnew note (for 0.19.2 is fine)
pls add a test
Sorry for the slow response, long week at work. Thank you both for the feedback, let me know if there's something else I can change.
I also notice that this exact same bug is present in scatter_plot. It can be fixed in exactly the same way as I have done above:

![image](https://cloud.githubusercontent.com/assets/15242567/21272466/3dccec7a-c374-11e6-8256-981e7b16f7ce.png)
![image](https://cloud.githubusercontent.com/assets/15242567/21272470/425303ce-c374-11e6-957e-c2666805dd64.png)
![image](https://cloud.githubusercontent.com/assets/15242567/21272452/2ef99fb8-c374-11e6-9459-0ccd473cf09e.png)

I would be happy to fix it as well. I could just tack it on here or open another PR, whichever is best.
The change to the default value of `c` went in via https://github.com/matplotlib/matplotlib/pull/4079 which is in mpl >=1.5.0.  pandas will need to do some version checking to correctly support older versions of mpl.  I thought back to 1.3.1 is currently supported?
status of this?
status on this? @sinhrks @jorisvandenbossche @TomAugspurger 
Thanks Jeff and everyone else for your patience on this; it's been a really hectic month at work. I appreciate all the feedback from everyone. I will try to address all concerns I can tomorrow and report back.
Thanks!
I squashed and rebased since the PR was stale, but it's my first time doing that so I apologize if I made a mistake.
@alexandercbooth can you rebase

@TomAugspurger ok on this?
lgtm. @TomAugspurger ok? (don't merge yet)
@TomAugspurger ?
Sorry for the delay, +1 on this.

@jreback, when you merge PRs that need a rebase (conflicts in whatsnew), you use the `merge-pr.py` script, right? I can do it, just want to double check first. Don't want to make @alexandercbooth rebase again.
@TomAugspurger yes you can use the script. it will stop when it can't auto rebase (it will squash), you then fix the conflicts, ``git add``, then continue the script. Then I stop again (its now rebased), just to make sure the commits message and everything is ok. Then have it push upstream.
@alexandercbooth thanks!
My pleasure!