BrandonFors/pandas-github-issues huggingface dataset:
CLN: clean-up show_versions and consistently use null for json output
State: closed

note changes to LC_ALL and LOCALE, null is already used for dependencies on master, see blosc and feather.

master
```
{
  "system": {
    "commit": "a7ecced88a42c426bf61016c0131cab023c0cdff",
    "python": "3.7.5.final.0",
    "python-bits": 64,
    "OS": "Windows",
    "OS-release": "10",
    "machine": "AMD64",
    "processor": "Intel64 Family 6 Model 58 Stepping 9, GenuineIntel",
    "byteorder": "little",
    "LC_ALL": "None",
    "LANG": "en_GB.UTF-8",
    "LOCALE": "None.None"
  },
  "dependencies": {
    "pandas": "1.1.0.dev0+497.ga7ecced88",
    "numpy": "1.17.2",
    "pytz": "2019.3",
    "dateutil": "2.8.0",
    "pip": "19.3.1",
    "setuptools": "41.6.0.post20191030",
    "Cython": "0.29.13",
    "pytest": "5.2.2",
    "hypothesis": "4.36.2",
    "sphinx": "2.2.1",
    "blosc": null,
    "feather": null,
...
```

this pr
```
{
  "system": {
    "commit": "2ac9d30f302e59de035cbea89188d5421212b000",
    "python": "3.7.5.final.0",
    "python-bits": 64,
    "OS": "Windows",
    "OS-release": "10",
    "Version": "10.0.18362",
    "machine": "AMD64",
    "processor": "Intel64 Family 6 Model 58 Stepping 9, GenuineIntel",
    "byteorder": "little",
    "LC_ALL": null,
    "LANG": "en_GB.UTF-8",
    "LOCALE": {
      "language-code": null,
      "encoding": null
    }
  },
  "dependencies": {
    "pandas": "1.1.0.dev0+500.g2ac9d30f3",
    "numpy": "1.17.2",
    "pytz": "2019.3",
    "dateutil": "2.8.0",
    "pip": "19.3.1",
    "setuptools": "41.6.0.post20191030",
    "Cython": "0.29.13",
    "pytest": "5.2.2",
    "hypothesis": "4.36.2",
    "sphinx": "2.2.1",
    "blosc": null,
...
```

console output is unchanged
```
INSTALLED VERSIONS
------------------
commit           : 2ac9d30f302e59de035cbea89188d5421212b000
python           : 3.7.5.final.0
python-bits      : 64
OS               : Windows
OS-release       : 10
Version          : 10.0.18362
machine          : AMD64
processor        : Intel64 Family 6 Model 58 Stepping 9, GenuineIntel
byteorder        : little
LC_ALL           : None
LANG             : en_GB.UTF-8
LOCALE           : None.None

pandas           : 1.1.0.dev0+500.g2ac9d30f3
numpy            : 1.17.2
pytz             : 2019.3
dateutil         : 2.8.0
pip              : 19.3.1
setuptools       : 41.6.0.post20191030
Cython           : 0.29.13
pytest           : 5.2.2
hypothesis       : 4.36.2
sphinx           : 2.2.1
blosc            : None
feather          : None
...
```

Labels:
name: Clean

Comments:
hopefully the test added in #32041 will resolve the patch coverage here.
needs rebase
LGTM
thanks @simonjayhawkins
REGR: show_versions
State: closed

regression in #31660 (no need to backport)

master
```
INSTALLED VERSIONS
------------------
{k:<17}: {stat}
{k:<17}: {stat}
{k:<17}: {stat}
...
```

this PR
```
INSTALLED VERSIONS
------------------
commit           : b11e0647d42a27c279f3c46d5ce26d79bb5f5dec
python           : 3.7.4.final.0
python-bits      : 64
...
```


Labels:
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
merits test?
@jbrockmendel looks like the fakemodule tests don't clean-up. will look tomorrow if can't get to machine later this evening. could maybe use monkeypatch VERSIONS or just delete fakemodule from VERSIONS after test
ok, test here isnt important enough to be a blocker
> Just an idea, we could rename `show_versions` to `_get_versions` and make it a generator yielding the version information. Then implement a small `show_versions` function that prints the results of `_get_versions`.

have started #32042 to clean-up since `get_sys_info` was stringifying the `None`s which then appears in the json output. so could incorporate this suggestion there.
Thanks @simonjayhawkins
BUG: Preserve name in Index.astype
State: closed

- [x] closes #32013
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
Hello @dsaxton! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:













There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-03-26 15:32:09 UTC
@dsaxton can you merge master to be on the safe side

LGTM
> @dsaxton can you merge master to be on the safe side
> 
> LGTM

@jbrockmendel Looks like there's an unrelated CI failure, but probably just wait for that to be fixed?
Yah, hopefully that will be fixed by #32630.
> Yah, hopefully that will be fixed by #32630.

@jbrockmendel Green now, thanks for the review
cc @jreback i think this is good to go
@jbrockmendel if you have any more comments
im a happy camper
lgtm. can you merge master, and ping on green (just to make sure it respects all of the recent merges)
> lgtm. can you merge master, and ping on green (just to make sure it respects all of the recent merges)

@jreback Merged master + green
hmm somthing failing here, pls merge master and see
> hmm somthing failing here, pls merge master and see

@jreback Looks like one of the fixtures may have changed, hopefully will be fixed now. I think the linting error will be fixed by https://github.com/pandas-dev/pandas/pull/32987
thanks @dsaxton
CLN: 29547 replace old string formatting
State: closed

I splitted PR #31844 in batches, this is the **last**
For this PR I ran the command `grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/` and checked all the files that were returned for `.format(` and changed the old string format for the corresponding `fstrings` to attempt a full clean of, [#29547](https://github.com/pandas-dev/pandas/issues/29547). I may have missed something so is a good idea to double check just in case

- [ x  ] tests added / passed
- [ x ] passes `black pandas`
- [ x ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ x ] Ref #29547


Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
@3vts thanks for making the changes. lgtm. can you run black to get ci passing
> I splitted PR #31844 in batches, this is the **last**
> For this PR I ran the command `grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/` and checked all the files that were returned for `.format(` and changed the old string format for the corresponding `fstrings` to attempt a full clean of, [#29547](https://github.com/pandas-dev/pandas/issues/29547). I may have missed something so is a good idea to double check just in case
> 
>     * [ x  ] tests added / passed
> 
>     * [ x ] passes `black pandas`
> 
>     * [ x ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
> 
>     * [ x ] closes #29547 (?)

@3vts Can you please change the last line from ```Closes #29547``` to ```Ref #29547```, Just so it won't close the master issue
Thanks @3vts 

General comment - would be nice to keep PRs more minimal in the future. This was maybe an exception because of all of the double curly braces at play, but if something else comes up the same in the future should tackle in smaller bits
CLN: 29547 replace old string formatting 8
State: closed

I splitted PR #31844 in batches, this is the eighth
For this PR I ran the command `grep -l -R -e '%s' -e '%d' -e '\.format(' --include=*.{py,pyx} pandas/` and checked all the files that were returned for `.format(` and changed the old string format for the corresponding `fstrings` to attempt a full clean of, [#29547](https://github.com/pandas-dev/pandas/issues/29547). I may have missed something so is a good idea to double check just in case

- [ x  ] tests added / passed
- [ x ] passes `black pandas`
- [ x ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
Thanks @3vts
CI: change np-dev xfails to not strict
State: closed

follow-up to #32025

Labels:
name: CI
description: Continuous Integration
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
Do we have a good way of knowing when the xfail becomes unnecessary?
once we make the test xfail(strict=False), i don't think so. still better than a skip though since we'll see the xpass in the test output
@jbrockmendel ok with this until have time to diagnose / fix the real cause?
fine by me
CLN: remove unused from MultiIndex
State: closed


Labels:
name: MultiIndex
name: Clean

Comments:
looks like mypy is against you here. not sure why. out of curiosity, why do need to use \_\_new__ for MultiIndex?
> out of curiosity, why do need to use __new__ for MultiIndex?

I think it is a combination of playing nicely with `_simple_new` and precedent set by `Index.__new__`
I think can just add a definition for sortorder at the class level to fix mypy
> I think can just add a definition for sortorder at the class level to fix mypy

can you clarify why this is acceptable and https://github.com/pandas-dev/pandas/pull/31716#discussion_r379934750 is not.

in both cases making mypy aware of attributes. In the unacceptable case the attribute is added dynamically and therefore cannot be statically checked. Here, the attribute could be picked up by a static check if the initialazation was in \_\_init__ instead of \_\_new__

to me, it would seem that the other scenario should be more acceptable.
> lgtm. i think @simonjayhawkins has a comment; those the construction methods we have _already_ use `__new__`, not likely to change as we have certain contruction requirements

yeah, happy with what is done here. the query was directed towards @WillAyd
> can you clarify why this is acceptable and [#31716 (comment)](https://github.com/pandas-dev/pandas/pull/31716#discussion_r379934750) is not.

Yea as you mention the other one is factory generated and picks an arbitrary subset of methods to apply, so would either keep copying all attributes or stick with a weird in between. The inheritance here is much simpler and self-contained
Thanks @jbrockmendel
CI: silence numpy-dev failures
State: closed

xref #31992

Labels:
name: CI
description: Continuous Integration
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
ok. this is starting to look promising.

not marking the issue as closed since only silencing here (hence using xfails instead of skips). so fixing the issue is outstanding.

 was not able to reproduce the failures locally so didn't attempt to fix.

will flag as 1.0.2 and backport in order to keep CI there green too.
@jreback ping green
i'll merge in about 10mins if no objections. can always revert or follow-on if issues.
looks like these tests are flakey. will need to skip instead if xfail.
xfail is ok but add strict=False

much better than skips
> xfail is ok but add strict=False
> 
> much better than skips

sounds good.
WEB: Add greeting note to CoC
State: closed

I noticed something similar in the [CPython contributing docs](https://cpython-core-tutorial.readthedocs.io/en/latest/diversity.html):

> For example, don’t say “hey guys!” but “hey everyone!”.

and thought it was really nice.

Pushing directly rather than opening as good first issue to avoid invoking a s*******m

Labels:
name: Docs
name: Web
description: pandas website

Comments:
Should be good - can you merge master to get green?
I agree this feels a bit "out of place" where it is added now
If you can merge master, looks like something (I guess unrelated) failed.
Thanks @MarcoGorelli
DOC: Fix errors in pandas.Series.argmax
State: closed

- [x] closes https://github.com/pandanistas/pandanistas_sprint_jakarta2020/issues/18
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

output of `python scripts/validate_docstrings.py pandas.Series.argmax`:
```
################################################################################
################################## Validation ##################################
################################################################################
```


Labels:
name: Docs

Comments:
Thanks for the nice docstring @farhanreynaldo
DOC add extended summary, update parameter types desc, update return types desc, and add whitespaces after commas in list declarations to DataFrame.first in core/generic.py
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
@sagungrp I think CI failure is unrelated but can you merge master and repush to be sure?
@sagungrp can you please merge master into your branch to fix the CI error?
```
git fetch upstream
git merge upstream/master
git push
```
This is ready, we can merge after that. Thanks!
Thanks @sagungrp
Fix docstring validation errors in pandas.Index.slice_indexer
State: closed

- [ ] closes https://github.com/pandanistas/pandanistas_sprint_jakarta2020/issues/6
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
@giovanism can you have a look at the last comments?
Closing as stale, @giovanism let is know if you want to finish this.
DOC: Add reference in keywords arguments to Line2D mathplotlib
State: closed

Keyword arguments in `pandas.plotting.bootstrap_plot` doesn't clearly specify argument options

- [ ] closes #xxxx
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
Can you please rebase?

this should resolve CI issue
I agree with @WillAyd , we shouldn't probably make this Matplotlib specific. The stuff added here could be helpful, but we need a better way to document the backend specific parameters. Closing.
DOC: Improve docstring of Index.delete
State: closed

- [x] closes https://github.com/pandanistas/pandanistas_sprint_jakarta2020/issues/13
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Output from  validate_docstrings.py
################################################################################
####################### Docstring (pandas.Index.delete)  #######################
################################################################################

Make new Index with passed location(-s) deleted.

Use array of integer as loc parameter to delete multiple locations.

Parameters
----------
loc : int
    Location of item(-s) which will be deleted.

Returns
-------
Index
    New Index with passed location(-s) deleted.

See Also
--------
numpy.delete : Delete any rows and column from NumPy array (ndarray).

Examples
--------
>>> idx = pd.Index(['a', 'b', 'c'])
>>> idx.delete(1)  # Deleting 'b'
Index(['a', 'c'], dtype='object')
>>> idx = pd.Index(['a', 'b', 'c'])
>>> idx.delete([0, 2])
Index(['b'], dtype='object')

################################################################################
################################## Validation ##################################
################################################################################


Labels:
name: Docs

Comments:
Hello @andhikayusup! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-02-15 12:19:52 UTC
Thanks @andhikayusup
DOC: Update pandas.Series.between_time docstring params
State: closed

- [x] closes [https://github.com/pandanistas/pandanistas_sprint_jakarta2020/issues/20](https://github.com/pandanistas/pandanistas_sprint_jakarta2020/issues/20)
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

output from python scripts/validate_docstrings.py pandas.Series.between_time:
################################################################################
#################### Docstring (pandas.Series.between_time) ####################
################################################################################

Select values between particular times of the day (e.g., 9:00-9:30 AM).

By setting ``start_time`` to be later than ``end_time``,
you can get the times that are *not* between the two times.

Parameters
----------
start_time : datetime.time or str
        The first time value.
end_time : datetime.time or str
        The second time value.
include_start : bool, default True
        Adding start_time value in the result.
include_end : bool, default True
        Adding end_time value in the result.
axis : {0 or 'index', 1 or 'columns'}, default 0
        Determine range time on index or columns value.
    .. versionadded:: 0.24.0

Returns
-------
Series or DataFrame
    If axis set on columns, it will return DataFrame format, vice versa.

Raises
------
TypeError
    If the index is not  a :class:`DatetimeIndex`

See Also
--------
at_time : Select values at a particular time of the day.
first : Select initial periods of time series based on a date offset.
last : Select final periods of time series based on a date offset.
DatetimeIndex.indexer_between_time : Get just the index locations for
    values between particular times of the day.

Examples
--------
>>> i = pd.date_range('2018-04-09', periods=4, freq='1D20min')
>>> ts = pd.DataFrame({'A': [1, 2, 3, 4]}, index=i)
>>> ts
                     A
2018-04-09 00:00:00  1
2018-04-10 00:20:00  2
2018-04-11 00:40:00  3
2018-04-12 01:00:00  4

>>> ts.between_time('0:15', '0:45')
                     A
2018-04-10 00:20:00  2
2018-04-11 00:40:00  3

You get the times that are *not* between two times by setting
``start_time`` later than ``end_time``:

>>> ts.between_time('0:45', '0:15')
                     A
2018-04-09 00:00:00  1
2018-04-12 01:00:00  4

################################################################################
################################## Validation ##################################
################################################################################

Labels:
name: Docs

Comments:
Thanks @adamwidi
CI: temporary fix to the CI
State: closed

ref #31992

---

This is just a temporary fix to the CI.

Until someone smarter than me fix it :)


Labels:
name: CI
description: Continuous Integration

Comments:
OK, i guess a very 'quick and dirty' fix for the benefit of the doc sprint. can you do an IMMEDIATE follow-up PR with a skipif or xfail for np version only with the issue as a reason
> OK, i guess a very 'quick and dirty' fix for the benefit of the doc sprint. can you do an IMMEDIATE follow-up PR with a skipif or xfail for np version only with the issue as a reason

and undoes the commenting out
> OK, i guess a very 'quick and dirty' fix for the benefit of the doc sprint. can you do an IMMEDIATE follow-up PR with a skipif or xfail for np version only with the issue as a reason

I have made it "xfail" for now, what would be a good "skipif"?

I don't this the xfail will work, since some environments pass. happy to keep this PR with the commenting out to get CI green and do this on another PR.

Sorry for the "force-push" I tend to fight with git a lot.
ping @simonjayhawkins 

Numpydev is green.
> ping @simonjayhawkins
> 
> Numpydev is green.

OK since ci has a backlog, will wait a little longer for full green to be sure.
will NOT be backporting this as it is a very temporary fix (duration of doc sprint only) and merging doc PRs
> will NOT be backporting this as it is a very temporary fix (duration of doc sprint only) and merging doc PRs

I completely agree, the doc sprint run is the sole purpose of why this PR exists
i'm going to merge this shortly as it seems that Linux py37_locale has hung and restarting is pointless given the ci backlog. any objections @jreback 
@simonjayhawkins go for it
@datapythonista I leave it to you to weight up the benefits of merging PRs to master vs reducing the burden on ci for the benefit of the sprint.

I think OK to merge PRs to master without getting contributors to rebase to reduce the CI burden further 
@MomIsBestFriend do you want to take the lead on the follow-up PR? if not, can you raise an issue as @jreback  suggested.
ah almost forgot.... Thanks @MomIsBestFriend.
@datapythonista as an aside. I had the same issue with the CI at the Man Hackathon. after just a few hours into the sprint, ci was taking more than 2 hours to complete.
@MomIsBestFriend np-dev still failing on master!
> @MomIsBestFriend np-dev still failing on master!

cannot reproduce locally. I assume that I am not setting up the environment/build correctly. maybe skip/xfail those as well?
DOC: Fix errors in pandas.Series.argmax
State: closed

- [x] closes https://github.com/pandanistas/pandanistas_sprint_jakarta2020/issues/18
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

output of `python scripts/validate_docstrings.py pandas.Series.argmax`:
```
################################################################################
################################## Validation ##################################
################################################################################
```

Labels:
name: Docs

Comments:
Isn't this a duplicate of #31999 ?
> 
> 
> Isn't this a duplicate of #31999 ?

I think it is, I was trying to tackle 1 error on the issue and I made another pull request for the rest of error on the issue. 
> > Isn't this a duplicate of #31999 ?
> 
> I think it is, I was trying to tackle 1 error on the issue and I made another pull request for the rest of error on the issue.

I think what happen was is that you ran ```git checkout``` from the branch you were working on, and you forgot to commit the rest of the changes.
> 
> 
> > > Isn't this a duplicate of #31999 ?
> > 
> > 
> > I think it is, I was trying to tackle 1 error on the issue and I made another pull request for the rest of error on the issue.
> 
> I think what happen was is that you ran `git checkout` from the branch you were working on, and you forgot to commit the rest of the changes.

Oh I see. Thank you for letting me know about this. Anything I should do regarding this PR duplication?
> > > > Isn't this a duplicate of #31999 ?
> > > 
> > > 
> > > I think it is, I was trying to tackle 1 error on the issue and I made another pull request for the rest of error on the issue.
> > 
> > 
> > I think what happen was is that you ran `git checkout` from the branch you were working on, and you forgot to commit the rest of the changes.
> 
> Oh I see. Thank you for let me know this. Anything I should do regarding the PR duplication?

The way I see it, for this PR you can either close it or making the changes to initially intended to do.

---

Either way thank you for working on this!
DOC: Improve documentation for Index.where
State: closed

- [x] closes https://github.com/pandanistas/pandanistas_sprint_jakarta2020/issues/15
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
Thanks for the work on this @laymonage