BrandonFors/pandas-github-issues huggingface dataset:
DOC: actually document float_precision in read_csv
State: closed

So I wasn't 100% correct when I said that `float_precision` was documented <a href="https://github.com/pydata/pandas/issues/12686#issuecomment-222684918">here<a/>.  It was well documented internally for `TextParser` and in a section for `io.rst`, but it wasn't listed formally in the parameters for the `read_csv` documentation.


Labels:
name: Docs
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13377?src=pr) is **84.23%**

> Merging [#13377](https://codecov.io/gh/pydata/pandas/pull/13377?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13377   diff @@
==========================================
  Files           138        138          
  Lines         50739      50739          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          42740      42740          
  Misses         7999       7999          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [b722222...ffca1ec](https://codecov.io/gh/pydata/pandas/compare/b722222f5ea760a3f3df4d063309949eb4956674...ffca1ecd64325073365267aa1bb6c674ac42deca)

ty
DOC: Fix wording/grammar for rolling's win_type argument.
State: closed

I don't know the exact intended phrasing here, but I think the writer might have meant "Provide"?


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13376?src=pr) is **84.23%**

> Merging [#13376](https://codecov.io/gh/pydata/pandas/pull/13376?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13376   diff @@
==========================================
  Files           138        138          
  Lines         50739      50739          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          42740      42740          
  Misses         7999       7999          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [b722222...ec0c88e](https://codecov.io/gh/pydata/pandas/compare/b722222f5ea760a3f3df4d063309949eb4956674...ec0c88e812ea607518b133d269e8082566c53791)

thanks @mikegraham 

yeah prob could flesh that out a bit
ENH: astype() can now take col label -> dtype mapping as arg; GH7271
State: closed

New PR for what was started in #12086.

closes #7271

By passing a dict of {column name/column index: dtype}, multiple columns can be cast to different data types in a single command. Now users can do:

`df = df.astype({'my_bool', 'bool', 'my_int': 'int'})`

or:

`df = df.astype({0, 'bool', 1: 'int'})`

instead of:

```
df['my_bool'] = df.my_bool.astype('bool')
df['my_int'] = df.my_int.astype('int')
```


Labels:
name: Enhancement
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: API Design

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13375?src=pr) is **84.38%**

> Merging [#13375](https://codecov.io/gh/pydata/pandas/pull/13375?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13375   diff @@
==========================================
  Files           142        142          
  Lines         51223      51241    +18   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43224      43242    +18   
  Misses         7999       7999          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ada6bf3...5fe82e3](https://codecov.io/gh/pydata/pandas/compare/ada6bf350f7fd4daaf2b80188ca165fb9543a252...5fe82e37ac1a895d770276ff090d11e633fa35aa?src=pr)

Updated

@StephenKappel Can you rebase this?

This will raise an error when you have duplicate columns (also if it is not the column you are astyping). But maybe we are OK with that?

can you rebase / update

rebased and updated to work with duplicate column names

thanks! nice PR
Typo correction
State: closed

Corrected a small typo found when reviewing the script.


Labels:
name: Docs

Comments:
this script is obsolete. you can simply delete it for this PR

@jorisvandenbossche 

Ok, will do.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13369?src=pr) is **84.23%**

> Merging [#13369](https://codecov.io/gh/pydata/pandas/pull/13369?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13369   diff @@
==========================================
  Files           138        138          
  Lines         50739      50739          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          42740      42740          
  Misses         7999       7999          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [5a9b498...913e6db](https://codecov.io/gh/pydata/pandas/compare/5a9b498e43a41744470732438e9422a407b0b380...913e6dbdd077ad236b54c263fe5fd09de3cad5ce)

This can indeed be deleted I think
DOC: Fixed a minor typo
State: closed

It also seems that the texts of the `doc/README.rst` and the `doc/source/contributing.rst` have lots of overlap and duplication. Not sure if there are any plans in consolidating these two files but I thought to mention that here 😄 


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13366?src=pr) is **84.23%**

> Merging [#13366](https://codecov.io/gh/pydata/pandas/pull/13366?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13366   diff @@
==========================================
  Files           138        138          
  Lines         50724      50724          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          42726      42726          
  Misses         7998       7998          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [103f7d3...029ade7](https://codecov.io/gh/pydata/pandas/compare/103f7d31e1b850e532ed85a4b53ef222d1271c54...029ade7c9fd65da98e22c09c4e7911e80be95cc5)

thanks.

the README is for 'local-use' IOW its there waiting to be read if needed. the contributing.rst is built into the published docs.

Cool @jreback. I hope I can contribute more to this awesome library 😄
BUG: resample by BusinessHour raises ValueError
State: closed

- [x] closes #12351 
- [x] tests added / passed (`TestPeriodIndex.test_resample_hourly_business_hourly`)
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

I did this during pandas sprint at PyCon 2016. Hope this close #12351
Resampling with BusinessHour took much more consideration I guess.
Please review this. Any comments are welcome.


Labels:
name: Bug
name: Resample
description: resample method

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13364?src=pr) is **84.23%**

> Merging [#13364](https://codecov.io/gh/pydata/pandas/pull/13364?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13364   diff @@
==========================================
  Files           138        138          
  Lines         50724      50727     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42726      42729     +3   
  Misses         7998       7998          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [103f7d3...2d3be12](https://codecov.io/gh/pydata/pandas/compare/103f7d31e1b850e532ed85a4b53ef222d1271c54...2d3be12277a1a99fdf7cb9fc5b2b8a9fee13f851)

can you update

@scari Do you have time to rebase and update this?

can you rebase / update?

can you rebase and move release notes to 0.19.2

can you rebase / move whatsnew to 0.20.0
closing as stale
BUG: df.pivot_table: margins_name is ignored when there aggfunc is li…
State: closed

- [x ] closes #13354 
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

…st #13354


Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13363?src=pr) is **84.23%**

> Merging [#13363](https://codecov.io/gh/pydata/pandas/pull/13363?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13363   diff @@
==========================================
  Files           138        138          
  Lines         50724      50724          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42726      42725     -1   
- Misses         7998       7999     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [103f7d3...f7cd79f](https://codecov.io/gh/pydata/pandas/compare/103f7d31e1b850e532ed85a4b53ef222d1271c54...f7cd79f6d5c1cd6346199737b4feafc1ff7c8d2f)

can you add tests / rebase

can you rebase / update?

closing, but pls reopen / comment if you can continue

needs tests
DEPR, DOC: Deprecate buffer_lines in read_csv
State: closed

`buffer_lines` is not respected, as it is determined internally via a heuristic involving `table_width` (see <a href="https://github.com/pydata/pandas/blob/master/pandas/parser.pyx#L527">here</a> for how it is computed).


Labels:
name: API Design
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13360?src=pr) is **84.23%**

> Merging [#13360](https://codecov.io/gh/pydata/pandas/pull/13360?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13360   diff @@
==========================================
  Files           138        138          
  Lines         50724      50725     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42726      42727     +1   
  Misses         7998       7998          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [103f7d3...87eff55](https://codecov.io/gh/pydata/pandas/compare/103f7d31e1b850e532ed85a4b53ef222d1271c54...87eff55c436e01d15c82522aecbae053281ba24a)

@jreback : Made the requested doc change, and Travis is giving the green light.  Ready to merge if there is nothing else.

ty
Make pd.read_hdf('data.h5') work when pandas object stored contained categorical columns
State: closed

- [x] closes #13231 
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: IO HDF5
description: read_hdf, HDFStore

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13359?src=pr) is **84.23%**

> Merging [#13359](https://codecov.io/gh/pydata/pandas/pull/13359?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13359   diff @@
==========================================
  Files           138        138          
  Lines         50724      50736    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42726      42737    +11   
- Misses         7998       7999     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [103f7d3...e7c8313](https://codecov.io/gh/pydata/pandas/compare/103f7d31e1b850e532ed85a4b53ef222d1271c54...e7c8313e611ca13024f31ce179a4758155047835)

looks good. I think there is a failing case that needs to be tested.

thanks @chrish42
DOC: fix comment on previous versions cythonmagic
State: closed

Small thing I just noticed in the docs (the note on the other version was not updated when the example was changed from cythonmagic -> Cython)


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13343?src=pr) is **84.23%**

> Merging [#13343](https://codecov.io/gh/pydata/pandas/pull/13343?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13343   diff @@
==========================================
  Files           138        138          
  Lines         50713      50713          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42715      42714     -1   
- Misses         7998       7999     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [fcd73ad...902352c](https://codecov.io/gh/pydata/pandas/compare/fcd73ad2e7482414b61d47056c6c9c220b11702c...902352c659276e2ea9c05e5af88b637cbf6918ee)
ENH: Series has gained the properties .is_monotonic*
State: closed


Labels:
name: Enhancement
name: Datetime
description: Datetime data dtype

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13336?src=pr) is **84.23%**

> Merging [#13336](https://codecov.io/gh/pydata/pandas/pull/13336?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13336   diff @@
==========================================
  Files           138        138          
  Lines         50703      50710     +7   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42705      42712     +7   
  Misses         7998       7998          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [f3d7c18...0a50ff9](https://codecov.io/gh/pydata/pandas/compare/f3d7c18190045bdf02f4448e46880a7030829716...0a50ff924d8ba97a09aeda52d6318e89ffa53862)
BUG: Fix maybe_convert_numeric for unhashable objects
State: closed

- [x] closes #13324
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13326?src=pr) is **84.22%**

> Merging [#13326](https://codecov.io/gh/pydata/pandas/pull/13326?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13326   diff @@
==========================================
  Files           138        138          
  Lines         50684      50681     -3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42684      42682     -2   
+ Misses         8000       7999     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [c0850ea...80b8515](https://codecov.io/gh/pydata/pandas/compare/c0850ea7f4c04a725142408208a49072dbe04b63...80b8515fc0d26c1905fa411b438d28758276e76b)

@jreback i've made the changes you suggested

looks good. ping when green.

@RogerThomas thanks!

I was just experimenting with something and:

so maybe should change this to `if getattr(val, '__hash__', None) is not None`

though can't seem to get this to trigger

```
In [1]: 'a'.__hash__
Out[1]: <method-wrapper '__hash__' of str object at 0x1002e1508>

In [2]: None.__hash__
Out[2]: <method-wrapper '__hash__' of NoneType object at 0x100180c40>

In [3]: 1.__hash__
  File "<ipython-input-3-e97b483155ff>", line 1
    1.__hash__
             ^
SyntaxError: invalid syntax

In [5]: [].__hash__ is None
Out[5]: True

```

if you want to see if you can generate a test that makes this fail (not sure). If so , can you do a followup?

Hey @jreback, I think this is just due to python's syntax parser.

``` python
In [1]: a = 1

In [2]: a.__hash__
Out[2]: <method-wrapper '__hash__' of int object at 0xa63b00>
```

I don't think this could ever fail

oh ok that makes sense thanks
ENH: add support for na_filter in Python engine
State: closed

Title is self-explanatory.


Labels:
name: IO CSV
description: read_csv, to_csv
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13321?src=pr) is **84.22%**

> Merging [#13321](https://codecov.io/gh/pydata/pandas/pull/13321?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13321   diff @@
==========================================
  Files           138        138          
  Lines         50681      50670    -11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42682      42675     -7   
+ Misses         7999       7995     -4   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [9e7bfdd...5cb0ae6](https://codecov.io/gh/pydata/pandas/compare/9e7bfdd5996d90c774cf6ebd39c6c0779469e545...5cb0ae64e149a9b636a39782aa987994d83514bb)

looks fine. pls rebase

@jreback : Rebased and Travis is giving the green light.  Ready to merge if there are no other concerns.

@gfyoung very minor comment

ty @gfyoung
BUG: Parse trailing NaN values for the Python parser
State: closed

Fixes bug in which the Python parser failed to detect trailing `NaN` values in rows


Labels:
name: Bug
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13320?src=pr) is **84.22%**

> Merging [#13320](https://codecov.io/gh/pydata/pandas/pull/13320?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13320   diff @@
==========================================
  Files           138        138          
  Lines         50710      50667    -43   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42712      42672    -40   
+ Misses         7998       7995     -3   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [8bbd2bc...7515029](https://codecov.io/gh/pydata/pandas/compare/8bbd2bc8f148ec54b0cb8af9d9584816722c7e9f...75150292308ca44470831e5a59dd2f2f9efbeb0d)

rebase after #13325 

ok merged #13325 so go ahead and rebase this and `na_filter` one

Sounds good.  Don't have access to my computer at the moment, but will do ASAP.

@jreback : Rebased and Travis is happy.  Ready to merge if there are no other concerns.

thanks!
TST: Parser tests refactoring
State: closed

1) Moved no columns test from CParser-only to `common.py`
2) Moved erroneous placed skiprows tests into their proper place


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13319?src=pr) is **84.22%**

> Merging [#13319](https://codecov.io/gh/pydata/pandas/pull/13319?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13319   diff @@
==========================================
  Files           138        138          
  Lines         50667      50667          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          42672      42672          
  Misses         7995       7995          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [70be8a9...bc1402e](https://codecov.io/gh/pydata/pandas/compare/70be8a95ebeb638aa53f465ba885a7b33b6c35d9...bc1402e65168ebf395be74ffa1ecd6563d5437b9)

ty @gfyoung
BUG: Groupby.nth includes group key inconsistently #12839
State: closed

- [x] closes #12839
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

When the group selection changes, the cache for `_selected_obj` needs to be reset so that `nth`, `head`, and `tail` can return consistent results.


Labels:
name: Bug
name: Groupby

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13316?src=pr) is **84.34%**

> Merging [#13316](https://codecov.io/gh/pydata/pandas/pull/13316?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13316   diff @@
==========================================
  Files           138        138          
  Lines         51126      51133     +7   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43122      43130     +8   
+ Misses         8004       8003     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [2134b63...16f5cd3](https://codecov.io/gh/pydata/pandas/compare/2134b6307928b526776473d641f88d5d15a6d025...16f5cd3712affbab4ccffe32d90b3ac600698229)

@adneu ok just some minor comments. ping when updated / green.

@adneu Do you have some time to update this?

@adneu ok only minor changes. can you update

Sorry for the delay. I added some docstrings and tests based on your comments. Pls check out the latest commit and let me know if ok.

naming change but otherwise lgtm. ping when green.

@adneu Looks good!

@jreback good to go?

thanks @adneu