BrandonFors/pandas-github-issues huggingface dataset:
TST: parameterize consistency tests for rolling/expanding windows
State: closed


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=h1) Report
> Merging [#17292](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7818486859d1aba53ce359b93cfc772e688958e5?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/17292/graphs/tree.svg?src=pr&width=650&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #17292      +/-   ##
==========================================
+ Coverage      91%   91.01%   +<.01%     
==========================================
  Files         162      162              
  Lines       49549    49549              
==========================================
+ Hits        45094    45097       +3     
+ Misses       4455     4452       -3
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.79% <ø> (+0.02%)` | :arrow_up: |
| #single | `40.25% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.72% <0%> (-0.1%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.05% <0%> (+1.81%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=footer). Last update [7818486...e726f7b](https://codecov.io/gh/pandas-dev/pandas/pull/17292?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
CLN: Replace imports of * with explicit imports
State: closed

Remove compat_NaT which is never used after being defined

Remove other unused imports

Remove unused cdef enum NPY_TYPES

flake8 cleanup in period.pyx

Ref #17234

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=h1) Report
> Merging [#17269](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/57befd18cb8ea8d641ea88a5c8ef916a09a9a1aa?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/17269/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #17269      +/-   ##
==========================================
- Coverage   91.02%   91.01%   -0.02%     
==========================================
  Files         162      162              
  Lines       49539    49539              
==========================================
- Hits        45095    45087       -8     
- Misses       4444     4452       +8
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.79% <ø> (ø)` | :arrow_up: |
| #single | `40.25% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.72% <0%> (-0.1%)` | :arrow_down: |
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.33% <0%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=footer). Last update [57befd1...35c5995](https://codecov.io/gh/pandas-dev/pandas/pull/17269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
CLN: Remove have_pytz (gh-17251)
State: closed

- [x] closes #17251
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Timezones
description: Timezone data dtype
name: Clean

Comments:
lgtm assuming it passes.
The Travis error was a ResourceWarning, seems unrelated.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=h1) Report
> Merging [#17266](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/6fe68325de93a5f745ff49eac57589d33a1d53c1?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/17266/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #17266      +/-   ##
==========================================
- Coverage   91.02%   91.01%   -0.02%     
==========================================
  Files         162      162              
  Lines       49539    49539              
==========================================
- Hits        45095    45087       -8     
- Misses       4444     4452       +8
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.79% <ø> (ø)` | :arrow_up: |
| #single | `40.25% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.72% <0%> (-0.1%)` | :arrow_down: |
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.33% <0%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=footer). Last update [6fe6832...a0cae1d](https://codecov.io/gh/pandas-dev/pandas/pull/17266?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Alright, in it goes.  Thanks @jbrockmendel !
BUG: Have object dtype for empty Categorical.categories
State: closed

Closes https://github.com/pandas-dev/pandas/issues/17248

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Categorical
description: Categorical Data Type

Comments:
lgtm. *might* be another issue out there about this.
There's one for `Series()` having float dtype: https://github.com/pandas-dev/pandas/issues/16737 (actually, that's about the index dtype).

Do we want to embrace empty = object dtype everywhere?
> Do we want to embrace empty = object dtype everywhere?

yes 
FYI CircleCI has finished (https://circleci.com/gh/pandas-dev/pandas/3865?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link), but the widget here on Github hasn't updated yet. I'll merge this later today.

Changing `pd.Series([])` will be a big enough change that I've split that into a separate issue: https://github.com/pandas-dev/pandas/issues/17261
hmm almost certain there already is an issue about Series.
BUGfix: reset_index can reset index name (#17067)
State: closed

- [ ] closes #17067
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

I added name parameter value to preserve index name before `reset_index`.


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
Oh, now I realize that I shouldn't modify core/common.py :(
I found where to fix, and working on it.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17243?src=pr&el=h1) Report
> Merging [#17243](https://codecov.io/gh/pandas-dev/pandas/pull/17243?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c0e37670dd578728f988a33bc21bc173b336249a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/17243/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/17243?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #17243   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         148      148           
  Lines       48688    48688           
=======================================
  Hits        44566    44566           
  Misses       4122     4122
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.9% <100%> (ø)` | :arrow_up: |
| #single | `41.63% <66.66%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/17243?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/17243/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.45% <100%> (ø)` | :arrow_up: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/pull/17243/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `92.92% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17243?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17243?src=pr&el=footer). Last update [c0e3767...5759763](https://codecov.io/gh/pandas-dev/pandas/pull/17243?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you rebase and update
and move note to 0.22.0
can you rebase / update
I rebased; if you can fix according to comments.
@hurcy can you rebase this and update
closing as stale
Remove import of pandas as pd in core.window
State: closed

Do `isinstance` checks against `ABCFoo`.

- [ ] closes #xxxx
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=h1) Report
> Merging [#17233](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/06850a148ad880eb2fd2564cc0ad7cae8606dd90?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `89.47%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/17233/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #17233      +/-   ##
==========================================
+ Coverage      91%   91.01%   +<.01%     
==========================================
  Files         162      162              
  Lines       49531    49526       -5     
==========================================
- Hits        45077    45074       -3     
+ Misses       4454     4452       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.79% <89.47%> (+0.02%)` | :arrow_up: |
| #single | `40.26% <0%> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/window.py](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvd2luZG93LnB5) | `96.37% <89.47%> (-0.14%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.72% <0%> (-0.1%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.05% <0%> (+1.81%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=footer). Last update [06850a1...f525d13](https://codecov.io/gh/pandas-dev/pandas/pull/17233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks. generally removing ``pd`` is in and of itself not a big deal; e.g. this is not a top-level imported module
Update plotting functions to use the new Matplotlib default styles
State: closed

`ax.set_xlim(left, right)` in `_make_plot()` is used only if the Matplotlib version is <2.0.0

- closes #15495


Labels:
name: Visualization
description: plotting

Comments:
is there a tests for this?
can you rebase / update
I think the original issue was in the meantime closed by https://github.com/pandas-dev/pandas/pull/16600 ? 
@TomAugspurger is this correct ?
@jorisvandenbossche yep.

Thanks anyway @apcamargo. This is fixed on master now.
Fix docs (#17226)
State: closed

- closes #17226


Labels:

Comments:
Hello @RaghavBatra! Thanks for updating the PR.

 - In the file [`pandas/core/generic.py`](https://github.com/pandas-dev/pandas/blob/8646301902fed0771030178722722e017b1ef83d/pandas/core/generic.py), following are the PEP8 issues :

> [Line 4126:70](https://github.com/pandas-dev/pandas/blob/8646301902fed0771030178722722e017b1ef83d/pandas/core/generic.py#L4126): [W291](https://duckduckgo.com/?q=pep8%20W291) trailing whitespace



##### Comment last updated on August 11, 2017 at 13:07 Hours UTC
@RaghavBatra : So the fix will be a little more involved than this.  If you try installing your branch, you will see that the documentation will now be incorrect for `DataFrame.replace`.  I think you might have to define `replace` in the `Series` class and add custom documentation there (unless I'm forgetting some doc-trick @jreback ?)
Hey this looks like more work than I thought. Maybe later and thanks for your help!
BUG: boolean masking with Index objects
State: closed

closes #17131

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=h1) Report
> Merging [#17219](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f165b90ed27487287e1c8a0a6c4e66344b2c731d?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/17219/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #17219      +/-   ##
==========================================
- Coverage   91.02%   91.01%   -0.02%     
==========================================
  Files         162      162              
  Lines       49517    49518       +1     
==========================================
- Hits        45075    45067       -8     
- Misses       4442     4451       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.79% <100%> (ø)` | :arrow_up: |
| #single | `40.27% <100%> (-0.06%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `91.47% <100%> (+0.02%)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.71% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=footer). Last update [f165b90...54af0dc](https://codecov.io/gh/pandas-dev/pandas/pull/17219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you rebase / update & add tests
superseded by #17738
Remove import exception handling
State: closed

Imports should succeed on all versions of Python that pandas supports.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=h1) Report
> Merging [#17218](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f165b90ed27487287e1c8a0a6c4e66344b2c731d?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/17218/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #17218      +/-   ##
==========================================
- Coverage   91.02%   90.98%   -0.05%     
==========================================
  Files         162      162              
  Lines       49517    49517              
==========================================
- Hits        45075    45054      -21     
- Misses       4442     4463      +21
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.76% <ø> (-0.03%)` | :arrow_down: |
| #single | `40.26% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `63.23% <0%> (-1.82%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.71% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=footer). Last update [f165b90...29f4798](https://codecov.io/gh/pandas-dev/pandas/pull/17218?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks @dhimmel !
Add dt accessor to Index
State: closed

Following discussion in #17134, this adds a `dt` property/accessor to `pd.Index`.  This property should quack like `pd.Series.dt`.  If `index` is not datetime-like, `index.dt` will raise an `AttributeError`.  Otherwise it will return an object that is effectively `index.to_series().dt`

Subsumes parts of #17117 

 - [ ] closes #17134
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master -u -- "*.py" | flake8 --diff``
 - [ ] whatsnew entry


Labels:
name: API Design

Comments:
See my comment in the issue: https://github.com/pandas-dev/pandas/issues/17134#issuecomment-321190508 which should be discussed first
This can be closed at least until #17134 is resolved.