BrandonFors/pandas-github-issues huggingface dataset:
DOC: misc. typos
State: closed

Found via `codespell -q 3 -I ../pandas-whitelist.txt`
Where whitelists consists of:
```
ans
behaviour
doubleclick
indicies
initialise
initialised
initialising
nd
resetted
splitted
thru
valu
```

Labels:

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19876?src=pr&el=h1) Report
> Merging [#19876](https://codecov.io/gh/pandas-dev/pandas/pull/19876?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ce77b79b97d7e827f50ebd0b7ca292fc2d966cc7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19876/graphs/tree.svg?src=pr&width=650&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19876?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19876   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         150      150           
  Lines       48946    48946           
=======================================
  Hits        44858    44858           
  Misses       4088     4088
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.02% <ø> (ø)` | :arrow_up: |
| #single | `41.81% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19876?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/internals.py](https://codecov.io/gh/pandas-dev/pandas/pull/19876/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzLnB5) | `95.53% <ø> (ø)` | :arrow_up: |
| [pandas/core/arrays/categorical.py](https://codecov.io/gh/pandas-dev/pandas/pull/19876/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2NhdGVnb3JpY2FsLnB5) | `95.04% <ø> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19876/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19876?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19876?src=pr&el=footer). Last update [ce77b79...d0624de](https://codecov.io/gh/pandas-dev/pandas/pull/19876?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thank you!
Use pandas_datetimestruct instead of date_info
State: closed

Changes test file name from previous pass

Labels:
name: Datetime
description: Datetime data dtype
name: Period
description: Period data type
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19874?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e97be6f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19874/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19874?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19874   +/-   ##
=========================================
  Coverage          ?   91.67%           
=========================================
  Files             ?      150           
  Lines             ?    48946           
  Branches          ?        0           
=========================================
  Hits              ?    44870           
  Misses            ?     4076           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.05% <ø> (?)` | |
| #single | `41.81% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19874?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19874?src=pr&el=footer). Last update [e97be6f...35e6c4d](https://codecov.io/gh/pandas-dev/pandas/pull/19874?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks.
templatize timedelta arith ops
State: closed

Some Timedelta operations are constructed using `_binary_op_method_timedeltalike`, while a bunch of others re-implement shared logic.  This PR is an attempt to get rid of the small differences in this shared logic so they can eventually use a single template.


Labels:
name: Timedelta
description: Timedelta data type
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19871?src=pr&el=h1) Report
> Merging [#19871](https://codecov.io/gh/pandas-dev/pandas/pull/19871?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ce77b79b97d7e827f50ebd0b7ca292fc2d966cc7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19871/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19871?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19871   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         150      150           
  Lines       48946    48946           
=======================================
  Hits        44858    44858           
  Misses       4088     4088
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.02% <ø> (ø)` | :arrow_up: |
| #single | `41.81% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19871?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19871?src=pr&el=footer). Last update [ce77b79...6225653](https://codecov.io/gh/pandas-dev/pandas/pull/19871?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks
disallow Timedelta ops with unitless timedelta64
State: closed

- [x] closes #19388
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19870?src=pr&el=h1) Report
> Merging [#19870](https://codecov.io/gh/pandas-dev/pandas/pull/19870?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/8f1dfa74e244622a7f356a496072f93dce032839?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19870/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19870?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19870      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files         150      150              
  Lines       48936    48938       +2     
==========================================
+ Hits        44860    44861       +1     
- Misses       4076     4077       +1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.04% <ø> (-0.01%)` | :arrow_down: |
| #single | `41.81% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19870?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/dtypes/cast.py](https://codecov.io/gh/pandas-dev/pandas/pull/19870/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL2Nhc3QucHk=) | `87.68% <0%> (-0.3%)` | :arrow_down: |
| [pandas/core/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/19870/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvb3BzLnB5) | `96.93% <0%> (+0.16%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19870?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19870?src=pr&el=footer). Last update [8f1dfa7...507cb32](https://codecov.io/gh/pandas-dev/pandas/pull/19870?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
DOC: Implementing single doc building for api docs
State: closed

Same as #19840, using @jorisvandenbossche approach, but using the --single attribute instead of separate functionality for docstrings.


Labels:
name: Docs

Comments:
Thanks, will take a look this weekend. 
Reusing index.rst instead of my temp.rst is a nice idea!

Functionality wise, I think you dropped the multiple docstrings at once?
Yes, but I think it should be easy to restore it with this approach, just wanted to share the idea first, before going into too much detail with the code.

Functionality wise, I don't think it works with this PR, but building the pdf for a single docstring should be "trivial" to have with this method.

I find this method simpler, that's why I wanted to test it, and I prefer it if there is no drawback I missed. For the rest they should be almost the same.
@datapythonista I just worked a bit further on it on the train, and added your commit to my other PR and made some further changes (I basically just added back the copying of existing generated rst file, because those are in some cases more correct). See https://github.com/pandas-dev/pandas/pull/19840
Closing this one in favor of #19840
DOC: Updated links to 2 tutorials in tutorials.rst
State: closed

Two of the links to the [pandas-cookbook](https://github.com/jvns/pandas-cookbook) did not work for version `v0.2` of the documents. Now all links work. Where a version  `v0.2` exists, it links to that version. In the remaining two cases, it now links to version `v0.1` instead of raising the `404: Page not found` error.

Labels:
name: Docs

Comments:
I would rather update the actual links and keep linking to the newer version, as those chapters still exist (the name was a bit changed): http://nbviewer.jupyter.org/github/jvns/pandas-cookbook/tree/master/cookbook/
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19857?src=pr&el=h1) Report
> Merging [#19857](https://codecov.io/gh/pandas-dev/pandas/pull/19857?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ce77b79b97d7e827f50ebd0b7ca292fc2d966cc7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19857/graphs/tree.svg?token=eZ4WkYLtcO&width=650&src=pr&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19857?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19857   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         150      150           
  Lines       48946    48946           
=======================================
  Hits        44858    44858           
  Misses       4088     4088
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.02% <ø> (ø)` | :arrow_up: |
| #single | `41.81% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19857?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19857?src=pr&el=footer). Last update [ce77b79...3f09bc3](https://codecov.io/gh/pandas-dev/pandas/pull/19857?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

I agree @jorisvandenbossche. Thanks for reviewing! I have updated this PR:

- Every link is to `v2.0` now.
- Another chapter has been written (Chapter 9), I have added it.

And I believe this PR is good to go then.
thanks!
Separate TimedeltaIndex mul/div tests
State: closed

Collect DTI/TDI/PI indexing tests ~symmetrically.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timedelta
description: Timedelta data type

Comments:
> Collect DTI/TDI/PI indexing tests ~symmetrically.

@jbrockmendel : Can you clarify what you mean by that?
thanks. pls parameterize / de-dupe on next passes
> Can you clarify what you mean by that?

@gfyoung Each of datetimes/timedeltas/periods have a test_indexing.py file, but they aren't (weren't) consistent about what methods get tested in that file.  This aligned the organization between these three files.
Fix+test DTI/TDI/PI add/sub with ndarray[datetime64/timedelta64]
State: closed

Two notes for upcoming passes:

- the tests are pretty redundant, can be parametrized more tightly once they are all OK.
- catching ndarray[datetime64] separately from DatetimeIndex is kind of weird, but for the moment necesarry.  Once #19835 goes through and re-orders the catching, we'll be able to fix this.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Datetime
description: Datetime data dtype

Comments:
@jbrockmendel : Good direction so far!  Looks you can parametrize now since all the CI is green.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19847?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e97be6f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19847/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19847?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19847   +/-   ##
=========================================
  Coverage          ?   91.69%           
=========================================
  Files             ?      150           
  Lines             ?    48920           
  Branches          ?        0           
=========================================
  Hits              ?    44857           
  Misses            ?     4063           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.07% <100%> (?)` | |
| #single | `41.82% <8.33%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19847?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/timedeltas.py](https://codecov.io/gh/pandas-dev/pandas/pull/19847/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy90aW1lZGVsdGFzLnB5) | `90.99% <100%> (ø)` | |
| [pandas/core/indexes/datetimelike.py](https://codecov.io/gh/pandas-dev/pandas/pull/19847/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZWxpa2UucHk=) | `97.38% <100%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19847?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19847?src=pr&el=footer). Last update [e97be6f...dc67762](https://codecov.io/gh/pandas-dev/pandas/pull/19847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

needs a rebase. does this fix any open issue?
> does this fix any open issue?

Not that I'm aware of.
Here too Travis error is pyarrow import
thanks
DOC: Making doc/source/conf.py pass PEP-8, and added to lint
State: closed

- [X] closes https://github.com/pandas-dev/pandas/issues/19838
- [ ] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
For some reason, travis CI is not starting for this PR. Made an edit to re-trigger it, but still nothing ..
I tested this locally, so merging (so I can rebase https://github.com/pandas-dev/pandas/pull/19840)
Continue porting period_helper; fix leftover asfreq bug
State: closed

In #19650 we fixed a bug with asfreq but missed a weekly-frequency case.  This fixes and tests that.  I'll see if I can cook up a more thorough set of tests to make sure nothing else slips through the cracks.

Other than that, the main thing this does is substitute in `ORD_OFFSET = WEEK_OFFSET * 7 + 4` and `BDAY_OFFSET = 5 * WEEK_OFFSET + 4` and then cleans up some algebra (which is now OK because we are using non-cdivision floordiv and mod).  As a result we get rid of a bunch of calls that add ORD_OFFSET just to subtract it a few lines later.

Gets rid of CamelCase in tslibs.period, moves towards using pandas_datetimestruct directly and getting rid of the redundant `date_info`.

Catches a RuntimeWarning in the tests; closes #19767.


Labels:
name: Period
description: Period data type
name: Clean

Comments:
> easiest prob to remove and do that next pass

sure
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19834?src=pr&el=h1) Report
> Merging [#19834](https://codecov.io/gh/pandas-dev/pandas/pull/19834?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/a6183a2d9c8d1c5a83940e891475ac23682be75a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19834/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19834?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19834   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         150      150           
  Lines       48890    48890           
=======================================
  Hits        44775    44775           
  Misses       4115     4115
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.95% <ø> (ø)` | :arrow_up: |
| #single | `41.78% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19834?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19834?src=pr&el=footer). Last update [a6183a2...3123c0e](https://codecov.io/gh/pandas-dev/pandas/pull/19834?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> I mean the module name itself.

That makes much more sense.  Mind waiting for the next pass since appveyor has a 12hour+ turnaround?
> That makes much more sense. Mind waiting for the next pass since appveyor has a 12hour+ turnaround?

ok
BUG: Fix qcut with NaT present
State: closed

- [X] closes #19768
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Bug
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
lgtm. ping on green.
thanks!
Implement add_offset_array for PeriodIndex
State: closed

This already works for DTI/TDI, this just rounds it out.

There will be some code de-duplication we can do if/when #19744 goes through.


Labels:
name: Period
description: Period data type

Comments:
lgtm. you want to de-dupliate code first?
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19826?src=pr&el=h1) Report
> Merging [#19826](https://codecov.io/gh/pandas-dev/pandas/pull/19826?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/cd1b168cf0fe12d3d850e2f98e3e7164c649f274?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `84.61%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19826/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19826?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19826      +/-   ##
==========================================
+ Coverage   91.58%   91.61%   +0.02%     
==========================================
  Files         150      150              
  Lines       48892    48905      +13     
==========================================
+ Hits        44780    44802      +22     
+ Misses       4112     4103       -9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.98% <84.61%> (+0.02%)` | :arrow_up: |
| #single | `41.78% <23.07%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19826?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/period.py](https://codecov.io/gh/pandas-dev/pandas/pull/19826/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9wZXJpb2QucHk=) | `92.87% <84.61%> (-0.17%)` | :arrow_down: |
| [pandas/core/indexes/datetimelike.py](https://codecov.io/gh/pandas-dev/pandas/pull/19826/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZWxpa2UucHk=) | `96.84% <0%> (-0.22%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19826/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19826?src=pr&el=footer). Last update [cd1b168...a6d9714](https://codecov.io/gh/pandas-dev/pandas/pull/19826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> lgtm. you want to de-dupliate code first?

If we're otherwise ready I'd rather merge and de-dup in the next pass.  My turnaround is faster than the CI's.
back to you :)