CLN: make submodules of pandas.util private
State: closed

xref #13634


Labels:
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=h1) Report
> Merging [#16223](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1f5ecc9a7008ea2a8af6e136a5bd6b410625623d?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16223/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #16223      +/-   ##
==========================================
- Coverage   90.25%   90.24%   -0.02%     
==========================================
  Files         162      164       +2     
  Lines       50879    50894      +15     
==========================================
+ Hits        45922    45927       +5     
- Misses       4957     4967      +10
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.02% <100%> (ø)` | :arrow_up: |
| #single | `40.3% <77.35%> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/\_validators.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX3ZhbGlkYXRvcnMucHk=) | `93.75% <ø> (ø)` | |
| [pandas/io/clipboard/exceptions.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2lvL2NsaXBib2FyZC9leGNlcHRpb25zLnB5) | `71.42% <ø> (ø)` | |
| [pandas/util/\_decorators.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX2RlY29yYXRvcnMucHk=) | `65.3% <ø> (ø)` | |
| [pandas/util/\_print\_versions.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX3ByaW50X3ZlcnNpb25zLnB5) | `15.71% <ø> (ø)` | |
| [pandas/io/clipboard/\_\_init\_\_.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2lvL2NsaXBib2FyZC9fX2luaXRfXy5weQ==) | `73.8% <ø> (ø)` | |
| [pandas/io/formats/terminal.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2lvL2Zvcm1hdHMvdGVybWluYWwucHk=) | `47.82% <ø> (ø)` | |
| [pandas/util/\_doctools.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX2RvY3Rvb2xzLnB5) | `0% <ø> (ø)` | |
| [pandas/compat/pickle\_compat.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2NvbXBhdC9waWNrbGVfY29tcGF0LnB5) | `69.51% <ø> (ø)` | :arrow_up: |
| [pandas/io/clipboard/windows.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2lvL2NsaXBib2FyZC93aW5kb3dzLnB5) | `11.62% <ø> (ø)` | |
| [pandas/io/clipboard/clipboard.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2lvL2NsaXBib2FyZC9jbGlwYm9hcmQucHk=) | `100% <ø> (ø)` | |
| ... and [59 more](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=footer). Last update [1f5ecc9...0245cd7](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=h1) Report
> Merging [#16223](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1f5ecc9a7008ea2a8af6e136a5bd6b410625623d?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16223/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #16223      +/-   ##
==========================================
- Coverage   90.25%   90.23%   -0.02%     
==========================================
  Files         162      164       +2     
  Lines       50879    50894      +15     
==========================================
+ Hits        45922    45926       +4     
- Misses       4957     4968      +11
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.02% <100%> (-0.01%)` | :arrow_down: |
| #single | `40.3% <77.35%> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/clipboard/clipboards.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2lvL2NsaXBib2FyZC9jbGlwYm9hcmRzLnB5) | `26.58% <ø> (ø)` | |
| [pandas/util/\_doctools.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX2RvY3Rvb2xzLnB5) | `0% <ø> (ø)` | |
| [pandas/util/\_decorators.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX2RlY29yYXRvcnMucHk=) | `65.3% <ø> (ø)` | |
| [pandas/util/\_validators.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX3ZhbGlkYXRvcnMucHk=) | `93.75% <ø> (ø)` | |
| [pandas/io/clipboard/exceptions.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2lvL2NsaXBib2FyZC9leGNlcHRpb25zLnB5) | `71.42% <ø> (ø)` | |
| [pandas/io/clipboard/windows.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2lvL2NsaXBib2FyZC93aW5kb3dzLnB5) | `11.62% <ø> (ø)` | |
| [pandas/io/clipboard/clipboard.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2lvL2NsaXBib2FyZC9jbGlwYm9hcmQucHk=) | `100% <ø> (ø)` | |
| [pandas/util/\_print\_versions.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX3ByaW50X3ZlcnNpb25zLnB5) | `15.71% <ø> (ø)` | |
| [pandas/compat/pickle\_compat.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL2NvbXBhdC9waWNrbGVfY29tcGF0LnB5) | `69.51% <ø> (ø)` | :arrow_up: |
| [pandas/util/\_depr\_module.py](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX2RlcHJfbW9kdWxlLnB5) | `79.06% <ø> (ø)` | |
| ... and [59 more](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=footer). Last update [1f5ecc9...0245cd7](https://codecov.io/gh/pandas-dev/pandas/pull/16223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Will have to update the test too.

On Thu, May 4, 2017 at 7:00 AM, Jeff Reback <notifications@github.com>
wrote:

> *@jreback* commented on this pull request.
> ------------------------------
>
> In pandas/tools/hashing.py
> <https://github.com/pandas-dev/pandas/pull/16223#discussion_r114755586>:
>
> > @@ -0,0 +1,18 @@
> +import warnings
> +import sys
> +
> +m = sys.modules['pandas.tools.hashing']
> +for t in ['hash_pandas_object', 'hash_array']:
> +
> +    def outer(t=t):
> +
> +        def wrapper(*args, **kwargs):
> +            from pandas import util
> +            warnings.warn("pandas.tools.hashing is deprecated and will be "
> +                          "removed in a future version, import "
> +                          "from pandas.util",
> +                          FutureWarning, stacklevel=3)
>
> hmm, sure could do that.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/16223#discussion_r114755586>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIhpO2eai0OmpXj4EK5w3RJSmMOecks5r2b35gaJpZM4NQKIU>
> .
>

nore that I didn't move ``pandas.util.testing`` as I suspect this is heavily used like ``pandas.core``. So will need to do something about that later.
> Will have to update the test too.

already did
Damn, this broke geopandas .. (we were apparently already using cache_readonly from utils.decorators)

And this will also break *released* version of dask (not master, as you already did a pr for that)

Any chance in doing a quick fix (0.20.1) before sending out the announcement?
does this not work with the latest released  of dask?
Yes, a clean install of pandas and dask currently does not work. 

Can we somehow 'hide' the conda packages for a moment? (I hided the release on pypi as there are no wheels yet)
we. an tag a post release
i think it's 0.20.0.post i think is valid

also fyi add to the release checklist
pypi upload is very last step (or ok if u immediately hide)
until conda and wheels are there we want to hide