BrandonFors/pandas-github-issues huggingface dataset:
DOC: Add favicon to doc pages
State: closed

This is a suggestion for adding a favicon to the doc pages. Having a favicon makes the pandas browser tabs easier to locate, especially with many open tabs or many pinned tabs.

I used the image from the pandas-dev GitHub organization, cropped some of the bars to make it appear less cluttered in the small favicon format, and resized it to a 32x32 `.ico`-file (the cropped png is attached at the end of this issue).

A few screenshots (pinned and normal tabs, alternating with and without the favicon):

Firefox Quantum
![image](https://user-images.githubusercontent.com/4560057/41294884-19082544-6e27-11e8-90d7-db2992f5d1bd.png)

Chromium
![image](https://user-images.githubusercontent.com/4560057/41294942-40a370e0-6e27-11e8-94a7-29ae473bdc5a.png)

Firefox pre-Quantum
![image](https://user-images.githubusercontent.com/4560057/41295070-9c1c7d22-6e27-11e8-9b4b-04d6e0e9fc57.png)

This is somewhat related to #21376, in that the favicon would change if a new logo is decided upon.

Cropped png
![favicon](https://user-images.githubusercontent.com/4560057/41295398-83b5e16e-6e28-11e8-9daf-353e700e6365.png)


- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21440?src=pr&el=h1) Report
> Merging [#21440](https://codecov.io/gh/pandas-dev/pandas/pull/21440?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/92e9882d723c57b3135b17bded1a6495fec0ebda?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21440/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21440?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21440   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49600    49600           
=======================================
  Hits        45580    45580           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21440?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21440?src=pr&el=footer). Last update [92e9882...c0b1eef](https://codecov.io/gh/pandas-dev/pandas/pull/21440?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
DOC: follow 0.23.1 template for 0.23.2 whatsnew
State: closed

xref https://github.com/pandas-dev/pandas/pull/21433 (@gfyoung we changed some things since the v0.23.1.txt file was added)

Labels:
name: Docs

Comments:
@jorisvandenbossche : Thanks for letting me know!  BTW, is there a place where we have a blank copy of the `whatsnew` template (i.e. so that an old version of it isn't pushed by accident)?
I don't think so, if I add it, I typically copy the last (relevant) one and remove the content
@jorisvandenbossche : Got it.  Thanks for clarifying!
DOC: fix grammar of deprecation message
State: closed


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21421?src=pr&el=h1) Report
> Merging [#21421](https://codecov.io/gh/pandas-dev/pandas/pull/21421?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7000b899038e9d6559ce80d3c018ec0ad5412efe?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21421/graphs/tree.svg?token=eZ4WkYLtcO&height=150&width=650&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21421?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21421   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49596    49596           
=======================================
  Hits        45576    45576           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21421?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/\_decorators.py](https://codecov.io/gh/pandas-dev/pandas/pull/21421/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX2RlY29yYXRvcnMucHk=) | `82.25% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21421?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21421?src=pr&el=footer). Last update [7000b89...405f77b](https://codecov.io/gh/pandas-dev/pandas/pull/21421?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Doc Fixes
State: closed

Closes <#21308> 
Note : Defined Levels section was added in the "Notes" section opposed to "See Also".
Description of "See Also" section [here](https://numpydoc.readthedocs.io/en/latest/format.html), suggests it should really link to other functions etc. 



Labels:
name: Docs
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: MultiIndex

Comments:
Hello @alimcmaster1! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on June 11, 2018 at 22:35 Hours UTC
@jschendel mind reviewing? This should make this functionality abit clearer.
Thanks,

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21415?src=pr&el=h1) Report
> Merging [#21415](https://codecov.io/gh/pandas-dev/pandas/pull/21415?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/415012f4f38ca0cf41717c51e49bd2349cba09a8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21415/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21415?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21415   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49596    49596           
=======================================
  Hits        45576    45576           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21415?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexing.py](https://codecov.io/gh/pandas-dev/pandas/pull/21415/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhpbmcucHk=) | `93.55% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21415?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21415?src=pr&el=footer). Last update [415012f...11fae9b](https://codecov.io/gh/pandas-dev/pandas/pull/21415?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks @gfyoung, added further commit to get rid of my pep8 error causing appveyor CI to fail.
Thanks, LGTM pending @TomAugspurger's comment.
Thanks both, updated as per @TomAugspurger comment. Also spotted a few other places in the codebase were we could use a Spinx ref. Will raise a separate PR.
thanks @alimcmaster1 happy to take more PRs on other patches!
Doc Fixes
State: closed

Minor doc fixes - make casing consistent and tense

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21414?src=pr&el=h1) Report
> Merging [#21414](https://codecov.io/gh/pandas-dev/pandas/pull/21414?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/415012f4f38ca0cf41717c51e49bd2349cba09a8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21414/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21414?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21414   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49596    49596           
=======================================
  Hits        45576    45576           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21414?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/multi.py](https://codecov.io/gh/pandas-dev/pandas/pull/21414/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9tdWx0aS5weQ==) | `94.99% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21414?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21414?src=pr&el=footer). Last update [415012f...39f7ef8](https://codecov.io/gh/pandas-dev/pandas/pull/21414?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks
Fix 20599 overflow error  when int in json is too large
State: closed

- [ ] closes #20599
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Hello @ssikdar1! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on June 10, 2018 at 15:21 Hours UTC
see my comments in the issue
Two tests didn't properly assert an exception was raised. Fixed.
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO CSV
description: read_csv, to_csv

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21409?src=pr&el=h1) Report
> Merging [#21409](https://codecov.io/gh/pandas-dev/pandas/pull/21409?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ffffa5cbb6134d0b6c6e49d460e5735bbdd6d5a2?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21409/graphs/tree.svg?width=650&height=150&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21409?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21409      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files         153      153              
  Lines       49600    49596       -4     
==========================================
- Hits        45580    45576       -4     
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (-0.01%)` | :arrow_down: |
| #single | `41.86% <ø> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21409?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/21409/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.61% <0%> (-0.01%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/21409/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.22% <0%> (-0.01%)` | :arrow_down: |
| [pandas/core/reshape/pivot.py](https://codecov.io/gh/pandas-dev/pandas/pull/21409/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzaGFwZS9waXZvdC5weQ==) | `97.03% <0%> (ø)` | :arrow_up: |
| [pandas/core/indexing.py](https://codecov.io/gh/pandas-dev/pandas/pull/21409/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhpbmcucHk=) | `93.55% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21409?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21409?src=pr&el=footer). Last update [ffffa5c...ef25e39](https://codecov.io/gh/pandas-dev/pandas/pull/21409?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @akaihola; slight change to use pytest ids, otherwise nice catch! keep em coming!
BUG : read_json with table='orient' causes unexpected type coercion 
State: closed

BUG : read_json with table='orient' causes unexpected type coercion #21345

- [x] closes #21345
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Changed `.astype` parameters according to the comments. Should work now


Labels:
name: IO JSON
description: read_json, to_json, json_normalize

Comments:
@WillAyd @pyryjook  @jreback  please have a look and kindly mention any drawback on which I may need to work on in this patch
@uds5501 : 
* Looks like you have test failures...
* Also add a `whatsnew` + new test
I mentioned this in one of the other threads but I don't think we should even be calling `_try_convert_data` at all since the schema explicitly tells us what the types are. 

Can you check the call stack from this and see if there's a way to not even call this method at all?
@WillAyd  Good point there.  I will try and make a work around here
Closing this for now, will try and create a workaround locally first. Till then, if anyone else is interested in picking up this issue, be my guest
BUG: Construct Timestamp with tz correctly near DST border
State: closed

closes #19970
closes #20854
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

So I _think_ the reason we need to convert a `Timestamp` to `datetime` branch is because of how `Timestamp` behave with `normalize`  explained by this https://github.com/pandas-dev/pandas/pull/18618#issuecomment-352271183

Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Timezones
description: Timezone data dtype

Comments:
Hello @mroeschke! Thanks for updating the PR.









Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on June 13, 2018 at 03:17 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21407?src=pr&el=h1) Report
> Merging [#21407](https://codecov.io/gh/pandas-dev/pandas/pull/21407?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ab668b0a56a9f2aee959bde787e9a0af4068d7a7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21407/graphs/tree.svg?height=150&src=pr&token=eZ4WkYLtcO&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/21407?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21407   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49600    49600           
=======================================
  Hits        45580    45580           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21407?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21407?src=pr&el=footer). Last update [ab668b0...ae9dc7b](https://codecov.io/gh/pandas-dev/pandas/pull/21407?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @mroeschke nice clean up!

can you review any outstanding issues that involve dst. this may go a long way towards solving them (if so, then pls PR for tests).
parametrize tests, unify repeated tests
State: closed

There's more to do, but the diff is already pretty big as it is.

There are a handful of test methods that are defined in 5-6 test classes.  By moving those to the base class we a) get rid of duplicate code and b) run the tests for all (well, most) `DateOffset` subclasses.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Frequency
description: DateOffsets
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21405?src=pr&el=h1) Report
> Merging [#21405](https://codecov.io/gh/pandas-dev/pandas/pull/21405?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ab668b0a56a9f2aee959bde787e9a0af4068d7a7?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21405/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21405?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21405      +/-   ##
==========================================
+ Coverage   91.89%    91.9%   +<.01%     
==========================================
  Files         153      153              
  Lines       49600    49600              
==========================================
+ Hits        45580    45583       +3     
+ Misses       4020     4017       -3
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.89% <ø> (+0.03%)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21405?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/21405/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `97.24% <0%> (+0.24%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21405?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21405?src=pr&el=footer). Last update [ab668b0...d378120](https://codecov.io/gh/pandas-dev/pandas/pull/21405?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @jbrockmendel
fix DateOffset eq to depend on normalize attr
State: closed

This has a bullet point in #18854 but doesn't appear to have its own issue.

Current:
```
now = pd.Timestamp.now()
off = pd.offsets.Week(n=1, normalize=False)
normed = pd.offsets.Week(n=1, normalize=True)

>>> now + off == now + normed
False
>>> off == normed  # PR changes this comparison to False
True
```

- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21404?src=pr&el=h1) Report
> Merging [#21404](https://codecov.io/gh/pandas-dev/pandas/pull/21404?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/576d5c6b76e039a411a7cc4c0de29813e2de0149?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21404/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21404?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21404   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         153      153           
  Lines       49606    49606           
=======================================
  Hits        45589    45589           
  Misses       4017     4017
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <100%> (ø)` | :arrow_up: |
| #single | `41.89% <100%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21404?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/21404/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `97.24% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21404?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21404?src=pr&el=footer). Last update [576d5c6...b902cb1](https://codecov.io/gh/pandas-dev/pandas/pull/21404?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> This has a bullet point in #18854 but doesn't appear to have its own issue.

@jbrockmendel : How about this one here: https://github.com/pandas-dev/pandas/issues/17689?  It might be a little familiar to you. 😉 
@jreback : Everything is green here.
I merged something which now causes a conflict here. @jbrockmendel can you rebase. @gfyoung can merge on green.
Thanks @jbrockmendel !