BrandonFors/pandas-github-issues huggingface dataset:
DOC GH15643 Removed pytest-xdist from requirements_dev.txt file
State: closed

 - [ x] closes #15643
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [ ] whatsnew entry


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15646?src=pr&el=h1) Report
> Merging [#15646](https://codecov.io/gh/pandas-dev/pandas/pull/15646?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/a703abcb6328b105bfa0b30895b8893f7f52f88f?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15646      +/-   ##
==========================================
- Coverage   91.02%      91%   -0.03%     
==========================================
  Files         143      143              
  Lines       49324    49324              
==========================================
- Hits        44898    44886      -12     
- Misses       4426     4438      +12
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15646?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/a703abcb6328b105bfa0b30895b8893f7f52f88f...4183f7489cb16230a1baa31d5739c84e42b5e3ed?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :x: |
| [pandas/tools/merge.py](https://codecov.io/gh/pandas-dev/pandas/compare/a703abcb6328b105bfa0b30895b8893f7f52f88f...4183f7489cb16230a1baa31d5739c84e42b5e3ed?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL21lcmdlLnB5) | `91.76% <0%> (-0.35%)` | :x: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/a703abcb6328b105bfa0b30895b8893f7f52f88f...4183f7489cb16230a1baa31d5739c84e42b5e3ed?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `90.96% <0%> (-0.34%)` | :x: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/a703abcb6328b105bfa0b30895b8893f7f52f88f...4183f7489cb16230a1baa31d5739c84e42b5e3ed?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.87% <0%> (-0.1%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15646?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15646?src=pr&el=footer). Last update [a703abc...4183f74](https://codecov.io/gh/pandas-dev/pandas/compare/a703abcb6328b105bfa0b30895b8893f7f52f88f...4183f7489cb16230a1baa31d5739c84e42b5e3ed?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
thanks!
BUG: Incorrect value updating for groupby.cummin/max (#15635)
State: closed

 - [x] closes #15635
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 
Nice catch @adbull. The original implementation was incorrectly setting the incorrect cummin/max value.

Labels:
name: Bug
name: Groupby

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15642?src=pr&el=h1) Report
> Merging [#15642](https://codecov.io/gh/pandas-dev/pandas/pull/15642?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/470c3276479925a198f38f9c0aacd745ef3a64bd?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15642      +/-   ##
==========================================
- Coverage   91.02%      91%   -0.03%     
==========================================
  Files         143      143              
  Lines       49324    49324              
==========================================
- Hits        44898    44886      -12     
- Misses       4426     4438      +12
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15642?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...b92b81a1ba4e89ce1b5848fd13ac4522f5d6bb4d?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :x: |
| [pandas/tools/merge.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...b92b81a1ba4e89ce1b5848fd13ac4522f5d6bb4d?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL21lcmdlLnB5) | `91.76% <0%> (-0.35%)` | :x: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...b92b81a1ba4e89ce1b5848fd13ac4522f5d6bb4d?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `90.96% <0%> (-0.34%)` | :x: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...b92b81a1ba4e89ce1b5848fd13ac4522f5d6bb4d?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.87% <0%> (-0.1%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15642?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15642?src=pr&el=footer). Last update [470c327...b92b81a](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...b92b81a1ba4e89ce1b5848fd13ac4522f5d6bb4d?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
thanks!
DOC: increase recursion limit on sphinx builds
State: closed

xref https://github.com/pandas-dev/pandas/pull/15637#issuecomment-285558452

hopefully should eliminate the non-deterministic pickle errors in doc-building :<

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15641?src=pr&el=h1) Report
> Merging [#15641](https://codecov.io/gh/pandas-dev/pandas/pull/15641?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/470c3276479925a198f38f9c0aacd745ef3a64bd?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15641      +/-   ##
==========================================
- Coverage   91.02%      91%   -0.03%     
==========================================
  Files         143      143              
  Lines       49324    49324              
==========================================
- Hits        44898    44887      -11     
- Misses       4426     4437      +11
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15641?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...3ac9d793845f34e74f87471b1b11fc1e1395af34?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :x: |
| [pandas/tools/merge.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...3ac9d793845f34e74f87471b1b11fc1e1395af34?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL21lcmdlLnB5) | `91.76% <0%> (-0.35%)` | :x: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...3ac9d793845f34e74f87471b1b11fc1e1395af34?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.87% <0%> (-0.1%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15641?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15641?src=pr&el=footer). Last update [470c327...3ac9d79](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...3ac9d793845f34e74f87471b1b11fc1e1395af34?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Great! That was indeed the error I saw locally (so not related to our pickle changes). I just didn't see it anymore afterwards, and on travis in the PR, but apparently it is not each time, or so.
DEPR: remove more .ix warnings from tests
State: closed

I think we had a filter somewhere that simply turned these off (in another test module)

Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15638?src=pr&el=h1) Report
> Merging [#15638](https://codecov.io/gh/pandas-dev/pandas/pull/15638?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/470c3276479925a198f38f9c0aacd745ef3a64bd?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15638      +/-   ##
==========================================
- Coverage   91.02%   90.99%   -0.03%     
==========================================
  Files         143      143              
  Lines       49324    49324              
==========================================
- Hits        44898    44884      -14     
- Misses       4426     4440      +14
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15638?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...8b82bd6e65288e03de8cbc92d7d5d1d998dfe10c?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :x: |
| [pandas/tools/merge.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...8b82bd6e65288e03de8cbc92d7d5d1d998dfe10c?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL21lcmdlLnB5) | `91.76% <0%> (-0.35%)` | :x: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...8b82bd6e65288e03de8cbc92d7d5d1d998dfe10c?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `90.96% <0%> (-0.34%)` | :x: |
| [pandas/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...8b82bd6e65288e03de8cbc92d7d5d1d998dfe10c?src=pr&el=tree#diff-cGFuZGFzL2luZGV4ZXMvYmFzZS5weQ==) | `96.1% <0%> (-0.12%)` | :x: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...8b82bd6e65288e03de8cbc92d7d5d1d998dfe10c?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.87% <0%> (-0.1%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15638?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15638?src=pr&el=footer). Last update [470c327...8b82bd6](https://codecov.io/gh/pandas-dev/pandas/compare/470c3276479925a198f38f9c0aacd745ef3a64bd...8b82bd6e65288e03de8cbc92d7d5d1d998dfe10c?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
DOC: remove latex and parallel building
State: closed


Labels:
name: Docs

Comments:
This seemed to work on my fork on travis, but not sure why removing the parallel would fix it.
yep this looks good. fyi

not exactly sure what is wrong here :>
```
/tmp/doc/source/io.rst:3097: ERROR: Error in "ipython" directive:
invalid option block.
.. ipython:: python
   :suppress:
   import os
   os.remove("data.pkl.compress")
   os.remove("data.pkl.xz")
   os.remove("data.pkl.gz")
   os.remove("s1.pkl.bz2")
/tmp/doc/source/overview.rst:120: WARNING: Include file '/tmp/LICENSE' not found or reading it failed
source/whatsnew/v0.20.0.txt:141: ERROR: Error in "ipython" directive:
invalid option block.
```
needs a white line, pushed a fix to this branch
I restarted a couple of times: https://travis-ci.org/pandas-dev/pandas/jobs/209555204

maybe: https://groups.google.com/forum/#!msg/sphinx-dev/MtRf64eGtv4/aOa7FdxkAgAJ

here's a fix (increase stack :>)
```
--- a/docs/users_guide/conf.py
+++ b/docs/users_guide/conf.py
@@ -147,6 +147,8 @@ def parse_flag(env, sig, signode):
 def setup(app):
     from sphinx.util.docfields import Field, TypedField
 
+    increase_python_stack()
+
     # the :ghci-cmd: directive used in ghci.rst
     app.add_object_type('ghci-cmd', 'ghci-cmd',
                         parse_node=parse_ghci_cmd,
@@ -171,3 +173,11 @@ def setup(app):
                             Field('since', label='Introduced in GHC version', names=['since']),
                             Field('static')
                         ])
+
+def increase_python_stack():
+    # Workaround sphinx-build recursion limit overflow:
+    # pickle.dump(doctree, f, pickle.HIGHEST_PROTOCOL)
+    #  RuntimeError: maximum recursion depth exceeded while pickling an object
+    #
+    # Default python allows recursion depth of 1000 calls.
+    sys.setrecursionlimit(10000)
```
https://github.com/sphinx-doc/sphinx/pull/2325/files is a better view on this.
DOC: make it possible to run doctests
State: closed

This adds a small entry in the conftest.py file, which makes it possible to run doctests with eg

```
pytest --doctests-module pandas/core/series.py
```

We are far from being able to run them all without error, and if we would want that is even another question (it may be too much small details to pay attention to), but this let's you at least run specific doctests.

Labels:
name: Docs

Comments:
@jorisvandenbossche this is great. I would propose you add a script ``ci/script_doctests.py``, add it in ``.travis.yml`` after ``script_multi.py`` and you just put the actual testing command / commands as we add things.

So then as things are fixed can be added there w/o impacting anything else.
if you want to get really fancy we can add an env variable DOC_TESTS to only run them on selective builds (e.g. 3.6/2.7).
> We are far from being able to run them all without error, and if we would want that is even another question (it may be too much small details to pay attention to), but this let's you at least run specific doctests.

If we can automate the running, why not. Having manually run tests is like not having tests :>
> If we can automate the running, why not.

Because we may find it is too much work to keep it working. The doctesting ensures the example are correct (which is important!), but it is also quite nitpicky and it has to be exactly correct. 
https://github.com/pandas-dev/pandas/pull/15625 is an example of adjustments needed to make them pass (but that PR also fixed an actual error in the example, apart from more stylistic changes). So might be good to first get some experience with to see how it goes.

ok. well if they are fixed in a particular file we should then test them to *keep* them working :>
Yes, we can certainly add that when certain files pass
DOC: resolved mistakes in examples series
State: closed

Adjusted some docstring examples.


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15625?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@2229c26`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.


```diff
@@            Coverage Diff            @@
##             master   #15625   +/-   ##
=========================================
  Coverage          ?   90.99%           
=========================================
  Files             ?      143           
  Lines             ?    49306           
  Branches          ?        0           
=========================================
  Hits              ?    44868           
  Misses            ?     4438           
  Partials          ?        0
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15625?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/compare/2229c26442ea28b7d69819e0b52b9bbc45afae4a...32b0dc66a1d34a6a9f36ef31d429f4b7008f9314?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `96.25% <ø> (ø)` | |
| [pandas/core/series.py](https://codecov.io/gh/pandas-dev/pandas/compare/2229c26442ea28b7d69819e0b52b9bbc45afae4a...32b0dc66a1d34a6a9f36ef31d429f4b7008f9314?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc2VyaWVzLnB5) | `94.91% <ø> (ø)` | |
| [pandas/conftest.py](https://codecov.io/gh/pandas-dev/pandas/compare/2229c26442ea28b7d69819e0b52b9bbc45afae4a...32b0dc66a1d34a6a9f36ef31d429f4b7008f9314?src=pr&el=tree#diff-cGFuZGFzL2NvbmZ0ZXN0LnB5) | `94.11% <100%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15625?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15625?src=pr&el=footer). Last update [2229c26...46d362e](https://codecov.io/gh/pandas-dev/pandas/compare/2229c26442ea28b7d69819e0b52b9bbc45afae4a...46d362e1dabafaefdf9d4936f40efe9ecd5a53ad?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
@MichielStock There were some PEP8 issues (lines too long, we test for that on Travis), but fixed those before merging.

Thanks!
DOC: fix link to offset strings in resample method
State: closed

 - [ ] closes #xxxx

The link to offset strings was not rendered correctly, I've made a sections ```Notes```, and placed the link there.
Part of issue #14843 

Labels:
name: Docs
name: Resample
description: resample method

Comments:
hmm, does this fix the link rendering? can you build locally and see
@jreback yes it does!
See attached screencap
![screenshot - 080317 - 19 38 20](https://cloud.githubusercontent.com/assets/10461030/23718204/e115b5a8-0436-11e7-9e9b-beac5dd8d3f2.png)

@DaanVanHauwermeiren Thanks!
Parallelize doc build
State: closed

closes #15591 

https://travis-ci.org/jreback/pandas/builds/208594369

a couple of minutes faster with -j 2.

fixes some deprecated use of ``pd.Term``.

Note there is another error in HDFStore build, though I can't repro it locally.

Labels:
name: Docs

Comments:
Ideally, I think we should make it possible to pass this to `python make.py html` to specify it (for local usage)
DOC: remove wakari.io section
State: closed

 - [x] closes #15595
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [ ] whatsnew entry


Labels:
name: Docs

Comments:
thanks!
@jreback Thanks for all of your work on pandas!!
hahha @mandel01 thanks!

lots more coming soon!
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15596?src=pr&el=h1) Report
> Merging [#15596](https://codecov.io/gh/pandas-dev/pandas/pull/15596?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/0bf45320440e0d477f6b31ac8825f34e8212f152?src=pr&el=desc) will **decrease** coverage by `-0.03%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15596      +/-   ##
==========================================
- Coverage   91.06%   91.03%   -0.03%     
==========================================
  Files         137      137              
  Lines       49307    49307              
==========================================
- Hits        44900    44889      -11     
- Misses       4407     4418      +11
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15596?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/0bf45320440e0d477f6b31ac8825f34e8212f152...4aded31fe71cf87a63548f269d0f1f0cb973cc67?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :x: |
| [pandas/tools/merge.py](https://codecov.io/gh/pandas-dev/pandas/compare/0bf45320440e0d477f6b31ac8825f34e8212f152...4aded31fe71cf87a63548f269d0f1f0cb973cc67?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL21lcmdlLnB5) | `91.78% <0%> (-0.35%)` | :x: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/0bf45320440e0d477f6b31ac8825f34e8212f152...4aded31fe71cf87a63548f269d0f1f0cb973cc67?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.83% <0%> (-0.1%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15596?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15596?src=pr&el=footer). Last update [0bf4532...4aded31](https://codecov.io/gh/pandas-dev/pandas/compare/0bf45320440e0d477f6b31ac8825f34e8212f152...4aded31fe71cf87a63548f269d0f1f0cb973cc67?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Moved freeze_panes validation to io/excel.py (#15160)
State: closed

 - follow up to #15160 
 - [x] tests added / passed - Existing test suite passed
 - [x] passes ``git diff upstream/master | flake8 --diff``



Labels:
name: IO Excel
description: read_excel, to_excel
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15592?src=pr&el=h1) Report
> Merging [#15592](https://codecov.io/gh/pandas-dev/pandas/pull/15592?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/0bf45320440e0d477f6b31ac8825f34e8212f152?src=pr&el=desc) will **decrease** coverage by `-0.03%`.
> The diff coverage is `88.88%`.


```diff
@@            Coverage Diff             @@
##           master   #15592      +/-   ##
==========================================
- Coverage   91.06%   91.03%   -0.03%     
==========================================
  Files         137      137              
  Lines       49307    49307              
==========================================
- Hits        44900    44889      -11     
- Misses       4407     4418      +11
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15592?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/0bf45320440e0d477f6b31ac8825f34e8212f152...81cb86f00b15df15e9b5c389e838c5cc4d6761e0?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.87% <ø> (-0.06%)` | :x: |
| [pandas/io/excel.py](https://codecov.io/gh/pandas-dev/pandas/compare/0bf45320440e0d477f6b31ac8825f34e8212f152...81cb86f00b15df15e9b5c389e838c5cc4d6761e0?src=pr&el=tree#diff-cGFuZGFzL2lvL2V4Y2VsLnB5) | `79.67% <88.88%> (+0.03%)` | :white_check_mark: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/0bf45320440e0d477f6b31ac8825f34e8212f152...81cb86f00b15df15e9b5c389e838c5cc4d6761e0?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :x: |
| [pandas/tools/merge.py](https://codecov.io/gh/pandas-dev/pandas/compare/0bf45320440e0d477f6b31ac8825f34e8212f152...81cb86f00b15df15e9b5c389e838c5cc4d6761e0?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL21lcmdlLnB5) | `91.78% <0%> (-0.35%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15592?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15592?src=pr&el=footer). Last update [0bf4532...81cb86f](https://codecov.io/gh/pandas-dev/pandas/compare/0bf45320440e0d477f6b31ac8825f34e8212f152...81cb86f00b15df15e9b5c389e838c5cc4d6761e0?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
thanks @jeffcarey