BrandonFors/pandas-github-issues huggingface dataset:
BUG: Accept unicode quotechars again in pd.read_csv
State: closed

Title is self-explanatory.  Affects Python 2.x only.  Closes #14477.


Labels:
name: Bug
name: IO CSV
description: read_csv, to_csv

Comments:
@gfyoung I think there is already `compat.text_type` that does this (capturing unicode/str for py2/py3)

@jorisvandenbossche : Ah, good catch.  Fixed.

@jorisvandenbossche : Could you cancel Travis builds <a href="https://travis-ci.org/pandas-dev/pandas/builds/170552837">#170552837</a> and <a href="https://travis-ci.org/pandas-dev/pandas/builds/170586342">#170586342</a>?  Thanks!

## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14492?src=pr) is 85.26% (diff: 100%)

> Merging [#14492](https://codecov.io/gh/pandas-dev/pandas/pull/14492?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14492   diff @@
==========================================
  Files           140        140          
  Lines         50670      50672     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43205      43207     +2   
  Misses         7465       7465          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [e3d943d...ec9f59a](https://codecov.io/gh/pandas-dev/pandas/compare/e3d943d1876e8914036e9c323f1876e52da34a04...ec9f59a0feb13ae2e1a47aeda3f07eef18b27be9?src=pr)

@jorisvandenbossche : Also <a href="https://travis-ci.org/pandas-dev/pandas/builds/170586654">#170586654</a> if possible, as I figured out what was causing the 2.7 machine to fail.  The 3.4 failure is unrelated.

looks fine to me; try with an actual unicode quotechar though, e.g

```
In [1]: "\u0394"
Out[1]: 'Δ'
```

Actual unicode quotechar do actually fail (see the tests). But I don't think we need to support actual unicode quotechars, just supporting ascii chars that are passed as unicode is enough IMO.

@jorisvandenbossche : Agreed.  The current failure is because of Python 2.x.  I modified test so that last check is only done on Python 3.x

lgtm. thanks.

@gfyoung thanks!
BUG: fix empty intersection of RangeIndex (GH14364)
State: closed

closes #14364


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14481?src=pr) is 85.25% (diff: 100%)

> Merging [#14481](https://codecov.io/gh/pandas-dev/pandas/pull/14481?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14481   diff @@
==========================================
  Files           140        140          
  Lines         50655      50657     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43185      43190     +5   
+ Misses         7470       7467     -3   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [233d51d...823e83d](https://codecov.io/gh/pandas-dev/pandas/compare/233d51dd099f590379bd9144c40a61f6785b2b57...823e83d7062d7f5eb68ce6fb91d2eea2b41a3f9d?src=pr)

lgtm

thanks!
BLD: don't require cython on sdist install
State: closed

- [x] closes #14204
- [x] tests not needed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

We could just make a cython a build-time requirement, but given we already create a sdists with `.c` files, probably makes sense to continue to support it.

I tested this locally, applying this patch on the latest source [release](https://pypi.python.org/packages/58/2c/62ba69f6cf16693fc341df084e8262ebb89f678ddc534164099fc7ddeb0b/pandas-0.19.0.zip#md5=6243f3abeaed035720bd77237bdade53) and it installed into a an environment without cython fine.


Labels:
name: Build
description: Library building on various platforms

Comments:
Thanks! Looks good to me, it's an easy fix to support installing without cython, so would keep doing that

## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14475?src=pr) is 85.25% (diff: 100%)

> Merging [#14475](https://codecov.io/gh/pandas-dev/pandas/pull/14475?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #14475   diff @@
==========================================
  Files           140        140          
  Lines         50655      50655          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43185      43185          
  Misses         7470       7470          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [233d51d...8d93366](https://codecov.io/gh/pandas-dev/pandas/compare/233d51dd099f590379bd9144c40a61f6785b2b57...8d93366d381454ddad02142bb097a30e0cc5c98a?src=pr)

thanks!
ERR: Fix GH13139: better error message on invalid pd.eval and df.query input
State: closed

- [x] closes #13139 
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Added test case to check for invalid input(empy string) on pd.eval('') and df.query('').
Used existing helper function(_check_expression) 


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14473?src=pr) is 85.26% (diff: 100%)

> Merging [#14473](https://codecov.io/gh/pandas-dev/pandas/pull/14473?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14473   diff @@
==========================================
  Files           140        140          
  Lines         50640      50641     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43175      43178     +3   
+ Misses         7465       7463     -2   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [170d13a...9a5c55f](https://codecov.io/gh/pandas-dev/pandas/compare/170d13ae3b41cb4793554237fdf3ffc0d60aec1d...9a5c55fa8d66e342f04dd57e00116d89dcd4a51a?src=pr)

just a doc-comment. pls push ; ping when green.

thanks!
BUG: downcast = 'unsigend' on 0 would would not downcast to unsigned.
State: closed

Continuation of #14412
- [ ] closes #14401
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

Once again I had some very bizarre issues with git. Hope this does it this time.


Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
@verhalenn For future reference, it is normally never needed to open a new PR to fix git issues. You can just clean it up locally and force push.

BTW, you have some failing tests.

No when I forced pushed it it closed the pull request for some reason. Usually that would happen if I were to delete the branch and then force push but that wasn't the case. I'll look into the error.

## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14472?src=pr) is 85.25% (diff: 100%)

> No coverage report found for **master** at 2e77536.
> 
> Powered by [Codecov](https://codecov.io?src=pr). Last update [2e77536...8db827a](https://codecov.io/gh/pandas-dev/pandas/compare/2e77536bdf90ef20fefd4eab751447918e07668f...8db827a299f38dc2e3b8bf8d749b33ec60d53661?src=pr)

thanks!

@jreback : I think this commit is breaking `master` right now.

reverted: https://github.com/pandas-dev/pandas/commit/d1d75d7fcb6b5d090cf96d328d0136c3959a82b8

@verhalenn if you can re-submit this PR would be great.

First thing tomorrow morning. I was kind of surprised you closed it when you did. The lint should be an easy fix but the downcast test will take a little extra time.
DOC: update readme for repo move
State: closed


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14470?src=pr) is 85.26% (diff: 100%)

> Merging [#14470](https://codecov.io/gh/pandas-dev/pandas/pull/14470?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #14470   diff @@
==========================================
  Files           140        140          
  Lines         50640      50640          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43176      43176          
  Misses         7464       7464          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [794f792...5413e2b](https://codecov.io/gh/pandas-dev/pandas/compare/794f79295484298525dbc8dd3b8ab251ad065e61...5413e2bee095b476488f83944090fd22175cc530?src=pr)
MAINT: Use check_output when merging.
State: closed

Since we don't support Python 2.6 anymore, the `check_output` method from `subprocess` is
at our disposal.

Follow-up to #14447.

xref <a href="https://github.com/pandas-dev/pandas/issues/14439#issuecomment-254522055"> #14439 (comment)</a>


Labels:
name: Build
description: Library building on various platforms

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14465?src=pr) is 85.25% (diff: 100%)

> Merging [#14465](https://codecov.io/gh/pandas-dev/pandas/pull/14465?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14465   diff @@
==========================================
  Files           140        140          
  Lines         50655      50655          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43185      43186     +1   
+ Misses         7470       7469     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [233d51d...e267d2b](https://codecov.io/gh/pandas-dev/pandas/compare/233d51dd099f590379bd9144c40a61f6785b2b57...e267d2ba0a5bca30bc36198f70b592f83f6d2a17?src=pr)

thanks!
DOC: fix pd.to_datetime documentation (issue #14448)
State: closed

Dupe of #14452
- [x] closes #14448
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs
name: Datetime
description: Datetime data dtype
name: Duplicate Report
description: Duplicate issue or pull request

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14456?src=pr) is 85.25% (diff: 100%)

> Merging [#14456](https://codecov.io/gh/pandas-dev/pandas/pull/14456?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14456   diff @@
==========================================
  Files           140        140          
  Lines         50631      50631          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43166      43167     +1   
+ Misses         7465       7464     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [c31ea34...5890a0d](https://codecov.io/gh/pandas-dev/pandas/compare/c31ea341747ac40d83e64d00bac179548e4b716e...5890a0db44e6b07c2033deca0d6a980f6417300f?src=pr)

Ah, it's dupe with #14452. Appreciate your review on #14452.
ERR: qcut uniquess checking
State: closed

- [x] closes #7751
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

Add option to drop non-unique bins.


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14455?src=pr) is 85.25% (diff: 75.00%)
> Merging [#14455](https://codecov.io/gh/pandas-dev/pandas/pull/14455?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14455   diff @@
==========================================
  Files           140        140          
  Lines         50631      50633     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43166      43168     +2   
  Misses         7465       7465          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [c31ea34...4450884](https://codecov.io/gh/pandas-dev/pandas/compare/c31ea341747ac40d83e64d00bac179548e4b716e...445088448f1f33ec068839575a17c9bbc1ebdd8e?src=pr)
Thx for the PR. Can u add tests and whatsnew?

looks pretty good. some more error checking formatting is needed. pls add a whatsnew note in 0.19.1, make an Enhancements changes section. Be sure to say that the default is the existing behavior.

pls add some tests. use the example from the orginal issue exercising both options to `duplicates` and pass some invalid values as well (and assert those raise)

Thanks for the feedback -- this is my first PR on an open source project -- will make the changes and resubmit tomorrow. Had some trouble building my branch on Windows.

contributing docs are [here](http://pandas.pydata.org/pandas-docs/stable/contributing.html); there is a section on creating a windows env.

can you rebase
@ashishsingal1 something went wrong with your rebase. Can you do:

```
git fetch upstream
git rebase upstream/master
git push -f
```

That should normally solve it
Trouble rebasing, going to start over with a new PR.
BUG: Catch overflow in both directions for checked add
State: closed

Port of #14324 after project name change.


Labels:
name: Bug
name: Timedelta
description: Timedelta data type

Comments:
@jreback : Doesn't seem like Appveyor is picking up this PR.

## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14453?src=pr) is 85.25% (diff: 68.75%)

> Merging [#14453](https://codecov.io/gh/pandas-dev/pandas/pull/14453?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14453   diff @@
==========================================
  Files           140        140          
  Lines         50640      50654    +14   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43175      43184     +9   
- Misses         7465       7470     +5   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [65362aa...2dc49e4](https://codecov.io/gh/pandas-dev/pandas/compare/65362aa4f06f01efdc20ca487c1c3c1f090613ee...2dc49e46f0251213bb724b0968af7d51792134fc?src=pr)

lgtm. can you add a whatsnew note. put in a new API Changes section in 0.19.1

Please no api change section for 0.19.1. We put it in the bug section for 0.19.0, so then can put it here there as well I think (we maybe should have put it in the api changes section for 0.19.0 ..)

bug fix section is fine

@gfyoung Thanks!

@jreback , @jorisvandenbossche : So while it's good that we're catching underflow, when I try to integrate this check with tdi + tdi OR tdi + td, we run into issues:

``` python
>>> import pandas as pd
>>>
>>> tdi = pd.TimedeltaIndex([pd.NaT])
>>> td = pd.Timedelta('1 days')
>>>
>>> tdi - td   # Should return TimedeltaIndex([pd.NaT])
...
OverflowError: Overflow in int64 addition
```

This is because we are doing the checked add with the `asi8` values, meaning that `NaT` becomes `np.iinfo(np.int64).min`, so the subtraction underflows as expected but not as we want.  Not sure what the best way is to NOT do checked add for those elements whose value is `NaN`.  Thoughts?

Additionally mask for that in the checking code?

Hmmm...I suppose, though that will impact performance again :cry: .  I can give it a shot anyways and see what happens.
DOC:updated docstring in .to_datetime()
State: closed

- [x] closes #14448 
- [ ] tests added / passed
- [ ] passes git diff upstream/master | flake8 --diff
- [ ] whatsnew entry


Labels:
name: Docs
name: Datetime
description: Datetime data dtype

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14452?src=pr) is 85.25% (diff: 100%)

> Merging [#14452](https://codecov.io/gh/pandas-dev/pandas/pull/14452?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14452   diff @@
==========================================
  Files           140        140          
  Lines         50631      50655    +24   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43166      43185    +19   
- Misses         7465       7470     +5   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [c31ea34...3aa78cf](https://codecov.io/gh/pandas-dev/pandas/compare/c31ea341747ac40d83e64d00bac179548e4b716e...3aa78cf021ab0ca3680a0d42a9796c6e4a86b425?src=pr)

- The [timestamp limitation](http://pandas-docs.github.io/pandas-docs-travis/timeseries.html#timestamp-limitations) is that "the timespan that can be represented using a 64-bit integer is limited to approximately 584 years". 
- So the default behavior (from version 0.17.0) is `errors='raise'` i.e. when a date does not meet timestamp limitations, an exception will be raised. 
  Setting `errors='ignore'` will simply return the original input instead of raising any exception.

@sinhrks Can this be merged?

@jreback Can this be merged? Please let me know if there are any changes to be added.

thanks!
Type levels as list in _make_concat_multiindex (fixes #14438)
State: closed

- [x] closes #14438
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14449?src=pr) is 85.25% (diff: 100%)

> Merging [#14449](https://codecov.io/gh/pandas-dev/pandas/pull/14449?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #14449   diff @@
==========================================
  Files           140        140          
  Lines         50631      50631          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43166      43166          
  Misses         7465       7465          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [c31ea34...57a2ec8](https://codecov.io/gh/pandas-dev/pandas/compare/c31ea341747ac40d83e64d00bac179548e4b716e...57a2ec8f719892ee1ff265e55ac53a76d8a36bdf?src=pr)

minor change, ping when green.

yep, will do!

@jreback done!

thanks @dubourg
BUG: Rename pydata to pandas-dev in merge-pr.py
State: closed

Title is self-explanatory.  Closes #14439.


Labels:
name: CI
description: Continuous Integration

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14447?src=pr) is 85.25% (diff: 100%)

> Merging [#14447](https://codecov.io/gh/pandas-dev/pandas/pull/14447?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #14447   diff @@
==========================================
  Files           140        140          
  Lines         50631      50631          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43167      43167          
  Misses         7464       7464          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [7cad3f1...342093e](https://codecov.io/gh/pandas-dev/pandas/compare/7cad3f16bccd1d4702ef9d038b1ee0db33b9bb94...342093eca6a10a42343ed4333d8a2d18df701bc4?src=pr)

thanks!
Update unpack_template.h
State: closed

- [x ] closes #14373
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

USE_CASE_RANGE is a GNU C feature. This change will activate
USE_CASE_RANGE on any platform when using GNU C and not on any platform
when a different compiler is being used.

closes #14373


Labels:
name: Build
description: Library building on various platforms

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14441?src=pr) is 85.25% (diff: 100%)

> Merging [#14441](https://codecov.io/gh/pandas-dev/pandas/pull/14441?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14441   diff @@
==========================================
  Files           140        140          
  Lines         50631      50631          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43167      43166     -1   
- Misses         7464       7465     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [7cad3f1...1824bad](https://codecov.io/gh/pandas-dev/pandas/compare/7cad3f16bccd1d4702ef9d038b1ee0db33b9bb94...1824bad1d7a67b4efa318f207f98bb88ea3368eb?src=pr)

can you push this again. since we changed the url of the repo, I think appveyor got turned off. I just turned it back on.

you can do:

`git commit --all --amend -C HEAD`  generate a revised hash
`git push yourbranchname yourrepo -f` to force the update

rebuilding server after a NAS crash - will do later tomorrow.

thanks @aixtools this builds.