BrandonFors/pandas-github-issues huggingface dataset:
ENH: Add Storage Options kwarg to read_table
State: closed

- [x] closes #39167
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

Follow up from https://github.com/pandas-dev/pandas/pull/35381 - looks like this was missed

Not sure if this is an enhancements or a bug given the docs already mention this arg is supported.
https://pandas.pydata.org/docs/reference/api/pandas.read_table.html

Labels:
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
/azp run
<samp>
Azure Pipelines successfully started running 1 pipeline(s).<br>

</samp>
BUG: groupby.apply incorrectly dropping nan
State: closed

- [x] closes #43205
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Groupby
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
since this is a regression, shouldn't this go to 1.3.3?
thanks @debnathshoham 
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.3.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 99640224fbe3ec14b8775492471d5d915093bfba
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #43236: BUG: groupby.apply incorrectly dropping nan'
```

4. Push to a named branch :

```
git push YOURFORK 1.3.x:auto-backport-of-pr-43236-on-1.3.x
```

5. Create a PR against branch 1.3.x, I would have named this PR:

> "Backport PR #43236 on branch 1.3.x (BUG: groupby.apply incorrectly dropping nan)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove `Still Needs Manual Backport` label once the PR gets merged.

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@meeseeksdev backport 1.3.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.3.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 99640224fbe3ec14b8775492471d5d915093bfba
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #43236: BUG: groupby.apply incorrectly dropping nan'
```

4. Push to a named branch :

```
git push YOURFORK 1.3.x:auto-backport-of-pr-43236-on-1.3.x
```

5. Create a PR against branch 1.3.x, I would have named this PR:

> "Backport PR #43236 on branch 1.3.x (BUG: groupby.apply incorrectly dropping nan)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove `Still Needs Manual Backport` label once the PR gets merged.

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@debnathshoham if you can follow the instructions above and manually backport
Update indexing.rst
State: closed

I have added a much clear and professional documentation for the note above which is clear and easy to understand.


Labels:
name: Docs

Comments:
What's and unclear and unprofessional about the current wording?
agreed - thanks anyway, and please see https://pandas.pydata.org/docs/development/contributing.html for how to contribute
Dear All,

Thanks a lot for your feedback.
This was my first attempt at contributing, as I am just getting started in
open source.
I will take care of the aforementioned next time.
Thanks for taking the time .

Yours sincerely
Allan

On Thu, Aug 26, 2021 at 10:43 PM Marco Edward Gorelli <
***@***.***> wrote:

> Closed #43235 <https://github.com/pandas-dev/pandas/pull/43235>.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/43235#event-5214285847>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AO4UI4J7YKQ5VZ5TGQQ63GTT6ZY43ANCNFSM5C3YK2XQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
> .
>
Added example to Dataframe.get docs
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry
@MarcoGorelli 


Labels:
name: Docs

Comments:
you mean this one right? @MarcoGorelli
```
df2 = df1.get("key") #key column is not available in dataframe 
print(df2)
None #Returns default value if not found.
```
I think, something like this  (`df` is directly from the example you added)
```python
In [9]: df.get(["temp_celsius","windspeed","temp_Kelvin"], default = "Some column missing")
Out[9]: 'Some column missing'
```
have you run the validate_docstrings script? https://pandas.pydata.org/pandas-docs/stable/development/contributing_documentation.html#updating-a-pandas-docstring
yes. Tested the `validate_docstrings` and `python make.py clean`, `python make.py --single pandas.DataFrame.get    `                    

These errors from `validate_docstrings` need fixing:
```
	flake8 error: E231 missing whitespace after ','
2     E251 unexpected spaces around keyword / parameter equals (2 times)
```
check https://www.python.org/dev/peps/pep-0008/
@MarcoGorelli How did you remove those errors? I have tried using autopep8 in vscode, It did nothing for me. Can u please explain a bit?
CLN: remove unused pandas-gbq tests
State: closed

Closes #43214

These tests are not run in CI. I'll replace these with tests in the pandas-gbq repo (https://github.com/googleapis/python-bigquery-pandas/issues/379)

- [x] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry (N/A)

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Yeah these used to run only on travis.

Taking Jeff's comments [here](https://github.com/pandas-dev/pandas/issues/43214#issuecomment-905892079) as a +1 and LGTM
CLN: remove _index_data
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Clean

Comments:
Thanks @jbrockmendel this is a follow-up to #42992? we may need to revert that one? https://github.com/pandas-dev/pandas/issues/43206#issuecomment-905588696
Yes.  Can keep this in a holding pattern until that is resolved.
great, can you rebase (and will hold till resolution of that other issue)
My investigation of #43206 suggests it is driven by the mismatched behavior that caused all the headaches that made us get rid of apply_frame_axis0 in the first place.  ATM I am not inclined to revert that removal.
thanks @jbrockmendel
Resolving Index Resetting for tz_localize
State: closed

- [x] closes #43080 
- [x] tests added / passed
   I have added a test function `test_series_tz_localize_matching_index`  in `test_tz_localize.py`
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry
   Index of the original series is preserved while converting `categorical` data to `datetime`


Labels:
name: Timezones
description: Timezone data dtype
name: Categorical
description: Categorical Data Type

Comments:
Hello @kurchi1205! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:







There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-09-03 07:38:24 UTC
@mroeschke  Can you please review this pull request .
As the pep8speaks comment notes, you have some code style issues in your test.

Please run `pre-commit` on your code before committing them: https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#pre-commit
I have solved the code issues using `pre-commit` .
I have made the change in the documentation . 
I assume some maintainer has to merge the pull request.
How to solve this timeout error ?
lgtm @phofl merge when good
Can someone help me understand this failing test ? How are my changes affecting this test case ?
Thx @kurchi1205 
ok thnx for the clarification
Added example for Dataframe.align
State: closed

- [ ] closes #42125 
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry
@MarcoGorelli 

Labels:
name: Docs

Comments:
Soo, we use `blackdoc`for doc formatting right🤔? I was really confused between `black` n `blackdoc`.😕
> Soo, we use `blackdoc`for doc formatting rightthinking? I was really confused between `black` n `blackdoc`.confused

docstring are formatted with a custom check which runs flake8, but it doesn't autoformat them, that's something we need to do manually unfortunately. I'd like to make it automatic though, it's kinda on my todo list
REF: share Index.putmask with ExtensionIndex
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
can you rebase
Rebased + green
REF: use _get_axis_number instead of if axis in [...]
State: closed

- [x] Added _get_axis_number in style.py  as per the standards

Labels:

Comments:
Hello @goyaldhara! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

* In the file [`pandas/io/formats/style.py`](https://github.com/pandas-dev/pandas/blob/74f85604bc2d5fdcbd9ed0d85a28414fcde8a6b9/pandas/io/formats/style.py):

> [Line 1168:89](https://github.com/pandas-dev/pandas/blob/74f85604bc2d5fdcbd9ed0d85a28414fcde8a6b9/pandas/io/formats/style.py#L1168): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (127 > 88 characters)
> [Line 1168:113](https://github.com/pandas-dev/pandas/blob/74f85604bc2d5fdcbd9ed0d85a28414fcde8a6b9/pandas/io/formats/style.py#L1168): [E261](https://duckduckgo.com/?q=pep8%20E261) at least two spaces before inline comment


looks like an exact copy of https://github.com/pandas-dev/pandas/pull/43121 with a trivial edit to make it look like it's your own
TST: unhoused test_offsets fn to custom business hour (#27045)
State: closed

- [ ] xref #27085 (chips away at, yes)
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

* https://github.com/pandas-dev/pandas/pull/42284 
* https://github.com/pandas-dev/pandas/pull/42896 
* https://github.com/pandas-dev/pandas/pull/42909
* https://github.com/pandas-dev/pandas/pull/42930
* https://github.com/pandas-dev/pandas/pull/42932
* https://github.com/pandas-dev/pandas/pull/42952
* https://github.com/pandas-dev/pandas/pull/42989
* https://github.com/pandas-dev/pandas/pull/42990
* https://github.com/pandas-dev/pandas/pull/42991

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Frequency
description: DateOffsets

Comments:
Thanks @felixDulys
TYP: assorted
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
sure can you rebase just to be sure
rebased; CI failure looks like it is present in master
rebased + green
Bug resolve
State: closed


changed file generic.py and style.py
replaced if axis in [...] with get_axis_number(axis)


Labels:

Comments:
Hello @soni-muskan1234! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



















There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-08-25 13:30:59 UTC
Please run pre-commit checks locally. This won't pass the ci
@soni-muskan1234 let us know if you want to carry on working on this. See comments from maintainers above on next steps.
thanks @soni-muskan1234 - closing as the issue is now resolved
TST: categorical reindex with added categories
State: closed

- [x] closes #42424 
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

The bug is specifically in the Interval index. The error arises in the example code from the issue while reindexing the categorical index with another categorical index(with new categories). 

The test (test_cut_with_nonexact_categorical_indices)  from PR [42425](https://github.com/pandas-dev/pandas/pull/42425) implicitly works in a similar way.
 


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks for the PR @Sheogorath27 - mind taking a look at why CI is failing? 
I checked tests are passing locally. And I did not find any conflicts with the failed test.
Could you add a unit test with the example in the original issue as well (for an additional smoke test)?
Test from PR [42425](https://github.com/pandas-dev/pandas/pull/42425) is the same as the example in the issue. Should I duplicate it?
> Test from PR [42425](https://github.com/pandas-dev/pandas/pull/42425) is the same as the example in the issue. Should I duplicate it?

That PR was never merged. What are you suggesting we duplicate? 
> > Test from PR [42425](https://github.com/pandas-dev/pandas/pull/42425) is the same as the example in the issue. Should I duplicate it?
> 
> That PR was never merged. What are you suggesting we duplicate?

Sorry, I assumed PR was merged. I will add a new unit test.
> Could you add a unit test with the example in the original issue as well (for an additional smoke test)?

I have added a new test based on the example from the issue.
Thanks @Sheogorath27
DOC: ecosystem pandas-stubs information
State: closed

- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Added information about pandas-stubs to both the .rst and .md ecosystem doc files.

closes https://github.com/pandas-dev/pandas/issues/43197

Labels:
name: Docs

Comments:
@datapythonista 

Decided to make some changes based on your feedback:

* Reduced the amount of technical detail
* Included an installation guide
* Included an example
@datapythonista Do I have to take some action for the CI to pass? It times-out after an hour.
/azp run
<samp>
Azure Pipelines successfully started running 1 pipeline(s).<br>

</samp>
> @datapythonista Do I have to take some action for the CI to pass? It times-out after an hour.

I have just restarted CI now. Hopefully should run to completion this time
pre-commit raises errors. You should fix them first
I will get around to fixing the pre-commit issues locally.
thanks @zkrolikowski-vl
CLN: remove no-longer-used
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Clean

Comments:
Thanks @jbrockmendel
DOC: OSX -> macOS
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
@partev are there any other references in the codebase?
@alimcmaster1 I haven't searched the whole codebase for other references.
> @alimcmaster1 I haven't searched the whole codebase for other references.

I have doubled checked - these are the only references in the user docs. LGTM
thanks @partev
DOC: OSX -> macOS
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:

Comments:
superseded by https://github.com/pandas-dev/pandas/pull/43193
DEPS: bump sqlalchemy min support version to 1.4.0
State: closed

precursor of #42976


Labels:
name: Dependencies
description: Required and optional dependencies

Comments:
no this is fine
the prior version is for compatibility (i mean if we can keep 1.3.11 compat would be great but not sure it's possible)
hah I didn't realize this was just a dep bump, ok.
@fangchenli if we wanted to have pre 1.4 compat (as well); how hard would this be?
> @fangchenli if we wanted to have pre 1.4 compat (as well); how hard would this be?

pre 1.4 sqlalchemy freezes the CI in #42976. We could delay the refactoring of SQL tests to keep the pre 1.4 compact.
I think we might even have sqlalchemy 1.4 compat problems see #40682. This might not be safe to do for 1.4.
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
> I think we might even have sqlalchemy 1.4 compat problems see #40682. This might not be safe to do for 1.4.

@lithomas1 can you clarify are you saying this isn't safe to do for pandas 1.4 or isnt safe to support sqlalchemy 1.4?
I meant bumping the min version for pandas 1.4.0. Sorry for the confusion
@fangchenli status of this?
> @fangchenli status of this?

ready
can you add a whatsnew note about this change (assume we are dropping < 1.4)? (fine by me)
> can you add a whatsnew note about this change (assume we are dropping < 1.4)? (fine by me)

It's already included in the 1.4 whatsnew doc.
thanks @fangchenli
REF: remove libreduction.SeriesBinGrouper
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

xref #40263

Labels:
name: Groupby
name: Clean

Comments:
wow!
TST: Test renaming a multiindex with duplicates (GH 38015)
State: closed

- [x] closes #38015
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

This is my first real contribution, I appreciate the feedback!

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: MultiIndex

Comments:
Hello @andrewwoood! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-09-05 05:02:05 UTC
Some pre-commit issues, otherwise lgtm. 

You could install pre-commit to run the hooks locally before pushing
can you merge master and ping on green
@jreback Sorry, is this what you were asking me to do? I'm not very competent with using git and contributing to open-source quite yet. I tried using the pre-commit framework but it doesn't seem to help my file pass the pre-commit check.
The ci tells you whats wrong:

```
 pandas/tests/indexing/multiindex/test_multiindex.py:125:14: PDF019 found both 'pd.MultiIndex' and 'MultiIndex' in the same file
pandas/tests/indexing/multiindex/test_multiindex.py:126:14: PDF019 found both 'pd.DataFrame' and 'DataFrame' in the same file
pandas/tests/indexing/multiindex/test_multiindex.py:129:15: PDF019 found both 'pd.MultiIndex' and 'MultiIndex' in the same file
pandas/tests/indexing/multiindex/test_multiindex.py:130:20: PDF019 found both 'pd.DataFrame' and 'DataFrame' in the same file
```
Thanks @andrewwoood! Happy to have you address similar `good first issue`s that need tests.
DOC: Mention that we provide Python 3.10 wheels
State: closed

- [ ] closes #42946
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

IMPORTANT: This depends on MacPython/pandas-wheels#152, so please merge that first.


Labels:
name: Build
description: Library building on various platforms
name: Docs

Comments:
> IMPORTANT: This depends on [MacPython/pandas-wheels#152](https://github.com/MacPython/pandas-wheels/pull/152), so please merge that first.

Thanks @lithomas1 marked this one as draft for now.
no we can build wheels for rc as a test
but don't add any notes until actual python release 
> but don't add any notes until actual python release

sure. will close this.
> no we can build wheels for rc as a test
> but don't add any notes until actual python release

Could you please provide wheels built with rc? See https://github.com/numpy/numpy/issues/19630#issuecomment-898314636
> Could you please provide wheels built with rc? See [numpy/numpy#19630 (comment)](https://github.com/numpy/numpy/issues/19630#issuecomment-898314636)

Thanks @hroncok for the question.

This issue is closed since we are not adding a release note about the availabilty of 3.10 wheels. 

see https://github.com/pandas-dev/pandas/issues/43050#issuecomment-912455816 for futher discussion on providing wheels.
ENH: `styler.render.repr` option
State: closed

offers option switching between "html" and "latex" output.

adds items to #41395.

also xref #39911 (technically after DataFrame.to_html is deprecated)

- [x] adds option
- [x] adds tests
- [x] updates options.rst docs
- [x] no public method docstrings  
- [x] whatsnew 

update to styler user guide as follow-on after all options are merged.

![Screen Shot 2021-08-29 at 10 04 24](https://user-images.githubusercontent.com/24256554/131243320-6a4d452c-9cdc-417d-ab20-54fffd8c3a76.png)


Labels:
name: Enhancement
name: Styler
description: conditional formatting using DataFrame.style

Comments:
Have refactored this. This is the best, most generic pattern I think. When a `_repr_` function returns `None` iPython moves on to the next mimetype. So here we are manually specifying only one `_repr_mimetype_` to return a string.
thanks I left the display issue open but xref