BrandonFors/pandas-github-issues huggingface dataset:
Maintain Dict Ordering with Concat
State: closed

- [x] closes #21510
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

although the set is instance of dict, it should not sort if it is also instance of OrderedDict

Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Hello @SaturninoMateus! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on June 21, 2018 at 02:03 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21512?src=pr&el=h1) Report
> Merging [#21512](https://codecov.io/gh/pandas-dev/pandas/pull/21512?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/506935c3482cb678b75dc7a70f48707c70b4ae79?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21512/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21512?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21512      +/-   ##
==========================================
+ Coverage   91.92%   91.92%   +<.01%     
==========================================
  Files         153      153              
  Lines       49563    49566       +3     
==========================================
+ Hits        45559    45562       +3     
  Misses       4004     4004
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.32% <100%> (ø)` | :arrow_up: |
| #single | `41.8% <25%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21512?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/reshape/concat.py](https://codecov.io/gh/pandas-dev/pandas/pull/21512/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzaGFwZS9jb25jYXQucHk=) | `97.61% <100%> (+0.02%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21512?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21512?src=pr&el=footer). Last update [506935c...a7aa052](https://codecov.io/gh/pandas-dev/pandas/pull/21512?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Is this in reference to a particular issue?
Sorry?
What issue is this solving? Typically all pull requests (except for simple doc updates) refer to an issue on the issue tracker
Issue #21510
OK thanks. For future PRs please add that reference in your original comment (I've updated it for you this time).

As per the checklist, you are also going to need tests and a whatsnew entry for 0.23.2
closing as stale, if you want to continue working, pls ping and we can re-open. you will need to merge master.
DOC: Improve code example for Index.get_indexer
State: closed

Make code example clearer for ``Index.get_indexer``

Labels:
name: Docs
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
Hello @topper-123! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on June 19, 2018 at 08:19 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21511?src=pr&el=h1) Report
> Merging [#21511](https://codecov.io/gh/pandas-dev/pandas/pull/21511?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9e982e18678c47c83ce2bb5932f844e2d9ee21f3?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21511/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21511?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21511   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         153      153           
  Lines       49587    49587           
=======================================
  Hits        45583    45583           
  Misses       4004     4004
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.32% <ø> (ø)` | :arrow_up: |
| #single | `41.89% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21511?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/21511/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.62% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21511?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21511?src=pr&el=footer). Last update [9e982e1...64b87e7](https://codecov.io/gh/pandas-dev/pandas/pull/21511?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@topper-123 Thanks!
REGR: Fixes first_valid_index when DataFrame or Series has duplicate row index (GH21441)
State: closed

- [x] closes #21441 
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21497?src=pr&el=h1) Report
> Merging [#21497](https://codecov.io/gh/pandas-dev/pandas/pull/21497?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c2da06c8eea4cc0339717aa09acdd6765bc3d673?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21497/graphs/tree.svg?src=pr&width=650&height=150&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21497?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21497      +/-   ##
==========================================
- Coverage   91.92%   91.91%   -0.01%     
==========================================
  Files         153      153              
  Lines       49570    49574       +4     
==========================================
+ Hits        45566    45568       +2     
- Misses       4004     4006       +2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.31% <100%> (-0.01%)` | :arrow_down: |
| #single | `41.8% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21497?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/21497/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `96.13% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/21497/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `85.75% <0%> (-0.21%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21497?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21497?src=pr&el=footer). Last update [c2da06c...751046d](https://codecov.io/gh/pandas-dev/pandas/pull/21497?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

will rebase and resolve conflict with whatsnew file and push later today
thanks @KalyanGokhale
PERF: improve speed of nans in CategoricalIndex
State: closed

This is a minor follow-up to #21369.

```python
>>> n = 100_000
>>> ci = pd.CategoricalIndex(['a']*n + ['b']*n + ['c']*n + [np.nan])
>>> np.nan in ci
19.5 us  # master
114 ns  # this PR
```

Using ``self.hasnans`` to check for nans is faster than ``self.isna().any()`` because  it's cached.


Labels:
name: Performance
description: Memory or execution speed performance
name: Categorical
description: Categorical Data Type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21493?src=pr&el=h1) Report
> Merging [#21493](https://codecov.io/gh/pandas-dev/pandas/pull/21493?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bf1c3dc253c08e70c543ae09c146b72544e85df5?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21493/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21493?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21493      +/-   ##
==========================================
+ Coverage   91.89%   91.89%   +<.01%     
==========================================
  Files         153      153              
  Lines       49604    49604              
==========================================
+ Hits        45584    45586       +2     
+ Misses       4020     4018       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <100%> (ø)` | :arrow_up: |
| #single | `41.88% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21493?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/category.py](https://codecov.io/gh/pandas-dev/pandas/pull/21493/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9jYXRlZ29yeS5weQ==) | `97.09% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/21493/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.81% <0%> (+0.2%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21493?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21493?src=pr&el=footer). Last update [bf1c3dc...4b868bf](https://codecov.io/gh/pandas-dev/pandas/pull/21493?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @topper-123
TST: Add unit tests for older timezone issues
State: closed

- [x] closes #8616
- [x] closes #8910
- [x] closes #7825
- [x] closes #8306
- [x] closes #8531
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

In the spirit of your https://github.com/pandas-dev/pandas/pull/21407#issuecomment-396896678 @jreback, cleaned up some old timezone issues (but not necessarily covered by #21407) that appear to have been solved

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timezones
description: Timezone data dtype

Comments:
@mroeschke looks awesome!

so can you either add these issue numbers to the whatsnew for #21407, or if its a 'different' issue (even though it was solved via the same), add an appropriate whatnew e.g. a resampling fixed deserves its own whatsnew (in bug fixes for all of these i think)
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21491?src=pr&el=h1) Report
> Merging [#21491](https://codecov.io/gh/pandas-dev/pandas/pull/21491?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9e982e18678c47c83ce2bb5932f844e2d9ee21f3?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21491/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/21491?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21491   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         153      153           
  Lines       49587    49587           
=======================================
  Hits        45583    45583           
  Misses       4004     4004
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.32% <ø> (ø)` | :arrow_up: |
| #single | `41.89% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21491?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21491?src=pr&el=footer). Last update [9e982e1...6d20d6a](https://codecov.io/gh/pandas-dev/pandas/pull/21491?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks @jreback. Yeah I don't think #21407 was directly related to any of these older issues, so made separate entries for each. 
thanks @mroeschke !
it’s fine to move some to 0.24 whatsnew
though if they r indeed fixed by #21407 are ok here
Sounds good. I have another timezones issues PR in the works so I'll keep that in mind
CLN: Index imports and 0.23.1 whatsnew
State: closed

xref @jreback https://github.com/pandas-dev/pandas/pull/21216#discussion_r195367428 and cleaned up some formatting in the 0.23.1 whatsnew where GH issues references didn't hyperlink


Labels:
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21490?src=pr&el=h1) Report
> Merging [#21490](https://codecov.io/gh/pandas-dev/pandas/pull/21490?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bf1c3dc253c08e70c543ae09c146b72544e85df5?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21490/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21490?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21490      +/-   ##
==========================================
+ Coverage   91.89%   91.89%   +<.01%     
==========================================
  Files         153      153              
  Lines       49604    49604              
==========================================
+ Hits        45584    45586       +2     
+ Misses       4020     4018       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <100%> (ø)` | :arrow_up: |
| #single | `41.88% <83.33%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/21490/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.62% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/21490/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.81% <0%> (+0.2%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21490?src=pr&el=footer). Last update [bf1c3dc...d80c627](https://codecov.io/gh/pandas-dev/pandas/pull/21490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @mroeschke
BUG: Timedelta.__bool__
State: closed

Closes #21484

Labels:
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21485?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@89418a3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21485/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21485?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #21485   +/-   ##
=========================================
  Coverage          ?   91.89%           
=========================================
  Files             ?      153           
  Lines             ?    49604           
  Branches          ?        0           
=========================================
  Hits              ?    45586           
  Misses            ?     4018           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (?)` | |
| #single | `41.88% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21485?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21485?src=pr&el=footer). Last update [89418a3...bd595a5](https://codecov.io/gh/pandas-dev/pandas/pull/21485?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

minor comments, lgtm otherwise.
thanks @TomAugspurger
Removing SimpleMock test from pandas.util.testing
State: closed

Removing SimpleMock test

- [x] closes #21475
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
restarted the HTTP failure.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21482?src=pr&el=h1) Report
> Merging [#21482](https://codecov.io/gh/pandas-dev/pandas/pull/21482?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bf1c3dc253c08e70c543ae09c146b72544e85df5?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21482/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/21482?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21482      +/-   ##
==========================================
+ Coverage   91.89%   91.92%   +0.02%     
==========================================
  Files         153      153              
  Lines       49604    49585      -19     
==========================================
- Hits        45584    45581       -3     
+ Misses       4020     4004      -16
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.32% <ø> (+0.02%)` | :arrow_up: |
| #single | `41.89% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21482?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/21482/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `85.96% <ø> (+1.35%)` | :arrow_up: |
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/21482/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.62% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21482?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21482?src=pr&el=footer). Last update [bf1c3dc...edb4959](https://codecov.io/gh/pandas-dev/pandas/pull/21482?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@TomAugspurger any suggestions on how this could pass travis?

> pandas/util/testing.py:2265:1: E302 expected 2 blank lines, found 1

lint issue
lgtm. ping on green.
@jreback . build and tests passed.

thanks @uds5501
BUG: Fix Index construction when given empty generator (#21470).
State: closed

- [ ] closes #21470 
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Bug
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21481?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d5a1232`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21481/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21481?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #21481   +/-   ##
=========================================
  Coverage          ?   91.92%           
=========================================
  Files             ?      153           
  Lines             ?    49586           
  Branches          ?        0           
=========================================
  Hits              ?    45582           
  Misses            ?     4004           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.32% <100%> (?)` | |
| #single | `41.89% <75%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21481?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/arrays/categorical.py](https://codecov.io/gh/pandas-dev/pandas/pull/21481/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2NhdGVnb3JpY2FsLnB5) | `95.69% <ø> (ø)` | |
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/21481/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.62% <100%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21481?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21481?src=pr&el=footer). Last update [d5a1232...650f810](https://codecov.io/gh/pandas-dev/pandas/pull/21481?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Maybe also worthwhile to include a test for `iter([])` as well. 
@mroeschke Thanks--good call on including iter([]) in tests- turns out calling CategoricalIndex on any non-generator iterator was broken.
thanks @Liam3851