BrandonFors/pandas-github-issues huggingface dataset:
BLD: Pin cython for 37-locale build
State: closed

Seeing if this resolves the build failure.

xref https://github.com/pandas-dev/pandas/issues/34704

Labels:
name: Build
description: Library building on various platforms

Comments:
Also the Checks and Docs github action builds are failing, and those use the main environment.yml I think?
Thanks @TomAugspurger 
Though looks like we still have this pinned here:

https://github.com/pandas-dev/pandas/blob/08febd2b9f77fd8f943de92939788e8bc53ee2d2/ci/deps/azure-37-numpydev.yaml#L17

I can push a follow up PR. We might not even need that any more
@MeeseeksDev backport to 1.0.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.0.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 a1191d6fb2d21631e1d4fb2c558d5c66c5ea3bdf
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #34711: BLD: Pin cython for 37-locale build'
```

4. Push to a named branch :

```
git push YOURFORK 1.0.x:auto-backport-of-pr-34711-on-1.0.x
```

5. Create a PR against branch 1.0.x, I would have named this PR:

> "Backport PR #34711 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@jorisvandenbossche will do this next
We actually don’t need to backport this can just do #34718
TST: Add test for rolling window, see GH 34605
State: closed

- [X] closes #34605 
- [X] tests added / passed
- [X] passes `black pandas`
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Dear maintainers,

I'm opening this PR to address issue #34605.

~I've made the test conditional to Python 3.8 as I'm using the positional only syntax as strong check. If this is not desired, let me know and I will change the function to explicitly check for the length of `*args`.~

Edit: maybe the usage of `parametrize` is a bit exaggerated here.
Edit2: Using Python 3.8 only features does not pleases the tests. Updating.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Window
description: rolling, ewma, expanding

Comments:
Hello @gglanzani! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-06-15 06:54:55 UTC
@mroeschke Thanks for the review Matthew, I think I've addressed all your points.
Looks good. I think our CI is having issues currently, so we can probably merge this once that is fixed.
lgtm. yep can merge once CI is good.
@gglanzani can you merge master?
@WillAyd Done
thanks @gglanzani
BUG: GH34677 Roll forward asv benchmark environment to py3.8
State: closed

Partially closes #34677 

Labels:
name: Benchmark
description: Performance (ASV) benchmarks

Comments:
I think we could also just remove this entry altogether
Just tested and that works for me as well. You think that's the better route to take?
Yea I think so
We need to verify that changing this won't cause a break in the timeseries at https://pandas.pydata.org/speed/pandas/.
How do we do that? I have another PR pending that needs benchmarking 
I'm not sure what conditions cause asv to consider it a different environment.

> I have another PR pending that needs benchmarking

Hopefully that isn't blocked by this issue. You can make the changes locally and run the ASVs.
Oh duh yeah thanks
I think this will cause a break in the timeseries (in a similar way as the cython version pin caused a new timeseries, see the two colors at eg https://pandas.pydata.org/speed/pandas/#algorithms.Hashing.time_frame), but I don't think there is a way around that? We need to do this update at some point, so the question is maybe if we are ok with doing it now.


Even if this breaks the time series I would be OK with doing it. Maybe after the next release so we get a clean delineation?
Yes, I think waiting until after the release sounds as a good idea
TYP: check_untyped_defs pandas.io.json._table_schema
State: closed

pandas\io\json\_table_schema.py:112: error: Incompatible types in assignment (expression has type "Dict[str, List[Any]]", target has type "str")
pandas\io\json\_table_schema.py:264: error: Incompatible types in assignment (expression has type "str", target has type "List[Any]")




Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Thanks @WillAyd for reviewing these. Travis is green, just not updated here. so will merge shortly.
DOC: updated doctorings for SS06 errors
State: closed


Labels:
name: Docs

Comments:
Hello @willpeppo! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:













There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-06-10 14:43:23 UTC
TYP: check_untyped_defs pandas.core.resample
State: closed

pandas\core\resample.py:969: error: Too many arguments for "__init__" of "object"
pandas\core\resample.py:1572: error: "DatetimeIndex" has no attribute "tzinfo"
pandas\core\resample.py:1573: error: "DatetimeIndex" has no attribute "tzinfo"
pandas\core\resample.py:1585: error: "PeriodIndex" has no attribute "asfreq"; maybe "freq"?
pandas\core\resample.py:1867: error: "PeriodIndex" has no attribute "asfreq"; maybe "freq"?
pandas\core\resample.py:1902: error: "PeriodIndex" has no attribute "asfreq"; maybe "freq"?


Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
@WillAyd anything more to do here?
Thanks @simonjayhawkins
TYP: check_untyped_defs pandas.core.nanops
State: closed

pandas\core\nanops.py:565: error: Item "bool" of "Union[bool, Any]" has no attribute "any"

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
@WillAyd @jorisvandenbossche updated + green
Lgtm @jorisvandenbossche merge if nothing outstanding
thanks @simonjayhawkins
BLD: pyproject.toml for Py38
State: closed

Closes https://github.com/pandas-dev/pandas/issues/34666

Labels:
name: Build
description: Library building on various platforms

Comments:
Merging in a few hours if there's no objection.
lets merge now!
@MeeseeksDev backport to 1.0.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.0.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 08febd2b9f77fd8f943de92939788e8bc53ee2d2
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #34667: BLD: pyproject.toml for Py38'
```

4. Push to a named branch :

```
git push YOURFORK 1.0.x:auto-backport-of-pr-34667-on-1.0.x
```

5. Create a PR against branch 1.0.x, I would have named this PR:

> "Backport PR #34667 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
Backport PR #34458 on branch 1.0.x (CLN: Clean csv files in test data GH34427)
State: closed

xref #34458

Labels:

Comments:
@simonjayhawkins do you have time one of those days to do a 1.0.5 release? 
> @simonjayhawkins do you have time one of those days to do a 1.0.5 release?

can do. do we want to include anything else, wait a few weeks before doing the release and see if anything else surfaces or just get a patch release done with the S3 changes?
I would personally just do a patch release with the S3 changes, and not wait a few weeks with that. But maybe open a RLS issue for it to get some feedback from others? 
agree would just do the revert of the single issue
BUG: Allow plain bools in ExtensionArray.equals
State: closed

- [x] closes #34660
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Bug
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks!
#34640: CLN: remove 'private_key' and 'verbose' from gbq
State: closed

- [x ] closes #34640 
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Hello, I am new to contributing to open source, so thank you in advance for any corrections and suggestions. Please let me know if I need to do anything else for this ticket!

I removed the code containing both 'private_key' and 'verbose' from the gbq.py file.

Labels:
name: Clean

Comments:
@tswast 
since those two kwargs weren't removed along with #30200 , also cc @jbrockmendel , just in case this was made on purpose by him.
@parkdj1 

hi, you need to rebase and resolve the conflicts in the two files listed below, otherwise, your commit won't get through and make CI run.
@parkdj1 - Thanks for the PR, can you address the test failures and fix up the commits seems to be a few unrelated changes.
Hello @parkdj1! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-09-22 22:31:42 UTC
> Hello @parkdj1! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
> 
> There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻
> 
> ##### Comment last updated at 2020-06-29 00:35:21 UTC

Awesome, thank you!
@parkdj1 is this still active? Ref my comments above:  https://github.com/pandas-dev/pandas/pull/34654#issuecomment-647164000

Also whatsnew will be 1.2 now.

Thanks
thanks @parkdj1
DOC: updated plotting/_misc.py for PR08 errors
State: closed


Labels:
name: Docs

Comments:
Thanks for the PR - mind referring the issue on this? 
yes no problem at a all... what's the best way to do that?   Just put the issue number in the comments ?   Thanks in advance for the guidance.
Exactly - the template should help. https://github.com/pandas-dev/pandas/issues/25232
Great thanks @willpeppo
TST: groupby apply with indexing and column aggregation returns the column #7002
State: closed

Adds test for #7002 

- [x] closes #7002 
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby

Comments:
Hello @VirosaLi! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-06-09 06:10:16 UTC
@VirosaLi can you address @simonjayhawkins comments? Lgtm otherwise
@VirosaLi Thanks for the updates. lgtm. ping on green
One of the checks is on pending for hours. Is this normal?
> One of the checks is on pending for hours. Is this normal?

Travis is glitchy sometimes, it's green if you click through
thanks @VirosaLi
ENH: Add max_results kwarg to read_gbq
State: closed

Adds support for the new `max_results` kwarg from pandas-gbq (added in [0.12.0](https://github.com/pydata/pandas-gbq/releases/tag/0.12.0)). Since `max_results` is a new kwarg, it is handled and tested in the same way as the `use_bqstorage_api` kwarg to maintain backwards compatibility.

❓ **Open question:** Setting `max_results=0` causes `pandas_gbq.read_gbq` to return `None` instead of a DataFrame. I've kept this behaviour the same in this PR, but maintainers may prefer to always return a (empty) DataFrame instead of `None`.

- [x] closes #34639
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry



Labels:
name: Enhancement

Comments:
@tswast 
thanks @JohnPaton
BUG/API: Disallow unit if input to Timedelta and to_timedelta is/contains str
State: closed

- [x] closes #12136
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Timedelta
description: Timedelta data type

Comments:
Can you add a test for the behavior? This is typically the first thing we look for in any PR
this is a replacement for #34379? 
@jreback Fixed. Thanks!
thanks @pdnm very nice patch! keep em coming!
Revert backport of #33632: Parquet & s3 I/O changes
State: closed

Ref: https://github.com/pandas-dev/pandas/issues/34626#issuecomment-640225867

Revert backport of https://github.com/pandas-dev/pandas/pull/33632
Backport: https://github.com/pandas-dev/pandas/pull/34173

cc @jorisvandenbossche @simonjayhawkins 


Labels:
name: IO Parquet
description: parquet, feather

Comments:
The doc failure is related to https://github.com/pandas-dev/pandas/pull/34458, which needs to be backported
TYP: some type annotations for interpolate
State: closed

pre-cursor to #34628

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Yea I don’t think its that important so if a lot of effort just revert

> On Jun 7, 2020, at 10:35 AM, Simon Hawkins <notifications@github.com> wrote:
> 
> 
> @simonjayhawkins commented on this pull request.
> 
> In pandas/core/missing.py <https://github.com/pandas-dev/pandas/pull/34631#discussion_r436385068>:
> 
> > @@ -92,8 +94,7 @@ def clean_fill_method(method, allow_nearest=False):
>      return method
>  
>  
> -def clean_interp_method(method, **kwargs):
> -    order = kwargs.get("order")
> +def clean_interp_method(method: str, order: Optional[int] = None, **kwargs) -> str:
> it doesn't appear that we pass the kwargs through to np.interp (left, right and period) but do for scipy.interpolate.interp1d
> 
> did you mean kwargs not used in this function? That's true, but would need to do order = kwargs.get("order") in the calling functions if I remove kwargs here. I don't see that as an improvement.
> 
> should I revert this change?
> 
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <https://github.com/pandas-dev/pandas/pull/34631#discussion_r436385068>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEU4UIZQS5KLL7E7JDLFELRVPFULANCNFSM4NXKKNVA>.
> 


Thanks @simonjayhawkins
WIP: avoid internals for Series.interpolate
State: closed

This may be premature while discussion about removing the block manager is ongoing

most of the diff is type annotations and collecting the method validation. will break off into pre-cursor PRs

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
The more I investigate this, I _think_ may to be able to avoid internals for DataFrame.interpolate too since interpolates per column within each block (using np.apply_along_axis). We should be able therefore to operate columnwise instead and can keep the shared code in NDFrame.

closing for now to clear queue.
TST #24444 added tests
State: closed

At last, there are no issues at all. I've made a new PR.

- [x] closes #24444
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks @OlivierLuG 

> I've made a new PR to update master. Sorry, there iare conflict. I don't know how to handle that.

There's instructions [here](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) in the contributing guide
Thanks @OlivierLuG
REF: re-use existing conversion functions
State: closed


Labels:
name: Refactor
description: Internal refactoring of code

Comments:
Yep exactly. Makes sense for future plan

Sent from my iPhone

> On Jun 7, 2020, at 9:46 AM, jbrockmendel <notifications@github.com> wrote:
> 
> ﻿
> @jbrockmendel commented on this pull request.
> 
> In pandas/_libs/tslibs/period.pyx:
> 
> >          return DtoB(dts, 0, unix_date)
>  
> -    elif freq_group == FR_WK:
> -        return unix_date_to_week(unix_date, freq - FR_WK)
> +    unit = get_unit(freq)
> +    return npy_datetimestruct_to_datetime(unit, dts)
> +
> +
> +cdef NPY_DATETIMEUNIT get_unit(int freq) nogil:
> I think what you're suggesting is something like:
> 
> cdef enum FreqGroup:
>     FR_MTH = NPY_DATETIMEUNIT.NPY_FR_M
>     FR_DAY = NPY_DATETIMEUNIT.NPY_FR_D
>     [...]
> LMK if you have something else in mind.
> 
> The trouble with that is that we currently actually use the values for FR_FOO directly, and this would change those.
> 
> There are a bunch of near-duplicate enum-like codes floating around that i do want to de-duplicate. #34588 makes FreqGroup an enum, and after #34587 im hoping we can de-duplicate FreqGroup with Resolution.
> 
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or unsubscribe.
TST/REF: arithmetic tests for BooleanArray + consolidate with integer masked tests
State: closed

Follow-up on https://github.com/pandas-dev/pandas/pull/34454

- Move a bunch of tests from `integer/test_arithmetic.py` to `masked/test_arithmetic.py` so those can be shared with boolean (and once merged I can add float as well in the FloatingArray PR)
- Added some more arithmetic tests to `boolean/test_arithmetic.py` to follow the same pattern as we have in `integer/test_arithmetic.py`. 
- The commong integer/boolean tests uncovered a bug in the BooleanArray implementation when dealing with a `pd.NA` scalar as other operand.

Labels:
name: Bug
name: Testing
description: pandas testing functions or related to the test suite
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
small comment; LGTM
Updated for all comments
thanks @jorisvandenbossche
TST: boolean indexing using .iloc #20627
State: closed

- [x] closes #20627
- [1] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

A simple test was added to close this issue.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
/azp run
<samp>
Azure Pipelines successfully started running 1 pipeline(s).<br>

</samp>
I think everything is done. The last PR is green.
Thanks @OlivierLuG
Improve document for **kwargs argument of pandas.Series.to_markdown
State: closed

This is a follow-up PR of #34594 .  
`pandas.Series.to_markdown` has also same argument.

This PR adds example for `pandas.Series.to_markdown` with tabulate option.

Related Issue: #34568 

Labels:
name: Docs

Comments:
Also lgtm - @MarcoGorelli any thoughts?
Ha sorry meant to write that on the other PR
/azp run
<samp>
Azure Pipelines successfully started running 1 pipeline(s).<br>

</samp>
Thanks @nuka137
DOC: Clarify where to the additional arguments for some win_types
State: closed

For example, std needs to specify when win_types is gaussian. However, std should be specified in the operation argument, not as one of the rolling arguments. This change is to clarify this point. 

- [ ] closes #34593
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
Hello @wchen928! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-06-17 20:58:13 UTC
Merged master to fix the CI failure.
Thanks @wchen928
REF: RelativeDeltaOffset.apply_index operate on ndarray
State: closed


Labels:
name: Frequency
description: DateOffsets

Comments:
> is this exercised in any tests?

Based on a quick check, looks like we have coverage for everything besides L1067
> > is this exercised in any tests?
> 
> Based on a quick check, looks like we have coverage for everything besides L1067

kk if you want to add here or followon ok
> kk if you want to add here or followon ok

lets do for follow-on.  there are a few more of these coming up
This is an API change?
> This is an API change?

No, apply_index_wraps already made it return an ndarray
Add ddof to cov methods
State: closed

- [ x] closes #28823
- [x] tests added / passed
- [x] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
Hello @smartswdeveloper! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:











There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-06-21 21:12:36 UTC
Can you add tests? That's typically the first thing we look for in any PR
@WillAyd I just did it. Thank you.
does corr will also need a change?
> does corr will also need a change?

I don't think so, the degrees of freedom cancel for correlation. Looks like numpy.corrcoef does have a ddof argument but it doesn't do anything and is deprecated.
> this needs a whatsnew note as well, other enhancements, 1.1

Done
lgtm. can merge on green.
Thanks @smartswdeveloper
TST: mark tzlocal tests as slow, closes #34413
State: closed

- [x] closes #34413
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
xref #34131 as well (maybe can close that too).