BrandonFors/pandas-github-issues huggingface dataset:
Fix parsing corner case closes #19382
State: closed

- [x] closes #19382
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19529?src=pr&el=h1) Report
> Merging [#19529](https://codecov.io/gh/pandas-dev/pandas/pull/19529?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bc1d0273cd4b7ddf348feff5f46b6eb114ea04c9?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19529/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/19529?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19529   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         150      150           
  Lines       48714    48714           
=======================================
  Hits        44633    44633           
  Misses       4081     4081
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.99% <ø> (ø)` | :arrow_up: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19529?src=pr&el=footer). Last update [bc1d027...0af64f6](https://codecov.io/gh/pandas-dev/pandas/pull/19529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> The conversion code for datetimes is still all over the place because tslib.pyx still exists, would be happy to remove that.

Yah, I've been holding off on that because there are small differences between array_to_datetime and the Timestamp constructor that I'm hoping to un-difference, then share the implementation.
thanks. happy to have a cleanup in array_to_datetime, but that's a separate PR
WIP: parametrize giant frame flex op tests
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
Hello @jbrockmendel! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on February 03, 2018 at 21:04 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19528?src=pr&el=h1) Report
> Merging [#19528](https://codecov.io/gh/pandas-dev/pandas/pull/19528?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e8620abc12a4c468a75adb8607fd8e0eb1c472e7?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19528/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19528?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19528      +/-   ##
==========================================
+ Coverage   91.62%   91.62%   +<.01%     
==========================================
  Files         150      150              
  Lines       48680    48681       +1     
==========================================
+ Hits        44603    44604       +1     
  Misses       4077     4077
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.99% <ø> (ø)` | :arrow_up: |
| #single | `41.73% <ø> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19528?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/reshape/merge.py](https://codecov.io/gh/pandas-dev/pandas/pull/19528/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzaGFwZS9tZXJnZS5weQ==) | `94.22% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19528?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19528?src=pr&el=footer). Last update [e8620ab...8487ade](https://codecov.io/gh/pandas-dev/pandas/pull/19528?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Closing for now to clear out the queue, will circle back.
ERR: Better error msg when merging on tz-aware and tz-naive columns
State: closed

- [ ] closes #15800
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry



Labels:
name: Datetime
description: Datetime data dtype
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Timezones
description: Timezone data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19525?src=pr&el=h1) Report
> Merging [#19525](https://codecov.io/gh/pandas-dev/pandas/pull/19525?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e8620abc12a4c468a75adb8607fd8e0eb1c472e7?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19525/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19525?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19525      +/-   ##
==========================================
- Coverage   91.62%   91.62%   -0.01%     
==========================================
  Files         150      150              
  Lines       48680    48681       +1     
==========================================
- Hits        44603    44602       -1     
- Misses       4077     4079       +2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.98% <100%> (-0.01%)` | :arrow_down: |
| #single | `41.73% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/reshape/merge.py](https://codecov.io/gh/pandas-dev/pandas/pull/19525/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzaGFwZS9tZXJnZS5weQ==) | `94.22% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/19525/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `83.64% <0%> (-0.21%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19525?src=pr&el=footer). Last update [e8620ab...4823afa](https://codecov.io/gh/pandas-dev/pandas/pull/19525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
Spellcheck of enhancingperf.rst
State: closed

Spellcheck of the docs, mostly `enhancingperf.rst`, and a sentence or two on `sparse.rst`.

* Added a short introductory paragraph on enhancing performance.
* Backticks ` `` ` around Series, DataFrame.
* Typeset variants of ` ``numba`` `, `(n|N)umba`, `(c|C)ython`, etc as **Numba** and **Cython**.
* Minor rephrasing of sentences, spelling, periods, colons etc.

Cheers. Comments very welcome :)


Labels:
name: Docs
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19516?src=pr&el=h1) Report
> Merging [#19516](https://codecov.io/gh/pandas-dev/pandas/pull/19516?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/69cd5fbfd8b57033b0eb280ebc6dd502652f269c?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19516/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19516?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19516      +/-   ##
==========================================
- Coverage   91.69%   91.67%   -0.03%     
==========================================
  Files         148      148              
  Lines       48561    48561              
==========================================
- Hits        44530    44518      -12     
- Misses       4031     4043      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.03% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.72% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19516?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19516/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19516?src=pr&el=footer). Last update [69cd5fb...5ed6c4a](https://codecov.io/gh/pandas-dev/pandas/pull/19516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks again @tommyod
DOC: minor groupby and resampler improvements
State: closed

- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Some minor improvements to groupby and resampler. In particular:
* Corrected a link under ``groupby.pipe``
* added "Notes" and "See Also" for NDFrame.groupby/resample
* shortened an example in groupby.rst

Labels:
name: Docs
name: Groupby

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19514?src=pr&el=h1) Report
> Merging [#19514](https://codecov.io/gh/pandas-dev/pandas/pull/19514?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bc1d0273cd4b7ddf348feff5f46b6eb114ea04c9?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19514/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19514?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19514   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         150      150           
  Lines       48714    48714           
=======================================
  Hits        44633    44633           
  Misses       4081     4081
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.99% <100%> (ø)` | :arrow_up: |
| #single | `41.75% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19514?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby.py](https://codecov.io/gh/pandas-dev/pandas/pull/19514/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS5weQ==) | `92.15% <ø> (ø)` | :arrow_up: |
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/19514/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `95.91% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19514?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19514?src=pr&el=footer). Last update [bc1d027...49714e8](https://codecov.io/gh/pandas-dev/pandas/pull/19514?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

All green.
Frame specific parts of #19504
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timezones
description: Timezone data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19512?src=pr&el=h1) Report
> Merging [#19512](https://codecov.io/gh/pandas-dev/pandas/pull/19512?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/69cd5fbfd8b57033b0eb280ebc6dd502652f269c?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19512/graphs/tree.svg?token=eZ4WkYLtcO&width=650&src=pr&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19512?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19512      +/-   ##
==========================================
- Coverage   91.69%   91.67%   -0.03%     
==========================================
  Files         148      148              
  Lines       48561    48561              
==========================================
- Hits        44530    44518      -12     
- Misses       4031     4043      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.03% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.72% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19512?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19512/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19512?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19512?src=pr&el=footer). Last update [69cd5fb...17cba22](https://codecov.io/gh/pandas-dev/pandas/pull/19512?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
split Timestamp tests off of #19504
State: closed

There is de-duplication/parametrization etc to be done, but that should wait until the tests are collected because we'll have to re-do it then anyway.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timezones
description: Timezone data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19511?src=pr&el=h1) Report
> Merging [#19511](https://codecov.io/gh/pandas-dev/pandas/pull/19511?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/69cd5fbfd8b57033b0eb280ebc6dd502652f269c?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19511/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19511?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19511      +/-   ##
==========================================
- Coverage   91.69%   91.67%   -0.03%     
==========================================
  Files         148      148              
  Lines       48561    48561              
==========================================
- Hits        44530    44518      -12     
- Misses       4031     4043      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.03% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.72% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19511?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19511/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19511?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19511?src=pr&el=footer). Last update [69cd5fb...161bd4b](https://codecov.io/gh/pandas-dev/pandas/pull/19511?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

this is fine, assuming you are going to completely destruct ``pandas/tests/tseries/test_timezones`` and put the tests in the appropriate places ?
thanks!
> this is fine, assuming you are going to completely destruct pandas/tests/tseries/test_timezones and put the tests in the appropriate places ?

Most of it will go into Timestamp/DatetimeIndex/...-specific modules.  There are some pieces that are more directly testing tslibs.timezones/tslibs.conversions, which can either stay in tests.tseries or go into a new tests.tslibs.
BUGFIX - AttributeError raised in StataReader.value_labels()
State: closed

- [x] closes #19417 
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

Returns empty dict instead of raising AttributeError for very old Stata files. Includes test against very old Stata file.

Labels:
name: Bug
name: IO Stata
description: read_stata, to_stata

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19510?src=pr&el=h1) Report
> Merging [#19510](https://codecov.io/gh/pandas-dev/pandas/pull/19510?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/672f5a151886a8bf457ac499d9a9a471689ee9ff?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19510/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19510?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19510   +/-   ##
=======================================
  Coverage    91.6%    91.6%           
=======================================
  Files         150      150           
  Lines       48750    48750           
=======================================
  Hits        44657    44657           
  Misses       4093     4093
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.97% <ø> (ø)` | :arrow_up: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19510?src=pr&el=footer). Last update [672f5a1...ea8d107](https://codecov.io/gh/pandas-dev/pandas/pull/19510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lgtm. rebasing, ping when green.
thanks!
TST: Remove dupe TimdeltaIndex tests from indexes/timedeltas/test_astype.py
State: closed

- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Both classes in `test_astype.py` and [`test_timedelta.py`](https://github.com/pandas-dev/pandas/blob/master/pandas/tests/indexes/timedeltas/test_timedelta.py#L19) inherit from `DatetimeLike`, which in turn [inherits from `Base`](https://github.com/pandas-dev/pandas/blob/master/pandas/tests/indexes/datetimelike.py#L9), leading to 200+ dupe tests being run.

Modified `test_astype.py` to inherit from `object` instead, removed some unnecessary boilerplate, and removed some additional tests that were specified to override base class tests.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19509?src=pr&el=h1) Report
> Merging [#19509](https://codecov.io/gh/pandas-dev/pandas/pull/19509?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/69cd5fbfd8b57033b0eb280ebc6dd502652f269c?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19509/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19509?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19509   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files         148      148           
  Lines       48561    48561           
=======================================
  Hits        44530    44530           
  Misses       4031     4031
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.06% <ø> (ø)` | :arrow_up: |
| #single | `41.72% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19509?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19509?src=pr&el=footer). Last update [69cd5fb...1a43bb5](https://codecov.io/gh/pandas-dev/pandas/pull/19509?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

+1

FWIW there are some other `astype` tests that may be in suboptimal locations:

`test_timedelta.test_freq_conversion` (and the Series cases probably belong elsewhere)
`test_ops.test_astype_object`

thanks!