BrandonFors/pandas-github-issues huggingface dataset:
Add _expand_user to _stringify_path as we need to allow tilde - ~, to expand to full path
State: closed


- [x] closes #23473 
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
Hello @srinivasreddy! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on January 05, 2019 at 18:39 Hours UTC
we have some tests in io/test_common.py ; do these need to be expanded?
Nope. I do not see the need. build pass should make it good to go. 
ok, can you add a whatsnew note
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23769?src=pr&el=h1) Report
> Merging [#23769](https://codecov.io/gh/pandas-dev/pandas/pull/23769?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/4b4bf723e19325039bd0ce5f61bc2b8ad0651909?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23769/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23769?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23769      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +<.01%     
==========================================
  Files         166      166              
  Lines       52379    52379              
==========================================
+ Hits        48386    48387       +1     
+ Misses       3993     3992       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.8% <100%> (ø)` | :arrow_up: |
| #single | `43.01% <100%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23769?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/common.py](https://codecov.io/gh/pandas-dev/pandas/pull/23769/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2NvbW1vbi5weQ==) | `72.86% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/23769/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `88.09% <0%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23769?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23769?src=pr&el=footer). Last update [4b4bf72...0a660e0](https://codecov.io/gh/pandas-dev/pandas/pull/23769?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you merge master and address comments
can you merge master
@pandas-dev/pandas-core if someone can merge master and update the test
Sure I'll take a look
@jreback all green let me know your thoughts
thanks @srinivasreddy & @WillAyd
API/DEPR: replace kwarg "pat" with "sep" in str.[r]partition
State: closed

- [x] closes #22676
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Strings
description: String extension data type and string data
name: Deprecate
description: Functionality to remove in pandas

Comments:
Hello @h-vetinari! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/strings.py`](https://github.com/h-vetinari/pandas/blob/8cbf9eac7e3d20357e720ea9817a42e2fa72db3b/pandas/core/strings.py) !

 - There are no PEP8 issues in the file [`pandas/tests/test_strings.py`](https://github.com/h-vetinari/pandas/blob/8cbf9eac7e3d20357e720ea9817a42e2fa72db3b/pandas/tests/test_strings.py) !


Failure is a flaky hypothesis test.
looks fine, ex @WillAyd comments. @WillAyd pls add this to the list in #6581 as well. merge when ready.
@jreback @WillAyd 
The feedback of @WillAyd is already incorporated.
thanks @h-vetinari
TST: Add test case for GH14080 for overflow exception
State: closed

- [X] closes #14080 
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] Unsure if I should modify whatsnew if it is just adding a test?


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timedelta
description: Timedelta data type

Comments:
Hello @eoveson! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/scalar/timestamp/test_arithmetic.py`](https://github.com/eoveson/pandas/blob/f7be8f3828f9eddd204af577216e388d7cf5da12/pandas/tests/scalar/timestamp/test_arithmetic.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23762?src=pr&el=h1) Report
> Merging [#23762](https://codecov.io/gh/pandas-dev/pandas/pull/23762?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/24bce1a5fdd70a66b9fb5e2f9f51631d1df6add3?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23762/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23762?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23762   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         161      161           
  Lines       51408    51408           
=======================================
  Hits        47416    47416           
  Misses       3992     3992
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.62% <ø> (ø)` | :arrow_up: |
| #single | `42.3% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23762?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23762?src=pr&el=footer). Last update [24bce1a...c727003](https://codecov.io/gh/pandas-dev/pandas/pull/23762?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @eoveson 
Thanks everyone for your feedback and the quick action on my pull request!
Add tz param to to_datetime()  when utc=True and errors='ignore'
State: closed

- [x] closes #23758 
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
Hello @srinivasreddy! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/tools/datetimes.py`](https://github.com/srinivasreddy/pandas/blob/ae2003baa7dad6a89eec2dcd7c07236549c7bbb7/pandas/core/tools/datetimes.py) !


@srinivasreddy do you mind updating and addressing the test failures from the CI?
closing as stale. if you want to continue pls ping.
TST: groupby with daily frequency fails with NonExistentTimeError on clock change day in Brazil
State: closed

- [x] closes #23742
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [n/a ] whatsnew entry


Labels:
name: Timezones
description: Timezone data dtype
name: Resample
description: resample method

Comments:
Hello @simonjayhawkins! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/test_resample.py`](https://github.com/simonjayhawkins/pandas/blob/c253028c3eba9c54adc1142971045fd35769de21/pandas/tests/test_resample.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23756?src=pr&el=h1) Report
> Merging [#23756](https://codecov.io/gh/pandas-dev/pandas/pull/23756?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/db2066b7d31450aaa87f2efcef492162a3d08309?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23756/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23756?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23756   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files         161      161           
  Lines       51390    51390           
=======================================
  Hits        47411    47411           
  Misses       3979     3979
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.64% <ø> (ø)` | :arrow_up: |
| #single | `42.31% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23756?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23756?src=pr&el=footer). Last update [db2066b...c253028](https://codecov.io/gh/pandas-dev/pandas/pull/23756?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @simonjayhawkins
BUG: Series.to_json Not Serializing Name with orient='records'
State: closed

- [ ] closes #23584 
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: IO JSON
description: read_json, to_json, json_normalize

Comments:
Hello @charlesdong1991! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/io/json/json.py`](https://github.com/charlesdong1991/pandas/blob/b9ddd7ad95c79ae10a5581fd13ff7260643311b6/pandas/io/json/json.py) !

 - There are no PEP8 issues in the file [`pandas/tests/io/json/test_json_table_schema.py`](https://github.com/charlesdong1991/pandas/blob/b9ddd7ad95c79ae10a5581fd13ff7260643311b6/pandas/tests/io/json/test_json_table_schema.py) !


can you merge master and update
@charlesdong1991 how strongly do you feel about this PR? I'm not entirely sure this is the right approach and raised that question as such in the original issue. Curious if you have thoughts to that before merging master as maybe we should close instead of investing further time in this.
HI, @WillAyd, I just took another glimpse at the original issue and pandas doc for this, i guess what confused the people who raised the issue was the unclear doc, since `series.to_json` shares the doc with `df.to_json`, and following the doc, the output of `series.to_json` when `orient='records'` should be `[{column -> value}, … , {column -> value}]`, however the output of `series.to_json` is `[value, ..., value]`. And the same confusion could go to the `orient='index'`: `series.to_json(orient='index')`. For me the best approach to solve this issue would be separating doc strings for these instead of deprecating and rewriting existing functions. I would also suggest to close the issue code-wisely.
OK thanks @charlesdong1991 . Closing this as such
TST/CLN: refactor tests\io\formats\test_to_html.py
State: closed

- [n/a ] xref #22786
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [n/a ] whatsnew entry


Labels:
name: Refactor
description: Internal refactoring of code
name: Testing
description: pandas testing functions or related to the test suite
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap

Comments:
Hello @simonjayhawkins! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/io/formats/test_to_html.py`](https://github.com/simonjayhawkins/pandas/blob/51ef74dc0d1d6f7ecee844d372551013d60221d4/pandas/tests/io/formats/test_to_html.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23747?src=pr&el=h1) Report
> Merging [#23747](https://codecov.io/gh/pandas-dev/pandas/pull/23747?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/db2066b7d31450aaa87f2efcef492162a3d08309?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23747/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23747?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23747   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files         161      161           
  Lines       51390    51390           
=======================================
  Hits        47411    47411           
  Misses       3979     3979
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.64% <ø> (ø)` | :arrow_up: |
| #single | `42.31% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23747?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23747?src=pr&el=footer). Last update [db2066b...a4be64f](https://codecov.io/gh/pandas-dev/pandas/pull/23747?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

test failure as #23726.
thanks @simonjayhawkins
BUG Rename during dependency generation from conda
State: closed

- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Package pytables wasn't renamed as it was compared to full package specification.



Labels:
name: Clean

Comments:
Hello @FHaase! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`scripts/generate_pip_deps_from_conda.py`](https://github.com/FHaase/pandas/blob/c240a8c2475efcbf124e0a13095e8253bf8d6190/scripts/generate_pip_deps_from_conda.py) !


lgtm. @TomAugspurger 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23740?src=pr&el=h1) Report
> Merging [#23740](https://codecov.io/gh/pandas-dev/pandas/pull/23740?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e98032db44c95325edec23292be84cebed9af867?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23740/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23740?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23740   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files         161      161           
  Lines       51383    51383           
=======================================
  Hits        47404    47404           
  Misses       3979     3979
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.64% <ø> (ø)` | :arrow_up: |
| #single | `42.31% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23740?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23740?src=pr&el=footer). Last update [e98032d...c240a8c](https://codecov.io/gh/pandas-dev/pandas/pull/23740?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks. Opened https://github.com/pandas-dev/pandas/issues/23741 for the azure failure.
DEPR: deprecate default of keep_tz=False of DatetimeIndex.to_series
State: closed

Closes #17832



Labels:
name: Datetime
description: Datetime data dtype
name: Deprecate
description: Functionality to remove in pandas

Comments:
Hello @jorisvandenbossche! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/indexes/datetimes.py`](https://github.com/jorisvandenbossche/pandas/blob/75291853c5c39af9b8fef54d4a86919300e901a1/pandas/core/indexes/datetimes.py) !

 - There are no PEP8 issues in the file [`pandas/tests/frame/test_alter_axes.py`](https://github.com/jorisvandenbossche/pandas/blob/75291853c5c39af9b8fef54d4a86919300e901a1/pandas/tests/frame/test_alter_axes.py) !


lgtm.
can you add to the deprecation issue #6581 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23739?src=pr&el=h1) Report
> Merging [#23739](https://codecov.io/gh/pandas-dev/pandas/pull/23739?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e98032db44c95325edec23292be84cebed9af867?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23739/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23739?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23739      +/-   ##
==========================================
+ Coverage   92.25%   92.25%   +<.01%     
==========================================
  Files         161      161              
  Lines       51383    51388       +5     
==========================================
+ Hits        47404    47409       +5     
  Misses       3979     3979
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.64% <100%> (ø)` | :arrow_up: |
| #single | `42.31% <16.66%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23739?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/23739/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `96.14% <100%> (+0.02%)` | :arrow_up: |
| [pandas/io/parsers.py](https://codecov.io/gh/pandas-dev/pandas/pull/23739/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnNlcnMucHk=) | `95.55% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23739?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23739?src=pr&el=footer). Last update [e98032d...d1390ed](https://codecov.io/gh/pandas-dev/pandas/pull/23739?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @jorisvandenbossche 
I'm looking at enforcing this deprecation now.  Should we just change the default or go ahead and rip out keep_tz altogether?
TST/CLN: Fix/clean pytables test
State: closed

While working on #23731, I sometimes got a failing test for pytables -- based on the rest of the test, it seemed pretty clear that the `_maybe_remove(store, 'xx')` was not consistently used throughout the test, and so I thought I'd add it. I'm guessing the CI never hits this failure because it seems it would need more replications for that.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
Hello @h-vetinari! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/io/test_pytables.py`](https://github.com/h-vetinari/pandas/blob/c9dfec42e54240d40d122133189d81cb78c3ed4c/pandas/tests/io/test_pytables.py) !


Failure is due to #23726
not sure this actually solves a problem.
As I laid out in the OP, this solves a flaky test that doesn't fail in the CI (clean image every time), but it failed about 10x for me locally, and it was obvious from the error that the same input hat been written to a store key twice. Hence adding the  `_maybe_remove` consistently.

It's a small change, but why not make the test suite more stable?
ok I don't think these actually fix anything, but can't hur

that original function should be a contextmanager anyhow (welcome PR on that).
BUG: Don't extract header names if none specified
State: closed

Closes #11733.

Labels:
name: Bug
name: IO Excel
description: read_excel, to_excel
name: MultiIndex

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23703?src=pr&el=h1) Report
> Merging [#23703](https://codecov.io/gh/pandas-dev/pandas/pull/23703?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e413c491e090274aad78489cc17a2e29cbd8e269?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23703/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23703?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #23703   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51339    51339           
=======================================
  Hits        47360    47360           
  Misses       3979     3979
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.64% <ø> (ø)` | :arrow_up: |
| #single | `42.34% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23703?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/series.py](https://codecov.io/gh/pandas-dev/pandas/pull/23703/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc2VyaWVzLnB5) | `93.68% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23703?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23703?src=pr&el=footer). Last update [e413c49...4d0e2b3](https://codecov.io/gh/pandas-dev/pandas/pull/23703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you merge master.

@chris-b1 can you take a look here
Hello @gfyoung! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/io/excel.py`](https://github.com/gfyoung/pandas/blob/4d0e2b3597bc362c2f4bfb940bb1fdc73f1e0ffc/pandas/io/excel.py) !

 - There are no PEP8 issues in the file [`pandas/tests/io/test_excel.py`](https://github.com/gfyoung/pandas/blob/4d0e2b3597bc362c2f4bfb940bb1fdc73f1e0ffc/pandas/tests/io/test_excel.py) !


@chris-b1 @jreback : Rebased my changes, and all is green.  PTAL.
@chris-b1 @jreback : Any further thoughts on this?
@gfyoung it looks fine to me, but @chris-b1 should have a look.
Just to confirm, since they don't diff - none of the existing cases in the xlsx files were modified?  Assuming no, looks good to me!
@chris-b1 : I just added a new test to those Excel files.  None of the existing tabs were modified. 👍 
Alright, with three LGTM's, I think this is good to merge now. 🙂