Accepts integer/float string with units and raises when unit is ambiguous (2)
State: closed

Supersedes #21384.

- [x] closes #12136
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Timedelta
description: Timedelta data type

Comments:
Hello @Sup3rGeo! Thanks for updating the PR.





















Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on January 08, 2019 at 15:23 Hours UTC
@jorisvandenbossche Ok so I created another PR, we can continue on this one
One point we have to decide: So far, `Timedelta('3.1416')` raised and `Timedelta('2000')` passed.

What do we want to do?

In this PR I am just raising for `Timedelta('2000')` as well and updated all tests that were not following this.
The failure in TravisCI seems to be something unrelated to this feature in question. Is there anything I should change related to that?
@jreback I really don't know what to do to make this failing test in Travis CI pass. I need some help/pointers here.
merge master and push again
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23025?src=pr&el=h1) Report
> Merging [#23025](https://codecov.io/gh/pandas-dev/pandas/pull/23025?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ca842cc4bab2aa9d2b48c051a597d860f38345d8?src=pr&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/23025/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/23025?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #23025      +/-   ##
==========================================
- Coverage   92.37%   92.25%   -0.12%     
==========================================
  Files         166      161       -5     
  Lines       52384    51291    -1093     
==========================================
- Hits        48391    47320    -1071     
+ Misses       3993     3971      -22
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.64% <100%> (-0.16%)` | :arrow_down: |
| #single | `42.33% <64%> (-0.69%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/23025?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/tools/timedeltas.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvdG9vbHMvdGltZWRlbHRhcy5weQ==) | `98.36% <100%> (+0.32%)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `86.81% <100%> (-1.29%)` | :arrow_down: |
| [pandas/io/sas/sasreader.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3Nhcy9zYXNyZWFkZXIucHk=) | `86.2% <0%> (-9.95%)` | :arrow_down: |
| [pandas/io/formats/html.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2Zvcm1hdHMvaHRtbC5weQ==) | `93.14% <0%> (-6.2%)` | :arrow_down: |
| [pandas/core/sparse/scipy\_sparse.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3BhcnNlL3NjaXB5X3NwYXJzZS5weQ==) | `97.05% <0%> (-2.95%)` | :arrow_down: |
| [pandas/core/dtypes/common.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL2NvbW1vbi5weQ==) | `94.37% <0%> (-2.41%)` | :arrow_down: |
| [pandas/io/common.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2NvbW1vbi5weQ==) | `70.76% <0%> (-2.1%)` | :arrow_down: |
| [pandas/core/arrays/datetimelike.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2RhdGV0aW1lbGlrZS5weQ==) | `95.9% <0%> (-1.97%)` | :arrow_down: |
| [pandas/io/html.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2h0bWwucHk=) | `91.25% <0%> (-1.42%)` | :arrow_down: |
| [pandas/core/computation/check.py](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tcHV0YXRpb24vY2hlY2sucHk=) | `90.9% <0%> (-1.4%)` | :arrow_down: |
| ... and [108 more](https://codecov.io/gh/pandas-dev/pandas/pull/23025/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23025?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/23025?src=pr&el=footer). Last update [ca842cc...dbe8fae](https://codecov.io/gh/pandas-dev/pandas/pull/23025?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

This one is green as well.
needs a rebase and pls respond to comments
So I think I was commenting but was creating a review that I had not submit

I hope you can see the replies now?
@jreback seems like everything is passing except one job in Azure that fails before running tests.
pls merge master
can you merge master and i will look 
can you merge master and update
can you merge master
Waiting for a seemingly bug in pytest

https://github.com/pytest-dev/pytest/issues/4617
@Sup3rGeo can you merge master here? Looks like the relevant issue you linked is closed
can you merge master
would love to see this, can you merge master and update
Would be nice but I think this has gone stale. @Sup3rGeo please ping if you'd like to pick this one back up!