BrandonFors/pandas-github-issues huggingface dataset:
DOC GH22897 Fix docstring of join in pandas/core/frame.py
State: closed

- [X] closes #22897
- [X] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

#22900 was dealt with by adding an "import pandas as pd" line to the start of the examples section.

Labels:
name: Docs
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Hello @JustinZhengBC! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/frame.py`](https://github.com/JustinZhengBC/pandas/blob/cf5669862842c6a7042056f32d3e70c3ec4b7472/pandas/core/frame.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22904?src=pr&el=h1) Report
> Merging [#22904](https://codecov.io/gh/pandas-dev/pandas/pull/22904?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/14598c6f82973b33d8b55e1e493f6103f9e16a62?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22904/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22904?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22904   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50830    50830           
=======================================
  Hits        46860    46860           
  Misses       3970     3970
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <ø> (ø)` | :arrow_up: |
| #single | `42.37% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22904?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/22904/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.2% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22904?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22904?src=pr&el=footer). Last update [14598c6...05988d4](https://codecov.io/gh/pandas-dev/pandas/pull/22904?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Alright, I believe I have taken care of all the other issues now.
I fixed those issues. I also added some backticks around parameter names in other sections, as that was what other docstrings seemed to be doing.
I changed the backticks around the df's to be single again.
Superseded by #23471
BLD: Drop nonexistent dependency of _libs/parsers
State: closed

Title is self-explanatory.

Follow-up to #22469.
Closes #22831.

Labels:
name: Build
description: Library building on various platforms

Comments:
Hello @gfyoung! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`setup.py`](https://github.com/gfyoung/pandas/blob/9414b176934866737a8a374dd0cb50c03bd68de4/setup.py) !


@jreback @jbrockmendel : Are you able to confirm locally that the rebuild no longer occurs?
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22883?src=pr&el=h1) Report
> Merging [#22883](https://codecov.io/gh/pandas-dev/pandas/pull/22883?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e45a6c14fc969c31c46ae890e72883ffe6658b4e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22883/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22883?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22883   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50830    50830           
=======================================
  Hits        46860    46860           
  Misses       3970     3970
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <ø> (ø)` | :arrow_up: |
| #single | `42.37% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22883?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22883?src=pr&el=footer). Last update [e45a6c1...9414b17](https://codecov.io/gh/pandas-dev/pandas/pull/22883?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Yep, that solved it for me locally.  Nice catch.
@gfyoung thanks!
Allow passing a mask to NanOps
State: closed

- [x] closes #22764
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] pytest --doctest-modules pandas/core/nanops.py
- [TO DO] whatsnew entry

Added Docs String and Examples to NanOps


Labels:
name: Enhancement
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
Hello @alimcmaster1! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/core/nanops.py`](https://github.com/alimcmaster1/pandas/blob/dcea82d371ffa107c17e1861a6df87082656a52a/pandas/core/nanops.py) !

 - There are no PEP8 issues in the file [`pandas/tests/test_nanops.py`](https://github.com/alimcmaster1/pandas/blob/dcea82d371ffa107c17e1861a6df87082656a52a/pandas/tests/test_nanops.py) !



##### Comment last updated on September 30, 2018 at 18:00 Hours UTC
can you rebase on master
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22865?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@08ecba8`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `97.67%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22865/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22865?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #22865   +/-   ##
=========================================
  Coverage          ?   92.19%           
=========================================
  Files             ?      169           
  Lines             ?    50828           
  Branches          ?        0           
=========================================
  Hits              ?    46862           
  Misses            ?     3966           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.61% <97.67%> (?)` | |
| #single | `42.36% <55.81%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/nanops.py](https://codecov.io/gh/pandas-dev/pandas/pull/22865/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvbmFub3BzLnB5) | `95.2% <97.67%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22865?src=pr&el=footer). Last update [08ecba8...dacdbec](https://codecov.io/gh/pandas-dev/pandas/pull/22865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @alimcmaster1
Add Azure Pipelines badge to readme
State: closed


Labels:
name: Docs

Comments:
thanks @zooba very nice!
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22828?src=pr&el=h1) Report
> Merging [#22828](https://codecov.io/gh/pandas-dev/pandas/pull/22828?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/183a41620c596bfc58edef5deb53d53e8bb4b798?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22828/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22828?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22828   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50820    50820           
=======================================
  Hits        46850    46850           
  Misses       3970     3970
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <ø> (ø)` | :arrow_up: |
| #single | `42.38% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22828?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22828?src=pr&el=footer). Last update [183a416...367cf14](https://codecov.io/gh/pandas-dev/pandas/pull/22828?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
DOC: fix a failing doctest in DataFrame.to_dict
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Based on #22459. Fix the docstring for DataFrame.to_dict. I also updated `ci/doctests.sh`.

Labels:
name: Docs

Comments:
Hello @Moisan! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/frame.py`](https://github.com/Moisan/pandas/blob/ecdd114f75231936995e3c02b96b8686a414dfaf/pandas/core/frame.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22827?src=pr&el=h1) Report
> Merging [#22827](https://codecov.io/gh/pandas-dev/pandas/pull/22827?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/cf11f71e423be65e9c2ae83ea1bab8b69ee79ca4?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22827/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22827?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22827   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files         170      170           
  Lines       51017    51017           
=======================================
  Hits        47011    47011           
  Misses       4006     4006
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.57% <ø> (ø)` | :arrow_up: |
| #single | `42.3% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22827?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/22827/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.11% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22827?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22827?src=pr&el=footer). Last update [cf11f71...64f6050](https://codecov.io/gh/pandas-dev/pandas/pull/22827?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Sorry, from looking at the diff now, I don't find this an actual improvement. Eg in the output

```
{'cat': {'legs': 4, 'wings': 0}, 'falcon': {'legs': 2, 'wings': 2}}
```

I really have to think hard "are legs/wings the columns or was it cat/falcon ?" to know what the structure is (`{index -> {column -> value}}` or `{column ->  {index -> value}}`)

I find this is easier to see from a glance with something like:
```
{'row1': {'col1': 4, 'col2': 0}, 'row2': {'col1': 2, 'col2': 2}}
```
thanks @Moisan
BUG: Merge timezone aware data with DST
State: closed

- [x] closes #18885
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

When merging timezone aware data using `where`, make the comparison in UTC to avoid relocalizing on an ambiguous time.

Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Timezones
description: Timezone data dtype

Comments:
Hello @mroeschke! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/indexes/datetimelike.py`](https://github.com/mroeschke/pandas/blob/ce784e005f241868d1181afce9e172c1f391d595/pandas/core/indexes/datetimelike.py) !

 - There are no PEP8 issues in the file [`pandas/tests/reshape/merge/test_merge.py`](https://github.com/mroeschke/pandas/blob/ce784e005f241868d1181afce9e172c1f391d595/pandas/tests/reshape/merge/test_merge.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22825?src=pr&el=h1) Report
> Merging [#22825](https://codecov.io/gh/pandas-dev/pandas/pull/22825?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2f1b842119bc4d5242b587b62bde71d8f7ef19f8?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22825/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22825?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22825      +/-   ##
==========================================
+ Coverage   92.18%   92.19%   +<.01%     
==========================================
  Files         169      169              
  Lines       50830    50833       +3     
==========================================
+ Hits        46860    46863       +3     
  Misses       3970     3970
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <100%> (ø)` | :arrow_up: |
| #single | `42.37% <11.11%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22825?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/datetimelike.py](https://codecov.io/gh/pandas-dev/pandas/pull/22825/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZWxpa2UucHk=) | `98.11% <100%> (+0.01%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22825?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22825?src=pr&el=footer). Last update [2f1b842...e4491d8](https://codecov.io/gh/pandas-dev/pandas/pull/22825?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Addressed your comments @jreback and all green.
All green besides a unrelated, failed connection to a s3 parquet test. 
All green besides a unrelated, failed connection to a s3 parquet test.
thanks @mroeschke
DOC: fixup spacing in to_csv docstring (GH22475)
State: closed

Follow-up on https://github.com/pandas-dev/pandas/pull/22475

Labels:
name: Docs

Comments:
Hello @jorisvandenbossche! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/generic.py`](https://github.com/jorisvandenbossche/pandas/blob/4d84ba695349d035381543031142772e63604d3f/pandas/core/generic.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22816?src=pr&el=h1) Report
> Merging [#22816](https://codecov.io/gh/pandas-dev/pandas/pull/22816?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/64b88e86677349de66071dffd74b5c3254283e2a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22816/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22816?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22816   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50820    50820           
=======================================
  Hits        46850    46850           
  Misses       3970     3970
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <ø> (ø)` | :arrow_up: |
| #single | `42.38% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22816?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/22816/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `96.67% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22816?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22816?src=pr&el=footer). Last update [64b88e8...4d84ba6](https://codecov.io/gh/pandas-dev/pandas/pull/22816?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
ERR: Clarify location of EOF on unbalanced quotes
State: closed

* Clarifies message in the C engine (original issue)
* Python's `csv` module no longer fires specific errors for that, so removed it from handling

Closes #22789.

Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: IO CSV
description: read_csv, to_csv

Comments:
Hello @gfyoung! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/io/parsers.py`](https://github.com/gfyoung/pandas/blob/80b1c979856e3adf5627a2bebfdc5c8aa120b77e/pandas/io/parsers.py) !

 - There are no PEP8 issues in the file [`pandas/tests/io/parser/common.py`](https://github.com/gfyoung/pandas/blob/80b1c979856e3adf5627a2bebfdc5c8aa120b77e/pandas/tests/io/parser/common.py) !

 - There are no PEP8 issues in the file [`pandas/tests/io/parser/quoting.py`](https://github.com/gfyoung/pandas/blob/80b1c979856e3adf5627a2bebfdc5c8aa120b77e/pandas/tests/io/parser/quoting.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22814?src=pr&el=h1) Report
> Merging [#22814](https://codecov.io/gh/pandas-dev/pandas/pull/22814?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2ab57b2dfc7005e580698c3e0bdf9478e96647db?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22814/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22814?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22814      +/-   ##
==========================================
+ Coverage   92.18%   92.18%   +<.01%     
==========================================
  Files         169      169              
  Lines       50820    50818       -2     
==========================================
- Hits        46850    46849       -1     
+ Misses       3970     3969       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <ø> (ø)` | :arrow_up: |
| #single | `42.38% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22814?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/parsers.py](https://codecov.io/gh/pandas-dev/pandas/pull/22814/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnNlcnMucHk=) | `95.6% <ø> (+0.05%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22814?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22814?src=pr&el=footer). Last update [2ab57b2...80b1c97](https://codecov.io/gh/pandas-dev/pandas/pull/22814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

ok this all looks good. worth a what's note?
> ok this all looks good. worth a what's note?

I was on the fence for that one.  It's so small that it didn't seem to merit it...up to you. 🙂 
nope looks good. thanks
BUG: Avoid AmbiguousTime or NonExistentTime Error when resampling
State: closed

- [x] closes #19375
- [x] closes #10117
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Timezones
description: Timezone data dtype
name: Resample
description: resample method

Comments:
Hello @mroeschke! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/resample.py`](https://github.com/mroeschke/pandas/blob/acd9128d73334e7a8da00ff2963a443c17311791/pandas/core/resample.py) !

 - There are no PEP8 issues in the file [`pandas/tests/test_resample.py`](https://github.com/mroeschke/pandas/blob/acd9128d73334e7a8da00ff2963a443c17311791/pandas/tests/test_resample.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22809?src=pr&el=h1) Report
> Merging [#22809](https://codecov.io/gh/pandas-dev/pandas/pull/22809?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bdb7a1603f1e0948ca0cab011987f616e7296167?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22809/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22809?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22809      +/-   ##
==========================================
+ Coverage   92.18%   92.18%   +<.01%     
==========================================
  Files         169      169              
  Lines       50810    50812       +2     
==========================================
+ Hits        46839    46842       +3     
+ Misses       3971     3970       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <100%> (ø)` | :arrow_up: |
| #single | `42.37% <0%> (+0.04%)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22809?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/resample.py](https://codecov.io/gh/pandas-dev/pandas/pull/22809/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzYW1wbGUucHk=) | `96.97% <100%> (+0.18%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22809?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22809?src=pr&el=footer). Last update [bdb7a16...acd9128](https://codecov.io/gh/pandas-dev/pandas/pull/22809?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @mroeschke