BUG: fallback from issue 20824 no longer occurs due to skipna flag
State: closed

- [ ] closes #20824
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Issue #20824 found that a fallback was occuring when df.Groupby().sum() was called with the skipna flag. This was occurring because the _cython_agg_general function was not accepting the argument, which has now been fixed. The fallback still occurs with strings in the df, however this is a deeper issue stemming from the _aggregate() call in groupby/ops.py (line 572).


Labels:

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=h1) Report
> Merging [#26176](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bbcfc7fba2c730d4df18f93f7f95ad439c26c31b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `30%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26176/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26176      +/-   ##
==========================================
- Coverage   91.98%   91.96%   -0.02%     
==========================================
  Files         175      175              
  Lines       52371    52380       +9     
==========================================
- Hits        48175    48173       -2     
- Misses       4196     4207      +11
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.52% <30%> (-0.02%)` | :arrow_down: |
| #single | `40.7% <30%> (-0.15%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/26176/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS9nZW5lcmljLnB5) | `88.21% <30%> (-0.81%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26176/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26176/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `96.9% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=footer). Last update [bbcfc7f...b6fae71](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=h1) Report
> Merging [#26176](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bbcfc7fba2c730d4df18f93f7f95ad439c26c31b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `30%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26176/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26176      +/-   ##
==========================================
- Coverage   91.98%   91.96%   -0.02%     
==========================================
  Files         175      175              
  Lines       52371    52380       +9     
==========================================
- Hits        48175    48173       -2     
- Misses       4196     4207      +11
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.52% <30%> (-0.02%)` | :arrow_down: |
| #single | `40.7% <30%> (-0.15%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/26176/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS9nZW5lcmljLnB5) | `88.21% <30%> (-0.81%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26176/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26176/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `96.9% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=footer). Last update [bbcfc7f...b6fae71](https://codecov.io/gh/pandas-dev/pandas/pull/26176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).