BrandonFors/pandas-github-issues huggingface dataset:
Fix bugs in WeekOfMonth.apply, Week.onOffset
State: closed

In the process we get rid of `WeekOfMonth.getOffsetOfMonth` and `LastWeekOfMonth.getOffsetOfMonth`, which were idiosyncratic what arguments they passed to `datetime`.

The issues this addresses are orthogonal to #18762, but the code affected does overlap.  In particular, after this, `roll_monthday` will not be needed in 18762.

closes #18864
closes #18672 
closes #18510
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Frequency
description: DateOffsets

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18875?src=pr&el=h1) Report
> Merging [#18875](https://codecov.io/gh/pandas-dev/pandas/pull/18875?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/316acbf065f5d1e30fdc7fcced3a53a2f4b14655?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18875/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/18875?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18875      +/-   ##
==========================================
- Coverage   91.65%   91.64%   -0.01%     
==========================================
  Files         154      154              
  Lines       51368    51364       -4     
==========================================
- Hits        47080    47074       -6     
- Misses       4288     4290       +2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.51% <100%> (-0.01%)` | :arrow_down: |
| #single | `40.84% <21.62%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18875?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/18875/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `96.78% <100%> (-0.17%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18875?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18875?src=pr&el=footer). Last update [316acbf...e71374f](https://codecov.io/gh/pandas-dev/pandas/pull/18875?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Ping
thanks!
[WIP] Prod/Sum of all-NA / all-empty
State: closed

To make review a bit easier, I've opened this before it's complete.

Of course we still need to decide

1. Do we want
    a. `sum([]) = 0`; `prod([]) = 1`
    b. `sum([NaN]) = 0`; `prod([NaN])` = 1 
2. Do we like the keyword approach (requiring people who want empty to be NA to always specify it) or do we want a new method?
3. Do we like the `empty_is_na` keyword? Alternatives are `fill_value`, ...
4. Does this apply to groupby (unobserved categoricals)
5. Does this apply to resample?

There are still some failing tests. I've tried to keep the commits separate:

- groupby: https://github.com/pandas-dev/pandas/commit/e96e38649b9e6784fda2eae3de6c72c44f6ca813
- resample: https://github.com/pandas-dev/pandas/commit/20f2ccc4fa2bcb559732e1b37a8671f29d7ef54b

closes #18678 

Labels:

Comments:
Hello @TomAugspurger! Thanks for submitting the PR.





 - In the file [`pandas/tests/frame/test_analytics.py`](https://github.com/pandas-dev/pandas/blob/d7e9f4a0eeda0c6b632c575fa5f832c76183089b/pandas/tests/frame/test_analytics.py), following are the PEP8 issues :

> [Line 804:29](https://github.com/pandas-dev/pandas/blob/d7e9f4a0eeda0c6b632c575fa5f832c76183089b/pandas/tests/frame/test_analytics.py#L804): [E225](https://duckduckgo.com/?q=pep8%20E225) missing whitespace around operator



 - In the file [`pandas/tests/groupby/test_categorical.py`](https://github.com/pandas-dev/pandas/blob/d7e9f4a0eeda0c6b632c575fa5f832c76183089b/pandas/tests/groupby/test_categorical.py), following are the PEP8 issues :

> [Line 686:49](https://github.com/pandas-dev/pandas/blob/d7e9f4a0eeda0c6b632c575fa5f832c76183089b/pandas/tests/groupby/test_categorical.py#L686): [W292](https://duckduckgo.com/?q=pep8%20W292) no newline at end of file









 - In the file [`pandas/tests/test_nanops.py`](https://github.com/pandas-dev/pandas/blob/d7e9f4a0eeda0c6b632c575fa5f832c76183089b/pandas/tests/test_nanops.py), following are the PEP8 issues :

> [Line 1058:48](https://github.com/pandas-dev/pandas/blob/d7e9f4a0eeda0c6b632c575fa5f832c76183089b/pandas/tests/test_nanops.py#L1058): [W292](https://duckduckgo.com/?q=pep8%20W292) no newline at end of file




Superseded by https://github.com/pandas-dev/pandas/pull/18876
DOC: Modify astype copy=False example to work across platforms
State: closed

- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Very minor, just changed `'int'` -> `'int64'`.

The example as previously written does not work on Windows, since `astype('int')` converts to `int32` instead of `int64`.  The `Series` constructor defaults to `int64`, so on Windows the `astype` ends up making a copy since the dtype changes, and thus the propagation to `s1` doesn't occur.

This shouldn't impact Linux or Mac, since `astype('int')` converts to `int64` on those platforms, so `astype('int64')` should be equivalent.  I suppose this might not work for people using 32 bit distributions (?), but this should have wider coverage of potential readers of the docs, and is less confusing than using something like `'intp'`.

Labels:
name: Docs

Comments:
thanks!
ENH: Let Categorical.rename_categories take a callable
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

This PR allows ``Categorical.rename_categories`` to take a callable as its argument.

This is useful for quickly changing the categories the same way for all categories, e.g.

```python
>>> pd.Categorical(['a', 'b']).rename_categories("cat_{}".format)
[cat_a, cat_b]
Categories (2, object): [cat_a, cat_b]
```

Labels:
name: Enhancement
name: Categorical
description: Categorical Data Type

Comments:
Updated and all green.
BTW, on Github, in the timeline this is added to the 0.22 milestone, but on the right side overview, it says milestone 0.23.

Seems to be something strange going on?
thanks @topper-123 

we are going to release 0.22 shortly with #18876 only, everything else gets moved to 0.23.
CLN: Drop compact_ints/use_unsigned from read_csv
State: closed

Deprecated in v0.19.0

xref #13323


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Clean

Comments:
All is green.  Anyone welcome to have a look to merge this.
wait on merging anything
Ah, right.  Travis is still failing.  Got it.
Function removed, and all is green still.  PTAL.
thanks @gfyoung
Make DatetimeIndex iterator pickleable by dill
State: closed

Currently, dill (https://github.com/uqfoundation/dill) cannot pickle iterators over DatetimeIndex because they are generators. This simple change removes that limitation.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype
name: Compat
description: pandas objects compatability with Numpy or Python functions
name: Needs Discussion
description: Requires discussion from core team before further action

Comments:
@rmihael : Thanks for the PR!  The change is relatively harmless it seems, so I'm okay with merging.  However, should get feedback from @jreback and @jorisvandenbossche to double check.
yep looks fine. thanks.
thanks!
@rmihael do you know the reason / case that this was useful?
@rmihael to give some context, we reverted this PR in https://github.com/pandas-dev/pandas/pull/21027 because it introduced a bug.
Sorry for the silence. I used dill to run multiprocess optimizations using the backtrader framework. I can use cloudpickle with the same success, so there is no need to add extra complexity to the codebase.
no problem, thanks for answering!
Dec cleanup
State: closed

- [X] closes #18190 
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

This should be the last commit to close out the issue referenced above. I think there's further opportunity to convert some of the imperative ``pytest.skip`` calls over to the new decorator methodology (especially Ibn ``pandas/tests/io``) but to keep the scope clean I would rather open a new issue for those rather than continually update #18190

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Looking into Travis failures. I was only grepping the pandas directory for ``skip_if_no`` uses but looks like I missed some in ``conftest.py``
thanks @WillAyd very nice set of patches!
@WillAyd General comment, please give your PRs a bit more descriptive title (@jreback please also do that before merging so the commit title is more informative when looking at the log)
DEPR: Deprecate skip_footer in read_excel
State: closed

For consistency with `read_csv`, which uses `skipfooter`.

Labels:
name: IO Excel
description: read_excel, to_excel
name: Deprecate
description: Functionality to remove in pandas

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18836?src=pr&el=h1) Report
> Merging [#18836](https://codecov.io/gh/pandas-dev/pandas/pull/18836?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b6a7cc9d4686f62596de031c9cc4a1d62d12c52e?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18836/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/18836?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18836      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51408    51406       -2     
==========================================
- Hits        47113    47101      -12     
- Misses       4295     4305      +10
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.49% <100%> (-0.01%)` | :arrow_down: |
| #single | `40.84% <100%> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18836?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/excel.py](https://codecov.io/gh/pandas-dev/pandas/pull/18836/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2V4Y2VsLnB5) | `90.09% <100%> (-0.04%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18836/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18836/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.68% <0%> (-0.11%)` | :arrow_down: |
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/18836/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.62% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18836?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18836?src=pr&el=footer). Last update [b6a7cc9...7045d51](https://codecov.io/gh/pandas-dev/pandas/pull/18836?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
CLN: Drop the buffer_lines parameter in read_csv
State: closed

Deprecated back in 0.19.0

xref #13360.

Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18835?src=pr&el=h1) Report
> Merging [#18835](https://codecov.io/gh/pandas-dev/pandas/pull/18835?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b6a7cc9d4686f62596de031c9cc4a1d62d12c52e?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18835/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/18835?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18835      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51408    51408              
==========================================
- Hits        47113    47103      -10     
- Misses       4295     4305      +10
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.49% <ø> (-0.01%)` | :arrow_down: |
| #single | `40.83% <ø> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18835?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/parsers.py](https://codecov.io/gh/pandas-dev/pandas/pull/18835/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnNlcnMucHk=) | `95.49% <ø> (ø)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18835/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18835/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.68% <0%> (-0.11%)` | :arrow_down: |
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/18835/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.62% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18835?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18835?src=pr&el=footer). Last update [b6a7cc9...1fa4bbf](https://codecov.io/gh/pandas-dev/pandas/pull/18835?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Prevent RecursionError on Timestamp comparison against object array
State: closed

Timedelta comparison already handled this correctly but I didn't see a test for it, so added one.

- [x] closes #15183
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype
name: Timedelta
description: Timedelta data type
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18829?src=pr&el=h1) Report
> Merging [#18829](https://codecov.io/gh/pandas-dev/pandas/pull/18829?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b6a7cc9d4686f62596de031c9cc4a1d62d12c52e?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18829/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/18829?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18829      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51408    51408              
==========================================
- Hits        47113    47104       -9     
- Misses       4295     4304       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.49% <ø> (ø)` | :arrow_up: |
| #single | `40.83% <ø> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18829?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18829/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18829/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.68% <0%> (-0.11%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18829?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18829?src=pr&el=footer). Last update [b6a7cc9...3820a2f](https://codecov.io/gh/pandas-dev/pandas/pull/18829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

nice thanks!
BUG: raise error for groupby() with invalid tuple key
State: closed

- [x] closes #18798
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Groupby
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18826?src=pr&el=h1) Report
> Merging [#18826](https://codecov.io/gh/pandas-dev/pandas/pull/18826?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b6a7cc9d4686f62596de031c9cc4a1d62d12c52e?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18826/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/18826?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18826      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51408    51408              
==========================================
- Hits        47113    47104       -9     
- Misses       4295     4304       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.49% <100%> (ø)` | :arrow_up: |
| #single | `40.83% <0%> (-0.12%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18826?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby.py](https://codecov.io/gh/pandas-dev/pandas/pull/18826/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS5weQ==) | `92.07% <100%> (ø)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18826/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18826/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.68% <0%> (-0.11%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18826?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18826?src=pr&el=footer). Last update [b6a7cc9...5fc5240](https://codecov.io/gh/pandas-dev/pandas/pull/18826?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
BUG make hashtable.unique support readonly arrays
State: closed

This problem was brought up in
https://github.com/pandas-dev/pandas/issues/18773 and effectively comes
down to how Cython deals with readonly arrays. While it would be ideal
for Cython to fix the underlying problem in the meantime we can rely on
this.

- [x] closes #18773
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18825?src=pr&el=h1) Report
> Merging [#18825](https://codecov.io/gh/pandas-dev/pandas/pull/18825?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/cdebcf374598e9141df7dc23bc75c9528e92c004?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18825/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18825?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18825      +/-   ##
==========================================
+ Coverage   91.59%   91.59%   +<.01%     
==========================================
  Files         150      150              
  Lines       48959    48959              
==========================================
+ Hits        44843    44845       +2     
+ Misses       4116     4114       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.96% <ø> (ø)` | :arrow_up: |
| #single | `41.13% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18825?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/18825/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.9% <0%> (+0.21%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18825?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18825?src=pr&el=footer). Last update [cdebcf3...ddb5247](https://codecov.io/gh/pandas-dev/pandas/pull/18825?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hello @hexgnu! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on December 23, 2017 at 20:56 Hours UTC
I pushed a fix. ping on green.
Awesome thanks @jreback looks like it all passed.
thanks @hexgnu 
keep em coming!