CLN: Dead version checking code post minimum version bump
State: closed

- [x] xref #26832
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`


Labels:
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=h1) Report
> Merging [#27063](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ff50b46045886604dd70438f73df7bf9da3da89b?src=pr&el=desc) will **decrease** coverage by `50.18%`.
> The diff coverage is `25%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/27063/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           master   #27063       +/-   ##
===========================================
- Coverage   92.04%   41.86%   -50.19%     
===========================================
  Files         180      180               
  Lines       50713    50711        -2     
===========================================
- Hits        46680    21230    -25450     
- Misses       4033    29481    +25448
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `?` | |
| #single | `41.86% <25%> (-0.09%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/pytables.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3B5dGFibGVzLnB5) | `89.37% <ø> (-0.94%)` | :arrow_down: |
| [pandas/io/html.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2h0bWwucHk=) | `20.35% <25%> (-73.94%)` | :arrow_down: |
| [pandas/io/formats/latex.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2Zvcm1hdHMvbGF0ZXgucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [pandas/io/gcs.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2djcy5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [pandas/io/sas/sas\_constants.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3Nhcy9zYXNfY29uc3RhbnRzLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [pandas/core/groupby/categorical.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS9jYXRlZ29yaWNhbC5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [pandas/tseries/plotting.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvcGxvdHRpbmcucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [pandas/tseries/converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvY29udmVydGVyLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [pandas/io/s3.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3MzLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [pandas/io/formats/html.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2Zvcm1hdHMvaHRtbC5weQ==) | `0% <0%> (-99.37%)` | :arrow_down: |
| ... and [134 more](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=footer). Last update [ff50b46...124b2c5](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=h1) Report
> Merging [#27063](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/d94146cf5d5d9f899a31308d0a4d9e5d132f6442?src=pr&el=desc) will **decrease** coverage by `0.2%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/27063/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #27063      +/-   ##
==========================================
- Coverage   92.04%   91.84%   -0.21%     
==========================================
  Files         180      180              
  Lines       50714    50728      +14     
==========================================
- Hits        46680    46590      -90     
- Misses       4034     4138     +104
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.48% <100%> (-0.2%)` | :arrow_down: |
| #single | `41.89% <0%> (-0.08%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/pytables.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3B5dGFibGVzLnB5) | `90.33% <ø> (+0.03%)` | :arrow_up: |
| [pandas/io/html.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2h0bWwucHk=) | `94.24% <100%> (-0.06%)` | :arrow_down: |
| [pandas/compat/pickle\_compat.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2NvbXBhdC9waWNrbGVfY29tcGF0LnB5) | `63.88% <0%> (-12.5%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `88.88% <0%> (-11.12%)` | :arrow_down: |
| [pandas/core/sparse/series.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3BhcnNlL3Nlcmllcy5weQ==) | `88.99% <0%> (-5.92%)` | :arrow_down: |
| [pandas/core/indexes/period.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9wZXJpb2QucHk=) | `90.43% <0%> (-2.16%)` | :arrow_down: |
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `94.23% <0%> (-2.15%)` | :arrow_down: |
| [pandas/core/sparse/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3BhcnNlL2ZyYW1lLnB5) | `93.56% <0%> (-2.07%)` | :arrow_down: |
| [pandas/core/panel.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcGFuZWwucHk=) | `16.09% <0%> (-1.71%)` | :arrow_down: |
| [pandas/core/series.py](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc2VyaWVzLnB5) | `92.23% <0%> (-1.44%)` | :arrow_down: |
| ... and [18 more](https://codecov.io/gh/pandas-dev/pandas/pull/27063/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=footer). Last update [d94146c...33259db](https://codecov.io/gh/pandas-dev/pandas/pull/27063?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Agreed with changing to ImportError.

On Wed, Jun 26, 2019 at 3:49 PM Matthew Roeschke <notifications@github.com>
wrote:

> *@mroeschke* commented on this pull request.
> ------------------------------
>
> In pandas/io/html.py
> <https://github.com/pandas-dev/pandas/pull/27063#discussion_r297860479>:
>
> > @@ -831,9 +832,13 @@ def _parser_dispatch(flavor):
>              raise ImportError(
>                  "BeautifulSoup4 (bs4) not found, please install it")
>          import bs4
> -        if LooseVersion(bs4.__version__) <= LooseVersion('4.2.0'):
> -            raise ValueError("A minimum version of BeautifulSoup 4.2.1 "
> -                             "is required")
> +        minimum_bs4_version = VERSIONS['bs4']
>
> Ah so this wasn't changed because import_optional_dependency will raise a
> ImportError while this path raises a ValueError (there's a test for this).
>
> I think it's worth changing to an ImportError. Thoughts @TomAugspurger
> <https://github.com/TomAugspurger>?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/27063?email_source=notifications&email_token=AAKAOIXHASI3SAQLUFAQEPLP4PI4HA5CNFSM4H3VJN32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4YO34A#discussion_r297860479>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAKAOIWRYUDQGKUOCF5K3TLP4PI4HANCNFSM4H3VJN3Q>
> .
>

lgtm, checks are failing, ping on green.
```
home/vsts/work/1/s/doc/source/whatsnew/v0.25.0.rst:828: WARNING: Unknown interpreted text role "method".
```

doc-warning