BrandonFors/pandas-github-issues huggingface dataset:
BUG: Index[offset_objects] + Period
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: Frequency
description: DateOffsets
name: Period
description: Period data type

Comments:
> this is only an issue on main?

No, the incorrect raising also occurs on 1.5.0
So does the not necessarily close https://github.com/pandas-dev/pandas/issues/50162?
> So does the not necessarily close https://github.com/pandas-dev/pandas/issues/50162?

No
Thanks @jbrockmendel
CI fix githubusercontent in links
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

thanks @lithomas1 for the fix!

Labels:
name: CI
description: Continuous Integration

Comments:
Thanks @MarcoGorelli
Update doc URL in `setup.cfg` (for `1.5.x`)
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
This came out of recent discussion with @jorisvandenbossche ( https://github.com/conda-forge/pandas-feedstock/pull/147#discussion_r1048944958 )
thx @jakirkham 

You can combine prs like you did in the future 
Thanks @phofl! 🙏

So this one was making the change to 1.5.x. In 2, this has moved to a different file, which the other PR updated
Ah thx, missed that.
No worries. Also thanks for the reviews 🙏
Update doc URL in `pyproject.toml`
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
This came out of recent discussion with @jorisvandenbossche ( https://github.com/conda-forge/pandas-feedstock/pull/147#discussion_r1048944958 )
thx @jakirkham
Backport PR #50238 on branch 1.5.x ( REGR: to_datetime with non-ISO format, float, and nan fails on main)
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Why are we back porting if this only fails on main?
🤦 my bad, not need to, thanks for having caught this
DOC: Adding link in StringArray and ArrowStringArray docs
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the pull request, but appears this is already being worked on with https://github.com/pandas-dev/pandas/pull/50241 so closing. Happy to have other pull requests for issues that are not being worked on!
CI remove scorecards
State: closed

xref https://github.com/pandas-dev/pandas/pull/50262

I don't think this has helped find anything, all it does it make CI red

We can reevaluate it in the future if and when it become more reliable, but for now it's just a pain

Labels:
name: CI
description: Continuous Integration

Comments:
good point, thanks
Thanks @MarcoGorelli
CI new numpy nightly failing some tests
State: closed

- [ ] closes #50267 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration

Comments:
thx @MarcoGorelli
BUG: out-of-bounds pydatetime with errors='coerce' and non-ISO format coerces all elements to NaT
State: closed

- [ ] closes #50255 (Replace xxxx with the GitHub issue number)
- [ ] closes #50266 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I haven't added a whatsnew note for #50255 , as this feature (parsing pydatetime / datetime / np.datetime64) objects with non-ISO formats wasn't available to users in the previous release anyway

----

This is much easier to review with "hide whitespace", as many of the changes are just changing a level of indentation

![image](https://user-images.githubusercontent.com/33491632/207829424-890402ed-89bc-4796-82f9-8a4b23d3eef4.png)


Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
@jbrockmendel @mroeschke sorry for the ping, just wanted to ask if we could get this one in, as:
- it unblocks #50361 
- which in turn unblocks #50242 

That would conclude the major `to_datetime` block of work I was planning to do - anything else would be relatively minor / fixing anything that comes up

Thanks 🙌
PERF: Series(pyarrow-backed).rank
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.0.0.rst` file if fixing a bug or adding a new feature.

Perf improvement in `Series(pyarrow-backed).rank` by using `pyarrow.compute.rank`. All parameter combinations use pyarrow compute functions except for `method="average"` which falls back to `algos.rank`.

```
import pandas as pd 
import numpy as np

ser = pd.Series(np.random.randn(10**6), dtype="float64[pyarrow]")

%timeit ser.rank(method="first")

# 1.41 s ± 10.3 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)    <- main
# 148 ms ± 1.42 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)  <- PR
```

Labels:
name: Performance
description: Memory or execution speed performance
name: Arrow
description: pyarrow functionality

Comments:
Thanks @lukemanley
REF: to_datetime handle non-object cases outside cython
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Refactor
description: Internal refactoring of code
name: Datetime
description: Datetime data dtype

Comments:
Thanks @jbrockmendel 
@jbrockmendel this looks like a likely culprit for https://asv-runner.github.io/asv-collection/pandas/#inference.ToDatetimeFromIntsFloats.time_sec_uint64

The regression occurred between d3e5e05 and 5f3c29e, so not totally sure that this is the problem, but the asv hits the code paths introduced here
More or less all the time is spend in astype_overflowsafe
Yah I noticed that too.  Reverting wouldn't be the worst thing, thought might be worth checking that the old version didn't allow silent overflows
CI: continue-on-error: true for scorecard action
State: closed

This job on main is currently failing with a 500 error 

```
 2022/12/14 18:00:45 error processing signature: http response 500, status: 500 Internal Server Error, error: {"code":500,"message":"something went wrong and we are looking into it."}
```

I am doubtful this is entirely actionable on our side (or if it ever will be), and it masks if there are actual failures on main so just letting this job "pass" even if there are these issues

Labels:
name: CI
description: Continuous Integration

Comments:
Darn that didn't work, maybe I have to manually skip the failing step

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error led me to believe you could do this for a entire job-id but I guess only if a strategy is used?
We can just delete the job, honestly. I find it kind of annoying, to be honest, and I don't think it really is catching actual security issues.

If we already have CodeQL, I think we should be fine.
agreed
POC: Devpy CLI
State: closed

- [ ] closes #47700 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Just a POC as to how a CLI would look like. I haven't implemented all commands, just the simple ones(build/test).

Labels:
name: Enhancement
name: Mothballed
description: Temporarily-closed PR the author plans to return to
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Still interested in working on this?

I think this would be cool to see, but I would be interested in seeing a mapping first from our current tool(s) and see if they can be consolidated into devpy commands
> Still interested in working on this?
> 
> I think this would be cool to see, but I would be interested in seeing a mapping first from our current tool(s) and see if they can be consolidated into devpy commands

Sorry for the silence. I'm planning on picking this up after the meson work lands (since devpy appears designed around meson as a build system).
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Going to close to clear the queue, but feel free to reopen when you're interested in picking back up
[BUG]Fix read_html error when URL include Unicode
State: closed

- [x] closes #47899 and #21499 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Let's tackle the last one after getting the approval for this PR.
I fixed the unicode URL issue for `read_html` function by converting the unicode-style URL.

```
# url:https://en.wikipedia.org/wiki/2013–14_Premier_League
# escaped:https://en.wikipedia.org/wiki/2013%E2%80%9314_Premier_League
```

Labels:
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap

Comments:
Sorry, I'll fix some tests first.
CI failure is just rate limit exceeded issue. I'll rerun later.

```
requests.exceptions.HTTPError: 403 Client Error: rate limit exceeded for url: https://api.github.com/users/wesm
```

Now, 32 Bit Linux test is canceled due to a timeout issue, and I think it is debugging in the below PR.
https://github.com/pandas-dev/pandas/pull/50376

however, failed and canceled tests are irrelevant issues for this PR, so after fixing the above test, I think this PR is fine. 
so, Please review the PR when you have time. Thanks in advance.
All tests are passed now. Could someone help me to review it?@phofl, @mroeschke 
I'm not sure this is something we should be special-casing. Looks like there has been some upstream conversation on this already in Python

https://bugs.python.org/issue3991

Not an expert on the RFCs but I think we would just want to defer to the language

FYI since the characters included are non-printable the test case is a bit deceiving. If you remove the non-printable characters everything works fine
@WillAyd Sorry for the late reply due to my new year holidays.
Thanks for the RFC confirmation, I didn't notice that. however, That makes sense to me.
I agreed with your suggestion, so It's better to defer to the Python language.

Let's close the related issues or pull requests, and Let's clearly state this is the spec and not the bug.
WIP Share paths 2
State: closed

Attempt at addressing the many, many inconsistencies between the ISO8601 path and the non-ISO8601 path

Can we just get rid of `array_strptime`, and only keep the part that does pattern matching?

@jbrockmendel does the general idea look reasonable? Asking you'd previously commented "yikes" about this 😄 . If so, I'll clean it up and get it ready, just wanted to check that there's not something you know that I don't that would prevent this from being possible

Labels:

Comments:
> Asking you'd previously commented "yikes" about this

IIRC the context for that is that `to_datetime` is the last big thing that needs to be updated to support non-nano, and AFAICT that is going to require adding non-trivial complexity to array_to_datetime.  So the prospect of adding more from a different direction merited a "yikes".  But that was and is speculative, so don't let that dissuade you here.
doing this the other way round works better, so closing in favour of #50242
REF: refactor implementation of to_dict out of frame.py and into core.methods.to_dict
State: closed

- [x] closes #49845 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Following https://github.com/pandas-dev/pandas/pull/46487#pullrequestreview-1059398661 a decision was made to move the implementation of `to_dict` in `frame.py` into `pandas.core.methods.to_dict`.

Labels:
name: Refactor
description: Internal refactoring of code
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
@rhshadrach friendly ping
Thanks @kostyafarber! There are other methods that should now go in this directory - describe is one example. Would you be interested in continuing this kind of refactor?
Hey @rhshadrach no worries, glad I can help - Yeah sure! 

If you wanna open up an issue with a list of methods, I can open PRs against them and work on it. 
@rhshadrach shall I look into describe or are you compiling a list? Happy to work on describe in the meantime.
@kostyafarber - I don't plan on compiling a list; I think describe would be great to work on.
@rhshadrach `describe.py` currently is as a standalone file in `core` would the refactor simply be moving that file into `methods`?
?
@kostyafarber - thanks for the ping; yes, that's correct.
BUG: empty strings raise in non-ISO8601 formats but parse as NaT elsewhere
State: closed

- [ ] closes #50251 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

- ISO8601 formats make empty strings NaT
- non-ISO8601 formats raise

Let's make this consistent. I think I prefer the former (`NaT`). ISO formats are probably also more common, so arguably this'd be a breaking change for fewer people

Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
good point, thanks - extra test added!
thx @MarcoGorelli
Disallow cumprod for timedelta
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

cc @jbrockmendel as discussed on the other pr

Labels:
name: Timedelta
description: Timedelta data type

Comments:
Does this need a whatsnew?  otherwise LGTM thanks for following up!
Added whatsnew
DEPR: deprecate Index.holds_integer
State: closed

See https://github.com/pandas-dev/pandas/issues/50042#issuecomment-1349283717


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Index
description: Related to the Index class or subclasses

Comments:
Ok, I understand. I'll look into it tomorrow. I've never worked on this part of the code base, hopefully it's not too complex.
@jbrockmendel , any comment?
The ARM failure looks unrelated.
I've changed this to use `Index._holds_integer`.
Ping.
👍 .
I've updated this PR after it was decided that it is ok now to merge deprecation PRs.

The code checks errors are unrelated to this PR.
I’ve rerun the failed tests and everything is green now.
thx @topper-123
DOC: added the link to array in string_arrow.py
State: closed

- [x] closes #50230
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @ramvikrams 
> Thanks @ramvikrams

thanks