BrandonFors/pandas-github-issues huggingface dataset:
TST/DOC: apply date() with timezones
State: closed

- [x] closes #11757
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Docs
name: Timezones
description: Timezone data dtype

Comments:
@rockg Thanks! (added 2 really minor comments)

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14085?src=pr) is 85.26% (diff: 100%)

> Merging [#14085](https://codecov.io/gh/pydata/pandas/pull/14085?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14085   diff @@
==========================================
  Files           139        139          
  Lines         50492      50492          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43052      43053     +1   
+ Misses         7440       7439     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [5152cdd...394e918](https://codecov.io/gh/pydata/pandas/compare/5152cdd77ba4799a276d2716535255c3301e9741...394e9184c980bba9a4392bef113edf248a836aff?src=pr)

Thanks!
BUG: Don't parse index column as numeric when parse_dates=True
State: closed

When a thousands parameter is specified, if the index column data contains that thousands value for date purposes (e.g. '.'), do not interpret those characters as the thousands parameter.

Closes #14066.


Labels:
name: Bug
name: IO CSV
description: read_csv, to_csv

Comments:
this is related to https://github.com/pydata/pandas/issues/9435 (though don't think this fixes)

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14077?src=pr) is 85.26% (diff: 75.00%)

> Merging [#14077](https://codecov.io/gh/pydata/pandas/pull/14077?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14077   diff @@
==========================================
  Files           139        139          
  Lines         50492      50504    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43053      43061     +8   
- Misses         7439       7443     +4   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [185fcbe...f2ed334](https://codecov.io/gh/pydata/pandas/compare/185fcbebd8c65706a9e3fea2d1ae28aa2d8baa93...f2ed33424765e7923db70e64ca2ca7b1c77c1be4?src=pr)

@jreback : Travis is passing, so this is ready to merge if there are no other concerns.

@gfyoung Thanks!
add utility methods get_groups() and iter_groups() to class _GroupBy
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

added utility methods get_groups() and iter_groups() to groupby objects 


Labels:
name: Duplicate Report
description: Duplicate issue or pull request

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14075?src=pr) is 85.27% (diff: 100%)

> Merging [#14075](https://codecov.io/gh/pydata/pandas/pull/14075?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14075   diff @@
==========================================
  Files           139        139          
  Lines         50455      50459     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43026      43030     +4   
  Misses         7429       7429          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [6645b2b...5aef79c](https://codecov.io/gh/pydata/pandas/compare/6645b2b11a82343e5f07b15a25a250f411067819...5aef79ccfa56bf64f88c59f6f7c4bf6ae5f469a6?src=pr)

What usecase are you trying to solve here?  Iterating a `groupby` object already yields the groups - does this do something different?

```
In [24]: df = pd.DataFrame({'a': [1,1,2,2,3,3]})

In [25]: for key, sub_df in df.groupby('a'):
    ...:     print(sub_df)
   a
0  1
1  1
   a
2  2
3  2
   a
4  3
5  3
```

oh, lol, that's all I really wanted.   For some reason it didn't occur to me you could just iter() it.
DOC: split docstring into multiple lines in excel.py
State: closed

- [x] closes #13967 
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry 

A follow-up on #14030.
Not sure whether this is the good way to do it - this seems too verbose.
I will add it to `parsers.py` or move it to `common.py` once it's done.

I also thought about moving the function to `Appender` to fix the length problem for good if necessary.


Labels:
name: Docs

Comments:
this is also an issue on read_csv doc string as well

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14073?src=pr) is 85.24% (diff: 100%)

> Merging [#14073](https://codecov.io/gh/pydata/pandas/pull/14073?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **0.02%**

``` diff
@@             master     #14073   diff @@
==========================================
  Files           139        140     +1   
  Lines         50511      50559    +48   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43071      43099    +28   
- Misses         7440       7460    +20   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [10bf721...654feea](https://codecov.io/gh/pydata/pandas/compare/10bf7213240eaa0960f50f86c7790d64d8973060...654feeadb66ea9bd281f6772b16df6962e1ac539?src=pr)

@jreback  do u want me to move the func to `common.py`?

yes move to `common.py`

@jreback @jorisvandenbossche I assume this is what you're talking about? It seems okay to me.
I have limited access to Internet in these few days so I might not responding in time.

@OXPHOS Just a question, what did you precisely change regarding to the previous version (I just don't remember exactly anymore, sorry). Sometimes adding a commit instead of amending the previous can make this more clearer.

@jorisvandenbossche oh sorry my bad. I realized this problem but made the wrong fix. 
So I was doing [this only](https://github.com/pydata/pandas/pull/14073/commits/7dd824c19200ead89a91fbf8c49567ea900d0bfd#diff-0153a977179cfc73a2645cf0b7cd1f7fR172) for the last commit.

And now I used [this](https://github.com/pydata/pandas/pull/14073/commits/7dd824c19200ead89a91fbf8c49567ea900d0bfd#diff-0153a977179cfc73a2645cf0b7cd1f7fR101)

@OXPHOS coming back to this, is the `spit_doc` function still needed now that you added a call to `textwrap.fill` (which already splits the long string created by `"', '".join(sorted(_NA_VALUES)`) ? Seems like you can remove this now?

@jorisvandenbossche I updated the wrap char number and now both `parses.py` and `excel.py` uses `textwrap.fill`

@OXPHOS Thanks a lot, looking good!
TST: Add tests for internal EOF in read_csv
State: closed

Title is self-explanatory.  Closes #5500.


Labels:
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14069?src=pr) is 85.27% (diff: 100%)

> Merging [#14069](https://codecov.io/gh/pydata/pandas/pull/14069?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14069   diff @@
==========================================
  Files           139        139          
  Lines         50455      50455          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43026      43025     -1   
- Misses         7429       7430     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [6645b2b...8c4cf85](https://codecov.io/gh/pydata/pandas/compare/6645b2b11a82343e5f07b15a25a250f411067819...8c4cf85943e647cbb8a0e081ad1e6277dbd309b9?src=pr)

thanks!
BUG: Align to_csv signatures with DataFrame and Series
State: closed

Default `path=None` in `Series.to_csv()` for consistency with `DataFrame.to_csv()`.

Closes #14054.


Labels:
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14063?src=pr) is 85.27% (diff: 100%)

> Merging [#14063](https://codecov.io/gh/pydata/pandas/pull/14063?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #14063   diff @@
==========================================
  Files           139        139          
  Lines         50446      50446          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43018      43018          
  Misses         7428       7428          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [df2d9ab...389ae8c](https://codecov.io/gh/pydata/pandas/compare/df2d9ab917a1ef4732cfb6c3317432f60c071074...389ae8c4149a4c026d99cdbb51b4228b287d11da?src=pr)

thanks!
WIP: add sort_levels to MultiIndex.from_product
State: closed

Currently, `from_product` always sorts levels in the resulting MultiIndex. This means that the result does not necessarily have lexsorted labels/codes.

This PR adds an option to not sort levels when calling `from_product`. Using this option yields a few benefits:
1. It's simpler -- resulting levels on the MultiIndex are exactly those you passed in.
2. It's marginally faster -- you don't need to sort the levels.
3. The resulting MultiIndex is always lex-sorted. This is handy if you want to be able to index it effeciently.

The downside is that the result can be a little less intuitive, because levels and labels do not have the same sort order (#14015).

I'm suggesting this option because it would be useful for xarray (to fix https://github.com/pydata/xarray/issues/980) -- otherwise we would simply put it in our own utility function.

I'm not certain that this is the best argument name, or that I've described it in a way that is clear if you don't understand MultiIndex internals.
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: MultiIndex

Comments:
@shoyer can you update / close (create an issue to track this then)

Closed in favor of #14672.
ENH: add parameter to to_html for HTML border
State: closed

Closes https://github.com/pydata/pandas/issues/11563

Previously this was hardcoded to `<table border="1" ...>`. Now we allow an option to `to_html`.

The only controversial bit here may be the option. I really don't like having options control output, but given that this is essentially a repr I think it's OK. It's also the only way to expose it to the user since `_repr_html_` can't take any arguments. I also selfishly need this [for my own library](https://github.com/tomaugspurger/stitch), where the user wouldn't be able to pass an option 😄 

Interestingly, the `border="0"` is seemingly redundant in the notebook:

![screen shot 2016-08-21 at 7 51 02 pm](https://cloud.githubusercontent.com/assets/1312546/17840966/c4942c98-67d8-11e6-8359-90f46dbb8cb7.png)

Looking at the CSS, I see jupyter applying a border-width of 0.909091px in their style, though I can't remember if I've adjusted the default CSS on this computer; will check later.


Labels:
name: Output-Formatting
description: __repr__ of pandas objects, to_string
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14061?src=pr) is 85.27% (diff: 100%)

> Merging [#14061](https://codecov.io/gh/pydata/pandas/pull/14061?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14061   diff @@
==========================================
  Files           139        139          
  Lines         50511      50517     +6   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43071      43078     +7   
+ Misses         7440       7439     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [10bf721...49e57e7](https://codecov.io/gh/pydata/pandas/compare/10bf7213240eaa0960f50f86c7790d64d8973060...49e57e7fc01757867a02715617931960451d8ead?src=pr)

@TomAugspurger On second thought, should the option be in `pandas.options.html` or in `pandas.options.io.html` (for consistency with excel and hdf)? 
Consistency is nice, but in this case more flat options namespace is also nice (it's not that there are many entries in pd.options)
Fix/read csv utf aliases
State: closed

- [x] closes #13549 
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

-read_csv with engine=c throws error when encoding=UTF_16 (anything other than utf-16)
-improved nosetests and moved to in pandas/io/tests/common.py
-passes `pep8radius upstream/master --diff` and  `git diff upstream/master | flake8 --diff`
-put what's new entry in 0.19.0 in accordance with milestone posted on issue


Labels:
name: Bug
name: Unicode
description: Unicode strings
name: IO CSV
description: read_csv, to_csv

Comments:
@nateGeorge Now there is only a lint error left (reason for the travis failure):

```
pandas/io/tests/parser/common.py:21:1: F811 redefinition of unused 'BytesIO' from line 11
```

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14060?src=pr) is 85.27% (diff: 100%)

> Merging [#14060](https://codecov.io/gh/pydata/pandas/pull/14060?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14060   diff @@
==========================================
  Files           139        139          
  Lines         50446      50449     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43018      43021     +3   
  Misses         7428       7428          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [df2d9ab...aca4148](https://codecov.io/gh/pydata/pandas/compare/df2d9ab917a1ef4732cfb6c3317432f60c071074...aca41484fbdd3a2d26f95286242e31e29a254665?src=pr)

@nateGeorge Thanks!

Thanks for all the help @jorisvandenbossche !  It was my first contribution to a large open source project and I learned a lot, next time should be much smoother.
BUG: Validate the ordered parameter for Categorical
State: closed

Title is self-explanatory.  Closes #14058.


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Categorical
description: Categorical Data Type

Comments:
Looks good to me!

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14059?src=pr) is 85.27% (diff: 100%)

> Merging [#14059](https://codecov.io/gh/pydata/pandas/pull/14059?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14059   diff @@
==========================================
  Files           139        139          
  Lines         50440      50444     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43012      43016     +4   
  Misses         7428       7428          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [ae4ffac...fe11176](https://codecov.io/gh/pydata/pandas/compare/ae4ffac560f9f6fbf1139dd4f391da52d12cdcce...fe111762c1b2652226aea96594cc8d07eaf84592?src=pr)

@gfyoung thanks!
BUG, DOC: Fix inconsistencies with scalar na_values in read_csv
State: closed

1) Update documentation to state that scalars are accepted for `na_values`
2) Accept scalars for the values when a dictionary is passed in for `na_values`

Closes #12224.


Labels:
name: Bug
name: Docs
name: IO CSV
description: read_csv, to_csv

Comments:
pls update io/excel as well as I believe uses same code

@jreback : Good point.  Fixed.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14056?src=pr) is 85.27% (diff: 100%)

> Merging [#14056](https://codecov.io/gh/pydata/pandas/pull/14056?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14056   diff @@
==========================================
  Files           139        139          
  Lines         50440      50442     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43012      43015     +3   
+ Misses         7428       7427     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [ae4ffac...7f253f2](https://codecov.io/gh/pydata/pandas/compare/ae4ffac560f9f6fbf1139dd4f391da52d12cdcce...7f253f235772107775ca9bd60df0c50cebe399d6?src=pr)

Thanks!
BUG: Don't error when usecols is a numpy array
State: closed

Converts `usecols` to a `set` just like we do on the C engine side.

Closes #12546.


Labels:

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14055?src=pr) is 85.26% (diff: 100%)

> Merging [#14055](https://codecov.io/gh/pydata/pandas/pull/14055?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14055   diff @@
==========================================
  Files           139        139          
  Lines         50386      50387     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42959      42960     +1   
  Misses         7427       7427          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [51b20de...fe166b7](https://codecov.io/gh/pydata/pandas/compare/51b20de44fdcb998f25392558e029621e10c451c...fe166b78dd99585a0c44f4b3e9b9ec9e7db28205?src=pr)

@jreback : Simplified the patch, and Travis is still happy.  Ready to merge if there is nothing else.

@gfyoung Thanks!
BUG: GH11847 Unstack with mixed dtypes coerces everything to object
State: closed

- [x] closes #11847
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Changed the way in which the original data frame is copied (dropped use of .values, since it does not preserve dtypes).


Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14053?src=pr) is 85.24% (diff: 100%)
> Merging [#14053](https://codecov.io/gh/pandas-dev/pandas/pull/14053?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14053   diff @@
==========================================
  Files           143        143          
  Lines         50849      50851     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43343      43346     +3   
+ Misses         7506       7505     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [837db72...6a381ce](https://codecov.io/gh/pandas-dev/pandas/compare/837db725b147104be4b0e5cbfd49868971ee4f78...6a381ce87f85e4ec1823809fcd207765997f6433?src=pr)
can you rebase / update?

@jreback is it ok now?

@jreback changed as suggested and passing.

@kordek  can you add a category dtype the tests as well. lgtm otherwise.
@jreback I've changed the tests as requested (if I understood correctly).
thanks @kordek
BUG: Dataframe.fillna with np.nan for dtype=category(GH 14021)
State: closed

- [x] closes #14021
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Categorical
description: Categorical Data Type

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14051?src=pr) is 85.27% (diff: 0.00%)

> Merging [#14051](https://codecov.io/gh/pydata/pandas/pull/14051?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14051   diff @@
==========================================
  Files           139        139          
  Lines         50446      50448     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43018      43021     +3   
+ Misses         7428       7427     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [df2d9ab...a405777](https://codecov.io/gh/pydata/pandas/compare/df2d9ab917a1ef4732cfb6c3317432f60c071074...a40577751f0b42664d3f3d727d99f56e512214d8?src=pr)

thanks!