BrandonFors/pandas-github-issues huggingface dataset:
BUG: Fixed inconsistent multiplication behavior #47953
State: closed

- [ ] closes #47953
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: Frequency
description: DateOffsets
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Hi, are you interested in continuing here?
@phofl Yes, sorry I haven't been looking at this recently, I've been very busy recently so I haven't had much time to work on my pull requests.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: fix a typo
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Thanks @yuanx749
CI: Require s3fs greater than minumum version in builds
State: closed

- [x] xref  #48271 (Replace xxxx with the Github issue number)

Our minimum version of s3fs is not compatible with aiobotocore >= 2.0, so have to pin to lower than 2.0 till we bump s3fs 


Labels:
name: CI
description: Continuous Integration
name: IO Network
description: Local or Cloud (AWS, GCS, etc.) IO Issues
name: Dependencies
description: Required and optional dependencies

Comments:
Failure looks unrelated, but not sure where this is coming from now
Thanks @phofl. Failure looks like something related to PY310.

cc @simonjayhawkins if you think it's necessary to backport to 1.4.x
Backport PR #48215 on branch 1.5.x (REGR: properly update DataFrame cache in Series.__setitem__)
State: closed

Backport PR #48215: REGR: properly update DataFrame cache in Series.__setitem__

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
since 1.5.x has not yet diverged much from main, merging this before #48271 is low risk.
CI: add warning when not in pandas dev and running stubtest
State: closed

- [x] closes #48260
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Labels:
name: CI
description: Continuous Integration
name: Typing
description: type annotations, mypy/pyright type checking
name: Warnings
description: Warnings that appear or should be added to pandas

Comments:
Thanks for the review. I resolved the comments you mentioned however, I noticed that the link you posted doesn't include the command to skip stubtest over [here](https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#validating-type-hints) compared to the one we have over [here](https://github.com/pandas-dev/pandas/blob/main/doc/source/development/contributing_codebase.rst#validating-type-hints)

Perhaps, there needs to be another task created for it? Or is it being done in another PR?
> Thanks for the review. I resolved the comments you mentioned however, I noticed that the link you posted doesn't include the command to skip stubtest over [here](https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#validating-type-hints) compared to the one we have over [here](https://github.com/pandas-dev/pandas/blob/main/doc/source/development/contributing_codebase.rst#validating-type-hints)
> 
> Perhaps, there needs to be another task created for it? Or is it being done in another PR?

The doc updates in https://github.com/pandas-dev/pandas/pull/48240 will be reflected on the website soon. We have a CI job that updates the docs (will be applied to versions >= 1.5)
Thanks @ambujpawar
Backport PR #48215 on branch 1.4.x (REGR: properly update DataFrame cache in Series.__setitem__)
State: closed

Backport PR #48215: REGR: properly update DataFrame cache in Series.__setitem__

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
will merge #48269 first so that we have green ci here
CI: Setting up ssh key to upload prod docs
State: closed

When we pushed the tag for pandas 1.5.0rc0 our docs build failed because we didn't have the ssh copied when trying to upload the docs to the server. This PR fixes that. Also, the web will be updated, which I'm not sure if it has any effect, as we may not be using the tags, but probably a good idea anyway.

Labels:
name: Docs
name: CI
description: Continuous Integration

Comments:
Marking this as 1.5 since I think that's next available opportunity that we will make a tag. cc @simonjayhawkins 
I reverted the push of the website and the dev docs. I didn't realize that the `checkout` action should be fetching the repo at the tag version. This can  mean checking out for example 1.4.5, which will have an outdated version of the website and the dev docs.

So, fixing the push of the released docs in this PR, and I reverted the update of web and dev docs.
Thanks @datapythonista
BUG: ArrowExtensionArray._from_* accepts pyarrow arrays
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

xref https://github.com/pandas-dev/pandas/pull/47034#discussion_r955500784

`ArrowExtensionArray` added in 1.5

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Constructors
description: Series/DataFrame/Index/pd.array Constructors
name: Arrow
description: pyarrow functionality

Comments:
thx @mroeschke
ENH: TimedeltaArray add/sub with non-nano
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timedelta
description: Timedelta data type
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
```
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

pandas/core/arrays/datetimelike.py:1294: error: "DatetimeLikeArrayMixin" has no attribute "_reso"  [attr-defined]
Found 1 error in 1 file (checked 1394 source files)
```
Yes

On Fri, Aug 26, 2022 at 4:16 PM Matthew Roeschke ***@***.***>
wrote:

> ***@***.**** commented on this pull request.
> ------------------------------
>
> In pandas/core/arrays/timedeltas.py
> <https://github.com/pandas-dev/pandas/pull/48261#discussion_r956494005>:
>
> >          if self.freq is not None:
> -            return type(self)(-self._ndarray, freq=-self.freq)
> -        return type(self)(-self._ndarray)
> +            freq = -self.freq
>
> Do we have a test for this case?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/48261#pullrequestreview-1087584266>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB5UM6CZNJZZE3LUXIQBB5DV3FF6BANCNFSM57U2H4TQ>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
REF: avoid FutureWarning about using deprecates loc.__setitem__ non-inplace usage
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Not a bugfix AFAICT, the new test passes without this edit.


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Warnings
description: Warnings that appear or should be added to pandas

Comments:
could refactor Loc._ensure_iterable_column_indexer to re-use in the get_loc post-processing
> Should this be for 1.5 or 2.0?

I'd put it into 1.5.x to avoid showing a spurious FutureWarning to users.
Thanks @jbrockmendel
REGR: iloc not possible for sparse DataFrame
State: closed

- [ ] closes #46406 (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


targeted backport PR to effectively restore the code path from 1.3.5 for a SparseDtype.

The regression issue is strictly about SparseDtype but I would imagine would also be an issue for any immutable EA. (How we address this probably needs further discussion) and there is already a special case for SparseDtype in `pandas/core/internals/managers.py`





Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version
name: Sparse
description: Sparse Data Type

Comments:
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.4.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 1843cf23c7aa74248d956ae28a30abfc2c0af8e8
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #48246: REGR: iloc not possible for sparse DataFrame'
```

4. Push to a named branch:

```
git push YOURFORK 1.4.x:auto-backport-of-pr-48246-on-1.4.x
```

5. Create a PR against branch 1.4.x, I would have named this PR:

> "Backport PR #48246 on branch 1.4.x (REGR: iloc not possible for sparse DataFrame)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@meeseeksdev backport 1.5.x
CI: Skip test_round_sanity tests due to failures
State: closed

- [x] xref #48244 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

This xfails the test for now to get the ci back to green. Does anybody have a better suggestion?


Labels:
name: CI
description: Continuous Integration

Comments:
There's was a suggestion here. https://github.com/pandas-dev/pandas/issues/47933#issuecomment-1205909274

Let's try to fix it for real this time, though(I'm going to mark the issue as a blocker).
Only if this is fast. All our builds are broken. We can mark the issue as a blocker and merge this till then
Ok to merge @mroeschke ? The failures make seeing anything really hard
Thanks @phofl. Yeah we can track an actual fix for this in https://github.com/pandas-dev/pandas/issues/47823
Thanks
@meeseeksdev backport 1.4.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.4.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 3d2033bec3c0272165bb41bc4c3226b2396c3130
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #48245: CI: Skip test_round_sanity tests due to failures'
```

4. Push to a named branch:

```
git push YOURFORK 1.4.x:auto-backport-of-pr-48245-on-1.4.x
```

5. Create a PR against branch 1.4.x, I would have named this PR:

> "Backport PR #48245 on branch 1.4.x (CI: Skip test_round_sanity tests due to failures)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
Fix mypy erroring on backport branches
State: closed

see #48235

cc @twoertwein 

Any suggestions on how to deal with this more effectively?

Labels:
name: CI
description: Continuous Integration
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Seems like the rounding issues with he Timedelta test are back
The goal of this if condition is to exit early if a non-dev version of pandas is installed: we could simply change it to `if not getattr(pd, "__version__", "")` to require any installed version. I belief that should work for the CI.

Luckily, stubtest is in the manual stage of pre-commit, so it isn't run by default. The above change would only affect people running pre-commit on the manual stage. If a contributor has non-dev pandasinstalled, stubtest might find discrepancies between the stubs and the non-dev implementation and therefore fail. Personally, I would do the above change and add a comment here
https://github.com/pandas-dev/pandas/blob/main/doc/source/development/contributing_codebase.rst#validating-type-hints

```sh
# the following might fail if the installed pandas version does not correspond to your local git version
pre-commit run --hook-stage manual --all-files
# if the above fails due to stubtest
SKIP=stubtest pre-commit run --hook-stage manual --all-files
```

(I didn't double check whether that is the correct syntax for skipping a hook in pre-commit)
This is the correct syntax, thx.

Like this? Could also explain in text, not as comment
cc @mroeschke 
Thx, will open an issue. 

I think we can merge? Typing is already green
Awesome, thanks @phofl and @twoertwein
Backport PR #48232 on branch 1.5.x (CI: Ensure jobs run on 1.5.x branch)
State: closed

Backport PR #48232: CI: Ensure jobs run on 1.5.x branch

Labels:
name: CI
description: Continuous Integration

Comments:
lets merge this as https://github.com/pandas-dev/pandas/pull/48240 is addressing the mypy issue.
REGR: Fix regression RecursionError when replacing numeric scalar with None
State: closed

- [x] closes #45725 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

If value is None, ``self.coerce_to_target_dtype`` returns ``float64`` if self is Numeric. But: ``self._can_hold_element(value)`` is False, since NumPy can not set None into a numeric array.

This should probably be consistent...


Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: replace
description: replace method

Comments:
> blocking for the short term
> 
> we have #48034 on the 1.4.x milestone. knowing that the backport of replace changes was not trivial last time due to changes on main, lets not make any other changes till that issue has been investigated.

looking at #48034, it appears that that issue is moreless orthogonal to this issue, so perhaps no reason to block.
LGTM (IMO I think the 1.4.x behavior is more reasonable than the RecurssionError behavior). cc @simonjayhawkins not sure if you still have any objections with moving forward with this behavior in 1.5.x
Could you merge main once more? I tried restarting the (seemingly) unrelated test failures but they are still failing.
Yeah restarted as well earlier. Merged main now
Thanks @phofl. Maybe please create an issue regarding using `replace` to replace NA-like values with NA-like values if we don't have one 
Opened  #49421
DOC: Get rid of question marks in getting started tutorials
State: closed

- [x] closes #48227 (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
@MarcoGorelli I adjusted PR so that it remains as is [aka `How do I create plots?` in the code]. 

However, I noticed that in the docs for some reason the [plots](https://pandas.pydata.org/docs/getting_started/intro_tutorials/04_plotting.html#) heading shows `How to` with a question mark and when I added the previous change with `How to` without question mark building the docs got rid of the question mark on that page.

Not sure how the code show `How do I` when the docs show the heading `How to`....
> Not sure how the code show `How do I` when the docs show the heading `How to`....

you probably just need to do `python make.py clean` first
@MarcoGorelli I have updated the dashes to be the length of the alter titles. Sorry about that.
Thanks @samrao1997
TST: Test Nullable int floordiv by 0
State: closed

- [x] closes #48223 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/v1.5.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
thx @mroeschke
Backport PR #48197 on branch 1.5.x (DOC: Cleanup 1.5 whatsnew)
State: closed

Backport PR #48197: DOC: Cleanup 1.5 whatsnew

Labels:
name: Docs

Comments:
ahh yes, we need to change some ci files so that ci runs on 1.5.x. This is low risk, so just merge.
> ahh yes, we need to change some ci files so that ci runs on 1.5.x. This is low risk, so just merge.

Thanks, opened https://github.com/pandas-dev/pandas/pull/48232 to enable jobs to run on 1.5.x
Test: IntervalIndex.astype("category") doesn't preserve exact interval dtype in categories
State: closed

- [ ] closes #38316
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Categorical
description: Categorical Data Type

Comments:
Thanks @weikhor
1.4.x
State: closed

- [ ] closes #48224


Labels:

Comments:
PR should be opened against `pandas-dev:main` not `pandas-dev:1.4.x`. see https://github.com/pandas-dev/pandas/pull/48120#issuecomment-1220828535
it appears you base branch is off of the `1.4.x` branch. You will want to always branch off the main branch. Please follow this guide on how to properly clone and make a pull request off of main: https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#creating-a-branch

Closing since this target branch cannot be changed, but hope the information above helps!