BrandonFors/pandas-github-issues huggingface dataset:
DOC: isin() docstring change DataFrame to pd.DataFrame
State: closed

isin() docstring change DataFrame to pd.DataFrame

Labels:
name: Docs

Comments:
Hello @beepscore! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on June 13, 2018 at 12:10 Hours UTC
Simple enough. If you can correct the LINT issue then lgtm
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21403?src=pr&el=h1) Report
> Merging [#21403](https://codecov.io/gh/pandas-dev/pandas/pull/21403?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/415012f4f38ca0cf41717c51e49bd2349cba09a8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21403/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21403?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21403   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49596    49596           
=======================================
  Hits        45576    45576           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21403?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/21403/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.22% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21403?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21403?src=pr&el=footer). Last update [415012f...ee2c818](https://codecov.io/gh/pandas-dev/pandas/pull/21403?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@beepscore Thanks! 
(I just changed `foo` to `df2`, many people are not familiar with 'foo', bar', ..)
BUG to_clipboard passes the wrong sep to to_csv
State: closed

Originally, the sep is `\t` as to_csv expects. A commit changes the sep to `r'\t',` causing an exception (because `csv.writer` expects the delimiter to be a one-character string). The exception is suppressed (with `pass` in the `except` block), causing the data frame to be passed to `to_string` downstream (even though it should be handled by `to_csv`)

Changing `r't'` back to `\t` is a quick fix, but just `pass` in the `except` block seems like the more problematic root cause (that I'm not handling here). 

- [x ] closes #21385
- [ ] tests added / passed
- [x ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x ] whatsnew entry


Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: Duplicate Report
description: Duplicate issue or pull request

Comments:
@anhqle : Thanks for this!  Going to need a test to protect against this in the future.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21398?src=pr&el=h1) Report
> Merging [#21398](https://codecov.io/gh/pandas-dev/pandas/pull/21398?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/415012f4f38ca0cf41717c51e49bd2349cba09a8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21398/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21398?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21398   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49596    49596           
=======================================
  Hits        45576    45576           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21398?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/clipboards.py](https://codecov.io/gh/pandas-dev/pandas/pull/21398/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2NsaXBib2FyZHMucHk=) | `100% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21398?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21398?src=pr&el=footer). Last update [415012f...9e65713](https://codecov.io/gh/pandas-dev/pandas/pull/21398?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Close because duplicate of #21111
DOC: Loading sphinxcontrib.spelling to sphinx only if it's available (#21396)
State: closed

- [X] closes #21396
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

I think the optional dependencies go directly into the `.txt` files for pip and conda, and not into the yaml file. Please correct me if I'm wrong.

Seems like besides `sphinxcontrib-spelling`, a binary program `enchant` is required, and it's not available in conda for what I've seen. Not sure what's the right approach for it.

Labels:
name: Bug
name: Build
description: Library building on various platforms
name: Docs

Comments:
> I think the optional dependencies go directly into the .txt files for pip and conda, and not into the yaml file. Please correct me if I'm wrong.

Good call: I agree that it is an optional dependency.  You don't need it to install `pandas` for general use.
As said on the issue, given the installation troubles, I would make this an optional one.
Just FYI, I just followed the [instructions to create a development environment with Conda](https://pandas.pydata.org/pandas-docs/stable/contributing.html#creating-a-python-environment). On the `python -m pip install -e .` step, I got
```
sphinxcontrib-spelling 4.1.0 requires PyEnchant>=1.6.5, which is not installed.
```
Is that desired behavior or should the `environment.yml` file also include `PyEnchant` as a dependency?
TST: adding test cases for verifying correct values shown by pivot_table() #21378
State: closed

BUG: Incorrect values shown by pivot_table() #21378

- [x] closes #21378
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Just added a new test to verify the included patch in `master` branch

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby
name: Categorical
description: Categorical Data Type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21393?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@6c71c45`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21393/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/21393?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #21393   +/-   ##
=========================================
  Coverage          ?   91.89%           
=========================================
  Files             ?      153           
  Lines             ?    49604           
  Branches          ?        0           
=========================================
  Hits              ?    45586           
  Misses            ?     4018           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (?)` | |
| #single | `41.88% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21393?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21393?src=pr&el=footer). Last update [6c71c45...355aea3](https://codecov.io/gh/pandas-dev/pandas/pull/21393?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@gfyoung  thanks! you may now close the issue after the merge :+1:

Hello @uds5501! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on June 15, 2018 at 17:32 Hours UTC
@jreback  Done the changes. Any other improvement you'd like?
@jreback fixed the errors in the test. Any other improvement required?
thanks @uds5501
DOC: Whatsnew for string coercion fix [ci skip]
State: closed

xref https://github.com/pandas-dev/pandas/pull/21366/files/a94d3995160a07a09693a883ceb0641e82ca7bdd#r194103331

That PR had
tests (https://github.com/pandas-dev/pandas/pull/21366/files/a94d3995160a07a09693a883ceb0641e82ca7bdd#diff-10e7ab03eb0363417c9b042860d3ba73R814)
but no release note for this specifically, since I didn't know it was a bug.

[ci skip]

Labels:
name: Docs

Comments:
Oh, I was mistaken about when this was changed. I thought it was just in my recent PR, but it was indeed 0.23.0.
I'm going to be lazy and just leave 0.23.0.txt as is.
DOC: update whatsnew 0.23.1
State: closed

One of the last commits apparently added back the subsections

Labels:
name: Docs

Comments:
ah, @jreback I see that you actually added that commit to that PR explicitly (I assumed is was due to some rebase or so). I removed the subsections on purpose in https://github.com/pandas-dev/pandas/pull/21368, because IMO for such a short list it is not really needed and rather adds noise to the toc (but can certainly be discussed)
DOC: update multi-index term with MultiIndex
State: closed

Hello,
before I start working on part 2 of the sphinx spelling extension I wanted to submit this PR in order to fix the double use of multi-index and MultiIndex. I have changed all `multi-index` mentions through the documentation to `MultiIndex`, this meant that some titles needed changing and new linking needed to be done. I have tested the documentation locally and everything seems to be working okay.

I have also reverted the changes to some adverbs that got changed previously (which shouldn't have according to @h-vetinari)

I hope that creating this PR before working on part 2 is okay. If you would rather me add this and the next one together let me know and I'll update the title and whatnot 😄 👍 


- [ ] closes #xxxx
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Docs
name: MultiIndex

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21382?src=pr&el=h1) Report
> Merging [#21382](https://codecov.io/gh/pandas-dev/pandas/pull/21382?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/abfac97b2d22447d41bfccaa53e0a264ca34d6d4?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21382/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21382?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21382      +/-   ##
==========================================
+ Coverage   91.85%   91.88%   +0.03%     
==========================================
  Files         153      153              
  Lines       49570    49570              
==========================================
+ Hits        45533    45549      +16     
+ Misses       4037     4021      -16
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.28% <ø> (+0.03%)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21382?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_core.py](https://codecov.io/gh/pandas-dev/pandas/pull/21382/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb3JlLnB5) | `83.53% <0%> (+1.14%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21382?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21382?src=pr&el=footer). Last update [abfac97...767485d](https://codecov.io/gh/pandas-dev/pandas/pull/21382?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@FabioRosado : Thanks!
MAINT: More friendly error msg on Index overflow
State: closed

Display a more friendly error message when there is an `OverflowError` during `Index` construction.

Partially addresses #15832.

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
Marked this for `0.23.2` since this is relatively minor and is in no rush to be squeezed into `0.23.1`.  That being said, if someone wants to push for tomorrow's release, be my guest. 😄 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21377?src=pr&el=h1) Report
> Merging [#21377](https://codecov.io/gh/pandas-dev/pandas/pull/21377?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/480790531ffcc4329f280ddf6877d028d08e969f?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21377/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21377?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21377      +/-   ##
==========================================
+ Coverage   91.89%   91.89%   +<.01%     
==========================================
  Files         153      153              
  Lines       49596    49599       +3     
==========================================
+ Hits        45576    45579       +3     
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <100%> (ø)` | :arrow_up: |
| #single | `41.86% <50%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21377?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/21377/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.61% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21377?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21377?src=pr&el=footer). Last update [4807905...44e95e6](https://codecov.io/gh/pandas-dev/pandas/pull/21377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

ok seems reasonable. 
> ok seems reasonable.

Cool.  lmk if there are any changes that need to be made to make this merge-able.
@jreback : friendly ping
yep looks fine. let's wait till 0.23.2 whatsnew is in (I see you have PR for that), but don't merge unless @TomAugspurger releases.
> let's wait till 0.23.2 whatsnew is in (I see you have PR for that), but don't merge unless @TomAugspurger releases.

Just to clarify: Are you saying to hold on both PR's until @TomAugspurger releases?  Or just this one?
yes hold on both.
nvm this is fine.
DOC: clean-up 0.23.1 whatsnew
State: closed

I added a "Fixed regressions" section and moved some over there. @TomAugspurger does that look ok to you? (then I'll maybe merge to the other PRs can add it there)

Also mad the bug fixes subsections into plain text to make it a bit less "heavy" (given the only few entries per section).

Labels:
name: Docs

Comments:
@MeeseeksDev hello
REGR: NA-values in ctors with string dtype
State: closed

```python
In [1]: import pandas as pd
In [2]: pd.Series([1, 2, None], dtype='str')[2]  # None

```

Closes #21083

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
Did you also add a test case for https://github.com/pandas-dev/pandas/issues/21270 ?
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21366?src=pr&el=h1) Report
> Merging [#21366](https://codecov.io/gh/pandas-dev/pandas/pull/21366?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7f6ea676808a39801e1d36ec1db48f269fa4e5a9?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21366/graphs/tree.svg?token=eZ4WkYLtcO&width=650&src=pr&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21366?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21366      +/-   ##
==========================================
- Coverage   91.89%   91.85%   -0.04%     
==========================================
  Files         153      153              
  Lines       49579    49569      -10     
==========================================
- Hits        45559    45532      -27     
- Misses       4020     4037      +17
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.25% <100%> (-0.04%)` | :arrow_down: |
| #single | `41.87% <100%> (+0.01%)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21366?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/series.py](https://codecov.io/gh/pandas-dev/pandas/pull/21366/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc2VyaWVzLnB5) | `94.15% <100%> (-0.03%)` | :arrow_down: |
| [pandas/plotting/\_core.py](https://codecov.io/gh/pandas-dev/pandas/pull/21366/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb3JlLnB5) | `82.39% <0%> (-1.15%)` | :arrow_down: |
| [pandas/core/dtypes/missing.py](https://codecov.io/gh/pandas-dev/pandas/pull/21366/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL21pc3NpbmcucHk=) | `91.95% <0%> (-0.58%)` | :arrow_down: |
| [pandas/core/reshape/pivot.py](https://codecov.io/gh/pandas-dev/pandas/pull/21366/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzaGFwZS9waXZvdC5weQ==) | `96.97% <0%> (-0.06%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21366?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21366?src=pr&el=footer). Last update [7f6ea67...4de6f7a](https://codecov.io/gh/pandas-dev/pandas/pull/21366?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @TomAugspurger 

we should prob create an issue about refactor / clean dtypes.cast
Fix #21356: JSON nested_to_record Silently Drops Top-Level None Values
State: closed

- [x] closes #21356 
- [x] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: IO JSON
description: read_json, to_json, json_normalize

Comments:
@WillAyd Kindly review, this is my first PR to pandas!
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21363?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@636dd01`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21363/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21363?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #21363   +/-   ##
=========================================
  Coverage          ?   91.85%           
=========================================
  Files             ?      153           
  Lines             ?    49562           
  Branches          ?        0           
=========================================
  Hits              ?    45525           
  Misses            ?     4037           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.25% <ø> (?)` | |
| #single | `41.86% <ø> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21363?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/json/normalize.py](https://codecov.io/gh/pandas-dev/pandas/pull/21363/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2pzb24vbm9ybWFsaXplLnB5) | `96.87% <ø> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21363?src=pr&el=footer). Last update [636dd01...b7bda86](https://codecov.io/gh/pandas-dev/pandas/pull/21363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@WillAyd if you have a few, can you rebase this
@jreback think its good to go. First time doing that so let me know if anything looks off
@daminisatya Thanks a lot!