BrandonFors/pandas-github-issues huggingface dataset:
DOC: Test doctests in pandas/core/reshape/concat.py
State: closed

- [x] closes #26436
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
seems it's running but I wonder why it's failed in my local. Let me take a look separately.
DOC: remove usage of lrange in docs
State: closed

Due to the recent removals (eg https://github.com/pandas-dev/pandas/pull/26396 and others)

Labels:
name: Docs

Comments:
Verified the log that this is fixed
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26423?src=pr&el=h1) Report
> Merging [#26423](https://codecov.io/gh/pandas-dev/pandas/pull/26423?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/421ae9d6fca42bf26eadabca7b7406e74f7814aa?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26423/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26423?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26423      +/-   ##
==========================================
- Coverage   91.69%   91.69%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46529    46525       -4     
- Misses       4212     4216       +4
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.19% <ø> (ø)` | :arrow_up: |
| #single | `41.16% <ø> (-0.18%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26423?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26423/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26423/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.02% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26423?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26423?src=pr&el=footer). Last update [421ae9d...1f061de](https://codecov.io/gh/pandas-dev/pandas/pull/26423?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

``pd.DataFrame(range(10))`` doesn't work in 0.24 (fixed for 0.25), so will likely not have worked in the older versions either. Maybe too late, but I think ``pd.DataFrame(list(range(10)))`` could be better, as these are release notes?
Ah, good point. I actually made sure I tested it, as I was not sure if I needed to use `list(..)` or not, but I was using master .. ;)
Add Annotations to GroupBy
State: closed

Not fully complete but got started on these on a flight today. Should be able to review failures in a few more details.

@gwrome @vaibhavhrt would love any feedback from you

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Hello @WillAyd! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:







* In the file [`pandas/core/groupby/groupby.py`](https://github.com/pandas-dev/pandas/blob/d89a75d6b70a0c433d9fe3e6573d1975bf2b0271/pandas/core/groupby/groupby.py):

> [Line 1640:45](https://github.com/pandas-dev/pandas/blob/d89a75d6b70a0c433d9fe3e6573d1975bf2b0271/pandas/core/groupby/groupby.py#L1640): [E222](https://duckduckgo.com/?q=pep8%20E222) multiple spaces after operator


Will come back to this at a later date
Remove _DtypeOpsMixin
State: closed


Labels:
name: Refactor
description: Internal refactoring of code
name: Clean

Comments:
Seems pretty straightforward. So this is purely dead development at this point right?
right. It was just needed until all our old dtypes became real extension
dtypes. I forgot to remove after adding DatetimeTZDtype.

On Thu, May 9, 2019 at 10:36 PM William Ayd <notifications@github.com>
wrote:

> Seems pretty straightforward. So this is purely dead development at this
> point right?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/26331#issuecomment-491143920>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAKAOITXBT2T5D6ACYAXCBTPUTUVNANCNFSM4HL7PVGA>
> .
>

So the bulk of https://github.com/pandas-dev/pandas/pull/26331/commits/acb5b49c08512aca15b8ab00fafcccc556d86ae6 is just moving methods from _DtypeOpsMixin to ExtensionDtype.
looks fine, merge pending CI resolution.
thanks @TomAugspurger
DOC: Improve links and fix issues on resample documentation page
State: closed

- [x] closes #26275 
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry (Not required IMO)


Labels:
name: Docs
name: Frequency
description: DateOffsets

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26306?src=pr&el=h1) Report
> Merging [#26306](https://codecov.io/gh/pandas-dev/pandas/pull/26306?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/20fa58d48a7788e980a084ac05196cab2cc055ac?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26306/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26306?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26306      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52302    52302              
==========================================
- Hits        48142    48138       -4     
- Misses       4160     4164       +4
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.59% <ø> (ø)` | :arrow_up: |
| #single | `40.72% <ø> (-0.18%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26306?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/26306/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `93.57% <ø> (ø)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26306/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26306/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.01% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26306?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26306?src=pr&el=footer). Last update [20fa58d...6458161](https://codecov.io/gh/pandas-dev/pandas/pull/26306?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

small comment, otherwise lgtm. ping on green.
The error is `AttributeError: type object 'DataFrame' has no attribute 'to_panel'` which seems to be unrelated to the current PR. @jreback Any suggestions?
@Bharat123rox I think #26308 will resolve that so can just merge master here after that goes in
Ping @jreback to review
thanks @Bharat123rox
Add type annotation to config_init
State: closed

- [X] closes #26297
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`


Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26300?src=pr&el=h1) Report
> Merging [#26300](https://codecov.io/gh/pandas-dev/pandas/pull/26300?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/94c8c94dccfa7934699c314420f0898d81425519?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26300/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26300?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26300      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52374    52373       -1     
==========================================
- Hits        48178    48173       -5     
- Misses       4196     4200       +4
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.53% <ø> (-0.01%)` | :arrow_down: |
| #single | `40.72% <ø> (-0.15%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26300?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/config\_init.py](https://codecov.io/gh/pandas-dev/pandas/pull/26300/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29uZmlnX2luaXQucHk=) | `96.94% <ø> (-0.03%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26300/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26300/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `96.9% <0%> (-0.12%)` | :arrow_down: |
| [pandas/core/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/26300/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYmFzZS5weQ==) | `97.98% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26300?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26300?src=pr&el=footer). Last update [94c8c94...7b363f6](https://codecov.io/gh/pandas-dev/pandas/pull/26300?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lgtm. ping on green.
@jreback The board is green
thanks @gwrome
Fix type annotations in pandas.core.base
State: closed

- [X] closes #26296
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`


Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
thanks @gwrome 

as an FYI; you don't need to open separate issues for typing each thing. You can simply submit a PR, or create a single issue, with checkboxes is fine.
Fix type annotations in pandas.core.computation
State: closed

- [X] closes #26294
- [X] tests passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`


Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26295?src=pr&el=h1) Report
> Merging [#26295](https://codecov.io/gh/pandas-dev/pandas/pull/26295?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/20fa58d48a7788e980a084ac05196cab2cc055ac?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26295/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26295?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26295      +/-   ##
==========================================
- Coverage   92.04%   92.04%   -0.01%     
==========================================
  Files         175      175              
  Lines       52302    52301       -1     
==========================================
- Hits        48142    48138       -4     
- Misses       4160     4163       +3
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.59% <100%> (ø)` | :arrow_up: |
| #single | `40.75% <100%> (-0.15%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26295?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/computation/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/26295/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tcHV0YXRpb24vb3BzLnB5) | `95.95% <ø> (+0.33%)` | :arrow_up: |
| [pandas/core/computation/pytables.py](https://codecov.io/gh/pandas-dev/pandas/pull/26295/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tcHV0YXRpb24vcHl0YWJsZXMucHk=) | `90.24% <100%> (ø)` | :arrow_up: |
| [pandas/core/computation/expr.py](https://codecov.io/gh/pandas-dev/pandas/pull/26295/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tcHV0YXRpb24vZXhwci5weQ==) | `96.71% <100%> (ø)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26295/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26295/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.01% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26295?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26295?src=pr&el=footer). Last update [20fa58d...2061229](https://codecov.io/gh/pandas-dev/pandas/pull/26295?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you merge master; @WillAyd 
Thanks @gwrome ! Very nice progress on all of these typing PRs
WIP: Maintain Int64 Precision on Construction
State: closed

- [X] closes #26259
- [X] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

This is not the final implementation but providing for discussion and feedback. Consideration points are:

 - `_from_sequence_of_strings` was hacked to just return an IntervalArray, which isn't correct. Do we want to potentially pass through a mask to `_from_sequence` -> `integer_array` -> `IntegerArray()` instead? I think there is also a bug when construction the DataFrame correctly which this might fix
 - I'm not super familiar with the IntervalArray tests just yet, but I think I need to add a construction test in `arrays.test_integer` which may either supplement or replace the CSV test herein
 - There appears to be a bug with `tm.assert_frame_equal` and large integers where precision could be lost. This probably applies to all of the `tm.assert_*_equal` functions

Labels:
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Hello @WillAyd! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



* In the file [`pandas/tests/io/parser/test_dtypes.py`](https://github.com/pandas-dev/pandas/blob/8132596b81bbe6b98a8dd5ca5f50305103de6483/pandas/tests/io/parser/test_dtypes.py):

> [Line 529:1](https://github.com/pandas-dev/pandas/blob/8132596b81bbe6b98a8dd5ca5f50305103de6483/pandas/tests/io/parser/test_dtypes.py#L529): [W293](https://duckduckgo.com/?q=pep8%20W293) blank line contains whitespace


> > unless we have pd.to_numeric construct the Int64 array directly
>
> yes that is a desirable outcome

I agree that is a desirable outcome. However, we will need to think a bit about how to achieve this, as it would be a breaking change, and one probably wants to be able to choose if you get nullable integer array or not.

A keyword to trigger to use nullable ints as output? (not very nice, but can't think directly think of good solutions ..)

> I agree that is a desirable outcome. However, we will need to think a bit about how to achieve this, as it would be a breaking change, and one probably wants to be able to choose if you get nullable integer array or not.

yes, but a desirable one; i don't think its a big deal to simply change this with an appropriate example in the whatsnew. downcast='integer' and 'unsigned' would simply return Int64/UInt64 arrays; this would only be a breaking change if you had floats previously.
@WillAyd can you merge master and update
I'll give this another look over next few days
Haven't looked at this in a few months - closing to clear up queue
CLN: Clean uses of super, part II
State: closed

- [x] xref #25725 & #26177

Continuation from #26177. In addition to the uses of ``super`` dealt with in #26177, there were some more advanced uses of ``super`` in the code base, e.g. in classmethods and using ``super`` to jump to a specific point in the MRO-chain.

This PR specifically deals with:
* ``super(..., self)`` in pyx-files
* ``super(..., cls)`` in the whole code base
* Changes some specific uses of ``super``, se comments .

Labels:

Comments:
Hello @topper-123! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





















There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2019-04-28 07:40:11 UTC
BUG: Preserve sparse dtype when reindexing
State: closed

- [ ] closes #26123.
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Hi, I've been taking a look at this but I need to verify some of the surrounding functionality so that I prevent introducing more breakages.

In this test, https://github.com/alex-hutton/pandas/blob/preserve-sparse-dtype-26123/pandas/tests/sparse/test_combine_concat.py#L99-L110 , my interpretation is that its purpose is to verify that if two `SparseSeries` are concatenated, a `fill_value` set on either of those `SparseSeries` should be ignored in favour of the default `fill_value` of `NaN`.

Is my interpretation correct, and is this test correct? It seems odd that the the `fill_value` of the `SparseSeries` should be disregarded, but I am probably missing something.

Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: Sparse
description: Sparse Data Type

Comments:
Hello @alex-hutton! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:







There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2019-04-22 12:35:45 UTC
closing as stale. if you'd to continue, pls merge master and ping.
CLN: remove __metaclass__ from code base
State: closed

- [x] xref #25725 & #26165

Removes uses of ``__metaclass__`` from the code base. After #26165 there was actually only one left.


Labels:

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26178?src=pr&el=h1) Report
> Merging [#26178](https://codecov.io/gh/pandas-dev/pandas/pull/26178?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/947bd7662afa8b6dc4406ec52cefc39d76d2d6cd?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26178/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26178?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26178      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52371    52370       -1     
==========================================
- Hits        48175    48170       -5     
- Misses       4196     4200       +4
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.53% <100%> (-0.01%)` | :arrow_down: |
| #single | `40.71% <100%> (-0.15%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26178?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/computation/engines.py](https://codecov.io/gh/pandas-dev/pandas/pull/26178/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tcHV0YXRpb24vZW5naW5lcy5weQ==) | `88.33% <100%> (-0.2%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26178/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26178/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `96.9% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26178?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26178?src=pr&el=footer). Last update [947bd76...fa898b0](https://codecov.io/gh/pandas-dev/pandas/pull/26178?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks @topper-123