DOC: update vendored numpydoc version 
State: closed

The first commit only updates our vendored version with the upstream one. 

Additional commits make it work with our docs:

- edit numpydoc to allow member listing for attributes (this is a change (and the only) to the source code of numpydoc that is not upstream: discussed in https://github.com/numpy/numpydoc/pull/106)
- numpydoc settings: use `numpydoc_use_blockquotes=False` for now for compatibility (it is deprecated). To fix this, we need to fix: css styling of description lists + warnings generated due to `**kwargs`

It is probably worth to look at the separate commits (and would also like to keep them when merging)

Labels:
name: Docs

Comments:
Hello @jorisvandenbossche! Thanks for updating the PR.





 - In the file [`doc/sphinxext/numpydoc/docscrape.py`](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/docscrape.py), following are the PEP8 issues :

> [Line 567:21](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/docscrape.py#L567): [E126](https://duckduckgo.com/?q=pep8%20E126) continuation line over-indented for hanging indent

 - In the file [`doc/sphinxext/numpydoc/docscrape_sphinx.py`](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/docscrape_sphinx.py), following are the PEP8 issues :

> [Line 36:80](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/docscrape_sphinx.py#L36): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (84 > 79 characters)
> [Line 39:80](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/docscrape_sphinx.py#L39): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (82 > 79 characters)
> [Line 355:25](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/docscrape_sphinx.py#L355): [E241](https://duckduckgo.com/?q=pep8%20E241) multiple spaces after ':'



 - In the file [`doc/sphinxext/numpydoc/tests/test_docscrape.py`](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/tests/test_docscrape.py), following are the PEP8 issues :

> [Line 458:1](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/tests/test_docscrape.py#L458): [E128](https://duckduckgo.com/?q=pep8%20E128) continuation line under-indented for visual indent
> [Line 595:1](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/tests/test_docscrape.py#L595): [E128](https://duckduckgo.com/?q=pep8%20E128) continuation line under-indented for visual indent
> [Line 731:5](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/tests/test_docscrape.py#L731): [E122](https://duckduckgo.com/?q=pep8%20E122) continuation line missing indentation or outdented
> [Line 741:80](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/tests/test_docscrape.py#L741): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (124 > 79 characters)
> [Line 1184:80](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/tests/test_docscrape.py#L1184): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (94 > 79 characters)
> [Line 1186:5](https://github.com/pandas-dev/pandas/blob/41bbc7be904a5d4f74864cb6da0cc665dd98d14f/doc/sphinxext/numpydoc/tests/test_docscrape.py#L1186): [E128](https://duckduckgo.com/?q=pep8%20E128) continuation line under-indented for visual indent



##### Comment last updated on March 27, 2018 at 14:57 Hours UTC
We still have the problem we fixed with this hack: https://github.com/pandas-dev/pandas/commit/70c9d318ed4ef32e1c294a4dbefcb783cda19dba, related to the property's that are None.

However, due to recent work, I think only `.index` and `.columns` are left for this (there are others there as well that don't show up properly, but that is because of the `if pydoc.getdoc(param_obj)` check and they have no docstring .. so that is easily fixable).
`.index` and `.columns` should be fixed with https://github.com/pandas-dev/pandas/pull/20385
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20383?src=pr&el=h1) Report
> Merging [#20383](https://codecov.io/gh/pandas-dev/pandas/pull/20383?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/89444ad5d3426dd1898b96477f767996c7f48ca0?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20383/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/20383?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #20383      +/-   ##
==========================================
- Coverage   91.85%   91.82%   -0.03%     
==========================================
  Files         152      152              
  Lines       49233    49233              
==========================================
- Hits        45222    45210      -12     
- Misses       4011     4023      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.21% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.88% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20383?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/20383/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.07% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20383?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20383?src=pr&el=footer). Last update [89444ad...41bbc7b](https://codecov.io/gh/pandas-dev/pandas/pull/20383?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Updated this. 

The remaining related warnings I think are:

/tmp/doc/source/generated/pandas.Index.holds_integer.rst: WARNING: document isn't included in any toctree
/tmp/doc/source/generated/pandas.Index.is_type_compatible.rst: WARNING: document isn't included in any toctree
/tmp/doc/source/generated/pandas.Series.imag.rst: WARNING: document isn't included in any toctree
/tmp/doc/source/generated/pandas.Series.real.rst: WARNING: document isn't included in any toctree

this seems to be because they are not listed manually in api.rst, and are also not linked in the class docstring page (because they have no docstring they appear as plain table entry, not link to the docstring page. With as a result there is nowhere a link to that page). 
Would adding them to the `hidden` toctree at the bottom of `api.rst` be OK? It'd fix the warnings. Not sure what happens to the links...
> Would adding them to the hidden toctree at the bottom of api.rst be OK? It'd fix the warnings. Not sure what happens to the links...

So now I need to remember again why we had those entries there at the bottom of api.rst ... Which you added in https://github.com/pandas-dev/pandas/pull/18202. Because this are attributes that were not yet included in api.rst before, and it is only now because they were no longer included in their class docstring page, there was a warning. 
But actually just giving them a proper docstring, should put them back in their class docstring page, and so fix the warning. So that is the more proper fix I think.



OK, so it seems that as long as they are properly included in the class docstring page toctree, that is also fine, so in principle then we can get rid of the full list of hidden items in api.rst (but for that, we need to add docstrings to some of those methods). That's the proper fix for the warnings, but will leave that for another PR (now added them to the hidden list in api.rst)
Travis doc build looks good