CLN: clean benchmarks to get them running
State: closed

Changes to be compatible with latest master / py3.

Labels:
name: Performance
description: Memory or execution speed performance
name: Clean

Comments:
this is great 

not sure if docs need any updates
i would default to 3.6 in the asv config as well
Almost forgot, there was one remaining error related to hdf5:

```
[ 38.26%] ··· Running hdfstore_bench.HDF5.time_query_store_table_wide                                                                                                                           failed
[ 38.26%] ····· Traceback (most recent call last):
                  File "/home/joris/scipy/asv/asv/benchmark.py", line 794, in <module>
                    commands[mode](args)
                  File "/home/joris/scipy/asv/asv/benchmark.py", line 771, in main_run
                    result = benchmark.do_run()
                  File "/home/joris/scipy/asv/asv/benchmark.py", line 455, in do_run
                    return self.run(*self._current_params)
                  File "/home/joris/scipy/asv/asv/benchmark.py", line 547, in run
                    all_runs.extend(timer.repeat(repeat, number))
                  File "/home/joris/miniconda3/envs/dev/lib/python3.5/timeit.py", line 206, in repeat
                    t = self.timeit(number)
                  File "/home/joris/miniconda3/envs/dev/lib/python3.5/timeit.py", line 178, in timeit
                    timing = self.inner(it, self.timer)
                  File "<timeit-src>", line 6, in inner
                  File "/home/joris/scipy/pandas/asv_bench/benchmarks/hdfstore_bench.py", line 89, in time_query_store_table_wide
                    ('index', '<', self.df_wide2.index[15000])])
                  File "/home/joris/scipy/pandas/pandas/io/pytables.py", line 722, in select
                    return it.get_result()
                  File "/home/joris/scipy/pandas/pandas/io/pytables.py", line 1428, in get_result
                    results = self.func(self.start, self.stop, where)
                  File "/home/joris/scipy/pandas/pandas/io/pytables.py", line 715, in func
                    columns=columns, **kwargs)
                  File "/home/joris/scipy/pandas/pandas/io/pytables.py", line 4103, in read
                    if not self.read_axes(where=where, **kwargs):
                  File "/home/joris/scipy/pandas/pandas/io/pytables.py", line 3302, in read_axes
                    self.selection = Selection(self, where=where, **kwargs)
                  File "/home/joris/scipy/pandas/pandas/io/pytables.py", line 4664, in __init__
                    self.terms = self.generate(where)
                  File "/home/joris/scipy/pandas/pandas/io/pytables.py", line 4677, in generate
                    return Expr(where, queryables=q, encoding=self.table.encoding)
                  File "/home/joris/scipy/pandas/pandas/core/computation/pytables.py", line 532, in __init__
                    where = ' & ' .join(["(%s)" % w for w in where])  # noqa
                  File "/home/joris/scipy/pandas/pandas/core/computation/pytables.py", line 532, in <listcomp>
                    where = ' & ' .join(["(%s)" % w for w in where])  # noqa
                TypeError: not all arguments converted during string formatting
```

Benchmarks are here: https://github.com/pandas-dev/pandas/blob/master/asv_bench/benchmarks/hdfstore_bench.py#L87-L93 
I am not very familiar with HDFStore, do you know what the issue is?
add a commit to use the correct syntax.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=h1) Report
> Merging [#16025](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f60b914e2100d44740df377d55f4d43b3709478c?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16025/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #16025      +/-   ##
==========================================
- Coverage   90.99%   90.99%   -0.01%     
==========================================
  Files         153      153              
  Lines       50470    50469       -1     
==========================================
- Hits        45927    45926       -1     
  Misses       4543     4543
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.76% <ø> (-0.01%)` | :arrow_down: |
| #single | `40.43% <ø> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `80.73% <0%> (-0.02%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=footer). Last update [f60b914...7e4b9dc](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=h1) Report
> Merging [#16025](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f60b914e2100d44740df377d55f4d43b3709478c?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16025/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #16025      +/-   ##
==========================================
- Coverage   90.99%   90.99%   -0.01%     
==========================================
  Files         153      153              
  Lines       50470    50469       -1     
==========================================
- Hits        45927    45926       -1     
  Misses       4543     4543
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.76% <ø> (-0.01%)` | :arrow_down: |
| #single | `40.43% <ø> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `80.73% <0%> (-0.02%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=footer). Last update [f60b914...9a074cf](https://codecov.io/gh/pandas-dev/pandas/pull/16025?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!

(BTW, you should link your two sigma address to your github account, it is not yet recognizing your commits)
Changed to 3.6 as well!
> (BTW, you should link your two sigma address to your github account, it is not yet recognizing your commits)

where do you see a problem?

side issue - I have a couple more small reorgs (indexes, tools) coming
If you look at the commit you added in this PR, it doesn't have your icon, and if you look at the commit: https://github.com/pandas-dev/pandas/pull/16025/commits/7e4b9dc12b20decc8d5b7be234a769f82871a6e7, the question mark next to the author gives some more explanation
e-mail address fixed thanks!