BrandonFors/pandas-github-issues huggingface dataset:
BUG/PERF: MultiIndex.difference losing EA dtype
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v1.6.0.rst` file if fixing a bug or adding a new feature.

Maintains EA dtypes and improves perf:

```
       before           after         ratio
     [71fc89cd]       [19e9ae76]
     <main>           <mi-difference>
-      29.0±0.8ms       16.7±0.9ms     0.58  multiindex_object.SetOperations.time_operation('monotonic', 'string', 'difference')
-      30.4±0.4ms       15.7±0.1ms     0.52  multiindex_object.SetOperations.time_operation('non_monotonic', 'string', 'difference')
-      26.7±0.7ms       13.0±0.5ms     0.49  multiindex_object.SetOperations.time_operation('monotonic', 'ea_int', 'difference')
-      30.1±0.3ms       13.3±0.1ms     0.44  multiindex_object.SetOperations.time_operation('non_monotonic', 'ea_int', 'difference')
-      25.1±0.5ms       8.87±0.2ms     0.35  multiindex_object.SetOperations.time_operation('monotonic', 'int', 'difference')
-      27.7±0.3ms       9.58±0.3ms     0.35  multiindex_object.SetOperations.time_operation('monotonic', 'datetime', 'difference')
-      27.5±0.4ms       9.13±0.3ms     0.33  multiindex_object.SetOperations.time_operation('non_monotonic', 'int', 'difference')
-      33.4±0.2ms       10.4±0.4ms     0.31  multiindex_object.SetOperations.time_operation('non_monotonic', 'datetime', 'difference')
```

Labels:
name: Performance
description: Memory or execution speed performance
name: MultiIndex
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
I’ve already got a pr about this, #48606
Ah, sorry. I saw the other setop PRs merged and thought difference might have been missed. I’ll close this.
DOC: re-phrase web README.md ENG
State: closed

Basic rephrasing of the web README.md for improved legibility 
- "to navigate it " -> "to allow navigation of the website " ("it" is ambiguous here, "website" leaves no question as to which entity the instructions refer to.
- "it is needed" -> "must"
- "a not open" -> "it is not possible to open " (perhaps a typo here initially, sentence lengthened for improved legibility)





Labels:
name: Docs
name: Web
description: pandas website

Comments:
Thanks @anonmouse1
CI: include tests in coverage
State: closed

It's hard to tell whether all tests are being executed in CI - can we add not omit them from the coverage report, so this'll be easier?

Labels:
name: CI
description: Continuous Integration

Comments:
Where can we observe the coverage difference from this change?

I see that coverage is written to `coverage.xml`, but it's not displayed in our logs
it should show up in https://app.codecov.io/gh/pandas-dev/pandas
Thanks @MarcoGorelli
BUG: pivot_table raising for nullable dtype and margins
State: closed

- [x] closes #48681 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
Thanks @phofl
BUG: pivot_table raising Future Warning with datetime column as index
State: closed

- [x] closes #48683 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I think I'd prefer back porting, but no strong opinion

Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Warnings
description: Warnings that appear or should be added to pandas

Comments:
Thanks @phofl
REGR: Regression in DataFrame.loc when setting df with all True indexer
State: closed

- [x] closes #48701 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
Thanks @phofl
Added theme_switcher 
State: closed

Added theme_switcher in  navbar_end to display the Dark/Light theme switcher

- [x] closes #48598 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Web
description: pandas website

Comments:
In Python you need to leave one space after commas. You can use flake8 to validate that there are no issies with the style of your code. That will make the checks green.
Thanks @deepaksirohiwal, looks good to me. Did you try this locally? Do you mind adding a screenshot here, so others can see how this will look when merged please?
Here are some screenshots of the new visual changes. Now Theme switch is available (top right) to toggle between different modes (Dark, Light and Auto) 
1
![Light](https://user-images.githubusercontent.com/38135521/191915680-3cc5fe32-8ca9-49e2-9a24-082b543af79c.jpg)
Light mode-Switch
2
![dark](https://user-images.githubusercontent.com/38135521/191915796-b98c8988-ccd1-4cd3-8e03-852950d92f12.jpg)
Dark mode -Switch
3
![auto](https://user-images.githubusercontent.com/38135521/191916103-0b6aab7c-5609-4dd5-9600-847b86c68ad1.jpg)

Auto mode(according to system setting)-Switch

thank you so much the dark theme is so hard to read in the docs!
Thanks @deepaksirohiwal 
Thank you @datapythonista and @mroeschke, I really learnt a lot and would love to contribute more.
REGR: dropna affects observed in groupby
State: closed

- [x] closes #48645 (Replace xxxx with the Github issue number)
- [x] closes #46909 (the cleanup is no longer applicable) 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Since this reintroduces a bug, a longer whatsnew note seemed appropriate.

Labels:
name: Bug
name: Groupby
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Regression
description: Functionality that used to work in a prior pandas version
name: Categorical
description: Categorical Data Type

Comments:
thx @rhshadrach
CLN: Clean groupby ops from unreached code paths
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

We can't hit these code paths anymore

Labels:
name: Groupby
name: Clean

Comments:
Nice!
Thanks @phofl
REGR: None converted to NaN when enlarging Series
State: closed

- [x] closes #48665 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
Thanks @phofl
REGR: to_hdf raising AssertionError with boolean index
State: closed

- [x] closes #48667 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: IO HDF5
description: read_hdf, HDFStore

Comments:
Thanks @phofl
ENH: Make deprecate_nonkeyword_arguments alter function signature
State: closed

- [x] closes #48692
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Enhancement
name: Deprecate
description: Functionality to remove in pandas

Comments:
Nice, thanks for working on this - would this solve https://github.com/pandas-dev/pandas/issues/48656 too?
@MarcoGorelli it almost fixes it, but not quite (since we have to look in kwonlyargs not args). Once this is merged I can open a PR to fix that
Thanks @hauntsaninja !
BUG: Restrict Timestamp(nanosecond=...) to [0, 999]
State: closed

- [x] closes #48538 (Replace xxxx with the Github issue number)
- [x] closes #48255 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/v1.6.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Timestamp
description: pd.Timestamp and associated methods

Comments:
thx @mroeschke
DEPR: enforce Timedelta freq, delta, is_populated deprecations
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timedelta
description: Timedelta data type
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks @jbrockmendel
DOC: Clarify exceptions that are internal only
State: closed

xref https://github.com/pandas-dev/pandas/pull/48088#issuecomment-1252924401


Labels:
name: Docs
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
Personally, I would rather actually remove those from the public API: 1) a user should never have to use those (so having them in the public `pandas.errors` module serves no real purpose I think), 2) since they are internal implementation details, we should be free to change or remove them without worrying about compatibility.

> My concern is that overtime the "internal" exceptions or warnings may unintentionally become publicly thrown, and at least users could still catch them through `pandas.errors`

We can maybe use some naming scheme to make it clearer those are actually internal? (eg `_Internal_` prefix, so there is less chance we accidentally use it in a public location, or it's clearer something is wrong if you see this as a user).



Sounds like we may need a different gameplan here so closing for now.
BUG: to_datetime(tz_mix, utc=True) converts to UTC
State: closed

- [x] closes #48678 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/v1.5.1.rst` file if fixing a bug or adding a new feature.


Labels:
name: Datetime
description: Datetime data dtype
name: Timezones
description: Timezone data dtype

Comments:
Can merge on greenish I think
thx @mroeschke
DEPR: enforce deprecations on DateOffset methods
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Frequency
description: DateOffsets
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks @jbrockmendel
Corrected pd.merge indicator type hint
State: closed

The argument "indicator" in [merge ](https://pandas.pydata.org/docs/reference/api/pandas.merge.html ) should be "str | bool" instead of just string.

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Anyone knows why is this check failing? "Ubuntu / actions-310.yaml pyarrow=5 single_cpu (pull_request)" when all others go well? I think the PR is still ok.
Thanks @PabloRuizCuevas
BUG: to_datetime raising on invalid offsets with errors=coerce and infer_datetime_format
State: closed

- [x] closes #48633 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
Thanks @MarcoGorelli
DOC: Document default value for options.display.max_cols when not running in terminal
State: closed

`display.max_cols` has a default value of 20 when not running in a terminal such as Jupyter Notebook.

This was a little confusing as the documentation for the default parameters generated in [Pandas User Guide - Available Options](https://pandas.pydata.org/docs/user_guide/options.html#available-options) are [environment specific](https://github.com/pandas-dev/pandas/blob/e493323d93e6a3447f0adfded493b80a42f4fec4/pandas/core/config_init.py#L412-L415) and 0 for when terminal is detected, but this was not noted in the current description.


Labels:
name: Docs

Comments:
Thanks @tmoschou
DEPR: enforce deprecation on floats with unit=M or Y
State: closed

Unfortunately just found that we missed the analogous behavior in to_datetime with non-scalars.  That'll go in the just-do-in-2.0 pile.

Whatsnew is in 1.6 on the assumption it will be changed to 2.0.

Labels:
name: Frequency
description: DateOffsets
name: Deprecate
description: Functionality to remove in pandas

Comments:
@phofl gentle ping, getting this in will allow us to move the whatsnew notes over to the new section and start getting those in
thx @jbrockmendel
ENH: unique/factorize preserve non-nano
State: closed

Put the whatsnew note in 1.6, assuming that will be changed to 2.0.

Labels:
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff
name: Stale
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Closing as blocked by #50690 (or reso inference in array_to_datetime)
ENH: DTA/TDA add datetimelike scalar with mismatched reso
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
Thanks @jbrockmendel
Fix scorecard.yml workflow
State: closed

Workflow was added by #48570, but set ossf/scorecard-action to a major version tag (v2). However, that action only has minor version tags. So it is currently broken. Wasn't caught because the `if github.repository` check skipped the action on my fork, and in my hubris I assumed it'd just work. 🤦 

This PR simply sets the action to the current minor version v2.0.3. Has been checked on my fork, can confirm it works!

Labels:
name: CI
description: Continuous Integration

Comments:
No worries, it happens to everyone. 
Thanks for the quick fix.
BUG: Series.getitem not falling back to positional for bool index
State: closed

- [x] closes #48653 (Replace xxxx with the Github issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

cc @jbrockmendel 

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
Thx
Thanks @phofl
BUG: DatetimeIndex ignoring explicit tz=None
State: closed

- [ ] closes #xxxx (Replace xxxx with the Github issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timezones
description: Timezone data dtype

Comments:
> [...] Also be a bug then?

Probably, yes.
Thanks @jbrockmendel. If you could follow up with the `Timestamp` case that'd be great