#34569 Added proper description for pandas.Series.pop
State: closed

- [x] closes #34569
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

Updated documentation will look like this: https://i.imgur.com/Tl9JO5X.png
This is my first commit to the project. If any changes/modifications let me know.


Labels:
name: Docs
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Yes sure will do that. Thanks for the help.
Hello @2796gaurav! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:









There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-06-22 19:07:27 UTC
@MarcoGorelli I had made changes as you mentioned. Attached ss of both dataframe.pop and series.pop. I don't know how to check code in my local machine. I hope its working fine. 
Still, it would be great if you can provide guidance on how to check local python function changes.

pandas.DataFrame.pop
https://i.imgur.com/LIL9VpN.png

pandas.Series.pop
https://i.imgur.com/yoWPJGk.png
@MarcoGorelli This one works perfectly. I have checked on my local system.
here's ss of updated pop documentation.

DataFrame.pop() -> https://i.imgur.com/bcPFwyZ.png
Series.pop() -> https://i.imgur.com/d2SvuOe.png
@MarcoGorelli I have made changes as you have said and checked with ``mypy`` locally and everything works fine. But when deployed it gives an error. can you help here?
@MarcoGorelli It works. There is just one Linting issue with flake8.
if i import 
```
if TYPE_CHECKING:
    from pandas.core.series import Series  # noqa: F401
```
i am getting this error.

`##[error]./pandas/core/generic.py:5340:9:F811:redefinition of unused 'Series' from line 108`

Can you help me out in this.
> i am getting this error.
> 
> `##[error]./pandas/core/generic.py:5340:9:F811:redefinition of unused 'Series' from line 108`
> 
> Can you help me out in this.

you can add a # noqa: F811 to generic.py:5340 (it's unfortunate that when using TYPE_CHECKING we get these false positives on the linter)
@2796gaurav it appears that your pull request is from your master branch on your fork. next time may be easier to create a feature branch for your changes https://pandas.pydata.org/docs/dev/development/contributing.html#creating-a-branch
@simonjayhawkins It really helped. Thanks for that. Also, I will take note to create a new branch next time. Let me know if you want to do this for this issue.

@MarcoGorelli I think I have made changes as instructed. Attaching ss of the pages.

pandas.DataFrame.pop -> https://i.ibb.co/F09N4Fc/img-df-pandas.png

pandas.Series.pop -> https://i.ibb.co/yhjbCT3/img-df-series.png
Thanks @simonjayhawkins and @MarcoGorelli . It was great working with both of you. This was my first contribution. I would make sure to create a separate branch before working.👍
Also if you have other tasks which you think i can contribute, let me know.
sorry @simonjayhawkins "request for review" clicked by mistake.
Thanks @2796gaurav