BrandonFors/pandas-github-issues huggingface dataset:
REGR: isin with nullable types with missing values raising 
State: closed

- [x] closes #39844
- [x] closes #42405
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Didn't look like there was a consensus reached on NA propagation in #39844, this should maintain the behavior from 1.2.x of not propagating and just fix the regression

Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays
name: isin
description: isin method

Comments:
Have fixed the issue in benchmark for nullable types in a different way. If still looks a bit kludgy let me know, and we can just leave that out of this pr
also rebase
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.3.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 f8855eb719ac8f8551ba50bf35dfcdc24ad60b5f
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #42473: REGR: isin with nullable types with missing values raising '
```

4. Push to a named branch :

```
git push YOURFORK 1.3.x:auto-backport-of-pr-42473-on-1.3.x
```

5. Create a PR against branch 1.3.x, I would have named this PR:

> "Backport PR #42473 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@meeseeksdev backport 1.3.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.3.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 f8855eb719ac8f8551ba50bf35dfcdc24ad60b5f
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #42473: REGR: isin with nullable types with missing values raising '
```

4. Push to a named branch :

```
git push YOURFORK 1.3.x:auto-backport-of-pr-42473-on-1.3.x
```

5. Create a PR against branch 1.3.x, I would have named this PR:

> "Backport PR #42473 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
this is going to need a manual backport, cc @mzeitlin11
CLN TST: Refactor `Styler.bar` tests through parametrisation
State: closed

`Styler.bar` tests are refactored to avoid code duplication and enhance the testing process to cover a wider array of scenarios with simpler code.

Summary of removed tests and their replacement coverage:

Original Test | Replaced By | Parameters |
--- | --- | --- |
test_bar_align_left | test_align_positive_cases <br> test_numerics <br> test_colors_mixed | align=left |
test_bar_align_left_0points | test_align_axis | axis=[index,columns] <br> align=left |
test_bar_align_mid_pos_and_neg | test_align_mixed_cases <br> test_colors_mixed | align=mid |
test_bar_align_mid_all_pos | test_align_positive_cases | align=mid |
test_bar_align_mid_all_neg | test_align_negative_cases | align=mid |
test_bar_align_zero_pos_and_neg | test_align_mixed_cases <br> test_colors_mixed | align=zero |
test_bar_align_left_axis_none | test_align_axis | align=left <br> axis=None |
test_bar_align_zero_axis_none | test_align_axis | align=zero <br> axis=None |
test_bar_align_mid_axis_none | test_align_axis | align=mid <br> axis=None |

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Styler
description: conditional formatting using DataFrame.style

Comments:
thanks @attack68 always happy to take these
DOC: GH42420 Fix typo in windows C compiler install guide
State: closed

Closes #42420

Labels:
name: Build
description: Library building on various platforms
name: Docs

Comments:
closes #42420 (very nice)
also in the future mention the issue with a # in the desc and comment take on the issue to assign it to yourself
Thank you, will do!
Would it make sense to push several updates to documentation at once, with a comment like "- closes #123456, #654321, #214365"? Or might it muddy the waters?
> Would it make sense to push several updates to documentation at once, with a comment like "- closes #123456, #654321, #214365"? Or might it muddy the waters?

Tightly-scoped prs are easiest to review, so if the updates are unrelated, best to keep them to separate prs
> > Would it make sense to push several updates to documentation at once, with a comment like "- closes #123456, #654321, #214365"? Or might it muddy the waters?
> 
> Tightly-scoped prs are easiest to review, so if the updates are unrelated, best to keep them to separate prs

Thank you!
Thanks @AlessandroBisiani 
Thank you all for the feedback+!
REGR: indexing with list subclass
State: closed

- [x] closes #42461
- [x] closes #42433
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
Add Logging error message to easy debug
State: closed

Add a Logging error message to debug easier.

![image](https://user-images.githubusercontent.com/5876946/125116176-83b2df00-e116-11eb-8567-bf12ec2cddc7.png)




Labels:

Comments:
Hello @maycuatroi! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

* In the file [`pandas/core/indexes/base.py`](https://github.com/pandas-dev/pandas/blob/e084737f6149c5f5f958829733f30dcb6af57764/pandas/core/indexes/base.py):

> [Line 3383:89](https://github.com/pandas-dev/pandas/blob/e084737f6149c5f5f958829733f30dcb6af57764/pandas/core/indexes/base.py#L3383): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (113 > 88 characters)


1) please write a test

2) it isn't obvious this is useful (and certainly isnt a pattern we follow anywhere else)  is there an issue where this is discussed?
this is dangerous. what if the index has 1 million values?
Thanks for the PR, but agreed with the other in that native logging in pandas is not a regular. For this use case, we would recommend logging around the exception instead. 

Closing, but if you'd like to contribute we would recommend checking out issues labeled `first good issues`
CI: Don't auto-cancel on master
State: closed

- [ ] closes #42076 
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

I haven't tested that this skips the cancel on master branch, only that it cancels already running workflows on PRs(e.g. https://github.com/lithomas1/pandas/pull/3). 
So, be ready to revert if needed.


Labels:
name: CI
description: Continuous Integration

Comments:
One potential problem is this could cause a blockage if we merge many PRs in a short amount of time. 
> One potential problem is this could cause a blockage if we merge many PRs in a short amount of time.

no this is ok / fine. as we used to do exactly this.
thanks @lithomas1 

if you'd monitor would be great.
BUG: MultiIndex.get_loc with string key on DatetimeIndex level
State: closed

- [ ] closes #xxxx
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: MultiIndex

Comments:
this already works? e.g. this is only tests. IIRC we did merge the patch for this before, right?
Correct.

I’m gonna have to do a test-organization pass before long

On Thu, Jul 15, 2021 at 4:58 PM Jeff Reback ***@***.***>
wrote:

> this already works? e.g. this is only tests. IIRC we did merge the patch
> for this before, right?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/42465#issuecomment-881082075>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB5UM6AMENNVRRZX57LQMT3TX5Y3LANCNFSM5ADC472Q>
> .
>
BUG: `to_xml` with `index=False` and offset input index
State: closed

Fixes #42458

It was assumed that the index contains the element `0`. This led to a
defect when the index of the input Dataframe has an offset, which is a
common use case when streaming Dataframes via generators.

This fix consists of not relying on accessing the `0` element of
`frame_dicts`.

- [x] closes #42458 
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Bug
name: IO XML
description: read_xml, to_xml

Comments:
cc @ParfaitG if you can have a look here
thanks @stephan-hesselmann-by for the patch and @ParfaitG for the review!
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
BUG: Mitigate division with zero in roll_var
State: closed

- [ ] closes #42442 
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Window
description: rolling, ewma, expanding

Comments:
cc @mroeschke 
@benHeid 

> However, I am unsure about writing tests for pandas since this is my first PR to pandas. I would appreciate help here. Thank you.

Take a look at 

https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#testing-with-continuous-integration

as well as the tests in `pandas.tests.window`, and feel free to ask questions here.
Hello @benHeid! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-07-24 11:12:40 UTC
I added a parameterized test with different min_periods and windows.
there are still some precommit issues here
@github-actions pre-commit

can you add a release note in 1.4 bug fix section (under rolling)
thanks @benHeid
Fixed Issue #42447
State: closed

- [🗸 ] closes #42447 
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:

Comments:
> Thanks for submitting @Varun270 but I have to comment that almost all of these changes are unnecessary and would just be adding to the commit history without gaining anything..
> 
> We would very much welcome PRs on issues, with some highlighted by a "good first issue" label. Many of them are identified documentation improvement issues.

Ok then I am closing this issue, thanks for reviewing
BUG: TypeError when shifting DataFrame created by concatenation of slices and fills with values
State: closed

- [x] closes #42719
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Regression
description: Functionality that used to work in a prior pandas version
name: Internals
description: Related to non-user accessible pandas implementation

Comments:
I decide to reopen this PR and ignore array manager with reference to `test_shift_dt64values_int_fill_deprecated`.
looks fine.

cc @jbrockmendel 
@jbrockmendel Done.
thanks @wjsi 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
CI: Sync all 3.9 builds
State: closed

- [x] closes #37826

IIUC, all the 3.9 builds(except numpydev) should have all dependencies.


Labels:
name: CI
description: Continuous Integration

Comments:
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.3.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 87d785599e01ec1f8a9799fc87d6ab4c77c3590c
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #42451: CI: Sync all 3.9 builds'
```

4. Push to a named branch :

```
git push YOURFORK 1.3.x:auto-backport-of-pr-42451-on-1.3.x
```

5. Create a PR against branch 1.3.x, I would have named this PR:

> "Backport PR #42451 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
thanks @lithomas1 
@meeseeksdev backport 1.3.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.3.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 87d785599e01ec1f8a9799fc87d6ab4c77c3590c
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #42451: CI: Sync all 3.9 builds'
```

4. Push to a named branch :

```
git push YOURFORK 1.3.x:auto-backport-of-pr-42451-on-1.3.x
```

5. Create a PR against branch 1.3.x, I would have named this PR:

> "Backport PR #42451 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
I think for the backport, will only backport changes in `ci/deps/actions-39.yaml` and leave `ci/deps/actions-39-slow.yaml` which maps to `ci/deps/actions-37-slow.yaml` unchanged.
BUG: Issue with pd.cut on Series with duplicate index
State: closed

- [x] closes #42185 
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Creating a new PR. I had messed up the earlier one by mistake.

Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
please review
Can you merge master, and fix the problems in the CI please? Ping us when it's green. Thanks!
@datapythonista @jreback Green
thanks @debnathshoham
BUG: MultiIndex.get_loc re-raise TypeError as KeyError
State: closed

- [ ] closes #xxxx
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Bug
name: MultiIndex

Comments:
this is a user facing change?
> this is a user facing change?

yes, will add note
looks fine can yu rebase
rebased + greenish
DOC: Refactor Numba enhancing performance and add parallelism caveat
State: closed

- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them


Labels:
name: numba
description: numba-accelerated operations

Comments:
> doc/source/user_guide/window.rst:264:12: F401 'pandas.api.indexers.BaseIndexer' imported but unused
doc/source/user_guide/window.rst:281:22: F821 undefined name 'CustomIndexer'
doc/source/user_guide/enhancingperf.rst:341:18: E225 missing whitespace around operator
thanks @mroeschke 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
Backport PR #42419 on branch 1.3.x (CI: update vm image version for Azure)
State: closed

Backport PR #42419: CI: update vm image version for Azure

Labels:
name: CI
description: Continuous Integration

Comments:
macOS py37_macos timed out. restarted to check environment setup. some tests are expected to fail. 
@simonjayhawkins is 3.7 not compat with this? (e.g. ok to not backport this as well).
in the current build, env setup completed in 10m 53s. so will merge pending tests pass (apart from the URL fails)
TYP: dtype specializations for np.ndarray in algos.pyi (part)
State: closed

cc @jbrockmendel 

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
neat!  ill have to go through and double-check the exact dtypes, but this looks really nice
Thanks. The obvious place to start is the libraries then propagate these up.

I'm struggling to get mypy failures. static type checking checks type compatibility whereas the cython is specialized for specific dtypes.


i take it npt.NDArray doesnt allow for specifying ndim?
needs rebase, otherwise i think this is an improvement even if you're having trouble producing errors
can you rebase
@simonjayhawkins what are your plans here?  i was thinking of doing a pass updating the _libs ndarray annotations
> @simonjayhawkins what are your plans here? i was thinking of doing a pass updating the _libs ndarray annotations

you are welcome to pull these changes into another branch.

(or I can fix-up this PR. I did not think it was appropriate to work on typing PRs while there are typing PRs from others that need review) 
> I did not think it was appropriate to work on typing PRs while there are typing PRs from others that need review

thats thoughtful of you, but no one will hold it against you
BUG: pd.cut with duplicate index Series lowest included
State: closed

- [x] closes #42185
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Bug
name: cut
description: cut, qcut

Comments:
Hi @jreback , apologies, I am new to open source contributions.
I have run the tests. Below is a screenshot. I am not very sure if (and how) my change caused these failures.

![Screenshot 2021-07-07 at 8 50 43 PM](https://user-images.githubusercontent.com/6472290/124786611-7c989f00-df65-11eb-9291-e4973866c0ff.png)

we have extensive docummentation on how to do changes: https://pandas.pydata.org/pandas-docs/dev/development/index.html

you need to add tests for your scenario and not break anything else.
DOC: GH42409 Fix mistake in code example of Styler.to_latex documentation
State: closed


- [x] closes #42409
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Docs
name: IO LaTeX
description: to_latex
name: Styler
description: conditional formatting using DataFrame.style

Comments:
thanks @STAMcM 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
CI: runtime warning in npdev build
State: closed

- [x] closes #42381
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: CI
description: Continuous Integration

Comments:
Thanks @jbrockmendel
CI: Don't test on 1.2.x
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: CI
description: Continuous Integration

Comments:
thanks @lithomas1 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
DEPS: use importlib for backend discovery #41815
State: closed

- [x] closes #41815

We still use `pkg_resources` in mpl tests. But it doesn't affect end users. 

Labels:
name: Build
description: Library building on various platforms

Comments:
> Performing static analysis using mypy
pandas/plotting/_core.py:1763: error: Item "None" of "Optional[Tuple[EntryPoint, ...]]" has no attribute "__iter__" (not iterable)  [union-attr]
pandas/plotting/_core.py:1766: error: Invalid self argument "EntryPoint" to attribute function "load" with type "Callable[[EntryPoint], Any]"  [misc]
Found 2 errors in 1 file (checked 1297 source files)
Performing static analysis using mypy DONE


thanks @fangchenli
CLN: random state updates after dropping numpy 1.17
State: closed

Followup to random state changes now that numpy 1.17 dropped


Labels:
name: Clean
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
this is rebase on master, e.g. after @fangchenli recent PR?
> this is rebase on master, e.g. after @fangchenli recent PR?

Yep, branched couple hours ago
DOC: Adding examples to DataFrameGroupBy.rank #38972
State: closed

- [x] closes #38972
- [x] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Docs
name: Groupby
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
Hello @debnathshoham! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-07-11 19:41:09 UTC
Hi @mzeitlin11 , just made the suggested changes. I have also attached how it looks now. Please let me know if this looks fine.
![Screenshot 2021-07-06 at 9 32 34 PM](https://user-images.githubusercontent.com/6472290/124632269-d20b7800-dea1-11eb-9149-57ddc45858d8.png)

please review
> please review

Sorry for later review, `pandas` is volunteer, so review may sometimes take a while :) Left some small comments, otherwise LGTM!
@debnathshoham of note: The docstring validation is failing

```
Error: /home/runner/work/pandas/pandas/pandas/core/groupby/groupby.py:2638:GL07:pandas.core.groupby.DataFrameGroupBy.rank:Sections are in the wrong order. Correct order is: Parameters, Returns, See Also, Examples
```
thanks @mroeschke . I believe it would be fixed now.
Thanks @debnathshoham