DOC: doc warnings
State: closed


Labels:
name: Docs

Comments:
don't merge yet.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15647?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@94c6c0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff            @@
##             master   #15647   +/-   ##
=========================================
  Coverage          ?      91%           
=========================================
  Files             ?      143           
  Lines             ?    49324           
  Branches          ?        0           
=========================================
  Hits              ?    44885           
  Misses            ?     4439           
  Partials          ?        0
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15647?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/94c6c0ce46ceae8ceb3a81f17014e6551902e653...67f19f42277f940f0e60fdba5c8b685cea6ad872?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.87% <ø> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15647?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15647?src=pr&el=footer). Last update [94c6c0c...6afb394](https://codecov.io/gh/pandas-dev/pandas/compare/94c6c0ce46ceae8ceb3a81f17014e6551902e653...6afb3944017533c3dc6df70a144df48f85e1c1f8?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
@jreback Fixed the problems with #15620 in that PR, to keep the credit.
ok thanks
ok I think this fixed the HDFStore issues.
Cool. 
Is the list with with expressions not supported anymore? Or just for some reason failing on travis?
@jorisvandenbossche no a list is still accepted (but nicer with the and). The issue was the bare strings, e.g. ``bar=foo``; for some reason the foo is interpreted as an ascii string I think, you need to use the correct quotes ``"``. I cannot repro this so maybe its an encoding issue (IOW even though we are building with 3.5, maybe the encoding of the file itself is ascii, just guessing here).

I put a note on the original issue #15544 to see if @chris-b1 has any ideas. 
@jorisvandenbossche ok this fixes a bunch of warnings (still a couple remaining) :>

some png links and a LICENSE link........but enough for now.
The png and license link warnings are already present for a few years, so not too urgent :-)
The issue here was that `foo` was a defined name in a different whatsnew [section](http://pandas-docs.github.io/pandas-docs-travis/whatsnew.html#whatsnew-0170-enhancements-other)
```python
foo = pd.Series([1,2], name='foo')
```

Now this comparison was unpacking the ints in that `Series` (which tbh I didn't know we did - but basically is like `.isin`) and raising the now invalid comparison.  
```python
store.select('df',[ 'B > 0', 'string == foo' ])
```

In past doc versions, this was just returning an empty result ([here](http://pandas.pydata.org/pandas-docs/stable/whatsnew.html#hdfstore)).  This is exactly that type of invalid comparisons we were trying to catch with #15544, so I think it's good that this raised!


@chris-b1 ahh that makes sense then. thanks for the look!