BrandonFors/pandas-github-issues huggingface dataset:
Changed pandas-qt python2/3 friendly qtpandas.
State: closed

Just changed the link to the abandoned repository python 2 only pandas-qt to the new functional Python 2/3 friendly qtpandas.

Labels:
name: Docs

Comments:
I don't know why appveyor failed. I just changed line in the docs are tests even required?
@draperjames the failure is not related to your PR (we have some problems with appveyor at the moment), just look for travis

Can you provide some more explanation for this PR? Why the change? Is this a successor of the other project or a fork? Better maintained?
Can you provide some more explanation for this PR? 
- Sure
### Why the change?
- pandas-qt doesn't support for python3. also the maintainer has shown no interest in it for a while.
### Is this a successor of the other project or a fork?
- This is a fork of the project but the namespace has been changed from `pandasqt` to `qtpandas`. We aren't happy about that either but there was no real way around it.
### Better maintained?
- We can only hope. @zbarge and I (@draperjames) are currently maintaining the repo on github and it's pip. So if we are just talking about people with access its twice as well maintained. We are looking for people that would be interested in helping build it out. 
@jorisvandenbossche Is there anything I can do to move this along?
> Is there anything I can do to move this along?

Nope, this is fine.

I just want to give @datalyze-solutions some time to react on this, as they added it initially. If there is no reaction in the short term, very happy to merge this!

cc @datalyze-solutions @kaotika You are aware and OK with this? 
By the way, another solution would be that you give @draperjames commit rights to the parent repoif you think that the changes they made in the fork are valuable, but don't have time to maintain it.


@jorisvandenbossche I have tried to contact @kaotika and @datalyze-solutions several times over the span of a month with no response. If either entity wanted to to give @zbarge or myself commit rights to the parent we would happily merge our fork with the original repo and help to maintain the project. Thanks for your time.
@draperjames waited long enough :-) 
BTW, thanks for taking this up!
For some reason this PR was targeting 0.19.x branch instead of master, so applied the same commit on master as well: https://github.com/pandas-dev/pandas/commit/0d3ecfa8ba3930b688a6781c7f84138bc80da41a
Groupby tests restructure
State: closed

closes #14813 


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby

Comments:
@jreback i have created this pr for the groupby tests restructure, at this point i have only moved the group by filter tests to a new file. Wanted to confirm if this is how it needs to be done also for the review comments.
you can name test_groupby_filters -> test_filters.py

yes this is the idea
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14817?src=pr) is 84.55% (diff: 100%)
> Merging [#14817](https://codecov.io/gh/pandas-dev/pandas/pull/14817?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **0.76%**

```diff
@@             master     #14817   diff @@
==========================================
  Files           144        144          
  Lines         51043      51043          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43552      43159   -393   
- Misses         7491       7884   +393   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [dd8cba2...860574d](https://codecov.io/gh/pandas-dev/pandas/compare/dd8cba27677895e80768f22f6992e58046dcc3bf...860574d4ef44b9d3d210f140aea0fae0fdbe5ef6?src=pr)
@aileronajay can you update a bit (IOW, split maybe a little more). ping on green and can merge right  away to prevent merge conflicts.
@jreback i do intend to pick this up from next week (just stuck with some stuff right now)
@jreback i have further split the tests into aggregate and categorical tests. So now we have filters, aggregate and categorical tests in separate files. There is also the original file with the tests that were not moved to one of the new files 
looks like you have ``test_groupby_filters`` and ``test_filters``?
@jreback it was a duplicate, i have removed it now
@jreback i had thought about removing the agg (and other identifiers) but then i wonder if leaving them in place is detrimental?
@aileronajay so on second thought, let's do that in another PR. then the changes will be obvious. So just leave the split files here. ping on green.
@jreback all tests are passing
thanks @aileronajay 

ok, couple of followups.

originally had 302 tests, now have 305, so a couple duped (not a big deal but if can fix would be great).

move apply, transform, agg from test_groupby -> test_agg (IOW anything having to do with these)

after that if you can find any more logical categories to split tests, pls post.
@jreback i was thinking of moving all cython tests into another file, but the cython tests individually belong to a different category each
BUG: Fix linux clipboard QApplication() creation
State: closed

 - [x] closes #14372

A Qt application cannot instantiate multiple `QApplication` instances,
so we create a new `QApplication` only when the global
`QApplication.instance()` is None.

Failing sample (gtk should not be installed for pandas to use qt clipboard):

```
from PyQt4.QtGui import QApplication
myapp = QApplication([])
from pandas.util.clipboard import clipboard_get  # <--- ERROR

  File "prefix/lib/python2.7/site-packages/pandas/util/clipboard.py", line 164, in <module>

    app = qt4.QtGui.QApplication([])

RuntimeError: A QApplication instance already exists.

```

Labels:
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
this should be addressed upstream

pls file a report with pyoerclip
if it's accepted there then we can merge 
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14815?src=pr) is 85.27% (diff: 0.00%)
> Merging [#14815](https://codecov.io/gh/pandas-dev/pandas/pull/14815?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #14815   diff @@
==========================================
  Files           144        144          
  Lines         50968      50968          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43466      43465     -1   
- Misses         7502       7503     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [2466ecb...40d70f9](https://codecov.io/gh/pandas-dev/pandas/compare/2466ecbb717d8cdfd30cc20d5d22e5e095d9a14d...40d70f9c185befc9288f41fb51c2567013fa880f?src=pr)
can you add a whatsnew note (0.20.0)
thanks!
Apply min_itemsize to index even when not appending
State: closed

 - [x] closes #10381
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry

Labels:
name: Bug
name: IO HDF5
description: read_hdf, HDFStore

Comments:
can you add a replica of @TomAugspurger example as well (you can make a new test function is fine). Just to cover the bases.
otherwise lgtm.
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14812?src=pr) is 85.26% (diff: 100%)
> Merging [#14812](https://codecov.io/gh/pandas-dev/pandas/pull/14812?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #14812   diff @@
==========================================
  Files           144        144          
  Lines         50981      50980     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43470      43469     -1   
  Misses         7511       7511          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [81a2f79...c07f1e4](https://codecov.io/gh/pandas-dev/pandas/compare/81a2f792a342a047bcc98b45cd6e99e6d82010b3...c07f1e4c987c01df60590c48dc6c6cd55c377f84?src=pr)
Appveyor is stuck again
rebase again, problem with appeveyor which i just fixed
TST: Test pivot with categorical data
State: closed

closes #8860
closes #8731
closes #9534

Looks like the examples in these issues pass in the master branch. Added test to confirm. 


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Categorical
description: Categorical Data Type

Comments:
@mroeschke thanks! 

can you see if you can figure out what issues solved these and list here.

If they are in 0.19.2 or 0.20, then we want to add these issues to the current whatsnew.
Cool! 
It seems they were already solved in 0.19.0
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14807?src=pr) is 85.28% (diff: 100%)
> Merging [#14807](https://codecov.io/gh/pandas-dev/pandas/pull/14807?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14807   diff @@
==========================================
  Files           144        144          
  Lines         50953      50968    +15   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43452      43467    +15   
  Misses         7501       7501          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [4378f82...b506083](https://codecov.io/gh/pandas-dev/pandas/compare/4378f82967f59097055eef17ede50aa515525551...b506083205d8b086eec7e9b8b21cf676d7c3c1ce?src=pr)
Looks like #11371 may have helped address these issues back in 0.17.1, but I am not finding any recent PRs fixing these issues.  
thanks!
BUG: MultiIndex truncated for some non-list arguments
State: closed

closes #14794.

WIP.  Discussion/suggestions welcome.



Labels:
name: Bug
name: MultiIndex

Comments:
pls add tests first. just make the simple change and get it to work. then you can do follows to restructure if necessary / more clear. There are a lot of things going going on here (IOW lots of routines hit this), and lots of variations of accepted, so need to be quite careful (and more so about performance).
Thank you.  I guess I got carried away.  I'll do a fresh start and open a new PR.
BUG: fix hash collisions for from int overflow
State: closed

hash collisions brought up: https://github.com/pandas-dev/pandas/issues/14711#issuecomment-264885726


closes #14804 


Labels:
name: Bug
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
thanks team!

cc @mrocklin
cc @mikegraham 
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14805?src=pr) is 85.27% (diff: 100%)
> Merging [#14805](https://codecov.io/gh/pandas-dev/pandas/pull/14805?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14805   diff @@
==========================================
  Files           144        144          
  Lines         50953      50953          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43451      43452     +1   
+ Misses         7502       7501     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [53bf1b2...707becf](https://codecov.io/gh/pandas-dev/pandas/compare/53bf1b27c7dac2a8d72d9bcfe75f514dae8e8c96...707becfc8bf0d5d8ac615696037b03300d5f65b1?src=pr)
DOC: Fix grammar and formatting typos 
State: closed

One grammatical typo, and the rest address small formatting typos when rendering online.  

Labels:
name: Docs

Comments:
@mroeschke Thanks for the PR! Just one comment about the line length (our strict rules nowadays are sometimes a bit cumbersome for the docstrings ..)
Ah you were correct; Travis threw a linting error. Thanks for the tips and explanation about #noqa! I'll fix those tonight.  
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14803?src=pr) is 85.28% (diff: 100%)
> Merging [#14803](https://codecov.io/gh/pandas-dev/pandas/pull/14803?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14803   diff @@
==========================================
  Files           144        144          
  Lines         50968      50968          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43466      43467     +1   
+ Misses         7502       7501     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [2466ecb...e08d27e](https://codecov.io/gh/pandas-dev/pandas/compare/2466ecbb717d8cdfd30cc20d5d22e5e095d9a14d...e08d27e578c6c95ed7ba019c7a1199b60dcc599d?src=pr)
@mroeschke the linter is now complaining about some other lines:

```
pandas/core/generic.py:3638:80: E501 line too long (84 > 79 characters)
pandas/core/generic.py:3646:80: E501 line too long (80 > 79 characters)
pandas/core/generic.py:3660:80: E501 line too long (80 > 79 characters)
pandas/tools/plotting.py:2896:80: E501 line too long (80 > 79 characters)
```

(also lines that you didn't change, but I suppose that the `#noqa` suppressed them as well)
Oops. Thanks for the heads up. I'll address those tonight as well. 
Hmm `git diff master | flake8 --diff` and `pep8radius master --diff` passed locally, but it seems Travis still threw a linting error? @jorisvandenbossche 


Yep (you can always look at the travis log (third build): https://travis-ci.org/pandas-dev/pandas/jobs/181861282, scroll to bottom):

pandas/core/generic.py:3662:80: E501 line too long (80 > 79 characters)

It's from lines that you didn't touch yourself (the full docstring was not checked before), so checking the diff didn't catch this. BTW, besides checking the diff manually, I would also advice to set up your IDE to check for this.

Ah, thanks for the guidance! Still learning to navigate myself through the logs. I appreciate the help!
@mroeschke Thanks!
DOC: add section on groupby().rolling/expanding/resample
State: closed

 - [x] closes #14759 

This is my first PR here. Not sure about the missing entries in API reference. Need some guidance on that. The same doubt about the best place to put the xref in computation.rst and timeseries.rst


Thanks.



Labels:
name: Docs

Comments:
@jorisvandenbossche can you help me with more information about the failed test below?


@wandersoncferreira you can ignore the AppVeyor error, that is a problem on our end unrelated to this PR. Travis did pass.
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14801?src=pr) is 85.28% (diff: 100%)
> Merging [#14801](https://codecov.io/gh/pandas-dev/pandas/pull/14801?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14801   diff @@
==========================================
  Files           144        144          
  Lines         50947      50968    +21   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43445      43467    +22   
+ Misses         7502       7501     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [5d0e157...b0fa254](https://codecov.io/gh/pandas-dev/pandas/compare/5d0e15716c5466e3a12691fb6c257734396ca451...b0fa25439669ad801ccc33b7035c80fc1f2b3ba8?src=pr)
@jreback thanks for your comments. Let me know if I can make it even better.
@wandersoncferreira Thanks!
allowing datetime and timedelta datatype in pd cut bins
State: closed

xref #14714, follow-on to #14737

Labels:
name: Datetime
description: Datetime data dtype
name: Timedelta
description: Timedelta data type
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
The change is currently WIP, will add tests and other change, @jorisvandenbossche 
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14798?src=pr) is 84.64% (diff: 88.88%)
> Merging [#14798](https://codecov.io/gh/pandas-dev/pandas/pull/14798?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14798   diff @@
==========================================
  Files           144        144          
  Lines         51021      51030     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43188      43196     +8   
- Misses         7833       7834     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [f79bc7a...82bffa1](https://codecov.io/gh/pandas-dev/pandas/compare/f79bc7a9d128187f3a93a3dae84ff03f4f4a62f4...82bffa139f110edc6852b57588074963d3275384?src=pr)
@aileronajay can you update this?
@jorisvandenbossche i am caught up with some stuff right now, i should be able to make these changes next week
thanks!
BUG: multi-index HDFStore data_columns=True
State: closed

 - [x] closes #14435
 - [ ] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry



Labels:
name: IO HDF5
description: read_hdf, HDFStore
name: MultiIndex

Comments:
i think this also fixes another issue
where the data_columns were aliases (iow they are changed by HDFStore)
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14791?src=pr) is 85.27% (diff: 100%)
> Merging [#14791](https://codecov.io/gh/pandas-dev/pandas/pull/14791?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14791   diff @@
==========================================
  Files           144        144          
  Lines         50942      50942          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43440      43441     +1   
+ Misses         7502       7501     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [588e29d...5d32610](https://codecov.io/gh/pandas-dev/pandas/compare/588e29d23fa289916a8b057d093af62f35c6dcf6...5d32610587df9e4137f4086534550eaf22dace8c?src=pr)
was thinking of this: https://github.com/pandas-dev/pandas/issues/7212
but already fixed, so lgtm.
thanks!
ENH: Pandas Series provide to_excel method
State: closed

 - [x] closes #8825
 - [x] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry


Labels:
name: API Design
name: IO Excel
description: read_excel, to_excel

Comments:
this prob needs to be added to ``api.rst`` as well
Could you retrigger [this job](https://travis-ci.org/pandas-dev/pandas/jobs/180428431) ? Thanks
@scls19fr The job fails because of a lint error. pls fix.
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14780?src=pr) is 85.27% (diff: 100%)
> Merging [#14780](https://codecov.io/gh/pandas-dev/pandas/pull/14780?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14780   diff @@
==========================================
  Files           144        144          
  Lines         50946      50953     +7   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43445      43452     +7   
  Misses         7501       7501          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [c0e13d1...0ab4876](https://codecov.io/gh/pandas-dev/pandas/compare/c0e13d1bccd4a783486eba8cc769db48a7875de8...0ab4876374078d8eafecb622c24d9e7a4fbe639e?src=pr)
Thanks @sinhrks I didn't noticed because that's only for 1 job.
pls rebase and push again
@scls19fr Thanks a lot!
API: Return sparse objects always for cumsum
State: closed

Always return `SparseArray` and `SparseSeries` for `SparseArray.cumsum()` and `SparseSeries.cumsum()` respectively, regardless of `fill_value`.

Close #12855.

Labels:
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: Sparse
description: Sparse Data Type

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14771?src=pr) is 85.26% (diff: 100%)
> Merging [#14771](https://codecov.io/gh/pandas-dev/pandas/pull/14771?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14771   diff @@
==========================================
  Files           144        144          
  Lines         50981      50983     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43470      43472     +2   
  Misses         7511       7511          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [81a2f79...83314fc](https://codecov.io/gh/pandas-dev/pandas/compare/81a2f792a342a047bcc98b45cd6e99e6d82010b3...83314fc1d6f13bee0679aebef64abb7c4c63c258?src=pr)
@jreback : I addressed all of the comments, and everything is passing.  Ready to merge if there are no other concerns.
@jreback : Applied requested changes, and all is green.  Ready to merge if there are no other concerns.
lgtm.
thanks!
BUG: Error upon Series.Groupby.nunique with empty Series (#12553)
State: closed

 - [x] closes #12553
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry

Similar to #12560, but it has appeared to stall. Wanted to push it along.  

Labels:
name: Bug
name: Groupby

Comments:
I think nunique was one of a few cases I hadn't completed when trying to solve some of these groupby + empty series. Generally I had tried to remove empty as a special case. But if that's not possible, sobeit.

~~Regardless we should use `shallow_copy` rather than `Series` here~~
Thanks @jreback, moved the `len` check down the stack. Just waiting for Travis to finish the build.  
thanks @mroeschke
DOC/TST: dtype param in read_fwf
State: closed

 - [x] closes #7141
 - [ ] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry

#14295 actually implemented the behavior, this is just adding docs and tests.

Labels:
name: Docs
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
cc @gfyoung 
LGTM!
@chris-b1 Thanks!