BrandonFors/pandas-github-issues huggingface dataset:
DOC: Updating DataFrame.to_stata docstring
State: closed

Fixes #22896

Labels:
name: Docs
name: IO Stata
description: read_stata, to_stata

Comments:
Hello @andy1771! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/core/frame.py`](https://github.com/andy1771/pandas/blob/bedeca8d3800f501842452ce9471ff60393f299e/pandas/core/frame.py) !



##### Comment last updated on October 02, 2018 at 12:02 Hours UTC
Can you follow the instructions in #22896 for this? Closing it for now, please reopen after following the instructions in the issue.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22943?src=pr&el=h1) Report
> Merging [#22943](https://codecov.io/gh/pandas-dev/pandas/pull/22943?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/5ce06b5bdb8c44043c6463bf8ce3da758800a189?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22943/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22943?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22943   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50833    50833           
=======================================
  Hits        46863    46863           
  Misses       3970     3970
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <ø> (ø)` | :arrow_up: |
| #single | `42.37% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22943?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/22943/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.2% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22943?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22943?src=pr&el=footer). Last update [5ce06b5...bedeca8](https://codecov.io/gh/pandas-dev/pandas/pull/22943?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hey, @andy1771 I saw you are working on #22899 already so I'll be leaving it up to you then! I was not aware when I made the comment on the issue. ;)
BUG: Correctly weekly resample over DST
State: closed

- [x] closes #21459
- [x] closes #9119
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Timezones
description: Timezone data dtype
name: Resample
description: resample method

Comments:
Hello @mroeschke! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/resample.py`](https://github.com/mroeschke/pandas/blob/e23fcd9068c522c8862f5090a6738c20a359dbd5/pandas/core/resample.py) !

 - There are no PEP8 issues in the file [`pandas/tests/test_resample.py`](https://github.com/mroeschke/pandas/blob/e23fcd9068c522c8862f5090a6738c20a359dbd5/pandas/tests/test_resample.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22941?src=pr&el=h1) Report
> Merging [#22941](https://codecov.io/gh/pandas-dev/pandas/pull/22941?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9caf04836ad34ca17da7b86ba7120cca58ce142a?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22941/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22941?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22941      +/-   ##
==========================================
+ Coverage   92.19%   92.19%   +<.01%     
==========================================
  Files         169      169              
  Lines       50822    50824       +2     
==========================================
+ Hits        46855    46858       +3     
+ Misses       3967     3966       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.61% <100%> (ø)` | :arrow_up: |
| #single | `42.36% <16.66%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/resample.py](https://codecov.io/gh/pandas-dev/pandas/pull/22941/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzYW1wbGUucHk=) | `96.98% <100%> (+0.01%)` | :arrow_up: |
| [pandas/util/\_depr\_module.py](https://codecov.io/gh/pandas-dev/pandas/pull/22941/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX2RlcHJfbW9kdWxlLnB5) | `67.44% <0%> (+2.32%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22941?src=pr&el=footer). Last update [9caf048...bf1ddd5](https://codecov.io/gh/pandas-dev/pandas/pull/22941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks @jreback !
Provide default implementation for `data_repated`
State: closed

Split from PeriodArray.

The previous implementation was not great, since failing to override it would result in `Series([NotImplementedError, NotImplementedError...])`. We could raise instead, forcing downstream arrays to implement it, or just repeat `data`. I opted for the latter, which integer_array was already doing. 

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Hello @TomAugspurger! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/extension/conftest.py`](https://github.com/TomAugspurger/pandas/blob/6834c52ec5edbe4ea29092e70dbee912ad10cf39/pandas/tests/extension/conftest.py) !

 - There are no PEP8 issues in the file [`pandas/tests/extension/decimal/test_decimal.py`](https://github.com/TomAugspurger/pandas/blob/6834c52ec5edbe4ea29092e70dbee912ad10cf39/pandas/tests/extension/decimal/test_decimal.py) !

 - There are no PEP8 issues in the file [`pandas/tests/extension/test_categorical.py`](https://github.com/TomAugspurger/pandas/blob/6834c52ec5edbe4ea29092e70dbee912ad10cf39/pandas/tests/extension/test_categorical.py) !

 - There are no PEP8 issues in the file [`pandas/tests/extension/test_integer.py`](https://github.com/TomAugspurger/pandas/blob/6834c52ec5edbe4ea29092e70dbee912ad10cf39/pandas/tests/extension/test_integer.py) !

 - There are no PEP8 issues in the file [`pandas/tests/extension/test_interval.py`](https://github.com/TomAugspurger/pandas/blob/6834c52ec5edbe4ea29092e70dbee912ad10cf39/pandas/tests/extension/test_interval.py) !


Travis failures is the unrelated s3 failure tracked in https://github.com/pandas-dev/pandas/issues/22934
Solved issue #22471 Replaced TestData with fixtures
State: closed

- [ ] close #22471
- [ ] tests updated
- [ ] removed TestData from frame-tests, replace with fixtures


Labels:

Comments:
@akulagrawal 

Was too slow to answer in the issue, but here are a few points:
* Keep it to one module (=file) per pull request (=PR)
* I wrote in #22471:
  > Basically, it comes down to replacing all the occurrences of `self.<name>` with `translation_guide[<name>]` (**and specifying `<name>` as a parameter to the function**).
  
  You did not do this here, and so the tests cannot possibly pass.
* To test locally:
  * (make sure you're in the right environment and folder)
  * run `pytest pandas/tests/frame/test_xxx.py` from the command line and fix any failures
* Do the same with `flake8 pandas/tests/frame/test_xxx.py` to make sure your PR will not fail the lint checks

General points:
* Good idea to read and follow https://pandas.pydata.org/pandas-docs/stable/contributing.html
* In particular, create branches off your local master branch for each separate PR.
@h-vetinari. Thanks for the help! my bad I didn't specify <name> as a parameter to the function!
let's do this in smaller batches. If its a long / complicated file, then a single file per PR is ok, if its mostly trivial changes then you can group multiple files into a single PR.
Support passing function to Appender
State: closed

Possibly addresses issues discussed in #20074?  More generally, allows for less-verbose usage.

Labels:

Comments:
Hello @jbrockmendel! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/util/test_util.py`](https://github.com/jbrockmendel/pandas/blob/f8c4813dcbabbd7f797d3987af0a3d71e26560a0/pandas/tests/util/test_util.py) !

 - There are no PEP8 issues in the file [`pandas/util/_decorators.py`](https://github.com/jbrockmendel/pandas/blob/f8c4813dcbabbd7f797d3987af0a3d71e26560a0/pandas/util/_decorators.py) !
TST/CLN: Fixturize tests/frame/test_block_internals.py
State: closed

- [ ] Following h-vetinari's footstep (#22471 ), "translate" one of the test file
- [ ] tests added / passed


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Hello @makbigc! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/frame/test_block_internals.py`](https://github.com/makbigc/pandas/blob/720e8aa78f881b776b57a5b9f4b83397f74631f5/pandas/tests/frame/test_block_internals.py) !


can you rebase and ping on green.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22926?src=pr&el=h1) Report
> Merging [#22926](https://codecov.io/gh/pandas-dev/pandas/pull/22926?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/56d8e789155231b04131c6bf4674971ec3f38f95?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22926/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22926?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22926   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files         170      170           
  Lines       51073    51073           
=======================================
  Hits        47056    47056           
  Misses       4017     4017
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.56% <ø> (ø)` | :arrow_up: |
| #single | `42.28% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22926?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22926?src=pr&el=footer). Last update [56d8e78...3a3b107](https://codecov.io/gh/pandas-dev/pandas/pull/22926?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jreback Thanks for your review. Rebased.
thanks @makbigc keep em coming!
Updated README.md
State: closed

Removed extra white spaces and clarified that NAN stands for Not a Number.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
@jaydeepborkar if you want to contribute to pandas, please consider the issues marked as "good first issue", not arbitrary changes.
CLN GH22874 replace bare excepts in pandas/io/pytables.py
State: closed

This PR changes bare excepts in `pandas/io/pytables.py` to more specific exceptions. I defaulted to using specific exceptions that seemed likely/triggered test errors, but it may be the case that I'm missing some or it's better to leave it as `Exception`.

- [x] closes #22874
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Code Style
description: Code style, linting, code_checks

Comments:
Hello @pambot! Thanks for updating the PR.

 - There are no PEP8 issues in the file [`pandas/io/pytables.py`](https://github.com/pambot/pandas/blob/781d419daab1aea63f49407a9f150c4d8384e2da/pandas/io/pytables.py) !



##### Comment last updated on October 02, 2018 at 00:58 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22919?src=pr&el=h1) Report
> Merging [#22919](https://codecov.io/gh/pandas-dev/pandas/pull/22919?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/5ce06b5bdb8c44043c6463bf8ce3da758800a189?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `58.33%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22919/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22919?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22919      +/-   ##
==========================================
- Coverage   92.19%   92.18%   -0.01%     
==========================================
  Files         169      169              
  Lines       50833    50833              
==========================================
- Hits        46863    46862       -1     
- Misses       3970     3971       +1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <16.66%> (ø)` | :arrow_up: |
| #single | `42.36% <58.33%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22919?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/pytables.py](https://codecov.io/gh/pandas-dev/pandas/pull/22919/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3B5dGFibGVzLnB5) | `92.44% <58.33%> (-0.05%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22919?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22919?src=pr&el=footer). Last update [5ce06b5...781d419](https://codecov.io/gh/pandas-dev/pandas/pull/22919?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jreback May be worth another look now
thanks @pambot very nice
BUG: to_datetime preserves name of Index argument in the result
State: closed

- [x] closes #21697
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype

Comments:
Hello @mroeschke! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/core/tools/datetimes.py`](https://github.com/mroeschke/pandas/blob/a7e1410aad78f9373499fed155d16be55e5b5023/pandas/core/tools/datetimes.py) !

 - There are no PEP8 issues in the file [`pandas/tests/indexes/datetimes/test_tools.py`](https://github.com/mroeschke/pandas/blob/a7e1410aad78f9373499fed155d16be55e5b5023/pandas/tests/indexes/datetimes/test_tools.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22918?src=pr&el=h1) Report
> Merging [#22918](https://codecov.io/gh/pandas-dev/pandas/pull/22918?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/a277e4aec312abe78689ce361025cd60b25cf0c0?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22918/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22918?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22918      +/-   ##
==========================================
- Coverage   92.19%   92.18%   -0.01%     
==========================================
  Files         169      169              
  Lines       50833    50830       -3     
==========================================
- Hits        46863    46860       -3     
  Misses       3970     3970
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <100%> (-0.01%)` | :arrow_down: |
| #single | `42.37% <50%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22918?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/tools/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/22918/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvdG9vbHMvZGF0ZXRpbWVzLnB5) | `85.22% <100%> (ø)` | :arrow_up: |
| [pandas/core/indexes/datetimelike.py](https://codecov.io/gh/pandas-dev/pandas/pull/22918/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZWxpa2UucHk=) | `98.1% <0%> (-0.02%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22918?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22918?src=pr&el=footer). Last update [a277e4a...5ce3d00](https://codecov.io/gh/pandas-dev/pandas/pull/22918?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Yep. The new tests cover all the new name placements.

Thanks @jreback 

(Travis failures are unrelated; s3_resource, `boto/moto` failure)
Use fused types for _take_2d
State: closed

Misc cleanup

For some of the cython code I get unexplained test failures when using fused types.  Vaguely hoping to narrow down the set of affected functions so as to make a helpful bug report to cython.

Labels:
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22917?src=pr&el=h1) Report
> Merging [#22917](https://codecov.io/gh/pandas-dev/pandas/pull/22917?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/4976ee1c93bcc6327ca5e8714ad326c126f4151e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22917/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22917?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22917   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         169      169           
  Lines       50831    50831           
=======================================
  Hits        46864    46864           
  Misses       3967     3967
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.61% <ø> (ø)` | :arrow_up: |
| #single | `42.35% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22917?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22917?src=pr&el=footer). Last update [4976ee1...849a6ce](https://codecov.io/gh/pandas-dev/pandas/pull/22917?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

rebase. I assume you want to merge this, or was this just testing things?
> rebase. I assume you want to merge this

Done and yes

thanks!
TST: solve test failure on 32bit systems
State: closed

- [x] closes #22813
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

#22296 introduced a test, where ``dtype=np.int64`` was used, but ``np.intp`` is needed for the test to pass on 32bit systems also. This fixes that.

After this PR, the pandas test suite passes with no failures on my 32bit python installation on Windows 10.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: 32bit
description: 32-bit systems

Comments:
Hello @topper-123! Thanks for submitting the PR.

 - There are no PEP8 issues in the file [`pandas/tests/indexes/test_base.py`](https://github.com/topper-123/pandas/blob/de744603d359b00022c31b93e8d115744f347693/pandas/tests/indexes/test_base.py) !


# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22908?src=pr&el=h1) Report
> Merging [#22908](https://codecov.io/gh/pandas-dev/pandas/pull/22908?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f4fae353eaaa719db335ec2b21259932de30f46d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22908/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22908?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22908   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50830    50830           
=======================================
  Hits        46860    46860           
  Misses       3970     3970
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.6% <ø> (ø)` | :arrow_up: |
| #single | `42.37% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22908?src=pr&el=footer). Last update [f4fae35...de74460](https://codecov.io/gh/pandas-dev/pandas/pull/22908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

looks fine, but let's fix #22924 first
thanks!