validate PR09 errors
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
> Actually, looks like there's still a few of these validations which need fixing up:
> 
> ```python
> Error: /home/runner/work/pandas/pandas/pandas/core/frame.py:7703:PR09:pandas.DataFrame.groupby:Parameter "dropna" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/core/generic.py:10955:PR09:pandas.DataFrame.rolling:Parameter "closed" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/formats/style.py:82:PR09:pandas.io.formats.style.Styler:Parameter "escape" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/formats/style_render.py:786:PR09:pandas.io.formats.style.Styler.format:Parameter "decimal" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/formats/style_render.py:786:PR09:pandas.io.formats.style.Styler.format:Parameter "thousands" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/formats/style_render.py:983:PR09:pandas.io.formats.style.Styler.format_index:Parameter "decimal" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/formats/style_render.py:983:PR09:pandas.io.formats.style.Styler.format_index:Parameter "thousands" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/formats/style.py:3136:PR09:pandas.io.formats.style.Styler.highlight_quantile:Parameter "color" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/formats/style.py:2760:PR09:pandas.io.formats.style.Styler.bar:Parameter "props" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/formats/style.py:466:PR09:pandas.io.formats.style.Styler.to_latex:Parameter "position" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/parquet.py:437:PR09:pandas.read_parquet:Parameter "path" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/io/sql.py:330:PR09:pandas.read_sql_query:Parameter "dtype" description should finish with "."
> Error: None:None:PR09:pandas.Timestamp:Parameter "fold" description should finish with "."
> Error: None:None:PR09:pandas.Timestamp.max:Parameter "fold" description should finish with "."
> Error: None:None:PR09:pandas.Timestamp.min:Parameter "fold" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/core/series.py:1787:PR09:pandas.Series.groupby:Parameter "dropna" description should finish with "."
> Error: /home/runner/work/pandas/pandas/pandas/core/generic.py:10955:PR09:pandas.Series.rolling:Parameter "closed" description should finish with "."
> ```
> 
> Do you want to add those full stops, so that the validation script passes?

Yes I will do that.
I have added full stops. But Sorry not able to find 5 of them.

**Don't know where to look for the following.** 
Error: None:None:PR09:pandas.Timestamp:Parameter "fold" description should finish with "."
Error: None:None:PR09:pandas.Timestamp.max:Parameter "fold" description should finish with "."
Error: None:None:PR09:pandas.Timestamp.min:Parameter "fold" description should finish with "."

**could not find a description for parameter 'closed' in the particular file.**
Error: /home/runner/work/pandas/pandas/pandas/core/generic.py:10955:PR09:pandas.Series.rolling:Parameter "closed" description should finish with "."
Error: /home/runner/work/pandas/pandas/pandas/core/generic.py:10955:PR09:pandas.DataFrame.rolling:Parameter "closed" description should finish with "."
First three are in timestamps.pyx
The others are probably in rolling.py in for class Window
Yeah, groupby is here

https://github.com/pandas-dev/pandas/blob/945c9ed766a61c7d2c0a7cbb251b6edebf9cb7d5/pandas/core/shared_docs.py#L126-L129

Window:

https://github.com/pandas-dev/pandas/blob/59d031ff26bd45c276df63fee5fd4f49a23652be/pandas/core/window/rolling.py#L895-L909

Admittedly these aren't the easiest to find
One comment made, all others are fine with me.
pls also merge master
> pls also merge master

@soumyas567 in case it's not clear:
```
git fetch upstream
git merge upstream/master
git push origin HEAD
```
I am not sure if the merging was correct. Hopefully, I did not mess it up. @MarcoGorelli 
@soumyas567 Thanks for the PR. Can you fix up the merge conflict? We'll get it merged afterwards.
> I am not sure if the merging was correct. Hopefully, I did not mess it up. @MarcoGorelli

Yup, the merging was correct!

There have since been new changes upstream, so you'll need to pull these too:
```
git fetch upstream
git merge upstream/master
```
and then resolve the merge conflicts (if it's not something you're familiar with, check out https://youtu.be/xNVM5UxlFSA)
> This isn't quite right - if you click "files changed", you see
> 
> ```
> <<<<<<< HEAD
>     MSG='Validate docstrings (GL02, GL03, GL04, GL05, GL06, GL07, GL09, GL10, SS01, SS02, SS04, SS05, PR03, PR04, PR05, PR09, PR10, EX04, RT01, RT04, RT05, SA02, SA03)' ; echo $MSG
>     $BASE_DIR/scripts/validate_docstrings.py --format=actions --errors=GL02,GL03,GL04,GL05,GL06,GL07,GL09,GL10,SS02,SS04,SS05,PR03,PR04,PR05,PR09,PR10,EX04,RT01,RT04,RT05,SA02,SA03
> =======
>     MSG='Validate docstrings (GL02, GL03, GL04, GL05, GL06, GL07, GL09, GL10, SS01, SS02, SS03, SS04, SS05, PR03, PR04, PR05, PR10, EX04, RT01, RT04, RT05, SA02, SA03)' ; echo $MSG
>     $BASE_DIR/scripts/validate_docstrings.py --format=actions --errors=GL02,GL03,GL04,GL05,GL06,GL07,GL09,GL10,SS02,SS03,SS04,SS05,PR03,PR04,PR05,PR10,EX04,RT01,RT04,RT05,SA02,SA03
> >>>>>>> upstream/master
>     RET=$(($RET + $?)) ; echo $MSG "DONE"
> ```
> 
> I'd suggest removing the top part (between `<<<<<<< HEAD` and `=======`), adding `PR09` to the lines below them, and then removing the `>>>>>>> upstream/master` line

Shall I do this from GitHub itself? I think I did "'keep both changes"  while resolving conflicts .  My local repository seems up-to-date now. 
Up to you, if you want to do it from the GitHub UI or in your editor

If you do it on GitHub, make sure to then do `git pull` so your local branch is up-to-date
> Up to you, if you want to do it from the GitHub UI or in your editor
> 
> If you do it on GitHub, make sure to then do `git pull` so your local branch is up-to-date

Is it OK now? 
lgtm
Thanks @soumyas567 
Thank you all. :) Thank you for the help  @MarcoGorelli