CLN: isort from attrs_caching.py to eval.py
State: closed

- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

More updates from issue #23334:
- asv_bench/benchmarks/attrs_caching.py
- asv_bench/benchmarks/binary_ops.py
- asv_bench/benchmarks/categorical.py
- asv_bench/benchmarks/ctors.py
- asv_bench/benchmarks/dtypes.py
- asv_bench/benchmarks/eval.py


Labels:
name: Code Style
description: Code style, linting, code_checks
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=h1) Report
> Merging [#25060](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/da5f5eb6c11140a2bb9f84049d30ba7d89bdbfd0?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25060/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #25060   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52403    52403           
=======================================
  Hits        48405    48405           
  Misses       3998     3998
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.79% <ø> (ø)` | :arrow_up: |
| #single | `42.87% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=footer). Last update [da5f5eb...cc62d21](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=h1) Report
> Merging [#25060](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/976a2db444c20ee71895bda394193aa24e1e5734?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25060/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #25060   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         173      173           
  Lines       52968    52968           
=======================================
  Hits        48339    48339           
  Misses       4629     4629
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.83% <ø> (ø)` | :arrow_up: |
| #single | `41.71% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=footer). Last update [976a2db...689e8bd](https://codecov.io/gh/pandas-dev/pandas/pull/25060?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

The error I'm getting is ```##[error]Benchmarks run with errors``` in the Checks_and_doc Job > Running benchmarks test. I solved one failing test from the last commit by returning the asv_bench/benchmarks/dtypes.py to what it was before I ran isort. I imagine something similar went wrong this time, but looking through the diffs and the output, I'm not sure where to start looking. Any ideas?
IIRC the benchmarks are only checked when those files are touched. It's
possible that a recent commit broke one of the benchmarks.

I'd recommend finding the previous commit to touch the benchmarks files,
and seeing if any of the commits between that and master broke them.

On Thu, Jan 31, 2019 at 4:01 PM Andrew Gaspari <notifications@github.com>
wrote:

> The error I'm getting is ##[error]Benchmarks run with errors in the
> Checks_and_doc Job > Running benchmarks test. I solved one failing test
> from the last commit by returning the asv_bench/benchmarks/dtypes.py to
> what it was before I ran isort. I imagine something similar went wrong this
> time, but looking through the diffs and the output, I'm not sure where to
> start looking. Any ideas?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/25060#issuecomment-459523036>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIomjsZ6O0lDjJjSLhZv4aJAT4xl3ks5vI2e6gaJpZM4adF5->
> .
>

@gasparia405 can you merge master? IIRC had a recent PR to fix issue with benchmark tests
@WillAyd Thanks for the heads up. I've merged with master and tests passing!
Hmm the benchmark failures might be related to work done in #25517
@gasparia405 can you merge master?
Closing as stale ping if you'd like to pick this back up