BrandonFors/pandas-github-issues huggingface dataset:
BLD: Build wheels for 3.9 and musllinux-aarch64 for pandas 2.3
State: closed

@lithomas1 would I need to re-tag the 2.3.x branch if/when we merge this?

xref https://github.com/pandas-dev/pandas/issues/61563 https://github.com/pandas-dev/pandas/issues/61574

Labels:
name: Build
description: Library building on various platforms

Comments:
I guess the issue is the tag would have to be named something else (at this point, I don't think it's a good idea to delete and re-tag), and that point it's probably better to make a new version.

It might be easier to download wheel artifacts from this PR and upload them by hand using twine, though.
Thanks again for the guidance @lithomas1. Closing this out 
> Closing this out

Shouldn't this be at least partially merged into `2.3.x` in case there is a bug fix release?
> Shouldn't this be at least partially merged into 2.3.x in case there is a bug fix release?

Yup definitely. I've tracked this task in https://github.com/pandas-dev/pandas/issues/61590 as the core team discusses the possibility of a 2.3.1 release
Wheels generated here look OK so going to merge
@mroeschke Thanks!
BUILD: Add wheels for musllinux_aarch64
State: closed

It seems the `musllinux_aarch64` wheels got accidentally removed in the transition from circleci to GHA.
Would be great if this could be backported to `2.3.x` as well.

- [x] closes https://github.com/pandas-dev/pandas/issues/55645#issuecomment-2943818815
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Build
description: Library building on various platforms

Comments:
Thanks for the PR. I'll incorporate this into https://github.com/pandas-dev/pandas/pull/61569 so I can upload 3.9 musllinux-aarch wheels as well
Going to close this PR (since the wheel building might be different than in the 2.3.x branch).

I will update https://github.com/pandas-dev/pandas/issues/61574 when the wheels are available on PyPI
> I'll inappropriate this into #61569 so I can upload 3.9 musllinux-aarch wheels as well

Works for me!

> Going to close this PR (since the wheel building might be different than in the 2.3.x branch).

Not sure about this though. Your PR #61569 only targets the `2.3.x` branch. This needs to be fixed in `main` as well. Otherwise the first `3.0` release will have the same issue. I guess you could do both #61569 and this PR, or fix it in main separately.
Ah good point. Sorry, I overlooked that. Yes we'll still need this in main
Thanks @cdce8p
DOC: Set date for v2.3.0.rst whatsnew
State: closed


Labels:
name: Docs

Comments:
/preview
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/61560/
/preview
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/61560/
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 2.3.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 1f6f42ac556dcc7c63283a0c4d6a055576d0317f
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #61560: DOC: Set date for v2.3.0.rst whatsnew'
```

4. Push to a named branch:

```
git push YOURFORK 2.3.x:auto-backport-of-pr-61560-on-2.3.x
```

5. Create a PR against branch 2.3.x, I would have named this PR:

> "Backport PR #61560 on branch 2.3.x (DOC: Set date for v2.3.0.rst whatsnew)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
DOC: Fix typo in to_html and to_string docs
State: closed

**UPDATE:** This started as an upgrade of Python in environment.yml, now it's just about fixing an issue with a period is duplicated in both the template and the variables.


I guess the only reason we require Python 3.10 for the development environments and run the docs is because it wasn't updated for a long time. Not sure if it'd be better to unpin, which I assume would get us the latest version of Python. Happy to do that here too.

Labels:
name: Docs

Comments:
+1 to unpin Python here
Just FYI, I think there are some configurations like pre-commit/mypy/etc. that have a "Python version" configuration that may be useful to (un)sync since they are dependent on the Python version installed by `environment.yml`
I'll leave this PR just for the typo in the docs (which doesn't seem was the cause for the doc build to fail). This is a bit more time consuming than I initially thought, and I prefer to focus on other things now. I created #61585 for this, probably someone from the community will take care of it, as it's a great first time issue.
/preview
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/61555/
DOC: Move PyCapsule whatsnew note from v3.0.0 to v2.3.0
State: closed

follow-up from https://github.com/pandas-dev/pandas/pull/61488#pullrequestreview-2871730860

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @MarcoGorelli
DOC: Add note on inference behavior of apply with result_type='expand'
State: closed

Closes #61057

- This PR adds a docstring note about the inference behavior of apply with result_type='expand' when function returns NaN-like values, as discussed in issue #61057.
- Added docstring to distinguish behavior for 'apply' method.

Labels:
name: Docs
name: Apply
description: Apply, Aggregate, Transform, Map
name: Stale

Comments:
pre-commit.ci autofix
pre-commit.ci autofix
Personally I think we should deprecate that parameter. Since I guess you're using it, do you mind sharing an example of how you are using it?

You'll have to remove the blank lines for the PR. Also, did you check if what you are detailing is only affected by expand, or also by reduce?
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Parallelize test_sql.py - Issue #60378
State: open

- [ ] Closes #60378
- [ ] Builds off of https://github.com/pandas-dev/pandas/pull/60595
- [ ] Extends @UmbertoFasci's per-table UUID work
- [ ] Solves https://github.com/pandas-dev/pandas/pull/60595 concurrency issue

~~- [x] Parallelizes test_sql.py via per-worker_DBs (approach superseded due to complexity)~~


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO SQL
description: to_sql, read_sql, read_sql_query
name: Stale

Comments:
Thanks for the feedback @mroeschke!

Having now run this through CI, I agree! I come from a production-oriented environment, so I initially underestimated the architecture/OS complexity. 

I looked into per-table UUIDs as per @UmbertoFasci's PR, and was concerned it might impact future test writing, and it still had some parallelization issues. I thought that using a different approach could solve these problems, but I see the value of this approach. 

I will revise this to use UUIDs on a per-test basis (building off of @UmbertoFasci's work).
I'm not ready for review yet. 

I added the connect_and_uuid fixture, this was the most parsimonious way I found to manage the sqlalchemy connection objects, as well as sharing the same UUIDs between tests (which create views and tables) and fixtures (which tear down views and tables). Working to extend this fixture to the rest of the tests.
Thanks for your efforts here so far, but personally the scale of these changes are too large to review. I would suggest breaking this into smaller PRs such as

1. A PR to ensure each test that creates a table also remove the table.
2. Update a fixture that impacts ~5 tests to return the unique table name in the fixture so it can used directly in the test if needed. This may involve changing functions that load data into pytest fixtures
3. Repeat 2 for ~10 tests at a time


Hello @mroeschke 

That sounds like a plan to me! I'll continue working here to make sure that these changes (and by extension all subsequent PR) pass CI, and then I'll write one PR with just the new fixtures.

After the PR with the new fixtures gets approved, I will make a set of PRs. These will all be boilerplate changes, almost all tests are parallelized in the exact same way so this should be easy to review. 

There are a couple tests which do things like "close the connection and then reopen it", so since these tests are different I'll put them in their own PR.

Feel free to tell me if there are any issues with this plan.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
DOC: Remove and Update out of date Docker Image issue with  #61511
State: closed

- [ ] Addresses & closes [DOC: Docker image provided on "Debugging C extensions" is out of date #61511](https://github.com/pandas-dev/pandas/issues/61511)  
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).



Labels:
name: Docs
name: Stale

Comments:
@WillAyd do you mind having a look?

I think we should also remove the container if it's not maintained, not only the docs.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
changed the pydata-sphinx-theme dependency to the git version
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dependencies
description: Required and optional dependencies

Comments:
This seems a bad idea. And if you think we should be doing this, please open an issue with the motivation, or at least write a description in the PR, so this can be discussed. But we don't want changes to a sphinx theme breaking our CI, so I don't think we'll get this merged.
This was related to issue #51536. This is my first time, I must off misunderstood what he was looking for.
Thanks for the information. The first line in the template is to provide the issue you are addressing, so we have more context.

I opened that issue, and there is indeed some misunderstanding. I think we are probably using a version that supports the footer now, you'll have to check. But the issue is about simplifying the footer. Maybe we need to upgrade the sphinx theme, but that would be to a specific version.

I can reopen this PR if needed, but probably better to start in a new branch. Juat let me know if you reuse this branch so I can reopen here.
CLN: Format comments in frame.py to comply with PEP8 line width
State: closed

Hello! While becoming acquainted with the code, I noticed that the frame.py file had a lot of comments with a length over PEP8's 79 character limit.

I reformatted all comments to the 79 character limit, unless they involve command-line related code examples.

Let me know if there is anything I can do to help.

Thank you!

Labels:

Comments:
Thanks for working on the proposed changes @TheCheerfulCoder. We validate in our CI that all rules from PEP-8 we care about are enforced. You can check the code checks jobs to get an idea all the things we validate.

We're happy with these longer lines, and merging this PR means we lose the value that `git blame` provides for a significant part of the code. So I'll be closing this PR, as I don't think we want to merge this.
ENH: Adding DataFrame plotting benchmarks for large datasets
State: closed

- [ ] related to #61532  - Adding in performance benchmarks for DataFrame plotting with large datasets.
- [ ] Description: Added 'DataFramePlottingLarge' benchmark class to track performance issues related to bottlenecks in #61398 and #61532. Tests multiple DataFrame sizes with/w/o DatetimeIndex & provides a baseline single-column comparison.
- [ ] Intended to cover:
          - DataFrame sizes: (1000,10) to (10000,10)
          - DatetimeIndex vs. regular index comparison
          - Multi-column vs. single-column plotting.


Labels:
name: Benchmark
description: Performance (ASV) benchmarks

Comments:
@rhshadrach do you have an opinion about this?
@shadnikn - what is the runtime of these benchmarks on your machine?
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Fix WeekOfMonth offset constructor offsets.pyx
State: closed

Related to issue #52431, went and scanned the checklist commented previously by a user on Aug 4th, 2024. Noticed WeekOfMonth has incorrect offset constructors, and updated according to an earlier comment by @Dr-Irv  


Labels:

Comments:
This is not the right way to do this.  Will close this, because we need to figure out what is the right way.
DOC: Fix docs for BusinessDay constructor #52431
State: closed

fix constructor for offset BusinessDay

- [ ] addresses #52431 
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).


Labels:
name: Docs
name: Frequency
description: DateOffsets

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
CI: Debug slow environment solve times
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Not sure if you've seen the discussion in #61531
Ah yes thanks. Yeah I suspect this is a mamba solver issue. Closing this PR out
BUG: Fix Index.equals between object and string
State: closed

- [X] closes #61099 
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file if fixing a bug or adding a new feature.

## Description of the code change on `Index.equals`

On the main branch, `Index.equals` casts `self` to `object` only when `self.dtype.na_value` is `np.nan`. The comparison actually succeeds when `self.dtype.na_value` is `np.nan` as below.
```python
>>> import pandas as pd
>>> import numpy as np

>>> s1 = pd.Series([1, 2, 3], index=['a', 'b', 'c'])
>>> s2 = pd.Series([4, 5, 6], index=['a', 'b', 'c'])
>>> s2.index = s2.index.astype(pd.StringDtype(storage="pyarrow", na_value=np.nan))

>>> print(s1 < s2)
a    True
b    True
c    True
dtype: bool
```
However, since doc stated that `dtype` is not compared, `self` should be casted regardless of `self.dtype.na_value` so that `self` could be compared with other dtypes as desired.


## Description of the code change on `test_mixed_col_index_dtype`

`using_infer_string` has been removed since I think that `result` should be `string` regardless of `using_infer_string`. This is becaus of the code change made on `Index.equals` - since `Index.equals` consider `df1.columns` is equal to `df2.colums`, `Index.intersection` returns `self`(which is `string`). You could see the result becomes `object`(which is the dtype of `df2`) in case of `result = df2 + df1`. On the main branch, on the other hand, `Index.intersection` returns `object` because `Index.equals` returns `False`, and then both `self` and `other` are cast to `object` by `_find_common_type_compat`. (see `L3287` at pandas/core/indexes/base.py)

https://github.com/pandas-dev/pandas/blob/25e64629ec317fba2fc1c2834b20362fa6c1fd89/pandas/core/indexes/base.py#L3286-L3290


* I created this pull request since @MayurKishorKumar doesn't seem to work on this issue anymore, but please let me know if there is going to be further actions on the previous PR and I am supposed to close this one.

Labels:
name: Bug
name: Strings
description: String extension data type and string data
name: Index
description: Related to the Index class or subclasses

Comments:
Thanks @sanggon6107!
ENH pandas-dev#60693: shift operations for Series and DataFrames
State: closed

This commit introduces the rshift and lshift method for both Series and DataFrames in pandas. It also adds the corresponding in-place methods.
These methdos don't work between a Series and a Dataframe, or if the two Series or DataFrames differ in size.

- [x] closes #60693
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Enhancement
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
@mroeschke Any chance this would be worth adding to pandas?
Going to close this PR until a decision has been made on the original issue
Add version constraints to reduce micromamba CI environment resolution time
State: closed

This PR updates the `environment.yml` file to add version constraints to several frequently resolved dependencies. These changes help reduce environment resolution time in CI workflows using micromamba, which was previously leading to timeouts (see #61531).

Updated packages:
- ipywidgets>=8.1.2
- nbformat>=5.9.2
- notebook>=7.0.6,<7.2.0
- dask-core>=2024.4.2
- seaborn-base>=0.13.2

Fixes: #61531

Labels:
name: CI
description: Continuous Integration
name: Dependencies
description: Required and optional dependencies

Comments:
pre-commit.ci autofix
Closing, as discussed in https://github.com/pandas-dev/pandas/issues/61531#issuecomment-2929429803
BUG: Fix Series.str.zfill for ArrowDtype string arrays #61485
State: open

Implemented `_str_zfill` for `ArrowExtensionArray` to support `Series.str.zfill` on Arrow-backed string arrays (`ArrowDtype(pa.string())`). This fixes an AttributeError due to the method relying on `_str_map`, which wasn't implemented. Used `_apply_elementwise` to match the approach of other string methods. Added tests under `test_string_array.py` and confirmed they pass. Also confirmed no other relevant test files are broken and the change aligns with how other string accessors are handled.

- [x] closes #61485
- [x] Tests added and passed
- [x] All code checks passed with pre-commit
- [x] Added a changelog entry in v3.0.0.rst

Labels:
name: Strings
description: String extension data type and string data
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.