BrandonFors/pandas-github-issues huggingface dataset:
ERR: raise on python in object hashing, only supporting strings, nulls
State: closed

xref #14729 

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
cc @mikegraham 
cc @mrocklin

Awesome, I think this is a really worth while restriction. Thanks!
Initially you were worried about things like tuples for multiindices -- did you decide that wasn't really a concern?
problem with tuples is that they can contain arbitrary things - so punting for now
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14767?src=pr) is 85.27% (diff: 100%)
> Merging [#14767](https://codecov.io/gh/pandas-dev/pandas/pull/14767?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

```diff
@@             master     #14767   diff @@
==========================================
  Files           144        144          
  Lines         50915      50915          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43418      43418          
  Misses         7497       7497          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [423c16a...8fb4ed0](https://codecov.io/gh/pandas-dev/pandas/compare/423c16a2ee88d82202c1e6b24a31d47ec6a04b82...8fb4ed0adf8f892bf7499ed7d218107864d274ea?src=pr)
BF: (re)raise the exception always unless returning
State: closed

coding logic flaw is obvious (leaves unser used later undefined), so no dedicated test was found

otherwise leads atm to masking of this error while testing on i386 and then failling with

UnboundLocalError: local variable unser referenced before assignment

More detail: https://buildd.debian.org/status/fetch.php?pkg=pandas&arch=i386&ver=0.19.1-1&stamp=1479504883

Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
thanks!
TST: Correct results with np.size and crosstab (#4003)
State: closed

 - [x] closes #4003
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``



Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14755?src=pr) is 85.26% (diff: 100%)


> No coverage report found for **master** at e991141.

> Powered by [Codecov](https://codecov.io?src=pr). Last update [e991141...e703a8d](https://codecov.io/gh/pandas-dev/pandas/compare/e991141f3c13117035fb2a08f4e64b4c18c9d5a9...e703a8d565ee550e5c8bf6e821eeb48cae17d890?src=pr)
can you rebase
Rebased and all green @jreback 
thanks!
TST: Same return values in drop_duplicates for Series and DataFrames(#…
State: closed

 - [x] closes #14192
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``

…14192)

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14754?src=pr) is 85.24% (diff: 100%)


> No coverage report found for **master** at 725453d.

> Powered by [Codecov](https://codecov.io?src=pr). Last update [725453d...8b84d12](https://codecov.io/gh/pandas-dev/pandas/compare/725453deb2efae1b84d87131e785a42a22753659...8b84d128ebeb092e7027753f49d9c8622c3ea0d6?src=pr)
Added the `keep` kwarg and added `int` and `datetime64` columns @sinhrks 
@mroeschke Thanks!
ENH: Add the ability to have a separate title for each subplot when plotting
State: closed

 - [] tests added / passed
 - [] passes ``git diff upstream/master | flake8 --diff``
 - [] whatsnew entry


Labels:
name: Visualization
description: plotting
name: API Design

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14753?src=pr) is 85.26% (diff: 0.00%)
> Merging [#14753](https://codecov.io/gh/pandas-dev/pandas/pull/14753?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **0.01%**

```diff
@@             master     #14753   diff @@
==========================================
  Files           144        144          
  Lines         50968      50977     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43466      43467     +1   
- Misses         7502       7510     +8   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [3ac41ab...59ab880](https://codecov.io/gh/pandas-dev/pandas/compare/3ac41ab2d7ae446fa04f47ec911003cd722dbd65...59ab880d3de2e52eff5711af4f13a1151d40eb9c?src=pr)
Thx for the PR. can u add tests and release note? Also, pls link the original issue if we have.
I did my best at adding a test and release note. I didn't see an original issue that this addresses. It's just something I have on my local that I wanted to contribute.
Is there anything else I need to do for this change to get pulled in?
@TomAugspurger pls have a look when you have a time.
Great thanks. +1 for merge when travis passes. Just ping us if you notice that it's green before we do
All green :)
Huh. I assume there is something funny going on since I didn't change any actual code. Is there a way to restart the checks?
Ah! I figured it out. I had a linting error (I'll start doing lint before committing oops!)
All green now! Anything else to change? If not, thanks for all the help everyone! I had fun. This was my first pull request but it certainly won't be the last :).
@bmagnusson Thanks! Looking forward to more PRs :-)
BUG: Patch read_csv NA values behaviour
State: closed

Patches the following behaviour when `na_values` is passed in as a dictionary:

1. Prevent aliasing in case `na_values` was defined in a broader scope.
2. Respect column indices as keys when doing NA conversions.

Closes #14203.

Labels:
name: Bug
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14751?src=pr) is 85.27% (diff: 100%)


> No coverage report found for **master** at 033d345.

> Powered by [Codecov](https://codecov.io?src=pr). Last update [033d345...0bd7531](https://codecov.io/gh/pandas-dev/pandas/compare/033d34596f5327472007f0f15029b86050ee2592...0bd7531651a8f3aa712152848e79874cb64bee04?src=pr)
Appveyor keeps failing because the build is taking too long, but I have no clue why that is the case (e.g. this <a href="https://ci.appveyor.com/project/jreback/pandas-465/build/1.0.2161/job/e803guq7rogwv5rw">build</a> seemed to do just fine).  I took a look at Travis to see if the builds much longer, but that is not the case.
@jreback , @sinhrks : Everything is green, so ready to merge if there are no concerns.
@jreback : Everything is passing.  Ready to merge if there are no other concerns.
thanks!
BUG: Improve error message for skipfooter malformed rows in Python engine
State: closed

Python's native CSV library does not respect the `skipfooter` parameter, so if one of those skipped
rows is malformed, it will still raise an error.  Append some useful information to the error message regarding that if that situation is potentially applicable.

Closes #13879.

Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14749?src=pr) is 85.27% (diff: 100%)
> Merging [#14749](https://codecov.io/gh/pandas-dev/pandas/pull/14749?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14749   diff @@
==========================================
  Files           144        144          
  Lines         50911      50915     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43413      43419     +6   
+ Misses         7498       7496     -2   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [2f43ac4...8aae4fe](https://codecov.io/gh/pandas-dev/pandas/compare/2f43ac4c4cdea407b42530bcfef490a18892302a...8aae4fe84bba60894d73f433034e81dd68803db4?src=pr)
@jreback , @jorisvandenbossche : Updated the error message, and everything is happy.  Ready to merge if there are no other concerns.
@gfyoung Thanks!
Revert "TST/TEMP: fix pyqt to 4.x for plotting tests"
State: closed

Reverts pydata/pandas#14240

For when https://github.com/ContinuumIO/anaconda-issues/issues/1068 is solved



Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
I think this is partly solved on the continuum side. They have included the fix in the rc settings, but didn't bump the build number (https://github.com/ContinuumIO/anaconda-issues/issues/1068#issuecomment-255814564). So it depends on if the cached conda package is still on travis.
Good question :-) (it was actually also an error that this was a branch on pandas itself)
SAS chunksize / iteration issues
State: closed

closes #14734
closes #13654
 - [X] tests added / passed
 - [X] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry



Labels:
name: Bug
name: IO SAS
description: SAS: read_sas

Comments:
pls add to the whatsnew. ping when ready / green.
Question: this is not a problem in the xport reader? If so, is there a test that confirms this?
It works there but I added a few tests.
@kshedden Thanks. You can move the whatsnew notice to the 0.19.2 file

## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14743?src=pr) is 85.22% (diff: 0.00%)
> Merging [#14743](https://codecov.io/gh/pandas-dev/pandas/pull/14743?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14743   diff @@
==========================================
  Files           143        143          
  Lines         50807      50857    +50   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43297      43344    +47   
- Misses         7510       7513     +3   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [d8e427b...28d4038](https://codecov.io/gh/pandas-dev/pandas/compare/d8e427bda07fc350dfa327df43b790697e733747...28d4038c3330332da2d3631214d26aa93c98d636?src=pr)
@kshedden Thanks for the quick fix!
DOC: Update outdated caveats for Anaconda and HTML parsing (#9032)
State: closed

 - [x] closes #9032




Labels:
name: Build
description: Library building on various platforms
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14739?src=pr) is 85.21% (diff: 100%)


> No coverage report found for **master** at d8e427b.

> Powered by [Codecov](https://codecov.io?src=pr). Last update [d8e427b...3e1cdb7](https://codecov.io/gh/pandas-dev/pandas/compare/d8e427bda07fc350dfa327df43b790697e733747...3e1cdb76adce04f454506111ed5dec74e4cccd34?src=pr)
True. I personally haven't had installation issues with those packages with anaconda. Should be okay to delete this section. 
Thanks for the catch @jorisvandenbossche. Accidentally deleted those. Looks like Anaconda isn't referenced anywhere else on that page.  
@mroeschke Thanks!
DOC: Correct uniqueness of index for Series (#7808)
State: closed

 - [X] closes #7808




Labels:
name: Duplicate Report
description: Duplicate issue or pull request

Comments:
@mroeschke Thanks for the PR. However, there was already another PR for the same change, see https://github.com/pandas-dev/pandas/pull/14344. So I merged that one.  
That PR was apparently not correctly linked to the issue #7808 (added that now), so it was not clear that there was already a PR. Sorry for that!
But I included the "Non-unique index values are allowed." that you included in this PR, in the other one.
No worries, thanks for the heads-up!
CLN: move assignment from header into cython
State: closed

an insignificant refactoring that allows PyPy2.7  to build and import Pandas. The original code uses functions that are macros in CPython but actual c-functions in PyPy and one cannot assign to a function result

Note that while PyPy imports Pandas, it very quickly segfaults, Apparently PyPy does not yet play well with enough of Cython, I suspect strange interactions with tp_new and tp_deallocate

Labels:
name: Build
description: Library building on various platforms
name: Clean

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14731?src=pr) is 85.21% (diff: 100%)
> Merging [#14731](https://codecov.io/gh/pandas-dev/pandas/pull/14731?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14731   diff @@
==========================================
  Files           143        143          
  Lines         50804      50804          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43292      43293     +1   
+ Misses         7512       7511     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [75b606a...ed1db95](https://codecov.io/gh/pandas-dev/pandas/compare/75b606abad51762b3faace1bbfa0a8d2241dc297...ed1db957ff9b50e44eeff05dd0813fd4a3afa2cc?src=pr)
@jreback thanks, fixed
thanks @mattip
MAINT: Ignore .pxi files
State: closed

All `.pxi` files have the warning to not edit directly, so why not have Git ignore any changes made there?

In addition, this PR deletes all of the `.pxi` files from the codebase because they are automatically generated by the `.pxi.in` files


Labels:
name: Build
description: Library building on various platforms

Comments:
if you did this and don't check them in.

the a new clone & build will generate them, so that's ok.

when you change a ``.in`` they will get regenerated, so that seems ok.

when you switch branches what happens? (e.g. modify something in a .in in one branch), switch to another
make should just regen the files you need. does that work?
@jreback : Yes, it does.
ok so in this PR, remove all of the .pxi as well.
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14723?src=pr) is 85.21% (diff: 100%)
> Merging [#14723](https://codecov.io/gh/pandas-dev/pandas/pull/14723?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14723   diff @@
==========================================
  Files           143        143          
  Lines         50804      50804          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43292      43293     +1   
+ Misses         7512       7511     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [75b606a...fe0c410](https://codecov.io/gh/pandas-dev/pandas/compare/75b606abad51762b3faace1bbfa0a8d2241dc297...fe0c4101d3982152a09c30aabbef00c410fb605a?src=pr)
Travis OSX keeps breaking because it cannot seem to hit the `github.com` endpoint when cloning the repository, which is unrelated to this PR.  Silencing testing for now until that resolves itself.
cc @sinhrks @chris-b1 
@jreback , @jorisvandenbossche : Travis is behaving again, so this should be ready to merge.
can  you confirm that that travis caching still works? 
I've added these files only for travis caching, so it's good to remove if caching can still work.
@sinhrks , @jreback : I don't see any issues with caching on Travis, so I think this should be good to go.
thanks!
let's keep an eye on the caching though
DOC: fix typo in merge_asof docstring examples
State: closed

Just a trivial fix to docs - incorrect function name in doctests.


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14718?src=pr) is 85.21% (diff: 100%)
> Merging [#14718](https://codecov.io/gh/pandas-dev/pandas/pull/14718?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

```diff
@@             master     #14718   diff @@
==========================================
  Files           143        143          
  Lines         50796      50796          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43285      43285          
  Misses         7511       7511          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [880de30...675c4b5](https://codecov.io/gh/pandas-dev/pandas/compare/880de3054c7ce3a6c48e295837207787dc73350f...675c4b537098188c6260d2108e280c12c0c9978a?src=pr)
@dwillmer Thanks! (leftover from a previous iteration of the PR before the name change :-))
BUG: Respect the dtype parameter for empty CSV
State: closed

Title is self-explanatory.  Closes #14712.

Should be merged in before #14295 because the bug could also exist for the Python parser.

Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14717?src=pr) is 85.21% (diff: 100%)
> Merging [#14717](https://codecov.io/gh/pandas-dev/pandas/pull/14717?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14717   diff @@
==========================================
  Files           143        143          
  Lines         50796      50800     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43285      43289     +4   
  Misses         7511       7511          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [880de30...cee4d6a](https://codecov.io/gh/pandas-dev/pandas/compare/880de3054c7ce3a6c48e295837207787dc73350f...cee4d6a9fa27a084b3618e78ea8892d724a799b2?src=pr)
lgtm. I restarted appveyor. If that doesn't pass, then pls have a look @gfyoung 
ping when passed / fixed.
I would be fine with this for 0.19.2 a well. @jorisvandenbossche up to you.
@jreback , @jorisvandenbossche : Everything passing.  Ready to merge if there are no other concerns.
@gfyoung Thanks. Moved to 0.19.2
Fix num_days in PandasAutoDateLocator
State: closed

Prior to this commit, one year is worth 12 days, not 12 * 31 days.

Labels:
name: Visualization
description: plotting

Comments:
Could you add a release note to `whatsnew/v0.19.2.txt`? Tests will be hard I think, but looking at the diff, your logic looks correct.
is there an open issue for this?
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14716?src=pr) is 85.21% (diff: 100%)
> Merging [#14716](https://codecov.io/gh/pandas-dev/pandas/pull/14716?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

```diff
@@             master     #14716   diff @@
==========================================
  Files           143        143          
  Lines         50796      50796          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43284      43284          
  Misses         7512       7512          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [fdb70a9...7f78fda](https://codecov.io/gh/pandas-dev/pandas/compare/fdb70a96716c07a0940312cabffb61aea5d6d997...7f78fdaf4b1fd780a773e341f90129178bf8a54f?src=pr)
can you add a whatsnew note (0.20.0) and is there a test / example that shows the current behavior (is incorrect)?
can you rebase
@jorisvandenbossche ?
See discussion in https://github.com/pandas-dev/pandas/issues/15753. Merging this as it was obviously a typo in the code, but one that will not affect any behaviour.
DOC: Disambiguate 'where' in boolean indexing-10min.rst (#12661)
State: closed

 - [x] closes #12661

Per @jorisvandenbossche comment in this thread (https://github.com/pandas-dev/pandas/pull/12671), remove code markdown from 'where' to not confuse the example with the `where()` method.


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14708?src=pr) is 85.20% (diff: 100%)
> Merging [#14708](https://codecov.io/gh/pandas-dev/pandas/pull/14708?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #14708   diff @@
==========================================
  Files           143        143          
  Lines         50796      50787     -9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43285      43274    -11   
- Misses         7511       7513     +2   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [880de30...1093b0a](https://codecov.io/gh/pandas-dev/pandas/compare/880de3054c7ce3a6c48e295837207787dc73350f...1093b0a8ba65c0b1931409c7d6843080afe0242b?src=pr)
Thanks for the feedback @jreback. Expanded a bit on the example.  
@mroeschke Thanks!