BrandonFors/pandas-github-issues huggingface dataset:
DOC: fix EX03 errors in docstrings -  pandas.io.formats.style.Styler: highlight_quantile, background_gradient, text_gradient
State: closed

All EX03 Errors resolved in the following cases:

1. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.io.formats.style.Styler.highlight_quantile
2. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.io.formats.style.Styler.background_gradient
3. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.io.formats.style.Styler.text_gradient

OUTPUT:

1. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.io.formats.style.Styler.highlight_quantile
```
################################################################################
################################## Validation ##################################
################################################################################

1 Errors found for `pandas.io.formats.style.Styler.highlight_quantile`:
	RT03	Return value has no description
```

2. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.io.formats.style.Styler.background_gradient
```
################################################################################
################################## Validation ##################################
################################################################################

1 Errors found for `pandas.io.formats.style.Styler.background_gradient`:
	RT03	Return value has no description
```

3. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.io.formats.style.Styler.text_gradient
```
################################################################################
################################## Validation ##################################
################################################################################

1 Errors found for `pandas.io.formats.style.Styler.text_gradient`:
	RT03	Return value has no description
```



- [ ] xref https://github.com/pandas-dev/pandas/issues/56804
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @jordan-d-murphy
PERF: Don't sort labels in groupby.ffill/bfill
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

```
N = 1000000
df = DataFrame(
    {"group": [1] * N + [2] * N, "value": [np.nan, 1.0] * N}
).set_index("group")
df = df.sample(N)

%timeit df.groupby("group").ffill()
gb = df.groupby("group")
gb.ffill()
%timeit gb.ffill()

# main
21.8 ms ± 676 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)
17.5 ms ± 145 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

# PR
10.3 ms ± 159 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
5.56 ms ± 74.6 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
```

Labels:
name: Groupby
name: Performance
description: Memory or execution speed performance
name: Transformations
description: e.g. cumsum, diff, rank

Comments:
Thanks @rhshadrach
DOC: EX03 fixes on dataframe.plot methods: hexbin, line
State: closed

- [x] xref #56804 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
@alpakpinar I don't think this should be marked to close https://github.com/pandas-dev/pandas/issues/56804 yet, 
There are still a few methods remaining to be fixed. Would you consider updating it to xref format?

I've been using this for my PRs: 

- [ ] xref https://github.com/pandas-dev/pandas/issues/56804
@jordan-d-murphy thanks! I updated the description of this pull request and also #56898 
Thanks @alpakpinar
DOC: Docstring EX03 fixes for pandas.DataFrame methods
State: closed

- [x] xref #56804 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thank you for the fixes @alpakpinar, nice clean up.
Fix CI not raised when there's an error
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration
name: Code Style
description: Code style, linting, code_checks

Comments:
hello @datapythonista, I fixed them here: https://github.com/pandas-dev/pandas/pull/56855
Amazing, thanks for that PR. This one is empty now since everything was fixed there. Closing, thanks a lot for finding and fixing those errors.
DEPS: Add warning if pyarrow is not installed
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

~~Not sure how to add a test for this - importing our warning asserters would cause the warning the be raised! 🤣 ~~

EDIT: Nvm, figured it out.

(I've checked by hand that the warning is both raised when you import pandas directly and import a submodule of pandas e.g. ``pandas.arrays``.
I also double checked that the warning only occurs once and not on every import.)

Labels:
name: Dependencies
description: Required and optional dependencies
name: Warnings
description: Warnings that appear or should be added to pandas

Comments:
also cc @pandas-dev/pandas-core for feedback on the warning message itself.
Merging for now, happy to address any followups in another PR.
Sorry to comment here rather than an issue but this feels like quite a niche gotcha -- just a heads up that the warning added here starts with a newline which makes it annoying to filter out (as `filterwarnings` always matches the start of the message).

e.g., neither

```
"ignore:Pyarrow will become a required dependency of pandas.*:DeprecationWarning"
```

nor

```
"ignore:.*Pyarrow will become a required dependency of pandas.*:DeprecationWarning"
```

nor

```
"ignore:.*pandas.*:DeprecationWarning"
```

will match the message, and what is required is

```
"ignore:\\nPyarrow will become a required dependency of pandas.*:DeprecationWarning"
```

I guess changing it now might cause more pain, but I suspect you may get a few more questions on this before v3 (unless I am singularly confused by this -- a quick GH search shows a few PRs that also took a while to get this correct in other packages)!
STY: enable PLR5501
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Code Style
description: Code style, linting, code_checks
name: Clean

Comments:
Thanks @tqa236
STY: Remove black-specific rule
State: closed

As `pandas` uses `ruff` as the formatter now, I think that we can safely enable this rule.

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
Thanks @tqa236
TYP: Update pyright
State: closed

Newer releases of pyright infer return types of partially annotated functions, which uncovers quite a few difficult-to-fix type errors (some functions had no return types because it would create too many typing errors elsewhere).

(pyright can also try to infer return types for completely unannotated functions, but that is disabled for now in pyright_reportGeneralTypeIssues.json  as it would trigger more difficult-to-fix cases.)

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Thanks @twoertwein
DOC: Add deprecated markers for downcast keyword
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @phofl
TST: Fix setitem parametrizations
State: closed

I'm not sure if i am on the right track with this PR but it's a try. If not i will close it and probably someone more into the code has to dig into that issue.

- [x] closes #56727
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.
name: Stale

Comments:
I'd like to understand how this relates to #31948 (for which the behavior seems to have changed since it was opened).

Ideally we'd do checks on the indexer once at the DataFrame/Series level instead of at the block level which can end up doing them repeatedly.
@jbrockmendel i updated #31948 with the current behavior. What would be the desired behavior? Maybe the test has wrong expectations...
With `@pytest.mark.filterwarnings("ignore::FutureWarning")`, as the only change, instead of
```
if type(arr) is pd.Series:
    arr.iloc[idx] = arr.iloc[0]
else:
    arr[idx] = arr[0]
```
the main reason the test are failing is `KeyError: '[0 1 2 <NA>] not in index'` is raised. 
But this could also be the desired Error?
i opened a new PR, that only changes the `setitem-py`, but does does pass all tests. See #57629
@jbrockmendel @mroeschke maybe you can have a look at  #57629
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
TST: extension tests use its own fixtures
State: closed

This reverts a small part of https://github.com/pandas-dev/pandas/pull/56583, for the changes made in the `pandas/tests/extension` directory

This is still a bit brittle, as there is currently no check inplace we don't change this back in the future -> https://github.com/pandas-dev/pandas/issues/56735. I was thinking we could run the tests for one of our own extension arrays outside of the pandas tests, will comment more on the issue.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks @jorisvandenbossche
DOC: Additions/updates to documentation : grammar changes to documentation
State: closed

- [x] closes #56885 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
thx @Saadha123
DOC: fix EX03 in pandas.ExcelWriter
State: closed

- [ ] ref #56804 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Also add a cross-reference in the docstring.


Labels:
name: Docs

Comments:
Thanks @yuanx749, very nice clean up
DOC: Installation instructions update
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
I followed all the steps specified in the ReadMe documentation. I have installed MiniForge, Mamba and checkout the repository. 

I then followed the installation instructions specified in the README.md file and executed the below command

```sh
python -m pip install -ve . --no-build-isolation --config-settings=editable-verbose=true
```
And was facing several errors. After inspecting the logs I found out that they were ModuleNotFound errors so I inspected more and found I have to install all the requirements first

```sh
python -m pip install -r requirements-dev.txt
```

I have updated the ReadMe accordingly so, new comers won't stumble like me!

Updated document will have the following commands now

```sh
python -m pip install -r requirements-dev.txt
python -m pip install -ve . --no-build-isolation --config-settings=editable-verbose=true
```
This is incorrect, sorry. The instructions are for general users, you are making them install the dependencies for people who contributes to pandas, which doesn't make sense. Closing.
It had this instructions for development mode which I tried and it failed. Instructions were partial

In **README.md**:

or for installing in [development mode](https://pip.pypa.io/en/latest/cli/pip_install/#install-editable):

python -m pip install -ve . --no-build-isolation --config-settings=editable-verbose=true
You are correct, sorry, I reviewed this PR too quick.

@lithomas1, I think this is failing since we moved to Meson. Shouldn't pip be able to find the dependencies it needs? When installing in editable mode pip fails because `mesonpy` is not found, and after installing it manually it fails because ofther deps like jinja.
@lithomas1 Should I remove and send pull request?
Yes, feel free to edit this same branch/PR and remove that block.
DOC: fix EX03 errors in docstrings - pandas.Timestamp - ceil, floor, round
State: closed

All EX03 Errors resolved in the following cases:

1. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.Timestamp.ceil 
2. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.Timestamp.floor
3. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.Timestamp.round

OUTPUT:

1. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.Timestamp.ceil 
```
################################################################################
################################## Validation ##################################
################################################################################

2 Errors found for `pandas.Timestamp.ceil`:
	No extended summary found
	See Also section not found
```

2. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.Timestamp.floor
```
################################################################################
################################## Validation ##################################
################################################################################

2 Errors found for `pandas.Timestamp.floor`:
	No extended summary found
	See Also section not found
```

3. scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.Timestamp.round
```
################################################################################
################################## Validation ##################################
################################################################################

2 Errors found for `pandas.Timestamp.round`:
	No extended summary found
	See Also section not found
```

- [ ] xref https://github.com/pandas-dev/pandas/issues/56804
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @jordan-d-murphy
DOC: fixed Ex03 errors in docstrings: 
State: closed

**PR SUMMARY**

Checked if validation docstrings passes for:

- [x] pandas.errors.DatabaseError
- [x] pandas.errors.IndexingError 
- [x] pandas.errors.InvalidColumnName

OUTPUT:
1. python scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.errors.DatabaseError
```
################################################################################
################################## Validation ##################################
################################################################################

Docstring for "pandas.errors.DatabaseError" correct. :)
```

2. python scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.errors.IndexingError
```
################################################################################
################################## Validation ##################################
################################################################################

Docstring for "pandas.errors.IndexingError" correct. :)
```

3. python scripts/validate_docstrings.py --format=actions --errors=EX03 pandas.errors.InvalidColumnName
```
################################################################################
################################## Validation ##################################
################################################################################

Docstring for "pandas.errors.InvalidColumnName" correct. :)
```

**PR CHECKLIST**

- [ ] xref #56804 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @tiffanyxiao