BrandonFors/pandas-github-issues huggingface dataset:
CLN: separate out groupby algos
State: closed

- separate out groupby algorithms to separate lib
- release GIL on median
- release GIL on is_lexsorted / fix memory leak
- release GIL on nancorr

Labels:
name: Groupby
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15775?src=pr&el=h1) Report
> Merging [#15775](https://codecov.io/gh/pandas-dev/pandas/pull/15775?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/32dd92912f15a5c66035f5674c116d23f21bdbca?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.


```diff
@@            Coverage Diff             @@
##           master   #15775      +/-   ##
==========================================
- Coverage   91.01%      91%   -0.02%     
==========================================
  Files         143      143              
  Lines       49403    49403              
==========================================
- Hits        44966    44957       -9     
- Misses       4437     4446       +9
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15775?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby.py](https://codecov.io/gh/pandas-dev/pandas/compare/32dd92912f15a5c66035f5674c116d23f21bdbca...4e2bfecf9866cf82289fff3fa774247bae3c6f37?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS5weQ==) | `94.96% <100%> (ø)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/32dd92912f15a5c66035f5674c116d23f21bdbca...4e2bfecf9866cf82289fff3fa774247bae3c6f37?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/32dd92912f15a5c66035f5674c116d23f21bdbca...4e2bfecf9866cf82289fff3fa774247bae3c6f37?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.86% <0%> (-0.1%)` | :arrow_down: |
| [pandas/tseries/index.py](https://codecov.io/gh/pandas-dev/pandas/compare/32dd92912f15a5c66035f5674c116d23f21bdbca...4e2bfecf9866cf82289fff3fa774247bae3c6f37?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvaW5kZXgucHk=) | `95.29% <0%> (-0.1%)` | :arrow_down: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/32dd92912f15a5c66035f5674c116d23f21bdbca...4e2bfecf9866cf82289fff3fa774247bae3c6f37?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `91.3% <0%> (+0.33%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15775?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15775?src=pr&el=footer). Last update [32dd929...4e2bfec](https://codecov.io/gh/pandas-dev/pandas/compare/32dd92912f15a5c66035f5674c116d23f21bdbca...4e2bfecf9866cf82289fff3fa774247bae3c6f37?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
CLN: replace _interleave_dtype with _find_common_type
State: closed

xref #15736 
xref #12780 

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Clean

Comments:
cc @sdementen 

you can rebase on top of this; should make that PR a lot simpler.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15765?src=pr&el=h1) Report
> Merging [#15765](https://codecov.io/gh/pandas-dev/pandas/pull/15765?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/783ae69f0edc350bdf7b20932351c79a5a1fad3c?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `100%`.


```diff
@@            Coverage Diff             @@
##           master   #15765      +/-   ##
==========================================
- Coverage   91.01%   90.99%   -0.03%     
==========================================
  Files         143      143              
  Lines       49395    49371      -24     
==========================================
- Hits        44959    44927      -32     
- Misses       4436     4444       +8
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15765?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/types/cast.py](https://codecov.io/gh/pandas-dev/pandas/compare/783ae69f0edc350bdf7b20932351c79a5a1fad3c...d47264683bf51d5a97e4affcaf835d714937cc43?src=pr&el=tree#diff-cGFuZGFzL3R5cGVzL2Nhc3QucHk=) | `85.31% <100%> (+0.2%)` | :arrow_up: |
| [pandas/core/internals.py](https://codecov.io/gh/pandas-dev/pandas/compare/783ae69f0edc350bdf7b20932351c79a5a1fad3c...d47264683bf51d5a97e4affcaf835d714937cc43?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzLnB5) | `93.62% <100%> (ø)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/783ae69f0edc350bdf7b20932351c79a5a1fad3c...d47264683bf51d5a97e4affcaf835d714937cc43?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/783ae69f0edc350bdf7b20932351c79a5a1fad3c...d47264683bf51d5a97e4affcaf835d714937cc43?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.86% <0%> (-0.1%)` | :arrow_down: |
| [pandas/tseries/index.py](https://codecov.io/gh/pandas-dev/pandas/compare/783ae69f0edc350bdf7b20932351c79a5a1fad3c...d47264683bf51d5a97e4affcaf835d714937cc43?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvaW5kZXgucHk=) | `95.29% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15765?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15765?src=pr&el=footer). Last update [783ae69...d472646](https://codecov.io/gh/pandas-dev/pandas/compare/783ae69f0edc350bdf7b20932351c79a5a1fad3c...d47264683bf51d5a97e4affcaf835d714937cc43?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
DOC: Patch new flake8 command grep
State: closed

The grep was initially matching to "pandas," which is incorrect because that was also matching files containing "pandas" in the name but that were not in the main `pandas` directory (e.g. performance test code).  This change enforces that we match to any Python files in the main `pandas` directory.

Also picked up compatibility issue with OSX, in which the `-r` flag does not exist.  However, `xargs` terminates if the argument list is empty, which was the whole point of passing in `-r` in the first place.

Follow-up to #15712

Labels:
name: Docs

Comments:
thanks!
BUG: replace coerces incorrect dtype
State: closed

closes #12747

Author: sinhrks <sinhrks@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

closes #15742
Closes #12780 from sinhrks/replace_type and squashes the following commits:

f9154e8 [sinhrks] remove unnecessary comments
279fdf6 [sinhrks] remove import failure
de44877 [sinhrks] BUG: replace coerces incorrect dtype

Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15742?src=pr&el=h1) Report
> Merging [#15742](https://codecov.io/gh/pandas-dev/pandas/pull/15742?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b1e29dba26ff86b826fe0f866182466ae42c0bc5?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `89.65%`.


```diff
@@            Coverage Diff             @@
##           master   #15742      +/-   ##
==========================================
- Coverage   91.01%   91.01%   -0.01%     
==========================================
  Files         143      143              
  Lines       49380    49401      +21     
==========================================
+ Hits        44943    44961      +18     
- Misses       4437     4440       +3
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15742?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/internals.py](https://codecov.io/gh/pandas-dev/pandas/compare/b1e29dba26ff86b826fe0f866182466ae42c0bc5...8bde21a9f01c4a09d6e305906e81794b45935d5e?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzLnB5) | `93.62% <100%> (+0.02%)` | :arrow_up: |
| [pandas/types/cast.py](https://codecov.io/gh/pandas-dev/pandas/compare/b1e29dba26ff86b826fe0f866182466ae42c0bc5...8bde21a9f01c4a09d6e305906e81794b45935d5e?src=pr&el=tree#diff-cGFuZGFzL3R5cGVzL2Nhc3QucHk=) | `85.11% <80%> (-0.35%)` | :arrow_down: |
| [pandas/tseries/index.py](https://codecov.io/gh/pandas-dev/pandas/compare/b1e29dba26ff86b826fe0f866182466ae42c0bc5...8bde21a9f01c4a09d6e305906e81794b45935d5e?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvaW5kZXgucHk=) | `95.29% <0%> (-0.1%)` | :arrow_down: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/b1e29dba26ff86b826fe0f866182466ae42c0bc5...8bde21a9f01c4a09d6e305906e81794b45935d5e?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `91.3% <0%> (+0.33%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15742?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15742?src=pr&el=footer). Last update [b1e29db...8bde21a](https://codecov.io/gh/pandas-dev/pandas/compare/b1e29dba26ff86b826fe0f866182466ae42c0bc5...8bde21a9f01c4a09d6e305906e81794b45935d5e?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
BUG: tz aware Timestamp field accessors returns local values (#13303)
State: closed

 - [x] closes #13303
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry

Previously, calling a date/time attribute with Timestamp that's tz aware (e.g. `Timestamp('...', tz='...').dayofyear`) would return the attribute in UTC instead of the local tz. 

Labels:
name: Bug
name: Timezones
description: Timezone data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15740?src=pr&el=h1) Report
> Merging [#15740](https://codecov.io/gh/pandas-dev/pandas/pull/15740?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/8bde21a9f01c4a09d6e305906e81794b45935d5e?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15740      +/-   ##
==========================================
- Coverage   91.01%   90.99%   -0.02%     
==========================================
  Files         143      143              
  Lines       49401    49401              
==========================================
- Hits        44961    44952       -9     
- Misses       4440     4449       +9
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15740?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/8bde21a9f01c4a09d6e305906e81794b45935d5e...b78b333ba572b02221a3d73d4f30b2f4833a76f9?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/8bde21a9f01c4a09d6e305906e81794b45935d5e...b78b333ba572b02221a3d73d4f30b2f4833a76f9?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `90.96% <0%> (-0.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/8bde21a9f01c4a09d6e305906e81794b45935d5e...b78b333ba572b02221a3d73d4f30b2f4833a76f9?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.86% <0%> (-0.1%)` | :arrow_down: |
| [pandas/tseries/index.py](https://codecov.io/gh/pandas-dev/pandas/compare/8bde21a9f01c4a09d6e305906e81794b45935d5e...b78b333ba572b02221a3d73d4f30b2f4833a76f9?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvaW5kZXgucHk=) | `95.39% <0%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15740?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15740?src=pr&el=footer). Last update [8bde21a...b78b333](https://codecov.io/gh/pandas-dev/pandas/compare/8bde21a9f01c4a09d6e305906e81794b45935d5e...b78b333ba572b02221a3d73d4f30b2f4833a76f9?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
can you add similar type tests for ``DatetimeIndex`` (IOW with a tz) in ``pandas/tests/indexes/datetimes/test_misc.py`` 
lgtm.

Thanks @jreback!
MAINT: Drop order and sort from pandas objects
State: closed

Affected classes:

1) `Index`
2) `Series`
2) `DataFrame`

xref #10726

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15735?src=pr&el=h1) Report
> Merging [#15735](https://codecov.io/gh/pandas-dev/pandas/pull/15735?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15735      +/-   ##
==========================================
- Coverage   91.01%   90.99%   -0.02%     
==========================================
  Files         143      143              
  Lines       49396    49380      -16     
==========================================
- Hits        44958    44934      -24     
- Misses       4438     4446       +8
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15735?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/series.py](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...f268b939ddfb91b67495efd0d5a64b654e07db93?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc2VyaWVzLnB5) | `94.86% <ø> (-0.03%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...f268b939ddfb91b67495efd0d5a64b654e07db93?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.86% <ø> (-0.11%)` | :arrow_down: |
| [pandas/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...f268b939ddfb91b67495efd0d5a64b654e07db93?src=pr&el=tree#diff-cGFuZGFzL2luZGV4ZXMvYmFzZS5weQ==) | `96.14% <ø> (-0.01%)` | :arrow_down: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...f268b939ddfb91b67495efd0d5a64b654e07db93?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/tseries/index.py](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...f268b939ddfb91b67495efd0d5a64b654e07db93?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvaW5kZXgucHk=) | `95.39% <0%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15735?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15735?src=pr&el=footer). Last update [59b88ab...f268b93](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...f268b939ddfb91b67495efd0d5a64b654e07db93?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
thanks!
TST: clean up build testing
State: closed


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: CI
description: Continuous Integration

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15734?src=pr&el=h1) Report
> Merging [#15734](https://codecov.io/gh/pandas-dev/pandas/pull/15734?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15734      +/-   ##
==========================================
- Coverage   91.01%      91%   -0.02%     
==========================================
  Files         143      143              
  Lines       49396    49396              
==========================================
- Hits        44958    44951       -7     
- Misses       4438     4445       +7
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15734?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...a99b713353516c041a47152a25e1369fc06faa05?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...a99b713353516c041a47152a25e1369fc06faa05?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.87% <0%> (-0.1%)` | :arrow_down: |
| [pandas/tseries/index.py](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...a99b713353516c041a47152a25e1369fc06faa05?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvaW5kZXgucHk=) | `95.39% <0%> (+0.09%)` | :arrow_up: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...a99b713353516c041a47152a25e1369fc06faa05?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `91.3% <0%> (+0.33%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15734?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15734?src=pr&el=footer). Last update [59b88ab...a99b713](https://codecov.io/gh/pandas-dev/pandas/compare/59b88ab6123338e1dfcc0f77dfb3e5c4c511889a...a99b713353516c041a47152a25e1369fc06faa05?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
TST: move conftest.py to top-level
State: closed

xref #15341 

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
@jreback The concerns of before regarding `pd.test()` (the reason conftest.py was not in the top level), are those solved / not needed anymore ?
@jorisvandenbossche so the issue was that when installed, if ``conftest.py`` is at the top-level (and not below pandas), then its not installed; this can be resolved by by actually including it as a data file in ``setup.py``, but then need to have to explicity tell ``pytest`` . This *only* matters for ``pandas.test()``; so we *could* explicity path it in there.

But this is just simpler. In any even I made the ``BUILD_TEST`` build now run ``pandas.test()`` so this is tested anyhow.
FYI I reverted my original commit: 59b88ab6123338e1dfcc0f77dfb3e5c4c511889a 
For what reason did you revert?

Personally, it doesn't really matter to me where `conftest.py` goes. It is just a choice when putting it top-level that `pd.test()` cannot specify the custom markers. Which is not the biggest problem I think. But I also don't mind it being inside pandas (it is not visible to users, so not really a problem)
@jorisvandenbossche well, it IS a problem in that in reality ``conftest.py`` will have more and more things. This is a central repository for fixtures and such. If pandas had been built from the ground up with ``pytest``, we would have a whole set of ``conftest.py``. So its not a problem per-se, just not very clean (and not very typical).
OK, so we agree to just keep it in pandas? 
That was not fully clear to me that you were OK with that, so that was the only reason of my question above!
yeah not sure what to do with it really.
TST: only catch deprecation warnings for top-level module imports
State: closed


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
@jreback What is the rationale here? Whas there a certain problem? The fact that those raise a warning is useful to test, no?
well the problem is we have ``pandas.json``, which if you are *in* ``pandas`` and do an ``import json`` it imports the local module (and not from the std library). So eventually when I get rid of ``pandas.json`` this will go away.

I put this in here, because you see the warning when the ``_version`` is imported.
Sorry, I don't understand the connection between the import problem of json, and the fact that `pd.json.dumps` raises a FutureWarning ?

> I put this in here, because you see the warning when the _version is imported.

Do you mean

```
In [1]: from pandas import _version
```

I don't see a warning there.
try creating a sdist, then untarring it. you will see a file ``pandas/_version.py``, versioneer creates this. 

IN this file it does a ``import json``. BUT this is IN the ``pandas/`` directory. guess what it picks up ``pandas.json``. (it has always been this ways, and it just happens to work, because ``json.loads`` is works like the library one).

It actually loading the WRONG library. The deprecation warning is because we are deprecating ``pandas.json``.

Its an unfortunate consequence of having a stdlib module name that is pretty common.
this ONLY happens on a package version FYI! It *does* NOT happen with a dev version. I noticed this when on the new build-test job, which actually does a full install then ``import pandas; pandas.test()``, just like an end-user would do.

It shows a deprecation warning immediately.
BUG: TZ-aware Series.where() appropriately handles default other=nan (#15701)
State: closed

 - [x] closes #15701 
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry


Labels:
name: Bug
name: Datetime
description: Datetime data dtype
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Timezones
description: Timezone data dtype

Comments:
thanks @chrisaycock