BrandonFors/pandas-github-issues huggingface dataset:
Updated README.md Grammar
State: closed

Suggested appropriate changes in grammar.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:

Comments:
some of these changes were already suggested in #42454. It was closed, however, since those/these changes are not grammatical errors, they are more subjective preferences of the author and changes are not needed.
Agree that these changes are not needed - please see [good first issues](https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22) and [contributing guide](https://pandas.pydata.org/docs/development/contributing.html) for how to contribute to pandas
REGR: sample modifying `weights` inplace
State: closed

- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Targeting 1.4 and no whatsnew since only a regression on master.


Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green.
> looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green.

Didn't include a whatsnew because it is only a regression on master caused by #42233
> > looks fine can you add a whatsnew note (1.4) reshaping is fine & ping on green.
> 
> Didn't include a whatsnew because it is only a regression on master caused by #42233

kk cool
thanks @mzeitlin11
CI: Upgrade codecov-action to v2
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: CI
description: Continuous Integration

Comments:
Seems benign; what does this do?
The old uploader is deprecated. From the codecov github releases page.
```
On February 1, 2022, the v1 uploader will be full sunset and no longer function. This is due
to the deprecation of the underlying bash uploader. This version uses the new uploader.

The v2 Action downloads, verifies, and runs the Codecov binary.
```
Probably better to upgrade it sooner rather than later.
Thanks @lithomas1
BUG: `styler.hide_columns` now hides the index name header row
State: closed

- [x] closes #42101
- [x] closes #42190 (stale pr)

Fixes `hide_columns` so that the index header row is also hidden alongside column headers.
Can be back ported to 1.3.2


Labels:
name: Styler
description: conditional formatting using DataFrame.style

Comments:
thanks @attack68 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
REGR: Series.nlargest with masked arrays
State: closed

- [x] closes #42816
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
not super thrilled with this, but does fix.
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
DEPR: dropping nuisance columns in rolling aggregations
State: closed

- [x] closes #42738
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

we did this in 1.3 for DataFrame reductions and GroupBy reductions.  AFAIK this is the last place we use this pattern.

cc @mroeschke 


Labels:
name: Window
description: rolling, ewma, expanding
name: Nuisance Columns
description: Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply

Comments:
comments addressed + rebased + green
CI: Unpin jedi
State: closed

- [ ] closes #38703
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: CI
description: Continuous Integration
name: Dependencies
description: Required and optional dependencies

Comments:
Thanks @lithomas1
TST: raising ValueError when inserting one dataframe in another
State: closed

- [x] closes #42403
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
Hello @debnathshoham! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-08-04 17:14:31 UTC
Thanks @debnathshoham
REF: remove unnecessary return value from ensure_data
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Refactor
description: Internal refactoring of code

Comments:
lgtm.
BUG: Exactly same check multiple times in if statement
State: closed

- [x] closes #42781 
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Clean

Comments:
thanks @gcaria
BUG: column names with degree sign make query fail
State: closed

This pull request adds DEGREESIGN (°) to tokens that are parsed and escaped in a backticked column. There are no separate issue reporting this, but this is similar to the EUROSIGN issue previously addressed.

- [ ] closes #xxxx
- [x] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Bug
name: expressions
description: pd.eval, query

Comments:
Thanks for the pr @fdion! Would you mind adding a test that fails on master, but works with this addition? And could use a whatsnew note about this change.
Since there were no tests for the column names in query, I added a test @mzeitlin11 that covers something that worked on main (`Capacitance(μF)`) with a special character, and with the degree symbol (`Temp(°C)`) which will fail on main. All 4 tests pass with my change.
> Since there were no tests for the column names in query, I added a test @mzeitlin11 that covers something that worked on main (`Capacitance(μF)`) with a special character, and with the degree symbol (`Temp(°C)`) which will fail on main. All 4 tests pass with my change.

Thanks, tests look great! 2 small comments, otherwise LGTM
thanks @fdion
PERF: column_arrays
State: closed

Shaves a couple percent off of time_to_json_wide asv

Labels:
name: Performance
description: Memory or execution speed performance

Comments:
seems fine, cna you rebase
can you rebase again just to be sure
getting segfaults on some builds, must be coming from the json c code.  @WillAyd anything stand out to you?
Won’t be able to look or the next week or so. Have you tried running the tests under a debugger? Should break on any segfault 

https://pandas.pydata.org/docs/development/debugging_extensions.html

FWIW I personally haven’t been getting symbols to show up in the debugger when compiling with clang - not sure what caused that recently but gdb may make things easier if available to you

Sent from my iPhone

> On Aug 5, 2021, at 9:55 PM, jbrockmendel ***@***.***> wrote:
> 
> ﻿
> getting segfaults on some builds, must be coming from the json c code. @WillAyd anything stand out to you?
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.

mothballing to clear the queue, need to figure out why this is segfaulting on some builds
BUG: Pass copy argument to expanddim constructor in concat.
State: closed

- [x] closes #42501
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Pass the provided copy argument through to the DataFrame constructor when constructing a DataFrame from a Series iterable, as is done with the other DataFrame construction call in the get_result method.

The new test in frame/methods/test_astype.py is as provided by the author of the issue with minor changes.

@TomAugspurger this updates your test `extension/decimal/test_decimal.py:test_astype_dispatches` to expect both frame and series astype calls to retain the context.prec value.  The prior failure was caused by the copying of the DataFrame, and that copy no longer occurs.  The underlying issue with copy and the dtype is unaddressed here.

Labels:
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.
name: Copy / view semantics

Comments:
The one test failure in `pandas/tests/resample/test_resample_api.py::test_agg` appears to be occurring in other PR test runs and unrelated.
ping when ready for merge
status here?
> status here?

Just about there.  Can you look at the questions above in the review?
> > status here?
> 
> Just about there. Can you look at the questions above in the review?

answered! pls merge master as well and ping on green.
thanks @jmcomie 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
> thanks @jmcomie

thanks for helping with the PR.  I'm happy to contribute
CI: catch warning produced in resample
State: closed

- [x] closes #42814
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
@jreback gentle ping gets us back to green (unrelated windows timeout)
do we need to backport this?
if we dont want to show users FutureWarnings then yah
but this is in a test so nbd i guess
BUG: Fix dtypes for read_json
State: closed

- [x] closes #33205
- [x] closes #21892
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: IO JSON
description: read_json, to_json, json_normalize

Comments:
Ready to be merged from my side.
Seems like the tests are flaky, can we rerun them?
there is a failure on master, will merge when fixed
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
@jreback greenish if still good to merge
can you merge master and ping on green
ping @jreback 

Thanks for keeping the ball rolling on this!
Thanks @r-raymond very nice!
fix import error for version under python3.8
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:

Comments:
add compatibility for python version under 3.8
Thanks for your PR, but Python3.7 is no longer supported on `master` (1.3.x releases still support it though)

typing_extensions isn't a dependency anyway so this wouldn't work
DOC: Fixed GL02 errors in documentation
State: closed

Fixed 2 of the 4 GL02 errors generated by pandas_validation_errors.ipynb 
The remaining two errors are from pandas.Timestamp.isoweekday and will be tackled next. 


Labels:
name: Docs

Comments:
is there a linter check we're going to add for this?
xref https://github.com/pandas-dev/pandas/issues/25120

Thanks @fshi01. Happy to have you to tackle the remaining GL02 errors and add a check in our CI. 
In addition to the remaining GL02 errors and adding a check to the CI, is there anything else I should do before it is merged? 
Nothing in particular.
COMPAT: MPL 3.4.0
State: closed

- [ ] closes #42791
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Visualization
description: plotting
name: Compat
description: pandas objects compatability with Numpy or Python functions
name: Dependencies
description: Required and optional dependencies

Comments:
thanks @lithomas1 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
Cln reshape tests
State: closed

- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them


Some cleanups


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Clean

Comments:
thanks @phofl
DataFrame.drop silently does nothing if MultiIndex has duplicates
State: closed

- [x] closes #42771
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Regression
description: Functionality that used to work in a prior pandas version
name: MultiIndex

Comments:
lgtm. @jbrockmendel ok here?
thanks @phofl 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
BUG: `Styler.set_sticky` fix the names rows 2/2
State: closed

- [x] closes #42537

BUG:
In 1.3.0/1.3.1 `set_sticky` did not handle well the names of column/index headers.
This overall bug fix makes sure those cells are well handled.
**Should be backported to 1.3.2**

Before any Fixes | After 2 of 2 fixes
--- | ---
**Index / No Names** | 
![before fixes index no names](https://user-images.githubusercontent.com/24256554/127744031-4e2cd55f-af0c-4666-935f-37fd9320ebdd.png) | ![after fixes index no names](https://user-images.githubusercontent.com/24256554/127738841-c0cb2606-7be1-4cc9-be20-28aadf8dd427.png)
**Index + Names**
![before fixes index names](https://user-images.githubusercontent.com/24256554/127744063-cdfd67ad-0665-47e9-b8fa-96998f5673c5.png) |![after fixes index names](https://user-images.githubusercontent.com/24256554/127738852-59e5199c-660b-4873-a17f-f9f99e3507de.png)
**MultIndex / No Names**
![before fixes multiindex no names](https://user-images.githubusercontent.com/24256554/127744109-1bcd7807-e204-4a7e-9990-57991365e1ca.png) | ![after fixes multiindex no names](https://user-images.githubusercontent.com/24256554/127738960-6d142482-d1ac-4475-b1dc-c0731ba68032.png)
**MultIndex + Names**
![before fixes multiindex names](https://user-images.githubusercontent.com/24256554/127744157-82aaa215-e87e-46e2-b57a-19f41f7c544e.png) | ![after fixes multindex names](https://user-images.githubusercontent.com/24256554/127743932-78f241f4-3c94-49e5-998d-14c6f7a0af9f.png)













Labels:
name: Styler
description: conditional formatting using DataFrame.style

Comments:
can you rebase this just to make sure
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
REGR: nanosecond timestamp comparisons to OOB datetimes
State: closed

- [x] closes #42794
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Datetime
description: Datetime data dtype
name: Regression
description: Functionality that used to work in a prior pandas version
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
thanks @mzeitlin11 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
CI: Fix doctests
State: closed

- [x] closes #42798
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them

Fixes three doctest failures on master. 

One is from #42569, where name is no longer preserved when passing a named Index into `.loc`. We want to preserve the name when passed an Index (this was documented), but certainly not a boolean Series mask. Not certain if there are cases outside of Index where it should be preserved. cc @jbrockmendel

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
comment request, otherwise LGTM
thanks @rhshadrach 
we still have some failing style tests right?
@jreback - not that I'm aware of. Looks like CI Checks passed here.
DOC GH42756 Update documentation for pandas.DataFrame.drop to clarify…
State: closed

… tuples.

- [ ] closes #42756
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
Thanks @mikephung122!
TYP: Fix typing for searchsorted
State: closed

- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them

Fixes mypy issue without using an ignore. cc @Dr-Irv 

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Thanks @rhshadrach
TST: Fix doctests in ``style.py``
State: closed

The following commits fix the doctests of the ``style.py``, add some redirects to the User Guide, and some expected results.

- [x] closes #42759
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Docs
name: Styler
description: conditional formatting using DataFrame.style

Comments:
wow

cc @attack68 if you'd take a look / merge (ok if it needs a followup) as this is green.
once you are confident that this fixes all cases in `style.py` do add it to `ci/code_checks.ch` which will then prevent anyone (like me) adding failing doctests in the future unknowingly.
also pls rebase, in theory this should be all green.
By the time I went to update my branch before committing to the new changes, I ended up rebasing and there were some commits that shouldn't go. I think it will be necessary to make a new, more organized PR, correct?
the failure is fine (its already fixed on master).

@attack68 merge when ready.
@Leonardofreua thanks. You might want to do a follow-on where the links you added to table visualization are more specific. You can link to specific parts of the page using `#page-id-as-title`
> @Leonardofreua thanks. You might want to do a follow-on where the links you added to table visualization are more specific. You can link to specific parts of the page using `#page-id-as-title`

Hi @attack68, thanks for the tip. I had initially done just that, but I thought it might not be accepted, so I ended up removing it. Can I open another issue to make this change?
TST: Fix for doctest in style_render.py -> pandas.io.formats.style_re…
State: closed

This pull request fixes the doctest pandas.io.formats.style_render.StylerRenderer.format

- [X] closes #42766 

Following this commit, all the doctests in style_render.py file passed.

Output:
```
python -m pytest --doctest-modules pandas/io/formats/style_render.py
========================================================= test session starts =========================================================
platform linux -- Python 3.8.5, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /home/aneesh/Desktop/Side Projects/ops/pandas, configfile: pyproject.toml
plugins: forked-1.3.0, asyncio-0.15.1, anyio-3.3.0, cov-2.12.1, instafail-0.4.2, hypothesis-6.14.3, xdist-2.3.0
collected 3 items                                                                                                                     

pandas/io/formats/style_render.py ...

--------------------------- generated xml file: /home/aneesh/Desktop/Side Projects/ops/pandas/test-data.xml ---------------------------
======================================================== slowest 30 durations =========================================================
1.06s call     pandas/io/formats/style_render.py::pandas.io.formats.style_render.StylerRenderer.format

(8 durations < 0.005s hidden.  Use -vv to show these durations.)
========================================================== 3 passed in 1.15s ==========================================================

```


Labels:

Comments:
Hello @aneesh98! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-08-01 12:10:04 UTC
is it better to have two spaces before `#` as per PEP?
> is it better to have two spaces before `#` as per PEP?

Sorry actually I have added two spaces before `#` , referring to other doctests in other files (for instance frame.py). 
> lgtm, all of these can be skipped

Thanks
@aneesh98 I would recommend merging master into your branch. #42790 and #42820 fixes the CI checks so they should now be all green once you merge 
> @aneesh98 I would recommend merging master into your branch. #42790 and #42820 fixes the CI checks so they should now be all green once you merge

Hi @KrishnaSai2020. Thank you for this.
thanks @aneesh98
BUG: Incorrect variable window bounds for first row when offset cover all rows
State: closed

- [x] closes #42753 
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

---

Allow for cases in which the end bound of the variable window for the first row extends past the last row, that is, cases in which the offset is large enough to cover all the rows.

Labels:
name: Window
description: rolling, ewma, expanding

Comments:
Hello @dicristina! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-08-06 16:42:02 UTC
cc @mroeschke 
@dicristina can you merge master
thanks @dicristina 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
CI: mypy fixup
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: CI
description: Continuous Integration
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
See #42770
merged #42770