BrandonFors/pandas-github-issues huggingface dataset:
CLN only check if dtype is compatible within mask
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

possible precursor to PDEP6

Labels:

Comments:
hmm  maybe not the best idea
TST/BUG: pyarrow test fixtures upcasting dtypes
State: closed

There are a few test fixtures in `test_arrow.py` that create an array from a subset of another array using `ArrowExtensionArray._from_sequence`. They are not passing the dtype which results in upcasting for smaller dtypes.

```
import pandas as pd

dtype = "int32[pyarrow]"

arr = pd.array([1, 2, 3], dtype=dtype)
arr2 = type(arr)._from_sequence([arr[0], arr[1]])

print(arr2.dtype)  # -> int64[pyarrow]
```

Labels:
name: Bug
name: Testing
description: pandas testing functions or related to the test suite
name: Arrow
description: pyarrow functionality

Comments:
Thanks @lukemanley
PERF/CLN: let pyarrow concat chunks instead of doing it ourselves in __from_arrow__
State: closed

See https://github.com/pandas-dev/pandas/issues/52070#issuecomment-1523223389 for context. We are currently manually iterating through the chunks of the pyarrow array, converting each chunk to our masked extension array, and then concatenate those at the end. While we could also let pyarrow concatenate the chunks, and then do a single conversion from the concatenated pyarrow Array to our masked array. That is both more performant and simpler to code.


- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Performance
description: Memory or execution speed performance
name: Arrow
description: pyarrow functionality

Comments:
LGTM pending green
Awesome, thanks @jorisvandenbossche
MNT: Metadata in DataFrame.mean
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.
The goal here is to make progress on https://github.com/pandas-dev/pandas/issues/28283.


Labels:
name: metadata
description: _metadata, .attrs
name: Stale

Comments:
[only propogate when it is Dataframe of Series](https://github.com/pandas-dev/pandas/pull/52925/commits/e842f9a8442d0eb954e5d395771d5d5f3570131f)
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Fix the metadata propagation in Dataframe.std
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.
The goal here is to make progress on https://github.com/pandas-dev/pandas/issues/28283.


Labels:
name: metadata
description: _metadata, .attrs

Comments:
Looks like there's typing issue which indicates this needs fixed at a lower level
Yeah it seems so, i will figure it out
Fix the typing problem by forcing the only propagation on Series
changes look good, if you add a whatsnew note to 2.1.0.rst we can get this in
Sure! I will add it now, Sorry I forget to add
Thanks @jiawei-zhang-a
Metadata propagation both in DataFrame.corrwith and Dataframe.sum
State: closed

….sum

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.
The goal here is to make progress on https://github.com/pandas-dev/pandas/issues/28283.



Labels:
name: metadata
description: _metadata, .attrs

Comments:
Thanks @jiawei-zhang-a
Fixed metadata propagation in Dataframe.any
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.
The goal here is to make progress on https://github.com/pandas-dev/pandas/issues/28283.


Labels:
name: metadata
description: _metadata, .attrs
name: Stale

Comments:
Looks like there's some typing failures
Propogate only when it is Series and ignore the return-value typing error when it is bool
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DEPR: Revert DataFrameGroupBy.apply operating on the group keys 
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Reverts #52477

Labels:
name: Groupby
name: Deprecate
description: Functionality to remove in pandas
name: Apply
description: Apply, Aggregate, Transform, Map

Comments:
Thx, could you rebase? This should get the numpy dev build green
thx @rhshadrach
CLN: Simplify to_masked implementation
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean
name: Arrow
description: pyarrow functionality

Comments:
Thanks @phofl
BUG: overriden methods of subclasses of Styler are not called during rendering #52728
State: closed

- [x] closes #52728 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Styler
description: conditional formatting using DataFrame.style
name: Subclassing
description: Subclassing pandas objects

Comments:
Thanks @nicklausroach
TST: Add test_datetime_object_multiindex test
State: closed

- [x] closes #19993 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks @shteken
TST: apply returns list
State: closed

- [x] closes #17487
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks @srkds 
Thanks @mroeschke for the review 👍
DEPS: Address numpy deprecation of len 1 arrays assignment
State: closed

- [ ] closes #52853 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dependencies
description: Required and optional dependencies

Comments:
There's more detail in https://github.com/numpy/numpy/pull/10615#issuecomment-1522513193, but basically `arr[0, ...]` will return a 0D array vs the actual object which is useful when the object is an array like e.g. `(1,)` that you want to treat like a scalar
DOC: Remove versionadded/changed for 1.1.0
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

removed 1.0 and earlier for 2.0, so can remove 1.1.0 for 2.1 I guess

Labels:
name: Docs

Comments:
Thanks @phofl
BUG: Fixes Incompatible return value type in pandas/core/generic.py
State: closed

- Contributes to issue #37715 (https://github.com/pandas-dev/pandas/issues/37715)
- Casts 64-bit signed integer to int value
- Passes unit tests through PyTest
- Added tests to respective folders within tests/series and tests/frame subdirectory
- Removed ignore comments


Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
> While subtle, this changes from a NumPy int to a Python int. I think this should be noted in the whatsnew as a bugfix.
> 
> Are the changes to pandas_web intentional?

My mistake, I will revert the changes as the changes in web pertain to a separate issue.
> All looks great - I think it just needs a note in the whatsnew under `Bug fixes` in the `Numeric` section.

The entry has been added to the whatsnew. 
No objections here
@bunardsheng - conflict needs to be resolved and we're good to go.
> @bunardsheng - conflict needs to be resolved and we're good to go.

All conflicts should be resolved. Can this PR be merged now, and should I close the PR?
Thanks @bunardsheng!
added typing IntervalClosedType where needed
State: closed

- [x] closes #48140  (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

@phofl 

Labels:
name: Interval
description: Interval data type
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
this is unrelated, minimum versions is sometimes flaky
thx @gmollard
REF: refactor ArrowExtensionArray._reduce
State: closed

Adds a `ArrowExtensionArray._reduce_pyarrow` method that returns a pyarrow scalar and makes `ArrowExtensionArray._reduce` get its pyarrow scalar from that and converts it there to a python scalar.

There are situations where we want to know the type of the value returned from pyarrow reductions (e.g. #52788)  and this allows us to get the pyarrow type.

This changes no functionality.

Labels:
name: Refactor
description: Internal refactoring of code
name: Arrow
description: pyarrow functionality

Comments:
Thanks @topper-123
Fix typo in future warning message
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Warnings
description: Warnings that appear or should be added to pandas

Comments:
This is only on 2.1, run into this in Dask
Thanks @phofl
call __finalize__ in DataFrame.eval with engine=numexpr
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

The goal here is to make progress on https://github.com/pandas-dev/pandas/issues/28283.


Labels:
name: metadata
description: _metadata, .attrs
name: expressions
description: pd.eval, query
name: Stale

Comments:
Thanks. Could you address the unit test failures?
Sure no problem, I will try to fix this problem 
@mroeschke Hi Mr.Roeschke, I have added a special judge when it is not DataFrame and does have attr `__finalize__`
Now `inplace` is and `engine` are involved to successfully call finalize
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Added version sorting on Web and Removed obsolete versions
State: closed

- [ ] closes #50885 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) 
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).



Labels:
name: Web
description: pandas website

Comments:
@datapythonista could you please review this?
@datapythonista could you please review my reply?
I still think that my implementation of creating `(version.parse(release["tag_name"]), release)` tuple is necessary, since the first serves as the key and the second is a dictionary object that can not be parsed directly. So do you mean that the first element in the tuple can be avoided by using lambda function in `sorted`? to save space? Thanks for your effort in advance.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Call __finalize__ in Dataframe.combine and Dataframe.combine_first
State: closed

- [x] resolves tasks in #28283 
- [x] remove not-implemented flag in tests


Labels:
name: metadata
description: _metadata, .attrs

Comments:
Here is my thought: In these two cases, I just let the attr from the first dataframe to propagate to the result. I think this is the most straightforward way and requires the least overhead. Let me know if this doesn't seem right. 
Thanks @jinlixiao
Fix Issue #52505
State: closed

github.com/pandas/issues/52505

- [X] closes #52505 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO CSV
description: read_csv, to_csv
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Fix string formatting
State: closed

- [x] closes #52690
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Output-Formatting
description: __repr__ of pandas objects, to_string
name: Stale

Comments:
I have added the requested changes
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
TST/CLN: Remove groupby.test_allowlist
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Followup to #52851 


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby
name: Clean

Comments:
thx @rhshadrach