BrandonFors/pandas-github-issues huggingface dataset:
DOC: add disallowing of Series construction of len-1 list with index to whatsnew
State: closed

Closes https://github.com/pandas-dev/pandas/issues/20391

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20392?src=pr&el=h1) Report
> Merging [#20392](https://codecov.io/gh/pandas-dev/pandas/pull/20392?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/699a48bcd71da54da05caee85e5d006afabc3df6?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20392/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/20392?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #20392      +/-   ##
==========================================
- Coverage   91.79%   91.77%   -0.03%     
==========================================
  Files         152      152              
  Lines       49205    49205              
==========================================
- Hits        45169    45157      -12     
- Misses       4036     4048      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.15% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.85% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20392?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/20392/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.07% <0%> (-1.74%)` | :arrow_down: |
| [pandas/core/resample.py](https://codecov.io/gh/pandas-dev/pandas/pull/20392/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzYW1wbGUucHk=) | `96.43% <0%> (ø)` | :arrow_up: |
| [pandas/core/strings.py](https://codecov.io/gh/pandas-dev/pandas/pull/20392/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3RyaW5ncy5weQ==) | `98.32% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20392?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20392?src=pr&el=footer). Last update [699a48b...a870f86](https://codecov.io/gh/pandas-dev/pandas/pull/20392?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
BUG: Handle all-NA blocks in concat
State: closed

Previously we special cased all-na blocks. We should only do that for
non-extension dtypes.

Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20382?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@13ae107`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20382/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/20382?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #20382   +/-   ##
=========================================
  Coverage          ?   91.79%           
=========================================
  Files             ?      152           
  Lines             ?    49184           
  Branches          ?        0           
=========================================
  Hits              ?    45148           
  Misses            ?     4036           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.17% <ø> (?)` | |
| #single | `41.83% <ø> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20382?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/internals.py](https://codecov.io/gh/pandas-dev/pandas/pull/20382/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzLnB5) | `95.54% <ø> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20382?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20382?src=pr&el=footer). Last update [13ae107...c12a24d](https://codecov.io/gh/pandas-dev/pandas/pull/20382?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lgtm.
The linting error was fixed on master: `pandas/_libs/tslibs/period.pyx:1358:12: W291 trailing whitespace`
remove NaN in categories checking
State: closed


- [ ] closes #20362
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Categorical
description: Categorical Data Type
name: Clean

Comments:
lgtm. ping on green. obviously we didn't have enough tests for this :<
thanks @almaleksia
DOC: ecosystem: Vaex, Pandas on Ray, alphabetization, pandas-datareader
State: closed

closes #20334 - Pandas on Ray
closes #20335 - Vaex

Labels:
name: Docs

Comments:
It might be worthwhile to also reference https://github.com/altair-viz/altair in the visualization section, since Vincent refers people to Altair: https://github.com/wrobstory/vincent#2016-06-18-update
Good call. #20355  "DOC: ecosystem.rst: Altair"
Pending a response to #20355, I'll go ahead and also alphabetize the Visualization Tools section and then this PR will be ready to merge.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20345?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@20ca108`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20345/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/20345?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #20345   +/-   ##
=========================================
  Coverage          ?   91.84%           
=========================================
  Files             ?      153           
  Lines             ?    49279           
  Branches          ?        0           
=========================================
  Hits              ?    45259           
  Misses            ?     4020           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.23% <ø> (?)` | |
| #single | `41.9% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20345?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20345?src=pr&el=footer). Last update [20ca108...94f0cdd](https://codecov.io/gh/pandas-dev/pandas/pull/20345?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you update
@westurner can you update
What needs to be updated here?
Rebased, thanks @westurner !
Preliminary format refactor
State: closed

The branch for the other PR was messed up, so I created a new one.

- [x] based on discussion here: https://github.com/pandas-dev/pandas/pull/20032#pullrequestreview-101917292
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

This PR splits the various formatters into different files so that it's easier to refactor a specific formatter. 

Labels:
name: Refactor
description: Internal refactoring of code
name: IO CSV
description: read_csv, to_csv
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap
name: IO LaTeX
description: to_latex

Comments:
lgtm. ping on green.
thanks @shangyian
TST: Parametrize dtypes tests - test_common.py and test_concat.py
State: closed

Parametrized some straightforward dtypes related tests.

Relatively minor changes to `test_common.py`:
  - mostly just extracted `for` loops
  - split one test into two separate tests (see code comment)

Made larger changes to `test_concat.py`:
  - removed the test class in favor of plain functions, since there was only one class in the file
  - combined a few different tests into a single test, since they were all using test procedure
      - removed the `check_concat` validation function since it's only called once now
      - further parametrized over a `for` loop previously in the  `check_concat` validation function
  - removed the `import pandas as pd` in favor of directly importing the necessary classes
      


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20340?src=pr&el=h1) Report
> Merging [#20340](https://codecov.io/gh/pandas-dev/pandas/pull/20340?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/3783ccc694ef93c0cf159ca1ad8e69a67d828bf0?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20340/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/20340?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #20340      +/-   ##
==========================================
- Coverage   91.76%   91.73%   -0.03%     
==========================================
  Files         150      150              
  Lines       49151    49151              
==========================================
- Hits        45102    45090      -12     
- Misses       4049     4061      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.12% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.9% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20340?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/20340/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.07% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20340?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20340?src=pr&el=footer). Last update [3783ccc...8933d34](https://codecov.io/gh/pandas-dev/pandas/pull/20340?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

made the requested changes
thanks @jschendel
BUG: xtick labels didn't work some times 
State: closed

use locally defined self._get_xticks instead of matplotlib default ax.get_xticks() 

actually fixes #18755  the other is unrelated


Labels:
name: Visualization
description: plotting

Comments:
Can you include a test to ensure this stays fixed? And is #18755 the right issue? At a glance, I don't see how this would fix it.
DOC: Formatting for DtypeWarning Docstring [ci skip]
State: closed

xref : https://github.com/pandas-dev/pandas/pull/20208

![fireshot capture 002 - pandas errors dtypewarning pandas 0_ - file____users_taugspurger_sandbox_](https://user-images.githubusercontent.com/1312546/37349929-958f175e-26a5-11e8-8c1e-872c2261c64f.png)

cc @jorisvandenbossche @hissashirocha

Labels:
name: Docs
name: IO Data
description: IO issues that don't fit into a more specific label
name: IO CSV
description: read_csv, to_csv

Comments:
Stiill have the issue with the warning going to stdout. Here's the tail of the validation script.

```
No warning was issued.

>>> import os
>>> os.remove('test.csv')
scripts/validate_docstrings.py:268: DtypeWarning: Columns (0) have mixed types. Specify dtype option on import or set low_memory=False.
  runner.run(test)

################################################################################
################################## Validation ##################################
################################################################################

Errors found:
        No returns section found
```
For the validation script I think it is not that much of a problem. But for pytest, I think we don't want to generally capture and silence the warnings, as there might be others raised in docstrings that we want to get notified of.
DOC: update the Index.get duplicates docstring
State: closed

Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):

- [x] PR title is "DOC: update the <your-function-or-method> docstring"
- [x] The validation script passes: `scripts/validate_docstrings.py <your-function-or-method>`
- [x] The PEP8 style check passes: `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] The html version looks good: `python doc/make.py --single <your-function-or-method>`
- [x] It has been proofread on language by another sprint participant

Please include the output of the validation script below between the "```" ticks:

```
################################################################################
################### Docstring (pandas.Index.get_duplicates)  ###################
################################################################################

Extract duplicated index elements.

Returns a sorted list of index elements which appear more than once in
the index.

Returns
-------
array-like
    List of duplicated indexes.

See Also
--------
Index.duplicated : Return boolean array denoting duplicates.
Index.drop_duplicates : Return Index with duplicates removed.

Examples
--------

Works on different Index of types.

>>> pd.Index([1, 2, 2, 3, 3, 3, 4]).get_duplicates()
[2, 3]
>>> pd.Index([1., 2., 2., 3., 3., 3., 4.]).get_duplicates()
[2.0, 3.0]
>>> pd.Index(['a', 'b', 'b', 'c', 'c', 'c', 'd']).get_duplicates()
['b', 'c']
>>> dates = pd.to_datetime(['2018-01-01', '2018-01-02', '2018-01-03',
...                         '2018-01-03', '2018-01-04', '2018-01-04'],
...                        format='%Y-%m-%d')
>>> pd.Index(dates).get_duplicates()
DatetimeIndex(['2018-01-03', '2018-01-04'],
              dtype='datetime64[ns]', freq=None)

Sorts duplicated elements even when indexes are unordered.

>>> pd.Index([1, 2, 3, 2, 3, 4, 3]).get_duplicates()
[2, 3]

Return empty array-like structure when all elements are unique.

>>> pd.Index([1, 2, 3, 4]).get_duplicates()
[]
>>> dates = pd.to_datetime(['2018-01-01', '2018-01-02', '2018-01-03'],
...                        format='%Y-%m-%d')
>>> pd.Index(dates).get_duplicates()
DatetimeIndex([], dtype='datetime64[ns]', freq=None)

################################################################################
################################## Validation ##################################
################################################################################

Docstring for "pandas.Index.get_duplicates" correct. :)

```

If the validation script still gives errors, but you think there is a good reason
to deviate in this case (and there are certainly such cases), please state this
explicitly.


Checklist for other PRs (remove this part if you are doing a PR for the pandas documentation sprint):

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Closed for conflict. See new PR: DOC: update the Index.get duplicates docstring #20322
DOC : Update the Period.second docstring
State: closed

```
# Period.second
############################################################################
####################### Docstring (pandas.Period.second) #######################
################################################################################

Get second of the minute component of the Period.

Returns
-------
int 
    The second as an integer, between 0 and 59.

See Also
--------
Period.hour : Get the hour component of the Period.
Period.minute : Get the minute component of the Period.

Examples
--------
>>> p = pd.Period("2018-03-11 13:03:12.050000")
>>> p.second
12

################################################################################
################################## Validation ##################################
################################################################################
```

Labels:
name: Docs
name: Period
description: Period data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20319?src=pr&el=h1) Report
> Merging [#20319](https://codecov.io/gh/pandas-dev/pandas/pull/20319?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/31afaf858604ab85665b54b92f40cef19d69a28d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20319/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/20319?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #20319   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         150      150           
  Lines       49165    49165           
=======================================
  Hits        45099    45099           
  Misses       4066     4066
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.11% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20319?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20319?src=pr&el=footer). Last update [31afaf8...2188f80](https://codecov.io/gh/pandas-dev/pandas/pull/20319?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lgtm
Thanks @WillAyd 
Thanks!
thanks
Doc : update the pandas.Period.minute docstring
State: closed

# Period.minute
################################################################################
####################### Docstring (pandas.Period.minute) #######################
################################################################################

Get minute of the hour component of the Period.

Returns
-------
int 
    The minute as an integer, between 0 and 59.

See Also
--------
Period.hour : Get the hour of the Period.
Period.second : Get the second of the Period.

Examples
--------
>>> p = pd.Period("2018-03-11 13:03:12.050000")
>>> p.minute
3

################################################################################
################################## Validation ##################################
################################################################################


Labels:
name: Docs

Comments:
@HimanshuAwasthi95 Thanks a lot!
thanks @jorisvandenbossche
DOC : Update the pandas.Period.hour docstring
State: closed

```
# Period.hour
################################################################################
######################## Docstring (pandas.Period.hour) ########################
################################################################################

Get hours of a day that a Period falls on.

Returns
-------
int

See Also
--------
Period.minute : Get the minute of hour
Period.second : Get the second of hour

Examples
--------
>>> p = pd.Period("2018-03-11 13:03:12.050000")
>>> p.hour
13

################################################################################
################################## Validation ##################################
################################################################################
```

Labels:
name: Docs

Comments:
Thanks @HimanshuAwasthi95 !
thanks @TomAugspurger
COMPAT: Ascii example
State: closed

Py2 issues:

```
pytest -m single -r xX --junitxml=/tmp/single.xml --strict --only-slow --skip-network pandas
Traceback (most recent call last):
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/site-packages/_pytest/config.py", line 366, in _importconftest
    mod = conftestpath.pyimport()
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/site-packages/py/_path/local.py", line 668, in pyimport
    __import__(modname)
  File "/home/travis/build/pandas-dev/pandas/pandas/__init__.py", line 45, in <module>
    from pandas.core.api import *
  File "/home/travis/build/pandas-dev/pandas/pandas/core/api.py", line 10, in <module>
    from pandas.core.groupby import Grouper
  File "/home/travis/build/pandas-dev/pandas/pandas/core/groupby.py", line 45, in <module>
    from pandas.core.index import (Index, MultiIndex,
  File "/home/travis/build/pandas-dev/pandas/pandas/core/index.py", line 2, in <module>
    from pandas.core.indexes.api import *
  File "/home/travis/build/pandas-dev/pandas/pandas/core/indexes/api.py", line 1, in <module>
    from pandas.core.indexes.base import (Index,
  File "/home/travis/build/pandas-dev/pandas/pandas/core/indexes/base.py", line 1537
SyntaxError: Non-ASCII character '\xc3' in file /home/travis/build/pandas-dev/pandas/pandas/core/indexes/base.py on line 1538, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
ERROR: could not load /home/travis/build/pandas-dev/pandas/pandas/conftest.py
```



Labels:
name: Docs

Comments:
Test collection succeeded on https://travis-ci.org/pandas-dev/pandas/jobs/352488613 Merging since this is breaking master right now.