BrandonFors/pandas-github-issues huggingface dataset:
fix isin method for series
State: closed

- [X] closes #43460 (Replace 43460 with the GitHub issue number)
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Stale
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks for the PR @nvanommeren and @sophievdberg! The CI caught some errors which I think you can solve locally if you run pre-commit. Let us know if you need help.
Thanks @noatamir, fixed some small problems. There are still quite some tests failing in `pandas/tests/computation/test_eval.py::TestEval::test_simple_cmp_ops` - just to check: should we update these tests as well?
Yeah `Series.isin(df)` should raise IMO
Thx! @nvanommeren Could you update the tests?
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Fixed literal typing in rank and resample methods
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


@phofl @noatamir @jorisvandenbossche 

Labels:
name: Typing
description: type annotations, mypy/pyright type checking
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks @maanijou!
TST: Add non-regression test for GH-33828
State: closed

- [X] closes #33828
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks @ArnaudChanoine
Using Literal["a"] instead of str in generic.py
State: closed

Specifies limit_area in interpolate and how in asfreq more precisely.

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Typing
description: type annotations, mypy/pyright type checking
name: Sprints
description: Sprint Pull Requests

Comments:
Worked on [issue 10](https://github.com/noatamir/pydata-workshop/issues/10) for the following points:

* Specify limit_area in interpolate  more precisely
* Specify how in asfreq  more precisely

Please review the code: @phofl, @noatamir, @jorisvandenbossche, @MarcoGorelli 
conflict resolved.
Thanks @kevx82 !
Regression tests to cover reset_index issue
State: closed

- [x] closes #38147
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
@phofl
Thanks @vagechirkov
GH31581 adding regression test
State: closed

- [x] closes #31581 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Worked on during the PyData workshop with @DrorBendet and @sven-simonsen. Tagging @phofl @noatamir @jorisvandenbossche @MarcoGorelli as reviewers.


Labels:
name: Needs Tests
description: Unit test(s) needed to prevent regressions
name: Sprints
description: Sprint Pull Requests

Comments:
Could you resolve the merge conflict?
> Could you resolve the merge conflict?

resolved.
Thx @corriebar
TST .drop() doesn't parse strings for DatetimeIndex
State: closed

- [X] closes https://github.com/pandas-dev/pandas/issues/5355
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Labels:
name: Needs Tests
description: Unit test(s) needed to prevent regressions
name: Sprints
description: Sprint Pull Requests

Comments:
Linking reviewers: @phofl @noatamir @jorisvandenbossche @MarcoGorelli
TST: Test column names underscore
State: closed

…

- [x] closes #23848 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks @ruaultadrien 
Thanks to you 🥳
DOC: Remove incorrect indexing doc sentence
State: closed

- [X] closes #46440
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks @shteken
Doc: fixed missing behavior explaination of sort=false for groupby issue #47529
State: closed

- [x] closes #47529 
- [x] All code checks passed

Changes were made by @hubschne and @raanasn at the python conference 2023 Berlin workshop


Labels:
name: Docs
name: Sprints
description: Sprint Pull Requests

Comments:
Reviewer suggestions: @phofl, @noatamir, @jorisvandenbossche and @marcogorelli
Thanks @raanasn!
DOC: Additions to documentation #47282
State: closed

Added a short paragraph on Series and Dataframes in the "10 minutes to pandas" documentation.
Documentation page was built successfully.

- [x] closes #47282

Additional Contributors: @MA-Ramirez

Reviewers: @phofl @noatamir @jorisvandenbossche @MarcoGorelli 

Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: Add small userguide example on how to use arrow dtype backend in read_parquet
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: IO Parquet
description: parquet, feather
name: Sprints
description: Sprint Pull Requests

Comments:
thx @YYYasin19
Columns not added in empty dataframe
State: closed

- [x] closes #28871 (Replace 28871 with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Working with @klaas-dev

@phofl, @noatamir, @jorisvandenbossche, and @MarcoGorelli 

Labels:
name: Stale
name: Sprints
description: Sprint Pull Requests

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: Add example for to_html
State: closed

- [x] closes #44945 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

@phofl @noatamir @jorisvandenbossche @MarcoGorelli 

Labels:
name: Stale
name: Sprints
description: Sprint Pull Requests

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Regression test for dt.total_seconds()
State: closed

- [x] closes #48521
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
@phofl
Thanks @vagechirkov
Literal typing for indexer methods
State: closed

- [ ] closes https://github.com/noatamir/pydata-workshop/issues/11 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


😄 
@phofl @noatamir @jorisvandenbossche @marcogorelli



Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks @emptymalei!
Thank you @twoertwein
TST: Added test on dataframe constructor with None 
State: closed

- [x] closes #32218 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

This test should cover what happened in issue #32218.

@phofl @noatamir @jorisvandenbossche @MarcoGorelli 

Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks @Gramet
TYP: replaced IntervalClosedType to IntervalInclusiveType
State: closed

- [x] closes #48140  (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
@phofl, @noatamir, @jorisvandenbossche, @MarcoGorelli
add: literal type hints for methods in NDFrame
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks @YYYasin19
TYP: Narrow down type of method keyword in Index
State: closed

This PR narrows down the type of the `method` keyword, used in two methods of the class `Index` to exactly the permitted values via the use of `Literal`.

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
@phofl @noatamir @jorisvandenbossche @MarcoGorelli PyData workshop
Any suggestions on how to proceed with `clean_reindex_fill_method` and `clean_fill_method`?
Didn't see that mypy failed:

> pandas/core/indexes/base.py:3749: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "Optional[Literal['pad', 'ffill', 'backfill', 'bfill', 'nearest']]")  [assignment]

You might be able to change the signature of `clean_reindex_fill_method` or add an ignore comment.
Yep you can change the signature as well
@phofl @twoertwein 
Sorry about the delay!

The mypy/typing problem seems to be resolved, yet one unit tests is failing. Could it be that it's flaky? I haven't been able to deduce much from the error message.
Thank you @kklein !
DEPR: Series.ravel
State: closed

- [ ] closes #52511 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Stale
name: Sprints
description: Sprint Pull Requests

Comments:
I'll have to take a closer look here, looks like we are using this internally. Will get to this over the weekend. pr itself is good!
Thanks for your answer, Should I replace the internal usage of this function ? 
I'll have to check what we are doing before I can give you a definitiv answer here
One place where we use `ravel()` internally that seems to cause many of the failures is in `maybe_downcast_numeric`:

https://github.com/pandas-dev/pandas/blob/961f9c4d7899121669c4832512c5903db573bb47/pandas/core/dtypes/cast.py#L348-L355

Changing `r = result.ravel()` to `r = np.ravel(result)` might be sufficient (assuming this won't dispatch to the method), or otherwise `r = np.asarray(result).ravel()` (we know at this point we have a numpy dtyped Series, so `np.asarray(..)` is cheap)

In theory we should not call this method with a Series though, but with an array (or, the type annotation is wrong)
> Thanks for your answer, Should I replace the internal usage of this function ?

Yes.

> In theory we should not call this method with a Series though, but with an array (or, the type annotation is wrong)

Agreed.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
add: type hints to sort_values
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number) // there is no existing issue for this currently
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks @YYYasin19!
ENH: Better dtype inference for reductions on dataframes
State: closed

- [x] closes #40669 (and probably others, I will check later)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I think the code itself is ready for review, but this needs more tests, and just checking now if the CI raises anything unexpected.

Labels:

Comments:
xref #52261
Superceeded by https://github.com/pandas-dev/pandas/pull/52788, closing.
Return dtype with appropriate resolution in DatetimeTZDtype.base
State: closed

- [x] closes https://github.com/pandas-dev/pandas/issues/52705 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timezones
description: Timezone data dtype
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
Thanks @shwina
TST: setitem preserving period[D] dtype
State: closed

- [X] closes #39763 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks @srkds 
Thanks @mroeschke and @jbrockmendel for review ❤😀