BrandonFors/pandas-github-issues huggingface dataset:
REF: de-duplicate nested-dict handling in DataFrame construction
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

This was the motivation for #41707.  This will introduce some overhead, but will also prevent the behaviors from getting out of sync again.

Labels:
name: Refactor
description: Internal refactoring of code
name: Clean

Comments:
oh i like this!
This might have caused a big slowdown in one of the benchmarks: https://pandas.pydata.org/speed/pandas/#frame_ctor.FromDicts.time_nested_dict_int64?python=3.8&Cython=0.29.21

@jbrockmendel can you verify this?
That looks plausible; noted in the OP we'd take a perf hit in these cases
Yes, but "some overhead" turns out to be a 6x slowdown. 
So then having the cython implementation (and the added effort of ensuring it is kept in sync) might be worth it.
do you have anything in particular in mind?  could revert until after the release
I didn't follow the original context, but IIUC, this PR didn't "fix" anything, correct? (like a bug) But it did remove a faster cython implementation to reduce maintenance cost in the idea the added overhead would only be small?

If that's the case, and the overhead actually turns out to be not so small (6x according to the benchmark), then it's a tradeoff we need to make: do we find the speed worth it to maintain the cython implementation. 
*If* we say yes to that, then yes I suppose this means to revert the PR; but it would not be only until after the release (not sure what the point of that would be).
> I didn't follow the original context, but IIUC, this PR didn't "fix" anything, correct? (like a bug) But it did remove a faster cython implementation to reduce maintenance cost in the idea the added overhead would only be small?

This context is that this follows #41707, which did fix a bug in the Series constructor that didn't affect DataFrame construction because they had separate implementations.
I opened https://github.com/pandas-dev/pandas/issues/42248 to keep track of this regression.
BUG: Series.loc[-1] with UInt64Index
State: closed

- [x] closes #41775
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
can you rebase
nice!
REF: Simplify Index.union
State: closed

This is the `Index.union` part of #41153. This helps simplify that PR.

The special casing in `Index.union` is currently active if both are numeric. After #41153 it should only be special cased if one dtype is uint64 and other a signed int. So after this and #41153:
* int8 & uint32 -> int64
* [u]int64 & float64 -> float64
* int64 & uint64 -> object
* int8 & uint64 -> object

The first and second case is handled correctly by `find_common_type`, but the others aren't currently.

This PR changes no functionality itself, but prepares for the changes in #41153, where we want e.g. `NumericIndex[int8] .union(NumericIndex[uint32])` to give `NumericIndex[int64]` and not `Index[object]`.

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Index
description: Related to the Index class or subclasses

Comments:
I’ve updated to find_common_type_compat.
looks fine can you rebase
@topper-123 ping when ready here (then @jbrockmendel can rebase other)
I’ve rebased.
thanks @topper-123
DEPR: DataFrame(floaty, dtype=inty) match Series
State: closed

- [ ] closes #xxxx
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

xref #40110, though we may still deprecate the Series behavior too, in which case we'll need to update the deprecation message here

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Deprecate
description: Functionality to remove in pandas

Comments:
looks fine. some checks are failing
release note?
hmm ci/checks failing, someting on the asvs?
and pls rebase
something failing on ci/ checks
https://github.com/pandas-dev/pandas/pull/41770/checks?check_run_id=2732581481 is in the asv benchmarks
BUG: Improve memory usage with openpyxl
State: closed

- [x] closes #41681
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them


Labels:
name: Performance
description: Memory or execution speed performance
name: IO Excel
description: read_excel, to_excel
name: Stale

Comments:
Hello @jordanrmerrick! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-09-09 18:56:54 UTC
The above commit won't work right now, I'm just adding it so the progress is visible. I still need to change how the cells are styled before it should work.
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
@jordanrmerrick Friendly ping to see if you're interested in continuing this PR.
Thanks for the contribution, but it appears this PR has gone stale. Closing due to inactivity but if you're interested in continuing we would be happy to reopen.
> Thanks for the contribution, but it appears this PR has gone stale. Closing due to inactivity but if you're interested in continuing we would be happy to reopen.

Hello, unfortunately I had to take an extended hiatus from pretty much all my personal coding work. I'm thankfully able to pick it up again, and this is a big priority of mine! 

If you're able to reopen this PR, I would appreciate it. I'll be working on this PR consistently.
Hi, posting some updates here: 

I'm still working on this, but progress has been slow. The way `write_only` workbooks work is causing complications with how to add styles (fonts, colors, etc.) to cells in a way that works with the existing methods in Pandas' code. Merged cells are also proving to be quite tricky. 

It's taking so long to add to this because I think I'm going to have to rewrite a lot of Pandas' implementation of openpyxl and I'm trying to plan it out beforehand. Sorry about that! I should be pushing ~some~ code in the next day or so.
closing as stale but ping if you want to continue
Backport PR #41443 on branch 1.2.x (Revert "Pin fastparquet to leq 0.5.0")
State: closed

Backport PR #41443: Revert "Pin fastparquet to leq 0.5.0"

Labels:
name: Dependencies
description: Required and optional dependencies

Comments:
closing for now. https://github.com/pandas-dev/pandas/pull/41443#issuecomment-852193474
Backport PR #41730: CI: suppress npdev warnings
State: closed

Backport PR #41730

Labels:
name: CI
description: Continuous Integration
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
It would be nice to get ci green on 1.2.x but not needed for release. Could merge this as is to reduce the number of errors on npdev env considerably and maybe look at the other errors separately.

The 2 test fails are just error messages so could be easily changed (here or followup).

The setup errors that do not fail on master are due to some recent changes on master for maybe_infer_to_datetimelike, so we won't be backporting those. I think we could maybe filter the warnings differently and that may work in the setup phase too. will look soon.


sure merge as needed (or ping me if u want review)
@jreback green (except circle CI, would either need to backport configuration file or change config on master to not run on branches)
ignore circle
DO NOT MERGE: test-backportability-of-#41711
State: closed

xref #41711

Labels:

Comments:
Hello @simonjayhawkins! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:









There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-06-01 11:01:21 UTC
TYP: to_numpy
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
> Thanks @jbrockmendel Is this not covered by one of @Dr-Irv PRs?

I haven't done `to_numpy()` yet, but in #41251 I changed the definition of `NpDtype` based on a suggestion by @simonjayhawkins  so I would suggest getting that approved before approving this one.
if this is handled elsewhere we can just close it
DOC: collect positional deprecations, remove duplicate DateOffset methods
State: closed

The DateOffset duplication is discussed in #41586.  docbuild is segfaulting locally (independent of this PR), so will have to see if this works on the CI.

Labels:
name: Docs
name: Frequency
description: DateOffsets

Comments:
@jorisvandenbossche this is spitting out a bunch of warnings like `/home/runner/work/pandas/pandas/doc/source/reference/api/pandas.tseries.offsets.YearBegin.rule_code.rst: WARNING: document isn't included in any toctree` ideas on how to handle these?
if can revist after we merge #41586
REF: remove unnecessary try/excepts
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Refactor
description: Internal refactoring of code

Comments:
sounds ok to me.
looks like needs a rebase
ENH: Improve error message in corr/cov for Rolling/Expanding/EWM when other isn't a DataFrame/Series
State: closed

- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Also some internal method cleanups

Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Window
description: rolling, ewma, expanding

Comments:
thanks @mroeschke
CLN: Remove old docs README
State: closed

Not sure why a README was created under `docs` in the first place. But having a docs/README that instead of having docs related information, just points to the contributing page, doesn't seem very useful, since the main README is already providing better information on how to contribute.

And in any case, the link in that README file is very old.

Labels:
name: Docs
name: Clean

Comments:
thanks @datapythonista
DEPR: ignoring dtype in DataFrame constructor failures
State: closed

- [x] closes #24435
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Constructors
description: Series/DataFrame/Index/pd.array Constructors

Comments:
great can you add a deprecation note
whatsnew added + green
[ArrowStringArray] ENH: raise an ImportError when trying to create an arrow string dtype if pyarrow is not installed
State: closed

xref https://github.com/pandas-dev/pandas/pull/39908#discussion_r585581525

Labels:
name: Strings
description: String extension data type and string data

Comments:
this ok before #39908 ? @simonjayhawkins 
> this ok before #39908 ? @simonjayhawkins

either, conflicts either way. (just wanted to keep this change separate) 


thanks @simonjayhawkins
CI: suppress npdev warnings
State: closed

Let's try this again

Labels:
name: CI
description: Continuous Integration
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
great!
we see errors on 1.2.x. let's see is this backports.

@meeseeksdev backport 1.2.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.2.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 505abc1c2617561e80d6926bc48bf4275fd6815c
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #41730: CI: suppress npdev warnings'
```

4. Push to a named branch :

```
git push YOURFORK 1.2.x:auto-backport-of-pr-41730-on-1.2.x
```

5. Create a PR against branch 1.2.x, I would have named this PR:

> "Backport PR #41730 on branch 1.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
TYP: tighten types in core.construction
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Clean
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
lgtm. pls rebase and ping on green.
i think the 32-bit patch fixes these failed builds ?
> i think the 32-bit patch fixes these failed builds ?

it should yes
REF: more explicit dtypes in strings.accessor
State: closed

Experimenting with #40489 I found that making Series inference behavior more like Index behavior broke a bunch of strings tests.  This makes the strings code robust to that potential change by being more explicit about dtypes.

Labels:
name: Refactor
description: Internal refactoring of code
name: Strings
description: String extension data type and string data

Comments:
@simonjayhawkins was right, it was possible to remove the returns_bool keyword; green
DOC: Updates Index.any docstring from #40362
State: closed

- [ ] closes #40362: add an introduction to all() function as described in "See also"
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Docs
name: Stale

Comments:
@simonjayhawkins 
> I think my preference would be to delete the any examples from the all method docstring.
> If we are adding as here, can we shares the examples instead to make them consistent.

Can I just commit the deleted example as well as the one I added this time?
Or should I submit a new pull request?
> Or should I submit a new pull request?

you can push changes to the same PR as it's the same issue.

@simonjayhawkins 

I'll commit this week.

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
@Beluuuuuuga is this still active?
> @Beluuuuuuga is this still active?

Sorry for the delay. I'll do it tomorrow.
sure, no hurry
Thanks for the PR, but it appears to have gone stale. Closing due to inactivity but feel free to push updates to your branch and when you're ready for another review we can reopen.
TST: Check map function works with StringDtype (#40823)
State: closed

Checks map function output on 2 DataFrames with data type StringDtype.

- [ ] closes #40823
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Strings
description: String extension data type and string data

Comments:
thanks @mdhsieh
Fix DataFrame.agg produces different types if the DataFrame is empty
State: closed

- [ ✔] closes https://github.com/pandas-dev/pandas/issues/41672
- [ ❌] tests added / passed
- [ ❌] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them



Labels:
name: Stale
name: Reduction Operations
description: sum, mean, min, max, etc.

Comments:
Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-05-30 01:26:58 UTC
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
Thanks @weikhor for the PR. can you add a release note to doc/source/whatsnew/v1.3.1.rst, Bug fixes section and address https://github.com/pandas-dev/pandas/pull/41722#discussion_r642685684
Thanks for the PR, but it appears this has gone stale and needs addressing of the reviews. Closing, but happy to reopen if still interested.
Improve Development Accesibility - Devcontainer [part 1 / 2]
State: closed

## Whats new 
This PR introduces some changes that improve the development experience via VSCode's devcontainers. Specifically:
* It removes the cloning of the pandas repo inside the container (it assumes that the user already cloned it on the host) and instead leverages the fact the the code is mounted to `/workspaces/pandas`.
* Defines the conda env inside the workspace itself such that it can be reused even when the container is deleted. This enables you to use the codebase outside the repo afterwards if you activate the same local conda env.
* Splits the previous `Dockerfile` in two: a simplified `Dockerfile` + a new `container_create.sh` that only runs the first time the container starts, making it possible to install the dependencies inside the workspace.


Labels:
name: Build
description: Library building on various platforms
name: Stale

Comments:
In the next PR I want to add support for Gitpod which is a nice way to develop when you don't have access to your PC.
cc @fangchenli @datapythonista @WillAyd 
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
Closing this, since there is no agreement on moving forward, and it didn't have any progress for couple of months.
Hey @jreback and @datapythonista!
Sorry for the haitus, I got some time again and will be trying to move this forward.
DEPR: Deprecated passing arguments as positional in pd.concat
State: closed

- [x] xref #41485
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Deprecate
description: Functionality to remove in pandas

Comments:
Hello @tegardp! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:











There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-06-06 11:25:15 UTC
can you rebase; this appears to have a read_table change (already merged) so need to remove that
@tegardp if you can update
> @tegardp if you can update

sorry i'm still confused about rebase workflow
> > @tegardp if you can update
> 
> sorry i'm still confused about rebase workflow

that is now sorted in https://github.com/pandas-dev/pandas/pull/41718/commits/d9b371252f1e8e4ae7acc812d25eb7b5080efbf0,

comments https://github.com/pandas-dev/pandas/pull/41718#discussion_r643799672 and https://github.com/pandas-dev/pandas/pull/41718#discussion_r643811201 to be addressed. will fix test and lint failures on ci
> comments [#41718 (comment)](https://github.com/pandas-dev/pandas/pull/41718#discussion_r643799672) and [#41718 (comment)](https://github.com/pandas-dev/pandas/pull/41718#discussion_r643811201) to be addressed. will fix test and lint failures on ci

tests are still failing... see https://github.com/pandas-dev/pandas/pull/41718#discussion_r643799672
you need to change any existing test which uses positional args to avoid the warnings.
https://github.com/pandas-dev/pandas/pull/41718/checks?check_run_id=2747849764 one failed test
thanks @tegardp
CLN: Deprecate non-keyword arguments in read_table #41485
State: closed

- [x] xref #41485
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: IO CSV
description: read_csv, to_csv
name: Deprecate
description: Functionality to remove in pandas

Comments:
Hello @tegardp! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-05-29 21:40:33 UTC
thanks @tegardp
Fix inconsistent results for empty datasets describe 
State: closed

- [✔ ]  closes https://github.com/pandas-dev/pandas/issues/41575
- [ ✔]  tests added / passed
- [✔ ]  Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them




Labels:
name: Bug
name: Groupby
name: Stale

Comments:
Hi @jreback This PR is about fixing https://github.com/pandas-dev/pandas/issues/41575. Thank
this currently fails on master right?
Hello @weikhor! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

* In the file [`pandas/core/groupby/generic.py`](https://github.com/pandas-dev/pandas/blob/69ea1cd23f457be4c9c3b013f3891b306d4c0607/pandas/core/groupby/generic.py):

> [Line 1864:36](https://github.com/pandas-dev/pandas/blob/69ea1cd23f457be4c9c3b013f3891b306d4c0607/pandas/core/groupby/generic.py#L1864): [W292](https://duckduckgo.com/?q=pep8%20W292) no newline at end of file

* In the file [`pandas/tests/groupby/test_function.py`](https://github.com/pandas-dev/pandas/blob/69ea1cd23f457be4c9c3b013f3891b306d4c0607/pandas/tests/groupby/test_function.py):

> [Line 1210:1](https://github.com/pandas-dev/pandas/blob/69ea1cd23f457be4c9c3b013f3891b306d4c0607/pandas/tests/groupby/test_function.py#L1210): [E302](https://duckduckgo.com/?q=pep8%20E302) expected 2 blank lines, found 1



##### Comment last updated at 2021-06-08 16:24:04 UTC
> this currently fails on master right?
Yes

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
Thanks for the PR, but it appears that this has gone stale and needs to address the reviews. Closing due to inactivity but happy to reopen if you're interested in continuing.