DOC: Bump fastparquet version
State: closed

Should we just bump the min version to 0.2.1? It's quite new, but I think reading datetime data is somewhat common :) It'll save us bug reports. 

Labels:
name: Docs
name: IO Parquet
description: parquet, feather

Comments:
cc @jorisvandenbossche this fixes the doc error you were seeing.
> Should we just bump the min version to 0.2.1? It's quite new, but I think reading datetime data is somewhat common :) It'll save us bug reports.

Yeah, maybe that is best ..
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=h1) Report
> Merging [#24590](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/db051b94d50cec2a5f2a160b36d67716c47839c7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/24590/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #24590   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         166      166           
  Lines       52497    52497           
=======================================
  Hits        48489    48489           
  Misses       4008     4008
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.79% <ø> (ø)` | :arrow_up: |
| #single | `43.04% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=footer). Last update [db051b9...e9f7841](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=h1) Report
> Merging [#24590](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/19f715c51d16995fc6cd0c102fdba2f213a83a0f?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/24590/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #24590      +/-   ##
==========================================
+ Coverage   92.37%   92.38%   +<.01%     
==========================================
  Files         166      166              
  Lines       52396    52395       -1     
==========================================
  Hits        48403    48403              
+ Misses       3993     3992       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.8% <100%> (-0.01%)` | :arrow_down: |
| #single | `43% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/parquet.py](https://codecov.io/gh/pandas-dev/pandas/pull/24590/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnF1ZXQucHk=) | `84.61% <100%> (ø)` | :arrow_up: |
| [pandas/core/indexes/period.py](https://codecov.io/gh/pandas-dev/pandas/pull/24590/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9wZXJpb2QucHk=) | `92.06% <0%> (-0.06%)` | :arrow_down: |
| [pandas/core/resample.py](https://codecov.io/gh/pandas-dev/pandas/pull/24590/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzYW1wbGUucHk=) | `97.23% <0%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/24590/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `88.09% <0%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=footer). Last update [19f715c...d1e0098](https://codecov.io/gh/pandas-dev/pandas/pull/24590?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> is this only for docs? may have to update the parquet doc section as well.

For now, this PR is only about the doc build. But if the suggestion of Tom is followed to bump the fastparquet version, we should also update the docs (although, if we decide to not nump the minimum version, we should maybe still mention that for datetime data, the latest version is required)

> For now, this PR is only about the doc build. But if the suggestion of Tom is followed to bump the fastparquet version, we should also update the docs (although, if we decide to not nump the minimum version, we should maybe still mention that for datetime data, the latest version is required)

then pls do this here
I've made the changes to bump the min version to 0.2.1 locally, but I think there's an issue with the conda-forge package. Going to fix that before pushing again.
why are you bumping for parquet reading? (we had already bumped for this release I think).
In the discussion above, Joris and I (and I thought you) agreed that reading datetimes is important enough to bump the minimum required first.

On master, we allow using fastparquet <0.2.1, but that will fail at runtime if trying to read a datetimetz column.

The proposal is to require fastparquet>=0.2.1
its fine. we don't usually bump up this fast, but ok.
but would need to change the tests & docs
https://github.com/pandas-dev/pandas/pull/24590#issuecomment-451216152

but fixing the CF package first.
> but fixing the CF package first.

what is this?
CF=conda-forge. There was an issue with the 0.2.1 build:
https://github.com/conda-forge/fastparquet-feedstock/pull/21

On Thu, Jan 3, 2019 at 11:45 AM Jeff Reback <notifications@github.com>
wrote:

> but fixing the CF package first.
>
> what is this?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/24590#issuecomment-451221152>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHInnlsa-_-fi0B86YQOiGGd-c3vAQks5u_kGhgaJpZM4ZoEzZ>
> .
>

ahh ok
ok merge ok then
merge?
No , the problem is not yet fixed (see the doc build log on travis)

Possibly due the conda-forge package problem? (@TomAugspurger the conda list output indicates it installed fastparquet 0.2.1 from conda-forge, but then the error is still there and the `pd.sho_versions()` gives fastparquet 0.1.6 ...)
ok cool.
The fastparquet 0.2.1 conda-forge package was accidentally packaging 0.1.6 (but labeling it as 0.2.1), so the error persisted.

The linux builds for a corrected fastparquet are just finishing now. I'll clean up my version bump and push.
Some travis builds are failing (didn't check why), but just checked that the doc build is now working (the error is gone)
The travis build is failing because not all the conda packages are done building. Some are still pulling in the (bad) 0.2.1 fastparquet. Conda install the bad 0.2.1, but then `fastparquet.__version__` is 0.1.6 (so we know that code works at least).

I'll let those finish up before pushing again (with the dev env update).
FYI, conda-forge stopped building packages for Python 3.5 on MacOS, so I've removed fastparquet from that env.
thanks!