BrandonFors/pandas-github-issues huggingface dataset:
transition period_helper to use pandas_datetimestruct
State: closed

In the last round we transitioned period.pyx to use pandas_datetimestruct instead of date_info.  This does the same thing for period_helper.

Labels:
name: Period
description: Period data type
name: Clean

Comments:
lgtm. ping on green.
actually, any doc-strings to update?
> actually, any doc-strings to update?

The affected docstrings are already updated.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19918?src=pr&el=h1) Report
> Merging [#19918](https://codecov.io/gh/pandas-dev/pandas/pull/19918?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9958ce68a19477721d2ba53bde2b17bb52ebebaa?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19918/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19918?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19918      +/-   ##
==========================================
+ Coverage   91.66%   91.68%   +0.02%     
==========================================
  Files         150      150              
  Lines       49026    49026              
==========================================
+ Hits        44939    44951      +12     
+ Misses       4087     4075      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.06% <ø> (+0.02%)` | :arrow_up: |
| #single | `41.83% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19918?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19918/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19918?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19918?src=pr&el=footer). Last update [9958ce6...e16dd3e](https://codecov.io/gh/pandas-dev/pandas/pull/19918?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

you need to rebase on master
Ping
thanks!
DOC fix incorrect example in DataFrame.to_dict docstring. Close GH19868
State: closed

- [x] closes #19868 
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] What's new: Fix incorrect example


Labels:
name: Docs

Comments:
thanks! good thing we don't have doc-string tests ATM!
BUG: Adding skipna as an option to groupby cumsum and cumprod
State: closed

- [x] closes #19806
- [x] tests added in `test_groupby.py`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

This handles #19806 by adding skipna as an option to both `cumsum` and `cumprod` after groupby. I'm assuming that default behavior is what is described in the docs, with skipna=True. 

Labels:
name: Groupby
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
Hello @shangyian! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on March 01, 2018 at 23:13 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19914?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@072545d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19914/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19914?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19914   +/-   ##
=========================================
  Coverage          ?   91.68%           
=========================================
  Files             ?      150           
  Lines             ?    49026           
  Branches          ?        0           
=========================================
  Hits              ?    44951           
  Misses            ?     4075           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.06% <100%> (?)` | |
| #single | `41.83% <0%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19914?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby.py](https://codecov.io/gh/pandas-dev/pandas/pull/19914/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS5weQ==) | `92.14% <100%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19914?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19914?src=pr&el=footer). Last update [072545d...3072df7](https://codecov.io/gh/pandas-dev/pandas/pull/19914?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
DOC: update install.rst to include ActivePython distribution
State: closed

PR associated with [Issue #19845](https://github.com/pandas-dev/pandas/issues/19845#issuecomment-367879282): update Installation webpage to include ActivePython distribution 

per @jreback 

- [ ] closes #19845
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19908?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@e6c7dea`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19908/graphs/tree.svg?src=pr&width=650&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19908?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19908   +/-   ##
=========================================
  Coverage          ?   91.68%           
=========================================
  Files             ?      150           
  Lines             ?    48969           
  Branches          ?        0           
=========================================
  Hits              ?    44898           
  Misses            ?     4071           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.06% <ø> (?)` | |
| #single | `41.85% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19908?src=pr&el=footer). Last update [e6c7dea...24eff5b](https://codecov.io/gh/pandas-dev/pandas/pull/19908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @Dr-G 

should be built in a few hours: http://pandas-docs.github.io/pandas-docs-travis/install.html
DOC: small typo fix
State: closed

"functionaility" -> "functionality"

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19901?src=pr&el=h1) Report
> Merging [#19901](https://codecov.io/gh/pandas-dev/pandas/pull/19901?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/92dbc78af9f34af83691d86347fc04d2c543b94c?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19901/graphs/tree.svg?src=pr&width=650&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19901?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19901   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files         150      150           
  Lines       48938    48938           
=======================================
  Hits        44860    44860           
  Misses       4078     4078
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.04% <ø> (ø)` | :arrow_up: |
| #single | `41.81% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby.py](https://codecov.io/gh/pandas-dev/pandas/pull/19901/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS5weQ==) | `92.31% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19901?src=pr&el=footer). Last update [92dbc78...dd5804b](https://codecov.io/gh/pandas-dev/pandas/pull/19901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
DOC: fix numpydoc section titles in misc plotting docstrings
State: closed


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19899?src=pr&el=h1) Report
> Merging [#19899](https://codecov.io/gh/pandas-dev/pandas/pull/19899?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/8f1dfa74e244622a7f356a496072f93dce032839?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19899/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/19899?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19899      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files         150      150              
  Lines       48936    48938       +2     
==========================================
  Hits        44860    44860              
- Misses       4076     4078       +2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.04% <ø> (-0.01%)` | :arrow_down: |
| #single | `41.81% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19899?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_misc.py](https://codecov.io/gh/pandas-dev/pandas/pull/19899/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19taXNjLnB5) | `38.98% <ø> (ø)` | :arrow_up: |
| [pandas/core/dtypes/cast.py](https://codecov.io/gh/pandas-dev/pandas/pull/19899/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL2Nhc3QucHk=) | `87.68% <0%> (-0.3%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19899?src=pr&el=footer). Last update [8f1dfa7...37de603](https://codecov.io/gh/pandas-dev/pandas/pull/19899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
parameterize test_pct_change_periods_freq
State: closed

- [x] closes https://github.com/pandas-dev/pandas/pull/19410
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Period
description: Period data type

Comments:
lgtm. ping on green.
thanks!
cleanup order of operations kludges
State: closed

DatetimeIndexOpsMixin has an unfortunate kludge where it checks if `self` is a `TimedeltaIndex` and if so dispatches to a reversed operation.  This then makes subsequent checks less straightforward than they could/should be.  This fixes that.

This is in preparation for separating out DatetimeArray/TimedeltaArray/PeriodArray, so this uses formatting on error messages to be class-agnostic.


Labels:
name: Datetime
description: Datetime data dtype
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19895?src=pr&el=h1) Report
> Merging [#19895](https://codecov.io/gh/pandas-dev/pandas/pull/19895?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/8f1dfa74e244622a7f356a496072f93dce032839?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `91.3%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19895/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19895?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19895      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files         150      150              
  Lines       48936    48930       -6     
==========================================
- Hits        44860    44853       -7     
- Misses       4076     4077       +1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.04% <91.3%> (-0.01%)` | :arrow_down: |
| #single | `41.82% <34.78%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19895?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/timedeltas.py](https://codecov.io/gh/pandas-dev/pandas/pull/19895/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy90aW1lZGVsdGFzLnB5) | `91.21% <100%> (+0.21%)` | :arrow_up: |
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/19895/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.61% <75%> (ø)` | :arrow_up: |
| [pandas/core/indexes/datetimelike.py](https://codecov.io/gh/pandas-dev/pandas/pull/19895/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZWxpa2UucHk=) | `97.33% <88.88%> (-0.06%)` | :arrow_down: |
| [pandas/core/dtypes/cast.py](https://codecov.io/gh/pandas-dev/pandas/pull/19895/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL2Nhc3QucHk=) | `87.68% <0%> (-0.3%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19895?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19895?src=pr&el=footer). Last update [8f1dfa7...e34c4a5](https://codecov.io/gh/pandas-dev/pandas/pull/19895?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
EHN: Implement method argument for DataFrame.replace
State: closed

- [x] closes #19632
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: API Design

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19894?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@d14fae8`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19894/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19894?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19894   +/-   ##
=========================================
  Coverage          ?   91.69%           
=========================================
  Files             ?      150           
  Lines             ?    49051           
  Branches          ?        0           
=========================================
  Hits              ?    44977           
  Misses            ?     4074           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.07% <100%> (?)` | |
| #single | `41.79% <0%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19894?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/19894/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `95.84% <100%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19894?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19894?src=pr&el=footer). Last update [d14fae8...5d8eae5](https://codecov.io/gh/pandas-dev/pandas/pull/19894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

very minor comment. ping when pushed. also there *might* be a duplicate issue of this out there, if you find one lmk.
@jreback I don't think your comment was posted.

I had a look for a duplicate issue but couldn't find any.
@jreback it’s green now, thanks!
hmm for some reason this is not triggering a re-run, looks like travis is partially degraded atm
thanks!
COMPAT: fixup decimal extension for indexing compat
State: closed


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Compat
description: pandas objects compatability with Numpy or Python functions
name: 32bit
description: 32-bit systems

Comments:
cc @TomAugspurger 
Ah, perfect, thanks.
hah, let's see if it passes on windows
CLN: remove obsolete code in Categorical.fillna
State: closed

closes #19787  

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
Deleted code and tested block of code associated with NaN that should be unreachable. 

Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Categorical
description: Categorical Data Type
name: Clean

Comments:
Thanks. Looks like some test cache files got in your commits.

Could you

1. Delete those files: `rm -rf .pytest_cache`
2. Remove them from the next commit (I think `git rm .pytests_cache`
3. Add `.pytest_cache` to the `.gitignore` file at the root of the pandas directory?

And then push those changes.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19880?src=pr&el=h1) Report
> Merging [#19880](https://codecov.io/gh/pandas-dev/pandas/pull/19880?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/38afa9310040f1bd4fb122008e96fe6d719b12a2?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19880/graphs/tree.svg?height=150&token=eZ4WkYLtcO&width=650&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19880?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19880      +/-   ##
==========================================
+ Coverage   91.78%   91.78%   +<.01%     
==========================================
  Files         152      152              
  Lines       49196    49191       -5     
==========================================
- Hits        45153    45151       -2     
+ Misses       4043     4040       -3
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.17% <ø> (ø)` | :arrow_up: |
| #single | `41.82% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19880?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/arrays/categorical.py](https://codecov.io/gh/pandas-dev/pandas/pull/19880/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2NhdGVnb3JpY2FsLnB5) | `95.47% <ø> (+0.36%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19880?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19880?src=pr&el=footer). Last update [38afa93...a1df599](https://codecov.io/gh/pandas-dev/pandas/pull/19880?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Fixed issue with leftover test.json file
State: closed

- [ ] closes #19815
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs
name: IO JSON
description: read_json, to_json, json_normalize

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19879?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@c1237f2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19879/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19879?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19879   +/-   ##
=========================================
  Coverage          ?   91.65%           
=========================================
  Files             ?      150           
  Lines             ?    48915           
  Branches          ?        0           
=========================================
  Hits              ?    44835           
  Misses            ?     4080           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.03% <ø> (?)` | |
| #single | `41.83% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19879?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19879?src=pr&el=footer). Last update [c1237f2...7927c6a](https://codecov.io/gh/pandas-dev/pandas/pull/19879?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
pandas.read_csv tries to convert "NaN" even when specifying dtype argument #19644
State: closed

When the user informs the dtype must be cast for the type defined by him.
More information: #19644 

- [x] closes #19644
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: IO CSV
description: read_csv, to_csv

Comments:
see #15669 
see comments on the issue. this is not possible as NaN is the missing value marker.