BrandonFors/pandas-github-issues huggingface dataset:
move timedelta test_astype test
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19639?src=pr&el=h1) Report
> Merging [#19639](https://codecov.io/gh/pandas-dev/pandas/pull/19639?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/13bd008edbbe0780600072d404fa989accb5e762?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19639/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19639?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19639      +/-   ##
==========================================
- Coverage   91.61%   91.59%   -0.03%     
==========================================
  Files         150      150              
  Lines       48807    48807              
==========================================
- Hits        44716    44704      -12     
- Misses       4091     4103      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.96% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19639?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19639/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19639?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19639?src=pr&el=footer). Last update [13bd008...f253e98](https://codecov.io/gh/pandas-dev/pandas/pull/19639?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Move liboffsets, libfreqs, libparsing tests to test_tslibs
State: closed

libfreqs and liboffsets tests are moved but not edited.  libparsing tests has one test moved to tests.indexes.datetimes.test_tools to keep it self-contained.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Datetime
description: Datetime data dtype
name: Frequency
description: DateOffsets

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19638?src=pr&el=h1) Report
> Merging [#19638](https://codecov.io/gh/pandas-dev/pandas/pull/19638?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/13bd008edbbe0780600072d404fa989accb5e762?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19638/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19638?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19638      +/-   ##
==========================================
- Coverage   91.61%   91.59%   -0.03%     
==========================================
  Files         150      150              
  Lines       48807    48807              
==========================================
- Hits        44716    44704      -12     
- Misses       4091     4103      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.96% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19638?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19638/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19638?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19638?src=pr&el=footer). Last update [13bd008...fbf0322](https://codecov.io/gh/pandas-dev/pandas/pull/19638?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Ping
thanks!
test_astype portion of #19627
State: closed

parametrized as suggested

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Datetime
description: Datetime data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19637?src=pr&el=h1) Report
> Merging [#19637](https://codecov.io/gh/pandas-dev/pandas/pull/19637?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/13bd008edbbe0780600072d404fa989accb5e762?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19637/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19637?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19637   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         150      150           
  Lines       48807    48807           
=======================================
  Hits        44716    44716           
  Misses       4091     4091
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.99% <ø> (ø)` | :arrow_up: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19637?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19637?src=pr&el=footer). Last update [13bd008...1a833b0](https://codecov.io/gh/pandas-dev/pandas/pull/19637?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
move shift_months test to test_arithmetic
State: closed

Broken off of #19627 

Labels:
name: Datetime
description: Datetime data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19636?src=pr&el=h1) Report
> Merging [#19636](https://codecov.io/gh/pandas-dev/pandas/pull/19636?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/13bd008edbbe0780600072d404fa989accb5e762?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19636/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19636?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19636      +/-   ##
==========================================
- Coverage   91.61%   91.59%   -0.03%     
==========================================
  Files         150      150              
  Lines       48807    48807              
==========================================
- Hits        44716    44704      -12     
- Misses       4091     4103      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.96% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19636?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19636/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19636?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19636?src=pr&el=footer). Last update [13bd008...12e92b8](https://codecov.io/gh/pandas-dev/pandas/pull/19636?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

ping
thanks
Consolidated Groupby nth / last object Templates
State: closed

- [X] closes #19569
- [ ] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Updated to prevent the group_rank_object method from being templated after the merging of #19481 

Labels:
name: Groupby
name: Clean

Comments:
lgtm. ping on green.
thanks!
Fix left join turning into outer join
State: closed

- [x] closes #19607
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19624?src=pr&el=h1) Report
> Merging [#19624](https://codecov.io/gh/pandas-dev/pandas/pull/19624?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/a214915e241ea15f3d072d54930d0e0c8f42ee10?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19624/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19624?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19624      +/-   ##
==========================================
+ Coverage   91.59%   91.62%   +0.02%     
==========================================
  Files         150      150              
  Lines       48795    48798       +3     
==========================================
+ Hits        44696    44711      +15     
+ Misses       4099     4087      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.99% <100%> (+0.02%)` | :arrow_up: |
| #single | `41.73% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19624?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/19624/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.42% <100%> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19624/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |
| [pandas/core/arrays/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/19624/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2Jhc2UucHk=) | `60.6% <0%> (+3.93%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19624?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19624?src=pr&el=footer). Last update [a214915...0a068a0](https://codecov.io/gh/pandas-dev/pandas/pull/19624?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @elrubio 

if you'd have a look at the xref issues to see if they are closable with this fix (if they are not, would appreciate a PR for those as well!)

> I think this is the same issue as #17257. maybe also related to #16304. Welcome to have a look / PR to fix. These should be the same.
order of exceptions in array_to_datetime
State: closed

First, cleans things up by moving all the seen_datetime and seen_integer variables to the tops of their respective blocks.

Mainly splits the `try:` block for `string_to_dts` up into two pieces based on the two lines in that block that _could_ raise and handles errors more specfically.

Labels:
name: Datetime
description: Datetime data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19621?src=pr&el=h1) Report
> Merging [#19621](https://codecov.io/gh/pandas-dev/pandas/pull/19621?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/a214915e241ea15f3d072d54930d0e0c8f42ee10?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19621/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19621?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19621      +/-   ##
==========================================
+ Coverage   91.59%    91.6%   +<.01%     
==========================================
  Files         150      150              
  Lines       48795    48798       +3     
==========================================
+ Hits        44696    44699       +3     
  Misses       4099     4099
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.97% <ø> (ø)` | :arrow_up: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19621?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/arrays/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/19621/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2Jhc2UucHk=) | `60.6% <0%> (+3.93%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19621?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19621?src=pr&el=footer). Last update [a214915...f70792b](https://codecov.io/gh/pandas-dev/pandas/pull/19621?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks. ideally want to split up these giant functions (e.g. make smaller functions to handle different types, like the strings) so it easier to read. but progress.
TST: set multi_statement flag for pymysql tests
State: closed

Trying something out for #19462

closes #19462

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO SQL
description: to_sql, read_sql, read_sql_query

Comments:
Hello @jorisvandenbossche! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on February 09, 2018 at 15:10 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19619?src=pr&el=h1) Report
> Merging [#19619](https://codecov.io/gh/pandas-dev/pandas/pull/19619?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7dcc86443fd9b1aa94b6f7e4e33b6fbd0210b8db?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19619/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19619?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19619   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         150      150           
  Lines       48795    48795           
=======================================
  Hits        44706    44706           
  Misses       4089     4089
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.99% <ø> (ø)` | :arrow_up: |
| #single | `41.72% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19619?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19619?src=pr&el=footer). Last update [7dcc864...9d6cb64](https://codecov.io/gh/pandas-dev/pandas/pull/19619?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Seems to be passing now, so merging.
Fix uncaught OutOfBounds in array_to_datetime
State: closed

The call to convert_datetime_to_tsobject has a check_dts_bounds in it.  One of the usages in array_to_datetime gets that right, the other misses it.

Labels:
name: Datetime
description: Datetime data dtype

Comments:
Hello @jbrockmendel! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on February 10, 2018 at 18:15 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19612?src=pr&el=h1) Report
> Merging [#19612](https://codecov.io/gh/pandas-dev/pandas/pull/19612?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/d7797b44b12f80a6f6e447b3523b820fadd85b7b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19612/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/19612?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19612   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         150      150           
  Lines       48807    48807           
=======================================
  Hits        44704    44704           
  Misses       4103     4103
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.96% <ø> (ø)` | :arrow_up: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19612?src=pr&el=footer). Last update [d7797b4...9999e2d](https://codecov.io/gh/pandas-dev/pandas/pull/19612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

does this have a referenced issue? needs a whatsnew note
> does this have a referenced issue? 

None that I found.
thanks!
Consolidate nth / last object Groupby Implementations
State: closed

- [X] closes #19569
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Depending on what goes first between this and #19481 some merge conflicts will need to be cleaned up

Labels:
name: Groupby
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19610?src=pr&el=h1) Report
> Merging [#19610](https://codecov.io/gh/pandas-dev/pandas/pull/19610?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b83512773ab0dd3908cf2ef5ccaddcd8e0337c64?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19610/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19610?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19610      +/-   ##
==========================================
- Coverage   91.62%   91.59%   -0.03%     
==========================================
  Files         150      150              
  Lines       48790    48790              
==========================================
- Hits        44703    44691      -12     
- Misses       4087     4099      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.97% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19610?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19610/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19610?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19610?src=pr&el=footer). Last update [b835127...fa63b47](https://codecov.io/gh/pandas-dev/pandas/pull/19610?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
@WillAyd I merged this, then reverted it. Can you send a new PR that is rebased on master?
Reverted in https://github.com/pandas-dev/pandas/commit/5c76f33a106d071e3b5620f908cfc760d8e3d6b2