BrandonFors/pandas-github-issues huggingface dataset:
CLN: Remove deprecated method
State: closed

These params are no longer in the method, therefore can remove the docs strings


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Deprecate
description: Functionality to remove in pandas
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22324?src=pr&el=h1) Report
> Merging [#22324](https://codecov.io/gh/pandas-dev/pandas/pull/22324?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/601d71fcfa9081fa88e5c20148972cd766396cd7?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22324/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22324?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22324      +/-   ##
==========================================
- Coverage   92.08%   92.08%   -0.01%     
==========================================
  Files         169      169              
  Lines       50706    50699       -7     
==========================================
- Hits        46691    46684       -7     
  Misses       4015     4015
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.48% <ø> (-0.01%)` | :arrow_down: |
| #single | `42.33% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22324?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/22324/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.5% <ø> (-0.05%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22324?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22324?src=pr&el=footer). Last update [601d71f...376e48c](https://codecov.io/gh/pandas-dev/pandas/pull/22324?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

we are not removing 0.21.0 deprecations yet, see the list here: https://github.com/pandas-dev/pandas/issues/6581

things deprecated in 0.20.0 are fair game however.
Okay no worries, thanks @jreback for the info!
@jreback : That was my mistake.  I was under the impression that `0.21.0` was fair game.

@alimcmaster1 : Sorry about that!  I think given we'll remove this method soon, let's leave the docs as is.  We can always make this removal later.
CLN: Remove unused param
State: closed

Param no longer used. Can remove it from single caller of this function

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22323?src=pr&el=h1) Report
> Merging [#22323](https://codecov.io/gh/pandas-dev/pandas/pull/22323?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/601d71fcfa9081fa88e5c20148972cd766396cd7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22323/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/22323?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22323   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files         169      169           
  Lines       50706    50706           
=======================================
  Hits        46691    46691           
  Misses       4015     4015
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.49% <100%> (ø)` | :arrow_up: |
| #single | `42.33% <50%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22323?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/22323/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.43% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22323?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22323?src=pr&el=footer). Last update [601d71f...393992c](https://codecov.io/gh/pandas-dev/pandas/pull/22323?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> so rather than do this, I would make the signature more similar to ....numeric_binop and pass op, then construct the opstr inside.

@jreback I think this is feasible only after merging #22336 and replacing ``np.abs`` with ``operator.abs`` (no idea whether this has any side effect), because ``np.abs.__name__`` is "absolute", not "abs".

closing as this is dependent on #22336 which needs to be fixed first.
CLN: Remove unused method
State: closed

- [y] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

This method isn't used anywhere in the codebase, good to delete?

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: MultiIndex
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22321?src=pr&el=h1) Report
> Merging [#22321](https://codecov.io/gh/pandas-dev/pandas/pull/22321?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/601d71fcfa9081fa88e5c20148972cd766396cd7?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22321/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/22321?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22321      +/-   ##
==========================================
+ Coverage   92.08%   92.08%   +<.01%     
==========================================
  Files         169      169              
  Lines       50706    50703       -3     
==========================================
- Hits        46691    46689       -2     
+ Misses       4015     4014       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.49% <ø> (ø)` | :arrow_up: |
| #single | `42.33% <ø> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22321?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/multi.py](https://codecov.io/gh/pandas-dev/pandas/pull/22321/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9tdWx0aS5weQ==) | `95.41% <ø> (+0.07%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22321?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22321?src=pr&el=footer). Last update [601d71f...ac64c8e](https://codecov.io/gh/pandas-dev/pandas/pull/22321?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks! improved coverage!
DOC/DEPR: clarify argmin/argmax deprecation message
State: closed

Attempt to better phrase the message, xref https://github.com/pandas-dev/pandas/issues/16830#issuecomment-412211029

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22310?src=pr&el=h1) Report
> Merging [#22310](https://codecov.io/gh/pandas-dev/pandas/pull/22310?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/188a4fc5535ea9022d086d379cbcaf562c1123f6?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22310/graphs/tree.svg?height=150&src=pr&token=eZ4WkYLtcO&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/22310?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22310   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files         169      169           
  Lines       50691    50691           
=======================================
  Hits        46681    46681           
  Misses       4010     4010
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.49% <ø> (ø)` | :arrow_up: |
| #single | `42.34% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22310?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/series.py](https://codecov.io/gh/pandas-dev/pandas/pull/22310/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc2VyaWVzLnB5) | `94.11% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22310?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22310?src=pr&el=footer). Last update [188a4fc...ef31468](https://codecov.io/gh/pandas-dev/pandas/pull/22310?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
DOC: fixes to DataFrame.plot.area docstring
State: closed

Follow-up on https://github.com/pandas-dev/pandas/pull/20170

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22307?src=pr&el=h1) Report
> Merging [#22307](https://codecov.io/gh/pandas-dev/pandas/pull/22307?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/188a4fc5535ea9022d086d379cbcaf562c1123f6?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22307/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22307?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22307   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files         169      169           
  Lines       50691    50691           
=======================================
  Hits        46681    46681           
  Misses       4010     4010
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.49% <ø> (ø)` | :arrow_up: |
| #single | `42.34% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22307?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_core.py](https://codecov.io/gh/pandas-dev/pandas/pull/22307/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb3JlLnB5) | `83.48% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22307?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22307?src=pr&el=footer). Last update [188a4fc...55771a9](https://codecov.io/gh/pandas-dev/pandas/pull/22307?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
ENH: add quantile method to resample
State: closed

- [x] closes #15023
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Enhancement
name: Resample
description: resample method

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22304?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@9346e79`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22304/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/22304?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #22304   +/-   ##
=========================================
  Coverage          ?   92.05%           
=========================================
  Files             ?      169           
  Lines             ?    50716           
  Branches          ?        0           
=========================================
  Hits              ?    46685           
  Misses            ?     4031           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.46% <100%> (?)` | |
| #single | `42.25% <11.11%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22304?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/resample.py](https://codecov.io/gh/pandas-dev/pandas/pull/22304/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzYW1wbGUucHk=) | `96.09% <100%> (ø)` | |
| [pandas/core/groupby/groupby.py](https://codecov.io/gh/pandas-dev/pandas/pull/22304/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS9ncm91cGJ5LnB5) | `96.18% <100%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22304?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22304?src=pr&el=footer). Last update [9346e79...92b5b2d](https://codecov.io/gh/pandas-dev/pandas/pull/22304?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hello @discort! Thanks for updating the PR.







Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on August 22, 2018 at 10:44 Hours UTC
@jreback 
@jreback 
thanks @discort keep em coming!
Remove unused param/method
State: closed

- [y] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

-Remove unused param "op" in `_validate_for_numeric_unaryop`. ( Param remove from single call of function)

-Static method `_from_element` appears to be unused


Labels:
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22289?src=pr&el=h1) Report
> Merging [#22289](https://codecov.io/gh/pandas-dev/pandas/pull/22289?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/0370740034978d3a63d4b8e5e2c96ff54e7e08ba?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22289/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/22289?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22289      +/-   ##
==========================================
+ Coverage   92.08%   92.08%   +<.01%     
==========================================
  Files         169      169              
  Lines       50694    50691       -3     
==========================================
- Hits        46682    46680       -2     
+ Misses       4012     4011       -1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.49% <100%> (ø)` | :arrow_up: |
| #single | `42.34% <50%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22289?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/multi.py](https://codecov.io/gh/pandas-dev/pandas/pull/22289/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9tdWx0aS5weQ==) | `95.41% <ø> (+0.07%)` | :arrow_up: |
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/22289/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.54% <ø> (ø)` | :arrow_up: |
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/22289/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.43% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22289?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22289?src=pr&el=footer). Last update [0370740...152ee47](https://codecov.io/gh/pandas-dev/pandas/pull/22289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

IMO the changes are semantically distinct enough that they should be broken up into separate PR's for evaluation.  @alimcmaster1 : what do you think?

cc @jreback 
Sure @gfyoung , happy to break it up makes it easier to review. 

See new PR's here:
#22321
#22323 
#22322
#22324

Ill close this one :)
[CLN] More Misc Cleanups in _libs
State: closed

cpdef --> cdef in a few cases
modernize string formatting
modernize for loop syntax

Should be orthogonal to other outstanding PR(s)

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22287?src=pr&el=h1) Report
> Merging [#22287](https://codecov.io/gh/pandas-dev/pandas/pull/22287?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/70e6f7c3ce7aca9a0ee08bacb2fe0ad85db02d88?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22287/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/22287?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22287   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         169      169           
  Lines       50709    50709           
=======================================
  Hits        46679    46679           
  Misses       4030     4030
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.46% <ø> (ø)` | :arrow_up: |
| #single | `42.25% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22287?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22287?src=pr&el=footer). Last update [70e6f7c...bcff47a](https://codecov.io/gh/pandas-dev/pandas/pull/22287?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

>  are you linting these? (obviously how you made some of the changes)

No, just periodically reading through them.  My vague plan for achieving linting is to get the code (at least some pyx modules) "close enough" to valid python to trick the linter.
Had to revert some edits to fix persistent ResourceWarning in one Travis environment.  Will try to narrow down the culprit in the next pass.
Ping (got “LGTM” a few days ago)
thanks
[CLN] More cython cleanups, with bonus type annotations
State: closed

A few places where string formatting is modernized

Removed remaining `# cython: profile=False` comments

The main (and possible controversial) thing done here is changing some functions to use type-hint syntax.  The affected functions are all currently `cpdef`, but are never used in cython, so _should_ only be `def`.  But cython's syntax does not allow for specifying a return type in `def` functions, so this is the cleanest way to remove unnecessary `cpdef` without losing typing.  (some discussion of this occurred in #22180)

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
Out of curiosity how are you verifying that the `cpdef` functions are only being called from Python? Manual exercise or is there a tool to help identify?
> Out of curiosity how are you verifying that the cpdef functions are only being called from Python? Manual exercise or is there a tool to help identify?

Just text search within the file.  Since the relevant functions aren't exposed in a .pxd file, there is no risk of them being called from a different cython file.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22283?src=pr&el=h1) Report
> Merging [#22283](https://codecov.io/gh/pandas-dev/pandas/pull/22283?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/e2e1a1051576a48f210ce17272fc24b90ebcf24a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22283/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22283?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22283   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50782    50782           
=======================================
  Hits        46742    46742           
  Misses       4040     4040
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <ø> (ø)` | :arrow_up: |
| #single | `42.3% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22283?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22283?src=pr&el=footer). Last update [e2e1a10...3300de1](https://codecov.io/gh/pandas-dev/pandas/pull/22283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jreback would this be easier if I separated the no-profile comments into an isolated PR?
no just haven’t had a chance to look yet
@jreback gentle ping; got your OK last week
think this was ok, can you rebase
Rebased; circleCI fail is hypothesis timeout
Rebased+green
thanks!