BrandonFors/pandas-github-issues huggingface dataset:
Pyside2 is arriving
State: closed

see http://blog.qt.io/blog/2018/04/13/qt-for-python-is-coming-to-a-computer-near-you/

- [x] install.rst new option from Qt World


Labels:

Comments:
Have we verified that `read_clipboard` actually works with pyside2? 
have you an example, so I can check in 30 seconds ? ... yes on Windows 10 / Excel / PySide2-5.11.0a1 / Python-3.6 64 bit / Pandas-0.22.0 (if I tested the right "read_clipboard" functionnality  ... is Pandas  using Qt for that ?)

![pandas_clip_pyside2](https://user-images.githubusercontent.com/4312421/39479570-f337f36c-4d65-11e8-91a7-4c23264e5ae6.PNG)

as "Qt for Python" is an opportunity to get a strong and official support of the Python-Qt bridge, we should help them gaining visibility.
Sure, but we'll want to make sure that it actually works for
`read_clipboard` before recommending people install it :)

On Tue, May 1, 2018 at 10:46 AM, stonebig <notifications@github.com> wrote:

> as "Qt for Python" is our last chance to get a strong and official support
> of the Python-Qt bridge, we should help them gaining visibility.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/20905#issuecomment-385704578>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIk2ndxM4DS1jiZ6mIAWnSOdjW02Pks5tuINAgaJpZM4TuEKr>
> .
>

ok, anyway QtConsole team says it's unwise to suggest:
- an http link (corrected to https)
- an alpha-branded version .... so, closing
BUG: Fix #20744. loffset ignored in resample ffill
State: closed

- [x] closes #20744 
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

This replaces pull request #20867 

Labels:
name: Bug
name: Resample
description: resample method

Comments:
@johncant you could have just pushed to the original PR, no need to open a new one. next time pls do that.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20884?src=pr&el=h1) Report
> Merging [#20884](https://codecov.io/gh/pandas-dev/pandas/pull/20884?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/70468dfaacf6ae3d62d1ebd29d66826c6d797e27?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20884/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/20884?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #20884      +/-   ##
==========================================
+ Coverage   91.78%   91.78%   +<.01%     
==========================================
  Files         153      153              
  Lines       49324    49325       +1     
==========================================
+ Hits        45272    45273       +1     
  Misses       4052     4052
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.17% <100%> (ø)` | :arrow_up: |
| #single | `41.91% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20884?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/resample.py](https://codecov.io/gh/pandas-dev/pandas/pull/20884/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzYW1wbGUucHk=) | `96.07% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20884?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20884?src=pr&el=footer). Last update [70468df...282e405](https://codecov.io/gh/pandas-dev/pandas/pull/20884?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thans @johncant !
DOC: Fix read_hdf docstring
State: closed

Read HDF docstring was not in NumPy format.  Corrects the formatting

[skip ci]

- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`



Labels:
name: Docs
name: IO HDF5
description: read_hdf, HDFStore

Comments:
The rendered docstring

https://pandas.pydata.org/pandas-docs/stable/generated/pandas.read_hdf.html

does not have the correct appearance.
can you run the validation script on this?
Seems inevitable since signature uses **kwargs to capture most inputs.

```
Errors found:
        Errors in parameters section
                Unknown parameters {'iterator', 'start', 'chunksize', 'where', 'columns', 'stop '}
```
CI wasn't running, pushed a commit w/ a few small changes (mentioning `__fspath__`) to re-trigger it.
Merging since the doc build passed cleanly.
DOC: Link to new PyPI instead of legacy PyPI
State: closed

The new PyPI site has [officially launched](https://pythoninsider.blogspot.ca/2018/04/new-pypi-launched-legacy-pypi-shutting.html), and they've recommended [linking to the new site](https://warehouse.readthedocs.io/api-reference/integration-guide/#migrating-to-the-new-pypi).

Links to the legacy site are currently redirecting to the new site, so the content of what users will actually see isn't different than with the existing links, but seems best to avoid the redirect.


Labels:
name: Docs

Comments:
thanks for the update!
DOC: Improve the docstring of Str.contains()
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

```############################################################################
################################## Validation ##################################
################################################################################

Errors found:
	Errors in parameters section
		Parameter "flags" description should start with capital letter
```
`Achieved through PyData 2018 pandas sprint.`

Labels:
name: Docs
name: Strings
description: String extension data type and string data

Comments:
Unsure best way to phrase `flags` parameter as description starts with the ```re``` module.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20870?src=pr&el=h1) Report
> Merging [#20870](https://codecov.io/gh/pandas-dev/pandas/pull/20870?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c4da79b5b322c73d8e61d1cb98ac4ab1e2438b40?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20870/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/20870?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #20870      +/-   ##
==========================================
+ Coverage   91.79%    91.8%   +<.01%     
==========================================
  Files         153      153              
  Lines       49411    49411              
==========================================
+ Hits        45359    45361       +2     
+ Misses       4052     4050       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.19% <ø> (ø)` | :arrow_up: |
| #single | `41.91% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20870?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/strings.py](https://codecov.io/gh/pandas-dev/pandas/pull/20870/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3RyaW5ncy5weQ==) | `98.34% <ø> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/20870/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.59% <0%> (+0.2%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20870?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20870?src=pr&el=footer). Last update [c4da79b...99eb015](https://codecov.io/gh/pandas-dev/pandas/pull/20870?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hey @WillAyd I've tried to fix your correction. What's the next step?
Thanks @Blair-Young!
Thanks @TomAugspurger looking forward to more.
Fix #20744 . loffset ignored in upsample
State: closed

- [X] closes #20744
- [X] 1 test updated
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Bug
name: Resample
description: resample method

Comments:
Credit to Karan Singhal and @acidburnburn 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20867?src=pr&el=h1) Report
> Merging [#20867](https://codecov.io/gh/pandas-dev/pandas/pull/20867?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/563a6ad108a79b0192a25d51d743812a18e21b15?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20867/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/20867?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #20867      +/-   ##
==========================================
+ Coverage   91.77%   91.77%   +<.01%     
==========================================
  Files         153      153              
  Lines       49313    49314       +1     
==========================================
+ Hits        45259    45260       +1     
  Misses       4054     4054
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.17% <100%> (ø)` | :arrow_up: |
| #single | `41.88% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20867?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/resample.py](https://codecov.io/gh/pandas-dev/pandas/pull/20867/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzYW1wbGUucHk=) | `96.07% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20867?src=pr&el=footer). Last update [563a6ad...00c93d9](https://codecov.io/gh/pandas-dev/pandas/pull/20867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Consider it done! I'll also rewrite the msg to include [BUG]
Replaced by pull request #20884
DOC: Improve the docstring of String.str.zfill()
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Result of the Pandas sprint at PyData London 2018. Includes work by @owlas.

Labels:
name: Docs
name: Strings
description: String extension data type and string data

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20864?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@876e568`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20864/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/20864?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #20864   +/-   ##
=========================================
  Coverage          ?   91.81%           
=========================================
  Files             ?      153           
  Lines             ?    49478           
  Branches          ?        0           
=========================================
  Hits              ?    45429           
  Misses            ?     4049           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.21% <ø> (?)` | |
| #single | `41.85% <ø> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20864?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/strings.py](https://codecov.io/gh/pandas-dev/pandas/pull/20864/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3RyaW5ncy5weQ==) | `98.63% <ø> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20864?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20864?src=pr&el=footer). Last update [876e568...706688f](https://codecov.io/gh/pandas-dev/pandas/pull/20864?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hello @alkamid! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on July 07, 2018 at 14:20 Hours UTC
@datapythonista thanks a lot for your valuable feedback! I've addressed all your comments, does it look better to you now?
@datapythonista thanks again, suggestions incorporated into PR. Let me know what you think now.
BUG: Correct Escaping for LaTeX, #20859
State: closed

- [x] closes #20859
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnewentry

Labels:
name: IO LaTeX
description: to_latex

Comments:
Hello @ScientiaEtVeritas! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on April 29, 2018 at 20:28 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20860?src=pr&el=h1) Report
> Merging [#20860](https://codecov.io/gh/pandas-dev/pandas/pull/20860?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/563a6ad108a79b0192a25d51d743812a18e21b15?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20860/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/20860?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #20860      +/-   ##
==========================================
+ Coverage   91.77%   91.78%   +<.01%     
==========================================
  Files         153      153              
  Lines       49313    49313              
==========================================
+ Hits        45259    45261       +2     
+ Misses       4054     4052       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.17% <100%> (ø)` | :arrow_up: |
| #single | `41.88% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/formats/latex.py](https://codecov.io/gh/pandas-dev/pandas/pull/20860/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2Zvcm1hdHMvbGF0ZXgucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/20860/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.59% <0%> (+0.2%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20860?src=pr&el=footer). Last update [563a6ad...d0ec214](https://codecov.io/gh/pandas-dev/pandas/pull/20860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

looks ok to me. @toobaz @TomAugspurger 
Thanks @ScientiaEtVeritas!
[WIP] Debug R doc build failure
State: closed

#20648

Labels:
name: Docs

Comments:
The packages built by anaconda include compiler flags (`-fPIC`) that should make this error impossible. Seeing if (temporarily) excluding conda-forge packages fixes things.
Hello @TomAugspurger! Thanks for updating the PR.

 - In the file [`doc/source/conf.py`](https://github.com/pandas-dev/pandas/blob/d6e946607f102ea069612a91269fc72b8a80de20/doc/source/conf.py), following are the PEP8 issues :

> [Line 75:13](https://github.com/pandas-dev/pandas/blob/d6e946607f102ea069612a91269fc72b8a80de20/doc/source/conf.py#L75): [E128](https://duckduckgo.com/?q=pep8%20E128) continuation line under-indented for visual indent





##### Comment last updated on April 26, 2018 at 14:14 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20830?src=pr&el=h1) Report
> Merging [#20830](https://codecov.io/gh/pandas-dev/pandas/pull/20830?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/630ef1649cb57a4068474baaff8c4a2b8a14b313?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20830/graphs/tree.svg?token=eZ4WkYLtcO&width=650&src=pr&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/20830?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #20830   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         153      153           
  Lines       49281    49281           
=======================================
  Hits        45230    45230           
  Misses       4051     4051
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.17% <ø> (ø)` | :arrow_up: |
| #single | `41.88% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20830?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20830?src=pr&el=footer). Last update [630ef16...d6e9466](https://codecov.io/gh/pandas-dev/pandas/pull/20830?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hmm, still trying to get  a local reproducer, but https://travis-ci.org/pandas-dev/pandas/jobs/371582150#L2705 managed to import rpy2, I guess since it was imported early enough :/

https://stackoverflow.com/questions/19268293/matlab-error-cannot-open-with-static-tls/19468365#19468365

It sounds like either Travis' glibc is the bottleneck here. We won't be able to do much to work around it unfortunately.
Thanks for looking into this. 
Temporary / definite workaround would be just remove that doc section, or to convert it to static code-blocks.
Yeah. I'm able to build things locally, so I'm not too worried about it delaying the relase.
closing as stale. if you'd like to continue pls ping.
DOC: Removed duplicate returns section
State: closed

Closes https://github.com/pandas-dev/pandas/issues/20822

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20823?src=pr&el=h1) Report
> Merging [#20823](https://codecov.io/gh/pandas-dev/pandas/pull/20823?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/4aac0c8a3ffd841a6916a5b49a8c4aa55fa8b080?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20823/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/20823?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #20823      +/-   ##
==========================================
- Coverage   91.78%   91.78%   -0.01%     
==========================================
  Files         153      153              
  Lines       49273    49271       -2     
==========================================
- Hits        45224    45222       -2     
  Misses       4049     4049
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.17% <ø> (-0.01%)` | :arrow_down: |
| #single | `41.88% <ø> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20823?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/window.py](https://codecov.io/gh/pandas-dev/pandas/pull/20823/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvd2luZG93LnB5) | `96.29% <ø> (-0.01%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20823?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20823?src=pr&el=footer). Last update [4aac0c8...cd933e1](https://codecov.io/gh/pandas-dev/pandas/pull/20823?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Change _can_hold_na to a class attribute and document that it shouldn't be changed
State: closed

- [x] closes #20761
- [x] tests added / passed
  - removed tests dependent on `_can_hold_na`
- [x ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry
  - not needed because it is part of `ExtensionArray` support new for v0.23

Replaces pull request #20815 (see discussion there for reasoning)


Labels:
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
@TomAugspurger It seems that you made the change that @jreback asked for.  Anything else for me to do?
Nope, we're good. Thanks!.