BrandonFors/pandas-github-issues huggingface dataset:
DOC: Fix versionadded directive typos in IntervalIndex
State: closed

There needs to be a space between the `..` and `versionadded::`.  Currently being rendered as plaintext, which doesn't look too great:

![image](https://user-images.githubusercontent.com/5332445/41943354-50072132-7960-11e8-814e-5fd8ef559a86.png)

Couldn't find any other instances of this in the codebase for `versionadded` or any other commonly used directives.  Pretty minor so tagging this as 0.23.2.


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21649?src=pr&el=h1) Report
> Merging [#21649](https://codecov.io/gh/pandas-dev/pandas/pull/21649?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/45e55af9cf74aede00a8b10f8922537f285a573a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21649/graphs/tree.svg?token=eZ4WkYLtcO&width=650&src=pr&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21649?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21649   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         154      154           
  Lines       49558    49558           
=======================================
  Hits        45545    45545           
  Misses       4013     4013
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.27% <ø> (ø)` | :arrow_up: |
| #single | `42.02% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21649?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/interval.py](https://codecov.io/gh/pandas-dev/pandas/pull/21649/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9pbnRlcnZhbC5weQ==) | `93.16% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21649?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21649?src=pr&el=footer). Last update [45e55af...2d3602a](https://codecov.io/gh/pandas-dev/pandas/pull/21649?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
addresses GH #21646
State: closed

- [x] closes #21646
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
This allows pytest to be called from any directory within the project and successfully run tests using the datapath fixture.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21647?src=pr&el=h1) Report
> Merging [#21647](https://codecov.io/gh/pandas-dev/pandas/pull/21647?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/45e55af9cf74aede00a8b10f8922537f285a573a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21647/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21647?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21647   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         154      154           
  Lines       49558    49558           
=======================================
  Hits        45545    45545           
  Misses       4013     4013
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.27% <ø> (ø)` | :arrow_up: |
| #single | `42.02% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21647?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21647?src=pr&el=footer). Last update [45e55af...ebca56c](https://codecov.io/gh/pandas-dev/pandas/pull/21647?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
DOC: fix typo in cookbook.rst
State: closed

Removing the semicolon delimiter at the end of the modified line of code allows the line's output to be displayed.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
Thanks!
DOC: fixup old whatsnew for dtype coercing change (#21456)
State: closed

xref https://github.com/pandas-dev/pandas/pull/21456

cc @gfyoung 

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21634?src=pr&el=h1) Report
> Merging [#21634](https://codecov.io/gh/pandas-dev/pandas/pull/21634?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/6db8076047f547a85038ea601dfc60bc51b4afc6?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21634/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/21634?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21634   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         153      153           
  Lines       49547    49547           
=======================================
  Hits        45536    45536           
  Misses       4011     4011
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21634?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21634?src=pr&el=footer). Last update [6db8076...fa6da50](https://codecov.io/gh/pandas-dev/pandas/pull/21634?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Move tz cleanup whatsnew entries to v0.24
State: closed

Pre-req for #21612. https://github.com/pandas-dev/pandas/pull/21612#pullrequestreview-131551269

Moving tz cleanup whatsnew entries from 0.23.2 to 0.24.0 added in #21491

cc @jreback 


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21631?src=pr&el=h1) Report
> Merging [#21631](https://codecov.io/gh/pandas-dev/pandas/pull/21631?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1033e8b1195d4071253889ada60523832285354c?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21631/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21631?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21631   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         153      153           
  Lines       49532    49532           
=======================================
  Hits        45525    45525           
  Misses       4007     4007
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.87% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21631?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21631?src=pr&el=footer). Last update [1033e8b...95ece7f](https://codecov.io/gh/pandas-dev/pandas/pull/21631?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
remove unused cimport
State: closed



- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21619?src=pr&el=h1) Report
> Merging [#21619](https://codecov.io/gh/pandas-dev/pandas/pull/21619?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f1aa08c4631aea435d66c161557e44f7c72a618e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21619/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21619?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21619   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         153      153           
  Lines       49547    49547           
=======================================
  Hits        45537    45537           
  Misses       4010     4010
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.78% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21619?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21619?src=pr&el=footer). Last update [f1aa08c...0d83543](https://codecov.io/gh/pandas-dev/pandas/pull/21619?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
TST: Clean old timezone issues PT2
State: closed

- [x] closes #11679
- [x] closes #11365
- [x] closes #12064
- [x] closes #12601
- [x] closes #9243
- [x] closes #11792
- [x] closes #13051
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

xref #21491, cleaning up older timezone issues and moved the whatsnew entries in the first cleanup PR from v0.23.2 to v0.24.0 as discussed https://github.com/pandas-dev/pandas/pull/21491#discussion_r197077733


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Timezones
description: Timezone data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21612?src=pr&el=h1) Report
> Merging [#21612](https://codecov.io/gh/pandas-dev/pandas/pull/21612?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/73ab162340c7cfc461a80b037da8ecf1911906d4?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21612/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21612?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21612      +/-   ##
==========================================
+ Coverage    91.9%    91.9%   +<.01%     
==========================================
  Files         154      154              
  Lines       49555    49558       +3     
==========================================
+ Hits        45542    45545       +3     
  Misses       4013     4013
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.27% <ø> (ø)` | :arrow_up: |
| #single | `42.02% <ø> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21612?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/21612/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.19% <0%> (ø)` | :arrow_up: |
| [pandas/core/indexes/interval.py](https://codecov.io/gh/pandas-dev/pandas/pull/21612/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9pbnRlcnZhbC5weQ==) | `93.16% <0%> (+0.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21612?src=pr&el=footer). Last update [73ab162...0f63b69](https://codecov.io/gh/pandas-dev/pandas/pull/21612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Addressed your comments @jreback and all green. 
thanks @mroeschke had some duplicate whatsnew entries, but fixed
BUG: Fix json_normalize throwing AttributeError (#21608)
State: closed

This PR fixes the bug in `json_normalize` that causes it to throw `AttributeError` when flattening an array of values.
- [ ] closes #21608 
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Enhancement
name: IO JSON
description: read_json, to_json, json_normalize

Comments:
Hello @vuminhle! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on June 23, 2018 at 13:45 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21611?src=pr&el=h1) Report
> Merging [#21611](https://codecov.io/gh/pandas-dev/pandas/pull/21611?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/eb40557a7897a6138b605b1fe5291451027ec01b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21611/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21611?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21611      +/-   ##
==========================================
+ Coverage    91.9%    91.9%   +<.01%     
==========================================
  Files         153      153              
  Lines       49548    49551       +3     
==========================================
+ Hits        45538    45541       +3     
  Misses       4010     4010
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <100%> (ø)` | :arrow_up: |
| #single | `41.77% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21611?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/json/normalize.py](https://codecov.io/gh/pandas-dev/pandas/pull/21611/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2pzb24vbm9ybWFsaXplLnB5) | `96.96% <100%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21611?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21611?src=pr&el=footer). Last update [eb40557...7f4e139](https://codecov.io/gh/pandas-dev/pandas/pull/21611?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

closing as stale, if you want to continue working, pls ping and we can re-open. you will need to merge master.
More speedups for Period comparisons
State: closed

Following #21582, the biggest avoidable overheads in Period comparisons are in a) `isinstance` calls that can be short-circuited and b) `__ne__` call overhead.  This PR moves `__eq__` and `__ne__` to the cython file, removing the `__ne__` overhead, and changes an `isinstance` check to a try/except.

Using the same profile code from #21582, this brings the `set_index` runtime from 6.603 seconds down to 2.165 seconds.

Labels:
name: Performance
description: Memory or execution speed performance
name: Period
description: Period data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21606?src=pr&el=h1) Report
> Merging [#21606](https://codecov.io/gh/pandas-dev/pandas/pull/21606?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/36422a88474396148bd7d5d38aa238ea844d9555?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21606/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21606?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21606      +/-   ##
==========================================
- Coverage    91.9%   91.89%   -0.01%     
==========================================
  Files         154      154              
  Lines       49562    49543      -19     
==========================================
- Hits        45549    45530      -19     
  Misses       4013     4013
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <100%> (-0.01%)` | :arrow_down: |
| #single | `41.84% <100%> (-0.02%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21606?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/21606/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `97.11% <100%> (-0.05%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21606?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21606?src=pr&el=footer). Last update [36422a8...92e6fdd](https://codecov.io/gh/pandas-dev/pandas/pull/21606?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @jbrockmendel !
CI: Test against Python 3.7
State: closed

- [x] closes #20552 
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: CI
description: Continuous Integration

Comments:
I will aim to keep as much there as possible.
can u update install.rst and setup.py where needed
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21604?src=pr&el=h1) Report
> Merging [#21604](https://codecov.io/gh/pandas-dev/pandas/pull/21604?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7bee353cd69ab846317301fdf614a94fbae50117?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21604/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21604?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21604   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         153      153           
  Lines       49548    49548           
=======================================
  Hits        45538    45538           
  Misses       4010     4010
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <100%> (ø)` | :arrow_up: |
| #single | `41.78% <100%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21604?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/compat/\_\_init\_\_.py](https://codecov.io/gh/pandas-dev/pandas/pull/21604/diff?src=pr&el=tree#diff-cGFuZGFzL2NvbXBhdC9fX2luaXRfXy5weQ==) | `58.6% <100%> (+0.17%)` | :arrow_up: |
| [pandas/core/dtypes/common.py](https://codecov.io/gh/pandas-dev/pandas/pull/21604/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL2NvbW1vbi5weQ==) | `94.63% <0%> (-0.02%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21604?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21604?src=pr&el=footer). Last update [7bee353...de3e8df](https://codecov.io/gh/pandas-dev/pandas/pull/21604?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Merging this, to ensure things don't slip in before the release.
Hey, @TomAugspurger 
I see two separate PR failing CI testing running Python3.7 due to the same error:
https://travis-ci.org/pandas-dev/pandas/jobs/396604150
https://travis-ci.org/pandas-dev/pandas/jobs/396594344

Is this expected? 

Thanks,

Alistair
TST: Use multiple instances of parametrize instead of product in tests
State: closed


- All instances `product` being used inside a `@pytest.mark.parametrize` have been converted to separate instances of `@pytest.mark.parametrize`
- Extracted `product` from within tests where it was straightforward
- There are still multiple instances of `product` being used within tests for looping purporses
   - Most of the ones left do not appear to be trivial to extract
   - Some instances we might not want to remove/are clearer as-is
   - Could maybe open an issue for some of the more obvious ones?

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21602?src=pr&el=h1) Report
> Merging [#21602](https://codecov.io/gh/pandas-dev/pandas/pull/21602?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7bee353cd69ab846317301fdf614a94fbae50117?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21602/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21602?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21602   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         153      153           
  Lines       49548    49548           
=======================================
  Hits        45538    45538           
  Misses       4010     4010
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.78% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21602?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21602?src=pr&el=footer). Last update [7bee353...35596c6](https://codecov.io/gh/pandas-dev/pandas/pull/21602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).