BrandonFors/pandas-github-issues huggingface dataset:
DOC: Add note in 1.5.3 about SQLAlchemy warnings
State: closed

xref #50558 

As discussed in todays dev call, for 1.5.3 the decision was to document that SQLAlchemy warnings can be expected but not addressed.

Labels:
name: Docs
name: IO SQL
description: to_sql, read_sql, read_sql_query

Comments:
thx @mroeschke 
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 eddb6f459a6b32112f614a9118659ef763b50db1
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #50680: DOC: Add note in 1.5.3 about SQLAlchemy warnings'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-50680-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #50680 on branch 1.5.x (DOC: Add note in 1.5.3 about SQLAlchemy warnings)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@meeseeksdev backport to 1.5.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 eddb6f459a6b32112f614a9118659ef763b50db1
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #50680: DOC: Add note in 1.5.3 about SQLAlchemy warnings'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-50680-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #50680 on branch 1.5.x (DOC: Add note in 1.5.3 about SQLAlchemy warnings)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
Update eval_performance.py
State: closed

I think there is someone has forgotten or maybe delete this by mistaken : import numpy as np

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @casadipietra
TEST: added test case for issue 41800
State: closed

- [x] Addresses #41800
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks @lpizzinidev
DEPR: ADD FutureWarning for pandas.io.execute 
State: closed

reopen for [DEPR: Add FutureWarning for pandas.io.sql.execute Pull Request #50638](https://github.com/pandas-dev/pandas/pull/50638)
- [x] closes #50185
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO SQL
description: to_sql, read_sql, read_sql_query
name: Deprecate
description: Functionality to remove in pandas

Comments:
@phofl, sorry again, we can start over here!

I'm not sure if it's appropriate and polite for me to start a new PR directly, if not, please let me know directly
!
It's fine :) Thanks for continuing, looks good generally, we are holding off on merging deprecations, so will merge when we are ready with our old deprecations
I apologize if my change has caused the check failure below again. Could you kindly inform me if it is related, and guide me on how to resolve it? If my change is not related, there is no need to respond. I greatly appreciate your help with this matter.
thx @luke396 failures were unrelated
> thx @luke396 failures were unrelated

I've noticed that you all are working hard to fix the CI issues. Keep up the good work! 😄
CLN: fix and move using_copy_on_write() helper out of internals
State: closed

I initially added this helper function just to the BlockManager internals in https://github.com/pandas-dev/pandas/pull/49771, but since then it seems we also started to use it outside of the internals. Which I think is a good change for a check that we will have to do often on the short term (it makes it more convenient to do this check, see the improvement in the diff where I changed existing `get_option(..)` calls). 
But, 1) the current function was only meant for internal usage and was incorrect for usage outside of the BlockManager (it also needs to check for the manager option) -> fixed that, and 2) moved it outside of the internals, so we don't have to import it from the internals in other parts of pandas.

Labels:
name: Clean

Comments:
> Should we merge this now? Would have to adjust all our PRs afterwards.

If that's OK for you, I would maybe merge this first? 
(we could also first merge the other PRs, and then update this one before merging. But since we will probably keep opening other PRs related to this, we will just need to merge this at some point anyway)
Yeah lets do it now
thx @jorisvandenbossche
BUG: is_[int|float]_dtypes functions not recognizing ArrowDtype
State: closed

- [ ] closes #50667 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Went ahead and fixed the other numeric-like dtype checkers


Labels:
name: Arrow
description: pyarrow functionality

Comments:
LGTM

Nice. This helps avoid a number of conversions to object dtype, e.g.

```
import pandas as pd
import numpy as np

ser = pd.Series(np.arange(10**6), dtype="int64[pyarrow]")

%timeit ser.duplicated()

# 403 ms ± 7.19 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)      <- main
# 12.4 ms ± 71.9 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)  <- this PR
```

thx @mroeschke
TST: Add a test for fillna in PeriodArray
State: closed

- [x] closes #24537 


Labels:
name: Sprints
description: Sprint Pull Requests

Comments:
@phofl @noatamir ready for review
@phofl should I still do something before this PR can be merged? Right now it's failing on pre-commit, but it's not related to my changes.
Sorry, was a bit busy yesterday.

pre-commit is failing, otherwise this lgtm 
Looks like pre-commit failure came from something else, merged main to check
thx @mstazherova 
Cool, thank you! Excited to do more :)
ENH: fix a bunch of pyarrow duration xfails
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timedelta
description: Timedelta data type
name: Arrow
description: pyarrow functionality

Comments:
Thanks @jbrockmendel
BUG: Timestamp parsing creating invalid object
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timestamp
description: pd.Timestamp and associated methods

Comments:
whatsnew added + green
Thanks @jbrockmendel
DOC: improve the string repr of "no_default" in the signature of methods
State: closed

- [x] closes https://github.com/noatamir/pyladies-berlin-sprints/issues/20

> For example in https://pandas.pydata.org/docs/dev/reference/api/pandas.DataFrame.dropna.html, the signature shows "how=_NoDefault.no_default". This could be improved to the shorter / less noisy "how=<no_default>", by adding a __str__ method to this object (https://github.com/pandas-dev/pandas/blob/7e5a95cda77d2665d5bec2f4154bf72f041ac36b/pandas/_libs/lib.pyx#L2671-L2678)

@phofl and @noatamir

Labels:
name: Stale
name: Sprints
description: Sprint Pull Requests

Comments:
@AliceAML I don't think this produced the expected change.

I checked by building the docs locally and downloading the docs built by the CI and in both cases I see "how=_NoDefault.no_default" at [pandas.DataFrame.dropna](https://pandas.pydata.org/docs/dev/reference/api/pandas.DataFrame.dropna.html). Here's a comparison of the dev Docs and the file from the CI:

<img width="1253" alt="comparing live docs (dev) with CI artifact" src="https://user-images.githubusercontent.com/6564007/211873030-bb8a7643-d9d1-4bf3-95db-3a80ea59f88e.png">

My bad, I assumed that sphinx would use `str(..)` of the object to display it in the docs. If that doesn't work, not fully sure what sphinx is doing ..

Can you check if `str(pd.api.extensions.no_default)` actually gives the expected result? (because maybe it is something with the Enum that it's not working as expected)
@jorisvandenbossche yeah that works for me on this branch.

![check str(pd api extensions no_default)](https://user-images.githubusercontent.com/6564007/211885169-1a77b847-8272-4e8a-880c-af388661db22.png)
I'll have to take a closer look here, right now I am guessing that sphinx is doing something weird here
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
@AliceAML thanks for the PR. closed as stale but if you want to continue, please comment and will reopen.
TST: ro_replace changing dtype of series
State: closed

- closes #25797
- Tests added and passed
@phofl and @noatamir 

Labels:
name: replace
description: replace method
name: Sprints
description: Sprint Pull Requests

Comments:
👋  @pooja-subramaniam 
The pre-commit errors will be fixed if you:
1. Replace your single quotes with double quotes
2. Add a new line at the end of the file (after your test)

If you want, you can have a look at the details link to see what the errors look like, so you can identify them next time 😉.

In the future, I recommend making a feature branch in your fork, rather than making a PR from your fork's main branch. You can find guidance for this in our documentation ([here)](https://pandas.pydata.org/docs/dev/development/contributing.html#creating-a-branch).
thanks for the points @noatamir!
@noatamir I don't understand the reason for the canceled check here. Do you know why that happened?
thx @pooja-subramaniam
DOC: Improve wording for DataFrame.rename summary 
State: closed

An attempt to improve the summary for DataFrame.rename.

- [x] closes [this issue](https://github.com/noatamir/pyladies-berlin-sprints/issues/19)
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

@phofl @noatamir 


Labels:
name: Docs
name: Sprints
description: Sprint Pull Requests

Comments:
thx @borovikova
DOC: add default encoding to read_csv
State: closed

Added utf-8 as default encoding of function `read_csv`

- [x] closes [#49881 ](https://github.com/pandas-dev/pandas/issues/49881)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Sprints
description: Sprint Pull Requests

Comments:
@phofl @noatamir 
thx @marielledado
DOC: fix closed and dtype arguments of TimedeltaIndex
State: closed

- [X] closes #49153 
- ~~[Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature~~
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
-  ~~Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.~~
- ~~Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.~~

1. **closed**: removed unused argument (xref #49167). It was already deprecated in version 0.24.0. (See https://github.com/TomAugspurger/pandas/blob/4d0fce26a87f7c6d74b77743fbcf96dd9c3cc338/pandas/core/indexes/timedeltas.py#L82)

2. **dtype**: add dtype parameter in docstring and add warning as indicated in [TimedeltaArray](https://pandas.pydata.org/docs/dev/reference/api/pandas.arrays.TimedeltaArray.html), since the argument is used to construct a TimedeltaArray.

Labels:
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks @abonte for the PR. closing as stale but please comment if you want to continue and will re-open.
PERF/CLN: Use Numpy C Iterator API to unify isnaobj 1D/2D
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

ASV's
```
       before           after         ratio
     [d3995f76]       [aff44731]
     <main>           <clean-perf-isna>
-         104±5ms       31.0±0.3ms     0.30  frame_methods.Isnull.time_isnull_strngs
-         107±7ms         30.5±2ms     0.29  frame_methods.Isnull.time_isnull_obj

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.
```


Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
```
mypy (stubtest)..........................................................Failed
- hook id: stubtest
- duration: 94.59s
- exit code: 1

pandas._libs.missing.isnaobj2d is not present at runtime
```
Thanks @lithomas1
ENH: Added explicit arguments in DataFrameGroupBy.describe by replacing **…
State: closed

…kwargs

- [x] closes #50406
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Groupby

Comments:
Thanks @asadullahnaeem!
Improve error message if attempting to construct multidimensional series
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Series
description: Series data structure

Comments:
Thanks @jonashaag
Update _base.py
State: closed

Originally, only the int type could be checked

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks @AniPython for the contribution. Can you please have a look at the bullet points in the description, fill the issue number you're working on, and add a title and a description that provides enough context to understand what you're trying to achieve here? Thanks!
thanks for your PR

this syntax is valid, no need to change it

please see https://pandas.pydata.org/docs/dev/development/contributing.html for how to contribute to pandas

closing then
DEPR: Remove DeprecationWarnings
State: closed

Looks like Dask addressed these deprecations in https://github.com/dask/dask/pull/8558, https://github.com/dask/partd/pull/60

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
@jrbourbeau  Just to be sure that nothing breaks on your side
thx @mroeschke @jrbourbeau
ENH: Add lazy copy for sort_values
State: closed

- [ ] xref #49473 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Copy / view semantics

Comments:
Thx for fixing this, merged main to ensure that the dev builds get through
DEPR: Add FutureWarning for pandas.io.sql.execute
State: closed

- [x] closes #50185
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
> Doc build is failing, mightt be related.
> 
> Could you remove all mentions in the docs?

Your mean is remove '`:func:`pandas.io.sql.execute` 'in .rst ?
Ah no, I think we mention this function in the user guide, this reference should be removed
> Ah no, I think we mention this function in the user guide, this reference should be removed

Fine, I will do it.

The function seems not be mentioned in the user guide or any .rst file. I find some examples in comments use the function, and I change them. 

Hope this will work!
![image](https://user-images.githubusercontent.com/77875500/211618457-196a3949-4196-4019-997f-55f9f3891d63.png)

May be this need some attention, in check `Doc Build and Upload / Doc Build and Upload`