BrandonFors/pandas-github-issues huggingface dataset:
API: add dtype= option to python parser
State: closed

- [x] part of #12686
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Ultimately I'm working towards #8212 (types in excel parser), which should be pretty straightforward after this.

Right now the tests are moved from `c_parser_only.py`, may need to add some more
cc @gfyoung 


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14295?src=pr) is 85.22% (diff: 100%)
> Merging [#14295](https://codecov.io/gh/pandas-dev/pandas/pull/14295?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **0.01%**

```diff
@@             master     #14295   diff @@
==========================================
  Files           143        143          
  Lines         50804      50833    +29   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43292      43324    +32   
+ Misses         7512       7509     -3   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [75b606a...3abb0bd](https://codecov.io/gh/pandas-dev/pandas/compare/75b606abad51762b3faace1bbfa0a8d2241dc297...3abb0bd6e46e78557c1fd480ac173881dc5d530b?src=pr)
@chris-b1 xref #14558. You say that `dtype` is ignored when `converters` is specified. In that case it would be nice to raise a warning about this if both are specified I think.

I think I've got all the feedback so far worked in - any more comments?  @jorisvandenbossche, @gfyoung, @jreback 

@chris-b1 : I'm putting together a PR to patch #14712.  As this directly relates to your PR, I would suggest waiting for mine to make sure the bug isn't an issue for you.
@chris-b1 can you rebase this? Then this can be merged I think (depending on the status of @gfyoung new PR)
Finally got back to this, rebased and updated docs - assuming tests still pass this should be good.  Will have to check, but I don't think this will conflict with #14717.
@chris-b1 I merged #14717. This added a dtype test to `c_parser_only`, so added a commit to move this to the general dtype tests as well. Feel free to merge if you're ok with this and the tests are green.
@chris-b1 Thanks!
BUG: Fix concat key name
State: closed

- [x] closes #14252
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Fixes a bug where `pd.concat` didn't propagate the names of keys used to create
a hierarchical index.


Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14292?src=pr) is 85.25% (diff: 100%)

> Merging [#14292](https://codecov.io/gh/pydata/pandas/pull/14292?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14292   diff @@
==========================================
  Files           140        140          
  Lines         50632      50634     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43171      43170     -1   
- Misses         7461       7464     +3   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [daba8e5...cdc76f6](https://codecov.io/gh/pydata/pandas/compare/daba8e55239eadfb7d6e4d28198981d8ad8de1ea...cdc76f6f0e2fd5e307f3a335afc23385d1e8234f?src=pr)

@jreback I think all comments are addressed now.

@jreback Changed whatsnew entry to 0.19.1. Is there anything left to do before merging?

thanks @bkandel
TST: remove usages of np.full_like for numpy<1.8.0 compat
State: closed

- [x] closes ##14276
- [x] passes `git diff upstream/master | flake8 --diff`


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14277?src=pr) is 85.25% (diff: 100%)

> Merging [#14277](https://codecov.io/gh/pydata/pandas/pull/14277?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #14277   diff @@
==========================================
  Files           140        140          
  Lines         50568      50568          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43113      43113          
  Misses         7455       7455          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [755886c...e098fd7](https://codecov.io/gh/pydata/pandas/compare/755886c9a4406e8f5bcfff9d6bbaf40009f3cad4...e098fd734b6bd8a5d750d6ed950d62fdaade3061?src=pr)

thanks!
DOC: Typo fix in ordered_merge warning
State: closed


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14271?src=pr) is 85.25% (diff: 100%)

> Merging [#14271](https://codecov.io/gh/pydata/pandas/pull/14271?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14271   diff @@
==========================================
  Files           140        140          
  Lines         50568      50579    +11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43112      43123    +11   
  Misses         7456       7456          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [a7469cf...64e97d6](https://codecov.io/gh/pydata/pandas/compare/a7469cf98275a183ad2e4bfafa9706a1ef8d035e...64e97d6921a73d27ec0a20e289216b61524a85cf?src=pr)

@jerenrich Thanks!
Update Github issue template
State: closed

Mostly just using the `details` tag to reduce some clutter in all the issues, e.g.

---
#### A small, complete example of the issue

``` python
# Your code here
def fib(n):
    return fib(n-1) + fib(n-2)
```
#### Expected Output

Nothing
#### Output of `pd.show_versions()`

<details>
## INSTALLED VERSIONS

commit: None
python: 3.5.2.final.0
python-bits: 64
OS: Darwin
OS-release: 15.6.0
machine: x86_64
processor: i386
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
LOCALE: en_US.UTF-8

pandas: 0.19.0rc1+21.ge596cbf
nose: 1.3.7
pip: 8.1.2
setuptools: 26.1.1
Cython: 0.25a0
numpy: 1.11.1
scipy: 0.18.0
statsmodels: 0.8.0rc1
xarray: 0.7.2
IPython: 5.1.0
sphinx: 1.4.6
patsy: 0.4.1
dateutil: 2.5.3
pytz: 2016.6.1
blosc: 1.4.1
bottleneck: 1.0.0
tables: 3.2.2
numexpr: 2.6.1
matplotlib: 1.5.2
openpyxl: 2.3.5
xlrd: 0.9.4
xlwt: 1.0.0
xlsxwriter: None
lxml: 3.4.4
bs4: 4.4.1
html5lib: 0.9999999
httplib2: 0.9.2
apiclient: 1.5.1
sqlalchemy: 1.0.12
pymysql: 0.7.6.None
psycopg2: 2.6.2 (dt dec pq3 ext lo64)
jinja2: 2.8
boto: 2.39.0
pandas_datareader: None

</details>


Labels:

Comments:
+1 for the code snippet (indeed a lot of people don't do that)

What does the `<details>` do exactly? I don't see a difference in your top post (which uses it)

Ah, apparantly it is a firefox issue (in chrome it does work nicely! That's indeed very nice), but should be fixed in upcoming firefox (https://gist.github.com/ericclemmons/b146fe5da72ca1f706b2ef72a20ac39d)

~~Maybe we can adapt the details 'title' to indicate that the installed versions are in the details?~~ No matter, there is still the title in the template above the details

I edited the original to include a sample of what a new issue would look like.

lgtm

Firefox now also supports it! :-)

I am going to merge this, we can always refine later
BUG: float truncation in eval with py 2
State: closed

- [x] closes #14241
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Python 2 only - apparently `str()` rounds shorter than `repr()`

```
In [1]: f = 1000000000.006

In [2]: str(f)
Out[2]: '1000000000.01'

In [3]: repr(f)
Out[3]: '1000000000.006'
```


Labels:
name: Bug
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14255?src=pr) is 85.25% (diff: 100%)

> Merging [#14255](https://codecov.io/gh/pydata/pandas/pull/14255?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14255   diff @@
==========================================
  Files           140        140          
  Lines         50568      50572     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43112      43116     +4   
  Misses         7456       7456          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [a7469cf...d679aa3](https://codecov.io/gh/pydata/pandas/compare/a7469cf98275a183ad2e4bfafa9706a1ef8d035e...d679aa34119a2e588ed70f3bf64795e3ec1d0f26?src=pr)

can you change the pytables test to add 3 values, then have the scalar select the middle one select and having it return empty doesn't prove it works, more like proves it doesn't not work :>

i don't know how equality of floats works in numexpr / HDF5

it might test well for us but fail on some platforms (just a guess) - so include if passes 

thanks!
TST: Fix generator tests to run
State: closed

Closes #14244

This class inheriting from TestCase caused
the tests the yield fixture tests to not actually
run. The new output is

```
nosetests pandas/computation/tests/test_eval.py:TestTypeCasting
........................................
----------------------------------------------------------------------
Ran 40 tests in 0.264s

OK
```


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14245?src=pr) is 85.25% (diff: 100%)

> Merging [#14245](https://codecov.io/gh/pydata/pandas/pull/14245?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14245   diff @@
==========================================
  Files           140        140          
  Lines         50560      50560          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43101      43104     +3   
+ Misses         7459       7456     -3   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [db9dc65...56f6028](https://codecov.io/gh/pydata/pandas/compare/db9dc65a29667667c66f3d9759c4cb2048d85b34...56f6028fffa323908813ac36fd8d9174226038e3?src=pr)

thanks @TomAugspurger
Revert "TST/TEMP: fix pyqt to 4.x for plotting tests"
State: closed

Reverts pydata/pandas#14240

For when https://github.com/ContinuumIO/anaconda-issues/issues/1068 is solved


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Also needs to revert https://github.com/pydata/pandas/commit/b99cb7ab225f432da4dfe73e0882e1de3db121b6

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14243?src=pr) is 85.26% (diff: 97.14%)

> Merging [#14243](https://codecov.io/gh/pydata/pandas/pull/14243?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **0.01%**

``` diff
@@             master     #14243   diff @@
==========================================
  Files           140        140          
  Lines         50559      50619    +60   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43099      43160    +61   
+ Misses         7460       7459     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [e8357a1...b99cb7a](https://codecov.io/gh/pydata/pandas/compare/e8357a15cd61ff698cbd3d57904133c586a8ed8b...b99cb7ab225f432da4dfe73e0882e1de3db121b6?src=pr)

@jorisvandenbossche ?
Wanted to close and reopen to trigger travis (to see if it is fixed), but can't reopen -> new PR https://github.com/pandas-dev/pandas/pull/14744
TST/TEMP: fix pyqt to 4.x for plotting tests
State: closed

To fix breaking tests (latest travis build on master broken, and also all recent PR builds), see https://github.com/matplotlib/matplotlib/issues/7124


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14240?src=pr) is 85.24% (diff: 100%)

> No coverage report found for **master** at e596cbf.
> 
> Powered by [Codecov](https://codecov.io?src=pr). Last update [e596cbf...f961d59](https://codecov.io/gh/pydata/pandas/compare/e596cbf82410fcb19d7c8cbe2f22a8b588afd390...f961d594fbd52070bd124ed8efa0f514da920caa?src=pr)

See https://github.com/ContinuumIO/anaconda-issues/issues/1068
BUG: set_levels set illegal levels.
State: closed

- [x] closes #13754
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

`MultiIndex.set_levels`, when given illegal level values, raises an error.
When `inplace=True`, though, the illegal level values are still accepted. This
commit fixes that behavior by checking that the proposed level values are legal
before setting them.


Labels:
name: Bug
name: Error Reporting
description: Incorrect or improved errors from pandas
name: MultiIndex

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14236?src=pr) is 85.26% (diff: 100%)

> Merging [#14236](https://codecov.io/gh/pydata/pandas/pull/14236?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14236   diff @@
==========================================
  Files           140        140          
  Lines         50633      50634     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43170      43172     +2   
+ Misses         7463       7462     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [f9ebeae...39b7bde](https://codecov.io/gh/pydata/pandas/compare/f9ebeaeb08a9e897f36b463e83cbf72a2b9bdf07...39b7bde0a36f5278917a5e861cb60521d19ae27e?src=pr)

@jreback the Travis OSX build keeps on failing on conda install. Could you maybe delete the cache and restart the build? Or any other ideas? I'm pretty sure the failure is not caused by these changes.

minor comments, ping when green.

lgtm. ping on green.

you need to rebase as just merged #14303 

@jreback I believe I have addressed all of the comments.

@jreback I think all comments are addressed now.

thanks @bkandel lgtm.

@jorisvandenbossche can be the first back-port test!

@bkandel Thanks a lot!
ENH: Allow usecols to accept callable (GH14154)
State: closed

- [ X] closes #14154 
- [ X] tests added / passed
- [ X] passes `git diff upstream/master | flake8 --diff`
- [X ] whatsnew entry
  <img width="1515" alt="asv_bench" src="https://cloud.githubusercontent.com/assets/609873/18575075/942a9240-7ba1-11e6-9dca-bab8b9987f31.png">


Labels:
name: Enhancement
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14234?src=pr) is 85.28% (diff: 100%)
> Merging [#14234](https://codecov.io/gh/pandas-dev/pandas/pull/14234?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14234   diff @@
==========================================
  Files           144        144          
  Lines         50953      50963    +10   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43452      43462    +10   
  Misses         7501       7501          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [4378f82...9b0d112](https://codecov.io/gh/pandas-dev/pandas/compare/4378f82967f59097055eef17ede50aa515525551...9b0d112b7c18c4f31b66a283cfde383f9fec21cc?src=pr)
can you rebase, move whatsnew notes to 0.20.0, and add an example as indicated
Requested changes should have been made - let me know if there's anything else you would like to tweak for this enhancement
@WillAyd thanks. couple more pretty minor comments. otherwise lgtm.
All of your requested changes should be accounted for.  Let me know if anything else comes to mind.
I noticed that the Travis-CI build failed for OS X.  I didn't see anything useful in the log and checking their website it appears that the failure may have stemmed from issues on their end and not necessarily from the code.  Do you have a preferred method to restart that build?  Should I close / re-open the PR or do you have another way you'd like to restart that test?

<img width="868" alt="screen shot 2016-11-29 at 7 01 45 pm" src="https://cloud.githubusercontent.com/assets/609873/20734278/66c770c0-b666-11e6-9525-e87de7899461.png">

I restarted the job.
@WillAyd just a couple of minor comments. ping when green.
@jreback pushed some edits to cover your latest comments.  Let me know if there's anything else you'd like on this
lgtm. ping on green.
@WillAyd Thanks!
DOC: added example to Series.map showing use of na_action parameter (GH14231)
State: closed

- [x] closes #14231
- [x] tests passed
- [x] passes `git diff upstream/master | flake8 --diff`

Added example to Series.map showing use of na_action parameter.


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14232?src=pr) is 85.24% (diff: 100%)

> Merging [#14232](https://codecov.io/gh/pydata/pandas/pull/14232?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14232   diff @@
==========================================
  Files           140        140          
  Lines         50559      50559          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43099      43100     +1   
+ Misses         7460       7459     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [5e2f9da...b847717](https://codecov.io/gh/pydata/pandas/compare/5e2f9da6e8e713bd89cfe8760e63583ea7d29879...b847717103cb1d2e5ceddaae9abce2c7222e106f?src=pr)

@shawnheide Thanks a lot!
BUG: fix alignment in series ops (GH14227)
State: closed

- [x] closes #14227
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14230?src=pr) is 85.26% (diff: 76.92%)

> Merging [#14230](https://codecov.io/gh/pydata/pandas/pull/14230?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14230   diff @@
==========================================
  Files           140        140          
  Lines         50619      50630    +11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43161      43168     +7   
- Misses         7458       7462     +4   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [5033a4a...66d35d1](https://codecov.io/gh/pydata/pandas/compare/5033a4a799c77fdc7e868a9f332384eabcc332b8...66d35d19c8a9f481bfba6805e427411d9130b198?src=pr)

@jorisvandenbossche can you update

@jreback I moved this to align (and therefore also fixing the bug in align), but it is still not yet that clean ... 
So the problem for tz aware indexes is that `Index.join` does not returns indexers when the result does not need to be reindexed (although in case of tz aware indexes the actual indexes can be different and have to be adapted), and based on that the index of the result is adapted in `align` or not. So I still have to check for this specific case. I tried to solve it in `Index.join` itself, but that caused other errors.

if this works (and you want to push in 0.19.0), ok.. maybe just add a TODO / issue to fix/clean later (otherwise better wait for 0.19.1)

Well, it was a hack before, and it is still the exact same hack now, only moved down the stack into align (fixing the behaviour of align as well), so merging for now.
DOC: #14195. to_csv warns regarding quoting behaviour for floats
State: closed

- [x] closes #14195
- [ ] passes `git diff upstream/master | flake8 --diff`

Added a small warning that if `float_format` is set then floats will be quoted even if csv.QUOTE_NONNUMERIC is set


Labels:
name: Docs

Comments:
The linter complains about some trailing whitespace (hence the travis failure)

Can you also update this in `docs/source/io.rst`?

Sorry - sure

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14228?src=pr) is 85.24% (diff: 100%)

> Merging [#14228](https://codecov.io/gh/pydata/pandas/pull/14228?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14228   diff @@
==========================================
  Files           140        140          
  Lines         50559      50559          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43099      43100     +1   
+ Misses         7460       7459     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [5e2f9da...f3df0d9](https://codecov.io/gh/pydata/pandas/compare/5e2f9da6e8e713bd89cfe8760e63583ea7d29879...f3df0d90627f6cbe2c51496c3ab0ac1fcca120bb?src=pr)

lgtm. @jorisvandenbossche 

Yes, looks good. @theultimatecrouton Thanks!