BrandonFors/pandas-github-issues huggingface dataset:
TYP #37715: Fix mypy errors in column.py
State: closed

- [ ] xref #37715 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Huh strange - I guess that's why this was ignored before. That said, I think the property decorator is correct, at least according to the dataframe protocol

https://data-apis.org/dataframe-protocol/latest/API.html

So I think you can update the tests and add a whatsnew note describing this as a bug fix

@jorisvandenbossche 
> That said, I think the property decorator is correct, at least according to the dataframe protocol
> 
> https://data-apis.org/dataframe-protocol/latest/API.html

Hmm, the documentation seems to be not up to date. This was originally a property, but changed to a method a while ago (https://github.com/data-apis/dataframe-api/pull/74#discussion_r841112693), so the currently implementation here is actually correct.
Thanks for the pull request, but I believe this was addressed and fixed in #50565 so closing. Happy to have your contributions on any other typing issues!
CI: remove aiobotocore pin
State: closed

Closes https://github.com/pandas-dev/pandas/issues/44311

Labels:
name: CI
description: Continuous Integration

Comments:
The doc build is passing. 
Hmm, not sure what went wrong there ;)
This is odd, but the install requirements failure is legit. Installing asv==0.5.0 locally with pip is failing as well. Not sure why we are pulling an older version here
But the strange thing is that it is not failing on main? maybe some pip cache related issue?
It doesn't explain why it starts to happen now, but we should probably pin to 0.5.1 since that fixed the issue with requirements-dev.txt: https://github.com/airspeed-velocity/asv/commit/516e283a7e7d835e161ac91f4e5e2e2c501a6192
thx @jorisvandenbossche
DEV: remove downstream test packages from environment.yml
State: closed

xref https://github.com/pandas-dev/pandas/issues/49998

Labels:
name: CI
description: Continuous Integration
name: Dependencies
description: Required and optional dependencies

Comments:
There is still a doc error from using statsmodels in an old whatsnew file, will convert that to plain code block.
lgtm when green
> There is still a doc error from using statsmodels in an old whatsnew file, will convert that to plain code block.

I went ahead and did this, hope it's OK
> I went ahead and did this, hope it's OK

Sure!
Should we document in the contributing docs for now that you need to install a few additional packages to be able to run all tests in `test_downstream.py` ?  
(`pip/conda install seaborn scikit-learn statsmodels cftime pandas-datareader`)

I am not fully sure this is necessarily worth mentioning (it makes the docs more complex with yet another note, while in practice contributors won't often need this)
I think it's OK to not mention this - very few contributors will be running the downstream tests anyway, and for those who do, the error message will typically make it clear what they need to install
I additionally also removed `pandas-gbq`, because 1) this is actually a big dependency (with conda, indirectly it is still bringing in geopandas and its dependencies (GDAL etc)), and 2) we actually only need this for `test_downstream.py` so it _is_  a "downstream" dependency in that sense (it seems that all actual tests of `read_gbq` / `to_gbq` have been removed because this functionality is tested in pandas-gbq itself now)
It would be nice to have a list of downstream dependencies somewhere. Not necessarily in the docs though. Maybe inside the test file itself?
TST: Added test for groupby dropping NA when grouping on columns
State: closed

- [x] closes #21755
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Closing as stale. @pbhoopala - if you're interested in continuing just comment here and happy to reopen.
BUG: displaying NaN in complex numbers does not work
State: closed

- [x] closes #50069 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Not sure if this is the best way to format things

Labels:
name: Output-Formatting
description: __repr__ of pandas objects, to_string
name: Complex
description: Complex Numbers
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: add examples to get_indexer_non_unique
State: closed

- [X] closes #50132
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Updated docstring for `Index.get_indexer_non_unique`. Added examples to clarify `Index.get_indexer_non_unique` behavior.

Labels:
name: Docs

Comments:
> thanks for working on this

Thank you @MarcoGorelli for reviewing my PR.
Some tests in CI failed, I am not sure if it’s related to my changes. Locally (on Linux) test `pandas/tests/indexes/object/test_indexing.py` passes. My local python version in mamba environment is `3.8.15`. It’s interesting that Python `3.11` is used in CI.
ENH: improve error reporting for dup columns in merge_asof
State: closed

- [x] closes #50102 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
Thanks @phofl
PERF: Speed up Period construction
State: closed

- [ ] closes #38312 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

ASVs.
```
       before           after         ratio
     [1d5ce5b3]       [b47aa45a]
     <main>           <period-speedup>
-     8.18±0.06ms       5.50±0.1ms     0.67  period.PeriodIndexConstructor.time_from_ints_daily('D', False)
-     8.06±0.06ms       5.36±0.1ms     0.67  period.PeriodIndexConstructor.time_from_ints_daily('D', True)
-     8.94±0.08ms      5.31±0.04ms     0.59  period.PeriodIndexConstructor.time_from_ints('D', False)
-     8.77±0.09ms       5.20±0.1ms     0.59  period.PeriodIndexConstructor.time_from_ints('D', True)

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.
```

parse_time_string already calls string_to_dts(parse_iso_8601_datetime), which I think is the only function that can currently parse nanoseconds(dateutil can't do it IIRC). 

Labels:
name: Performance
description: Memory or execution speed performance
name: Period
description: Period data type

Comments:
are the improvements in parsing.pyx independent of the improvements in period.pyx?
needs rebase, otherwise LGTM
Thanks for the reviews.

This PR depends on  #50417, though, so need someone to review/re-review there.
ping on green
PERF: Split blocks in blk.delete
State: closed

- [x] closes #46267 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

```
       before           after         ratio
     [a047fb6c]       [e8c3a52a]
-      1.16±0.01s         962±10μs     0.00  indexing.Setitem.time_setitem_list
-         382±7ms         302±10μs     0.00  indexing.Setitem.time_setitem
```

Labels:
name: Performance
description: Memory or execution speed performance
name: Internals
description: Related to non-user accessible pandas implementation

Comments:
cc @jbrockmendel would you mind having a look here?
will look over the weekend (applies to many many pings in my inbox)
looks like some mypy complaints
Thx, fixed mypy
Thanks @phofl
DOC restructure contributing environment guide
State: closed

- [ ] closes #50134 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Hey @noatamir , thoughts on this? I think it's clearer to split it up into 3 steps:

![image](https://user-images.githubusercontent.com/33491632/206668601-02e3dfb7-0d3e-4093-8654-f295535e03ff.png)

I've also removed some parts which are arguably unnecessary

Labels:
name: Docs

Comments:
Just noticed https://github.com/pandas-dev/pandas/pull/50144 - let's try to get that one in first
thanks! @natmokval seeing as you went through this not too long ago, reckon it makes it clearer for new contributors?
@meeseeksdev please backport to 1.5.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 70eef55e438823697515e834ee4ac350bdb0aaa7
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #50145: DOC restructure contributing environment guide'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-50145-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #50145 on branch 1.5.x (DOC restructure contributing environment guide)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@meeseeksdev please backport to 1.5.x
DOC: BT for VisualStudio2022
State: closed

- [x] closes #49799
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
The problem with documentation for the installation guide was fixed. I checked that the setting environment using Build Tools for Visual Studio 2022 works well.

The set of components is the same as with UI installation.



Labels:
name: Docs

Comments:
@meeseeksdev please backport to 1.5.x
DOC: Add example for pandas.DataFrame.rolling() with ``on``
State: closed

- [x] closes #50080

I'm a newbie, and welcome any comments!


Labels:
name: Docs
name: Window
description: rolling, ewma, expanding

Comments:
> It looks like the docstring validation is failing. Could you investigate?
> 
> I think one example is sufficient

Ok, I will try to pass the docstring validation, and reduce two example to one.

Thanks for your comments!
When I use `python make.py --single pandas.DataFrame.rolling`, there is a warning, `WARNING: extlinks: Sphinx-6.0 will require a caption string to contain exactly one '%s' and all other '%' need to be escaped as '%%'.`,  I'm not sure that matters.
I'm so sorry that my improper operation messed up the PR!
> Almost there 💪

How about this one 😄

 Thank you for taking the time to share your thoughts with me. I really appreciate your review.
feat: fsspec auto_mkdir set to true unless given
State: closed

- [X] closes https://github.com/pandas-dev/pandas/issues/50135
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks but closing as in https://github.com/pandas-dev/pandas/issues/50135 it was deemed that this should be addressed in fsspec
API: ensure IntervalIndex.left/right are 64bit if numeric
State: closed

Extracted part for #49560, slightly altered.

`IntervalIndex` depends on `IntervalTree` which only accepts 64-bit int/uint/floats. This ensures that numpy numeric arrays in `IntervalTree` will always be 64-bit.

A question is if we should have non-64bit `IntervalTree`s. I've considered that that is maybe a different question than #49650, and  I could write an issue about it and someone could take it in a follow-up, possibly before 2.0?

This PR changes nothing  functionality-wise, but is needed when `Index` can have non-64bit indexes after #49650.

Labels:
name: Interval
description: Interval data type

Comments:
> Is there a use-case for non 64-bit arrays?

Not for me personally, it was more of a question I had when I wrote the code, and we now will support non-64-bit indexes. IMO this can come later, if someone sees a need for it. 
Sounds good to me. What we have to keep in mind a bit: If we compile IntervalTree for all possible dtypes, this will further increase the size of pandas for end users. So as long as there is no use case, I would keep as is. But open to revisit if there is a situation where this would be helpful
Yeah, I agree.

I’ve updated the PR.
Thx @topper-123
CI: fix with new numpy nightly
State: closed

- [ ] xref #50124 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
 Can we merge this to get ci running again and address the topics raised in follow ups?
> Can we merge this to get ci running again and address the topics raised in follow ups?

That's a good idea, IMO.
OK, I've removed the `closes` keyword, so we can keep https://github.com/pandas-dev/pandas/issues/50124 open to keep discussing this
> > Can we merge this to get ci running again and address the topics raised in follow ups?
> 
> That's a good idea, IMO.

Merging then, let's take this conversation forwards in the issue https://github.com/pandas-dev/pandas/issues/50124
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 5fad2e4e90be46c14e947ac1a7eba3275c4b656d
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #50129: CI: fix with new numpy nightly'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-50129-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #50129 on branch 1.5.x (CI: fix with new numpy nightly)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
Backport PR #49771 on branch 1.5.x (PERF: Use fastpath for accessing option value in internals)
State: closed

Backport PR #49771: PERF: Use fastpath for accessing option value in internals

Labels:
name: Performance
description: Memory or execution speed performance

Comments:
Hmm, the test that I added is failing, but I can't reproduce this locally (using the branch from this PR)
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
BUG: Series read_json tries to convert all column values to dates even when using keep_default_dates=True, if one column has an na value FIX
State: closed

- [ ] closes #49585 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
As noted here, this isn't the solution, sorry https://github.com/pandas-dev/pandas/issues/49585#issuecomment-1342263806
> As noted here, this isn't the solution, sorry [#49585 (comment)](https://github.com/pandas-dev/pandas/issues/49585#issuecomment-1342263806)

closing then, but thanks for your pr
PERF: I was looking into this file and a saw some duplicate strings so i cr…
State: closed

…eated a constant for those strings"

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
agreed, `"mode.data_manager"` is simple and clear, no need for a constant

thanks anyway for your pr
Alternate Ubuntu CI fix
State: closed

@MarcoGorelli @lithomas1 @jbrockmendel 

I think if we clean up some of this dead code we can support a clean build on newer gcc. Lots of layers of indirection to sift through so not entirely clear on what's happening, but I think gcc isn't going to be happy with some of the paths this theoretically produces

https://github.com/pandas-dev/pandas/issues/22234

Labels:
name: CI
description: Continuous Integration

Comments:
This is also failing on 1.5.x, can we backport or should we pin the ubuntu version?
probably fine to backport?
@meeseeksdev please backport to 1.5.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 5fe95c60c7b1db349a92e36b23816cfd4f2cc515
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #50117: Alternate Ubuntu CI fix'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-50117-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #50117 on branch 1.5.x (Alternate Ubuntu CI fix)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).