BUG: fix parsing of ODF time values with comments
State: closed

- [x] Similar to: #55200 variant for `time-value` cells
- [x] Tests: added comments to cells in `test_1900.ods` and `test_1904.ods` fixtures, so that [`io/excel/test_readers.py:test_reader_seconds()`](https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/excel/test_readers.py#L976-L1015) would be failing without this fix. Also fixed missing microseconds there (see p.1 in #55045).
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.2.0.rst` file.

> ODF `office:time-value` format is specified by [p.3.2.6 of XML Schema (Part 2)](https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/#duration) as referenced in [p.19.389 of OpenDocument Schema Part 3](https://docs.oasis-open.org/office/OpenDocument/v1.3/OpenDocument-v1.3-part3-schema.html#attribute-office_value-type)

Related to: #55045 (test files updates)

Labels:
name: IO Excel
description: read_excel, to_excel
name: Stale

Comments:
On a493bb794eee30a48edefc2f920fcb093dfd2276, I've refactored the helper function into `_get_cell_time_value()` - similar to existing `_get_cell_string_value()` for strings.
Pardon me not grasping the `ODFReader` class layout in the first place...
@rhshadrach @mroeschke @dimastbk

Would there be anything else I should do on this PR ?
> [mzuzek](https://github.com/mzuzek) [force-pushed](https://github.com/pandas-dev/pandas/compare/7c22815ea69a3b2e1bbd117b88a90db47ab24ed5..ea23a2e501a8db58b07907899383d3ce3e49faa3) the fix-odf-time-comments branch from [7c22815 ](https://github.com/pandas-dev/pandas/commit/7c22815ea69a3b2e1bbd117b88a90db47ab24ed5)to [ea23a2e ](https://github.com/pandas-dev/pandas/commit/ea23a2e501a8db58b07907899383d3ce3e49faa3)
[yesterday](https://github.com/pandas-dev/pandas/pull/55324#event-10571687912)

Just so you're aware, by force pushing you make it so that reviewers can no longer use the "Show changes since your last review" feature. Not a big deal at all here because the diff is so small.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
@rhshadrach @mroeschke @dimastbk

Thank you for reviewing this PR and for all your comments.

I'm sorry it didn't work out:
I understand that after all review issues and requests have been properly addressed - as confirmed [here](https://github.com/pandas-dev/pandas/pull/55324#pullrequestreview-1662225869) -    
this PR was blocked by discussions which haven't introduced any new problems or change requests (last one [here](https://github.com/pandas-dev/pandas/pull/55324#discussion_r1353434324)).  
I'll assume it's just the way things work here.