BrandonFors/pandas-github-issues huggingface dataset:
Small ops cleanups
State: closed

Consistently use `op_name` and `res_name` and avoid `name`

Use find_common_type instead of np.find_common_type, moving towards de-duping Series/Frame code.

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19972?src=pr&el=h1) Report
> Merging [#19972](https://codecov.io/gh/pandas-dev/pandas/pull/19972?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/a7a7f8c1101aed1a9d37abbbcd80f77da414f0a8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `97.77%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19972/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19972?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19972   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         150      150           
  Lines       49045    49045           
=======================================
  Hits        44951    44951           
  Misses       4094     4094
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.03% <97.77%> (ø)` | :arrow_up: |
| #single | `41.79% <86.66%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19972?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/19972/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvb3BzLnB5) | `96.33% <97.77%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19972?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19972?src=pr&el=footer). Last update [a7a7f8c...ac3f6c5](https://codecov.io/gh/pandas-dev/pandas/pull/19972?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
DOC: update docstring validation script
State: closed

Follow-up on https://github.com/pandas-dev/pandas/pull/19898

cc @datapythonista 

Labels:
name: Docs

Comments:
Something related, but the `Series.str`, `Series.cat`, `Series.dt` accessors themselves are not included in the overview (spreadsheet) I think. They should be documented as well, so that's something to fix (or add manually)
The csv generated should have a row for each item in `doc/source/api.rst`. Unless there is a bug in the script, if they are missing it's because they are missing from that document, and they should be added there if we want to include them in the documentation.
They are in api.rst, but as a comment, so depending on how it is parsed that might give a problem: https://github.com/pandas-dev/pandas/blame/master/doc/source/api.rst#L674-L681
BUG: Preserve column metadata with DataFrame.astype
State: closed

- [X] closes #19920
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry

Follow-up to #18099

Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19948?src=pr&el=h1) Report
> Merging [#19948](https://codecov.io/gh/pandas-dev/pandas/pull/19948?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c8859b57b891701f250fb05f2cc60d2e6cae2d6b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19948/graphs/tree.svg?token=eZ4WkYLtcO&width=650&src=pr&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19948?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19948      +/-   ##
==========================================
+ Coverage   91.66%   91.66%   +<.01%     
==========================================
  Files         150      150              
  Lines       49027    49028       +1     
==========================================
+ Hits        44940    44941       +1     
  Misses       4087     4087
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.04% <100%> (ø)` | :arrow_up: |
| #single | `41.83% <40%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19948?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/19948/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `95.89% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19948?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19948?src=pr&el=footer). Last update [c8859b5...20c1bd8](https://codecov.io/gh/pandas-dev/pandas/pull/19948?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Making to_datetime('today') and Timestamp('today') consistent
State: closed

This PR changes `pd.to_datetime` to be consistent with `Timestamp('today')`.

- [x] closes #19935
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Datetime
description: Datetime data dtype
name: API Design

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19937?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@9242248`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19937/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19937?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19937   +/-   ##
=========================================
  Coverage          ?   91.66%           
=========================================
  Files             ?      150           
  Lines             ?    49026           
  Branches          ?        0           
=========================================
  Hits              ?    44939           
  Misses            ?     4087           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.04% <ø> (?)` | |
| #single | `41.83% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19937?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19937?src=pr&el=footer). Last update [9242248...680000e](https://codecov.io/gh/pandas-dev/pandas/pull/19937?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
DOC: add doc on ExtensionArray and extending pandas
State: closed

- Added a new page on extending pandas
- Added some prose on extension arrays / extension dtypes
- Moved subclassing there
- Added a section to ecosystem.rst about libraries providing extension types and accessors.

Labels:
name: Docs
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19936?src=pr&el=h1) Report
> Merging [#19936](https://codecov.io/gh/pandas-dev/pandas/pull/19936?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/6ef4be3f8f269f147b5abedecf7da6f19af305d3?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19936/graphs/tree.svg?src=pr&width=650&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19936?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19936      +/-   ##
==========================================
- Coverage   91.69%   91.66%   -0.04%     
==========================================
  Files         150      150              
  Lines       48981    49026      +45     
==========================================
+ Hits        44913    44939      +26     
- Misses       4068     4087      +19
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.04% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.83% <ø> (-0.03%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19936?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/accessor.py](https://codecov.io/gh/pandas-dev/pandas/pull/19936/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYWNjZXNzb3IucHk=) | `98.7% <ø> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19936/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |
| [pandas/core/groupby.py](https://codecov.io/gh/pandas-dev/pandas/pull/19936/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS5weQ==) | `92.14% <0%> (-0.18%)` | :arrow_down: |
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/19936/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `95.88% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19936?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19936?src=pr&el=footer). Last update [6ef4be3...87aca05](https://codecov.io/gh/pandas-dev/pandas/pull/19936?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Doc build finished. Merging in a bit.
Thanks!
Adding sample datasets to be used in the documentation
State: closed

- [X] closes #19710 
- [ ] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Docs

Comments:
I thought we had an issue about this already, IIRC @mrocklin either made it or commented (was for a slightly different purpose though).
We already have lots of data constructors in ``pandas.util.testing``, though these are 'nicer' ones. These would need testing (e.g. do they run), and can be de-privatized (no leading _). 
> I thought we had an issue about this already, IIRC @mrocklin either made it or commented (was for a slightly different purpose though).

I don't know if there is an older issue, but this is related to what is recently discussed in https://github.com/pandas-dev/pandas/issues/19710 as @datapythonista linked to.

> We already have lots of data constructors in pandas.util.testing, though these are 'nicer' ones.

Indeed, I don't think the ones in util.testing are suitable for this, as the exact purpose of those are to be 'nicer' relate-able small dataframes.
Any more thoughts on this? Knowing which data to use for the examples in the docstrings is the main blocker for the sprint. Any feedback on how you think we can improve this first draft is highly appreciated. Thanks!
This needs to be imported in some `__init__` files, as otherwise you cannnot do `pd.io.samples. ...`. Or what would be the intended use in the docs?
For what has been discussed in #19710, seems like it probably makes more sense to simply have some ideas on data to be used, but use custom datasets as simple and illustrative as possible depending on each case. So, closing this.
Add documentation to pandas.core.groupby.GroupBy.apply
State: closed

It took me a few hours to figure out how to edit rows from `groupBy` objects until I scavenged the code.


Labels:
name: Docs
name: Groupby

Comments:
Hello @Rafalonso! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on February 27, 2018 at 19:52 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19927?src=pr&el=h1) Report
> Merging [#19927](https://codecov.io/gh/pandas-dev/pandas/pull/19927?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f4c9d966fb20d9ca3221d31bd9eb31117065808c?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19927/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19927?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19927      +/-   ##
==========================================
+ Coverage   91.66%   91.69%   +0.02%     
==========================================
  Files         150      150              
  Lines       48974    48974              
==========================================
+ Hits        44894    44906      +12     
+ Misses       4080     4068      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.07% <ø> (+0.02%)` | :arrow_up: |
| #single | `41.85% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19927?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby.py](https://codecov.io/gh/pandas-dev/pandas/pull/19927/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS5weQ==) | `92.31% <ø> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19927/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19927?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19927?src=pr&el=footer). Last update [f4c9d96...17d3037](https://codecov.io/gh/pandas-dev/pandas/pull/19927?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@pandas-dev/pandas-core needs a rebase
@jreback : Given @TomAugspurger comment [above](https://github.com/pandas-dev/pandas/pull/19927#discussion_r171063351), I wonder if it might be best to close.  This PR has been dormant for a long time, and I'm not seeing the immediate benefit of this addition unfortunately.
After consideration I agree that this PR doesn't provide much value. Thanks for the comments.
TST: Debug flaky plotting test
State: closed

Maybe closes https://github.com/pandas-dev/pandas/issues/19924. I can't reproduce this locally so who knows.

A while back I went through and added `plt.subplots()`  and explicit `ax=ax` to a bunch of the plotting tests. I apparently missed this one. It seemed to help, but they're flaky tests so who knows.

Also chanegd `idx1.equals(idx2)` to `tm.assert_frame_equal` so we get a better error message when it does fail.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Visualization
description: plotting
name: Unreliable Test
description: Unit tests that occasionally fail

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19925?src=pr&el=h1) Report
> Merging [#19925](https://codecov.io/gh/pandas-dev/pandas/pull/19925?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f4c9d966fb20d9ca3221d31bd9eb31117065808c?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19925/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19925?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19925      +/-   ##
==========================================
+ Coverage   91.66%   91.69%   +0.02%     
==========================================
  Files         150      150              
  Lines       48974    48974              
==========================================
+ Hits        44894    44906      +12     
+ Misses       4080     4068      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.07% <ø> (+0.02%)` | :arrow_up: |
| #single | `41.85% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19925?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19925/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19925?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19925?src=pr&el=footer). Last update [f4c9d96...dd66dc5](https://codecov.io/gh/pandas-dev/pandas/pull/19925?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

It passed, not sure if it helped or not.

Merging later today if there are no objections.
offsets/liboffsets cleanup
State: closed

working on making DateOffset immutable enough unrelated changes added up to merit separating them out into this PR.  No logic is affected.

Labels:
name: Frequency
description: DateOffsets
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19922?src=pr&el=h1) Report
> Merging [#19922](https://codecov.io/gh/pandas-dev/pandas/pull/19922?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7561eb8a2a20e7e896cf82a5b8796ae93ccd5574?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19922/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/19922?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19922      +/-   ##
==========================================
+ Coverage   91.66%   91.69%   +0.02%     
==========================================
  Files         150      150              
  Lines       48974    48921      -53     
==========================================
- Hits        44894    44857      -37     
+ Misses       4080     4064      -16
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.06% <100%> (+0.02%)` | :arrow_up: |
| #single | `41.85% <36.36%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/19922/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `97.21% <100%> (+0.2%)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19922/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19922?src=pr&el=footer). Last update [7561eb8...d1f4d3d](https://codecov.io/gh/pandas-dev/pandas/pull/19922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Consistent Timedelta Writing for all Excel Engines
State: closed

- [X] closes #19900
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry

I've basically copied the implementation that was done for the `XlwtWriter` class in #19244 over to the other engine subclasses for an easy fix. This might also fix #19911

Labels:
name: IO Excel
description: read_excel, to_excel
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19921?src=pr&el=h1) Report
> Merging [#19921](https://codecov.io/gh/pandas-dev/pandas/pull/19921?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/74dbfd0aa9b44936a4db7969bfe25f526fef53ce?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19921/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19921?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19921      +/-   ##
==========================================
- Coverage   91.68%   91.65%   -0.03%     
==========================================
  Files         150      150              
  Lines       48976    48976              
==========================================
- Hits        44903    44891      -12     
- Misses       4073     4085      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.03% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.85% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19921?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19921/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19921?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19921?src=pr&el=footer). Last update [74dbfd0...3fd5187](https://codecov.io/gh/pandas-dev/pandas/pull/19921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

The Travis failure is coming from `TestTSPlot.test_mixed_freq_regular_first` and does not appear related to the change made at all.  All green otherwise
thanks @WillAyd nice patch! does this close #19911 ?