ENH: between_time, at_time accept axis parameter
State: closed

xref #2141 

- [x] closes #8839
- [x] tests added / passed

Axis parameter added to between_time and at_time, defaults to index for DataFrame


Labels:
name: Enhancement
name: Datetime
description: Datetime data dtype

Comments:
Hello @yrhooke! Thanks for updating the PR.







Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on August 09, 2018 at 13:30 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21799?src=pr&el=h1) Report
> Merging [#21799](https://codecov.io/gh/pandas-dev/pandas/pull/21799?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/91d1c50327c209e03ffc32c5fd64f9666de81e20?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21799/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21799?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21799      +/-   ##
==========================================
+ Coverage   92.24%   92.24%   +<.01%     
==========================================
  Files         161      161              
  Lines       51433    51441       +8     
==========================================
+ Hits        47446    47454       +8     
  Misses       3987     3987
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.64% <100%> (ø)` | :arrow_up: |
| #single | `42.28% <7.69%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21799?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/21799/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `96.84% <100%> (+0.01%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21799?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21799?src=pr&el=footer). Last update [91d1c50...9ae360f](https://codecov.io/gh/pandas-dev/pandas/pull/21799?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

a nice followup would be #2141 (separate PR after this one)
Alright, I'm on it.
I hope it's alright now. 

`test_between_time_axis` and `test_between_time_axis_raises` are trying to account for the scenarios where neither axis is a DatetimeIndex or that both are. If those are extraneous I can simplify them. 

Also, should these tests be combined into the main `test_between_time`, `test_at_time`? I'm not sure what's preferred here.
can you rebase and add those tests, otherwise lgtm.
can you rebase and update
I rebased and updated the tests, they're kind of awkwardly built, I couldn't figure out what the axis fixture was. 
think this got lost, can you rebase
can you merge master
ok i rebased this.
thanks @yrhooke