BrandonFors/pandas-github-issues huggingface dataset:
Tests for fixed issues in Series[datetime64]
State: closed

- [x] closes #12534, closes #19071
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Datetime
description: Datetime data dtype

Comments:
@jbrockmendel : To properly close #12534, you should also add documentation per the discussion.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19072?src=pr&el=h1) Report
> Merging [#19072](https://codecov.io/gh/pandas-dev/pandas/pull/19072?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/4a8496b2bf02df521b6b7f15843c515545a3d192?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19072/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19072?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19072      +/-   ##
==========================================
- Coverage   91.54%   91.51%   -0.03%     
==========================================
  Files         148      148              
  Lines       48804    48804              
==========================================
- Hits        44676    44664      -12     
- Misses       4128     4140      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.89% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.63% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19072/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19072?src=pr&el=footer). Last update [4a8496b...b2db46f](https://codecov.io/gh/pandas-dev/pandas/pull/19072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> To properly close #12534, you should also add documentation per the discussion

@gfyoung Can you expand on what you have in mind here?
> were these fixed by a previous PR? can you reference it

For one of the tests I know it was fixed by #19024.  For the other I'm not sure when it got fixed (but certainly no later than 19024)
thanks, if these issues are not in the whatsnew pls add (new PR).
DEPR: removing to_long and toLong, deprecated in 0.7.0
State: closed

- [X] closes #19077 
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry

  

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
can you add a note to the Deprecations section. Also can you see if you can see when this was deprecated originally? its not in our master list.
@jreback I created an issue, with the information on when it was deprecated (in 2011), and added the note in whatsnew doc. Thanks a lot for the reviews, they're really helpful. Please let me know if this requires something else.
lgtm. ping on green.
thanks!
Revert "CI: fix conda version (#19025)"
State: closed

This reverts commit c19bdc98fa3f856e2e6b3495bbab88b587801987.


Labels:
name: CI
description: Continuous Integration

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19062?src=pr&el=h1) Report
> Merging [#19062](https://codecov.io/gh/pandas-dev/pandas/pull/19062?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/6552718d2a908a57b88354fe916609631793131e?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19062/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19062?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19062      +/-   ##
==========================================
+ Coverage   91.56%   91.57%   +<.01%     
==========================================
  Files         150      150              
  Lines       48942    48942              
==========================================
+ Hits        44816    44818       +2     
+ Misses       4126     4124       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.93% <ø> (ø)` | :arrow_up: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19062?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/19062/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.95% <0%> (+0.21%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19062?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19062?src=pr&el=footer). Last update [6552718...78e5cb5](https://codecov.io/gh/pandas-dev/pandas/pull/19062?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
TST: Remove clipboard-excel test warnings
State: closed

Closes #19010.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO Excel
description: read_excel, to_excel

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19052?src=pr&el=h1) Report
> Merging [#19052](https://codecov.io/gh/pandas-dev/pandas/pull/19052?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ab000a970025e1b50b41e10be73ee45b11b44db6?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19052/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19052?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19052      +/-   ##
==========================================
- Coverage   91.57%   91.54%   -0.03%     
==========================================
  Files         150      150              
  Lines       48942    48942              
==========================================
- Hits        44818    44806      -12     
- Misses       4124     4136      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.91% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19052?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19052/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19052?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19052?src=pr&el=footer). Last update [ab000a9...c31697e](https://codecov.io/gh/pandas-dev/pandas/pull/19052?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @gfyoung
BUG: Index constructor does not maintain CategoricalDtype
State: closed

- [X] closes #19032
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Categorical
description: Categorical Data Type
name: Interval
description: Interval data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19048?src=pr&el=h1) Report
> Merging [#19048](https://codecov.io/gh/pandas-dev/pandas/pull/19048?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ab000a970025e1b50b41e10be73ee45b11b44db6?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19048/graphs/tree.svg?token=eZ4WkYLtcO&height=150&width=650&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19048?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19048      +/-   ##
==========================================
- Coverage   91.57%   91.56%   -0.01%     
==========================================
  Files         150      150              
  Lines       48942    48942              
==========================================
- Hits        44818    44816       -2     
- Misses       4124     4126       +2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.93% <100%> (-0.01%)` | :arrow_down: |
| #single | `41.75% <66.66%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19048?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/19048/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.45% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/19048/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.74% <0%> (-0.22%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19048?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19048?src=pr&el=footer). Last update [ab000a9...4080bc0](https://codecov.io/gh/pandas-dev/pandas/pull/19048?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
CLN: ASV series_methods
State: closed

Utilized `param` and cleaned up some benchmarks.

```
asv dev -b ^series_methods
· Discovering benchmarks
· Running 9 total benchmarks (1 commits * 1 environments * 9 benchmarks)
[  0.00%] ·· Building for existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[  0.00%] ·· Benchmarking existing-py_home_matt_anaconda_envs_pandas_dev_bin_python
[ 11.11%] ··· Running series_methods.Clip.time_clip                       290μs
[ 22.22%] ··· Running series_methods.Dir.time_dir_strings                30.5ms
[ 33.33%] ··· Running series_methods.Dropna.time_dropna                      ok
[ 33.33%] ···· 
               ========== ========
                 dtype            
               ---------- --------
                  int      4.20ms 
                datetime   19.4ms 
               ========== ========

[ 44.44%] ··· Running series_methods.IsIn.time_isin                          ok
[ 44.44%] ···· 
               ======== ========
                dtype           
               -------- --------
                int64    2.63ms 
                object   5.03ms 
               ======== ========

[ 55.56%] ··· Running series_methods.Map.time_map                            ok
[ 55.56%] ···· 
               ======== ========
                  m             
               -------- --------
                 dict    3.54ms 
                Series   2.31ms 
               ======== ========

[ 66.67%] ··· Running series_methods.NSort.time_nlargest                     ok
[ 66.67%] ···· 
               ======= ========
                 keep          
               ------- --------
                 last   5.20ms 
                first   5.53ms 
               ======= ========

[ 77.78%] ··· Running series_methods.NSort.time_nsmallest                    ok
[ 77.78%] ···· 
               ======= ========
                 keep          
               ------- --------
                 last   4.19ms 
                first   5.00ms 
               ======= ========

[ 88.89%] ··· Running ..._methods.SeriesConstructor.time_constructor         ok
[ 88.89%] ···· 
               ====== =======
                data         
               ------ -------
                None   726μs 
                dict   1.56s 
               ====== =======

[100.00%] ··· Running series_methods.ValueCounts.time_value_counts           ok
[100.00%] ···· 
               ======== ========
                dtype           
               -------- --------
                 int     4.63ms 
                float    7.00ms 
                object   24.7ms 
               ======== ========
```


Labels:
name: Benchmark
description: Performance (ASV) benchmarks

Comments:
thanks @mroeschke 

getting close to full ability to lint check asvs looks like!
Yup! Two more files until we can start linting asvs.
TST: Add tests for Categorical.is_dtype_equal against Series
State: closed

- [X] closes #16659
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Issue is already fixed on 0.22.0 (so really probably fixed in 0.21.x), just adding tests to ensure that there's not a regression.  Didn't add a whatsnew entry since this behavior already exists in a released version, but can add one if need be.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Categorical
description: Categorical Data Type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19045?src=pr&el=h1) Report
> Merging [#19045](https://codecov.io/gh/pandas-dev/pandas/pull/19045?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ab000a970025e1b50b41e10be73ee45b11b44db6?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19045/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19045?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19045      +/-   ##
==========================================
- Coverage   91.57%   91.54%   -0.03%     
==========================================
  Files         150      150              
  Lines       48942    48942              
==========================================
- Hits        44818    44804      -14     
- Misses       4124     4138      +14
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.9% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19045?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19045/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/19045/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.74% <0%> (-0.22%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19045?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19045?src=pr&el=footer). Last update [ab000a9...151c76a](https://codecov.io/gh/pandas-dev/pandas/pull/19045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @jschendel
Tests for TDI issues already fixed
State: closed

Fix a couple others caused by failing to return NotImplemented or to override names correctly.

closes #17250
xref #19042 
closes #19043
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

  
  
  

Labels:
name: Bug
name: Datetime
description: Datetime data dtype
name: Timedelta
description: Timedelta data type

Comments:
@jbrockmendel : Triple threat PR, very nice! :+1: 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19044?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@856c92b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `83.33%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19044/graphs/tree.svg?token=eZ4WkYLtcO&height=150&src=pr&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/19044?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #19044   +/-   ##
=========================================
  Coverage          ?   91.53%           
=========================================
  Files             ?      148           
  Lines             ?    48691           
  Branches          ?        0           
=========================================
  Hits              ?    44569           
  Misses            ?     4122           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.9% <83.33%> (?)` | |
| #single | `41.62% <66.66%> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19044?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/19044/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvb3BzLnB5) | `91.89% <100%> (ø)` | |
| [pandas/core/indexes/timedeltas.py](https://codecov.io/gh/pandas-dev/pandas/pull/19044/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy90aW1lZGVsdGFzLnB5) | `90.92% <50%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19044?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19044?src=pr&el=footer). Last update [856c92b...10296e8](https://codecov.io/gh/pandas-dev/pandas/pull/19044?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hello @jbrockmendel! Thanks for updating the PR.







Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on January 05, 2018 at 16:45 Hours UTC
rebase and lgtm.
ping
thanks @jbrockmendel
Fix bugs in FY5253Quarter and LastWeekOfMonth
State: closed

Similar to [need to lookup reference], this fixes bugs in `LastWeekOfMonth` and `FY5253Quarter` to ensure that the fast implementation `offset.onOffset(ts)` matches the slow (base class) implementation `(ts + offset) - offset == ts`.

I haven't yet looked at BusinessHour and CustomBusinessHour, but other than that I think these are the last classes that have this category of bug.

- [ ] closes #xxxx
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19036?src=pr&el=h1) Report
> Merging [#19036](https://codecov.io/gh/pandas-dev/pandas/pull/19036?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/3198b9df59b7a0e946a37d7ede4167e1bb71d91a?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19036/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19036?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19036      +/-   ##
==========================================
+ Coverage   91.51%   91.54%   +0.02%     
==========================================
  Files         148      148              
  Lines       48807    48808       +1     
==========================================
+ Hits        44667    44680      +13     
+ Misses       4140     4128      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.91% <100%> (+0.02%)` | :arrow_up: |
| #single | `41.63% <5.12%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19036?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/19036/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `96.97% <100%> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19036/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19036?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19036?src=pr&el=footer). Last update [3198b9d...8b0c604](https://codecov.io/gh/pandas-dev/pandas/pull/19036?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

https://travis-ci.org/pandas-dev/pandas/jobs/324352177

Not sure why this keeps timing out.
Ping
thanks!