BrandonFors/pandas-github-issues huggingface dataset:
TST: #14345 fixes TestDatetimeIndexOps test_nat AssertionErrors on 32-bit
State: closed

- [ ] closes #14345 
     Changed tm.assert_numpy_array_equal(idx._nan_idxs, np.array([], dtype=np.int64)
     np.int64 to npintp
    All tests now pass on 32bit linux install.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14347?src=pr) is 85.26% (diff: 100%)

> Merging [#14347](https://codecov.io/gh/pydata/pandas/pull/14347?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14347   diff @@
==========================================
  Files           140        140          
  Lines         50632      50632          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43170      43171     +1   
+ Misses         7462       7461     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [96b364a...73ad3d7](https://codecov.io/gh/pydata/pandas/compare/96b364a4a337b608c92dd6d5a00ceedd80c29315...73ad3d75a47ba4d7e938eb0614a4fc71da0cdc2f?src=pr)

thanks @MattRijk lgtm.
BUG: GH14323 Union of differences from DatetimeIndex incorrect
State: closed

- [ ] closes #14323 
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

Sets freq to None when doing a difference operation on a DatetimeIndex
or TimedeltaIndex, rather than retaining the frequency (which can cause
problems with downstream operations). Frequency of PeriodIndex is
retained.


Labels:
name: Bug
name: Datetime
description: Datetime data dtype
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14346?src=pr) is 85.26% (diff: 100%)

> Merging [#14346](https://codecov.io/gh/pydata/pandas/pull/14346?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14346   diff @@
==========================================
  Files           140        140          
  Lines         50632      50632          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43171      43172     +1   
+ Misses         7461       7460     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [58542e8...1dbf582](https://codecov.io/gh/pydata/pandas/compare/58542e83367973be15fe22e0906907edab35813f...1dbf582b5b8f8d3bf81a047ef3cb886ab33cbb13?src=pr)

Just bumping since my other comment was downthread-- I've reverted the whatsnew changes and made the tests use explicit comparisons, and then squashed the resulting commits. Glad to make a further refactor to the tests if you'd like.

@Liam3851 Sorry for the delay in comment. 
For me the explicit separate tests are OK. But, can you simplify the test cases a little bit? As the issue is not that you take a union of differences (that was just the specific case where you encountered the issue). The issue is rather that a) `difference` now returned a `freq`, and b) that `union` does not handle indexes with `freq` correctly. So I would just use a simple example for both cases. 

thanks!
DOC: Correct uniqueness of index for Series
State: closed

closes #7808

Just wanted to fix the docstring to reflect the fact that the index labels neither need to be unique ~~nor hashable~~.


Labels:
name: Docs

Comments:
It is true that labels no longer need to be unique, but they still must be hashable?

No they don't need to be hashable currently:

```
In [5]: s = pd.Series ([1,2,3], index = ([1],[1],[1]))

In [6]: s
Out[6]:
[1]    1
[1]    2
[1]    3
dtype: int64
```

Do you think we should add a check for hashable? 

try to index that and see what happens 

@jreback lol i don't know, maybe some people use series without ever indexing them? otherwise do you think we should add a check for hashable values? Or maybe edit the doco to say "for the object to support indexing, the labels must be of a hashable type"?

```
In [4]: s = pd.Series ([1,2,3], index = ([1],[2],[3]))

In [5]: s.loc[[1]]
TypeError: unhashable type: 'list'

In [7]: s.index.inferred_type
Out[7]: 'mixed'
```

So we do actually check hashable, but its fairly lazy as its somewhat to expensive to do this. The point is that this is non-idiomatic, and though may work in parts of pandas is not supported, nor recommended in any way.

So if you'd like to update with a stronger warning would be great.

@themrmax Can you update this? (leave out the hashable change for now, but you can keep the change regarding uniqueness) 

## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14344?src=pr) is 85.21% (diff: 100%)
> Merging [#14344](https://codecov.io/gh/pandas-dev/pandas/pull/14344?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **0.04%**

```diff
@@             master     #14344   diff @@
==========================================
  Files           140        143     +3   
  Lines         50632      50800   +168   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43170      43289   +119   
- Misses         7462       7511    +49   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [96b364a...6462ef5](https://codecov.io/gh/pandas-dev/pandas/compare/96b364a4a337b608c92dd6d5a00ceedd80c29315...6462ef5277cd99efda3898a5e1482da3e23d11dc?src=pr)
@themrmax Thanks! 
(I added one sentence from another PR for the same issue ("Non-unique index values are allowed") before merging)
cool thanks @jorisvandenbossche yes that's clearer now !
BUG: astype falsely converts inf to integer, patch for Numpy (GH14265)
State: closed

- [x] closes #14265
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Bug in Numpy causes inf values to be falsely converted to integers. I added a ValueError exception similar to the exception for trying to convert NaN to an integer. 


Labels:
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14343?src=pr) is 85.26% (diff: 100%)
> Merging [#14343](https://codecov.io/gh/pandas-dev/pandas/pull/14343?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #14343   diff @@
==========================================
  Files           144        144          
  Lines         50981      50980     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43470      43469     -1   
  Misses         7511       7511          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [e1f9b96...a9a702e](https://codecov.io/gh/pandas-dev/pandas/compare/e1f9b966eb642c073b610df87a248b3a6d0e5588...a9a702ec18d9dbba66f12c9366664a57fe1bfa85?src=pr)
Looks good to me (for 0.20, but can be merged)
@jreback 

Sorry @jorisvandenbossche and @jreback it took so long to make these simple fixes, but I just got them done. I ended up merging the tests in series and frame with the previous test for NaN conversion. Let me know if you have any more requests. Cheers. 

can you rebase (so can check with current code)
Just rebased and re-ran the tests, everything looks good. Let me know if there's anything else I need to do. 
Thanks for catching that @jreback. Hopefully that should do it. 
@shawnheide Thanks!
Bug: Error when key-only Grouper is passed to groupby in a list (GH14334)
State: closed

- [x] closes #14334
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Groupby

Comments:
@jorisvandenbossche Is this Travis CI build failure something I need to worry about?

That does not seem related, and I can also not reproduce it locally. I restarted the build.

## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14342?src=pr) is 85.26% (diff: 100%)

> Merging [#14342](https://codecov.io/gh/pandas-dev/pandas/pull/14342?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14342   diff @@
==========================================
  Files           140        140          
  Lines         50640      50645     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43176      43180     +4   
- Misses         7464       7465     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [794f792...5e96797](https://codecov.io/gh/pandas-dev/pandas/compare/794f79295484298525dbc8dd3b8ab251ad065e61...5e9679773630ab18d14f6d0ed4b61a1ba0f910f4?src=pr)

@jreback rebased, moved whatsnew to 0.19.1, and made the requested updates

@jreback multiple column `pd.Grouper` tests added

thanks!

@jreback @jorisvandenbossche I see that the PR is closed but it doesn't look like it was merged into master. Was there a problem or does it just take a while?

@jmmease No, it is merged, just not through the github interface. You can see the merge commit in the "jreback closed this in 4852008 a day ago" message above. If you look at master history, you will also see a commit of you with the PR title as message

@jorisvandenbossche Ahh, I see. Thanks
BUG: Frequency not set on empty series
State: closed

- [x] closes #14320 
- [x] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14340?src=pr) is 85.26% (diff: 100%)

> Merging [#14340](https://codecov.io/gh/pandas-dev/pandas/pull/14340?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14340   diff @@
==========================================
  Files           140        140          
  Lines         50632      50635     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43170      43173     +3   
  Misses         7462       7462          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [96b364a...35abfd0](https://codecov.io/gh/pandas-dev/pandas/compare/96b364a4a337b608c92dd6d5a00ceedd80c29315...35abfd0f40af5065acb99b49a90b09eb59b484e8?src=pr)

@sahildua2305 you need to rebase on master

`git rebase -i origin/master`

Oops! Last time I rebased this branch it was fine. I will do that again.

if that doesn't work, then close and open a new PR. We had shifted the url of the repo.

Sure!
Bug: Grouping by index and column fails on DataFrame with single index (GH14327)
State: closed

- [x] closes #14327
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Don't know if this is too late for 0.19.0 but I went ahead and added the whatsnew entry there for now.


Labels:
name: Bug
name: Groupby

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14333?src=pr) is 85.26% (diff: 95.83%)

> Merging [#14333](https://codecov.io/gh/pydata/pandas/pull/14333?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14333   diff @@
==========================================
  Files           140        140          
  Lines         50630      50639     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43169      43177     +8   
- Misses         7461       7462     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [6dcc238...33eb725](https://codecov.io/gh/pydata/pandas/compare/6dcc23862b6b60ce2a67436b4a278fbe4c05490f...33eb725c39e38b89c46042848dce703de78a6b52?src=pr)

whatsnew moved to 0.20.0 as @jreback requested

Looks good to me

Thanks for the feedback @jreback, @jorisvandenbossche, and @TomAugspurger.  Writing the docstrings and working through the type signatures sure helped me better understand the logic I was refactoring!

@TomAugspurger @jorisvandenbossche @jreback I've noticed that there's now a 0.19.1 whatsnew file. Should I move the whatsnew entry there?

Yes, as it seems a straightforward bug fix, you can put it in 0.19.1

@jorisvandenbossche Hmm, I rebased my branch on upstream/master so that I have a copy of the 0.19.1 whatsnew file to work with. After making the change I did a force push which successfully updated the branch in my fork (https://github.com/jmmease/pandas/tree/bug_14327), but it didn't update this pull request.

Should I have merged upstream/master instead of rebasing?

Well, something is going wrong since we moved the repo from the pydata org to the pandas-dev org. PRs that were already open before seem to have this problem.

@wesm @TomAugspurger @jreback anybody experience with this problem, or an idea what could be going on?

@jmmease lgtm. just some doc consistency changes. ping on green.

@jreback Thanks, I'll make these updates this evening. Do you have any guidance on how I should proceed since this PR didn't update with my rebase+force push from yesterday? (See comment from @jorisvandenbossche above) I could try again with a merge instead of rebase or I could open a new PR and reference this one.

On the short term, opening as a new PR is probably the easiest (if you close this one, you can just create a new one from the same branch)

PR reopened in #14428
DOC: fix some sphinx build issues
State: closed

The table here: http://pandas-docs.github.io/pandas-docs-travis/categorical.html#concatenation is apparently not building well. Rst ...


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14332?src=pr) is 85.25% (diff: 100%)

> Merging [#14332](https://codecov.io/gh/pydata/pandas/pull/14332?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14332   diff @@
==========================================
  Files           140        140          
  Lines         50630      50630          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43169      43167     -2   
- Misses         7461       7463     +2   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [6dcc238...0419321](https://codecov.io/gh/pydata/pandas/compare/6dcc23862b6b60ce2a67436b4a278fbe4c05490f...0419321c8859d21e0a8c22bedcb29581756d4543?src=pr)
TST: fix period tests for numpy 1.9.3 (GH14183)
State: closed

Partly addresses #14183 


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14331?src=pr) is 85.26% (diff: 100%)

> Merging [#14331](https://codecov.io/gh/pydata/pandas/pull/14331?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #14331   diff @@
==========================================
  Files           140        140          
  Lines         50630      50630          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43169      43169          
  Misses         7461       7461          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [6dcc238...e39754e](https://codecov.io/gh/pydata/pandas/compare/6dcc23862b6b60ce2a67436b4a278fbe4c05490f...e39754e5cf95d7f65862947b25322c7ff39f0ca7?src=pr)
BUG: mixed freq timeseries plotting with shared axes (GH13341)
State: closed

Closes #13341, partly closes #14322 (that example still does not work when first plotting the irregular series)

cc @sinhrks @TomAugspurger 


Labels:
name: Bug
name: Visualization
description: plotting

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14330?src=pr) is 85.26% (diff: 93.75%)


> No coverage report found for **master** at b1d9599.

> Powered by [Codecov](https://codecov.io?src=pr). Last update [b1d9599...b3537e2](https://codecov.io/gh/pandas-dev/pandas/compare/b1d95990b4bad8e6dd555607e98dad690cfd59d6...b3537e2f65db7698089109caad87f393225f5bb0?src=pr)
@jorisvandenbossche @TomAugspurger ?
Rebased, moved to 0.19.2 and addressed Tom's comment. 
Should be good to merge I think when green.
to_latex encoding issue
State: closed

- [x] closes #14275
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: IO LaTeX
description: to_latex

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14329?src=pr) is 85.26% (diff: 100%)

> Merging [#14329](https://codecov.io/gh/pydata/pandas/pull/14329?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14329   diff @@
==========================================
  Files           140        140          
  Lines         50630      50632     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43169      43171     +2   
  Misses         7461       7461          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [6dcc238...f480b93](https://codecov.io/gh/pydata/pandas/compare/6dcc23862b6b60ce2a67436b4a278fbe4c05490f...f480b93570597a261b9388e6cbf2a96456be2762?src=pr)

@nbonnotte it's failing on py3.5 + windows

@jorisvandenbossche codecs.open was not reading the test file correctly. I updated the test, now everything looks good to me.

@nbonnotte Thanks!
Remove NotImplementedError for parse_dates keyword in read_excel
State: closed

Rebase and update of PR https://github.com/pydata/pandas/pull/12051


Labels:
name: IO Excel
description: read_excel, to_excel

Comments:
lgtm.

Apparently it does not work out of the box anymore by re-enabling it (probably due to changes in `PythonParser` over the last year), so will have to take a deeper look

@jorisvandenbossche ?
@jorisvandenbossche let's update and get this in.
@jorisvandenbossche can you update
@jorisvandenbossche can you rebase
BUG: date slicing with reverse sorted index
State: closed

- [x] closes #14316
- [ ] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

cc @shoyer - good diagnosis!


Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14317?src=pr) is 85.26% (diff: 100%)

> Merging [#14317](https://codecov.io/gh/pydata/pandas/pull/14317?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14317   diff @@
==========================================
  Files           140        140          
  Lines         50619      50621     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43161      43163     +2   
  Misses         7458       7458          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [5033a4a...04feea1](https://codecov.io/gh/pydata/pandas/compare/5033a4a799c77fdc7e868a9f332384eabcc332b8...04feea1e75d34119008f21d704880137af5d5292?src=pr)

lgtm. minor comment. merge when ready.

thanks!
DOC: expand doc for numeric_only
State: closed

- [x] closes #10480
- [x] tests not needed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry not needed

Just making the description (hopefully) a little clearer.  


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14309?src=pr) is 85.26% (diff: 100%)

> Merging [#14309](https://codecov.io/gh/pydata/pandas/pull/14309?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14309   diff @@
==========================================
  Files           140        140          
  Lines         50614      50614          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43155      43156     +1   
+ Misses         7459       7458     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [df50e88...c9657fc](https://codecov.io/gh/pydata/pandas/compare/df50e88f6da84a874402285836483cafa3415292...c9657fca25db5f2daae61eefa13caf740ab339ec?src=pr)

thanks!
BUG: Index.copy() honors 'name' parameter (#14302)
State: closed

- [x] closes #14302 
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14303?src=pr) is 85.26% (diff: 88.46%)

> Merging [#14303](https://codecov.io/gh/pydata/pandas/pull/14303?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14303   diff @@
==========================================
  Files           140        140          
  Lines         50598      50608    +10   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43141      43149     +8   
- Misses         7457       7459     +2   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [977b384...bbfc79f](https://codecov.io/gh/pydata/pandas/compare/977b384cc7cb0ee0d403730ca4b34e32b388ac0c...bbfc79f9e15339b31d1d4b209bff9e5557da1f9f?src=pr)

@shoyer @MaximilianR Any further comments?

@jreback I refactored the validation of `name`/`names`, but then [Travis failed](https://travis-ci.org/pydata/pandas/jobs/163226500) with 

```
ERROR: File or directory already exists: /Users/travis/miniconda
```

I'm not sure what to make of this.

@chrisaycock I restarted the failed osx job. ping when all green. lgtm.

thanks @chrisaycock