BrandonFors/pandas-github-issues huggingface dataset:
TST: Remove fsspec internals from tests
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I don't think clearing the registry does anything. The public registry var is supposed to be immutable, and we were just clearing the internal registry dict. 

However, we didn't remove gcs from the known_implementations dict, so gcs would've technically still been in the registry IIUC this code correctly. 

https://github.com/fsspec/filesystem_spec/blob/0f3ecd8e629043646ab19b1a2b00d895f0553a81/fsspec/registry.py#L206-L209


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO Data
description: IO issues that don't fit into a more specific label

Comments:
CircleCI failure is separate and unrelated.
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 ce9e3d658d6efa3600a4563ca7a00e7a15b80272
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #50925: TST: Remove fsspec internals from tests'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-50925-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #50925 on branch 1.5.x (TST: Remove fsspec internals from tests)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
thx @lithomas1, could you backport manually?
backported in #51038
cirlcle.ci
State: closed

- [x] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
For this practice please do this on your own repository. Closing
Circleci project setup
State: closed

- [x] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Can you explain what you are trying to do?
For this practice please do this on your own repository. Closing
ENH: Optimize replace to avoid copying when not necessary
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Copy / view semantics

Comments:
Does this fix any of the existing cases in ``test_replace``?
No, not yet
thanks @phofl
ENH: Make shallow copy for align nocopy with CoW
State: closed

xref https://github.com/pandas-dev/pandas/issues/49473

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Copy / view semantics

Comments:
Merging, will open a separate pr for ``return self``
REF: standardize reso-return in parsing
State: closed

Moving towards getting reso inference working in the remaining cases in convert_string_to_tsobject, and hopefully de-duplicating parse_datetime_string vs parse_datetime_string_with_reso

Labels:
name: Refactor
description: Internal refactoring of code
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
@mroeschke gentle ping this and #50803 are not time-sensitive but are blockery for further work.
Thanks @jbrockmendel
Changes how the latest version is taken from a list of versions and cuts out obsolete versions on the homepage
State: closed

- [ ] closes Better management of releases in the pandas home page #50885
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Web
description: pandas website
name: Stale

Comments:
I'm still really struggling to import the pandas_web.py file from my test file inside the test folder. I've tried following some guides, but none of it seems to import the file correctly. What would you do to make this happen?
> I'm still really struggling to import the pandas_web.py file from my test file inside the test folder. I've tried following some guides, but none of it seems to import the file correctly. What would you do to make this happen?

Just use `import pandas_web`, if you call `python -m pytest web/`, the directory `web/` will be added to the python path, and that will work.

The problem I see is that we've got some custom addoptions in the project `pyproject.toml` that will make tests fail if the `pandas/conftest.py` is used. You may see the error `__main__.py: error: unrecognized arguments: --strict-data-files`. I think the best to fix it is to have a `web/pyproject.toml` file with simply `[tool.pytest.ini_options]` in it. This will make pytest ignore the root `pyproject.toml` and let the tests run.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
@JustinAmstadt do you have time to finish this? Thank you!
TST: read_fwf with dtype_backend
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Arrow
description: pyarrow functionality

Comments:
Interesting, this was somehow failing for me, but did not have enough time to look closer when I added the option
thx @mroeschke
ENH: Add dtype_backend to to_numeric
State: closed


Labels:
name: Enhancement
name: Arrow
description: pyarrow functionality

Comments:
thx @mroeschke 
> Can we open an issue about implementing this properly?

This may be the "proper" way to implement this since the non-numeric inference & downcasting logic is all done in cython/numpy? I don't think there's any pure arrow equivalent to do this
Yeah we’d need a maybe downcast equivalent for this
DEPR: casting strings to float in to_datetime with unit
State: closed

- [x] closes #50735 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Datetime
description: Datetime data dtype
name: Deprecate
description: Functionality to remove in pandas

Comments:
> Reckon the "inverse" should be deprecated as well, i.e. parsing numeric with format as strings, like

That definitely seems like a potential footgun, no idea how common that is in the wild.
DEPR: Remove (Int|UInt|Float)64Index
State: closed

Actually removes `Int64Index`, `UInt64Index` & `Float64Index`. Also does some cleanups that previous deprecation PRs didn't catch.  

This PR formally achieves the goals set out in #42717. In real terms there are a few outstanding items, which still need to be addressed:
* Move `NumericIndex` into `Index`
* Update docs and write the `whatsnew` entry for this change
* Make the tests in `pandas/tests/arithmetic` cover 8/16/32 bit dtypes
* a few minor issues

So I'd like to kep #42717 open until those are resolved.
 

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
The remaining failure look unrelated.
Thanks @topper-123
BUG: JSON serialization with orient split fails roundtrip with MultiIndex
State: closed

- Closes #50456
- xFail for mark split deprecated.
- All [code checks passed].
- Added an entry in the latest `doc/source/whatsnew/v2.0.0.rst`


Labels:
name: IO JSON
description: read_json, to_json, json_normalize

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
ENH: Use circular weakref to delay copy in setitem
State: closed

- [ ] xref #48998 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

This PR uses a circular weakref between the added block in the DataFrame and the original block from the Series, when doing setitem in a DataFrame with a Series (haven't fixed other cases yet, wanted to get feedback on whether I'm on the right track).

With this way, whoever modifies the data first will have to copy the data, and we can delay the copy in ``__setitem__``.


Labels:
name: Copy / view semantics
name: Stale

Comments:
cc @jorisvandenbossche @phofl for feedback.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
CLN: Refactor block splitting into its own method
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
I'd like to get this merged soonish, I have a Loc pr ready that builds on top of this.

It's basically only a refactoring of existing code into it's own method, no new functionality
Merging, happy to address additional comments in follow ups
WEB: Make all links in the website relative
State: closed

I have a first version implemented of the system that will allow us to preview the rendered web/docs of a PR without having to download the artifact (see #50832).

In order to be able to navigate the website in a relative path (i.e. https://pandas.pydata.org/preview/XXXXX/ instead of the root https://pandas.pydata.org/) we need the changes implemented here, that make all the links relative, so for example the a link from `/preview/XXXXX/donate.html` would go to `/preview/XXXXX/getting_started.html`, instead of simply `/getting_started.html` like we've got now.

Labels:
name: Clean
name: Web
description: pandas website

Comments:
The new preview system seems to work reasonably well, this is what it generates for this PR: https://pandas.pydata.org/preview/50897/

To tell the server to make the preview available in that url from the artifact, we need a request like this: `curl -X POST https://pandas.pydata.org/preview/submit/3966694545/50888/`. Where the first number is the run id of the job that genereated the web/docs artifact (the run id it's in the [url](https://github.com/pandas-dev/pandas/actions/runs/3969358635/jobs/6803744722) of the job). And the second number is the PR number (it's only used to name the target directory).

There are many things that can be improved, but with this PR and calling the trigger from the job in #50899 seems like we've got a first working version.

CC: @pandas-dev/pandas-core 
@datapythonista 
Ah nice, thanks for fixing this. 
This was the main thing that blocked me from moving forward with uploading docs to OVH (I think? All the files were uploaded correctly, stuff just didn't load properly when it wasn't in the base of the bucket). 

If you'd like, I can send you what I had for uploading docs to an OVH bucket.
> If you'd like, I can send you what I had for uploading docs to an OVH bucket.

I had some problems with OVH storage. I think we can make it work, but deleting files or buckets with their UI fails, and I think someone else wasn't working well, so I set up just a regular instance. If we don't need to have a service running a storage bucket seems better since we shouldn't run out of space (not sure if it's a good thing, I think cleaning old stuff is nice). But I think we'll need to implement part of the system to publish the docs as a github app.

Happy to discuss further, and surely happy to get your code if we are going to use an OVH bucket. But for what I did I think what we've got with an instance seems to be a bit better.
DOC: Fix some RT02 issues in docstrings
State: closed

- [ ] closes #49968 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Towards #49968

Labels:
name: Docs

Comments:
Awesome good to see this fully enforced @DeaMariaLeon!

If interested in continuing with these validation there are other codes that we don't enforce https://numpydoc.readthedocs.io/en/latest/validation.html#built-in-validation-checks

( I would personally love to see EX01 enforced )
Thanks @mroeschke. 

> If interested in continuing with these validation there are other codes that we don't enforce https://numpydoc.readthedocs.io/en/latest/validation.html#built-in-validation-checks
> 
> ( I would personally love to see EX01 enforced )

Yes, I'm interested. Would it be this issue? #37875


Correct.
Yeah, exactly - even a PR to add something like
```
    MSG='Partially validate docstrings (EX01)' ; echo $MSG
    $BASE_DIR/scripts/validate_docstrings.py --format=actions --errors=EX01 --ignore_functions \
	    <list of functions goes here>
```
(just like there was for RT02, until you fixed them all 🙌 ) would be really welcome
Sure @MarcoGorelli I would be happy to help. Thanks for letting me know.
CI dont fail import scipy.stats
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration

Comments:
scipy#17827 is closed.  does that solve it on our end?
If I am reading https://github.com/numpy/numpy/pull/23034 correctly, this may be fixed on the next numpy nightly release and we won't have to do anything on our end.
> If I am reading [numpy/numpy#23034](https://github.com/numpy/numpy/pull/23034) correctly, this may be fixed on the next numpy nightly release and we won't have to do anything on our end.

the best kind of fix 🎉 ok cool, closing then, hopefully this'll have sorted itself out tomorrow
DOC: removed hypen to fix docs build numpydoc warnings
State: closed

I noticed a few warning in a recent PR. This should fix them. 

Ref:
![Screenshot of docs build warning in CI](https://user-images.githubusercontent.com/6564007/213683432-7a79a34d-4c84-4e52-896a-5e8b73d5af6c.png)

![Screenshot of detailed numpydoc warnings](https://user-images.githubusercontent.com/6564007/213683456-5a01914a-858e-497e-88ea-158a520d48e5.png)


Labels:
name: Docs

Comments:
Thanks @noatamir
DEPR: remove Int/Uint/Float64Index from tests/arithmetic + various
State: closed

Progress towards #42717.

Arithmetic ops with indexes with 8/16/32 bit dtypes is a bit difficult and I'd like like to work on that after removal of Int64Index etc. So there's a follow-up, where more dtypes should be added to the tests in `pandas/tests/arithmetic/`.

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
The failure looks unrelated.
Thanks @topper-123
Updated release instructions to use rst instead of markdown
State: closed

- [ ] closes #50824 
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

@datapythonista I tried to fix the other pull request but made a mess of it so I thought it would be best to start over. If this was the wrong, please let me know what should have been done; still learning the GitHub/ git workflow.



Labels:
name: Docs

Comments:
Thanks @tpackard1
ENH: support argmin/argmax with pyarrow durations
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Arrow
description: pyarrow functionality

Comments:
Thanks @jbrockmendel
Remove obj_with_exclusions
State: closed

- [x] closes #46944 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Built on #50846; just testing whether obj_with_exclusions is now the same as selected_obj with the exception of #50805

Labels:
name: Refactor
description: Internal refactoring of code
name: Groupby

Comments:
(Not having looked at the code) nice!
Is this still viable?
Nope - closing.