BrandonFors/pandas-github-issues huggingface dataset:
DEPR: Remove legacy offsets
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Follow-up of #10951. Remove legacy offsets deprecated in 0.17.0.


Labels:
name: Frequency
description: DateOffsets
name: Deprecate
description: Functionality to remove in pandas

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13590?src=pr) is **84.39%**

> Merging [#13590](https://codecov.io/gh/pydata/pandas/pull/13590?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **0.01%**

``` diff
@@             master     #13590   diff @@
==========================================
  Files           142        142          
  Lines         51225      51191    -34   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43225      43202    -23   
+ Misses         8000       7989    -11   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [20de266...2593b1f](https://codecov.io/gh/pydata/pandas/compare/20de2661c8eff66e465248cbe28062eae0e0e3bb...2593b1f732f726c206768180200d16b0fe9e1a21?src=pr)

lgtm otherwise.

The "Removal of prior version deprecations/changes" section has already been added in the meantime, so I think this needs a rebase
DOC: Add Fedora and Centos install instructions
State: closed

Since Fedora and Centos use a different tools than OpenSuse, and
have their own packages in official repositories, it is better
to point to them than the one from OpenSuse.


Labels:
name: Docs

Comments:
I guess 

though to be honest should prob relegate instructions for installing from source from a distro and recommendation via conda or wheel instead

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13588?src=pr) is **84.31%**

> Merging [#13588](https://codecov.io/gh/pydata/pandas/pull/13588?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13588   diff @@
==========================================
  Files           138        138          
  Lines         51157      51157          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43132      43132          
  Misses         8025       8025          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ba82b51...16e714f](https://codecov.io/gh/pydata/pandas/compare/ba82b511c76d87421c8900348efebe4577548ec6...16e714f00834b3fef9dc697c588dbded8f05cb1c?src=pr)

@jorisvandenbossche 

Yes, I agree that we should revisit those install instructions, but given there are instructions for ubuntu and debian, merging this for now.
RLS: switch master from 0.18.2 to 0.19.0
State: closed

xref #13562 


Labels:
name: Release

Comments:
prob pandas/doc/release.rst as well.

`release.rst` did not yet include anything about 0.18.2 (we always only add right before the release I think)

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13586?src=pr) is **84.31%**

> Merging [#13586](https://codecov.io/gh/pydata/pandas/pull/13586?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13586   diff @@
==========================================
  Files           138        138          
  Lines         51155      51155          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43130      43130          
  Misses         8025       8025          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [2655dae...1494280](https://codecov.io/gh/pydata/pandas/compare/2655daef1b7346feabd00d4d40910a80386d0812...1494280e7d4fee52627b7c9a4833292a1dca0259?src=pr)

Merging, so other PRs can be rebased on to this with the new whatsnew file
BUG: groupby apply on selected columns yielding scalar (GH13568)
State: closed

- [x] closes #13568
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Groupby
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
@jreback Can you remember the reason that you added the `name=self.name` in several places in the  groupby/rolling/resample refactor? (see https://github.com/pydata/pandas/commit/699424027fb657192541bcd0c3d9f9b7d26f2300#diff-720d374f1a709d0075a1f0a02445cd65R3376) 
I think the fix is correct here, as AFAIU `self.name` can only be None (and that is already the default for name in Series) or a list (from `self._selection`) which raises an error as name. 

The nested groupy-aplly (e.g. `.rolling.groupby.mean` does `.rolling.groupby.apply(lambda x: mean)`, and wasn't passing things thru. However the fixing name things was in several places; it may be that this particular change was not needed.

So the path that you are changing is all scalars, so this seems ok. If nothing breaks then you are good to go!.

_though_ the path in the OP is really related to `_selection`, so this _might_ be a red herring. 

In any event I would add a nice comment about why we are _not_ passing name here.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13585?src=pr) is **84.33%**

> Merging [#13585](https://codecov.io/gh/pydata/pandas/pull/13585?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13585   diff @@
==========================================
  Files           138        138          
  Lines         51100      51100          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43097      43097          
  Misses         8003       8003          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [5605f99...c463e1f](https://codecov.io/gh/pydata/pandas/compare/5605f99105b6a97fb950fbebbf83d2cac0b23ef1...c463e1fb227cbff5caced3c0f41c8ee433805287?src=pr)

> So the path that you are changing is all scalars, so this seems ok. If nothing breaks then you are good to go!.

Indeed, that was my thought as well

> though the path in the OP is really related to _selection, so this might be a red herring. 

The problem is that I am not familiar enough to know all use / corner cases of `self._selection` and `self.name`. At first sight setting  `name` equal to `_selection` in case of a selection of multiple columns (so for a DataFrameGroupBy) does not seem to make much sense to me, as you never want to use that as the name of a result

Added a comment

Actually, if I just let `name` return None instead of `_selection` (except for SeriesGroupBy, there the property is overwritten), the tests pass as well: https://github.com/jorisvandenbossche/pandas/commit/a6f5c9ec02a1c6495555d372069df052a4b6c08b

lgtm
COMPAT: 32-bit compat fixes mainly in testing
State: closed

closes #13566


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
this was a PITA 

cc @jorisvandenbossche 
cc @sinhrks 
cc @gfyoung 

passing on 32-bit linux & windows & travis.

@jreback : any reason why we don't test 32-bit for PR's?  Our parent library `numpy` has at least one machine for 32-bit testing as you can see <a href="https://github.com/numpy/numpy/blob/master/.travis.yml#L40">here</a>.

oh didn't know you could set it up that way 

sure u want to add another build (under the bottom section - go for it)

There's a little bit more that happens behind the scenes, but I just wanted to throw that out there.  I can certainly take a look.

What is the reason `searchsorted` has to return platform int?

Alas, adding a 32-bit config is way more complicated than I imagined (I thought perhaps Ctrl+P from `numpy` might suffice, but alas, that doesn't even work).  So tabling that idea for now.

32-bit linux

```
In [12]: arr = np.array([0,1,2])

In [13]: arr.dtype
Out[13]: dtype('int32')

In [14]: arr.searchsorted(arr).dtype
Out[14]: dtype('int32')
```

64-bit windows

```
In [15]: arr = np.array([0,1,2])

In [16]: arr.dtype
Out[16]: dtype('int32')

In [17]: arr.searchsorted(arr)
Out[17]: array([0, 1, 2], dtype=int64)
```

64-bit all around / OSX

```
In [1]: arr = np.array([0,1,2])

In [2]: arr.searchsorted(arr)
Out[2]: array([0, 1, 2])

In [3]: arr.searchsorted(arr).dtype
Out[3]: dtype('int64')

In [4]: arr.dtype
Out[4]: dtype('int64')
```

So the issue is that on 64-bit we have integers defaults to 64-bit upon construction, and indexing routines (e.g. `.searchsorted` and `.take` are also 64-bit)
On 32-bit these are both 32-bit
on windows indexing are 64-bit but 32-bit for integer defaults (this is because windows use `long long` for pointers, but `long` for integer)

Note that this is NOT an API change, rather a regression to 0.18.1 (so putting it back where it was). Will update soon.

I think somewhere we are doing a forced conversion (in `.searchsorted`) but should not be.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13584?src=pr) is **84.31%**

> Merging [#13584](https://codecov.io/gh/pydata/pandas/pull/13584?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13584   diff @@
==========================================
  Files           138        138          
  Lines         51155      51155          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43130      43130          
  Misses         8025       8025          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [2655dae...b624ce0](https://codecov.io/gh/pydata/pandas/compare/2655daef1b7346feabd00d4d40910a80386d0812...b624ce09dceef66897702a9f3534f6959f179a75?src=pr)
BUG: Block/DTI doesnt handle tzlocal properly
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Unable to concatenate `Series` with `tzlocal`

```
s = pd.Series([pd.Timestamp('2011-01-01', tz=dateutil.tz.tzlocal())])
s
#0   2011-01-01 00:00:00+09:00
# dtype: datetime64[ns, tzlocal()]

pd.concat([s, s])
# UnknownTimeZoneError: 'tzlocal()'
```

It is caused by 2 issues:
#### 1. `tslib.maybe_get_tz` can't handle `tzlocal`.

```
pd.tslib.maybe_get_tz('tzlocal()')
# UnknownTimeZoneError: 'tzlocal()'
```
#### 2. `DatetimeIndex.tz_localize` may return incorrect result when `tzlocal` is used.

it's internally used in `conat`.

```
pd.DatetimeIndex(['2011-01-01', '2011-01-02'], tz=dateutil.tz.tzlocal()).tz_localize(None)
# DatetimeIndex(['2011-01-01', '1970-01-01'], dtype='datetime64[ns]', freq=None)
```


Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Timezones
description: Timezone data dtype

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13583?src=pr) is **84.31%**

> Merging [#13583](https://codecov.io/gh/pydata/pandas/pull/13583?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13583   diff @@
==========================================
  Files           138        138          
  Lines         51157      51157          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43132      43132          
  Misses         8025       8025          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ba82b51...93f59a3](https://codecov.io/gh/pydata/pandas/compare/ba82b511c76d87421c8900348efebe4577548ec6...93f59a3c3273bf6b58fb171bf26e9ae00c0fb81c?src=pr)

thanks!
BUG: DatetimeIndex - Period shows ununderstandable error
State: closed

- [x] closes #13078
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Period
description: Period data type

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13581?src=pr) is **84.31%**

> Merging [#13581](https://codecov.io/gh/pydata/pandas/pull/13581?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13581   diff @@
==========================================
  Files           138        138          
  Lines         51157      51157          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43132      43133     +1   
+ Misses         8025       8024     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ba82b51...c957541](https://codecov.io/gh/pydata/pandas/compare/ba82b511c76d87421c8900348efebe4577548ec6...c957541ba12ed18a0f415e8d7ff958db77c009ea?src=pr)

thanks @sinhrks
CLN: move plotting funcs to pd.plotting
State: closed

Rebased in #16005

---

- [x] closes #12548
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

cleanup `tools/plotting` as `plotting` subpackage. Because the differences are being huge, would like to split 3 part if base direction is OK:

~~1. Move plotting related tests under `pandas/tests/plotting` splitting to `Series`, `DataFrame`, etc. (0.18.2)~~ (#13621)
2. Create `pd.plotting` and move related files (0.20.0) 
3. Split / refactor `pd.plotting` to use small utility functions / property control classes. Add tests. (0.20.0)


Labels:
name: Visualization
description: plotting
name: Clean

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/13579?src=pr) is 85.68% (diff: 69.35%)
> Merging [#13579](https://codecov.io/gh/pandas-dev/pandas/pull/13579?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #13579   diff @@
==========================================
  Files           145        154     +9   
  Lines         51419      51464    +45   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          44057      44098    +41   
- Misses         7362       7366     +4   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [97fd744...1c1efe1](https://codecov.io/gh/pandas-dev/pandas/compare/97fd7447ff54d8f964d057dbaad2b5caa362e24d...1c1efe190667f1d868c1ab95a12d754458324d3b?src=pr)
@sinhrks Generally sounds like a good plan!

+1 overall. @sinhrks will this break old code? Does `pandas.tools.plotting` just point to `pandas.plotting`? I looked in the diff, but could have missed it.

@sinhrks Can you rebase this? Further it is mainly docs that is still needed?

@sinhrks as usual, certainly can include in 0.19.0, just trying to clear the decks.

@sinhrks can you update 

@sinhrks do you time to update this?
@sinhrks Do you have time to update this? I still think this is a useful refactor. I can also do a rebase to get it in.
Once updated to the latest master. Let me add release note later.
Thx, updated based on the comments.

- tests are moved to ``pandas/plotting/tests``.
- ``pd.scatter_matrix`` has been deprecated, in favor of ``pd.plotting.scatter_matrix``.
- added tests to check warnings are properly raised.
really just some minor comments. ok with merging, then fixing after if it is easier (one test failure on locale on travis, not sure why that is).
@sinhrks seems really close...can you rebase
I rebased this one, but pushed to a new PR: https://github.com/pandas-dev/pandas/pull/16005

(this PR predates from when you can push to PR's branch)
Default credentials for Google Compute Engine (#13577)
State: closed

- [x] closes #13577
- [x] passed all existing tests for GbqConnector
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13578?src=pr) is **84.30%**

> Merging [#13578](https://codecov.io/gh/pydata/pandas/pull/13578?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13578   diff @@
==========================================
  Files           138        138          
  Lines         51155      51160     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43130      43130          
- Misses         8025       8030     +5   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [2655dae...fd898e3](https://codecov.io/gh/pydata/pandas/compare/2655daef1b7346feabd00d4d40910a80386d0812...fd898e3edd3cd515d1799cec0ad9e18d1569c338?src=pr)
Fix bug in contains when looking up a string in a non-monotonic datet…
State: closed

- [ ] closes #13572
- [x] tests added / passed
  pandas.tests.indexes.test_datetimelike.TestDatetimeIndex:test_contains
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

…ime index and the object in question is first in the index.


Labels:
name: Datetime
description: Datetime data dtype
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13574?src=pr) is **84.31%**

> Merging [#13574](https://codecov.io/gh/pydata/pandas/pull/13574?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **0.03%**

``` diff
@@             master     #13574   diff @@
==========================================
  Files           138        138          
  Lines         51126      51157    +31   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43122      43132    +10   
- Misses         8004       8025    +21   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d38ee27...3c202b1](https://codecov.io/gh/pydata/pandas/compare/d38ee272f3060cb884f21f9f7d212efc5f7656a8...3c202b1cbcc73c4006c967c8abe1b8d9089c5be4?src=pr)

needs a rebase. some of these tests may now be passing. #13609 fixed lots of things.

Hmm, I think I made a mistake in rebasing. Looks like I pulled in every single change in to this pull request. I'll close this one and make a new one.
Remove test plot line blarg
State: closed

Superceded by #13641

---
- [x] closes #13570 
- [x] tests passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [X] whatsnew entry

The "blarg" argument is propagated to matplotlib and there it raises an
AttributeError (and not a TypeError).
However, since the test doesn't seem to have a rationale, it is removed here.


Labels:
name: Visualization
description: plotting
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13573?src=pr) is **84.34%**

> Merging [#13573](https://codecov.io/gh/pydata/pandas/pull/13573?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13573   diff @@
==========================================
  Files           138        138          
  Lines         51126      51126          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43122      43122          
  Misses         8004       8004          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d38ee27...6d9304e](https://codecov.io/gh/pydata/pandas/compare/d38ee272f3060cb884f21f9f7d212efc5f7656a8...6d9304e38b7490fadc07f92a3669dd7e3ad2a1ad)

Closing this in favour of  PR #13641 

@olebole Even though it is not merged, thanks for your contribution!
BUG: Datetime64Formatter not respecting ``formatter``
State: closed

- [x] closes #10690
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

the Datetime64Formatter class did not accept a `formatter` argument, so custom formatters passed in through `df.to_string` or `df.to_html` were silently ignored. 


Labels:
name: Datetime
description: Datetime data dtype
name: Output-Formatting
description: __repr__ of pandas objects, to_string
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13567?src=pr) is **84.34%**

> Merging [#13567](https://codecov.io/gh/pydata/pandas/pull/13567?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **0.03%**

``` diff
@@             master     #13567   diff @@
==========================================
  Files           138        138          
  Lines         51155      51135    -20   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43130      43132     +2   
+ Misses         8025       8003    -22   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [2655dae...3146ded](https://codecov.io/gh/pydata/pandas/compare/2655daef1b7346feabd00d4d40910a80386d0812...3146ded17a83c691c75ff15dd0b369e723b77ffe?src=pr)

lgtm. 

@haleemur Merged, thanks a lot!

(I moved the whatsnew note to 0.19.0, as master is now targeted for that)