BrandonFors/pandas-github-issues huggingface dataset:
BUG: Empty lists shouldn't be counted as DateOffsets. See #13844
State: closed

- [x] closes #13844 
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Timedelta
description: Timedelta data type

Comments:
tests!

Ah, sorry. Could you point me in the direction of the relevant test file? The structure is different to numpy...

[contributing docs](http://pandas.pydata.org/pandas-docs/stable/contributing.html)

this is prob in `tseries/tests_timeseries.py` though maybe in `tests/series/test_*` (somewhere) as well. you will have to find something similar and put right after.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13889?src=pr) is 85.31% (diff: 100%)

> Merging [#13889](https://codecov.io/gh/pydata/pandas/pull/13889?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13889   diff @@
==========================================
  Files           139        139          
  Lines         50138      50143     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42769      42777     +8   
+ Misses         7369       7366     -3   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [3186fef...cb26d25](https://codecov.io/gh/pydata/pandas/compare/3186fef545b55ca7b4a3c79c800f32b1d586545e...cb26d2555b231342eb7ce23fabef2b34e4bfb980?src=pr)

Thanks. Right I've inserted a test in each of the files you mentioned. To be honest the logical distinction between the different classes in the test files wasn't that clear to me, so please say if they are in the wrong segment. 

First time contributing to pandas so just finding my feet!

minor points. ping on green.

thanks, will amend

lgtm. pls add a whatsnew note in Bug Fixes.

thanks!
BUG: preserve DatetimeIndex.name in HDFStore/read_hdf() with tz (#13884)
State: closed

- [x] closes #13884
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: IO HDF5
description: read_hdf, HDFStore

Comments:
tests!

@jreback I added a test now (still just one commit).

lgtm. pls add a whatsnew note in Bug Fixes.

ping on green.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13888?src=pr) is 85.29% (diff: 100%)

> Merging [#13888](https://codecov.io/gh/pydata/pandas/pull/13888?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13888   diff @@
==========================================
  Files           139        139          
  Lines         50087      50088     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          42723      42723          
- Misses         7364       7365     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [0be0d67...789fa59](https://codecov.io/gh/pydata/pandas/compare/0be0d679873234bfa5198e27a213afe8d43edad7...789fa5926e0a7be58746563458f6d94e06537e69?src=pr)

@jreback ping, this is good to go.

thanks!
BUG: Ignore the BOM in UTF8 BOM CSV files
State: closed

Title is self-explanatory.  Closes #4793.


Labels:
name: Bug
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13885?src=pr) is 85.30% (diff: 80.64%)

> Merging [#13885](https://codecov.io/gh/pydata/pandas/pull/13885?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13885   diff @@
==========================================
  Files           139        139          
  Lines         50108      50138    +30   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42744      42768    +24   
- Misses         7364       7370     +6   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [2beab41...34bc8e5](https://codecov.io/gh/pydata/pandas/compare/2beab41aa288a98bb2f81e5aca0efa67792d3505...34bc8e5e80f50c4a6d0fe2ede0cee02a41d4f93a?src=pr)

was just about to merge (testing on macosx / windows). and on mac got this warning (though no error)?

```
\[jreback-~/pandas] nosetests  -A 'not slow and not network' pandas/io/tests/parser/
.......................................................................................................................................................................................S.............S........................................................................................................................................................................................S.............S...S......................................................................................................................................................................./Users/jreback/pandas/pandas/io/parsers.py:2192: UnicodeWarning: Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  if not first_row[0] or first_row[0][0] != _BOM:
.S.............S..S...............S.............................
----------------------------------------------------------------------
Ran 632 tests in 63.239s
```

@jreback : It's a Python 2.x thing because you're comparing with a string that cannot be cast to `Unicode`.  I made an explicit check for it that should hopefully get rid of the warning.

thanks!

closed by https://github.com/pydata/pandas/commit/e5ee5d2e034c9a4be795596633c199d0ba23970b
DOC: Update README to link to install instructions.
State: closed

Want any updates to the actual install instructions? Should we remove the section on wakari? Do we have a preference for conda-forge over the default channel?


Labels:
name: Docs

Comments:
I would maybe leave in the "pip install pandas" and "conda install pandas" (but removal of easy install and addition of link to full docs is certainly good!)

I would keep the default channel for now

I would actually remove the detailed list of dependencies (not needed in the readme I think, and duplicated content with install.rst which both have to be kept up to date). But I can also do in another PR.

Sounds good, I'll update tonight.

On Mon, Aug 15, 2016 at 8:45 AM, Joris Van den Bossche <
notifications@github.com> wrote:

> I would actually remove the detailed list of dependencies (not needed in
> the readme I think, and duplicated content with install.rst which both have
> to be kept up to date). But I can also do in another PR.
> 
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> https://github.com/pydata/pandas/pull/13882#issuecomment-239805252, or mute
> the thread
> https://github.com/notifications/unsubscribe-auth/ABQHIm8p9yBpcmIgix8DJ6VPGbcf6j4Kks5qgG10gaJpZM4Jajk_
> .

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13882?src=pr) is 85.28% (diff: 100%)

> Merging [#13882](https://codecov.io/gh/pydata/pandas/pull/13882?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13882   diff @@
==========================================
  Files           139        139          
  Lines         50229      50229          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          42837      42837          
  Misses         7392       7392          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [8b50d8c...55f9f13](https://codecov.io/gh/pydata/pandas/compare/8b50d8c854196e3025c9a881cafeedc5f509aaef...55f9f13e80107d8bc451b526822cfd0da6c13004?src=pr)

@TomAugspurger Thanks, I will do a follow-up with some clean-up of the install.rst page.
TST: Add first line comment tests in read_csv
State: closed

Title is self-explanatory.  Closes #4623.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13881?src=pr) is 85.27% (diff: 100%)

> Merging [#13881](https://codecov.io/gh/pydata/pandas/pull/13881?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **0.05%**

``` diff
@@             master     #13881   diff @@
==========================================
  Files           140        139     -1   
  Lines         50400      50011   -389   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42951      42649   -302   
+ Misses         7449       7362    -87   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [1f55e91...becaff7](https://codecov.io/gh/pydata/pandas/compare/1f55e919a3b85cd0891a7a7a1d6913ca06f6bd9e...becaff79cd1d6dcbb73e9c6402d9433471b652a1?src=pr)

ty sir!
solve list cannot add to tuple error in make_signature function
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13878?src=pr) is 85.23% (diff: 0.00%)

> Merging [#13878](https://codecov.io/gh/pydata/pandas/pull/13878?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13878   diff @@
==========================================
  Files           140        140          
  Lines         50456      50456          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43007      43007          
  Misses         7449       7449          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [d4f95fd...1ecdeb6](https://codecov.io/gh/pydata/pandas/compare/d4f95fdebb74db5edb09c743b48c4b03e0940591...1ecdeb6e2c8d9fd8ffa8bf3259184ad3b4a90f02?src=pr)

what exactly does this break?

when I run an example like: 

from pandas.util.decorators import make_signature
def f(a,b,c=2) :
    return a_b_c

print(make_signature(f))

I got an error as: 
defaults = ('',) \* n_wo_defaults + spec.defaults
TypeError: can only concatenate tuple (not "list") to tuple

hmm, that does fail (only in py3). Well must have been a typo in the copy paste a while back. Can you add a test in `pandas/tests/test_util.py`.  `make_signature` is actually used in `pandas.core.groupby`. Can you repro an error from something?

can you rebase / update?
BUG: Series creation with datetime64 with non-ns unit as object dtype
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

found a bug related to `datetime64` with non-ns unit.

```
# OK
pd.Series(np.array([np.datetime64('2011-01-01')]))
#0   2011-01-01
# dtype: datetime64[ns]

# OK
pd.Series([np.datetime64('2011-01-01')], dtype=object)
#0    2011-01-01
# dtype: object

# NG
pd.Series(np.array([np.datetime64('2011-01-01')]), dtype=object)
#0    1970-01-01 00:00:00.000014
# dtype: object

# OK
pd.Series(np.array([np.datetime64('2011-01-01', 'ns')]), dtype=object)
#0    2011-01-01 00:00:00
# dtype: object
```


Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13876?src=pr) is 85.23% (diff: 100%)

> Merging [#13876](https://codecov.io/gh/pydata/pandas/pull/13876?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13876   diff @@
==========================================
  Files           140        140          
  Lines         50456      50458     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43007      43010     +3   
+ Misses         7449       7448     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [d4f95fd...00244d0](https://codecov.io/gh/pydata/pandas/compare/d4f95fdebb74db5edb09c743b48c4b03e0940591...00244d0ea9d81016307a7a6b0d82de94dce34bcb?src=pr)

thanks @sinhrks
DEPR: Remove legacy offsets
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Follow-up to #13590. Remove legacy offset aliases that remained in `pandas/tseries/frequencies.py`: `_period_alias_dictionary()` and `_period_alias_dict`.


Labels:
name: Frequency
description: DateOffsets
name: Period
description: Period data type
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
@sinhrks 

hmm, were these previously deprecated?

@jreback All the removed aliases raise a `FutureWarning` in 0.18.1 and a `ValueError` in `master` &mdash; at least when creating `Period` and `PeriodIndex` objects, as well as calling `.asfreq()` on them.

@agraboso ok, guess weren't tested!

@sinhrks ?

The are a few tests &mdash; see, for example,
- [test_period.py#L444-L463](https://github.com/pydata/pandas/blob/master/pandas/tseries/tests/test_period.py#L444-L463)
- [test_period.py#L689-L691](https://github.com/pydata/pandas/blob/master/pandas/tseries/tests/test_period.py#L689-L691)
- [test_period.py#L1148-L1165](https://github.com/pydata/pandas/blob/master/pandas/tseries/tests/test_period.py#L1148-L1165)
- [test_offsets.py#L4561-L4565](https://github.com/pydata/pandas/blob/master/pandas/tseries/tests/test_offsets.py#L4561-L4565)

But I don't know if there may be some edge cases in which the removed aliases could be accepted.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13868?src=pr) is 85.22% (diff: 100%)

> Merging [#13868](https://codecov.io/gh/pydata/pandas/pull/13868?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **0.01%**

``` diff
@@             master     #13868   diff @@
==========================================
  Files           140        140          
  Lines         50456      50398    -58   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43007      42950    -57   
+ Misses         7449       7448     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [d4f95fd...25d932d](https://codecov.io/gh/pydata/pandas/compare/d4f95fdebb74db5edb09c743b48c4b03e0940591...25d932d09549e9050211c69fcd72d14914d92093?src=pr)

Yes it has been missed as not tested. Thanks for the catch!

NOTE: I found a condition which doesn't show warning. I think it is rare and can't be a reason to keep the impl, but may need discussion.

```
pd.Period(ordinal=1, freq='SECONDLY')
# Period('1970-01-01 00:00:01', 'S')
```

@sinhrks `pd.Period(ordinal=1, freq='SECONDLY')` raises a `FutureWarning` in 0.18.1. I added a test of `pd.Period(ordinal=1, freq='SECONDLY')` (and other removed aliases) that fails on `master` but passes with this PR.

@agraboso You're right, confirmed using 0.18.1 to show warning.

thanks!
TST: use types.api in plotting
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`

remove warning related to #13147 and #13621 


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13867?src=pr) is 85.25% (diff: 100%)

> Merging [#13867](https://codecov.io/gh/pydata/pandas/pull/13867?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13867   diff @@
==========================================
  Files           140        140          
  Lines         50455      50455          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43014      43015     +1   
+ Misses         7441       7440     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [59f2557...8450250](https://codecov.io/gh/pydata/pandas/compare/59f25575f42e19f066dc3cd2245983071e2d7813...8450250f750063cccdbfefcce41f7223e3f89820?src=pr)

thanks!
BUG: SparseDataFrame may not preserve passed dtype
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

`SparseDataFrame` may reset passed sparse data's `dtype` and `fill_value` as below.

**on current master:**

```
arr = pd.SparseArray([1, 0, 3, 0], dtype=np.int64, fill_value=0)

# OK, dtype and fill_value are kept
s = pd.SparseSeries(arr, name='x')
s.dtype, s.fill_value
(dtype('int64'), 0)

# NG, dtype is reset
df = pd.SparseDataFrame(s)
df['x'].dtype, df['x'].fill_value
(dtype('float64'), 0)

# NG, dtype is reset
df = pd.SparseDataFrame({'x': s})
df['x'].dtype, df['x'].fill_value
(dtype('float64'), 0)

# NG, dtype and fill_value are reset
df = pd.SparseDataFrame({'x': arr})
df['x'].dtype, df['x'].fill_value
(dtype('float64'), nan)
```


Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Sparse
description: Sparse Data Type

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13866?src=pr) is 85.28% (diff: 100%)

> Merging [#13866](https://codecov.io/gh/pydata/pandas/pull/13866?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13866   diff @@
==========================================
  Files           139        139          
  Lines         50011      50008     -3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          42650      42647     -3   
  Misses         7361       7361          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [768bf49...dea69ed](https://codecov.io/gh/pydata/pandas/compare/768bf495b9b1f2e6a51708ca6ba83da239cbe504...dea69ed398f138831feb94668c686b38321104dd?src=pr)

thanks!
CLN: Removed / filled stub read_csv tests
State: closed

Title is self-explanatory.

xref #4782


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13864?src=pr) is 85.25% (diff: 100%)

> Merging [#13864](https://codecov.io/gh/pydata/pandas/pull/13864?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13864   diff @@
==========================================
  Files           140        140          
  Lines         50455      50455          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43014      43015     +1   
+ Misses         7441       7440     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [59f2557...4da1ba4](https://codecov.io/gh/pydata/pandas/compare/59f25575f42e19f066dc3cd2245983071e2d7813...4da1ba4511ce3e9f4d1b6a9464e26bd186181ce9?src=pr)

thanks @gfyoung
BUG: loffset not applied when using resample with agg() (GH13218)
State: closed

- [x] closes #13218 
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Resample
description: resample method

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13861?src=pr) is 85.29% (diff: 100%)

> Merging [#13861](https://codecov.io/gh/pydata/pandas/pull/13861?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13861   diff @@
==========================================
  Files           139        139          
  Lines         50164      50168     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42788      42791     +3   
- Misses         7376       7377     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [257ac88...dbb054f](https://codecov.io/gh/pydata/pandas/compare/257ac884d61a74990d1cb4d72c48b1c9003298d5...dbb054f9b787dbbe09ffa60424e19d1b1a0d973f?src=pr)

in any event, pls add the test for timedelta index, but assert it fails (and put a TODO for the xref issue #7687 )

@jreback I'm not quite sure what you mean by put a TODO, could you please clarify? 

Anyways, doing the tests was kind of tricky, so please lmk if I went in the right direction.

what I mean is can leave the timedelta fixes for another PR to fix
but u can out the tests in for them (and since they will fail u can just assert that they fail and add a comment, a todo for fixing later)

@jreback for future reference, when I update my PRs should I @ someone with write access to let them know?  Or should I just wait, and check on them intermittently, rebasing when they get out of date?

thanks

you can ping me if u want me to look

I added some comments

@jreback split the tests into separate test classes

@jreback I think I explained the use of `arg` sufficiently. 

I also didn't realize that `loffset` was broken when passing in a list to agg, e.g. `df.resample('2d', loffset='2h').agg(['mean']).`, so I added a fix and put in the corresponding tests.

@jreback when you have time can you take a look at this, thanks

@jreback I've tried, but can't think of any more alternative solutions. I went back to what I had originally, with the logic in the `aggregate()` functions. 

if this is insufficient, please lmk if you want me to close the PR

well, then reopen if you have a better way.

@jreback I force pushed but I don't have the option to reopen. I don't wanna create a dupe, so is there any way you can reopen this?