Renaming asv setting build_cache_size
State: closed

The CI job that is checking that the benchmarks don't break is reporting that an `asv` setting has been renamed.

I think we've got a server where we run the benchmarks, not sure if we replicate the environment there at every run from `environment.yml`. Otherwise I guess we should do it manually before merging this.

@TomAugspurger I think you manage that server? does this make sense?


Labels:
name: Performance
description: Memory or execution speed performance
name: CI
description: Continuous Integration

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=h1) Report
> Merging [#26703](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/649ad5c91aabb95d7f200eec84b82cae1459fc65?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26703/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26703      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50701    50701              
==========================================
- Hits        46588    46584       -4     
- Misses       4113     4117       +4
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.41% <ø> (ø)` | :arrow_up: |
| #single | `41.93% <ø> (-0.09%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26703/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26703/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=footer). Last update [649ad5c...6c299bf](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=h1) Report
> Merging [#26703](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/649ad5c91aabb95d7f200eec84b82cae1459fc65?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26703/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26703      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50701    50701              
==========================================
- Hits        46588    46584       -4     
- Misses       4113     4117       +4
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.41% <ø> (ø)` | :arrow_up: |
| #single | `41.93% <ø> (-0.09%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26703/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26703/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=footer). Last update [649ad5c...6c299bf](https://codecov.io/gh/pandas-dev/pandas/pull/26703?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> I think we've got a server where we run the benchmarks, not sure if we replicate the environment there at every run from environment.yml

I don't think so. I think ASV has it's own way of building the environment from the matrix of dependencies.
Looks like the benchmarks are failing, the error here is unrelated to this PR, I also saw the same error in #26414. We don't see in other PRs, because we only check the benchmarks when something inside `asv_bench` is modified, and I guess the failure was produced by changes in pandas.

Will check which change broke it, and open an issue.
@datapythonista is this still needed?
@jreback my understanding is that a future version of asv will remove the renamed setting, and I don't know if our benchmarks will break or the current setting will be ignored, but I think we should make this change before that.
thanks @datapythonista