BrandonFors/pandas-github-issues huggingface dataset:
TST: de-xfail pyarrow usecols tests
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO CSV
description: read_csv, to_csv

Comments:
thx @jbrockmendel
DEPR: DatetimeArray/TimedeltaArray.__init__
State: closed

- [x] closes #55623 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
If there are no more comments, I plan to merge this in a week.
TST: de-xfail chunksize pyarrow tests
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO CSV
description: read_csv, to_csv

Comments:
thx @jbrockmendel
TST: de-xfail pyarrow dialect tests
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO CSV
description: read_csv, to_csv
name: Arrow
description: pyarrow functionality

Comments:
Thanks @jbrockmendel
DEPR: to_clipboard, read_clipboard
State: closed

- [x] closes #52129 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Why do we want to deprecate these? I personally find them useful every now and again - are these a maintenance burden?
My main complaint is that we effectively aren't (and AFAICT can't) test it on the CI.  If I'm wrong about it being rarely used then i wont mind keeping it around.
I would prefer to keep these. Sure not the main reason for using pandas, but they are nice for quick transfers of data across applications
I use this functionality all the time. Often will define something like the below at the top of a notebook for sending arbitraty array-likes to the clipboard as I'm modelling. Clearly,  not something needed (much?) in production code, but when doing ad-hoc throw-away work/analysis, it's incredibly useful.

```python
def clippy(data):
    pd.DataFrame(data).to_clipboard()
```
I don't care about this deprecation enough to argue about it, but my thought is that the `def clippy(data)` use case would be better served by

```
def clippy(data):
    content = pd.DataFrame(data).to_csv()
    something_that_lives_outside_of_pandas.to_clipboard(content)
```
My attempt to test clipboard in the CI in https://github.com/pandas-dev/pandas/pull/56084
Merged the test pr, so closing here
DEPR: is_period, is_interval
State: closed

- [x] closes #55264 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Period
description: Period data type
name: Deprecate
description: Functionality to remove in pandas
name: Interval
description: Interval data type

Comments:
Thanks @jbrockmendel
BUG: to_datetime with floats and unit not matching Timestamp
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

The edited sas test is unfortunate but i think OK overall.  Will revisit once #56014 is addressed.  Also i expect that behavior to change in the not-too-distant future to return non-nano anyway.

In a follow-up I'll try to de-duplicate cast_from_unit and cast_from_unit_vectorized.

Labels:
name: Datetime
description: Datetime data dtype
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
Thanks @jbrockmendel 
This seems to have caused a pretty bad performance regression

https://asv-runner.github.io/asv-collection/pandas/#inference.ToDatetimeFromIntsFloats.time_nanosec_float64
DEPR: fractional periods in date_range, timedelta_range, period_range…
State: closed

…, interval_range

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Datetime
description: Datetime data dtype
name: Timedelta
description: Timedelta data type
name: Period
description: Period data type
name: Deprecate
description: Functionality to remove in pandas
name: Interval
description: Interval data type

Comments:
Thanks @jbrockmendel
DOC: Add note for copy keywords for Copy-on-Write
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Starting with one method to figure out wording. Will add for the remaining ones after this one

Labels:
name: Docs
name: Copy / view semantics

Comments:
I've added the enable cow already (big fan of this) and added a defers the copy to the lazy copy mechanism (we also link to the cow docs where this is explained in more detail)
going ahead with the others now
DOC: Fix GH# in whatsnew not for DataFrameGroupBy.value_counts bugfix
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I had the wrong GH# in #56016 in the whatsnew and the code; the GH# added to the tests was correct.

Labels:
name: Docs

Comments:
Thanks @rhshadrach
ASV: Add benchmarks for groupby with multiple categories
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Timings:

```
[ 78.57%] ··· groupby.MultipleCategories.time_groupby_extra_cat_nosort                 29.5±2ms
[ 82.14%] ··· groupby.MultipleCategories.time_groupby_extra_cat_sort                 54.4±0.1ms
[ 85.71%] ··· groupby.MultipleCategories.time_groupby_nosort                         23.0±0.2ms
[ 89.29%] ··· groupby.MultipleCategories.time_groupby_ordered_nosort                 23.3±0.1ms
[ 92.86%] ··· groupby.MultipleCategories.time_groupby_ordered_sort                   50.9±0.4ms
[ 96.43%] ··· groupby.MultipleCategories.time_groupby_sort                           50.4±0.3ms
[100.00%] ··· groupby.MultipleCategories.time_groupby_transform                       629±0.8μs
```

Labels:
name: Enhancement
name: Groupby
name: Categorical
description: Categorical Data Type
name: Benchmark
description: Performance (ASV) benchmarks

Comments:
Thanks @rhshadrach
Avoid warning in DateOffset addition
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: Frequency
description: DateOffsets
name: Warnings
description: Warnings that appear or should be added to pandas

Comments:
Thanks @jbrockmendel
REF: cython3 cleanups
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Internals
description: Related to non-user accessible pandas implementation

Comments:
Thanks @jbrockmendel
REF: use conditional-nogil in libalgos
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Internals
description: Related to non-user accessible pandas implementation

Comments:
Thanks @jbrockmendel
[Docstring] Update a link to SQLAlchemy documentation to be compatible with 2.0 
State: closed

While reading that docstring I found that the link to SQLAlchemy documentation was outdated. I propose to change it to link to a documentation of SQLAlchemy version that is actually supported (>=2.0).

Quick search in repo for string `https://docs.sqlalchemy.org/en/13` yields just that single string to be outdated.

Cheers,
Damian

Labels:
name: Docs

Comments:
thanks @heavelock
CoW warning mode: setting values into single column of DataFrame
State: closed

Next subtask of https://github.com/pandas-dev/pandas/issues/56019. 

This tackles `mgr.column_setitem`, which is used to set values into a single column (but not setting the full column, so like `df.loc[idx, "col"] = ..`)

Labels:
name: Copy / view semantics

Comments:
Green!
thx @jorisvandenbossche
remove ctypedef class from lib.pyx
State: closed

@jbrockmendel 

Labels:
name: Internals
description: Related to non-user accessible pandas implementation

Comments:
`E   TypeError: issubclass() arg 1 must be a class` matches what i got locally from the same approach
Ah ok. I guess this makes it so dtype is not a Python object, so probably need to change that check around
Thanks @WillAyd 
nice!
BUG: Bad shift_forward around UTC+0 when DST
State: closed

- [ ] closes #51501 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

- The algo originates from https://github.com/pandas-dev/pandas/pull/22644. 
- A related bug fix later in https://github.com/pandas-dev/pandas/pull/23406 but failed to take care of edge cases where we move in/out of UTC+0.
  - The 3rd and 4th test case related to utc+0 all fail on main
- More tests added.


Labels:
name: Timezones
description: Timezone data dtype

Comments:
Thanks @quangngd
BUG: GroupBy.value_counts sorting order
State: closed

- [x] closes #56007 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Groupby
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
Thanks @rhshadrach
CI/TST: Skip pyarrow csv tests where parsing fails
State: closed

Follow up to https://github.com/pandas-dev/pandas/pull/55943

Also reduces our CI timeout from 180 minutes to 90 since tests have been running a lot faster lately

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO CSV
description: read_csv, to_csv
name: CI
description: Continuous Integration
name: Arrow
description: pyarrow functionality

Comments:
Is this bc we think one of these is responsible for stalls?
> Is this bc we think one of these is responsible for stalls?

Yeah, I'm just being overly cautious based on https://github.com/apache/arrow/issues/38676 and deeming any of these test that fail in `pyarrow.csv.read_csv` may stall due to thread/gil cleanup
thanks @mroeschke
BUG: get_indexer rountripping through string dtype
State: closed

- [ ] closes #55834 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

cc @jbrockmendel this feels a bit special casy, thoughts?

Labels:
name: Strings
description: String extension data type and string data
name: Index
description: Related to the Index class or subclasses

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Looks like this has gone stale and needs a rebase. Closing to clear the queue but feel free to reopen when you have time
REF: use conditional-nogil in libgroupby
State: closed

There is a perf/verbosity tradeoff here that this PR chooses to leave some perf on the table, primarily in object dtype cases.  Namely makes object dtype cases go through _treat_as_na with a `with gil:` context rather than keep duplicated

```
if numeric_object_t is object:
     # TODO(cython3): use _treat_as_na here once
     #  conditional-nogil is available.
     isna_entry = checknull(val)
else:
    isna_entry = _treat_as_na(val, is_datetimelike)
```

Similarly this removes the nogil from `_check_below_mincount` and re-releases the gil inside the function.  bc _check_below_mincount is only called once at the end of each function and not inside the loop, i think this is benign.

Opened https://github.com/cython/cython/issues/5831 to get back the sliver of perf this leaves on the table.

Labels:
name: Internals
description: Related to non-user accessible pandas implementation

Comments:
Thanks @jbrockmendel
PERF: assert_produces_warning
State: closed

Similar to the implementation in `pandas.util._exceptions.find_stack_level`. 

Seems like it may save a little testing time:

```
> pytest pandas/tests/series/

160.85s  <- main
135.46s  <- PR
```

```
> pytest pandas/tests/arithmetic/

309.48s  <- main
276.90s  <- PR
```


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Performance
description: Memory or execution speed performance

Comments:
nice!  these things add up quick
also if there are a small number of highly-parametrized tests (seems likely in the arithmetic tests) that are responsible for a ton of these calls, can pass check_stacklevel=False for some/most of them
Ah, good to know
Thanks @lukemanley
CLN: remove cython<3 reversed-op pattern
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Internals
description: Related to non-user accessible pandas implementation

Comments:
Thanks @jbrockmendel
BUG: DatetimeIndex with non-nano dtype and mixed numeric inputs
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Non-Nano
description: datetime64/timedelta64 with non-nanosecond resolution

Comments:
Thanks @jbrockmendel
BUG: Return numpy types from ArrowExtensionArray.to_numpy for temporal types when possible
State: closed

- [x] closes #55997 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timedelta
description: Timedelta data type
name: Arrow
description: pyarrow functionality
name: Timestamp
description: pd.Timestamp and associated methods

Comments:
@mroeschke 
tests are still failing I think.