BrandonFors/pandas-github-issues huggingface dataset:
TST: confirming tests for some fixed issues
State: closed

closes #7710, closes #8617, closes #13119

Closes a few issues still tagged with 0.19.0 that only need a confirming test


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14117?src=pr) is 85.27% (diff: 100%)

> Merging [#14117](https://codecov.io/gh/pydata/pandas/pull/14117?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14117   diff @@
==========================================
  Files           139        139          
  Lines         50543      50543          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43101      43102     +1   
+ Misses         7442       7441     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [8fdfa51...252facb](https://codecov.io/gh/pydata/pandas/compare/8fdfa518105cde9ae16449578b3d75c13c8c19a5...252facb89ba974203661705429db145017e37851?src=pr)

@jorisvandenbossche #6817 is not the right issue. can you update. (at the top of the PR)

@jreback whoops, updated (the commit message contained the correct number)
API: Raise FileNotFoundError in read_csv
State: closed

For a nonexistent file, raise the more specific `FileNotFoundError` for Python >= 3.3 in `read_csv`.

Closes #14086.


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14116?src=pr) is 85.27% (diff: 66.66%)

> Merging [#14116](https://codecov.io/gh/pydata/pandas/pull/14116?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14116   diff @@
==========================================
  Files           139        139          
  Lines         50543      50545     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43101      43103     +2   
  Misses         7442       7442          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [8fdfa51...4923f73](https://codecov.io/gh/pydata/pandas/compare/8fdfa518105cde9ae16449578b3d75c13c8c19a5...4923f730688370f8393892c53835b5426f49f439?src=pr)

Looks good to me. Would be nice to also look if other readers raise IOError currently.

@jorisvandenbossche : `read_hdf` is another one that could raise a better error. :smile:

I think this also exists for json / excel.

@jreback : They give different errors, at least when I tried locally.

@gfyoung can you elaborate?

@jreback : Sorry, wasn't clear.  `read_excel` raises `FileNotFoundError` already (it calls Python's `open` function to open the file).  With `read_json`, I get this:

``` python
>>> read_json('nonexistent.json')
...
ValueError: Unexpected character found when decoding 'null'
```

I suppose that could be improved but seems a little different from what I'm fixing here.

ok, yes this should be ok for all other things. can you quickly see if read_stat/read_sas are ok? (I _think_ things that call `io/common/_get_filepath_or_buffer` are fine. `read_csv/read_hdf` just do special things.

ping if ok

Looks good to me!

@jreback : Travis is passing. Ready to merge if there are no other concerns.
DOC: small update to install.rst page
State: closed

Move some content from the removed content on dependencies from the README (see GH13882)

I was going through the install.rst, and updated some small things, but there was actually no content from README to be moved.


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14115?src=pr) is 85.26% (diff: 100%)

> Merging [#14115](https://codecov.io/gh/pydata/pandas/pull/14115?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14115   diff @@
==========================================
  Files           139        139          
  Lines         50502      50502          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43063      43062     -1   
- Misses         7439       7440     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [be61825...4e54c71](https://codecov.io/gh/pydata/pandas/compare/be61825986ba565bc038beb2f5df2750fc1aca30...4e54c71a22bf1999ca7e90fb82b3d95510d093d9?src=pr)
DEPR: Deprecated PeriodIndex.to_datetime
State: closed

Continuation of #14096 by deprecating `PeriodIndex.to_datetime` in favour of `PeriodIndex.to_timestamp`.

Also addresses #8254.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14113?src=pr) is 85.27% (diff: 100%)

> Merging [#14113](https://codecov.io/gh/pydata/pandas/pull/14113?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14113   diff @@
==========================================
  Files           139        139          
  Lines         50511      50513     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43071      43074     +3   
+ Misses         7440       7439     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [10bf721...9fd85bb](https://codecov.io/gh/pydata/pandas/compare/10bf7213240eaa0960f50f86c7790d64d8973060...9fd85bbd096ce3134d69279a2b2496588871af5a?src=pr)

@jreback , @jorisvandenbossche : Travis is passing.  Ready to merge if there are no other concerns.

lgtm

Thanks!

Don't forget to add to the list in #6581!

@gfyoung Already did :-) (but linked to the issue, where the links are to all the different prs)
Test for segfault in factorize (gh12666)
State: closed

- [x] closes #12666 
- [x] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`

Not sure about the last. It's my first PR. 


Labels:
name: Bug
name: Testing
description: pandas testing functions or related to the test suite
name: Complex
description: Complex Numbers

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14112?src=pr) is 85.26% (diff: 100%)

> Merging [#14112](https://codecov.io/gh/pydata/pandas/pull/14112?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #14112   diff @@
==========================================
  Files           139        139          
  Lines         50502      50502          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43062      43062          
  Misses         7440       7440          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [8d1646c...8a6ab59](https://codecov.io/gh/pydata/pandas/compare/8d1646c36a289e3fe921aeeb5fd5ab60c7a10ae7...8a6ab59881b1574fb283b318c0bc9f892f0a7ba2?src=pr)

thanks!
BUG: pass *args and **kwargs for wrapped methods in Groupby (#14107)
State: closed

- [x] closes #14107 
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

Methods such as 'hist' that take keyword arguments would now be able to be called via a Groupby object and the keyword args would be passed onwards to matplotlib as the user expects.


Labels:
name: Visualization
description: plotting

Comments:
tests!

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14109?src=pr) is 85.24% (diff: 0.00%)

> Merging [#14109](https://codecov.io/gh/pydata/pandas/pull/14109?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **0.02%**

``` diff
@@             master     #14109   diff @@
==========================================
  Files           139        140     +1   
  Lines         50502      50556    +54   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43063      43094    +31   
- Misses         7439       7462    +23   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [a0151a7...429509e](https://codecov.io/gh/pydata/pandas/compare/a0151a7b1287e77bcaf0340eba51a2efd7fa8bba...429509e3ccd80ee6c684e83cf4f50ee15630bfba?src=pr)

pls add tests

BTW, I just removed a duplicate dictionary entry on `test_tslib.py`.
It was there for a year now and I have no idea how anything was able to pass lint until now.

I'll need some help at this point (@jreback or others available). My change was a simple one-liner, and I added a test that fails without my change and succeeds with it; so I'm pretty certain my change is fully covered.
However codecov/patch says 0.00%. I'm not sure what it means and how to fix it. Help?

Pinging again. I'd really love to contribute this tiny piece, but if it is just remaining as clutter, I'll remove the PR to avoid future confusion.

I think your example fails in current master. can you clarify?
@yonatanp I am still unclear what the exact issue is here, can you show an example?
can you rebase
can you rebase / update
closing as stale
DEPR: Deprecate Timestamp.to_datetime
State: closed

1) Deprecate `NaT.to_datetime`
2) Deprecate `Timestamp.to_datetime`
3) Issue `UserWarning` in `Timestamp.to_datetime` when nanoseconds is non-zero

`NaT` is also a `_Timestamp`, so the second deprecation covered the first one as well.

Closes #8254.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14101?src=pr) is 85.26% (diff: 100%)

> Merging [#14101](https://codecov.io/gh/pydata/pandas/pull/14101?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14101   diff @@
==========================================
  Files           139        139          
  Lines         50502      50502          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43063      43062     -1   
- Misses         7439       7440     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [a0151a7...1fe9f46](https://codecov.io/gh/pydata/pandas/compare/a0151a7b1287e77bcaf0340eba51a2efd7fa8bba...1fe9f4643826946a2386e30fab9972b81f66a2b9?src=pr)

@jorisvandenbossche , @jreback : Travis is giving the green light, so this should be ready to merge if there are no other concerns.

@gfyoung Thanks!
COMPAT/BLD: int dtype in json tests
State: closed

Fixes failing windows build
https://ci.appveyor.com/project/jreback/pandas-465/build/job/p8hju341jyhnkogc


Labels:
name: Windows
description: Windows OS
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
so maybe add a note in json docs that deserializstion will go to platform ints

The public json api (`pd.read_json`) actually coerces everything to int64, it's only the internal methods where you can get a platform int.

``` python
In [45]: s = pd.Series([1,2,3])

In [46]: pd.read_json(s.to_json(orient='records'), typ='series').dtype
Out[46]: dtype('int64')

In [47]: from pandas.json import loads

In [48]: loads(s.to_json(orient='records'), numpy=True).dtype
Out[48]: dtype('int32')
```

edit: one more example., just to confirm `numpy=True` also coerces

```
In [53]: pd.read_json(s.to_json(orient='records'), 
              typ='series', numpy=True, orient='records').dtype
Out[53]: dtype('int64')
```

ok thanks @chris-b1 ping on green.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14100?src=pr) is 85.26% (diff: 100%)

> Merging [#14100](https://codecov.io/gh/pydata/pandas/pull/14100?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #14100   diff @@
==========================================
  Files           139        139          
  Lines         50502      50502          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43063      43063          
  Misses         7439       7439          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [a0151a7...a2825d9](https://codecov.io/gh/pydata/pandas/compare/a0151a7b1287e77bcaf0340eba51a2efd7fa8bba...a2825d94b2faf63e31c10041b41fe766d24d4dad?src=pr)

thank you sir!
CLN/PERF: clean-up of the benchmarks
State: closed

Related to https://github.com/pydata/pandas/issues/10849 (similar to https://github.com/pydata/pandas/pull/10998)

Just putting this up, was doing some time ago, but not yet fully ready, and thought to already merge this (if the content is OK) to not get too much conflicts.

Gist: removing redundancy by gathering tests in classes and sharing setup functions (you can see the diff change that it removed quite some lines of code). At the same time, I am cleaning up the test names a bit, to make them shorter/more pythonic (eg `DatetimeIndex.time_add_timedelta` instead of `time_datetimeindex_add_timedelta.time_datetimeindex_add_timedelta`). 
The only disadvantage of this cleanup is that for people who already did run the benchmarks for older versions of pandas, this will have to be redone.


Labels:
name: Performance
description: Memory or execution speed performance
name: Clean

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14099?src=pr) is 85.26% (diff: 100%)
> Merging [#14099](https://codecov.io/gh/pandas-dev/pandas/pull/14099?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #14099   diff @@
==========================================
  Files           144        140     -4   
  Lines         50979      50667   -312   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43468      43201   -267   
+ Misses         7511       7466    -45   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [1dbc7be...ab32803](https://codecov.io/gh/pandas-dev/pandas/compare/1dbc7bedcde3274d945790d17c864eecf787a9fa...ab328031ed3241c0be401780ec71a523b9140663?src=pr)
xref #14105: Make sure to remove all references to `datetools` both in `vb_suites` and `asv_bench`.

@jorisvandenbossche skimmed lgtm. Though I didn't run this, so assuming correctness, go ahead.

@jorisvandenbossche merge when ready.

Will try to clean the remaining ones next week

let's merge this

side issue, we should prob pep8 the asv code :> (and of course include it in our tests)

should rebase and merge
Todo' from comments:

- deal with the new resample API (see https://github.com/pandas-dev/pandas/pull/14099#r76518712)
- consolidate the benchmarks for the io functions (as you now have `parsers_vb.py`, but also `io_bench.py`, `hdfstore_bench.py`, `io_sql.py`). Rename parser_vb -> parser
- further clean-up
- better structure? (subdirs?)
- PEP8
DOC: Improved links between expanding and cum* (GH12651)
State: closed

- [x] closes #12651 
- [x] passes `git diff upstream/master | flake8 --diff`


Labels:
name: Docs
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14098?src=pr) is 85.26% (diff: 100%)

> Merging [#14098](https://codecov.io/gh/pydata/pandas/pull/14098?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14098   diff @@
==========================================
  Files           139        139          
  Lines         50490      50502    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43053      43063    +10   
- Misses         7437       7439     +2   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [670435a...4427e28](https://codecov.io/gh/pydata/pandas/compare/670435ab346d6b35e65b3b1de2b56d850ff25cc6...4427e28a0f1ab35eb2acf5ed27b469a1e16a1b01?src=pr)

can you update

can you rebase and update this?

@adrian-stepien Thanks! (adapted it a little bit for @jreback's comments)
Added consistent pandas imports in io documentation
State: closed

Partially addresses #9886


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14097?src=pr) is 85.26% (diff: 100%)

> Merging [#14097](https://codecov.io/gh/pydata/pandas/pull/14097?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14097   diff @@
==========================================
  Files           139        139          
  Lines         50490      50502    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43053      43063    +10   
- Misses         7437       7439     +2   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [670435a...4a9f041](https://codecov.io/gh/pydata/pandas/compare/670435ab346d6b35e65b3b1de2b56d850ff25cc6...4a9f041f9b85c75e7095cbd80980f7da95d0b5bc?src=pr)

@jackieleng Thanks a lot!
DEPR: Deprecated Index.to_datetime
State: closed

Deprecates both `Index.to_datetime` and `DatetimeIndex.to_datetime` in favor of `pd.to_datetime`.

Partially addresses #8254.

Closes #5612 because `pd.to_datetime` does have a `format` argument.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14096?src=pr) is 85.27% (diff: 100%)

> Merging [#14096](https://codecov.io/gh/pydata/pandas/pull/14096?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14096   diff @@
==========================================
  Files           139        139          
  Lines         50489      50490     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43052      43053     +1   
  Misses         7437       7437          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [0e61847...efa9885](https://codecov.io/gh/pydata/pandas/compare/0e61847e111a3ba181f16c8b9b974c74d360ad2e...efa9885ec0028e95f45c29f00e9c7d5e2258672e?src=pr)

@jorisvandenbossche : Since Travis is passing, and if there are no complaints, IMO this can be merged?

I would add the deprecation of Timestamp.to_datetime as well, if you are ok with that?

The reasons for deprecation are slightly different though.  When I looked into it, the deprecation was a little more complicated.  This change, however, was relatively trivial. :smile:

I would feel more comfortable doing it in a separate PR if that's okay.

OK, that's fine :-) Thanks!

@jorisvandenbossche : Also, add that deprecation to #6581.

@gfyoung yep, thanks, added
BUG: Float64Index.get_value() for tuples.
State: closed

- [x] closes #13509
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

Currently, trying to retrieve one tuple-valued entry in a `Series` with
a `Float64Index` will fail (GH 13509). This fixes that bug.


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14092?src=pr) is 85.26% (diff: 100%)

> Merging [#14092](https://codecov.io/gh/pydata/pandas/pull/14092?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #14092   diff @@
==========================================
  Files           139        139          
  Lines         50492      50486     -6   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43053      43049     -4   
+ Misses         7439       7437     -2   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [185fcbe...2b77554](https://codecov.io/gh/pydata/pandas/compare/185fcbebd8c65706a9e3fea2d1ae28aa2d8baa93...2b7755419c7e5140cbe70f935ad78d87f3d0b6c1?src=pr)

thanks for the fix!

that was completely dead code that you removed! (except of course _your_ example hit it!)
BUG: fix tz-aware datetime convert to DatetimeIndex (GH 14088)
State: closed

- [x] closes #14088
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Timedelta
description: Timedelta data type
name: Timezones
description: Timezone data dtype

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/14090?src=pr) is 85.26% (diff: 100%)

> Merging [#14090](https://codecov.io/gh/pydata/pandas/pull/14090?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #14090   diff @@
==========================================
  Files           139        139          
  Lines         50492      50492          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43053      43052     -1   
- Misses         7439       7440     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [185fcbe...c91425b](https://codecov.io/gh/pydata/pandas/compare/185fcbebd8c65706a9e3fea2d1ae28aa2d8baa93...c91425b8bd8100c588c59fe085f664a20d5844d9?src=pr)

thanks!