BrandonFors/pandas-github-issues huggingface dataset:
TST: Parse dates with empty space (#6428)
State: closed

 - [x] closes #6428
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``

Parsing a date with an empty space no longer returns today's date on master 0.19.1. Not sure when this was fixed, but it doesn't seem like it occurred recently.


Labels:
name: Bug
name: Testing
description: pandas testing functions or related to the test suite
name: IO CSV
description: read_csv, to_csv

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14862?src=pr) is 85.30% (diff: 100%)
> Merging [#14862](https://codecov.io/gh/pandas-dev/pandas/pull/14862?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

```diff
@@             master     #14862   diff @@
==========================================
  Files           144        144          
  Lines         50957      50957          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43469      43469          
  Misses         7488       7488          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [86233e1...36bc9b7](https://codecov.io/gh/pandas-dev/pandas/compare/86233e15193c3bcd0f646915891ca6c7892335d9...36bc9b75a4975b67f879d73536b5cb9a27811b75?src=pr)
@mroeschke Thanks!
PERF: use StringHasTable for strings
State: closed

xref #13745 

provides a modest speedup for all string hashing. The key thing is, it will release the GIL on more operations where this is possible (mainly ``factorize``).

can be easily extended to ``.value_counts()`` and ``.duplicated()`` (for strings), new issue for that one

```
In [9]: np.random.seed(1234)

In [10]: strings = tm.makeStringIndex(1000000)

In [11]: def f():
    ...:     for i in range(2):
    ...:         pd.factorize(strings)
    ...:         

In [12]: @tm.test_parallel(num_threads=2)
    ...: def g():
    ...:     pd.factorize(strings)
    ...:     

In [13]: %timeit f()
1 loop, best of 3: 685 ms per loop

In [14]: %timeit g()
1 loop, best of 3: 446 ms per loop

In [15]: strings = strings.take(np.random.randint(0,1000,size=len(strings)))

In [16]: strings.nunique()
Out[16]: 1000

In [17]: %timeit f()
1 loop, best of 3: 222 ms per loop

In [18]: %timeit g()
10 loops, best of 3: 190 ms per loop
```

Labels:
name: Performance
description: Memory or execution speed performance
name: Strings
description: String extension data type and string data

Comments:
cc @mrocklin

## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14859?src=pr) is 85.31% (diff: 100%)


> No coverage report found for **master** at 033d345.

> Powered by [Codecov](https://codecov.io?src=pr). Last update [033d345...ade23d1](https://codecov.io/gh/pandas-dev/pandas/compare/033d34596f5327472007f0f15029b86050ee2592...ade23d1cb3d2bdd7bef1d783d060bbc6eeff7db7?src=pr)
cc @mrocklin

if you can give this a stress test (and see if it helps in your perf tests), when you have a chance
I *think* I've narrowed down my original problem to something else.
Working on isolating it further now.  Will try this after that issue is
removed.

On Wed, Dec 14, 2016 at 11:05 AM, Jeff Reback <notifications@github.com>
wrote:

> cc @mrocklin <https://github.com/mrocklin>
>
> if you can give this a stress test (and see if it helps in your perf
> tests), when you have a chance
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/14859#issuecomment-267074198>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AASszImRcGD1PokmZSZMPJFRbLyO1ToCks5rIBPLgaJpZM4LKF2s>
> .
>
Fix inconsistency in Partial String Index with 'second' resolution
State: closed

- Closes #14826
- Tests added: test_partial_string_indexes. Comprehensive testing of partial string indexes.

## Whatsnew entry
Fix inconsistency in Partial String Index with 'second' resolution. See #14826. Now if the timestamp and the index both have resolution `second`, timestamp is considered as an exact match try and not a slice. Therefore, for `Series`, scalar will be returned, for `DataFrame` `KeyError` raised.

Labels:
name: Bug
name: Datetime
description: Datetime data dtype
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
I am +1 on the idea of this PR. 
@jreback in the discussion on the issue, I interpreted your comments as opposed to this change. Is that still the case? 
The only problem is whether we should just break this behaviour, or are able to first raise a FutureWarning for this to deprecate it.
@jorisvandenbossche no was fine with it. It was a fix designed for DataFrame, but broke Series (which was never tested), so for sure a bug. I don't think there is a problem with simply changing this, it would give the wrong shape back previously.
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14856?src=pr) is 84.64% (diff: 100%)
> Merging [#14856](https://codecov.io/gh/pandas-dev/pandas/pull/14856?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #14856   diff @@
==========================================
  Files           144        144          
  Lines         51016      51016          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43185      43184     -1   
- Misses         7831       7832     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [8e630b6...2881a53](https://codecov.io/gh/pandas-dev/pandas/compare/8e630b63010ffdb4ed3c9b47309dc237f8141fdc...2881a5338554b77a21a391795790053cc5a9cbcc?src=pr)
I addressed code review comments by @jreback.
pls add a whatsnew entry (0.20.0) in other api changes. a small sub-section, showing the change.
@jreback I added whatsnew subsection and also edited documentation a little bit.
thanks!

pls review the docs when built (will prob take a few hours) and issue a follow up if needed.
http://pandas-docs.github.io/pandas-docs-travis/timeseries.html will show them
@jreback Thanks for the corrections. Articles are not my strong side :) I created a follow-up PR #14966 to correct a couple of typos.

Btw, this is my first PR merged to large open source project. Thanks for your guiding :)
TST: Test DatetimeIndex weekend offset
State: closed

closes #5348
closes #5115
closes #5152

The original issues pass on master as of 0.19.1. These related issues might have been fixed part of #5004, but it doesn't look like that any PRs fixed this recently.  


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Datetime
description: Datetime data dtype
name: Frequency
description: DateOffsets

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14853?src=pr) is 85.26% (diff: 100%)
> Merging [#14853](https://codecov.io/gh/pandas-dev/pandas/pull/14853?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14853   diff @@
==========================================
  Files           144        144          
  Lines         50981      50981          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43469      43470     +1   
+ Misses         7512       7511     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [b6de920...736ebb2](https://codecov.io/gh/pandas-dev/pandas/compare/b6de920d8c3c2becc46b4fe233e9f388947554f2...736ebb284bf21d13c6c231e8d3f38ad70db748b8?src=pr)
@mroeschke Thanks a lot, this is really useful for cleaning up the issues!
TST: skip testing on windows for specific formatting which sometimes hang
State: closed

xref #14626

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Windows
description: Windows OS
name: Unreliable Test
description: Unit tests that occasionally fail

Comments:
this is the reason *sometimes* appeveyor doesn't complete.
Can we just skip the test when the result of `datetime.now()` has zero's at the end:

```
now = datetime.now()
if str(now).endswith("000"):
    nose.skipTest()
index = Index([now])
```

then we don't have the confusing spurious test failures (what the convoluted while function tried to solve)
can't skip the entire test, but I put a conditional in there.
BUG: Spurious IncompatibleFrequency error prevented plotting of non-standard intervals (Fixes #14763)
State: closed

 - [x] closes #14763 
 - [x] tests added: tests/plotting/test_series.py: test_non_standard_intervals
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [ ] whatsnew entry - Confirm version and I'll add

Fix Summary: A check on frequency compatibility was unnecessarily strict. Now IncompatibleFrequency exceptions will only get raised if the unit types differ.

Labels:
name: Bug
name: Visualization
description: plotting
name: Period
description: Period data type

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14850?src=pr) is 85.26% (diff: 100%)
> Merging [#14850](https://codecov.io/gh/pandas-dev/pandas/pull/14850?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14850   diff @@
==========================================
  Files           144        144          
  Lines         50979      50979          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43468      43469     +1   
+ Misses         7511       7510     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [856476b...fb5f046](https://codecov.io/gh/pandas-dev/pandas/compare/856476b589eb5f5b78dfb950d3ff6fffa00e14db...fb5f0463ce01ffb518d3eeeb71def00365c1f63c?src=pr)
pls also add a whatsnew entry (0.20.0) is fine.
@jorisvandenbossche @jreback @sinhrks 

After doing some more testing I don't think the fix I've made here is the correct one, so I am going to close this pull request for now. What I submitted does result in the desired plots but I believe it also breaks some behavior in PeriodIndex. The right way to do this is a good deal more complicated than I originally thought, and I don't think I am the right one to do it given my relative inexperience working with this codebase. Happy to discuss my findings if anyone else wants to try to solve this.

Example of an undesired side effect of the fix:
```
idx1 = PeriodIndex(period_range('2000-01-01', '2000-01-02', freq='6H'))
idx2 = idx1.append([ period_range('2000-01-03', '2000-01-04', freq='5H')])

# idx2
PeriodIndex(['2000-01-01 00:00', '2000-01-01 06:00', '2000-01-01 12:00',
'2000-01-01 18:00', '2000-01-02 00:00', '2000-01-03 00:00',
'2000-01-03 05:00', '2000-01-03 10:00', '2000-01-03 15:00',
'2000-01-03 20:00'],
dtype='period[6H]', freq='6H')
```
As you can see, you get a PeriodIndex which says its freq is 6H, but some of the points have a 5H difference. In the current master this code would just result in a plain ndarray.
BUG: Allow TZ-aware DatetimeIndex in merge_asof() (#14844)
State: closed

 - [x] closes #14844 
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry



Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Timezones
description: Timezone data dtype

Comments:
lgtm. ping on green.
@jreback So Travis passed but AppVeyor failed because of the one-hour time out. Should I just resubmit?
I restarted the job, but very odd have seen that a lot recently. And some succeed just fine.
thanks!
Fix to numeric on decimal fields
State: closed

 - [X] closes #14827 
 - [X] tests added / passed
 - [X] passes ``git diff upstream/master | flake8 --diff``
 - [X] whatsnew entry


Labels:
name: Enhancement
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
@jreback Does this look ok to you?
@RogerThomas You don't need to open a new PR to update. You can just push again the same branch, and the PR on github will automatically be updated.
@jorisvandenbossche, thanks yeah, I thought the same, but the other PR doesn't seem to have been updated, maybe it only updates if its status is open. Anyway, I'll leave this one here and leave the other one closed if it's ok with you.
> maybe it only updates if its status is open.

indeed
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14842?src=pr) is 84.64% (diff: 100%)
> Merging [#14842](https://codecov.io/gh/pandas-dev/pandas/pull/14842?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #14842   diff @@
==========================================
  Files           144        144          
  Lines         51016      51019     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43185      43187     +2   
- Misses         7831       7832     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [8e630b6...91d989b](https://codecov.io/gh/pandas-dev/pandas/compare/8e630b63010ffdb4ed3c9b47309dc237f8141fdc...91d989b0419426c0327cbfb63346f40a464f7d8b?src=pr)
almost perfect. left some comments.
Thanks @jreback, I actually had it like that originally but decided to just directly import it from lib. Changed back now
ok lgtm. ping on green.
@jreback all ready to go
thanks!
DOC: astype now takes dict mapping col names to datatypes (#14761)
State: closed

 - [x] closes https://github.com/pandas-dev/pandas/issues/14761
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry

Updating documentation to reflect change

Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14837?src=pr) is 84.64% (diff: 100%)
> Merging [#14837](https://codecov.io/gh/pandas-dev/pandas/pull/14837?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #14837   diff @@
==========================================
  Files           144        144          
  Lines         51016      51016          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43185      43184     -1   
- Misses         7831       7832     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [8e630b6...b9414a9](https://codecov.io/gh/pandas-dev/pandas/compare/8e630b63010ffdb4ed3c9b47309dc237f8141fdc...b9414a92e27ba9fe70ffba5e4167f0bdb6441791?src=pr)
@m-charlton you don't need to close this PR or remove the branch on github to update this. You can just push to the same branch, and the PR on github will automatically be updated.
If you restore the branch, reopen the PR, and then push again, it should still work like that.
@m-charlton Some git help, seems something went wrong with updating to master. If you do the following, it should normally be solved:

```
git fetch upstream
git checkout update_docs_astype_with_dict_#14761
git rebase upstream/master
git push -f 
```
I performed the above before I saw your git help.
Has this fixed the problem?
I think I've rectified my mistakes in update b9414a9
lgtm. ping on green.
I think it was more to do with the content so @jorisvandenbossche needs to
give it a look.
BF(TST): use = (native) instead of < (little endian) for target data types
State: closed

 - [ ] closes #14830
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [ ] whatsnew entry

It is still WiP -- just thought to submit a PR to see how travis etc reacts on typical platforms

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
thanks @yarikoptic 
Please CP this fix into your 0.19.x branch
0.19.x is closed :(
0.20.0 up next
BF: boost min cython to 0.23
State: closed

closes #14699
closes #14508


Labels:
name: Build
description: Library building on various platforms

Comments:
prob need to change a few travis setups in ci
for this to work


what is btw really the lowest version of cython which works in your setups and passes the tests? 0.23 here is somewhat arbitrary one higher than 0.21.1 where 14699 manifested
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14831?src=pr) is 85.26% (diff: 100%)
> Merging [#14831](https://codecov.io/gh/pandas-dev/pandas/pull/14831?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

```diff
@@             master     #14831   diff @@
==========================================
  Files           144        144          
  Lines         50980      50980          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43469      43469          
  Misses         7511       7511          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [0c82abe...e796e8b](https://codecov.io/gh/pandas-dev/pandas/compare/0c82abef8bc8fc7419a3b8823229cafd195595ac...e796e8bd1128fcef2d355e293de32430b27bebc0?src=pr)
```
ci/install_travis.sh:    pip install cython==0.19.1
ci/requirements-2.7.build:cython=0.19.1
ci/requirements-2.7_COMPAT.build:cython=0.19.1
ci/requirements-2.7_LOCALE.build:cython=0.19.1
```
@yarikoptic I think 0.23 is fine. if you can add a note on 0.20.0 whatsnew. also need to update ``install.rst`` I think (as well as change those files I listed above).
interesting -- now 2nd env in travis fails due to failing to find pandas/index.c   any immediate clue why?
@yarikoptic that build is still installing cython 0.19.1 (see the requirements-2.7_LOCALE.build file), so it acts like cython is not installed (I only thought we had a better error message for such cases)
LGTM

@jreback 
seem some files have no changes?

can you add a note in the whatsnew 0.20.0 (in addition to the one you have), about the development requireing a higher version.

can you see if anything needs to be changed in contributing.rst

otherwise lgtm.
@jreback 

- "no changes" -- read between the lines ;)  git would not have a change registered if there were no changes -- while at it fixed some permissions
- whatsnew entry was added a while back... now had to resolve merge conflict already.  would appreciate a merge ;)
thank you sir!
frame_methods benchmarking sum instead of mean
State: closed

Not sure if the function name or the method call is incorrect, but it looks like this should be benchmarking `mean` instead of `sum`



Labels:
name: Performance
description: Memory or execution speed performance

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14824?src=pr) is 85.26% (diff: 100%)


> No coverage report found for **master** at e991141.

> Powered by [Codecov](https://codecov.io?src=pr). Last update [e991141...654057d](https://codecov.io/gh/pandas-dev/pandas/compare/e991141f3c13117035fb2a08f4e64b4c18c9d5a9...654057dfd03e63978c50c7608e4bf401ddb96110?src=pr)
@mroeschke Looks ok, you will only have to rebase as I just merged a large PR cleaning-up lots of benchmarks (but your change can still be applied)
Rebased and all green @jorisvandenbossche 
thanks!
Fixed KDE Plot to drop the missing values
State: closed

 - [x] closes https://github.com/pandas-dev/pandas/issues/14821
 - [x] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry



Labels:
name: Visualization
description: plotting
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14820?src=pr) is 85.30% (diff: 100%)
> Merging [#14820](https://codecov.io/gh/pandas-dev/pandas/pull/14820?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14820   diff @@
==========================================
  Files           144        144          
  Lines         50957      51004    +47   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43469      43511    +42   
- Misses         7488       7493     +5   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [86233e1...4273f8e](https://codecov.io/gh/pandas-dev/pandas/compare/86233e15193c3bcd0f646915891ca6c7892335d9...4273f8e9f53d49988fcdefc2e5afb61e9bdc57ff?src=pr)
Can you add a test and a release note in whatsnew/0.19.2?
Yes, I can do that
can you rebase, problem with appeveyor which i just fixed
Sure, I'll do that!

On Sat, Dec 10, 2016 at 10:33 AM Jeff Reback <notifications@github.com>
wrote:

> can you rebase, problem with appeveyor which i just fixed
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/14820#issuecomment-266216306>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AGg1E01seEPTO65FIZGUbq1__9zCTGicks5rGsZfgaJpZM4LHV8J>
> .
>

@jreback - Is there a problem with the Travis CI? 
you need to rebase on current master, I fixed this yesterday.
Thanks @jreback - have rebased now.
One small change, then we should be good! We're aware of that travis failure on the 3.4 build.
@keshavramaswamy thanks!