BrandonFors/pandas-github-issues huggingface dataset:
DOC: document convention argument for resample()
State: closed

 - [ ] closes #15432 
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master -u -- "*.py" | flake8 --diff``
 - [ ] whatsnew entry


Labels:
name: Docs
name: Resample
description: resample method

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16965?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@2cd85ca`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16965/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/16965?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #16965   +/-   ##
=========================================
  Coverage          ?   90.97%           
=========================================
  Files             ?      161           
  Lines             ?    49290           
  Branches          ?        0           
=========================================
  Hits              ?    44842           
  Misses            ?     4448           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.74% <ø> (?)` | |
| #single | `40.19% <ø> (?)` | |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16965?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/16965?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `92.29% <ø> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16965?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16965?src=pr&el=footer). Last update [2cd85ca...6653dbe](https://codecov.io/gh/pandas-dev/pandas/pull/16965?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks @fding253!
DOC: misspelling in DatetimeIndex.indexer_between_time [CI skip]
State: closed

 - [ ] fix typo in DatetimeIndex.indexer_between_time
 - [ ] passes ``git diff upstream/master -u -- "*.py" | flake8 --diff``


Labels:
name: Docs

Comments:
Hello @shanral! Thanks for submitting the PR.

 - In the file [`pandas/core/indexes/datetimes.py`](https://github.com/pandas-dev/pandas/blob/d1a33c62aeae10f80aeaa9efd7bd06febc56ec19/pandas/core/indexes/datetimes.py), following are the PEP8 issues :

> [Line 445:9](https://github.com/pandas-dev/pandas/blob/d1a33c62aeae10f80aeaa9efd7bd06febc56ec19/pandas/core/indexes/datetimes.py#L445): [E722](https://duckduckgo.com/?q=pep8%20E722) do not use bare except'
> [Line 1174:9](https://github.com/pandas-dev/pandas/blob/d1a33c62aeae10f80aeaa9efd7bd06febc56ec19/pandas/core/indexes/datetimes.py#L1174): [E741](https://duckduckgo.com/?q=pep8%20E741) ambiguous variable name 'l'


thanks!
BUG: If Series is called with no arguments, let it have a RangeIndex (#16737)
State: closed

 - [x] closes #16737
 - [ ] tests added / passed
 - [x] passes ``git diff upstream/master -u -- "*.py" | flake8 --diff``
 - [x] whatsnew entry

Before:
```python
In [4]: Series().index
Out[4]: Index([], dtype='object')
```

Now:
```python
In [3]: Series().index
Out[3]: RangeIndex(start=0, stop=0, step=1)
```

Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
can you rebase and respond to comments
I also think we should aim for consistency, I'll change the code accordingly so pd.Series([]).index and pd.Series().index evaluate to an empty Index.
revisiting this, can you rebase and update and we can review
Hmmm, I think I messed up the rebase. Uhm. What should I do?
@alanbato we should be able to recover it from your local `git reflog`, and then do the rebase again.

Ping one of us on gitter at https://gitter.im/pydata/pandas and we'll walk you through it.
Your actual commit is still in this branch, so a `git fetch upstream` and `git rebase -i upstream/master` and then only keeping the commit you want should also work. But as @TomAugspurger said, feel free to ping on gitter as well for help.


I think I did it! Thanks for your help @TomAugspurger @jorisvandenbossche.
But the question still stands, what should be the expected behaviour?

Also pinging @jreback in case he has something to say

Cheers! 🐍
> I also think we should aim for consistency, I'll change the code accordingly so pd.Series([]).index and pd.Series().index evaluate to an empty Index.

I think we agree on this one (so what @TomAugspurger proposed)
closing as stale, if you want to work on this, pls ping.
Change "pls" to "please" in warning message
State: closed

 - [ ] closes #xxxx
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master -u -- "*.py" | flake8 --diff``
 - [x] whatsnew entry

Code is now more formal when talking to users, as to not disrespect them!
Full warning:
`"by argument to sort_index is deprecated, please use .sort_values(by=...)"`

Labels:
name: Docs

Comments:
Hello @alanbato! Thanks for submitting the PR.

 - In the file [`pandas/core/frame.py`](https://github.com/pandas-dev/pandas/blob/f263535633cc952838ff44f28ca9a6aee2c87fb7/pandas/core/frame.py), following are the PEP8 issues :

> [Line 2045:9](https://github.com/pandas-dev/pandas/blob/f263535633cc952838ff44f28ca9a6aee2c87fb7/pandas/core/frame.py#L2045): [E722](https://duckduckgo.com/?q=pep8%20E722) do not use bare except'
> [Line 2479:13](https://github.com/pandas-dev/pandas/blob/f263535633cc952838ff44f28ca9a6aee2c87fb7/pandas/core/frame.py#L2479): [E722](https://duckduckgo.com/?q=pep8%20E722) do not use bare except'
> [Line 3362:80](https://github.com/pandas-dev/pandas/blob/f263535633cc952838ff44f28ca9a6aee2c87fb7/pandas/core/frame.py#L3362): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (80 > 79 characters)
> [Line 5221:21](https://github.com/pandas-dev/pandas/blob/f263535633cc952838ff44f28ca9a6aee2c87fb7/pandas/core/frame.py#L5221): [E722](https://duckduckgo.com/?q=pep8%20E722) do not use bare except'
> [Line 5717:9](https://github.com/pandas-dev/pandas/blob/f263535633cc952838ff44f28ca9a6aee2c87fb7/pandas/core/frame.py#L5717): [E722](https://duckduckgo.com/?q=pep8%20E722) do not use bare except'


thanks!
DOC: Recommend sphinx 1.5 for now
State: closed

xref https://github.com/pandas-dev/pandas/issues/16705

I've started to debug the slowdown (it's on the writing side), but haven't diagnosed the cause. For the SciPy sprints tomorrow we should recommend 1.5

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16929?src=pr&el=h1) Report
> Merging [#16929](https://codecov.io/gh/pandas-dev/pandas/pull/16929?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/6000c5b9624fdd8925099f215eba282bfbef87ce?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16929/graphs/tree.svg?height=150&src=pr&token=eZ4WkYLtcO&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/16929?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #16929      +/-   ##
==========================================
- Coverage   90.99%   90.97%   -0.02%     
==========================================
  Files         161      161              
  Lines       49303    49303              
==========================================
- Hits        44863    44854       -9     
- Misses       4440     4449       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.74% <ø> (ø)` | :arrow_up: |
| #single | `40.19% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16929?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/16929?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/16929?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.71% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16929?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16929?src=pr&el=footer). Last update [6000c5b...b471e54](https://codecov.io/gh/pandas-dev/pandas/pull/16929?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
DOC: Update flake8 command instructions
State: closed

xref <a href="https://github.com/pandas-dev/pandas/pull/16738#issuecomment-315211329">#16738 (comment)</a>

cc @thequackdaddy 


Labels:
name: Docs
name: Code Style
description: Code style, linting, code_checks

Comments:
Ignore the Appveyor failure.  That's it being silly on a PR with `[ci skip]`.
@jreback : Just curious, do I have similar permissions as I do on Travis for builds?  I tried navigating to one and didn't see any options to restart builds or anything.
@gfyoung login using pandas-dev username; it will validate using github and you should be able to interact
> login using pandas-dev username

If I try clicking the `GitHub` button, it logs in using my `GitHub` account (and can't interact with builds).  However, if I try entering `pandas-dev` into the username-password field, I need a password 😉 - what am I doing wrong here?
@thequackdaddy : if you have anything you would like to add, let me know.  Otherwise, I'll merge this later today or tomorrow (without the `ci skip`).
Fix for #16909(DeltatimeIndex.get_loc is not working on np.deltatime64 data type)
State: closed

get_loc should now work for np.timedelta64 data type.

 - [x] closes #16909
 - [ ] tests added / passed
 - [x] passes ``git diff upstream/master --name-only -- '*.py' | flake8 --diff`` (On Windows, ``git diff upstream/master -u -- "*.py" | flake8 --diff`` might work as an alternative.)
 - [x] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Timedelta
description: Timedelta data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=h1) Report
> Merging [#16912](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/4ca9fcd73225af9cb1dc2acc99bb494dc5f8926a?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16912/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #16912      +/-   ##
==========================================
- Coverage   90.99%   90.97%   -0.02%     
==========================================
  Files         161      161              
  Lines       49303    49303              
==========================================
- Hits        44863    44854       -9     
- Misses       4440     4449       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.74% <100%> (ø)` | :arrow_up: |
| #single | `40.19% <50%> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/timedeltas.py](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy90aW1lZGVsdGFzLnB5) | `90.58% <100%> (ø)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.71% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=footer). Last update [4ca9fcd...a7e2d74](https://codecov.io/gh/pandas-dev/pandas/pull/16912?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

ok rebase and I think ok to go.
thanks!
MAINT: Remove unused mock import
State: closed

We import it, set it as an attribute, and then don't use it.

xref <a href="https://github.com/pandas-dev/pandas/issues/16716#issuecomment-315127204">#16716 (comment)</a>

cc @TomAugspurger 

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
@jreback : Some unrelated `test_clipboard` failure occurred on Travis.  Could you restart the failing build <a href="https://travis-ci.org/pandas-dev/pandas/jobs/253307819">here</a> just so that everything is green?
@gfyoung hah, you *should* be able to restart them now! (you may need to have travis sync things to get the permissions)
Well, would you look at that?  I can!  Thanks :smile:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16908?src=pr&el=h1) Report
> Merging [#16908](https://codecov.io/gh/pandas-dev/pandas/pull/16908?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9d13227345882daaa90f03078c09a9b44a18ce72?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16908/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/16908?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #16908      +/-   ##
==========================================
- Coverage   90.99%   90.97%   -0.02%     
==========================================
  Files         161      161              
  Lines       49301    49301              
==========================================
- Hits        44861    44852       -9     
- Misses       4440     4449       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.74% <ø> (ø)` | :arrow_up: |
| #single | `40.19% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16908?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/16908?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/16908?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.71% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16908?src=pr&el=footer). Last update [9d13227...b963bfe](https://codecov.io/gh/pandas-dev/pandas/pull/16908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@gfyoung FYI make sure to tag PR's (with labels), and then when merging they are on the correct milestone.
@jreback : Ah, right.  I need to get into that habit now. :smile:
Fix Groupby doc.
State: closed

 - [x] closes #16870 
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master --name-only -- '*.py' | flake8 --diff`` (On Windows, ``git diff upstream/master -u -- "*.py" | flake8 --diff`` might work as an alternative.)
 - [x] whatsnew entry


Labels:
name: Docs
name: Groupby

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16901?src=pr&el=h1) Report
> Merging [#16901](https://codecov.io/gh/pandas-dev/pandas/pull/16901?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9d13227345882daaa90f03078c09a9b44a18ce72?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16901/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/16901?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #16901      +/-   ##
==========================================
- Coverage   90.99%   90.97%   -0.02%     
==========================================
  Files         161      161              
  Lines       49301    49301              
==========================================
- Hits        44861    44852       -9     
- Misses       4440     4449       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.74% <ø> (ø)` | :arrow_up: |
| #single | `40.19% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16901?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/16901?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/16901?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.71% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16901?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16901?src=pr&el=footer). Last update [9d13227...7d32756](https://codecov.io/gh/pandas-dev/pandas/pull/16901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you rebase
closing as stale, if you'd like to continue, please ping.
BUG: setitem with boolean mask and tz-aware DTI
State: closed

closes #16889 

 - [x] closes #xxxx
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master --name-only -- '*.py' | flake8 --diff`` (On Windows, ``git diff upstream/master -u -- "*.py" | flake8 --diff`` might work as an alternative.)
 - [x] whatsnew entry


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Timezones
description: Timezone data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=h1) Report
> Merging [#16897](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/8d0c025a4584c0f2d412d060c30fe459dc90b53b?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/16897/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #16897      +/-   ##
==========================================
- Coverage   91.02%   90.98%   -0.05%     
==========================================
  Files         161      161              
  Lines       49303    49305       +2     
==========================================
- Hits        44878    44859      -19     
- Misses       4425     4446      +21
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `88.75% <100%> (-0.03%)` | :arrow_down: |
| #single | `40.19% <0%> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexing.py](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhpbmcucHk=) | `93.93% <100%> (+0.01%)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `63.23% <0%> (-1.82%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.75% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=footer). Last update [8d0c025...fc20f32](https://codecov.io/gh/pandas-dev/pandas/pull/16897?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you rebase and update
will do later today
thanks!