add missing args, make kwarg explicit
State: closed

Index._evaluate_compare is never hit, but if it were it would raise twice: once for not having the right signature and again for referencing a non-existent base.AbstractMethodError

`BlockManager.isna` is entirely non-obvious because there is a required kwarg that isn't in its signature.  This makes it explicit.

Labels:
name: Refactor
description: Internal refactoring of code
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
Does line 3962 in https://github.com/pandas-dev/pandas/pull/19691/files#diff-248241e14f081931cc805f9d0e137a5fR3962 not hit `Index._evaluate_compare`?
Nope.  _evaluate_compare gets overriden in DatetimeIndexOpsMixin, and the only classes that woudl have `needs_i8_conversion(self)` get it from there.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19691?src=pr&el=h1) Report
> Merging [#19691](https://codecov.io/gh/pandas-dev/pandas/pull/19691?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/d198a6efd5a3d2e7d5afb4a3cf556507c7501dd4?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `75%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19691/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19691?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19691      +/-   ##
==========================================
+ Coverage   91.58%    91.6%   +0.02%     
==========================================
  Files         150      150              
  Lines       48867    48867              
==========================================
+ Hits        44755    44767      +12     
+ Misses       4112     4100      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.98% <75%> (+0.02%)` | :arrow_up: |
| #single | `41.75% <75%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19691?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/internals.py](https://codecov.io/gh/pandas-dev/pandas/pull/19691/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzLnB5) | `95.05% <100%> (ø)` | :arrow_up: |
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/19691/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.46% <50%> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19691/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19691?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19691?src=pr&el=footer). Last update [d198a6e...e22bf64](https://codecov.io/gh/pandas-dev/pandas/pull/19691?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!