BrandonFors/pandas-github-issues huggingface dataset:
Remove unused files from src/klib
State: closed

De-couple ujson from numpy_helper

Labels:
name: IO JSON
description: read_json, to_json, json_normalize
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19415?src=pr&el=h1) Report
> Merging [#19415](https://codecov.io/gh/pandas-dev/pandas/pull/19415?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/8a7aca9eda989243fedae4ef525ddef4511ab241?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19415/graphs/tree.svg?width=650&src=pr&height=150&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19415?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19415      +/-   ##
==========================================
+ Coverage   91.62%   91.65%   +0.02%     
==========================================
  Files         150      150              
  Lines       48729    48729              
==========================================
+ Hits        44649    44661      +12     
+ Misses       4080     4068      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.02% <ø> (+0.02%)` | :arrow_up: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19415?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19415/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19415?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19415?src=pr&el=footer). Last update [8a7aca9...fac58f2](https://codecov.io/gh/pandas-dev/pandas/pull/19415?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Pin Thrift to 0.10.*
State: closed

fastparquet compatibility in https://github.com/dask/fastparquet/pull/281, which will be released before long. But let's pin for now.

Labels:
name: CI
description: Continuous Integration
name: Dependencies
description: Required and optional dependencies

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19408?src=pr&el=h1) Report
> Merging [#19408](https://codecov.io/gh/pandas-dev/pandas/pull/19408?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/d3f7d2a666aa824e2df98083aa5c1fd9bb63252e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19408/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/19408?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19408   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         150      150           
  Lines       48726    48726           
=======================================
  Hits        44658    44658           
  Misses       4068     4068
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.02% <ø> (ø)` | :arrow_up: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19408?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19408?src=pr&el=footer). Last update [d3f7d2a...22aa1bc](https://codecov.io/gh/pandas-dev/pandas/pull/19408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
standardize cimports of numpy as "cnp"
State: closed

In a few files this collects scattered numpy imports and puts them all in one place.

Removes unnecessary `np.import_ufunc()` calls.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19405?src=pr&el=h1) Report
> Merging [#19405](https://codecov.io/gh/pandas-dev/pandas/pull/19405?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/8a7aca9eda989243fedae4ef525ddef4511ab241?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19405/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19405?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19405   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         150      150           
  Lines       48729    48729           
=======================================
  Hits        44649    44649           
  Misses       4080     4080
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.99% <ø> (ø)` | :arrow_up: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19405?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19405?src=pr&el=footer). Last update [8a7aca9...6865cd7](https://codecov.io/gh/pandas-dev/pandas/pull/19405?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks. can consider adding a lint rule to enforce some of this, if possible.
DOC: correct merge_ordered example
State: closed

- update of incorrect documentation example for merge_ordered.
- adding a test corresponding to this example.

- [ ] closes #19393 
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Hello @raph-m! Thanks for updating the PR.





Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on January 25, 2018 at 22:50 Hours UTC
Hi,
That's my first contribution to an open source project. Please let me know if I did something wrong :)
Hello, the appveyor test did not pass but the errors do not appear to be related to my modifications. Please let me know if I should make changes to pass the AppVeyor test.
@raph-m Don't worry about the appveyor tests, that is indeed unrelated (and being fixed)

Looks good for the rest!
DOC: changes to use code-block declaration
State: closed

- [ ] closes #19400
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
Thanks,

Looks like there was an extra file commited "doc/test.json". Could you delete it and then

```
git add doc/test.json
git commit -m "removed file"
git push
```

Then we'll get this merged.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19400?src=pr&el=h1) Report
> Merging [#19400](https://codecov.io/gh/pandas-dev/pandas/pull/19400?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/d3f7d2a666aa824e2df98083aa5c1fd9bb63252e?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19400/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19400?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19400      +/-   ##
==========================================
- Coverage   91.65%   91.62%   -0.03%     
==========================================
  Files         150      150              
  Lines       48726    48726              
==========================================
- Hits        44658    44646      -12     
- Misses       4068     4080      +12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.99% <ø> (-0.03%)` | :arrow_down: |
| #single | `41.75% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19400?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19400/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.22% <0%> (-1.74%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19400?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19400?src=pr&el=footer). Last update [d3f7d2a...9a78405](https://codecov.io/gh/pandas-dev/pandas/pull/19400?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
BUG SparseDataFrame with dense Series (#19374)
State: closed

- [X] closes #19374
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Bug
name: Sparse
description: Sparse Data Type

Comments:
@datapythonista : Looks pretty good so far.  Don't forget to add a `whatsnew` entry.
Thanks a lot for the comments. Sorry about the whatsnew, I added it when opening the PR, but forgot to add it to the commit.

@jreback, I didn't find a way to construct the expected `SparseDataFrame` without using the constructor that is being tested itself. But I added the comparison of the length and sum of the original series and the new `SparseDataFrame`, which I think should be enough (and it helped find a bug in my previous code).

Addressed all the other comments, let me know if you see anything else. Thanks!
Thanks for the feedback @jreback, I misunderstood what the columns argument had to do, and I was overcomplicating the code.

Now it simply creates the `DataFrame` with the `Series` name if it has one, or it uses 0 as the column if it doesn't. This seems to be consistent with the `Series` constructor and with creating a `SparseDataFrame` from a `DataFrame`, which ignores unknown columns.

I'm not 100% sure I understood what you mean by "actually contruct dic", please let me know if this new version doesn't address this too.
Thanks once again for the comments @jreback, seems that I followed the conventions of an old test. Addressed your comments, should be all right now.
thanks @datapythonista
implement ABCInterval
State: closed

Avoid python-space import in lib

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Enhancement
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Interval
description: Interval data type

Comments:
need test in pandas/tests/dtypes/test_generic.py
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19367?src=pr&el=h1) Report
> Merging [#19367](https://codecov.io/gh/pandas-dev/pandas/pull/19367?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7202635c9332b2b510f3f32cb1e97e3268edc61f?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19367/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19367?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19367      +/-   ##
==========================================
- Coverage   91.61%    91.6%   -0.02%     
==========================================
  Files         150      150              
  Lines       48677    48685       +8     
==========================================
+ Hits        44595    44596       +1     
- Misses       4082     4089       +7
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.97% <100%> (-0.02%)` | :arrow_down: |
| #single | `41.72% <100%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19367?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/dtypes/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/19367/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL2dlbmVyaWMucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/19367/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `83.83% <0%> (-0.62%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19367?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19367?src=pr&el=footer). Last update [7202635...6162585](https://codecov.io/gh/pandas-dev/pandas/pull/19367?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
updated hist documentation
State: closed

pandas.DataFrame.hist()/pandas.Series.hist() currently say that the `bins` keyword argument must be an integer, with a default value of 10. Since these methods are built off matplotlib, these actually seem to be more flexible (allowing sequences as well as integers). I don't know if there was a reason for this discrepancy, but if not, I've adjusted the pandas docstrings to reflect the matplotlib documentation.

[Existing pandas documentation](https://pandas.pydata.org/pandas-docs/stable/generated/pandas.DataFrame.hist.html)
[Existing matplotlib documentation](https://matplotlib.org/api/_as_gen/matplotlib.axes.Axes.hist.html)

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs
name: Visualization
description: plotting

Comments:
Hello @mitchnegus! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on January 30, 2018 at 20:49 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19366?src=pr&el=h1) Report
> Merging [#19366](https://codecov.io/gh/pandas-dev/pandas/pull/19366?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/238499ab0a48a0ad4a2011e2ce1c6a02c86124eb?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19366/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19366?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #19366   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         150      150           
  Lines       48724    48724           
=======================================
  Hits        44642    44642           
  Misses       4082     4082
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.99% <ø> (ø)` | :arrow_up: |
| #single | `41.74% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19366?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/plotting/\_core.py](https://codecov.io/gh/pandas-dev/pandas/pull/19366/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb3JlLnB5) | `82.41% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19366?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19366?src=pr&el=footer). Last update [238499a...d0e44e4](https://codecov.io/gh/pandas-dev/pandas/pull/19366?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@mitchnegus do you have a chance to update based on these comments?
Yes, sorry, I got busy and had forgot about this. Thanks for the bump!
thanks!
remove unused convert_sql_column
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Clean

Comments:
lgtm. ping on green. 
thanks!
Remove unused functions, cimports
State: closed

Miscellaneous cleanup, use `util.is_array` instead of `isinstance`, that kind of thing.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19360?src=pr&el=h1) Report
> Merging [#19360](https://codecov.io/gh/pandas-dev/pandas/pull/19360?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9872d6757e5117dce070981141cee562f675694e?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19360/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/19360?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19360      +/-   ##
==========================================
+ Coverage   91.54%   91.58%   +0.03%     
==========================================
  Files         150      150              
  Lines       48702    48694       -8     
==========================================
+ Hits        44585    44595      +10     
+ Misses       4117     4099      -18
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.95% <100%> (+0.03%)` | :arrow_up: |
| #single | `41.72% <50%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19360?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexing.py](https://codecov.io/gh/pandas-dev/pandas/pull/19360/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhpbmcucHk=) | `93.11% <ø> (+0.49%)` | :arrow_up: |
| [pandas/core/sparse/series.py](https://codecov.io/gh/pandas-dev/pandas/pull/19360/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3BhcnNlL3Nlcmllcy5weQ==) | `95.32% <100%> (ø)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19360/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19360?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19360?src=pr&el=footer). Last update [9872d67...77bbcf4](https://codecov.io/gh/pandas-dev/pandas/pull/19360?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Added cast blacklist for certain transform agg funcs
State: closed

- [X] closes #19200
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Groupby
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19355?src=pr&el=h1) Report
> Merging [#19355](https://codecov.io/gh/pandas-dev/pandas/pull/19355?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9872d6757e5117dce070981141cee562f675694e?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/19355/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/19355?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #19355      +/-   ##
==========================================
+ Coverage   91.54%   91.57%   +0.02%     
==========================================
  Files         150      150              
  Lines       48702    48705       +3     
==========================================
+ Hits        44585    44600      +15     
+ Misses       4117     4105      -12
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.94% <100%> (+0.02%)` | :arrow_up: |
| #single | `41.72% <50%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/19355?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/groupby.py](https://codecov.io/gh/pandas-dev/pandas/pull/19355/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ3JvdXBieS5weQ==) | `92.15% <100%> (+0.01%)` | :arrow_up: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/19355/diff?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `66.95% <0%> (+1.73%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19355?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/19355?src=pr&el=footer). Last update [9872d67...3f8b7f3](https://codecov.io/gh/pandas-dev/pandas/pull/19355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @WillAyd nice patch! keep em coming!