whatsnew 1.3.0
State: closed

- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them

Minor fixups. After I get feedback here, I plan to make a PR with detailed instructions about adding to the whatsnew.

cc @attack68 - the Styler sections had a major revisions, wanted to get any feedback here.

cc @jorisvandenbossche @simonjayhawkins 

Labels:
name: Docs

Comments:
@jreback - agreed with all your suggestions above but would like to hold off and do in a followup to keep the diff here reasonable. I think it's okay for the changes to happen during the RC period (but won't be waiting for the RC period either)
@attack68 - The performance improvement of the HTML rendering referenced #37792 but this is unrelated, not sure what issue/PR was meant. Also from the line

> - The method :meth:`.Styler.format` has been improved to easily format missing data, precision, and perform HTML escaping (:issue:`40437`, :issue:`40134`)

I think the "format missing data" is referring to #40134, but I can't find changes to na_rep there. Can you help me understand what changed?
> @attack68 - The performance improvement of the HTML rendering referenced #37792 but this is unrelated, not sure what issue/PR was meant. Also from the line
> 
> > * The method :meth:`.Styler.format` has been improved to easily format missing data, precision, and perform HTML escaping (:issue:`40437`, :issue:`40134`)
> 
> I think the "format missing data" is referring to #40134, but I can't find changes to na_rep there. Can you help me understand what changed?

there was a function called `Styler.set_na_rep()`, which set a property on `self` and the `format` method with an `na_rep` arg which conflicted at times. So, yes, it was there previously but it didn't always do what you thought. Now the missing data in `Styler` is handled exclusively and consistently by `Styler.format`, and `Styler.set_na_rep` is deprecated. 

> @attack68 - The performance improvement of the HTML rendering referenced #37792 but this is unrelated, not sure what issue/PR was meant. Also from the line

#39972 and #39952

@rhshadrach there's a lot here.  id suggest breaking off the non-controversial bits into a precursor PR
> @rhshadrach there's a lot here. id suggest breaking off the non-controversial bits into a precursor PR

maybe start with the sphinx directive syntax errors, then another PR for the sphinx directives with broken links, then the grammer and then finally move stuff.
The first one (maybe 2) would be good for the rc
Going back on what I said in https://github.com/pandas-dev/pandas/pull/41747#issuecomment-851779839, I only plan to finish up this what's in this PR. I'll break it up as @simonjayhawkins recommended.
@rhshadrach is more of this getting broken off or can you mark as Ready For Review?
@jbrockmendel - one last one (#41822).

The main reason for draft status is https://github.com/pandas-dev/pandas/pull/41747#discussion_r642758379. Currently the top section of styler duplicates many of the other notes in the whatsnew. Need to deduplicate and decide whether enhancements for the Styler should appear in the top enhancement section or as line items in the Other Enhancements (grouped together). Any thoughts here would be appreciated.

I think it is clear that bugfixes should go in the Styler bugfixes section and not in the top enhancement section.
I've deduplicated the Styler notes and reorganized so that all enhancements are in `Enhancements` in their own section, while Performance, Deprecation, and Bugfix notes appear below in the appropriate sections.
I can siphon off the Styler relevant pieces into a separate PR as well if that will make this easier to review. Let me know if that's desirable @simonjayhawkins, @jbrockmendel  (or anyone else)
@rhshadrach merge conflicts
Thanks @attack68 and @simonjayhawkins for the comments/requests, adjustments made and conflicts resolved.
Thanks @rhshadrach I think just @jreback comments about moving stuff to do in follow-up.