BUG: DataFrame/Series.tz_convert does not modifies original data with copy=False
State: closed

- [x] closes #6326
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

This also impacted `tz_localize` as well. Non blocking for 0.24


Labels:
name: Bug
name: Timezones
description: Timezone data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=h1) Report
> Merging [#24657](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c4994ca56b5d6af35643bd9f20d39b090acbe5ff?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/24657/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #24657      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52384    52384              
==========================================
- Hits        48391    48390       -1     
- Misses       3993     3994       +1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.8% <100%> (ø)` | :arrow_up: |
| #single | `43.02% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/24657/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `96.62% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/24657/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `88% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=footer). Last update [c4994ca...c7bfdab](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=h1) Report
> Merging [#24657](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c4994ca56b5d6af35643bd9f20d39b090acbe5ff?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/24657/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #24657      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52384    52384              
==========================================
- Hits        48391    48390       -1     
- Misses       3993     3994       +1
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.8% <100%> (ø)` | :arrow_up: |
| #single | `43.02% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/24657/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `96.62% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/24657/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `88% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=footer). Last update [c4994ca...c7bfdab](https://codecov.io/gh/pandas-dev/pandas/pull/24657?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jreback were your comments from 
https://github.com/pandas-dev/pandas/pull/24657#pullrequestreview-189696517 blocking for this PR? They seem out of scope for the bug fix here.
this fixes a bug but i think we ought to consider deprecating copy and making it inplace
even though i don’t like that
OK. A deprecation will take time, so fix in the meantime?

On Mon, Jan 7, 2019 at 8:51 AM Jeff Reback <notifications@github.com> wrote:

> this fixes a bug but i think we ought to consider deprecating copy and
> making it inplace
> even though i don’t like that
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/24657#issuecomment-451959299>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHImeM5kkllqona7QG9q0Ocd22PFoqks5vA17sgaJpZM4Zy727>
> .
>

Well the order of operations could be:

1) Fix this bug first
2) Follow up PR with deprecating `copy` kwarg in `tz_convert` (or vice versa)?
that’s fine
Thanks! Made https://github.com/pandas-dev/pandas/issues/24667 as a follow up to deprecate `copy` in favor of `inplace`