BrandonFors/pandas-github-issues huggingface dataset:
DOC: Enforce Numpy Docstring Validation for pandas.Series.max
State: closed

- [ ] xref #58504 

fixes
```
-i "pandas.Series.max RT03" \

```

Labels:
name: Docs

Comments:
Thanks @tuhinsharma121 
Sorry for the late review, but is there a reason why you are re-writing the docs from scratch instead of fixing it from the `make_doc` function? You fixed it for `Series.max` but `DataFrame.max` and some other reduction methods are still failing @mroeschke @tuhinsharma121 
Another benefit of this change is avoiding the dynamic docstring so that docstring formating can happen via `ruff`
yeah. And `See Also` section can have flexibility to differ slightly for Series and DataFrame methods this way.
DOC: Enforce Numpy Docstring Validation for pandas.Interval.right pandas.Interval.left pandas.Interval.closed
State: closed

- [ ] xref #58498

fixes
```
pandas.Interval.right SA01
pandas.Interval.left SA01
pandas.Interval.closed SA01
```


Labels:
name: Docs

Comments:
These don’t all need to be separate PRs
@jbrockmendel I thought it would be easier to review. But I get your point. `Interval.left`, `Interval.right`,`Interval.closed` can go into one. let me merge them into this PR. 
Thanks @tuhinsharma121
DOC: Improve convert_dtypes's docstring
State: closed

- [x] closes #58546
xref #58543 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks for the quick fix @Aloqeely
DOC: Fix SA01 Errors
State: closed

- [x] xref #58504
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
ENH: Restore support for reading Stata 104 format dta files, and add support for 103
State: closed


- [x] closes #58554
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I wasn't sure whether to label this as a bug fix or enhancement as support has existed in the Pandas previously, but it last worked a long time ago.

I have included 103 support in this too as for the purposes of reading the format is identical (103 does not support data of byte type).

Labels:
name: IO Stata
description: read_stata, to_stata

Comments:
cc @bashtage 
Seems pretty simple.  Are the dta files produced by Stata or something else?
The new test files are produced with a program that I wrote based on the published specifications, but I test them with Stata (and occasionally a hex editor to be sure). I have also tested with a variety of historic files available from the Stata Technical Bulletin and the Stata Journal.
Thanks @cmjcharlton
BUG: `DatetimeIndex.is_year_start` and `DatetimeIndex.is_quarter_start` always return False on double-digit frequencies
State: closed

- [x] closes #58523


Labels:
name: Bug
name: Frequency
description: DateOffsets

Comments:
@MarcoGorelli could you please take a look at this PR? I think CI failures are unrelated to my changes.
> looks good to me on green, thanks @natmokval !

thank you for reviewing this PR!
BUG: pandas-dev#58523 & pandas-dev#58524
State: closed

- [ ] closes May fix #58523 and #58524



Labels:

Comments:
hey - I left a comment [here](https://github.com/pandas-dev/pandas/pull/58549#discussion_r1589720478) about the implementation itself, but at a minimum, if you open a PR fixing a bug, you're going to need to include tests
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
ENH: read parquet files in chunks using to_parquet and chunksize
State: closed

ENH: read parquet files in chunks using to_parquet and chunksize

- [X] closes #55973 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Fix SA01 errors for Series.dtype, Series.is_unique, Series.shape
State: closed

- [x] xref #58504
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
fix BUG #58524
State: closed

- [ ] closes #58524
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Changed it to check the last character of the string so it handles if numbers in front. Works with the example, but not sure about if there are other cases that would break this. The fix seems almost too simple. Let me know :) 

Labels:

Comments:
Modified my PR to parse the characters in freqstr and check that for more flexibility
Hi, when I run the pre-commit hooks pre-commit run --hook-stage manual --all-files, all the lines pass, but it seems like I have many failing checks. Could I have some guidance with how to understand which tests are failing and if there are issues with how I write my code? Thanks
Hey, the pre-commit code checks are actually passing, the problem here is that some of the unit tests are failing

See this guide for running the unit tests locally: https://pandas.pydata.org/docs/dev/development/contributing_codebase.html#running-the-test-suite
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: Fix Docstring Errors for pandas.api.extensions.ExtensionArray
State: closed

- [ ] xref #58539

Fixed SA01 issues for the following methods:

```
 -i "pandas.api.extensions.ExtensionArray SA01" \ 
 -i "pandas.api.extensions.ExtensionArray._accumulate RT03,SA01" \ 
 -i "pandas.api.extensions.ExtensionArray._concat_same_type PR07,SA01" \ 
 -i "pandas.api.extensions.ExtensionArray._formatter SA01" \ 
 -i "pandas.api.extensions.ExtensionArray._from_sequence SA01" \ 
```
Fixed functions also removed from code_checks.sh




Labels:
name: Docs

Comments:
Thanks @gboeker
DOC: Enforce Numpy Docstring Validation for pandas.Timestamp.day_of_week
State: closed

- [ ] xref #58505

fixes

```
pandas.Timestamp.day_of_week
```


Labels:
name: Docs

Comments:
@mroeschke  whenever you have time 🤗
Thanks @tuhinsharma121 (you're doing a great job with these PRs :) )
DOC: Enforce Numpy Docstring Validation for pandas.Int
State: closed

- [ ] xref #58498

It fixes 

```
 -i "pandas.Int16Dtype SA01" \ 
 -i "pandas.Int32Dtype SA01" \ 
 -i "pandas.Int64Dtype SA01" \ 
 -i "pandas.Int8Dtype SA01" \ 
-i "pandas.UInt16Dtype SA01" \
-i "pandas.UInt32Dtype SA01" \
-i "pandas.UInt64Dtype SA01" \
-i "pandas.UInt8Dtype SA01" \
```

Labels:
name: Docs

Comments:
Thanks @tuhinsharma121
ENH: Add support for rolling apply on multiple columns or whole DataF…
State: closed

ENH: Add support for rolling apply on multiple columns or whole DataFrame

- [x] closes #53235

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) for adding a new feature

- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.

- [x] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file for adding a new feature.

This pull request adds support for applying a function to multiple columns or the entire DataFrame when using the `rolling.apply` method. The new `multi_column` parameter has been introduced to enable this functionality.

Key changes:

- Modified the `_apply` function in `pandas/core/window/rolling.py` to handle the `multi_column` parameter and apply the function accordingly.
- Added test cases in `pandas/tests/window/test_rolling_apply.py` to cover the new functionality.
- Added an entry in the release notes (`doc/source/whatsnew/v3.0.0.rst`) to document the enhancement.

Usage example:

```python
import pandas as pd
import numpy as np

data = {'value': [np.nan, np.nan, np.nan, 10],
        'weight': [np.nan, np.nan, 2, 3]}
df = pd.DataFrame(data)

def multi_column_func(window_df):
    return window_df['value'] * window_df['weight']

result = df.rolling(window=2, min_periods=1).apply(multi_column_func, multi_column=True)
print(result)

0         NaN
1         NaN
2         NaN
3    30.0000
dtype: float64

Labels:

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
ENH: Add table name parameter to pandas.read_excel
State: closed

This is a draft to resolve errors and improve PR #58464
- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
REF: Read excel parse refactor
State: closed

This  is related to PR 58464 as a precursor to that enhancement
- [x] Precursor to closing #38937 by refactoring the parse method
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Refactor
description: Internal refactoring of code
name: IO Excel
description: read_excel, to_excel

Comments:
Thanks @iangainey!
BUG: Improve error message when `tansfrom()` with incorrect axis
State: closed

- [x] closes #58474  (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Apply
description: Apply, Aggregate, Transform, Map

Comments:
@rhshadrach thoughts?
Thanks @luke396
CLN: Simplify map_infer_mask
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


This is needed for upcoming numpy string dtype support (getting rid of the ``ndarray[object]`` annotation).

We might also get a decent speedup from using numpy C API functions (but probably not).

EDIT: Looks like benchmarks aren't significantly changed.

Labels:
name: Clean

Comments:
Thanks @lithomas1
BUG: astype not casting values for dictionary dtype correctly
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Arrow
description: pyarrow functionality

Comments:
Thanks @phofl
Fix PR07 error for pandas.Index
State: closed

- [ ] closes DOC: Enforce Numpy Docstring Validation | pandas.Index #58068
- [ ] Fixed Errors found for `pandas.Index`:  PR07 -Parameter "data" has no description



Labels:
name: Docs

Comments:
@aBiR1D delete the line `-i "pandas.Index PR07" \` from `ci/code_checks.sh`
@tuhinsharma121  done.
pre-commit.ci autofix
@aBiR1D fix you linting first. then commit push on this branch. 

```
pip install pre-commit
pre-commit install
pre-commit run -a
```
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Fix PR07,RT03,SA01 errors for Index.join
State: closed

- [x] xref #58068
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
CLN: enforce the deprecation of exposing blocks in core.internals 
State: closed

xref #55355,
enforced the deprecation of `create_block_manager_from_blocks`

xref #55139
enforced the deprecation of exposing `blocks` in `core.internals `


Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
Thanks @natmokval 
I think we need to revert this, and first bump the DeprecationWarning to a FutureWarning. I actually don't care that much about the exact warning class, though, but I think that this is generally the correct way to deal with something we started deprecating with a DeprecationWarning. But I think we should care about keeping this around a bit longer (even though it is with a warning), because this simply means that you cannot use pandas 3.0 with pyarrow < 15, while we actually have a minimum version requirement of pyarrow 10
> I think that this is generally the correct way to deal with something we started deprecating with a DeprecationWarning

Which is similarly as Richard said in https://github.com/pandas-dev/pandas/issues/50578#issuecomment-2105676394
> I think we need to revert this, and first bump the DeprecationWarning to a FutureWarning. I actually don't care that much about the exact warning class, though, but I think that this is generally the correct way to deal with something we started deprecating with a DeprecationWarning. But I think we should care about keeping this around a bit longer (even though it is with a warning), because this simply means that you cannot use pandas 3.0 with pyarrow < 15, while we actually have a minimum version requirement of pyarrow 10

thanks @jorisvandenbossche, I opened [PR](https://github.com/pandas-dev/pandas/pull/58715) to revert this
ENH: Adding table name parameter to pandas.read_excel
State: closed

- [x] closes #38937  (Replace xxxx with the GitHub issue number)

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
As far as I can tell this should be passing all of the tests. Some pre-commit hooks seem to not be passing in this PR but some make no sense, saying there is no attribute, yet there is. Tons of "not indexable errors", that are indexable, and were existing functionality prior to opening this so I'm not certain how it's failing.
Any guidance on getting these to pass would be great.
Agreed with the hesitancy to implement this feature as of now. Going to close since I think more buy-in needs to happen in the issue first, but happy to have a separate PR with the cleanups
I guess I'm a bit confused, as I had tried to get more of a discussion on the issue but could not get any response from you (the development team), only from other contributors. The functionality only adds complexity when the user wants to read in tables, and there are plenty of other functionality in the excel io area of pandas that only works with one of the engines. How does getting more buy-in happen? @mroeschke @rhshadrach 
> The functionality only adds complexity when the user wants to read in tables

Each feature adds a certain amount of technical debt - it increases the surface area of pandas requiring tests, documentation, dealing with new bug reports. It would be unmaintainable to accept all feature requests, therefore we must carefully evaluate what features we do accept.

> there are plenty of other functionality in the excel io area of pandas that only works with one of the engines.

This is something we would like to reduce.

That said - I would take a look at the diff here after #58497 is merged.
Thank you for the explanations, those certainly make sense. 
In regards to looking at the diff here after #58497 is merged, since I can't update this PR and wanted to improve it/resolve any errors I opened at draft PR #58500 that will have a more accurate diff if you would be so kind to look at that.
Apologies for the closed out #58499-had set up working on this project incorrectly initially and was working on the main branch of my fork, finally got these split out into branches properly and linked with the right PR's.

Please let me know any thoughts, issues, or improvements. I would like to understand the discussion as to if or how this functionality should look in pandas.
For the future - we can reopen the PR. But let's continue this in #58500.
Fix #58427 np.bool_(False) & pd.NA gives pd.NA
State: closed

- [x] #58427 

Added examples and remove duplicate Example
Added check in the add operator - if also other is np.False_

Labels:

Comments:
pls hold off on this until joris responds to the question in the original issue.  then we can talk about how to correctly address it
Thank you for the guidance. I appreciate the opportunity to contribute to open source and am eager to learn and follow the proper processes. I'll wait Joris's response before proceeding further. Please let me know if there's anything else I can assist with in the meantime.
Thanks @tal-ladi, but let's close this PR until a decision has been made on the issue