BrandonFors/pandas-github-issues huggingface dataset:
CI: troubleshoot timeouts
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:

Comments:
If you're trying to debug the Azure timeouts, from what I've surmised, it's hanging during the pytest teardown step after the `pandas/tests/window/moments` tests.
> If you're trying to debug the Azure timeouts, from what I've surmised, it's hanging during the pytest teardown step after the pandas/tests/window/moments tests.

OK, do you have a gameplan for this?
I've been trying various approaches to increasing timeouts and seeing if there's the same behavior on GHA (no luck so far). I wouldn't be opposed to just not running the `pandas/tests/window/moments` test again to hopefully get things to green
> I wouldn't be opposed to just not running the pandas/tests/window/moments test again to hopefully get things to green

Yah let's disable it for now and maybe try re-introducing it bit by bit?
closes #44914 by changing the path object to string if it is of io.BufferWriter
State: closed

Changes the path object in to_parquet to string type if it is io.BufferWriter type. PyArrow does not remove the partial file on disk if the path is not string type.

- [x] closes #44914 
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [x] Added code to convert path object from io.BufferWriter type to string type. 


Labels:
name: Bug
name: IO Parquet
description: parquet, feather

Comments:
I have added two tests: 
- Checks to see if PyArrow raises an error when dtype=fp16
- Checks to see if PyArrow removes partial files from disk in case of error 
thanks @Anirudhsekar96 
This makes mypy fail:

`pandas/io/parquet.py:184: error: "RawIOBase" has no attribute "name"  [attr-defined]`
I have opened a new pull request for resolving mypy fail (https://github.com/pandas-dev/pandas/pull/45570)
BUG: ser.loc[range] = foo treating key as positional
State: closed

- [ ] closes #xxxx
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [x] whatsnew entry


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
ci fail is unrelated s3
CI: Align Azure & GHA dependencies
State: closed

Progress toward https://github.com/pandas-dev/pandas/issues/29685

* Share same dependency files between Azure and GHA
* Bump Windows and macOS images to latest
* Don't split Azure jobs by increasing timeout beyond 1 hour

Discoveries:
* Windows and psutil in a multiprocess environment don't play nice
* Anything that spawns threads like numba / pyarrow can cause issues on Azure (more so on Windows than MacOS)

Labels:
name: CI
description: Continuous Integration

Comments:
is it possible to split this up a bit (simply to nail down what is breaking)
> is it possible to split this up a bit (simply to nail down what is breaking)

Sure, I split out the modified tests in https://github.com/pandas-dev/pandas/pull/45702 that can be merged first that contribute to Azure timeout behavior.
looks like a number of builds are take 60+ minutes here.
REF: merge_asof dont use values_for_argsort
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry
cc @mroeschke @jreback 

Original motivation here was to remove an anti-pattern usage of _values_for_argsort.  In the process I found what I _think_ should be a bug, but I haven't been able to write a test that exposes it, could use some help.



Labels:
name: Refactor
description: Internal refactoring of code
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Appears you're trying to tackle joining on nullables from which https://github.com/pandas-dev/pandas/issues/32306 would be relevant. 
I think this should go in, as even if we don't have a test case that fails on the existing version, the version here i think is reliable.  Also this gets rid of the last clearly-antipattern usage of _values_for_argsort
BUG: Boxplots ignore xlabel and boxplot() doesn't support horizontal layout
State: closed

- [X] closes #36918 and closes #45463
- [X] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [x] whatsnew entry


Labels:
name: Visualization
description: plotting

Comments:
@stefmolin could you merge in the main branch once more? We had CI issues this past week
Thanks @stefmolin
BUG: Series[bool].__setitem__(BooleanArray)
State: closed

- [ ] closes #xxxx
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [x] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
hmm can you fix the conflict and rebase; this *might* break on the `_hasna` change
rebased + green
CI/DOC: Fix docbuild link warnings (1.4.x manual backport)
State: closed

Performing this manually since there were some recent changes to `doc/source/ecosystem.rst` and `doc/source/user_guide/cookbook.rst` that were not backported


Labels:
name: Docs

Comments:
nice!
> Performing this manually since there were some recent changes to `doc/source/ecosystem.rst` and `doc/source/user_guide/cookbook.rst` that were not backported

have now backported #45408
DOC: Added info on dict of Series with copy=False solution
State: closed

- [ ] closes #9216 
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
Hello @kaipriester! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2022-01-18 23:59:51 UTC
Thanks @kaipriester
CI: py38 builds
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:
name: CI
description: Continuous Integration

Comments:
@jreback this fixes the py38 builds
Add back __array_wrap__ for dask compatibility
State: closed

xref https://github.com/pandas-dev/pandas/pull/44006/files#r786627658

Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
lots of things failing here, can you merge master
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
Backport PR #45364 on branch 1.4.x (CI/TST: update pyarrow pin in windows-3.8 env / fix failing parquet test on windows)
State: closed

Manual backport of https://github.com/pandas-dev/pandas/pull/45364

Labels:
name: Dependencies
description: Required and optional dependencies

Comments:
https://github.com/pandas-dev/pandas/runs/4855571330?check_suite_focus=true seemed to fail but not sure why here
The failures happens on other PRs that are targetting master, so a general failure it sems
DEPR: undo deprecation of astype(int64) for datetimelike values
State: closed

Closes #45034

Labels:
name: API - Consistency
description: Internal Consistency of API/Behavior
name: Astype

Comments:
ok so going to back to using .astype here rather than .view, ok with that.
ok this is fine. @jorisvandenbossche @jbrockmendel ok here?
sure, can merge this for 1.4 and can hammer out better solution for 1.5
thanks @jorisvandenbossche 
@meeseeksdev backport 1.4.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.4.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -m1 3ac8543dcf3dc2a61945be3bba3855165ef396d7
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #45449: DEPR: undo deprecation of astype(int64) for datetimelike values'
```

4. Push to a named branch:

```
git push YOURFORK 1.4.x:auto-backport-of-pr-45449-on-1.4.x
```

5. Create a PR against branch 1.4.x, I would have named this PR:

> "Backport PR #45449 on branch 1.4.x (DEPR: undo deprecation of astype(int64) for datetimelike values)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.4.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -m1 3ac8543dcf3dc2a61945be3bba3855165ef396d7
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #45449: DEPR: undo deprecation of astype(int64) for datetimelike values'
```

4. Push to a named branch:

```
git push YOURFORK 1.4.x:auto-backport-of-pr-45449-on-1.4.x
```

5. Create a PR against branch 1.4.x, I would have named this PR:

> "Backport PR #45449 on branch 1.4.x (DEPR: undo deprecation of astype(int64) for datetimelike values)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@jorisvandenbossche if you'd push a manual backport here
DOC: Update 10min.rst (removes superfluous indirection in zip-statement.)
State: closed

removes superfluous indirection in zip-statement.

Labels:
name: Docs

Comments:
Thanks. Appears to have a formatting error: https://github.com/pandas-dev/pandas/runs/4853417447?check_suite_focus=true#step:4:69
Made new pull request
Okay. In the future, please just push to the same branch to update the existing pull request.
REF: remove Block.putmask fallback to where
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry

Works locally, curious to see how it fares on other builds.

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves

Comments:
looks fine here, ok?
> looks fine here, ok?

yah, should be good to go
inching closer to de-duplicating Block methods.
compat: catch dateutil ParserError
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry

Giving this another shot.

Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
great
CI: Don't split slow vs non slow jobs for GHA posix
State: closed

Since GHA has a 6 hour job limit, and it appears that slow jobs take ~25 mins and non-slow jobs take ~35 minutes, it shouldn't be necessary to split these anymore.


Helps reduce the number of builds so more can run concurrently.

Labels:
name: CI
description: Continuous Integration

Comments:
this needed?
Yup this is an orthogonal cleanup.
All good here. Failure unrelated. 
@mroeschke needs a rebase
@mroeschke one more rebase if you can and https://github.com/pandas-dev/pandas/runs/4932326914?check_suite_focus=true failed (but looks suprios)
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
CI: Set Azure job timeouts to max limit and don't split
State: closed

Bumps the Azure job limits from 1 hour to 6 hours and unsplits the jobs (due to the time constraints originally).  https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml&viewFallbackFrom=vsts#timeouts

Hopefully this is also enough time for the timeouts we've been seeing in Azure jobs.

Labels:

Comments:
Making another attempt.
CI: Move Windows OS tests to GHA
State: closed

To hopefully address the annoying timeouts in Windows tests on Azure, moving these tests to GHA.

Azure has a timeout limit of 1 hour: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#server-jobs

GHA has a timeout limit of 6 hours (among other things): https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits


Labels:

Comments:
Trying another approach first
REGR: DataFrame(dict) missing columns should not be views
State: closed

- [x] closes #45369
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:
name: Constructors
description: Series/DataFrame/Index/pd.array Constructors

Comments:
@meeseeksdev backport 1.4.x
Something went wrong ... Please have a look at my logs.
BUG: setting pd.NA into Series casts to object
State: closed

- [x] closes #44199
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [x] whatsnew entry

Example
```
ser = pd.Series([0.0, 1.0])
ser[0] = pd.NA
>>> ser.dtype
dtype('O')   # <- main
dtype('float64')  # <- PR
```

Labels:
name: Bug
name: Dtype Conversions
description: Unexpected or buggy dtype conversions

Comments:
Can you give a code example of what actually changed? (what is the dtype now?) It's a bit hard to directly see from the code changes what it does in practice
> Can you give a code example of what actually changed? (what is the dtype now?) It's a bit hard to directly see from the code changes what it does in practice

updated OP with example
lgtm
PEP 561
State: closed

According to PEP 561, we just need to add this file to mark the lib as typed.

I don't know if all the lib is typed, maybe we also need to do that before merging.

- [ ] tests passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them


Labels:

Comments:
Thanks for the PR but this approach is still being discussed in https://github.com/pandas-dev/pandas/issues/28142 and https://github.com/pandas-dev/pandas/issues/45253, and pandas is not fully typed yet, so those issues need addressing before we can move forward with this.

Closing, but feel free to engage in the discussion in those issues first to move this along!
CI: py38 builds
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:
name: CI
description: Continuous Integration

Comments:
greenish
hmm does this fix?
> hmm does this fix?

fixes the py38 issue yah
btw who is the go-to person for merge_asof?
you, me or @mroeschke 
hah if its me then we're in trouble
ENH: Add numba engine to groupby.min/max
State: closed

- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [x] whatsnew entry


Labels:
name: Enhancement
name: numba
description: numba-accelerated operations

Comments:
thanks @mroeschke
BUG: accept strings in FloatingArray._from_sequence
State: closed

- [ ] closes #xxxx
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [x] whatsnew entry

Makes FloatingArray behavior match IntegerArray.  After this we can refactor to share most of coerce_to_array.

Labels:
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
yep can you add a note & rebase
whatsnew added + green
DEPR: Index.is_monotonic for Index.is_monotonic_increasing
State: closed

- [x] closes #21335
- [ ] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [x] whatsnew entry


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
closes #21335 i think
thanks @mroeschke
BUG: BooleanArray+pd.NA altering array inplace
State: closed

- [ ] closes #xxxx
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [x] whatsnew entry


Labels:
name: Bug
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks!
REF: share BooleanArray.astype+NumericArray.astype
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:
name: Refactor
description: Internal refactoring of code
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
can you merge master
rebased + greenish
CLN: remove _from_mgr (no longer used after GH-45363)
State: closed

One part of the follow-up to https://github.com/pandas-dev/pandas/pull/45363

This one doesn't necessarily need to be backported to 1.4

Labels:
name: Groupby

Comments:
we just merged some cleanup similar to this by @jbrockmendel so if you can rebase
@jbrockmendel it would be useful if you can mention the PR when doing a follow-up to a specific PR (so that github shows it as a linked PR in the original PR)
thanks @jorisvandenbossche
ENH: Add dtypes/converters arguments for pandas.read_xml
State: closed

- [X] closes #43567
- [X] tests added / passed
- [X] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [X] whatsnew entry


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: IO XML
description: read_xml, to_xml

Comments:
thanks @ParfaitG failures unrelated
CLN: remove sqlalchemy<14 compat
State: closed


Labels:
name: IO SQL
description: to_sql, read_sql, read_sql_query
name: Dependencies
description: Required and optional dependencies

Comments:
CI is bumped for >= 1.4? and there is a whatsnew note on this?
> CI is bumped for >= 1.4? and there is a whatsnew note on this?

yes #43191
thanks @fangchenli
DOC: Clean up redirects & dead links
State: closed

Ran `sphinx-build -b linkcheck` and fixed some redirects and dead links


Labels:
name: Docs

Comments:
> 

we could add a check for this (after everything is fixed)
> > 
> 
> we could add a check for this (after everything is fixed)

Yup xref https://github.com/pandas-dev/pandas/issues/45409
@jreback ok to backport this? (it made a change to the 1.4.0 release notes so they are out of sync or could just sync the notes but would maybe be good to have the broken links fixed on the next release of the docs)
oh sure any of the doc ones are fine
@meeseeksdev backport 1.4.x
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.4.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -m1 ca5d9ee9d1eae7c642634413cb22092e0c9334ea
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #45408: DOC: Clean up redirects & dead links'
```

4. Push to a named branch:

```
git push YOURFORK 1.4.x:auto-backport-of-pr-45408-on-1.4.x
```

5. Create a PR against branch 1.4.x, I would have named this PR:

> "Backport PR #45408 on branch 1.4.x (DOC: Clean up redirects & dead links)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
conflict was with #45456 which was already backported.
STYLE: use option_context almost always
State: closed

Replaces `set_option` except when this function is directly tested.

Happy to revisit/revise if I missed anything. Thanks!

- [x] closes #38813
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) for how to run them
- [ ] whatsnew entry


Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
@jreback, trying to understand if there's an actual failure here or just a timeout with Azure (and I don't see an option to retry). If you can point me to an error in the pr, I'd be happy to fix it. 
thanks @chrismoradi
Backport PR #44839 on branch 1.4.x (REGR: allow reindexing datetimelike with upcast / raise deprecation warning)
State: closed

Backport PR #44839: REGR: allow reindexing datetimelike with upcast / raise deprecation warning

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Deprecate
description: Functionality to remove in pandas

Comments:
restarted failing tests. 

pandas-dev.pandas (Windows py38_np18_2) failed on second attempt. timeout

Posix / pytest (actions-38-minimum_versions.yaml, not slow and not ne... failed on different test but with same ResourceWarning

1st attempt FAILED pandas/tests/io/formats/style/test_deprecated.py::test_hide_index_columns[index]
2nd attempt FAILED pandas/tests/io/formats/style/test_deprecated.py::test_where_subset[slice_4]

Will assume unrelated to this PR and merge.