BrandonFors/pandas-github-issues huggingface dataset:
DEPR: Enforce deprecation of na_sentinel
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

cc @jbrockmendel @jorisvandenbossche 

Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff
name: Deprecate
description: Functionality to remove in pandas

Comments:
```
Error: /home/runner/work/pandas/pandas/pandas/core/base.py:1139:GL03:pandas.Series.factorize:Double line break found; please use only one blank line to separate sections or paragraphs, and do not leave blank lines at the end of docstrings
Error: /home/runner/work/pandas/pandas/pandas/core/algorithms.py:586:GL03:pandas.factorize:Double line break found; please use only one blank line to separate sections or paragraphs, and do not leave blank lines at the end of docstrings
Error: /home/runner/work/pandas/pandas/pandas/core/base.py:1139:GL03:pandas.Index.factorize:Double line break found; please use only one blank line to separate sections or paragraphs, and do not leave blank lines at the end of docstrings
```
@rhshadrach heads up - there's a merge conflict
Thanks @mroeschke, it's now resolved.
circleCI failure looks like its the float->dt64 astype issue, i.e. unrelated
@rhshadrach looks like there's a merge conflict; otherwise, looks good to merge
Thanks @rhshadrach
DEPR: Enforce deprecation of silent dropping of nuisance columns in agg_list_like
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

It seemed to me we'd lose test coverage with some of the tests if we just were tested these ops raised. So I split some into testing without the nuisance columns and with them.


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Apply
description: Apply, Aggregate, Transform, Map
name: DataFrame
description: DataFrame data structure

Comments:
small question, otherwise LGTM.  looks like CI failures are unrelated
cc @mroeschke merge when ready
@rhshadrach are you planning to do the other nuisance-columns ones?
@jbrockmendel - yes, happy to take them all.
enable pylint:useless-return
State: closed

Issue #48855. This PR enables pylint type "R" warning:  "useless-return". 
In one place (https://github.com/natmokval/pandas/blob/da3025ae6dec3fed73df0cf1d1bbc5ef0d816695/pandas/tests/groupby/test_apply.py#L151) the warning is disabled to match the style of surrounding functions. 

- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
Thanks @natmokval - I think the CI failure's unrelated but I've merged upstream/main to restart the checks to be sure
Sweet, thanks @natmokval 
Thank you @mroeschke
DEPR: remove 1.0 deprecations in 2.0 (`Styler`)
State: closed

Removed deprecations from Styler:

- `where()`
- `hide_index`
- `hide_columns`
- `render`
- `set_na_rep`
- `set_precision`
-  `null_color` kwarg in `highlight_null`


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Styler
description: conditional formatting using DataFrame.style

Comments:
can you add appropriate notes in the whatsnew
Thanks @attack68
BUG: Fixing DataFrame.Update crashes when NaT present
State: closed

- [x] closes #16713 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: DataFrame
description: DataFrame data structure

Comments:
@MarcoGorelli Made changes for the comments you left and added to the whatsnew!
DEPR: Timestamp comparison with pydate
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Timestamp
description: pd.Timestamp and associated methods

Comments:
rebased+green
Thanks @jbrockmendel
Make the conversion from dtype to subclass just a little faster
State: closed

Calling `is_float_dtype` is a really "safe" way to take an array or a dtype and know if it is a subclass.

But I don't think you need to do that. Checking the `kind` should be enough. I get about 5-10% faster on the benchmarks shown. Mostly reducing 12us to 11.5 us. I think it is real.

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Performance
description: Memory or execution speed performance
name: Index
description: Related to the Index class or subclasses

Comments:
I think maybe my knowledge of "isinstance" is really outdated. I can't find a meaningful difference running the benchmarks on my computers.

oh well.
feel free to close or merge, sorry for the noise.
ExtensionDtype case is handled separately above.  its also a bit of a moot point since Float64Index, Int64Index, and UInt64Index are going away soon.
Ah I missed that portion of the function. Okay I think I would be okay with this then
thanks @hmaarrfk 
👍🏾
DEPR: internals
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Deprecate
description: Functionality to remove in pandas

Comments:
The minimum version failures look real due to fastparquet. Maybe means we need to bump it?
fastparquet bump did the trick
Thanks @jbrockmendel
DEPR: disallow unit-less dt64 dtype in astype
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks @jbrockmendel
enable pylint for wrong-import-order (#48855)
State: closed

This PR enables pylint C-Type message "wrong-import-order". The warnings from pylint are fixed.
Issue #48855

Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
Looks like `precommit` is also failing, please see https://pandas.pydata.org/docs/development/contributing_codebase.html#contributing-pre-commit for how to fix
Might be better to just leave this one turned off, there's already `isort` for import order
Thanks. Looks like `isort` does a similar thing as `wrong-import-order`, so it would be better to leave the last one turned off. I won't work on `wrong-import-order` any longer.
sure - closing for now then, thanks
DOC: add name parameter to the IntervalIndex for #48911
State: closed

- [x] closes #48911
- [x] Added an entry in the latest `doc/source/whatsnew/v2.0.0.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
@Dr-Irv 
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 3872572512b4ea5af50618203331d9c7cc5d5fd8
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #49386: DOC: add name parameter to the IntervalIndex for #48911'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-49386-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #49386 on branch 1.5.x (DOC: add name parameter to the IntervalIndex for #48911)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@sylviaovo can you follow the backport instructions so we can include this in the 1.5.2 release whenever that happens?
asv groupby.string smaller_faster
State: closed

xref #44450

- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Decreased the size, should take significantly less time

Labels:
name: Strings
description: String extension data type and string data
name: Benchmark
description: Performance (ASV) benchmarks

Comments:
Sweet, thanks @debnathshoham
DEPR: Enforce dropping of datetime in DataFrame.mean/median with numeric_only=None
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: DataFrame
description: DataFrame data structure
name: Reduction Operations
description: sum, mean, min, max, etc.
name: Nuisance Columns
description: Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply

Comments:
#49250 addresses this but interprets it the opposite way
Ah, I thought I checked the queue but must have missed yours.

> but interprets it the opposite way

Not sure what you mean by this, they seem pretty compatible to me. Comparing them, I see now I removed a warning that shouldn't have been. Closing in favor of yours.
STYLE: fix pylint unneeded-not warnings
State: closed

Related to https://github.com/pandas-dev/pandas/issues/48855
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I added `# pylint: disable=unneeded-not` for tests where the intention was clearly to test the `not` operator.

Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
Awesome, thanks again @Moisan
DEPR: Timestamp(dt64obj, tz=tz)
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
rebased + green
Thanks @jbrockmendel
issue 48855 enable pylint C-type "disallowed-name " warning
State: closed

[x] Refers to one of the issues in STYLE fix pylint issues [#48855](https://github.com/pandas-dev/pandas/issues/48855)
[x ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
I have enabled the C-type "disallowed-name " warning in pylint and renamed the "[bad names](https://pylint.pycqa.org/en/latest/user_guide/configuration/all-options.html#bad-names)" flagged by this warning


Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
Just added one small commit removed the `pass` causing `pylint` failure after #49418
One merge conflict otherwise LGTM
> One merge conflict otherwise LGTM

Am I reading the conflict correctly that the assertion should be removed?

```
<<<<<<< pylint-48855-C-type-disallowed-name
    aggs = ["sum", sum_div2, "count", "min"]
    with tm.assert_produces_warning(
        FutureWarning, match=r"\['item'\] did not aggregate successfully"
    ):
        result = df.agg(aggs)
=======
    aggs = ["sum", foo, "count", "min"]
    result = df.agg(aggs)
>>>>>>> main
```
That is correct
yeah it's just because https://github.com/pandas-dev/pandas/pull/49401/files#diff-94eebfea2f48a4a1fcce99c6af1c99613cabe5e05c47f4a21378699680ac4db9 also modified the same lines of code and was merged first
Great, thanks @stellalin7
API/BUG: Fix is_string_dtype and make more strict
State: closed

- [x] closes #15585 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Started with fixing pytest warnings about `return` being used instead of `assert`

Fixing led to some extension dtype tests being seemingly incorrect w/r/t `is_string_dtype` which pointed to #15585

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Strings
description: String extension data type and string data

Comments:
CI failures are unrelated
This patch may have induced a potential regression. Please check the links below. If any ASVs are parameterized, the combinations of parameters that a regression has been detected appear as subbullets. This is a partially automated message.

Subsequent benchmarks may have skipped some commits. See the link below to see which commits are between the two benchmark runs where the regression was identified.

https://github.com/pandas-dev/pandas/compare/a215264d472e79c48433fa3a04fa492abc41e38d...b77417832c76f0027723cad68ffd5654bbafe2a9

 - [strings.Dummies.time_get_dummies](https://asv-runner.github.io/asv-collection/pandas/#strings.Dummies.time_get_dummies)
   - [dtype='str'](https://asv-runner.github.io/asv-collection/pandas/#strings.Dummies.time_get_dummies?p-dtype=%27str%27)
   - [dtype='string[pyarrow]'](https://asv-runner.github.io/asv-collection/pandas/#strings.Dummies.time_get_dummies?p-dtype=%27string%5Bpyarrow%5D%27)
   - [dtype='string[python]'](https://asv-runner.github.io/asv-collection/pandas/#strings.Dummies.time_get_dummies?p-dtype=%27string%5Bpython%5D%27)
There are a lot of patches between the two commits where the regression was identified, but it seems to me this is where it occurred. Given the behavior change in this PR, I think this is entirely expected.
BUG: Fix passing `Colormap` instance to plot methods with mpl >= 3.6
State: closed

- [x] closes #49374
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Visualization
description: plotting
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
Just a merge conflict, otherwise looks good
Thanks for the quick fix @zmoon 
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 1.5.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 c4a24d29bc47a673a3d84980c8d9a8a9040dc076
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #49377: BUG: Fix passing `Colormap` instance to plot methods with mpl >= 3.6'
```

4. Push to a named branch:

```
git push YOURFORK 1.5.x:auto-backport-of-pr-49377-on-1.5.x
```

5. Create a PR against branch 1.5.x, I would have named this PR:

> "Backport PR #49377 on branch 1.5.x (BUG: Fix passing `Colormap` instance to plot methods with mpl >= 3.6)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
@zmoon would you have time to follow the instructions above to submit a backporting PR to target the 1.5.x branch?
@mroeschke happy to have a go
CLN: Remove xlrd < 2.0 code
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

The minimum version of xlrd was bumped to 2.0.1 in pandas 1.4.0. This is mostly doing some cleanup - removing a FutureWarning that can no longer be hit. The only behavior change here is that when the user specifies `engine="xlrd"` on a non-xls file, we attempt to use the xlrd engine instead of raising directly.

Edit: And we now also warn the user any time xlrd is used.


Labels:
name: IO Excel
description: read_excel, to_excel
name: Clean

Comments:
Thanks @rhshadrach
DEPR: Enforce deprecation of partial failure in transform for lists/dicts
State: closed

From #43740

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Apply
description: Apply, Aggregate, Transform, Map
name: Nuisance Columns
description: Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply

Comments:
small nitpick, otherwise LGTM.  excited to see this change
thanks @rhshadrach pls be sure to update #30228
It's on the same line as #49401, so will update after that PR is merged.