BUG: avoid usage in_qtconsole for recent IPython versions
State: closed

I've verified this manually with qtconsole 4.4.0, but if others want to check that'd be helpful.

![screen shot 2019-01-30 at 2 22 06 pm](https://user-images.githubusercontent.com/1312546/52010178-794a8080-249a-11e9-9376-a9254ce6bbf9.png)

What release should this be done in? 0.24.1, 0.24.2 or 0.25.0?

Closes https://github.com/pandas-dev/pandas/issues/25036

Labels:
name: Dependencies
description: Required and optional dependencies

Comments:
For reference, IPython 3.0 was released in Feb. 2015 https://pypi.org/project/ipython/3.0.0/
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25039?src=pr&el=h1) Report
> Merging [#25039](https://codecov.io/gh/pandas-dev/pandas/pull/25039?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/149138ef008a26bca04f4b698e15ff8fd3ce4663?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `62.5%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25039/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25039?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #25039      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52397    52403       +6     
==========================================
+ Hits        48404    48405       +1     
- Misses       3993     3998       +5
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.79% <62.5%> (-0.02%)` | :arrow_down: |
| #single | `42.87% <12.5%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/25039?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/25039/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `96.82% <62.5%> (-0.11%)` | :arrow_down: |
| [pandas/io/formats/console.py](https://codecov.io/gh/pandas-dev/pandas/pull/25039/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2Zvcm1hdHMvY29uc29sZS5weQ==) | `66.66% <0%> (-5.8%)` | :arrow_down: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/25039/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `88.13% <0%> (+0.09%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25039?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25039?src=pr&el=footer). Last update [149138e...acd50bb](https://codecov.io/gh/pandas-dev/pandas/pull/25039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

> What release should this be done in? 0.24.1, 0.24.2 or 0.25.0?

Is there a reason to already do it in 0.24.x ?
sure we should drop, but this should be done in 0.25
The reason to do it soon is because it's affecting users: https://github.com/pandas-dev/pandas/issues/25036 I see that I forgot to link to that in the PR, sorry.
I suppose https://github.com/pandas-dev/pandas/issues/25036 is the reason?

As a solution for 0.24.1, we could also check the version of IPython, and only run that code for old IPython versions. So we don't break support in a bug fix release, but we also actually fix the bug for most users that will not have such old IPython version. 
ok this seems fine then for 0.24.1
can you add a note in whatsnew
@jorisvandenbossche switched to the check you suggested in 
https://github.com/pandas-dev/pandas/pull/25039#issuecomment-459116270, if you want to check.

I'll followup with the original PR of removing all this shortly after 0.24.1.