BrandonFors/pandas-github-issues huggingface dataset:
Added links to useful discussions of groupby and SettingWithCopyWarning
State: closed

Added links to useful discussions of `groupby` and `SettingWithCopyWarning`.

Did not run tests as only docs changed, but `python make.py --single groupby` and `python make.py --single indexing` successfully create the respective html files.

- [x] closes #17505
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21916?src=pr&el=h1) Report
> Merging [#21916](https://codecov.io/gh/pandas-dev/pandas/pull/21916?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2b51c968ca1e16a7fb517968576f8a9ab47ce1ed?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21916/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/21916?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21916   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         166      166           
  Lines       50323    50323           
=======================================
  Hits        46281    46281           
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.36% <ø> (ø)` | :arrow_up: |
| #single | `42.23% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21916?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21916?src=pr&el=footer). Last update [2b51c96...927d7c8](https://codecov.io/gh/pandas-dev/pandas/pull/21916?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

worth adding some text / examples from the blog as well?

@datapythonista 
I'm unsure about adding many links to third parties in the documentation. If a blog is clearer than the documentation, I think we should improve the documentation as a preferred practice.

@supern8ent what do you think it's missing in the docs that those links clarify?


@datapythonista Honestly I was at my first sprint and just looking for a doc issue to squash. I agree  that it's better to improve the documentation than link, but I can't answer your question (what specifically is missing) since it wasn't my idea in the first place. 

@jreback I suggest rejecting the PR and clarifying issue 17505 a bit.
I thought some is the prose and examples in the blog were pretty clear. might be worth cribbing from it
Ok, just including links is not preferred. Better to use those works as a reference to improve pandas documentation.
[BUG] Fix interpolation for datetimelike dtypes
State: closed

- [x] closes #11312, #11701, #19199,
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

Two bugs here, one fixed, one avoided.  First is in `Block._interpolate` where datetimelike values were not cast correctly.  Second is that `DataFrame.transpose` will raise in some conditions (see #19198, also motivated #21908).

This adds dtype-handling code in `Block._interpolate`.  An alternative would be to override `_interpolate` in subclasses.  Either way works for me.

NB: This is only implemented for `method='linear'`.  I made that explicit in the tests as a reminder to follow-up with others.

(#19199 is marked as  a duplicate but it includes a bug report for the TZ-aware case that is separate bug.)

Labels:
name: Enhancement
name: Datetime
description: Datetime data dtype
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
I'll hold off on pushing this until #21870 (and possibly #21903) go through to avoid rebasing hell
Closing temporarily to clear the queue.
Looks like this was lost somewhere in the process. Pity, would be great to see this somewhen :) 
@nielsuit227 you're welcome to pick this up and run with it
Use the Agg backend for docs builds
State: closed

This uses a non-interactive Agg matplotlib backend to build docs, which avoids trying to use the default MacOS backend, which can fail in some environments.

Closes #21913.

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21914?src=pr&el=h1) Report
> Merging [#21914](https://codecov.io/gh/pandas-dev/pandas/pull/21914?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2b51c968ca1e16a7fb517968576f8a9ab47ce1ed?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21914/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21914?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21914   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         166      166           
  Lines       50323    50323           
=======================================
  Hits        46281    46281           
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.36% <ø> (ø)` | :arrow_up: |
| #single | `42.22% <ø> (-0.01%)` | :arrow_down: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21914?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21914?src=pr&el=footer). Last update [2b51c96...24ca96c](https://codecov.io/gh/pandas-dev/pandas/pull/21914?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jorisvandenbossche @TomAugspurger @datapythonista 
Looks good, tested on Linux.

I was just guessing whether it'd be possible to set an environment variable in `conf.py` instead of creating a new file. Not a big deal, but there are already many files in `doc/source` and if it's the same, I'd prefer changing `conf.py` than adding a new file.

I'd say this link is about the same problem: https://stackoverflow.com/questions/25124977/cant-use-sphinxs-matplotlib-extension-with-qt-on-os-x#25164523

What do you think @tdsmith ?
Just to check, this has no influence on how the figures look in the docs? (the quality)
No quality difference that I can spot:

![screenshot at 2018-07-16 14-53-38](https://user-images.githubusercontent.com/10058240/42780142-16083f68-8908-11e8-952e-47e2be7e2c43.png)

I would also assume this can be set in `conf.py`
Thanks for the review, all! I just realized you asked for conf.py and not make.py -- it works for me in either place; AFAICT tweaking the environment is still the right thing to do in either place.
thanks @tdsmith
Add statsmodels to optional dependencies
State: closed

Some of the documentation uses methods from statsmodels, which isn't included in the optional dependency list.

Fixes #21911.

- [x] closes #xxxx
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Build
description: Library building on various platforms
name: Docs
name: Dependencies
description: Required and optional dependencies

Comments:
yep lgtm.

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21912?src=pr&el=h1) Report
> Merging [#21912](https://codecov.io/gh/pandas-dev/pandas/pull/21912?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2b51c968ca1e16a7fb517968576f8a9ab47ce1ed?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21912/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21912?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21912   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         166      166           
  Lines       50323    50323           
=======================================
  Hits        46281    46281           
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.36% <ø> (ø)` | :arrow_up: |
| #single | `42.23% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21912?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21912?src=pr&el=footer). Last update [2b51c96...2126d51](https://codecov.io/gh/pandas-dev/pandas/pull/21912?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
BUG: issues with hash-function for Float64HashTable (GH21866)
State: closed

The following issues

   1)  hash(0.0) != hash(-0.0)
   2)  hash(x) != hash(y) for different x,y which are nans

are solved by setting:

   1) hash(-0.0):=hash(0.0)
   2) hash(x):=hash(np.nan) for every x which is nan

- [x] closes #21866
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
Test failure appears unrelated.  Can you push again to re-run it?
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21904?src=pr&el=h1) Report
> Merging [#21904](https://codecov.io/gh/pandas-dev/pandas/pull/21904?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/322dbf4f812f47d4eaee5d8afa10e17acf6dbc67?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21904/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21904?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21904   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         167      167           
  Lines       50578    50578           
=======================================
  Hits        46530    46530           
  Misses       4048     4048
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.4% <ø> (ø)` | :arrow_up: |
| #single | `42.17% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21904?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21904?src=pr&el=footer). Last update [322dbf4...124b095](https://codecov.io/gh/pandas-dev/pandas/pull/21904?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

can you run an asv and report any anomalies
@jbrockmendel  No, it was a problem in the one of the added test cases: somewhat naively 16GB memory were reserved (but not committed!), yet obviously different operating systems with different resources reacts differently to such a request.

It is a little bit strange, that the testing just died and didn't recover from that...

I removed these silly tests and now it looks better (at least it is clear, what goes wrong).
@jreback Done.
@jbrockmendel any comments? if ok pls merge.
@realead good job catching a subtle bug.  Thanks for taking point on this.
TST/CLN: series.duplicated; parametrisation; fix warning
State: closed

Splitting up #21645

Added tests for `duplicated`, parametrized two tests for `drop_duplicates`, fixed a warning from #21614.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21899?src=pr&el=h1) Report
> Merging [#21899](https://codecov.io/gh/pandas-dev/pandas/pull/21899?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2b51c968ca1e16a7fb517968576f8a9ab47ce1ed?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21899/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21899?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21899   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         166      166           
  Lines       50323    50323           
=======================================
  Hits        46281    46281           
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.36% <ø> (ø)` | :arrow_up: |
| #single | `42.22% <ø> (-0.01%)` | :arrow_down: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21899?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21899?src=pr&el=footer). Last update [2b51c96...e640040](https://codecov.io/gh/pandas-dev/pandas/pull/21899?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

needs a rebase
@jreback All just left-overs from the previous module. Hopefully converging on a clean module soon... ;-)
@h-vetinari absolutely - is just easier to fix when exracting things and make nice and clean
> can u do the same for frame? (unique and duplicates)

@jreback I did the same for frame in #21898
@jreback Actually, did the same for #21900 as well - e.g. replace `pd.` with direct imports
thanks @h-vetinari
DOC: move feature to correct whatsnew section; typos
State: closed

Splitting up #21645. 

Motivation is easy: when I started working on #21645, there was nothing under "New Features" (usually having a descriptive section each) except this one-liner. To me, this belongs to "Other Enhancements".

Plus found some typos and stuff where the `rst` breaks (cannot have something directly after closing backticks).


Labels:
name: Docs

Comments:
thanks!
Multi line comment
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
@Giftlin : Thanks for the PR!  In general, we use the `#` if the comments are not docstrings, so I actually would prefer to leave that comment as is.
Multi line comment
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
@Keerthivasan1990 : Thanks for the PR! In general, we use the # if the comments are not docstrings, so I actually would prefer to leave that comment as is.
use npy_datetimestruct instead of pandas_datetimestruct
State: closed

Follow-on to #21863 

Labels:
name: Datetime
description: Datetime data dtype
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21886?src=pr&el=h1) Report
> Merging [#21886](https://codecov.io/gh/pandas-dev/pandas/pull/21886?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bdb61688aa80a6ec9bdb6832946dd83ab4b4c9c8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21886/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21886?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21886   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         164      164           
  Lines       49992    49992           
=======================================
  Hits        45952    45952           
  Misses       4040     4040
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `42.16% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21886?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21886?src=pr&el=footer). Last update [bdb6168...31e756d](https://codecov.io/gh/pandas-dev/pandas/pull/21886?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@WillAyd thoughts?  Should be easy follow-up to PANDAS_DATETIMEUNIT change
thanks @jbrockmendel 
when i rebuilt locally after merging this I got an error about finding pandas_datetimeunit, so I think we are missing a dep somewhere (on a np.datetime.pxd?)

works after a ``make clean``
TST: Parametrize tests in tests/util/test_hashing.py
State: closed

Noticed that these tests could be parametrized when investigating a comment in the `IntervalArray` PR, and originally started doing to work there.  The `IntervalArray` PR is big enough already, and this is unrelated, so creating a separate PR.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21883?src=pr&el=h1) Report
> Merging [#21883](https://codecov.io/gh/pandas-dev/pandas/pull/21883?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bdb61688aa80a6ec9bdb6832946dd83ab4b4c9c8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21883/graphs/tree.svg?token=eZ4WkYLtcO&width=650&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21883?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21883   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         164      164           
  Lines       49992    49992           
=======================================
  Hits        45952    45952           
  Misses       4040     4040
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `42.16% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21883?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21883?src=pr&el=footer). Last update [bdb6168...3124d0c](https://codecov.io/gh/pandas-dev/pandas/pull/21883?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @jschendel
Cleanup cimports, implement bits of numpy_helper in util.pxd
State: closed

Removes a few unnecessary uses of `cnp.import_array()`

Uses cython's conditional compilation to avoid runtime PY2/PY3 checks

Arranges cython imports in stdlib-->3rd party--> internal order.

Separates out the one part of `libresolution._FrequencyInferer` that we actually _do_ want to keep in cython

Couple of small lintings in groupby.pyx

Labels:
name: Internals
description: Related to non-user accessible pandas implementation
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21878?src=pr&el=h1) Report
> Merging [#21878](https://codecov.io/gh/pandas-dev/pandas/pull/21878?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bdb61688aa80a6ec9bdb6832946dd83ab4b4c9c8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21878/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21878?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21878   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         164      164           
  Lines       49992    49992           
=======================================
  Hits        45952    45952           
  Misses       4040     4040
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `42.16% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21878?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21878?src=pr&el=footer). Last update [bdb6168...003babf](https://codecov.io/gh/pandas-dev/pandas/pull/21878?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @jbrockmendel a couple of things ought to do in the future PRs
BUG: Align Series.str.zfill() with str.zfill()
State: closed

- [ ] closes #20868
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Using standard library `zfill` method directly to handle specific characters issue

Labels:
name: Bug
name: Strings
description: String extension data type and string data

Comments:
@atulagrwl : Good start!  Need a `whatsnew` entry in `0.24.0` as well.
Added the validation test in last commit and added whatsnew entry too.
can you rebase
closing as stale. if you'd like to continue, pls ping.