BrandonFors/pandas-github-issues huggingface dataset:
TST / string dtype: add env variable to enable future_string and add test build
State: closed

xref https://github.com/pandas-dev/pandas/issues/54792

Taking a similar approach as we did for CoW: allow enabling the option with an env variable (also useful for testing locally), and add an extra build on CI with that option enabled. 

Not all tests are passing yet, so will see how to mark this build as "allow failures", but I think it would already be useful to set up the infra so we can fix the tests piecewise in follow-ups.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Strings
description: String extension data type and string data
name: backported

Comments:
started a branch similar to this to get the tests passing; i count 
1592
1615 failures locally.  Of these, 529 are in tests/io (with `-m "not db and not slow"` so may be missing some).  810 are in pandas/tests/groupby/test_raises.py::test_groupby_raises_string. 
> 810 are in pandas/tests/groupby/test_raises.py::test_groupby_raises_string.

Impressive that a single test can give 810 failures ;) But then that set of failures should also be relatively easy to solve I suppose
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
I am going to merge this as this makes testing further string dtype related PRs a lot easier. But happy to further bikeshed on the name and easy to change that later.
CI: fix CI failure for PDEP with status: Draft
State: closed

cc @WillAyd 

This will only fix the CI failure, but 2 things to note:
1- The PDEP won't be shown in https://pandas.pydata.org/about/roadmap.html
2- If the PR gets the PDEP label, it will be considered as "Under Discussion" in the website roadmap
I want to fix that, but how will we differentiate? Do we check if the PR is marked as Draft? Or do we check if the PR has a certain label? (e.g. make a PDEP: draft label or use the needs discussion label)


Labels:
name: Stale

Comments:
I don't think we want to add draft PDEPs to the website but @datapythonista would know best
Going to mark this as ready for review as this fixes the CI failure. 

As for the problem of draft PDEPs currently appearing in the website roadmap, the only fix I can think of is to make an API request for each opened PDEP PR and fetch the content of the PDEP file and see if the status is written as draft or not, but I will wait for @datapythonista's input before doing that as that is not the cleanest of solutions.

@WillAyd if you think it's appropriate, can we add some certain label to be able to differentiate between draft and under discussion PDEPs? If that's possible, then I can follow up with a very simple fix, otherwise I will just open an issue to not forget about this.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Fix PR07,RT03,SA01 errors for Index.union, Index.symmetric_difference
State: closed

- [x] xref #58068
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
Fix PR07,RT03,SA01 errors for Index.insert, Index.intersection
State: closed

- [x] xref #58068
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
Fix errors for Index.drop, Index.reindex
State: closed

- [x] xref #58068
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
Fix PR07,RT03,SA01 errors for Index.append, Index.difference
State: closed

- [x] xref #58068
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
Update compute_dict_like to get all columns
State: closed

- [x] closes #55041  (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Groupby
name: Apply
description: Apply, Aggregate, Transform, Map

Comments:
Thank you for the review, I have added comments as per the review.
Thanks for the patience here @undermyumbrella1 - I should be able to get to this by Friday.
@undermyumbrella1 - looks like some unrelated failures, can you merge main to make sure.
Thanks @undermyumbrella1
String dtype: implement object-dtype based StringArray variant with NumPy semantics
State: closed

Similarly like https://github.com/pandas-dev/pandas/pull/54533 added a variant of the pyarrow-backed string dtype to use numpy nullable (NaN) semantics (now named `StringDtype(storage="pyarrow", na_value=np.nan)` with `ArrowStringArrayNumpySemantics`), this PR does the same for our object-dtype numpy array backed StringArray: a new `StringDtype(storage="python", na_value=np.nan)` with the corresponding `StringArrayNumpySemantics` array.

Illustration for discussion in https://github.com/pandas-dev/pandas/issues/57073

xref https://github.com/pandas-dev/pandas/issues/54792

Labels:
name: Strings
description: String extension data type and string data
name: backported

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
This PR is certainly not yet perfect (and further reviews are welcome!), but I am going to merge it: we still have to fix a lot of things in general anyway (all the xfailing tests with the current implementation), and by getting this in now we start addressing those xfails (e.g. https://github.com/pandas-dev/pandas/pull/59430), we can fix the tests/implementations for both dtype variants at the same time.
CLN: Changed the behavior of `Series.__[gs]etitem__ ` with an integer slice on objects with a floating-dtype index to a positional instead of label-based slicing
State: closed

xref #53338
Changed the behavior of `Series.__getitem__`, `Series.__setitem__`, `DataFrame.__getitem__`, `DataFrame.__setitem__` with an integer slice on objects with a floating-dtype index to a positional instead of label-based slicing

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Clean

Comments:
closed since this was handled in #58646
ENH: Add jsonline output format in to_dict(), failing type checks
State: closed

- [ ] closes #58123 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I got stuck and this is incomplete. Maybe it's not a great thing to do returning string in to_dict() functions.


Labels:

Comments:
Thanks for the contribution! As mentioned in the original issue, this is already doable with `DataFrame.to_json(orient='records', lines=True)`, and `DataFrame.to_dict` should only be returning a dictionary value and not a string (hence the name), so it doesn't make sense to implement it here
I agree with @Aloqeely - this should already be implemented via .to_json so no reason to duplicate that here
BUG: Overflow warning when using Series.diff() on Series with Periods
State: closed

- [x] closes #58320 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Labels:
name: Period
description: Period data type
name: Warnings
description: Warnings that appear or should be added to pandas
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
ENH: Adds errors parameter to array strftime to enhance exception handling. 
State: closed

- [x] closes #58178 
- [x] Tests added and passes in pandas\tests\arrays\test_datetimelike.py
- [x] Pre-commit passes
- [x] Added type annotations for new 'errors' parameter in changed strftime functions. 
- [x] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file in the enhancement section. 


Labels:

Comments:
Thanks for the PR, but the original enhancement request hasn't gotten enough feedback from the core team to move forward yet so closing this PR for now. If the original issue gains more support we can reopen this PR 
Hi, thank you for looking at the PR. Are there any specific concerns with the way we are handling this issue or does the team just need more time to discuss if it is necessary? Thank you for the update. 
The team just needs more time to discuss the original enhancement request. i.e. if an enhancement issue has `Needs Triage` or `Needs Discussion` labels, it is not suitable to open a PR yet
I see. Thanks for the clarification!
DOC: fix PR07 and SA01 issue for Index: copy and get_slice_bound
State: closed

- [ ] xref #58068 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @KeiOshima
DOC: ficing PR01 and SA01 issue for Index: Identical
State: closed

- [ ] xref #58068
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @KeiOshima
preserve index in list accessor
State: closed

- [ ] closes #58425(Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Index
description: Related to the Index class or subclasses
name: Arrow
description: pyarrow functionality

Comments:
Thanks @rohanjain101
`pd.eval`: `Series` names are now preserved even for `"numexpr"` engine.
State: closed

Series names are now preserved even when using
numexpr engine. Making the behavior consistent
with python engine.

- [x] closes #10239 (and its duplicate #58069)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: expressions
description: pd.eval, query

Comments:
Thanks @domsmrz
DOC: Fix Index.inferred type SA01 and Index.slice_locs RT03 errors
State: closed

- [x] xref #58068
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
DOC: ficing RT03 errors for Index: drop_duplicates and memory_usage
State: closed

- [ ] xref #58068 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @KeiOshima
DOC: Fix RT03 and SA01 errors for Index.droplevel, Index.dropna
State: closed

- [x] xref #58068
- [N/A] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [N/A] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [N/A] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
DOC: fixing RT03 erros for Index: duplicated and nunique
State: closed

- [ ] xref #58068 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @KeiOshima
DOC: Fix DataFrame.reorder_levels SA01 error
State: closed

- [x] xref #58065
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
DOC: fixing SA01 error for Index: T and empty
State: closed

- [ ] xref #58068 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @KeiOshima
DOC: Fix RT03 errors for DataFrame.infer_objects, DataFrame.hist, DataFrame.to_parquet
State: closed

- [x] xref #58065
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @shriyakalakata
DOC: Fix "versionadded" for case_when
State: closed

Tag was on parameter instead of function itself.

- [ ] ~~closes #xxxx (Replace xxxx with the GitHub issue number)~~
- [ ] ~~[Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature~~
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] ~~Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.~~
- [ ] ~~Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.~~


Labels:
name: Docs

Comments:
Why did it skip the doc upload? I was hoping to look at the result on the web. (job [Doc Build and Upload](https://github.com/pandas-dev/pandas/actions/runs/8837092412/job/24265158961?pr=58426#logs)).

At least I was able to download it and look at it.
Thanks @wjandrea
[Typing] Enhance the WriteExcelBuffer protocol to be compatible with io.BinaryIO
State: closed

- [X] closes #58424
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.



Labels:

Comments:
> Would you mind also doing a similar PR in `pandas-stubs` ?

Sure, here it is https://github.com/pandas-dev/pandas-stubs/pull/912