BrandonFors/pandas-github-issues huggingface dataset:
Correct assert_frame_equal doc string
State: closed

Correct default values in assert_frame_equal doc string


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Docs

Comments:
@WillAyd 
```################################################################################
################################## Validation ##################################
################################################################################

Warnings found:
        No extended summary found
        See Also section not found
        No examples section found
Docstring for "pandas.util.testing.assert_frame_equal" correct. :)
```
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22552?src=pr&el=h1) Report
> Merging [#22552](https://codecov.io/gh/pandas-dev/pandas/pull/22552?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/98fb53ca2d64658749e9f182b391002ef3500c1b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22552/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22552?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22552   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50787    50787           
=======================================
  Hits        46745    46745           
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <ø> (ø)` | :arrow_up: |
| #single | `42.29% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22552?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/22552/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `85.75% <ø> (ø)` | :arrow_up: |
| [pandas/core/strings.py](https://codecov.io/gh/pandas-dev/pandas/pull/22552/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc3RyaW5ncy5weQ==) | `98.63% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22552?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22552?src=pr&el=footer). Last update [98fb53c...6a861d7](https://codecov.io/gh/pandas-dev/pandas/pull/22552?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Hello @pablojim! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on September 03, 2018 at 11:52 Hours UTC
Typo: UCT -> UTC
State: closed

- [(no issue)] closes #xxxx
- [(didn't change code)] tests added / passed
- [(didn't change .py files)] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [(seems unnecessary)] whatsnew entry


Labels:
name: Docs
name: Timezones
description: Timezone data dtype

Comments:
LGTM, ping on green.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22548?src=pr&el=h1) Report
> Merging [#22548](https://codecov.io/gh/pandas-dev/pandas/pull/22548?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1a798be98b7a605693c6d1143ab1d703a77f47a1?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22548/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22548?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22548   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50783    50783           
=======================================
  Hits        46741    46741           
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <ø> (ø)` | :arrow_up: |
| #single | `42.22% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22548?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22548?src=pr&el=footer). Last update [1a798be...a974cb3](https://codecov.io/gh/pandas-dev/pandas/pull/22548?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

🍏 
thanks!
CLN: use 'codes' rather than 'values' internally in Categorical
State: closed

In some places a variable has the name ``values``, where ``codes`` would be more logical, as we're dealing with codes.

This makes it a bit easier to understand what we're looking at when reading IMO,

Labels:
name: Categorical
description: Categorical Data Type
name: Clean

Comments:
+1 on moving away from ‘values’, too many variants of that exist at the moment
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22547?src=pr&el=h1) Report
> Merging [#22547](https://codecov.io/gh/pandas-dev/pandas/pull/22547?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/1a798be98b7a605693c6d1143ab1d703a77f47a1?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22547/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22547?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #22547      +/-   ##
==========================================
- Coverage   92.04%   92.04%   -0.01%     
==========================================
  Files         169      169              
  Lines       50783    50782       -1     
==========================================
- Hits        46741    46740       -1     
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <100%> (-0.01%)` | :arrow_down: |
| #single | `42.22% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22547?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/arrays/categorical.py](https://codecov.io/gh/pandas-dev/pandas/pull/22547/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2NhdGVnb3JpY2FsLnB5) | `95.74% <100%> (-0.01%)` | :arrow_down: |
| [pandas/core/indexes/category.py](https://codecov.io/gh/pandas-dev/pandas/pull/22547/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9jYXRlZ29yeS5weQ==) | `97.28% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22547?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22547?src=pr&el=footer). Last update [1a798be...77323b8](https://codecov.io/gh/pandas-dev/pandas/pull/22547?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
Added capture_stderr decorator to test_validate_docstrings
State: closed

- [X] closes #22483
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Originally thought it would be nice to have this as a class decorator, but usage of this conflicts with the `capsys` fixture used by `test_bad_examples` so had to pick and choose where to apply. Additionally the decorator doesn't work out of the box to wrap classes, so it would take a decent amount more code.

cc @gfyoung will present minor merge conflicts with your work in #22531

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22543?src=pr&el=h1) Report
> Merging [#22543](https://codecov.io/gh/pandas-dev/pandas/pull/22543?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/100906ef8db3e388f70fb3450ffa39b2939c44e1?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22543/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22543?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22543   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50787    50787           
=======================================
  Hits        46745    46745           
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <100%> (ø)` | :arrow_up: |
| #single | `42.29% <100%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22543?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/22543/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `85.75% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22543?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22543?src=pr&el=footer). Last update [100906e...bf3b929](https://codecov.io/gh/pandas-dev/pandas/pull/22543?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

looks fine. whare are they printing to stderr now?
@jorisvandenbossche can you point me to where you were seeing this in Travis before? Worth double checking there that this has the intended effect
@jorisvandenbossche all green after rebase
Looks clean after rebase.  I think we have enough approvals to merge this. 😄
TST: Move tests/scripts to scripts/tests
State: closed

Moves the `tests/scripts` directory to `scripts/tests`, as these tests don't really belong in the top-level `pandas` directory (they test the `scripts` directory, not `pandas`).

Labels:
name: Refactor
description: Internal refactoring of code
name: Testing
description: pandas testing functions or related to the test suite

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22531?src=pr&el=h1) Report
> Merging [#22531](https://codecov.io/gh/pandas-dev/pandas/pull/22531?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/98fb53ca2d64658749e9f182b391002ef3500c1b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22531/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22531?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22531   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50787    50787           
=======================================
  Hits        46745    46745           
  Misses       4042     4042
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <ø> (ø)` | :arrow_up: |
| #single | `42.29% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22531?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22531?src=pr&el=footer). Last update [98fb53c...868f6bf](https://codecov.io/gh/pandas-dev/pandas/pull/22531?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Relevant build:

https://travis-ci.org/pandas-dev/pandas/jobs/421898109
Think we also need to update the Makefile to ensure this still gets linted (?)
> Think we also need to update the Makefile to ensure this still gets linted (?)

@WillAyd : AFAICT we don't use the `Makefile` when doing the linting on Travis.  That being said, I don't see why we can't add it as another command.
@jreback @datapythonista @WillAyd :

I've addressed all of your comments, and everything is still green!  PTAL.
@jreback : Is this good to merge since you approved it? (you generally have merged after approval)
yep
Updated condition to skip for pytables build issue on numpy 1.15 #22098
State: closed

- [ ] closes #22098
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
I have fetched and merged master. But still shows a build error. Anything wrong with my code.
Looks like numpy 1.15 was installed.

Anaconda doesn't seem to have 1.15.1 built yet https://repo.continuum.io/pkgs/main/linux-64/. Will probably be up this week.
This is for 1.15.0 exactly.

It'd probably be best to define a skipif for NumPy 1.15.0 in
https://github.com/pandas-dev/pandas/blob/master/pandas/util/_test_decorators.py
and just use that in the test.

On Mon, Aug 27, 2018 at 1:47 PM Jeff <notifications@github.com> wrote:

> *@jeffyancey* commented on this pull request.
> ------------------------------
>
> In pandas/compat/numpy/__init__.py
> <https://github.com/pandas-dev/pandas/pull/22522#discussion_r213074847>:
>
> > @@ -15,6 +15,7 @@
>  _np_version_under1p13 = _nlv < LooseVersion('1.13')
>  _np_version_under1p14 = _nlv < LooseVersion('1.14')
>  _np_version_under1p15 = _nlv < LooseVersion('1.15')
> +_np_version_equal1p15 = _nlv == LooseVersion('1.15')
>
> Is the pattern to change this to
>
> _np_version_under1p16 = _nlv < LooseVersion('1.16')
> _np_version_equal1p16 = _nlv == LooseVersion('1.16')
>
> when numpy 1.16 comes out? Or is this a one off to meet a current need?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/22522#pullrequestreview-149834465>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIu-1HRG3_ocxKBbOoJciz0eyZQAmks5uVD7DgaJpZM4WN2cT>
> .
>

thanks!
BUG: Resample raises AmbiguousTimeError if index starts or ends on DST
State: closed

- [x] closes #10117
- [x] closes #19375
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Timezones
description: Timezone data dtype
name: Resample
description: resample method

Comments:
Actually, I don't think this is the appropriate fix. Closing for now.
DOC: Update series apply docstring. GH22459
State: closed

- [X] refs #22459
- [x] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Updated `Series.apply` docstring to resolve errors raised from scripts/validate_docstrings.py from #22459.

Labels:
name: Docs
name: Algos
description: Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22510?src=pr&el=h1) Report
> Merging [#22510](https://codecov.io/gh/pandas-dev/pandas/pull/22510?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f2839fe813391140a1e08d3c5f71c04bbaf5ab56?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22510/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22510?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22510   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         161      161           
  Lines       51498    51498           
=======================================
  Hits        47530    47530           
  Misses       3968     3968
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.69% <ø> (ø)` | :arrow_up: |
| #single | `42.43% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/series.py](https://codecov.io/gh/pandas-dev/pandas/pull/22510/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc2VyaWVzLnB5) | `93.68% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22510?src=pr&el=footer). Last update [f2839fe...d5c13b2](https://codecov.io/gh/pandas-dev/pandas/pull/22510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@datapythonista I removed the type from the **kwds parameter. I also agree that it should be renamed to **kwargs to be more consistent with the rest of the code base. 
Hello @eldritchideen! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on September 04, 2018 at 10:56 Hours UTC
I have updated the Series.apply docstring based on review feedback. Thanks @datapythonista and @gfyoung 
@eldritchideen do you have time to update this PR based on the comments?
@datapythonista I see the self assignment on this - are you actually working this one? 
I forgot about it, but fixed the pending issues now. Can you take a look and merge if everything is ok (or fix any outstanding issue, as the PR is discontinued)?
thanks @eldritchideen
CI: Bump to NumPy compat to 1.9.3
State: closed

1.9.2 doesn't seem to be available in `/pkgs/main`. We're seeing errors like

```
ImportError: libgfortran.so.1: cannot open shared object file: No such file or directory
```

when importing numpy.

Switching to 1.9.3 (which is available in main) solves that for me locally.

Labels:
name: CI
description: Continuous Integration

Comments:
I'm not sure why appveyor wasn't run, but in theory it's unaffected by this.

Merging to get master passing again.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22499?src=pr&el=h1) Report
> Merging [#22499](https://codecov.io/gh/pandas-dev/pandas/pull/22499?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/447580e492271228c8e777757934ae5fd7af9515?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22499/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/22499?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22499   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50776    50776           
=======================================
  Hits        46737    46737           
  Misses       4039     4039
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <ø> (ø)` | :arrow_up: |
| #single | `42.23% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22499?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22499?src=pr&el=footer). Last update [447580e...5e7da44](https://codecov.io/gh/pandas-dev/pandas/pull/22499?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks!
CLN: Simplify read_csv tz offset parsing
State: closed

I _think_ after  #22457  we do not need the `np.asarray` calls that were introduced in #22380

Labels:
name: IO CSV
description: read_csv, to_csv
name: Clean

Comments:
If tests pass, I'm +1 for this.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22494?src=pr&el=h1) Report
> Merging [#22494](https://codecov.io/gh/pandas-dev/pandas/pull/22494?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/55d176d1cd624f8921379c0ceed06fb8e00625b9?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/22494/graphs/tree.svg?src=pr&width=650&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/22494?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #22494   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         169      169           
  Lines       50776    50776           
=======================================
  Hits        46737    46737           
  Misses       4039     4039
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.45% <100%> (ø)` | :arrow_up: |
| #single | `42.23% <66.66%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/22494?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/parsers.py](https://codecov.io/gh/pandas-dev/pandas/pull/22494/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnNlcnMucHk=) | `95.48% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22494?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/22494?src=pr&el=footer). Last update [55d176d...97e0e6b](https://codecov.io/gh/pandas-dev/pandas/pull/22494?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Looks like tests are passing besides a travis build termination. 
thanks!