BrandonFors/pandas-github-issues huggingface dataset:
implement _tz_convert_dst for de-duplication
State: closed

Analogous to #21727, this handles the `get_dst_info` case whereas that handled the `tzlocal` case.

Fleshes out docstring as discussed in #21727 

All the other uses of `get_dst_info` are handled _slightly_ differently.  Need to figure out whether those are intentional to see if more de-duplication (or perf) is available.

Labels:
name: Timezones
description: Timezone data dtype
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21730?src=pr&el=h1) Report
> Merging [#21730](https://codecov.io/gh/pandas-dev/pandas/pull/21730?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/10709762e95be2b98d68b95db93a287ee5af74d4?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21730/graphs/tree.svg?src=pr&token=eZ4WkYLtcO&width=650&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21730?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21730   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         158      158           
  Lines       49705    49705           
=======================================
  Hits        45693    45693           
  Misses       4012     4012
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.99% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21730?src=pr&el=footer). Last update [1070976...522ec03](https://codecov.io/gh/pandas-dev/pandas/pull/21730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Implement _tz_convert_tzlocal_utc for de-duplication
State: closed

There is a bunch of code in conversion (and a bit in resolution, period, and tslib) that can be de-duplicated.  This is one part of ~5 steps in that process.

Labels:
name: Timezones
description: Timezone data dtype
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21727?src=pr&el=h1) Report
> Merging [#21727](https://codecov.io/gh/pandas-dev/pandas/pull/21727?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/62a0ebc5837a4a1f7cc925e13344be1adf1acc59?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21727/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21727?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21727   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         158      158           
  Lines       49705    49705           
=======================================
  Hits        45693    45693           
  Misses       4012     4012
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.99% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21727?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21727?src=pr&el=footer). Last update [62a0ebc...6878a69](https://codecov.io/gh/pandas-dev/pandas/pull/21727?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Yes, the private function is just for this module.
CLN: Delay converting bins to datetimelike until necessary
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

xref #20956, `q/cut` now returns datetimelike bins when `retbins=True`. Instead of always trying to convert bins to datetimelike (even when `retbins=False`), moving the conversion to `_postprocess_for_cut` until after `retbins=True` is checked

cc @jreback 

Labels:
name: Datetime
description: Datetime data dtype
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21724?src=pr&el=h1) Report
> Merging [#21724](https://codecov.io/gh/pandas-dev/pandas/pull/21724?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/2b136054db3b8f4c8d1aa33160c4bbe3b8ce940e?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21724/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21724?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21724   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         158      158           
  Lines       49702    49702           
=======================================
  Hits        45690    45690           
  Misses       4012     4012
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <100%> (ø)` | :arrow_up: |
| #single | `42% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21724?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/reshape/tile.py](https://codecov.io/gh/pandas-dev/pandas/pull/21724/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvcmVzaGFwZS90aWxlLnB5) | `94.73% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21724?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21724?src=pr&el=footer). Last update [2b13605...c9ea5b5](https://codecov.io/gh/pandas-dev/pandas/pull/21724?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
implement _local_timestamps in DatetimeArrayMixin
State: closed

Broken out of #21715 because it is a blocker for a handful of orthogonal follow-ons.

Labels:
name: Datetime
description: Datetime data dtype
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21721?src=pr&el=h1) Report
> Merging [#21721](https://codecov.io/gh/pandas-dev/pandas/pull/21721?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9b247706a907acea3af271d82fd75e98bcbc924f?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21721/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21721?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21721      +/-   ##
==========================================
+ Coverage   91.93%   91.93%   +<.01%     
==========================================
  Files         159      159              
  Lines       49719    49722       +3     
==========================================
+ Hits        45707    45710       +3     
  Misses       4012     4012
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <100%> (ø)` | :arrow_up: |
| #single | `42.02% <27.27%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21721?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/arrays/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/21721/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvYXJyYXlzL2RhdGV0aW1lcy5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/21721/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.45% <100%> (-0.03%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21721?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21721?src=pr&el=footer). Last update [9b24770...70e4047](https://codecov.io/gh/pandas-dev/pandas/pull/21721?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
docstring and whitespace cleanup
State: closed


Labels:
name: Docs
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21719?src=pr&el=h1) Report
> Merging [#21719](https://codecov.io/gh/pandas-dev/pandas/pull/21719?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/79bc3357fc30faf1f98b8815fcb02ea9bec154fb?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21719/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21719?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21719   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         158      158           
  Lines       49698    49698           
=======================================
  Hits        45684    45684           
  Misses       4014     4014
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (ø)` | :arrow_up: |
| #single | `42% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21719?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21719?src=pr&el=footer). Last update [79bc335...1fe67a2](https://codecov.io/gh/pandas-dev/pandas/pull/21719?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @jbrockmendel
TST: Parametrize tests in tools/test_numeric.py
State: closed

Title is self-explanatory.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21717?src=pr&el=h1) Report
> Merging [#21717](https://codecov.io/gh/pandas-dev/pandas/pull/21717?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/8f322149ebd2a30f2f2d48c06863cd783166fa84?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21717/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21717?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21717   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         158      158           
  Lines       49703    49703           
=======================================
  Hits        45689    45689           
  Misses       4014     4014
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.99% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21717?src=pr&el=footer). Last update [8f32214...3042714](https://codecov.io/gh/pandas-dev/pandas/pull/21717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jreback @jschendel : Comments addressed, and all is still green.  PTAL.
thanks @gfyoung very nice!
De-privatize tslibs functions
State: closed

Related: an item on the tslibs TODO list, #21698.

Labels:
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21714?src=pr&el=h1) Report
> Merging [#21714](https://codecov.io/gh/pandas-dev/pandas/pull/21714?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7cd2679982138e1e7f9f1a759827647e6e521d43?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `69.23%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21714/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21714?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21714      +/-   ##
==========================================
- Coverage    91.9%    91.9%   -0.01%     
==========================================
  Files         158      158              
  Lines       49690    49688       -2     
==========================================
- Hits        45670    45668       -2     
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.28% <69.23%> (-0.01%)` | :arrow_down: |
| #single | `41.95% <0%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21714?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/accessors.py](https://codecov.io/gh/pandas-dev/pandas/pull/21714/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9hY2Nlc3NvcnMucHk=) | `90.09% <ø> (-0.1%)` | :arrow_down: |
| [pandas/core/indexes/datetimelike.py](https://codecov.io/gh/pandas-dev/pandas/pull/21714/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZWxpa2UucHk=) | `96.72% <100%> (ø)` | :arrow_up: |
| [pandas/core/indexes/period.py](https://codecov.io/gh/pandas-dev/pandas/pull/21714/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9wZXJpb2QucHk=) | `92.57% <62.5%> (-0.02%)` | :arrow_down: |
| [pandas/tseries/frequencies.py](https://codecov.io/gh/pandas-dev/pandas/pull/21714/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvZnJlcXVlbmNpZXMucHk=) | `95.9% <75%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21714?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21714?src=pr&el=footer). Last update [7cd2679...fd393df](https://codecov.io/gh/pandas-dev/pandas/pull/21714?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @jbrockmendel
ENH: Add set_closed method to IntervalIndex
State: closed

- [X] closes #21670
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry


Labels:
name: Enhancement
name: API Design
name: Interval
description: Interval data type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21711?src=pr&el=h1) Report
> Merging [#21711](https://codecov.io/gh/pandas-dev/pandas/pull/21711?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/7cd2679982138e1e7f9f1a759827647e6e521d43?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21711/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21711?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21711      +/-   ##
==========================================
+ Coverage    91.9%   91.91%   +<.01%     
==========================================
  Files         158      158              
  Lines       49690    49695       +5     
==========================================
+ Hits        45670    45675       +5     
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.28% <100%> (ø)` | :arrow_up: |
| #single | `41.95% <20%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/interval.py](https://codecov.io/gh/pandas-dev/pandas/pull/21711/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9pbnRlcnZhbC5weQ==) | `93.18% <100%> (+0.05%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21711?src=pr&el=footer). Last update [7cd2679...9428144](https://codecov.io/gh/pandas-dev/pandas/pull/21711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lgtm. @jorisvandenbossche @TomAugspurger 
FYI - I'll refrain from doing any additional `IntervalIndex` updates after this, so as not to cause conflicts with any `IntervalArray` work (I'm assuming that @TomAugspurger or I will be working on that at some point during the sprint).
Sounds good.

Would be nice to knock out IntervalArray during the sprint.
remove unused cimport, parametrize test
State: closed


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21710?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@be14333`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21710/graphs/tree.svg?width=650&height=150&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21710?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##             master   #21710   +/-   ##
=========================================
  Coverage          ?    91.9%           
=========================================
  Files             ?      158           
  Lines             ?    49690           
  Branches          ?        0           
=========================================
  Hits              ?    45670           
  Misses            ?     4020           
  Partials          ?        0
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.28% <ø> (?)` | |
| #single | `41.95% <ø> (?)` | |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21710?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21710?src=pr&el=footer). Last update [be14333...17ca09c](https://codecov.io/gh/pandas-dev/pandas/pull/21710?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @jbrockmendel
DOC: move whatsnew on performance from 0.23.2 to 0.24.0
State: closed

I did not backport the performance improvements in my backporting PRs for now, so this moves that section to 0.24.0.txt. 
(my rationale: let's be conservative for bug fix releases, performance improvements (if they are not fixing severe performance regressions) are not strictly needed in a bug fix release).



Labels:
name: Docs

Comments:
Agreed with being conservative in bugfix releases.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21709?src=pr&el=h1) Report
> Merging [#21709](https://codecov.io/gh/pandas-dev/pandas/pull/21709?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ad76ffcca0d92c3885c279c80701c2f4a3f3f177?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21709/graphs/tree.svg?height=150&width=650&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21709?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21709   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         154      154           
  Lines       49659    49659           
=======================================
  Hits        45640    45640           
  Misses       4019     4019
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.28% <ø> (ø)` | :arrow_up: |
| #single | `41.89% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21709?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21709?src=pr&el=footer). Last update [ad76ffc...0adcf07](https://codecov.io/gh/pandas-dev/pandas/pull/21709?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

did you move the fixes? or rather not backport them?
Yes, I simply did not backport them
BUG : Adding *kwargs for name retention in Index args
State: closed

- [x] closes #21697
- [ ] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Bug

Comments:
Hello @uds5501! Thanks for updating the PR.

 - In the file [`pandas/core/tools/datetimes.py`](https://github.com/pandas-dev/pandas/blob/ec356fa62241750a227c1bafb4c0c396bde1c293/pandas/core/tools/datetimes.py), following are the PEP8 issues :

> [Line 596:21](https://github.com/pandas-dev/pandas/blob/ec356fa62241750a227c1bafb4c0c396bde1c293/pandas/core/tools/datetimes.py#L596): [E722](https://duckduckgo.com/?q=pep8%20E722) do not use bare except'



##### Comment last updated on July 09, 2018 at 12:12 Hours UTC
@mroeschke  Sure sir, would do
@mroeschke I had a quick question. I made a commit regarding the whatsnew note in another path. If I want to add the commit in this PR itself.. how do I do that?
@uds5501 I am not sure if I completely follow but you could potentially merge the other branch into this branch locally or just re-do the whatsnew entry. The latter is probably easiest since we are just talking about a one-liner
closing as dupe of #21848 which is farther along