BrandonFors/pandas-github-issues huggingface dataset:
MultiIndex Doc
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs
name: MultiIndex

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=h1) Report
> Merging [#18169](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/535033033002592b8fce94f9365b6671baaf59ec?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18169/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18169      +/-   ##
==========================================
+ Coverage    91.4%    91.4%   +<.01%     
==========================================
  Files         163      163              
  Lines       50068    50068              
==========================================
+ Hits        45764    45767       +3     
+ Misses       4304     4301       -3
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.21% <ø> (+0.02%)` | :arrow_up: |
| #single | `40.33% <ø> (-0.06%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.8% <0%> (-0.1%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.2% <0%> (+1.81%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=footer). Last update [5350330...162dcbd](https://codecov.io/gh/pandas-dev/pandas/pull/18169?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks!
CI: don't show miniconda output on install / numpy 1.14 compat
State: closed

closes #18123

Labels:
name: CI
description: Continuous Integration

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=h1) Report
> Merging [#18157](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c8aad92c44098caf7d5875bd0803a2abffb3b34a?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `66.66%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18157/graphs/tree.svg?token=eZ4WkYLtcO&height=150&width=650&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18157      +/-   ##
==========================================
- Coverage    91.4%   91.38%   -0.02%     
==========================================
  Files         163      163              
  Lines       50068    50068              
==========================================
- Hits        45764    45755       -9     
- Misses       4304     4313       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.19% <66.66%> (ø)` | :arrow_up: |
| #single | `40.33% <66.66%> (-0.06%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/compat/\_\_init\_\_.py](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=tree#diff-cGFuZGFzL2NvbXBhdC9fX2luaXRfXy5weQ==) | `58.1% <66.66%> (ø)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.8% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=footer). Last update [c8aad92...0055c61](https://codecov.io/gh/pandas-dev/pandas/pull/18157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lint import order
State: closed

Expecting lots and lots of flake8 complaints...

Labels:
name: Code Style
description: Code style, linting, code_checks

Comments:
@jbrockmendel : Nice addition!  Get the linter to pass first.  Then document that we use this tool.
FYI: http://isort.readthedocs.io/en/latest/ will rewrite the imports automatically (for the PR getting everything in order. Not for running regularly).
flake8+multiprocessing is throwing an error here.  Unfortunately it gives a line number but not a filename.

```
Linting  *.py
Traceback (most recent call last):
  File "/home/travis/miniconda3/envs/pandas/bin/flake8", line 11, in <module>
    load_entry_point('flake8==3.4.1', 'console_scripts', 'flake8')()
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/site-packages/flake8/main/cli.py", line 16, in main
    app.run(argv)
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/site-packages/flake8/main/application.py", line 348, in run
    self._run(argv)
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/site-packages/flake8/main/application.py", line 336, in _run
    self.run_checks()
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/site-packages/flake8/main/application.py", line 266, in run_checks
    self.file_checker_manager.run()
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/site-packages/flake8/checker.py", line 317, in run
    self.run_parallel()
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/site-packages/flake8/checker.py", line 286, in run_parallel
    for ret in pool_map:
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/multiprocessing/pool.py", line 289, in <genexpr>
    return (item for chunk in result for item in chunk)
  File "/home/travis/miniconda3/envs/pandas/lib/python2.7/multiprocessing/pool.py", line 673, in next
    raise value
ValueError: Expected token OP:'[', got OP:'(' on line 477 col 33
```
@TomAugspurger +1.  Doing this manually would be a PITA.
don’t use multiprocessing 
> don’t use multiprocessing

Well, yah.  It's apparently being called under the hood by flake8.  I'll get around to looking at it eventually, someone else is welcome to beat me to it.
Tslibs testing6
State: closed

Kind of all over the place.  There's a lot to be done in terms of making tests.scalars isolate scalar tests, etc.

The added tests in two test_arithmetic files fill out the test matrix started in 17991

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
> Kind of all over the place.

I haven't be able to look over your changes completely, but given that you say this, is it possible to break up the changes so that they're not so "all over the place" ?
Yah, I think its time for a good night's sleep.  I'll start with a coherent chunk of this in the morning.
TST: Add another test for segfault in C engine
State: closed

Not sure why the original PR was closed, but let's bring it to completion.

xref #13833.
Closes #5291.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO CSV
description: read_csv, to_csv

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=h1) Report
> Merging [#18128](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/f7f214ba5241d84c107d318df4f85129b9ffc938?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18128/graphs/tree.svg?token=eZ4WkYLtcO&height=150&width=650&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18128      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files         163      163              
  Lines       50122    50122              
==========================================
+ Hits        45740    45743       +3     
+ Misses       4382     4379       -3
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.07% <ø> (+0.02%)` | :arrow_up: |
| #single | `40.32% <ø> (-0.06%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.75% <0%> (-0.1%)` | :arrow_down: |
| [pandas/plotting/\_converter.py](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=tree#diff-cGFuZGFzL3Bsb3R0aW5nL19jb252ZXJ0ZXIucHk=) | `65.2% <0%> (+1.81%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=footer). Last update [f7f214b...2bd1311](https://codecov.io/gh/pandas-dev/pandas/pull/18128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

ok this is fine merge away
BUG: Don't parse NA-values in index when requested
State: closed

The `na_filter` parameter wasn't being respected when being applied on values in the index.

Closes #5239.

Labels:
name: Bug
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: IO CSV
description: read_csv, to_csv

Comments:
> sure.....though to be honest, easiest just to drop na_filter...but if you come up with a better API, gr8

@jreback : I agree with this suggestion.  I could also deprecate the parameter in this PR as well?
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=h1) Report
> Merging [#18127](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/6f0ff1a6f5fdc2cc135ffffc6e54b471977d2659?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18127/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18127      +/-   ##
==========================================
- Coverage   91.28%   91.26%   -0.02%     
==========================================
  Files         163      163              
  Lines       50127    50130       +3     
==========================================
- Hits        45757    45752       -5     
- Misses       4370     4378       +8
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.07% <100%> (ø)` | :arrow_up: |
| #single | `40.32% <66.66%> (-0.06%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/parsers.py](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=tree#diff-cGFuZGFzL2lvL3BhcnNlcnMucHk=) | `95.59% <100%> (+0.07%)` | :arrow_up: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.75% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=footer). Last update [6f0ff1a...fdb6ef3](https://codecov.io/gh/pandas-dev/pandas/pull/18127?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

minor comment. merge when pushed and on green.
All is green, so merging.
demonstrate similarity for discussion purposes
State: closed

This is a demonstration rather than an actual PR.

There is some very similar logic in `internals.make_block` and `internals.form_blocks`.  For demonstration this PR separates the relevant bits out into `_get_block_klass` and `get_block_type`, respectively.

Suppose that the small differences in these two new functions were reconciled.  Then adding a custom block type would be a matter of adding it to `_block_type_klasses` along with registering some kind of hook in `_get_block_klass`.

There would need to be some cleanup at the end of `form_blocks` to map block types to `_foo_blockify` functions.

ref #17144
noci


Labels:

Comments:
Hello @jbrockmendel! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on November 05, 2017 at 18:17 Hours UTC
BUG: Override mi-columns in to_csv if requested
State: closed

Previously, `MultiIndex` columns weren't being overwritten when `header` was passed in for `to_csv`.

Closes #5539 (almost four years to the day, wow...)


Labels:
name: Bug
name: Output-Formatting
description: __repr__ of pandas objects, to_string
name: MultiIndex

Comments:
lgtm!
@jschendel : Thanks for the comments.  I'm going to hold off from making the changes here because I see that your comments are applicable to several other points in those two files.  Will make another PR to clean those up once this one is merged.
@gfyoung : Sounds good, was actually thinking of doing something similar myself.  I'm usually hesitant to bring up points like that when I see them unless there's already edits that need to be made, since they're not super critical and don't want people to feel like I'm nagging them!
@gfyoung tiny comment. after that, merge when ready.
All green, so merging.
BLD: Make sure to copy ZIP files for parser tests
State: closed

The ZIP file wasn't listed in `setup.py` from #18091.

Will merge on green.

Labels:
name: Build
description: Library building on various platforms

Comments:
good point. thanks @gfyoung 
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18108?src=pr&el=h1) Report
> Merging [#18108](https://codecov.io/gh/pandas-dev/pandas/pull/18108?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/3268f4e976a42065db3dcbc869f0c73adc0c7522?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18108/graphs/tree.svg?src=pr&width=650&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/18108?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18108      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50123    50123              
==========================================
- Hits        45741    45732       -9     
- Misses       4382     4391       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.05% <ø> (ø)` | :arrow_up: |
| #single | `40.32% <ø> (-0.06%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18108?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18108?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18108?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.75% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18108?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18108?src=pr&el=footer). Last update [3268f4e...a14fc58](https://codecov.io/gh/pandas-dev/pandas/pull/18108?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

did you port to the 0.21.x branch? don't do that. we will move everything all at once in the order it was done. otherwise you can get conflicts.
Oops, my bad.  I thought that was what the backport label meant for us to do.  Feel free to remove or revert (which ever is easiest).
no, it means we *should* do it, but don't do it now.
Yeah, that's what I meant.  Should I just remove those two commits from the branch then?
no its fine
BLD: Clean up dependencies for Cython files
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Build
description: Library building on various platforms
name: Clean

Comments:
an does this solve the problem?
this is including way too many things; all of the pyx are not needed just the pxd
FFS I asked exactly that pyx vs pxd question over in #18089 and you guys ignored it.  "Fix" this yourselves.

As far as I'm concerned this makes things distinctly worse.
IMO, let's focus on getting a working build first.  We can "clean up" later in subsequent commits to this PR.  Mixing the two together is making it hard for us to make progress here.
Actually, due to merge conflicts, this will be annoying to merge in as written.  Let's start from scratch.
Conda appveyor master
State: closed

xref https://github.com/conda/conda/issues/6251

Closes https://github.com/pandas-dev/pandas/issues/18073



Labels:
name: Build
description: Library building on various platforms

Comments:
That apparently wasn't it. (We'll still want to update to the newer miniconda though).
> That apparently wasn't it. (We'll still want to update to the newer miniconda though).

we already use the latest windows installeer, e.g. see ``ci/install.ps1``
superseded by #18105
follow-up to #18014
State: closed

- de-privatize names
- move check_all_nulls to nattype
- export NPY_NAT and iNaT from nattype
- update imports


Labels:
name: Datetime
description: Datetime data dtype

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18081?src=pr&el=h1) Report
> Merging [#18081](https://codecov.io/gh/pandas-dev/pandas/pull/18081?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/27bbea7ee125f4dc19dca2a7703c9a13ca754f9b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/18081/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/18081?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #18081      +/-   ##
==========================================
- Coverage   91.25%   91.23%   -0.02%     
==========================================
  Files         163      163              
  Lines       50120    50120              
==========================================
- Hits        45737    45728       -9     
- Misses       4383     4392       +9
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `89.04% <ø> (ø)` | :arrow_up: |
| #single | `40.32% <ø> (-0.06%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/18081?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/18081?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/18081?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.75% <0%> (-0.1%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18081?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/18081?src=pr&el=footer). Last update [27bbea7...e2d4f18](https://codecov.io/gh/pandas-dev/pandas/pull/18081?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).