BrandonFors/pandas-github-issues huggingface dataset:
TST: Add test for boxable categories GH#21658
State: closed

- [ ] closes #21658 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks again @liang3zy22
DEPR `fill_method` and `limit` keywords in `pct_change`
State: closed

- [ ] Closes #53491
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests)
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit)
- [x] Added an entry in the latest `doc/source/whatsnew/v2.1.0.rst` file


Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Deprecate
description: Functionality to remove in pandas
name: Transformations
description: e.g. cumsum, diff, rank

Comments:
Can these be done in a single PR or in separate PRs?
I don't think these can be done in a single major version. In 2.x we deprecate the default; in 3.x we can then change the default to None. Finally in 3.x we can also deprecate the arguments and in 4.x we can remove them.
@rhshadrach I have updated the PR to deprecate only the default value of `fill_method`. Not sure if I'm doing correctly, so please let me know if I should make changes.

It also seems that deprecating this behavior is raising warnings in so many tests. I've already fixed some of those, do I need to fix the rest as well (like what I'm currently doing), or is there a better resolution?
I disagree with @rhshadrach that this needs to be a two-major-version process.  This is just not that big of a deal.
@jbrockmendel - what's your recommended way forward here?
1) warn if method is explicitly passed
2) otherwise warn if there are NAs present
Ah - thanks; that sounds great to me.
Okay, so in other words, revert to my original version, and in addition warn when has NA but method is not explicit passed.

I will make the changes soon. Thanks for your discussion.
Could you merge main once more?
Thanks @Charlie-XIAO 
@rhshadrach @jbrockmendel Hi, we need `fill_method='None'` to force `pct_change` not to handle NAs, but this PR cause a lot of deprecated warning and we can't fix it. Before you provide an alternative to do that, deprecating`fill_method` is unwise.
Does obj.fillna(...).pct_change not work, as is also mentioned in the deprecation message? @holymonson 
> Does obj.fillna(...).pct_change not work, as is also mentioned in the deprecation message? @holymonson

We don't want `fillna()` at all, on the contrary we want keeping NAs, while your deprecation message doesn't tell howto **NOT** fillna.
@holymonson - I've responded in #53491
BUG: groupby.nth after selection
State: closed

- [x] closes #53518 (Replace xxxx with the GitHub issue number)
- [x] closes #11038 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Groupby
name: Filters
description: e.g. head, tail, nth

Comments:
Thanks @rhshadrach
FIX `groupby` with column selection not returning tuple when grouping by list of a single element
State: closed

- [x] Closes #53500
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests)
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit)
- [x] Added an entry in the latest `doc/source/whatsnew/v2.1.0.rst` file

Labels:
name: Bug
name: Groupby

Comments:
@Charlie-XIAO now that #53519 has been merged, the issues with `nth` should be fixed. Can you merge main.
> @Charlie-XIAO now that #53519 has been merged, the issues with `nth` should be fixed. Can you merge main.

Sure, will do.
Thanks @Charlie-XIAO!
BUG/PERF: DataFrame.isin lossy data conversion
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.1.0.rst` file if fixing a bug or adding a new feature.


fixes edge case bug (lossy data conversion):
```
import pandas as pd

val = 1666880195890293744

df = pd.DataFrame({"a": [val], "b": [1.0]})

df.apply(lambda x: x.isin([val]))  # True, False
df.isin([val])                     # False, False 
```


perf (for EA dtypes):
```
import pandas as pd
import numpy as np

data = np.random.randint(0, 1000, (100_000, 2))
df = pd.DataFrame(data, dtype="int64[pyarrow]")

%timeit df.isin([1, 50])

# 25.6 ms ± 1.49 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)  <- main
# 2.1 ms ± 265 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)   <- PR
```

Labels:
name: Bug
name: Performance
description: Memory or execution speed performance

Comments:
Thanks @lukemanley
BUG: merge_asof raising ValueError for read-only ndarrays
State: closed

- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.1.0.rst` file if fixing a bug or adding a new feature.


```
import pandas as pd

left = pd.Series([2], index=[2], name="left")
right = pd.Series([1], index=[1], name="right")

# setting read-only here results in the error below
left.index.values.flags.writeable = False

# ValueError: buffer source array is read-only
pd.merge_asof(left, right, left_index=True, right_index=True)
```

Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
Does setting the memory views to const not have the same effect? For a while I thought we were trying to use memoryviews over numpy arrays in the Cython layer so would be better to stick to that design if it works. If not though still lgtm
Worth adding a test for this 
> Does setting the memory views to const not have the same effect? For a while I thought we were trying to use memoryviews over numpy arrays in the Cython layer so would be better to stick to that design if it works. If not though still lgtm

I just tried setting const on the memory views and I got a compile error. Looking through the rest of that file it looks like most funcs use numpy arrays for numeric. There is a 3rd as_of join in that file (asof_join_nearest_on_X_by_Y) that already uses numpy arrays.
> Worth adding a test for this

I did include a test in this PR. Is there an additional test you'd like to see?
Ah sorry - missed the test looking from phone. And makes sense - the theory was to always use memoryviews but I don't think we ever got the practice to follow
No worries, thanks for reviewing
Thanks @lukemanley
DEPR: Period[B]
State: closed

- [x] closes #53446 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

There's a place in the plotting code where we apparently cast to Period, not sure why that would be necessary.  Need to find an alternative before the deprecation is enforced.

Labels:
name: Frequency
description: DateOffsets
name: Period
description: Period data type
name: Deprecate
description: Functionality to remove in pandas

Comments:
+1 on deprecating. What about the other Business offsets?
> What about the other Business offsets?

The other business offsets aren't used for Period.  (Confusion about that is common, which is part of why i want to decouple offsets from Period entirely)
Thanks @jbrockmendel
DOC: Added Nav Links to Discussion and Development section on README
State: closed

- [x] closes #53507  (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I have added a direct link to the contributor community webpage in the Discussion and Development Section on the project README and I also listed the community meetings (with links). I tested the nav links on my branch and it all works. 

I wanted to provide a suggestion to the issue I opened referenced above if this is helpful in aiding future contributors and their understanding of the communication channels. 


Labels:
name: Docs

Comments:
Thanks @ssharp0
CI: Bump builds to 3.11, update numpy nightly wheels location
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration

Comments:
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
git checkout 2.0.x
git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
git cherry-pick -x -m1 21a81e90f6b551f5d9d4b976169f1fb5a453a854
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
git commit -am 'Backport PR #53508: CI: Bump builds to 3.11, update numpy nightly wheels location'
```

4. Push to a named branch:

```
git push YOURFORK 2.0.x:auto-backport-of-pr-53508-on-2.0.x
```

5. Create a PR against branch 2.0.x, I would have named this PR:

> "Backport PR #53508 on branch 2.0.x (CI: Bump builds to 3.11, update numpy nightly wheels location)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the `Still Needs Manual Backport` label once the PR gets merged.

If these instructions are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
DOC: Add Visible Table of Contents to Project README Documentation
State: closed

- [x] closes #53503 

I have added a table of contents to the projects main README markdown file on my feature branch. I applied the same header styling to match the rest of the README. I tested the links on my branch and it all works. 

I typically look for a table of contents on READMEs and I find it to be a valuable resource so I wanted to provide a suggestion to the issue I opened referenced above.

Labels:
name: Docs

Comments:
Great thanks @ssharp0
DOC: Fixing EX01 - Added examples
State: closed

- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Towards https://github.com/pandas-dev/pandas/issues/37875



Labels:
name: Docs

Comments:
It seems that I'm bugging 2 reviewers! But I'm requesting Marco's review because we talked about it... The request for Matthew's review happens automatically now.
> The request for Matthew's review happens automatically now.

it's because of the codeowners file that's recently been added, so he gets notified for any PR touching `ci`
Thanks @MarcoGorelli
DEPR: fillna method kwd
State: closed

- [x] closes #53394 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Transformations
description: e.g. cumsum, diff, rank

Comments:
Thanks @jbrockmendel
BUG: RangeIndex.union(sort=True) with another RangeIndex
State: closed

- [x] closes #53490 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Index
description: Related to the Index class or subclasses
name: setops
description: union, intersection, difference, symmetric_difference

Comments:
Going to merge, but happy to address follow ups.
DEPR: use_inf_as_na
State: closed

- [x] closes #51684 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
```
2023-06-01T20:16:55.9250397Z docstring of pandas.reset_option:305: WARNING: Explicit markup ends without a blank line; unexpected unindent.
2023-06-01T20:16:55.9251576Z docstring of pandas.set_option:310: WARNING: Explicit markup ends without a blank line; unexpected unindent.
2023-06-01T20:16:55.9254260Z docstring of pandas.describe_option:310: WARNING: Explicit markup ends without a blank line; unexpected unindent.
2023-06-01T20:16:55.9255238Z docstring of pandas.get_option:307: WARNING: Explicit markup ends without a blank line; unexpected unindent.
```
It isn't clear to me what those docbuild complaints are pointing to.
Thanks @jbrockmendel
DEPR: pd.value_counts
State: closed

- [ ] closes #47862 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks @jbrockmendel
DEPR: method, limit in NDFrame.replace
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

xref #33302

Labels:
name: Deprecate
description: Functionality to remove in pandas
name: replace
description: replace method

Comments:
rebased + green
Thanks @jbrockmendel
BLD: Fix compiling pandas with a venv located in the src dir
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

cc @jbrockmendel can you give this a shot?

Labels:
name: Build
description: Library building on various platforms

Comments:
Chatted offline with Brock about this and it seems to fix the issues he's been having (at least with compiling pandas in a venv).

Planning on merging on this on green.
DEPR: combine
State: closed

- [x] closes #53463 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Needs a "do X instead"

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
Would be +1 with a reasonable do X instead alternative
Finding a "do X instead" is really weird bc 'update' is so weird.  For Series you could _almost_ say "operate pointwise instead" i guess
Not much interest, no clear "do X instead". Closing.
ENH: Groupby agg support multiple funcs numba
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Only thing missing for now is Groupby.agg with multiple UDFs. This'll require changes to the shared apply code, so I've left that out of this PR.
(I've added a commented out example test case to address this).

Labels:
name: Enhancement
name: Groupby
name: numba
description: numba-accelerated operations

Comments:
Looks pretty good. Just a merge conflict
Thanks @lithomas1
Update timedeltas.py
State: closed

completed function

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks but this is correct as is. We recommend looking for issues labeled `good first issue` if interested in contributing
TYP: algos.isin
State: closed

- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.



Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Thanks @lukemanley