CI: Set pytest minversion to 4.0.2
State: closed

- [x] closes #23519
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
would need to make a min on the install scripts as well (when we have a working version)
You're saying pin a minimum version of pytest for CI? What would the
benefit of that be? Do we care about
supporting old versions of pytest?

On Thu, Feb 21, 2019 at 10:16 AM Jeff Reback <notifications@github.com>
wrote:

> would need to make a min on the install scripts as well (when we have a
> working version)
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/25402#issuecomment-466061495>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIlp4nwC1toPTROGAFk04yz0_jBzpks5vPsZSgaJpZM4bHwFU>
> .
>

currently using pytest-3.8.1 on macOS py35_np_120

should we update the ci build or downgrade the pytest minversion?

the minversion should probably be above pytest 3.10 otherwise may encounter the minversion parse error xref #23519 again in the future.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=h1) Report
> Merging [#25402](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9c0f6a8d703b6bee48918f2c5d16418a7ff736e3?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25402/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #25402   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         173      173           
  Lines       52845    52845           
=======================================
  Hits        48479    48479           
  Misses       4366     4366
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=footer). Last update [9c0f6a8...a5229b9](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=h1) Report
> Merging [#25402](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/9c0f6a8d703b6bee48918f2c5d16418a7ff736e3?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25402/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #25402   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         173      173           
  Lines       52845    52845           
=======================================
  Hits        48479    48479           
  Misses       4366     4366
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.73% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=footer). Last update [9c0f6a8...a5229b9](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=h1) Report
> Merging [#25402](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c9863865c217867583e8f6592ba88d9200601992?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25402/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #25402   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         173      173           
  Lines       52923    52923           
=======================================
  Hits        48555    48555           
  Misses       4368     4368
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.31% <0%> (ø)` | :arrow_up: |
| #single | `41.73% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/\_tester.py](https://codecov.io/gh/pandas-dev/pandas/pull/25402/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvX3Rlc3Rlci5weQ==) | `23.8% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=footer). Last update [c986386...3230bed](https://codecov.io/gh/pandas-dev/pandas/pull/25402?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

also pls update the docs (i think we have a reference to pytest and it’s min version iirc);

also would need a PR against both MacPython/pandas-wheels and conda-forge/pandas-feedstock

when this is merged
it appears that pytest-3.8.1 is the latest version for py35 on conda
you can try moving to the pip section
> i think we have a reference to pytest and it’s min version iirc

that's right. contributing.rst and install.rst will need updating.
lgtm. @pandas-dev/pandas-core any objections?
Thanks @simonjayhawkins!