BrandonFors/pandas-github-issues huggingface dataset:
Hack fix for BUG - GH24784
State: closed

- [X] closes #24784 
- [X] tests added / passed - 1
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry - Test utility method "_check_plot_works_with_continuous_dates"  and Test case "test_continuous_dates"


Labels:
name: Datetime
description: Datetime data dtype
name: Visualization
description: plotting

Comments:
Hello @itssujeeth! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



* In the file [`pandas/tests/plotting/common.py`](https://github.com/pandas-dev/pandas/blob/ae6bf34cb2e4b4d82990e51840d6b5f5c472e5c4/pandas/tests/plotting/common.py):

> [Line 559:1](https://github.com/pandas-dev/pandas/blob/ae6bf34cb2e4b4d82990e51840d6b5f5c472e5c4/pandas/tests/plotting/common.py#L559): [E302](https://duckduckgo.com/?q=pep8%20E302) expected 2 blank lines, found 1

* In the file [`pandas/tests/plotting/test_series.py`](https://github.com/pandas-dev/pandas/blob/ae6bf34cb2e4b4d82990e51840d6b5f5c472e5c4/pandas/tests/plotting/test_series.py):

> [Line 17:89](https://github.com/pandas-dev/pandas/blob/ae6bf34cb2e4b4d82990e51840d6b5f5c472e5c4/pandas/tests/plotting/test_series.py#L17): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (113 > 88 characters)
> [Line 745:89](https://github.com/pandas-dev/pandas/blob/ae6bf34cb2e4b4d82990e51840d6b5f5c472e5c4/pandas/tests/plotting/test_series.py#L745): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (109 > 88 characters)
> [Line 746:89](https://github.com/pandas-dev/pandas/blob/ae6bf34cb2e4b4d82990e51840d6b5f5c472e5c4/pandas/tests/plotting/test_series.py#L746): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (110 > 88 characters)



##### Comment last updated at 2019-08-18 18:52:40 UTC
can you merge master and update to comments
closing this as stale, though its a nice change, needs a rebase and comments addressed.
TST 27905 - testing groupby.transform('sum')
State: closed

- [x] closes #27905
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby

Comments:
closing as a duplicate of #27974
DOC: Fixes to docstrings
State: closed

- [X] xref #27979
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Partially resolves issue 

Labels:
name: Docs

Comments:
Hello @realjohnward! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:









* In the file [`pandas/io/pytables.py`](https://github.com/pandas-dev/pandas/blob/0273150d25146f22bdeec9127141618beae89a6d/pandas/io/pytables.py):

> [Line 1178:89](https://github.com/pandas-dev/pandas/blob/0273150d25146f22bdeec9127141618beae89a6d/pandas/io/pytables.py#L1178): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (99 > 88 characters)





##### Comment last updated at 2019-08-22 17:01:41 UTC
just saw you did reference the issue in the PR, you can check how we usually do (the hash makes github create a link to this PR in the issue)
Thank you @datapythonista for looking over this PR and requesting changes. I am creating another PR with the requested changes made.
When a DataFrame is merged with an empty dataframe, it was creating an incorrect index for the resulting dataframe. Fix for it 
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


In the current fix, if any dataframe is empty, a index is set explicitly using the set_index function

Labels:
name: Needs Info
description: Clarification about behavior needed to assess issue

Comments:
Hello @ananya197! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

* In the file [`pandas/core/frame.py`](https://github.com/pandas-dev/pandas/blob/d1165d0524048d1f580016969325e9026d3a4082/pandas/core/frame.py):

> [Line 7205:21](https://github.com/pandas-dev/pandas/blob/d1165d0524048d1f580016969325e9026d3a4082/pandas/core/frame.py#L7205): [E126](https://duckduckgo.com/?q=pep8%20E126) continuation line over-indented for hanging indent
> [Line 7213:21](https://github.com/pandas-dev/pandas/blob/d1165d0524048d1f580016969325e9026d3a4082/pandas/core/frame.py#L7213): [E123](https://duckduckgo.com/?q=pep8%20E123) closing bracket does not match indentation of opening bracket's line
> [Line 7214:89](https://github.com/pandas-dev/pandas/blob/d1165d0524048d1f580016969325e9026d3a4082/pandas/core/frame.py#L7214): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (92 > 88 characters)


Is this closing an issue? If not, can you show an example?
Hi @ananya197 ! It's not very clear what this is for so closing for now. If you can point to an issue or provide some context on the purpose though we can certainly reopen as required
Raise exception in read_csv when prefix is set, but not used because a header exists
State: closed

Raised an error if argument prefix is set when there are headers present during pandas read_csv.

- [x] closes #27394
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: IO CSV
description: read_csv, to_csv

Comments:
@PraneethKhanna do you have time to add the requested test and the note in the release notes (aka whatsnew)?
Looks like this is stale but @PraneethKhanna if you'd like to pick back up please ping!
New branch
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Hello @RuchitaD1! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:











There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2019-08-18 16:40:57 UTC
@RuchitaD1, it's impossible for us to tell what you're proposing to change here, without a proper title, a description, and a link to the issue you're addressing.

Also, there are plenty of changes (new lines, changes to indentation...) that we don't want, and are breaking the CI). Feel free to open a PR, but please provide all the information I mention, avoid any change that it's not strictly necessary, and make sure you check all the points in the proposed description of the PR. Thanks!
New branch
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Hello @RuchitaD1! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



* In the file [`pandas/core/generic.py`](https://github.com/pandas-dev/pandas/blob/9f00f52adc6b238c31d572b084f4629862ace1df/pandas/core/generic.py):

> [Line 6674:9](https://github.com/pandas-dev/pandas/blob/9f00f52adc6b238c31d572b084f4629862ace1df/pandas/core/generic.py#L6674): [E303](https://duckduckgo.com/?q=pep8%20E303) too many blank lines (2)
> [Line 6676:17](https://github.com/pandas-dev/pandas/blob/9f00f52adc6b238c31d572b084f4629862ace1df/pandas/core/generic.py#L6676): [E117](https://duckduckgo.com/?q=pep8%20E117) over-indented (comment)
> [Line 6677:17](https://github.com/pandas-dev/pandas/blob/9f00f52adc6b238c31d572b084f4629862ace1df/pandas/core/generic.py#L6677): [E117](https://duckduckgo.com/?q=pep8%20E117) over-indented (comment)
> [Line 6679:17](https://github.com/pandas-dev/pandas/blob/9f00f52adc6b238c31d572b084f4629862ace1df/pandas/core/generic.py#L6679): [E117](https://duckduckgo.com/?q=pep8%20E117) over-indented
> [Line 6684:17](https://github.com/pandas-dev/pandas/blob/9f00f52adc6b238c31d572b084f4629862ace1df/pandas/core/generic.py#L6684): [E303](https://duckduckgo.com/?q=pep8%20E303) too many blank lines (2)
> [Line 6687:21](https://github.com/pandas-dev/pandas/blob/9f00f52adc6b238c31d572b084f4629862ace1df/pandas/core/generic.py#L6687): [E303](https://duckduckgo.com/?q=pep8%20E303) too many blank lines (2)
DataFrame html repr: also follow min_rows setting
State: closed

Follow-up on https://github.com/pandas-dev/pandas/pull/27095, where I forgot to apply this setting in the html repr as well.

Thoughts on including this in 0.25.1 or not? It's kind of a oversight of the 0.25 feature, but also an actual change of course in the user experience in the notebook.

Labels:
name: Output-Formatting
description: __repr__ of pandas objects, to_string
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap

Comments:
I'm probably OK with backporting 0.25.1.
OK, added a whatsnew for 0.25.1 then
Thanks!
DOC: remove savefig references from the docs v0.7.3
State: closed

- [x] closes #27971 
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
@datapythonista removed those references. In the future we should make sure every .rst file is independent of each other
DOC: Fix GL01 and GL02 errors in the docstrings
State: closed

- [x] closes #27986
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Fixed docstrings text that aren’t on the next line after opening `"""` and followed immediately by the line with closing `"""`. Issue #27986

Labels:
name: Docs

Comments:
Hello @steveayers124! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2019-08-24 05:57:03 UTC
I appreciate your review, and encouragement, @datapythonista. I'll try going in smaller increments to see maybe what's failing, when I try more pull requests on my remaining changes. Thanks for the feedback!
Agree on both @WillAyd. But I'm also happy to have them in a follow up. GL01 and GL02 are about the position of the quotes, and for formatting errors I'd say it may speed up things if we merge PRs fast and keep opening new tickets fast, than trying to address too many in the PRs.

I'm writing a blog post about what I think it makes sense, so we can discuss and find the way that we all find more efficient. But there is so much to say that it's taking forever. :)
Sure - merge away

Sent from my iPhone

> On Aug 24, 2019, at 9:22 AM, Marc Garcia <notifications@github.com> wrote:
> 
> Agree on both @WillAyd. But I'm also happy to have them in a follow up. GL01 and GL02 are about the position of the quotes, and for formatting errors I'd say it may speed up things if we merge PRs fast and keep opening new tickets fast, than trying to address too many in the PRs.
> 
> I'm writing a blog post about what I think it makes sense, so we can discuss and find the way that we all find more efficient. But there is so much to say that it's taking forever. :)
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.

Thanks @steveayers124, keep the good work.
index fixed when join with empty dataframe
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Hello @ananya197! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:

* In the file [`pandas/core/frame.py`](https://github.com/pandas-dev/pandas/blob/2925cae048815f03932109f43efbfbc6904b4824/pandas/core/frame.py):

> [Line 4386:1](https://github.com/pandas-dev/pandas/blob/2925cae048815f03932109f43efbfbc6904b4824/pandas/core/frame.py#L4386): [W293](https://duckduckgo.com/?q=pep8%20W293) blank line contains whitespace
> [Line 7212:21](https://github.com/pandas-dev/pandas/blob/2925cae048815f03932109f43efbfbc6904b4824/pandas/core/frame.py#L7212): [E123](https://duckduckgo.com/?q=pep8%20E123) closing bracket does not match indentation of opening bracket's line
> [Line 7213:17](https://github.com/pandas-dev/pandas/blob/2925cae048815f03932109f43efbfbc6904b4824/pandas/core/frame.py#L7213): [E265](https://duckduckgo.com/?q=pep8%20E265) block comment should start with '# '
> [Line 7214:89](https://github.com/pandas-dev/pandas/blob/2925cae048815f03932109f43efbfbc6904b4824/pandas/core/frame.py#L7214): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (96 > 88 characters)
> [Line 7215:1](https://github.com/pandas-dev/pandas/blob/2925cae048815f03932109f43efbfbc6904b4824/pandas/core/frame.py#L7215): [W293](https://duckduckgo.com/?q=pep8%20W293) blank line contains whitespace
Pandas tseries offsets DateOffset
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

input: python .\scripts\validate_docstrings.py pandas.tseries.offsets.DateOffset --errors=F821
output: Docstring for "pandas.tseries.offsets.DateOffset" correct. :)

Labels:

Comments:
Is this PR supposed to be about tseries.offsets?  The diff looks unrelated.
@realjohnward are you working on this PR still?
Actually, this seems to be a duplicate of https://github.com/pandas-dev/pandas/pull/27982.
Support str param type for partition_cols in to_parquet function
State: closed

- [x] closes #27117 
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

Not sure where to add whatsnew entry #PandasHack2019


Labels:
name: IO Parquet
description: parquet, feather

Comments:
@sbrice
@DalynnHatch can you merge master; the code change is ok, but will comment on the tests after rebase.
Closing as stale but @DalynnHatch ping if you'd like to pick back up and continue
Issue 27117
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
Hello @DalynnHatch! Thanks for opening this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





* In the file [`pandas/tests/io/test_parquet.py`](https://github.com/pandas-dev/pandas/blob/afd10c467ecf41f673646267ecf5c0e62d16dfed/pandas/tests/io/test_parquet.py):

> [Line 333:89](https://github.com/pandas-dev/pandas/blob/afd10c467ecf41f673646267ecf5c0e62d16dfed/pandas/tests/io/test_parquet.py#L333): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (94 > 88 characters)
Read csv test
State: closed

- [ ] closes #27655 
- [ 1 ] tests added / passed
- [ 1 ] passes `black pandas`
- *[ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
 
Do not close issue, waiting for user response before continuing further testing.

*Returns "fatal: bad revision 'upstream/master'"

Labels:
name: IO CSV
description: read_csv, to_csv

Comments:
@realjohnward are you still working on this?
I think this has gone stale so closing but @realjohnward feel free to ping if not
DOC: Fixing flake8 error in basics.rst
State: closed

- [x] closes #24173 and follow up on it
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Docs
name: Code Style
description: Code style, linting, code_checks

Comments:
Hi @iamshreeram - can you merge master and address comment?
Sure @WillAyd . I will work on it.
can you merge master
Closing as stale
Series.rename now handles values by Series constructor 
State: closed

- [x] closes #27813 
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:

Comments:
It looks like this PR changes 4 files, only one of which is related to the referenced issue.  am i misunderstanding?

can you include a test for the changed/fixed behavior
The change for this PR is only in the pandas/core/series.py. I don't know why every other commit got included in it when it was from separate feature branch. Can you suggest what needs to be done?
you can revert the changes to unrelated files with `git checkout upstream/master some/file/name.py`
We also have https://github.com/pandas-dev/pandas/pull/27814 for this.
Looks like this was superseded by #27814 - thanks for the PR though!
test case for transform with fillna #27905
State: closed

- [x] closes #27905 
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments:
Hello @ukantesaria! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2019-08-18 00:05:50 UTC
thanks for creating the PR, i think it would be nice also to test `groupby(group_col).transform("fillna")` case
can you merge master and update to comments
can you merge master and update
can you merge master and update to the comments
closing as stale
Added Engine Disposal Documentation
State: closed

Created hyperlink to SQLAlchemy docs for Engine Disposal
responsibilities of user. Unified wording of legacy support for sqlite

- [x] closes #23086 
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Docs
name: IO SQL
description: to_sql, read_sql, read_sql_query

Comments:
Can you fix merge conflict and address comments?
can you merge master and revert the 0.25.1 file
Nice idea but looks like this has gone stale so closing; ping if you'd like to pick this back up
Added try-except clause to catch numpy error.
State: closed

- [x] closes #27953
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.
name: Constructors
description: Series/DataFrame/Index/pd.array Constructors

Comments:
needs a test
Modified as requested.
by "needs a test" I meant that this PR fixes some bug and we need a unit test (goes somewhere in pandas/tests/) to test that we get the correct behavior
I added a test in a place that seemed appropriate. It passed on my platform.
The last version didn't pass the checks. I'm confused because the error doesn't seem to be related to anything that I edited...

![Screenshot from 2019-08-18 15-06-44](https://user-images.githubusercontent.com/43019642/63229856-8aef3d80-c1ca-11e9-96e4-b9763bc641da.png)
![Screenshot from 2019-08-18 15-05-19](https://user-images.githubusercontent.com/43019642/63229857-8b87d400-c1ca-11e9-90f3-aa8da80a0907.png)
can you merge master and add a test
closing this as stale, though its a nice change, needs a rebase and comments addressed.
issue 27904
State: closed

- [x] closes #xxxx
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Duplicate Report
description: Duplicate issue or pull request

Comments:
needs test
Closing, as this is a dupe of #27951 which is actively being worked on.
BUG: don't cache pandas matplotlib converters (#27036)
State: closed

- [ ] closes #27036 
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

#27036 is caused by pandas converters replacing default converters in the cache when we register our  matplotlib converters.

Labels:
name: Bug
name: Visualization
description: plotting

Comments:
Can you add a test for the bugfix
How does this interact with https://github.com/pandas-dev/pandas/pull/27481?
I believe this addresses the same issue as #27481, so I'm closing.
DOC: Added documentation to name and fastpath arguments in series.py
State: closed



- [X] closes #27178
- [N/A] tests added / passed
- [N/A] passes `black pandas`
- [N/A] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [N/A] whatsnew entry


Labels:
name: Docs

Comments:
This is a duplicate of #27960, please help with that PR if you've got something that it's better than what's in there. Thanks!
DOC: Examples added for different types of plots in visualizations user guide
State: closed

- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Docs
name: Visualization
description: plotting

Comments:
You have several unrelated changes to what the title of the PR says, including an added file I don't think we want to get it merged.

Also, afaik we don't use seaborn anywhere in the documentation, and it's not a dependency of pandas, so using seaborn would require discussion.

Closing this for now, please open an issue if you want to discuss using seaborn in examples, and feel free to open a new PR, but just add the related changes.
updated default quoting on to_csv function to csv.QUOTE_NONNUMERIC
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: API Design
name: IO CSV
description: read_csv, to_csv

Comments:
@ayang2012 : Thanks for submitting this PR!  A lot to unpack here, but the biggest question is:

This is an API change.  Can you explain what the rationale is for the change?

(FYI: to anyone else reviewing this, I know there are a bunch of other things to comment on, but this is ultimately the question I want answered before we dive into the other details)
@ayang2012 can you comment on https://github.com/pandas-dev/pandas/pull/27965#issuecomment-522290097?
Closing as I don't think we necessarily want to do this, but certainly open to discussion on it. @ayang2012 if you do think something needs to be changed with this I think best to open an issue and we can discuss appetite / approach up front as required