BrandonFors/pandas-github-issues huggingface dataset:
BUG: inconsistency between replace dict using integers and using strings (#20656)
State: closed

- [x] closes #20656
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Strings
description: String extension data type and string data
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21477?src=pr&el=h1) Report
> Merging [#21477](https://codecov.io/gh/pandas-dev/pandas/pull/21477?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/fb6116f35c291ad49702a0e89575a33da37eeaa1?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21477/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21477?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21477      +/-   ##
==========================================
+ Coverage   92.07%   92.08%   +<.01%     
==========================================
  Files         169      169              
  Lines       50684    50703      +19     
==========================================
+ Hits        46668    46689      +21     
+ Misses       4016     4014       -2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.49% <100%> (ø)` | :arrow_up: |
| #single | `42.33% <12.12%> (-0.01%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21477?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/internals/blocks.py](https://codecov.io/gh/pandas-dev/pandas/pull/21477/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzL2Jsb2Nrcy5weQ==) | `94.63% <100%> (+0.17%)` | :arrow_up: |
| [pandas/core/internals/managers.py](https://codecov.io/gh/pandas-dev/pandas/pull/21477/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzL21hbmFnZXJzLnB5) | `96.48% <100%> (+0.01%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21477?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21477?src=pr&el=footer). Last update [fb6116f...4729fc5](https://codecov.io/gh/pandas-dev/pandas/pull/21477?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@peterpanmj : Good start.  Need a `whatsnew` entry in `0.23.2`.
@gfyoung : Which subsection under Bug fixes should I add my entry ?
@peterpanmj  : `v0.23.2.txt` - `Other` section
Wondering am I working in the right direction ?
@peterpanmj  yes going in good direction! need to rebase as we moved internals around a bit. 
can you rebase
Looks like a nice bit of cleanup in Manager.  For Block I wonder if it could share code with Index,
 (Or an object EA?) but that’s a question for another day.
thanks @peterpanmj nice patch!
BUG #21374: Fix divison with complex numbers in eval() method
State: closed

- [ ] closes #21374 
- [ ] tests added / passed
```python
data = {"a": [1 + 2j], "b": [1 + 1j]}
df = pd.DataFrame(data = data)
df.eval("a/b")
```
Expected output:
```python
df["a"]/df["b"]

0    (1.5+0.5j)
dtype: complex128
```
New result:
```python
df.eval("a/b")

0    (1.5+0.5j)
dtype: complex128
```
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Bug
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
Hello @fillipe-gsm! Thanks for updating the PR.



Cheers ! There are no PEP8 issues in this Pull Request. :beers: 

##### Comment last updated on June 14, 2018 at 02:15 Hours UTC
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21472?src=pr&el=h1) Report
> Merging [#21472](https://codecov.io/gh/pandas-dev/pandas/pull/21472?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b5fc76954963e30b7d7dd4c30ed7363568fd01ee?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21472/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21472?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21472      +/-   ##
==========================================
- Coverage    91.9%   91.89%   -0.01%     
==========================================
  Files         153      153              
  Lines       49606    49606              
==========================================
- Hits        45589    45587       -2     
- Misses       4017     4019       +2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <100%> (-0.01%)` | :arrow_down: |
| #single | `41.89% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21472?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/computation/ops.py](https://codecov.io/gh/pandas-dev/pandas/pull/21472/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tcHV0YXRpb24vb3BzLnB5) | `95.6% <100%> (ø)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/21472/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.6% <0%> (-0.21%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21472?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21472?src=pr&el=footer). Last update [b5fc769...72252e1](https://codecov.io/gh/pandas-dev/pandas/pull/21472?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

tests!
@fillipe-gsm this is almost ready, just needs a unit test and what’s new entry.
closing. needs tests. pls ping if able to update.
DOC : Update generic.py
State: closed

Included documentation for 'how' in DataFrame.resample

- [x] closes #21463
- [ ] tests added / passed
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21465?src=pr&el=h1) Report
> Merging [#21465](https://codecov.io/gh/pandas-dev/pandas/pull/21465?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/576d5c6b76e039a411a7cc4c0de29813e2de0149?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21465/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/21465?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21465   +/-   ##
=======================================
  Coverage    91.9%    91.9%           
=======================================
  Files         153      153           
  Lines       49606    49606           
=======================================
  Hits        45589    45589           
  Misses       4017     4017
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <ø> (ø)` | :arrow_up: |
| #single | `41.89% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21465?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/21465/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `96.12% <ø> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21465?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21465?src=pr&el=footer). Last update [576d5c6...cd9954e](https://codecov.io/gh/pandas-dev/pandas/pull/21465?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

This was deprecated quite some time ago

https://github.com/pandas-dev/pandas/commit/14cf67fbb25c1695fd126ab034af2218d04c154c
BUG: fix get_indexer_non_unique with CategoricalIndex key
State: closed

- [x] closes #21448
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Categorical
description: Categorical Data Type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21457?src=pr&el=h1) Report
> Merging [#21457](https://codecov.io/gh/pandas-dev/pandas/pull/21457?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/8eb49371be3e19de48b90064019898b4162b7cbb?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21457/graphs/tree.svg?width=650&src=pr&token=eZ4WkYLtcO&height=150)](https://codecov.io/gh/pandas-dev/pandas/pull/21457?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21457      +/-   ##
==========================================
+ Coverage   91.89%    91.9%   +<.01%     
==========================================
  Files         153      153              
  Lines       49600    49606       +6     
==========================================
+ Hits        45580    45589       +9     
+ Misses       4020     4017       -3
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.3% <100%> (ø)` | :arrow_up: |
| #single | `41.89% <14.28%> (+0.02%)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21457?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/category.py](https://codecov.io/gh/pandas-dev/pandas/pull/21457/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9jYXRlZ29yeS5weQ==) | `97.06% <100%> (+0.03%)` | :arrow_up: |
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/21457/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.62% <100%> (ø)` | :arrow_up: |
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/21457/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `97.24% <0%> (+0.24%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21457?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21457?src=pr&el=footer). Last update [8eb4937...85f0c70](https://codecov.io/gh/pandas-dev/pandas/pull/21457?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
API/BUG: Raise when int-dtype coercions fail
State: closed

Related to the Index and Series constructors.

Closes #15832.

cc @ucals (since this is mostly based off what you did in #15859)

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21456?src=pr&el=h1) Report
> Merging [#21456](https://codecov.io/gh/pandas-dev/pandas/pull/21456?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/c2da06c8eea4cc0339717aa09acdd6765bc3d673?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21456/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/21456?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21456      +/-   ##
==========================================
+ Coverage   91.92%   91.92%   +<.01%     
==========================================
  Files         153      153              
  Lines       49570    49586      +16     
==========================================
+ Hits        45566    45582      +16     
  Misses       4004     4004
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.32% <100%> (ø)` | :arrow_up: |
| #single | `41.81% <66.66%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21456?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/21456/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.62% <100%> (ø)` | :arrow_up: |
| [pandas/core/dtypes/cast.py](https://codecov.io/gh/pandas-dev/pandas/pull/21456/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZHR5cGVzL2Nhc3QucHk=) | `88.49% <100%> (+0.26%)` | :arrow_up: |
| [pandas/core/series.py](https://codecov.io/gh/pandas-dev/pandas/pull/21456/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc2VyaWVzLnB5) | `94.19% <100%> (+0.01%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21456?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21456?src=pr&el=footer). Last update [c2da06c...27caec9](https://codecov.io/gh/pandas-dev/pandas/pull/21456?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@gfyoung if you can rebase your fixures should cleanly merge
@jreback : Tests are finally green again!  PTAL.
@jreback : Tests are green again.  PTAL.
> perf check?

@jreback : Oh sorry, forgot to respond on that.  Perf looks good!
@jreback : Comments addressed, perf looks good, and CI is green.  PTAL.
thanks @gfyoung  nice patch!
Fix tests fragile to PATH
State: closed

Closes #21450

Get path of current python interpreter running opposed to one on users path.


Labels:
name: CI
description: Continuous Integration
name: Unreliable Test
description: Unit tests that occasionally fail

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21453?src=pr&el=h1) Report
> Merging [#21453](https://codecov.io/gh/pandas-dev/pandas/pull/21453?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ab668b0a56a9f2aee959bde787e9a0af4068d7a7?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21453/graphs/tree.svg?height=150&src=pr&token=eZ4WkYLtcO&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/21453?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #21453      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files         153      153              
  Lines       49600    49600              
==========================================
- Hits        45580    45578       -2     
- Misses       4020     4022       +2
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (-0.01%)` | :arrow_down: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21453?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/21453/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `84.6% <0%> (-0.21%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21453?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21453?src=pr&el=footer). Last update [ab668b0...e846c18](https://codecov.io/gh/pandas-dev/pandas/pull/21453?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

thanks @WillAyd
PERF: Use ccalendar.get_days_in_month over tslib.monthrange
State: closed

asv looks like a wash, probably to be expected since these calls make up such a small part of the methods they are used in.

tslibs.resolution uses the stdlib calendar.monthrange instead of tslib.monthrange, so the perf bump should be bigger there.

Labels:
name: Datetime
description: Datetime data dtype
name: Performance
description: Memory or execution speed performance

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21451?src=pr&el=h1) Report
> Merging [#21451](https://codecov.io/gh/pandas-dev/pandas/pull/21451?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ab668b0a56a9f2aee959bde787e9a0af4068d7a7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21451/graphs/tree.svg?token=eZ4WkYLtcO&src=pr&height=150&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/21451?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21451   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49600    49600           
=======================================
  Hits        45580    45580           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <100%> (ø)` | :arrow_up: |
| #single | `41.86% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/21451?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/tseries/offsets.py](https://codecov.io/gh/pandas-dev/pandas/pull/21451/diff?src=pr&el=tree#diff-cGFuZGFzL3RzZXJpZXMvb2Zmc2V0cy5weQ==) | `97% <100%> (ø)` | :arrow_up: |
| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/21451/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.8% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21451?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21451?src=pr&el=footer). Last update [ab668b0...aecbee8](https://codecov.io/gh/pandas-dev/pandas/pull/21451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@jbrockmendel : Any `asv`-related information + `whatsnew` in `0.24.0` would be good here.
this is fine, no whatsnew needed if just internal refactoring generally (unless its 'big') or has an api impact.
DOC: Fixed warning in doc build [ci skip]
State: closed

[ci skip]

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21449?src=pr&el=h1) Report
> Merging [#21449](https://codecov.io/gh/pandas-dev/pandas/pull/21449?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/ab668b0a56a9f2aee959bde787e9a0af4068d7a7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/21449/graphs/tree.svg?height=150&src=pr&token=eZ4WkYLtcO&width=650)](https://codecov.io/gh/pandas-dev/pandas/pull/21449?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master   #21449   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         153      153           
  Lines       49600    49600           
=======================================
  Hits        45580    45580           
  Misses       4020     4020
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.29% <ø> (ø)` | :arrow_up: |
| #single | `41.86% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21449?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/21449?src=pr&el=footer). Last update [ab668b0...478a6e0](https://codecov.io/gh/pandas-dev/pandas/pull/21449?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Resolves Issue 21344: provide a timedelta in a non-string format
State: closed

- [x] closes #21344
- [x] tests added / passed
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

This extends the API - and there is a judgement call about how to treat nanosecond-resolution pd.Timedelta() objects in the context of datetime.timedelta() objects.


Labels:
name: Enhancement
name: Timedelta
description: Timedelta data type

Comments:
``Timedelta.resolution`` is used completely internally. rather have you change its name and leave ``.resolution`` as an inherited property. I didn't even know that ``timedelta`` has a property by this name.

This would then be an API change, but conform to ``timedelta``, which we in general want to do.
can you rebase
closing as stale. if you'd like to continue, pls ping.