BrandonFors/pandas-github-issues huggingface dataset:
TST: use one-class pattern in json extension tests
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.
name: Nested Data
description: Data where the values are collections (lists, sets, dicts, objects, etc.).

Comments:
Thanks @jbrockmendel
TST: use single-class pattern in test_string.py
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Refactor
description: Internal refactoring of code
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Thanks @jbrockmendel
CLN: pass dtype to from_sequence explicitly
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks @jbrockmendel
CI: Rename to .condarc
State: closed

- [ ] closes #56497 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: CI
description: Continuous Integration

Comments:
With setup-micromamba 1.7.3, this is not an issue anymore.
I mistakenly assumed that only `.condarc` is a valid condarc file name. But in reality, all files ending with `.yml` are too (among others)

https://github.com/mamba-org/mamba/blob/c54c4b530e6638c8712f6246200d0f5a32410b46/libmamba/src/api/configuration.cpp#L955

Sorry about the inconvenience 😓 
Ah no worries! Despite this, I think it's OK for us to rename this anyways
added mapping to assign
State: closed

- [x] closes #56498 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Going to close this PR pending approval for this feature in the associated issue
BUG: Replaced ValueError exception with TypeError exception in df.where() function
State: closed

Replaced ValueError exception with TypeError as it is more appropriate for the error it serves

[] closes issue #56330  where there was a consensus that a TypeError is more appropriate for the following error: "Boolean array expected for the condition, not (non-bool type)". Since ValueErrors are raised when the type is correct but the value is incorrect, whereas in this function we are raising an exception because of a wrong type, hence the TypeError.

I've also included commits to update the tests for this method.

(I had already made this PR but messed up my commits because I'm new to GitHub so I'm redoing it).


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
You have to adjust one more test here: https://github.com/pandas-dev/pandas/blob/main/pandas/tests/series/indexing/test_where.py#L204
> You have to adjust one more test here: https://github.com/pandas-dev/pandas/blob/main/pandas/tests/series/indexing/test_where.py#L204

Thank you so much! Finally passed the checks!
> Can you add a whatsnew entry in v2.20.rst?
@mroeschke I thought you just talking about adding up a new header whasnew will coming up with Updated version.
  

Thanks @DarthKitten2130
TST: de-special-case test_EA_types
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Thanks @jbrockmendel
TYP: Update mypy and pyright
State: closed

The first commit contains changes for only the mypy update.

The second commit contains only changes for pyright 1.1.399 (this commit has three remaining errors caused by a bug fixed in 1.1.400 ).

The third commit tries to get to 1.1.400. One major change in 1.1.400 is that pyright now also infers missing return annotations for partially annotated functions. Many of these functions would require complex overloads or ignore codes. I added a few overloads but for now, I would prefer to update to 1.1.399 (and ignore the error fixed in 1.1.400).

Labels:
name: Code Style
description: Code style, linting, code_checks
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Thanks @twoertwein
BUG: time strings cast to ArrowDtype with pa.time64 type
State: closed

- [x] closes #56463 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Arrow
description: pyarrow functionality

Comments:
One test request, otherwise LGTM
thx @mroeschke
BUG: merge_asof(tolerance=Timedelta) with ArrowDtype
State: closed

- [ ] closes #56486 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Datetime
description: Datetime data dtype
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Arrow
description: pyarrow functionality

Comments:
thx @mroeschke 
I think we should probably create a more generic wrapper at some point
BUG: RecursionError with categorical merge keys
State: closed

- [x] closes #56376
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v2.2.0.rst` file if fixing a bug or adding a new feature.

Most of this PR is repeated code from https://github.com/pandas-dev/pandas/pull/55201. It might be worth generalizing, but I didn't see a clean way.

Labels:
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
REF: use maybe_convert_objects in pd.array
State: closed

- [x] closes #52972 (Replace xxxx with the GitHub issue number)
- [x] closes #29973
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

@phofl the only other place where the convert_nullable_whatever option is used is in the sql code that i think you implemented.  will any of the changes here affect that?

Labels:
name: Stale

Comments:
@lithomas1 looked at this function recently so might have feedback
should be fine for the sql use case
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Looks like this PR has gone stale and needs a rebase. Closing to clear the queue but feel free to reopen when you have time to circle back
rebased
Thanks @jbrockmendel
README updated for initial setup and installation
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the contribution @davoodalavi, but we try to avoid merging pull requests that mix different fixes and introduce somehow arbitrary changes.

What I recommend is that you open an issue if there is something that you want to discuss. For small changes feel free to open a pull request, but do not mix things as it makes reviewing complicated, and also managing changes in pandas and keeping a clean history in case of issues.

In this particular case, if you think that there should be blank lines after headers in the README, that should be a separate PR from the rest. I don't think we'll merge such a PR, as the GitHub markdown format supports not having it, and seems opinionated to have them or not, so it seems to just introduce noise and add no value (noise by having to review more PRs, having a longer history, changing what `git blame` returns...

For the other comments, they also seem opinionated, some users will find it useful to have information on how to create virtual environments, while for others it's obvious, and others won't use venv but something else. I personally don't think we should have a too verbose README as we already have a two installation instructions pages, one of them very verbose.

So, closing here, but as I said, if you still think something should be changed, please open a new PR, but in an atomic way (addressing a simple topic at a time, not mixing different things).
Create test_timestamp_fromisoformat.py 
State: closed

- [ ] addresses #56398  (Replace xxxx with the GitHub issue number)
- [ ] [Tests added](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
CLN: changes for spelling mistakes
State: closed

- [x] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Clean

Comments:
Thanks for the contribution @ashishkumar30, not sure if many of those add much value, but make sure you're not breaking the tests, we test for the messages of exceptions in general, so changing them will make tests fail.

I'd personally prefer if you revert the commas, and also adding the `s` to Python object names like `Categorical` or `datetime`.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: Add example with ``numpy_nullable`` to ``pd.read_html()``
State: closed

- [x] [closes](https://github.com/noatamir/pyladies-berlin-sprints/issues/4)

Labels:

Comments:
Given ```See the :ref:`read_html documentation in the IO section of the docs <io.read_html>` for some examples of reading in HTML tables.``` I am not sure if I can or should move this.
> Given `` See the :ref:`read_html documentation in the IO section of the docs <io.read_html>` for some examples of reading in HTML tables. `` I am not sure if I can or should move this.

It would be good to move those examples in the user guide to the docstring
I moved several examples.
apply.py code comment reformatting and clean up
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the PR but these docstrings and comments are structured and validated in a specific format, so these cannot be changed to a different format.

Going to close, but happy to have contributions toward any other open issues
Add optional parameter for pd.factorize to handle new categories in categorical data dynamically
State: closed

- [X] closes #12509 
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [X] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Issue with updating release notes (merge conflict):

Addition:
`- Enhanced :func:`pandas.factorize` to support an additional parameter `original_factorization`, allowing users to apply an existing factorization scheme to new data. This feature is useful for maintaining consistent category codes across different datasets (:issue:`12509`).`

Example usage:

```
original_data = ['a', 'b', 'c', 'c', 'd', 'e']
new_data = ['a', 'd', 'e', 'k']

# Original codes will be 0, 1, 2, 2, 3, 4
original_codes, original_uniques = pd.factorize(original_data)

new_codes, new_uniques = pd.factorize(new_data) # New codes will be 0, 1, 2, 3 given existing implementation
new_codes1, new_uniques1 = pd.factorize(new_data, original_factorization=(original_uniques, original_codes))

# New codes 1 will be 0, 3, 4, 5 to account for the mappings previously generated.
```



Labels:

Comments:
Thanks for the pull request, but it appears to have gone stale. Additionally the issue notes that this is a documentation change and a proposal to add a new argument needs a dedicated issue first before proceeding. Closing
DOC: Minor improvements groupby user guide
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Groupby

Comments:
Just noting to feel free to liberally move examples and behavior notes to docstrings or remove sections that are too niche/outdated. IMO I feel that information is best served in docstrings as opposed to user guides given how outdated they are
Thanks @rhshadrach
BUG: Return numpy types from ArrowExtensionArray.to_numpy for temporal types when possible
State: closed

- [ ] closes #55997 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Timedelta
description: Timedelta data type
name: Arrow
description: pyarrow functionality
name: Timestamp
description: pd.Timestamp and associated methods

Comments:
thx @mroeschke
Fix/qcut multiple min values
State: closed

- [] closes #55991
- [] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [] Added an entry in the latest `doc/source/whatsnew/v2.1.4.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
Adjust concat tests for string option
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Strings
description: String extension data type and string data

Comments:
Thanks @phofl