BrandonFors/pandas-github-issues huggingface dataset:
TST: Test series add sub with UInt64
State: closed

- [x] closes #22023 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
thx @luke396
DOC: Add docstring for DataFrame.T property
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.



**Before this change:**
The `T` property of a DataFrame is named in the docs but is not linked to any documentation:

(Screenshot below taken from https://pandas.pydata.org/docs/dev/reference/api/pandas.DataFrame.html)

<img width="1346" alt="image" src="https://user-images.githubusercontent.com/122238526/212579272-bc583d1a-bd0d-471e-972f-c6d10d81667e.png">



**After this change**
The `T` property is linked to documentation (it now appears as the top property alphabetically, I guess because it's a capital 'T').

<img width="1258" alt="image" src="https://user-images.githubusercontent.com/122238526/212579535-b4f9c4d7-2bfb-49af-bb3b-1e3f0e675df0.png">


And if you click on it you see this new page.  As you can see, it links through to the existing `DataFrame.transpose` docs. I put in one simple example here.
<img width="1277" alt="image" src="https://user-images.githubusercontent.com/122238526/212579665-cdca6ebd-9a99-4d16-ace6-979ad85a7dbc.png">






Labels:
name: Docs

Comments:
Thanks @smij720
ENH: Add use_nullable_dtypes to read_feather
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Enhancement
name: IO Parquet
description: parquet, feather

Comments:
Thanks @phofl
BUG: eval and query not working with ea dtypes
State: closed

- [x] closes #29618 (Replace xxxx with the GitHub issue number)
- [x] closes #50261
- [x] closes #31913
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


This is really ugly, not sure if we want to do this. But could not find another way to make this work

Labels:
name: expressions
description: pd.eval, query
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
cc @mroeschke could you have a look? Remaining failures were only because pyarrow was not installed in the pipelines in question
ci is green now
Thanks @phofl
BUG: Series add casting to object for list and masked series
State: closed

- [x] closes #22962 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
Thanks @phofl
BUG: Fix file-like objects failing in `read_xml` when iterparse is used
State: closed

- [X] closes #50641
- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/v2.0.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: IO XML
description: read_xml, to_xml

Comments:
Thanks @ParfaitG
BUG: Series constructor overflowing for UInt64
State: closed

- [x] closes #38798 (Replace xxxx with the GitHub issue number)
- [x] closes #25880 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Not sure if there is a way to avoid loss of precision without using object in the mixed case. This does not impact the regular case without overflow risks

Labels:
name: Bug
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
Yikes this is mean, it's not failing on Mac :)
TST: Test groupby method drop na
State: closed

- [x] closes #21755 (Replace xxxx with GitHub issue number) 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) when a bug was fixed or a new feature was added - [ ] All [Code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit) 
- [ ] [Type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) added to new arguments/methods/functions 
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file when a bug was fixed or a new feature was added.

referred to [TST: Added test for groupby dropping NA when grouping by columns from pbhoopala](https://github.com/pandas-dev/pandas/pull/50156)

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby

Comments:
Thanks @luke396
TST: Determine groupby-transform not convert back type
State: closed

- [x] closes #22243 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby
name: Apply
description: Apply, Aggregate, Transform, Map

Comments:
Thanks @luke396
TEST: dropna() doesn't fall into infinite loop
State: closed

- [x] closes #50708
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

I have checked that the problem was reproducible in 1.5.2 and is not reproducible on main. The added test `test_constructor_large_size_frame` checks if an infinite loop occurs.

Labels:
name: Needs Tests
description: Unit test(s) needed to prevent regressions
name: Subclassing
description: Subclassing pandas objects

Comments:
Hi @MarcoGorelli. Could you please take a look at the test.
should be good (pre-commit isort failure is unrelated, and solved in https://github.com/pandas-dev/pandas/pull/51048 - I just hit the "update branch" button to merge upstream/main and restart it just to be sure)
Thank you, @MarcoGorelli for reviewing the PR.
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Hi @MarcoGorelli. I merged upstream/main into my branch. Could you please have a look?
thanks - looks like the test is failing now
```
FAILED pandas/tests/frame/test_constructors.py::TestDataFrameConstructors::test_constructor_large_size_frame - pandas.tests.frame.test_constructors.TestDataFrameConstructors.test_constructor_large_size_frame.<locals>.TimeoutError: Timer expired
```

it might be worth doing a dive into setting what caused the timeout in the first place - I could take a look next week
Looks like this PR has stalled so closing to clear the queue
thank you, @mroeschke, I should have closed this pr myself earlier.
ENH: Add use_nullable_dtypes option to read_json
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

This is a shortcut for now, but want to get the option in for 2.0, want to implement this properly afterwards

Labels:
name: IO JSON
description: read_json, to_json, json_normalize
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays

Comments:
Yep, added a test for "Int64". 
Thanks @phofl
TST: Consolidate tests that raise in groupby
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Part of #50133. Continue the work of @rhshadrach started in #50404 for the groupby consolidation.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Groupby
name: Clean

Comments:
Thanks for the review @rhshadrach. 

I updated the tests, I believe now it should cover all the cases you mentioned (and more). Wondering if 28k tests for a single file isn't to much though ?

Anyway, I think we are still missing some cases like grouping on the index or grouping on a dtype other than int or category. Not sure if you think it is necessary here?
On my machine, I get :
==== 28501 passed, 420 skipped in 113.16s (0:01:53) ====

Also, do you know why the CI pipeline is failing ? I see some failed tests in pandas/tests, but I don't see the connection with this PR ?
Done. The new runtime on my machine is : 
===== 10561 passed in 44.23s =====
Thanks @albuzenet - great work!
Thanks for the review @rhshadrach !
ENH: Add global nullable option
State: closed

- [x] closes #50747 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays
name: Arrow
description: pyarrow functionality

Comments:
Thx!
resolved
good to merge on greenish?
> good to merge on greenish?

Yup
ENH: Add lazy copy to replace
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

cc @lithomas1 as discussed on slack

Labels:
name: Copy / view semantics

Comments:
thanks @phofl.
Thx to you as well, you did most of the work :)
REF: groupby Series selection with as_index=False
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Currently `.groupby(..., as_index=False)['column']` gives back a DataFrameGroupBy This is because `SeriesGroupBy` doesn't implement `as_index=False`. This gives rise to having a `DataFrameGroupBy` object with `self.obj` being a Series. It also might be a bit surprising to users that this gives them back a DataFrameGroupBy (though this is probably rarely noticed).

Eliminating this case simplifies the states groupby code must consider. It also is a step toward #46944.

There should be no changes in behavior from a user perspective except getting back a SeriesGroupBy and the one noted in the comments below.

cc @jbrockmendel 

Labels:
name: Refactor
description: Internal refactoring of code
name: Groupby

Comments:
Thanks @rhshadrach
TST: Test dtype sparseDtype with specificd fill value
State: closed

- [x] closes #49987 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Sparse
description: Sparse Data Type

Comments:
thx @luke396
DOC: Add datetime.tzinfo to paramater tz in tz_localize and tz_convert
State: closed

- [x] closes #50655 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs
name: Timezones
description: Timezone data dtype

Comments:
Don't forget to add it to the functions listed in the issue. There could be more that I forgot to include.
> Don't forget to add it to the functions listed in the issue. There could be more that I forgot to include.

All functions about tz_localize or tz_convert seem to share the same doc template, so this will influence all of them (Series.tz_localize, DataFrame.tz_localize, DateIndex.tz_localize... ). I haven't found more functions that need to be added, so if so, feel free to bring them up.

> All functions about tz_localize or tz_convert seem to share the same doc template, so this will influence all of them (Series.tz_localize, DataFrame.tz_localize, DateIndex.tz_localize... ). I haven't found more functions that need to be added, so if so, feel free to bring them up.

I actually haven't read the code. Sorry for the wrong comment and thank you for solving the issue.
Thanks @luke396
TST: Fix undefined variables in tests
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I think I got all of them from #50669. Feel free to push if I missed one.

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Self merging to get CI green.
DOC: list supported float dtypes I
State: closed

- [x] closes #50216
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Updated documentation for `pandas.to_numeric()`, pointed out that `downcast` parameter doesn’t support `float16` dtype. Listed in the description of [dtype](https://pandas.pydata.org/docs/user_guide/basics.html#dtypes) supported floating point types and added Link to [NumPy types](https://numpy.org/doc/stable/reference/arrays.scalars.html#numpy).

Labels:
name: Docs

Comments:
thx @natmokval
REF: share string parsing code
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Refactor
description: Internal refactoring of code
name: Datetime
description: Datetime data dtype

Comments:
look great! will do a final check after a call I have in a few mins, then will approve/merge
BUG: stringdtype.astype(dt64_or_td64)
State: closed

- [x] closes #36153 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Strings
description: String extension data type and string data

Comments:
Thanks @jbrockmendel
CLN explicit float casts in tests
State: closed

Similar to https://github.com/pandas-dev/pandas/pull/50493

There are places when an implicit cast happens, but it's not the purpose of the test - the cast might as well be done explicitly then

This would help pave the way towards https://github.com/pandas-dev/pandas/pull/50424

---

I expect this to be the last precursor PR, after this one I'll raise a draft PR to try enforcing PDEP6 in some cases (note that merging would only take place _after_ 2.0 is released)

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Clean

Comments:
Thanks @MarcoGorelli