BrandonFors/pandas-github-issues huggingface dataset:
BUG: Check `min_periods` before applying the function
State: closed

- [x] closes #58868
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Apply
description: Apply, Aggregate, Transform, Map
name: Window
description: rolling, ewma, expanding
name: numba
description: numba-accelerated operations

Comments:
Thanks @rob-sil
BUG: Fix to_datetime not respecting dayfirst 
State: closed

- [x] closes #58859
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Datetime
description: Datetime data dtype

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Ah, I guess the dateutil path was not being used here.
The formatting makes it seem like I made a lot of changes but essentially I just added an `if not dayfirst` check before using `string_to_dts` per your suggestion.
The test fails if I revert the changes in `parsing.pyx`, I believe this is the line of code in the test that hits the changes:
https://github.com/pandas-dev/pandas/blob/4c275301f620105cb2a9b944a815f3e85e1f2bd5/pandas/tests/tools/test_to_datetime.py#L3044-L3046


Thanks @Aloqeely
solved issue #58848 by adding docstrings in announce.py and contribut…
State: closed

…ors.py

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
corrects-spelling-mistake-in-merging.rst
State: closed

Changed 'mactches' to 'matches'

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @jamesyuill
BUG/df.agg-with-df-with-missing-values-results-in-IndexError
State: closed

- [x] closes #58810
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: Apply
description: Apply, Aggregate, Transform, Map

Comments:
Ready for review.
Thanks @abeltavares
DOC: Add note about deprecated offset aliases
State: closed

The PRs #55792 (Y), #52064 (Q), and #55553 (M) deprecated the single letter version of the aliases in favour of the -end version of them.

This table was missed as part of that work.

I skipped making an issue because the PR with the fix is the simplest way to express the issue!

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] ~[Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature~
- [ ] ~All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).~
- [ ] ~Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.~
- [ ] ~Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.~


Labels:
name: Docs
name: Frequency
description: DateOffsets

Comments:
thanks @tacaswell 

these are only deprecated for offsets (where people always interpreted `'M'` to mean `'month'` as opposed to `'month end'`)

for periods (the section you've edited), `'M'` is still valid - periods have no "period start" / "period end"

is this not what you're seeing?
I'm getting this out of `pd.Grouper(freq=...)` which in my head should be "period", but reading the docs for `pd.Grouper ` it does link to the offsets table so there is some user-error / wishful-API-usage (🐑 ) going on here.  I went looking for notes on the deprecation, found the `M` in this table and decided to "help". 

The warning I'm getting is:

```
<string>:23: FutureWarning: 'M' is deprecated and will be removed in a future version, please use 'ME' instead.
```

which is unclear if it is an offset or period (I don't have time to run through sorting out the deprecation note generation to tell if that is easy to add or not, sorry).

-----

I've removed the changes to the table and moved the note to the other table.
> thanks @tacaswell , should be right - @natmokval could you confirm please?

I agree, we should point out that we deprecated the aliases `'M,' 'Q,' etc.`, for offsets. Thanks, @tacaswell, for adding the note for the table with Offset aliases.

We can also mention in this note that we deprecated the aliases `'BM,' 'CBM,' 'BQ,' and 'BY'` in favor of `'BME,' 'CBME,' 'BQE,' and 'BYE'`, but it’s already clear enough.
agree, thanks for taking a look

cool, let's ship it then
Series.values deprecation of converts and drops
State: closed

- [x] closes #54717 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Added the warnings in the function external_values in "pandas/core/internals/blocks.py" and added most of the asserts in the tests. Some tests will not pass, because they sometimes would show the warning and sometimes wouldn't so I didn't know what to do.

Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
I was thinking about changing the stack_level on the warning so we don't need to do as much asserts on the tests. 
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
REF/block the implicit cast of datetime.datetime to pa.date32()
State: closed

- [x] closes #58420
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

The change I made probably doesn't change the entire problem because the code continues to cast all other pyarrow types.


Labels:

Comments:
Really appreciate the research into this @PedroVerardo . From what you discovered the issue is upstream in pyarrow - I copied you on the issue there so let's close this and track upstream.

Sorry there is nothing to merge into pandas but once again thanks for your efforts on this
REF/API: make construct_array_type a non-classmethod
State: closed

- [x] closes #58663 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).




Labels:

Comments:
Since it is already a non-classmethod in StringArray, making the abstract method non-classmethod would ensure code consistency.
Since it's my first PR, I would greatly appreciate your valuable feedback @jbrockmendel 
#58663 is not a good issue for a beginner.  please look for an issue with the "good first issue" label
I did indeed look for some alternatives with this label, but ultimately concluded that this issue remained the most appropriate one and the one I was most interested in investigating further.
> concluded that this issue remained the most appropriate one

It is not.  Please look again.
I apologize if I chose an inappropriate issue. I consulted with a colleague who has previously contributed to this repository and they assured me it was fine. If anything is missing from the modified files, or if further discussion/research regarding the issue is needed, that's perfectly okay.
The hard part of addressing #58663 is not changing a few lines of code, but in achieving consensus that it is a change we _want_ to make, then in making the change without breaking 3rd party subclasses.
Thanks for the PR @miguelpgarcia but agreed that making a PR is premature at this point and would need more coordination to start opening a PR to address. Going to close, but happy to have your contributions towards issues labeled `good first issue`
ENH: pd.NamedAgg forwards *args and **kwargs to aggfunc
State: closed

- [x] closes #58283
- [x] [Tests added and passed]
- [x] All [code checks passed]
- [x] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file if fixing a bug or adding a new feature.


Labels:
name: Apply
description: Apply, Aggregate, Transform, Map
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Closing as stale. @tomytp - if you'd like to continue, comment here and we can reopen.
CLN: use isnan() instead of the Py_IS_NAN macro
State: closed

Since 3.11 the later is just an alias for isnan().  See also https://github.com/python/cpython/issues/119613


Labels:
name: Clean

Comments:
What about Python 3.10? Noted on the C99 requirement (we actually require a C11 compiler anyway) but are these macros equivalent still on 3.10 or is there a possibility of a behavior difference?
There is.  If you support platforms without IEEE 754, without NaN, and without C99+ ``<math.h>``.  Macroses were more complex to cover such cases, e.g.:
https://github.com/python/cpython/blob/c8f868dc52f98011d0f9b459b6487920bfb0ac4d/Include/pymath.h#L97-L103
OK thanks for that info. I think we are OK with this as is then. Appreciate the PR
@mroeschke 
Thanks @skirpichev
DOC: Added Docstrings to announce.py and contributors.py
State: closed

- [ ] closes #58812 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Docstrings were added to `get_authors()` , `get_pull_requests()`, `build_string()`, `build_components()`, and `main()` of **announce.py**. Additionally, docstrings were added to `run()` and `setup()` in **contributors.py**.


Labels:
name: Docs

Comments:
Thanks for the PR! As mentioned in the issue there is already another open PR that adds the docstrings, and I think we're gonna stick to it because it was opened first.

Really sorry for taking much of your time! But feel free to work on other issues with the `Docs` label, we have lots of other docstrings that need to be improved! ;)
feat!: Removes `inplace` option for `pandas.core.resample.Resampler.i…
State: closed

…nterpolate`. Fixes / cleans up related test cases.

- [x] closes #58690 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Resample
description: resample method
name: Stale
name: inplace
description: Relating to inplace parameter or equivalent

Comments:
@MarcoGorelli somehow it did not auto-assign the reviewers. But in any case, here we are :)
Do these need to be deprecated first? You can use the `deprecate_kwarg` decorator for that
> Do these need to be deprecated first? You can use the `deprecate_kwarg` decorator for that

I don't know what the exact policy is. But as far as I understand the deprecation tells the user that a certain **future** change will change the API. This does not apply here, as the inplace-functionality is already broken. We would need to add the deprecation to pandas 2 to inform users about the upcoming change, and to ease migration. But I guess this would need a separate PR that targets the next 2.x release.
> Do these need to be deprecated first?

Thanks @Aloqeely - in general, yes, this would require a deprecation. However, here, the change is going to breaking anyway (in order to fix a historic ~~feature~~ bug), so to be honest I'd be OK removing `inplace` without warning too
@mroeschke can we merge this? 😄 
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
> This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.

I'll work on this, I was just unable to spend time.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
BUG: DataFrame.drop unexpectedly drops frequency
State: closed

- [x] closes #58743 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
im not convinced this is something we should do.  this seems like a case where users shouldn't be using `drop` in the first place
I'm not convinced, either. In any case, I don't think it's desirable for `drop` to implicitly set `freq` to `None`. If `DatetimeIndex` has a `freq`, it should be retained, and if it is explicitly `None`, it should remain `None`.

Thank you so much again for your review.
Yeah I'm not convinced this complexity is worth adding. Thanks for the PR but going to close for now
ENH: add atol, rtol and check_exact to the Object.compare() method
State: closed

- [x] closes #58827
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file if fixing a bug or adding a new feature.


Labels:

Comments:
Thanks for the PR, but the associated issue should first have buy in from the core team before proceeding with a PR here.

Closing, but we can reopen once there is more support for this issue in the PR
ENH: Implemented det and rref for frame.py(determinant and row reduced form)
State: closed

Our features consist in:
-Calculating the determinant of a DataFrame
-Reducing a DataFrame to its row reduced echelon form The DataFrame's determinant algorithm tries to find linear dependencies If there are some, it will immediately return 0
Otherwise it will calculate it through recursion
The row reduction algorithm removes linear dependencies between rows And reduces the values to as low as it can

- [x] doesn't close any issue
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Needs Discussion
description: Requires discussion from core team before further action

Comments:
i asked on slack if me and my colleague could develop some more methods for the dataframes related to linear algebra, we were asked if what we wanted was already in numpy or other libraries, to which i replied yes and justified our decision with the existance of the dot method for the dataframes.
i totally understand if the people in charge decide not to accept this pull request, we implemented these methods to the DataFrame because we thought it made sense for us to do so.
Thanks for the PR! I also think we should not implement these methods since they already exist in scipy.

But let's get another pandas dev's opinion before closing
Yea I agree with @Aloqeely - we generally have a really high bar to expand our API. The fact that this is already available in SciPy and likely with a more performant implementation makes it less than ideal to try and duplicate in pandas.

Appreciate the PR though. Sounds like you might have done this as an exploration which is great, though for future reference it is usually best to open an enhancement request first and have someone approve at a high level before putting effort into the implementation. We are cognizant of contributor time so we want to avoid situations as much as possible where people put time into things that are unlikely to be accepted to the library
DOC: Fix docstring error SA01 for pandas.Dataframe.plot, pandas.Series.plot, pandas.core.groupby.DataFrameGroupBy.plot, pandas.core.groupby.SeriesGroupBy.plot
State: closed

- [ ] DOC: Fixes docstring errors for following methods closes (#58065)
- [ ] Updated code_checks.sh to remove docstring errors
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
Thanks @anishfish2
upadting doc string 
State: closed

- [ ] closes #58824
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.


Labels:
name: Docs

Comments:
pre-commit.ci autofix
Thanks for the PR! Can you also add the description for the `msg` parameter as suggested in the issue?
Thanks @santhoshbethi 
Thanks for Approving @mroeschke
_may_promote hotfix.
State: closed

- [x] closes #58428 


If `is_valid_na_for_dtype(fill_value, dtype)` is passing then why is there a need to change `dtype` to accomodate na and call `ensure_dtype_can_hold_na` which unnecessarily promotes dtype from `int64` to `float64`

Labels:

Comments:
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.