Convert Sparse ASVs
State: closed


Labels:
name: CI
description: Continuous Integration
name: Clean

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=h1) Report
> Merging [#26704](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/649ad5c91aabb95d7f200eec84b82cae1459fc65?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26704/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26704      +/-   ##
==========================================
- Coverage   91.88%   91.87%   -0.01%     
==========================================
  Files         174      174              
  Lines       50701    50701              
==========================================
- Hits        46588    46584       -4     
- Misses       4113     4117       +4
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.41% <ø> (ø)` | :arrow_up: |
| #single | `41.93% <ø> (-0.09%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97% <0%> (-0.12%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=footer). Last update [649ad5c...990f5b8](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=h1) Report
> Merging [#26704](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/d47fc0cba3cf94ebd289ad3776bf7ff3fe60dfb8?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/26704/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #26704      +/-   ##
==========================================
+ Coverage   91.71%   91.72%   +<.01%     
==========================================
  Files         178      178              
  Lines       50771    50779       +8     
==========================================
+ Hits        46567    46575       +8     
  Misses       4204     4204
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.31% <ø> (ø)` | :arrow_up: |
| #single | `41.21% <ø> (-0.07%)` | :arrow_down: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `78.94% <0%> (-10.53%)` | :arrow_down: |
| [pandas/core/indexes/interval.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9pbnRlcnZhbC5weQ==) | `96.11% <0%> (-0.32%)` | :arrow_down: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `96.88% <0%> (-0.12%)` | :arrow_down: |
| [pandas/core/series.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvc2VyaWVzLnB5) | `93.64% <0%> (+0.01%)` | :arrow_up: |
| [pandas/util/testing.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvdGVzdGluZy5weQ==) | `90.94% <0%> (+0.1%)` | :arrow_up: |
| [pandas/io/excel/\_base.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2V4Y2VsL19iYXNlLnB5) | `91.92% <0%> (+0.11%)` | :arrow_up: |
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `94.1% <0%> (+0.19%)` | :arrow_up: |
| [pandas/core/computation/expr.py](https://codecov.io/gh/pandas-dev/pandas/pull/26704/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tcHV0YXRpb24vZXhwci5weQ==) | `97.8% <0%> (+0.27%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=footer). Last update [d47fc0c...e0d13c6](https://codecov.io/gh/pandas-dev/pandas/pull/26704?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

For my personal edification, why are we filtering these?
Keeps them from polluting the output of ASV runs.

Alternatively, we just remove all the SparseDataFrame / SparseSeries asvs,
or convert them to using DataFrame[sparse] / Series[Sparse]?

On Fri, Jun 7, 2019 at 1:11 PM gfyoung <notifications@github.com> wrote:

> For my personal edification, why are we filtering these?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/26704?email_source=notifications&email_token=AAKAOIUNC3JSM2566JS5O73PZKQFHA5CNFSM4HVWCALKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXGSZRQ#issuecomment-499985606>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAKAOIT4R4CV454P5IQP74TPZKQFHANCNFSM4HVWCALA>
> .
>

> Alternatively, we just remove all the SparseDataFrame / SparseSeries asvs,
or convert them to using DataFrame[sparse] / Series[Sparse]?

should do this, can open an issue?

is this mergable (or failing for some other reason)?
Updated to remove the filter and change the SparseSeries / SparseFrame tests to use regular dataframe / series.
FYI, all green if anyone has a chance to take a quick look.
+1 on this, though means we lose asv's on previous versions for sparse (which I think is ok). 

cc @topper-123 @qwhelan 
+1 for me. Logical step, now that sparse(DataFrame|Series) is deprecated.
+1, if loss of old benchmark comparisons is a concern it would probably make sense to set up a regular backfill job on the speed site. `asv` could make this quite a bit easier, but just covering every major point release would go pretty far. Happy to work on this starting in about a week if there's interest.
thanks @TomAugspurger