CLN: Excel Module Cleanups pandas-dev #25271
State: closed

- [X] closes #25271 
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`



Labels:
name: IO Excel
description: read_excel, to_excel

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=h1) Report
> Merging [#25340](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/83fe6ca422ecc35f311897abedadcc492b2a0777?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25340/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #25340      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         173      173              
  Lines       52831    52830       -1     
==========================================
- Hits        48457    48456       -1     
  Misses       4374     4374
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.28% <100%> (-0.01%)` | :arrow_down: |
| #single | `41.72% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/excel/\_util.py](https://codecov.io/gh/pandas-dev/pandas/pull/25340/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2V4Y2VsL191dGlsLnB5) | `80.64% <ø> (ø)` | :arrow_up: |
| [pandas/io/excel/\_base.py](https://codecov.io/gh/pandas-dev/pandas/pull/25340/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2V4Y2VsL19iYXNlLnB5) | `92.48% <100%> (-0.04%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=footer). Last update [83fe6ca...985e354](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=h1) Report
> Merging [#25340](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/83fe6ca422ecc35f311897abedadcc492b2a0777?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25340/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #25340      +/-   ##
==========================================
- Coverage   91.72%   91.72%   -0.01%     
==========================================
  Files         173      173              
  Lines       52831    52830       -1     
==========================================
- Hits        48457    48456       -1     
  Misses       4374     4374
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.28% <100%> (-0.01%)` | :arrow_down: |
| #single | `41.72% <0%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/excel/\_util.py](https://codecov.io/gh/pandas-dev/pandas/pull/25340/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2V4Y2VsL191dGlsLnB5) | `80.64% <ø> (ø)` | :arrow_up: |
| [pandas/io/excel/\_base.py](https://codecov.io/gh/pandas-dev/pandas/pull/25340/diff?src=pr&el=tree#diff-cGFuZGFzL2lvL2V4Y2VsL19iYXNlLnB5) | `92.48% <100%> (-0.04%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=footer). Last update [83fe6ca...985e354](https://codecov.io/gh/pandas-dev/pandas/pull/25340?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Thanks for the interest and doing a PR! Unfortunately there is already another one for this so will stick with that one since it came first. 

Sent from my iPhone

> On Feb 16, 2019, at 4:13 AM, codecov[bot] <notifications@github.com> wrote:
> 
> Codecov Report
> 
> Merging #25340 into master will decrease coverage by <.01%.
> The diff coverage is 100%.
> 
> 
> @@            Coverage Diff             @@
> ##           master   #25340      +/-   ##
> ==========================================
> - Coverage   91.72%   91.72%   -0.01%     
> ==========================================
>   Files         173      173              
>   Lines       52831    52830       -1     
> ==========================================
> - Hits        48457    48456       -1     
>   Misses       4374     4374
> Flag	Coverage Δ	
> #multiple	90.28% <100%> (-0.01%)	⬇️
> #single	41.72% <0%> (ø)	⬆️
> Impacted Files	Coverage Δ	
> pandas/io/excel/_util.py	80.64% <ø> (ø)	⬆️
> pandas/io/excel/_base.py	92.48% <100%> (-0.04%)	⬇️
> Continue to review full report at Codecov.
> 
> Legend - Click here to learn more
> Δ = absolute <relative> (impact), ø = not affected, ? = missing data
> Powered by Codecov. Last update 83fe6ca...985e354. Read the comment docs.
> 
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.

closing in favor of #25275