BrandonFors/pandas-github-issues huggingface dataset:
CI: Run all GHA checks on backport branch
State: closed

- [ ] closes #39696
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

cc @simonjayhawkins 

How this was tested

I made a fake 1.3.x branch which is actually just a copy of master.

I applied these changes, and GHA triggered on my fork. I also verifyed that Installing the ssh key and uploading docs were skipped.
See the run here.
https://github.com/lithomas1/pandas/runs/3081634451?check_suite_focus=true


Labels:
name: CI
description: Continuous Integration

Comments:
Thanks @lithomas1 
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.3.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 de34ca33f4bade13ffca17cd24e04a71688bae41
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #42556: CI: Run all GHA checks on backport branch'
```

4. Push to a named branch :

```
git push YOURFORK 1.3.x:auto-backport-of-pr-42556-on-1.3.x
```

5. Create a PR against branch 1.3.x, I would have named this PR:

> "Backport PR #42556 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
Revert "REGR: concat(ints, bools) casting to object #42092"
State: closed

Reverts pandas-dev/pandas#42541

This fails ArrayManager. 

cc @jbrockmendel 

Labels:

Comments:
The solution is to _fix_ it for ArrayManager
This is just temporary, so we can get green, while the ArrayManger case is fixed. If the ArrayManager fix is simple, we can always close this and merge that instead. Otherwise, we should probably merge this after a couple of days so that CI remains green, and re-land #42541
ok why don't we wait a day or 2 to see if can fix ArrayManager here.
I think this just needs a change in `concat_arrays` in the `not single_dtype` case
Gonna close since I think an actual fix has been sent in now.
CLN: clean sqlalchemy import
State: closed

xref #40686


Labels:
name: Refactor
description: Internal refactoring of code
name: IO SQL
description: to_sql, read_sql, read_sql_query

Comments:
thanks @fangchenli very nice as always!
Just a note: this broke our tests where we were passing a mock in as a SQLite conn, which with this change leads to the SQLAlchemy import being attempted. Worked around by setting `conn_mock.__class__ = sqlite3.Connection` to fool the `isinstance()` check.
TYP: Make components of Suffixes Optional
State: closed

The documentation on the parameters that actually are of type `Suffixes`:

> *suffixeslist-like, default is (“_x”, “_y”)*
> A length-2 sequence where each element is optionally a string indicating the suffix to add to overlapping column names in left and right respectively. _**Pass a value of None**_ instead of a string to indicate that the column name from left or right should be left as-is, with no suffix. At least one of the values must not be None.


Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
Yes, still interested in this.
@scravy pls merge master and can have a look
Do you prefer rebasing or merging from master?
either are fine
@jreback I rebased. 
thanks @scravy
Backport PR #42539 on branch 1.3.x (Revert "CI: runtime warning in npdev build")
State: closed

Backport PR #42539: Revert "CI: runtime warning in npdev build"

Labels:
name: CI
description: Continuous Integration

Comments:
Hmm. This actually xpasses on 3.8 npdev as well in addition to Python 3.9, hence the CI failure. Maybe the solution is to just remove the xfail altogether. Unfortunately, without #42538 backported, we won't know, since master has no 3.8 np dev job anymore.

I think we should wait on this one for a while. If a better solution comes up, we can always close this and backport that one.
> Hmm. This actually xpasses on 3.8 npdev as well in addition to Python 3.9, hence the CI failure. Maybe the solution is to just remove the xfail altogether. Unfortunately, without #42538 backported, we won't know, since master has no 3.8 np dev job anymore.
> 
> I think we should wait on this one for a while. If a better solution comes up, we can always close this and backport that one.

you can also do a PR against the 1.3.x branch directly and see
OK, this seems to also xpass on 3.8 npdev(1.3.x branch). I'll try to send in a PR soonish.
REGR: concat(ints, bools) casting to object #42092
State: closed

- [x] closes #42092
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry


Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
@jreback @jbrockmendel I think this pull request added a test(``test_concat_bool_with_int``) that is failing with ArrayManager. See https://github.com/pandas-dev/pandas/actions/workflows/ci.yml where the last few runs are all failing. 

Can this be reverted?
Revert "CI: runtime warning in npdev build"
State: closed

Reverts pandas-dev/pandas#42413

Test passing on 3.9 numpydev again?
Numpydev is red again b/c of this I think.


Labels:
name: CI
description: Continuous Integration

Comments:
@meeseeksdev backport 1.3.x
thanks @lithomas1 
Something went wrong ... Please have  a look at my logs.
CI: Run some checks on push on 1.3.x
State: closed

- [ ] xref #39696
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

Not turning on CI/Checks since that one is non-trivial since it requires configuring the doc build to not upload on 1.3.x.


Labels:
name: CI
description: Continuous Integration

Comments:
thanks @lithomas1 
Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

```
$ git checkout 1.3.x
$ git pull
```

2. Cherry pick the first parent branch of the this PR on top of the older branch:
```
$ git cherry-pick -m1 f61347bfb48862b8657c59f63bce6d9c16119e44
```

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

```
$ git commit -am 'Backport PR #42538: CI: Run some checks on push on 1.3.x'
```

4. Push to a named branch :

```
git push YOURFORK 1.3.x:auto-backport-of-pr-42538-on-1.3.x
```

5. Create a PR against branch 1.3.x, I would have named this PR:

> "Backport PR #42538 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to [suggest an improvement](https://github.com/MeeseeksBox/MeeseeksDev).
                
can you push the backport PR as well @lithomas1 ty
TST: Test reindex w/ multiindex df (GH21247)
State: closed

- [x] closes #21247
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Whats new:
Add a test to `pandas/tests/indexes/multi/test_reindex.py`



Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
Hello @mroeschke this is my first PR to the main code base. 

The CI failed because of a timeout:

`##[error]The job running on agent Azure Pipelines 2 ran longer than the maximum time of 60 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134`

I'm not sure what I should be doing to fix this issue. Is there a standard procedure?

Thanks.
thanks @calvh
CI: Test Python dev on 1.3.x PRs
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: CI
description: Continuous Integration
name: Python 3.10

Comments:
Thanks @lithomas1
Backport PR #42524 on branch 1.3.x (CI: Xfail less on Python 3.10)
State: closed

Backport PR #42524: CI: Xfail less on Python 3.10

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: CI
description: Continuous Integration
name: Python 3.10

Comments:
Oooooh, Python Dev workflow isn't running on 1.3.x PRs, only PRs against master, but I looked on master and this seems to be passing now. Should I do a PR to enable Python Dev on 1.3.x?
yes!
CI: Xfail less on Python 3.10
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

Thanks realead for fixing the tests.


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: CI
description: Continuous Integration
name: Python 3.10

Comments:
this ok to backport? these were related to @realead patches that we *did* backport?
Yep should be #42135 and #41988 iirc.
great thanks @lithomas1 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
Backport PR #42475 on branch 1.3.x (PERF/REGR: astype changing order of some 2d data)
State: closed

Backport PR #42475: PERF/REGR: astype changing order of some 2d data

Labels:
name: Performance
description: Memory or execution speed performance
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Regression
description: Functionality that used to work in a prior pandas version
name: Reduction Operations
description: sum, mean, min, max, etc.

Comments:
hmm this is failing pre-commit. @mzeitlin11 can you put up a PR which backports this and passes?
Closing for #42526
DOC: Add user_guide examples and docstring example for df.plot.box and df.plot.hist
State: closed

- [x] closes #42492
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Docs
name: Visualization
description: plotting

Comments:
thanks @charlesdong1991
BUG: Fix multi-index colname references in read_csv c engine.
State: closed

This fixes an issue with the read_csv c engine when the input has more than one header row and arguments to dtype, na_values, or converters reference multi-index column names as tuples.

- [x] closes #42446
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

I added a whatsnew entry for v1.4.0 since that's what other recent bug fixes have done, but I'm not yet sure of the criteria for that. Is it appropriate to add it for whichever release "owns" master?

Labels:
name: Bug
name: IO CSV
description: read_csv, to_csv
name: MultiIndex

Comments:
cc @gfyoung if you'd have a look
Regarding the failed check -- I've run the test _tests/scalar/timedelta/test_arithmetic.py_ and it's passing locally.  If it's an issue in my branch I will work to fix it but it seems this might be an environmental error ?
thanks @jmcomie 

failed check is not related
read_excel() modifies provided types dict when accessing file with duplicate column
State: closed

- [x] closes #42462
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry


Labels:
name: Bug
name: IO Excel
description: read_excel, to_excel

Comments:
The dict is being changed below. Preventing this will require a bigger change.

https://github.com/pandas-dev/pandas/blob/3c10f1f7da63f47d086b127c47fe9aca215d98e1/pandas/io/parsers/python_parser.py#L428-L434
This was introduced in #41411. You can try changing the modified Code there to avoid this and you can use the Tests I have added there 
please review
HI @phofl @jreback @mzeitlin11 - do you mind taking a look, if this is okay now?
I‘ll have a look shortly 
Hi @jreback @phofl could you pls take a look, if this is fine?
Lets do this for 1.3.2, was a regression 
Hello @debnathshoham! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:







There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-08-04 14:23:43 UTC
I have added the whatsnew entry in 1.3.2 as @phofl suggested.
@jreback Greenish (unrelated failures). 
thanks @debnathshoham 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
ENH - Improved error message for interpolating IntegerArrays (#41565)
State: closed

- [X] closes #41565
~~- [ ] tests added / passed~~
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [X] whatsnew entry

This PR improves the error message when trying to interpolate dtype integer with method="linear", as discussed in #41565.

Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Error Reporting
description: Incorrect or improved errors from pandas
name: NA - MaskedArrays
description: Related to pd.NA and nullable extension arrays
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
Thanks for the pr, going to close for now as stale, but please ping to reopen if you'd like to continue working on it!
Omerdan03 bug pd.series.rename #42481
State: closed

- [ ] closes #42481
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

https://github.com/pandas-dev/pandas/issues/42481

Labels:
name: Bug
name: Series
description: Series data structure
name: Stale

Comments:
Thanks for the pr @Omerdan03. Can you please add tests?
I'm not 100% confident people *weren't* relying on this returning something. If we're going to change this, we should have a deprecation cycle.

But see https://github.com/pandas-dev/pandas/issues/16529 for a larger issue around inplace. I'd prefer not to have multiple deprecations around this keyword.
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
Thanks for the PR, but appears this PR has gone stale and the change still need more discussion on the original issue. Closing, but happy to have you contribute on other issues!
TYP: npt.NDarray
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

cc @simonjayhawkins 

Labels:
name: Typing
description: type annotations, mypy/pyright type checking

Comments:
Thanks @jbrockmendel
CI: add back xfail for flaky chunksize test
State: closed

This reverts the part of #42174 that (optimistically it turns out) removed the xfail for a `ResourceWarning` with the python parser. 


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO CSV
description: read_csv, to_csv
name: CI
description: Continuous Integration

Comments:
sure
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
REGR: to_dict(orient={"records", "split", "dict"}) slowdown
State: closed

- [x] closes #42352
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Regression was due to each scalar value hitting `is_datetime_or_timedelta_dtype` -> `_is_dtype_type` where it falls most of the way through.


Labels:
name: Performance
description: Memory or execution speed performance
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Regression
description: Functionality that used to work in a prior pandas version

Comments:
pls
run a lot of asvs

this is a very hot path and don't want to affect other things 
> this is a very hot path and don't want to affect other things

EDIT: The function modified is `maybe_box_native` (added in #37648), and I can only find it hit in `to_dict` paths

`to_dict` asvs:
```
       before           after         ratio
     [87d78559]       [614a926a]
     <master>         <regr_to_dict_perf>
-        484±10ms          168±2ms     0.35  frame_methods.ToDict.time_to_dict_datetimelike('dict')
-         479±3ms          164±3ms     0.34  frame_methods.ToDict.time_to_dict_datetimelike('records')
-         465±4ms          159±9ms     0.34  frame_methods.ToDict.time_to_dict_datetimelike('split')
-         149±2ms         21.6±2ms     0.15  frame_methods.ToDict.time_to_dict_ints('records')
-         141±6ms       13.7±0.4ms     0.10  frame_methods.ToDict.time_to_dict_ints('dict')
-         135±6ms       12.9±0.4ms     0.10  frame_methods.ToDict.time_to_dict_ints('split')
```
no run all the asvs

or at the very least casting and construction ones 
> no run all the asvs
> 
> or at the very least casting and construction ones

Sorry, please see comment above, just edited
thanks @mzeitlin11 
@meeseeksdev backport 1.3.x
Something went wrong ... Please have  a look at my logs.
REF: implement Index._get_indexer_strict
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

xref #27181, a couple more steps to get that all the way accomplished

Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: MultiIndex

Comments:
rebased + greenish
@jreback gentle ping, this unblocks the last 2 MultiIndex PRs on deck
Improve boolean indexing docs
State: closed

- [ X] closes #42384
- [ X] tests added / passed
- [ X] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ X] whatsnew entry


Labels:
name: Docs
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
Thanks for the PR, but it appears to have gone stale. This was close, but if you could push some small updates based on the review we would be happy to accept this PR. Closing in the meantime.
ENH: Styler.bar height control
State: closed

- [x] closes #36419 
- [x] tests added / passed
- [x] whatsnew entry

I originally thought the issue was too complicated to code for such a small feature, but turns out it was only one or two lines of coding, so I added it in. Quite a nice addition for visualisations I think.

![Screen Shot 2021-07-11 at 17 23 59](https://user-images.githubusercontent.com/24256554/125200903-309f7000-e26d-11eb-8ae8-1b12d83523e4.png)


Labels:
name: Styler
description: conditional formatting using DataFrame.style

Comments:
can you rebase
done, note the change to keyword only args.
thanks, IIRC elsewhere you are going to followon with a check for invalid height?
TST: verify numpy.ravel works on a list of DataFrames with specified column names (#26247)
State: closed

- [x] closes  #26247
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [ ] whatsnew entry

Inserted test to verify that np.ravel can be used on DataFrames with specified column names.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Compat
description: pandas objects compatability with Numpy or Python functions

Comments:
Hello @usersblock! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2021-07-11 05:18:47 UTC
Thanks for the pr @usersblock. Some comments, plus test you added is failing
@usersblock please don't use the CI to try to get tests passing - see https://pandas.pydata.org/docs/development/ for how to run tests locally to make sure they pass
@jreback @mzeitlin11 
My bad for doing that. There was one part of the workflow I might not understand. 
```
# this works - list of DataFrames without column names
np.ravel([pd.DataFrame(batch.reshape(1,3)) for batch in x])

# this also works - single DataFrame with column names
np.ravel(pd.DataFrame(x[0].reshape(1,3), columns=["x1", "x2", "x3"]))

# this doesn't work - list of DataFrames with column names
np.ravel([pd.DataFrame(batch.reshape(1,3), columns=["x1", "x2", "x3"]) for batch in x])
```
From the following code from the issue, the third np.ravel fails py38_macos and py38_np18. It passes on my local environment, py39 and py38_32bit. Could this be a compatibility issue?
I'd check the numpy versions on each of the runs - that seems like the most likely candidate for a difference like this
Numpy 1.18.5 is the culprit for the failing tests. Perhaps the original issue should be reclassified as a bug fix for compatibility issues.
BUG: string slicing on MultiIndex DatetimeIndex level
State: closed

- [ ] closes #xxxx
- [x] tests added / passed
- [x] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them
- [x] whatsnew entry

Original motivation was to get rid of _get_partial_string_timestamp_match_key.

Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: MultiIndex

Comments:
rebase. plus this does look like a user facing change.
Rebased, what’s new added, green
looks fine, can you rebase
rebased + green