Backport PR #25262 on branch 0.24.x (REF/TST: resample/test_base.py)
State: closed

Backport PR #25262: REF/TST: resample/test_base.py

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=h1) Report
> Merging [#25718](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=desc) into [0.24.x](https://codecov.io/gh/pandas-dev/pandas/commit/68278a8672a1a15564f0d1b8c04b0ffd1fe2af0c?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25718/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           0.24.x   #25718   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52430    52430           
=======================================
  Hits        48443    48443           
  Misses       3987     3987
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.83% <ø> (ø)` | :arrow_up: |
| #single | `42.9% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=footer). Last update [68278a8...9ff83de](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=h1) Report
> Merging [#25718](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=desc) into [0.24.x](https://codecov.io/gh/pandas-dev/pandas/commit/68278a8672a1a15564f0d1b8c04b0ffd1fe2af0c?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/25718/graphs/tree.svg?width=650&token=eZ4WkYLtcO&height=150&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           0.24.x   #25718   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52430    52430           
=======================================
  Hits        48443    48443           
  Misses       3987     3987
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.83% <ø> (ø)` | :arrow_up: |
| #single | `42.9% <ø> (ø)` | :arrow_up: |


------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=footer). Last update [68278a8...9ff83de](https://codecov.io/gh/pandas-dev/pandas/pull/25718?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@TomAugspurger why does this need to be backported? For the collection problems?
Yeah. But if we decide to keep 0.24.x pinned at the older pytest, then this
is unnecessary.

On Wed, Mar 13, 2019 at 4:56 PM Joris Van den Bossche <
notifications@github.com> wrote:

> @TomAugspurger <https://github.com/TomAugspurger> why does this need to
> be backported? For the collection problems?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/25718#issuecomment-472621851>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIm0-DcCQDYIpLly65es496DsW02Hks5vWXQWgaJpZM4bwLLl>
> .
>

@TomAugspurger : if this does solve the collection problem, we can close #25197.
is this mergable or should close?
let's see if this works