BrandonFors/pandas-github-issues huggingface dataset:
ENH: Series.append now has ignore_index kw
State: closed

- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [x] whatsnew entry

not sure if there is any reason we haven't supported...


Labels:
name: Enhancement
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13677?src=pr) is **84.38%**

> Merging [#13677](https://codecov.io/gh/pydata/pandas/pull/13677?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13677   diff @@
==========================================
  Files           142        142          
  Lines         51223      51223          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43224      43224          
  Misses         7999       7999          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [6b9cd15...4bc7b54](https://codecov.io/gh/pydata/pandas/compare/6b9cd15f6a655b1ade2c571e32e142bf56dde769...4bc7b54fba5b51dc6521129698fe6110f867930d?src=pr)

lgtm. just minor test comment.

updated test, and now green.

thanks!
TST: assert message shows unnecessary diff
State: closed

- [x] passes `git diff upstream/master | flake8 --diff`

removed unnecessary trailing `None`. 

```
pd.util.testing.assert_index_equal(pd.Index([1, 2, 3]), pd.Index([1 ,2, 4]))
# AssertionError: Index are different
# 
# Index values are different (33.33333 %)
# [left]:  Int64Index([1, 2, 3], dtype='int64')
# [right]: Int64Index([1, 2, 4], dtype='int64')None
```


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13676?src=pr) is **84.38%**

> Merging [#13676](https://codecov.io/gh/pydata/pandas/pull/13676?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13676   diff @@
==========================================
  Files           142        142          
  Lines         51223      51223          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43223      43224     +1   
+ Misses         8000       7999     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d7c028d...bdfd2cc](https://codecov.io/gh/pydata/pandas/compare/d7c028d4965932160fa3b69f56c716b1454c42a5...bdfd2cc3f390e3d407203548d5eaea453f86075a?src=pr)

yes this was annoying!
DOC: resample warnings
State: closed

- [ ] closes #13618, closes #13520
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

Prevents warnings triggered by IPython by matching against `'_repr'` or `'_ipython'`, and expands the `resample` warning message to indicate what caused the deferred object to be materialized.


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: Resample
description: resample method

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13675?src=pr) is **84.38%**

> Merging [#13675](https://codecov.io/gh/pydata/pandas/pull/13675?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **0.16%**

``` diff
@@             master     #13675   diff @@
==========================================
  Files           141        142     +1   
  Lines         51185      51225    +40   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43275      43226    -49   
- Misses         7910       7999    +89   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [506520b...c1f7727](https://codecov.io/gh/pydata/pandas/compare/506520bd35331aa82db50686c07d96594cac0c10...c1f77271ad77c87cd590a14fc120833e6a185db3?src=pr)

lgtm. I would add at the very least a bug fix note. I don't think anything is warranted unless you think a user would be suprised by the change in deprecation warning.

@jreback  - added a doc note - not sure why travis didn't run, but that's the only change.  I didn't think there needs to be any doc change on the deprecation warning, it's basically saying the same thing, just more verbose.

thanks!
CLN: Replace float64_t with int64_t in _ensure_components
State: closed

- [x] passes `git diff upstream/master | flake8 --diff`


Labels:
name: Timedelta
description: Timedelta data type
name: Clean

Comments:
I would be surprised if this works
the issue is overflow on non 64bit platforms 

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13673?src=pr) is **84.38%**

> Merging [#13673](https://codecov.io/gh/pydata/pandas/pull/13673?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13673   diff @@
==========================================
  Files           142        142          
  Lines         51223      51223          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43223      43224     +1   
+ Misses         8000       7999     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d7c028d...6854086](https://codecov.io/gh/pydata/pandas/compare/d7c028d4965932160fa3b69f56c716b1454c42a5...685408638107693e8693ab6e1db9f6b51bff4221?src=pr)

I feel all number (`_d`, `_h`, or etc.) is smaller than `ivalue`(int64_t), so if problem happens on non 64bit platforms, float64_t does not solve problems.

thanks!
CLN: removed setter method of categorical's ordered attribute
State: closed

Deprecated back in `0.16.0` <a href="https://github.com/pydata/pandas/pull/9611">here</a>.


Labels:
name: Categorical
description: Categorical Data Type
name: Clean

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13671?src=pr) is **84.38%**

> Merging [#13671](https://codecov.io/gh/pydata/pandas/pull/13671?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **<.01%**

``` diff
@@             master     #13671   diff @@
==========================================
  Files           142        142          
  Lines         51223      51220     -3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43223      43221     -2   
+ Misses         8000       7999     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d7c028d...58938e7](https://codecov.io/gh/pydata/pandas/compare/d7c028d4965932160fa3b69f56c716b1454c42a5...58938e74f34008eda753aacf14c478186c6cce20?src=pr)

@sinhrks : added the test to check for `AttributeError`, and Travis still passing.  Ready to merge if there are no other concerns.

thanks!

side note, can you catch these warnings (prob need to fix code to not have them emitted).

```
[Mon Jul 18 21:44:13 ~/pandas]$ nosetests  pandas/tests/test_categorical.py
........................................................../Users/jreback/pandas/pandas/core/internals.py:1493: FutureWarning: reshape is deprecated and will raise in a subsequent release. Please use .values.reshape(...) instead
  mask = mask.reshape(new_values.shape)
....................................................../Users/jreback/pandas/pandas/tests/test_categorical.py:4125: FutureWarning: 
Setting NaNs in `categories` is deprecated and will be removed in a future version of pandas.
  cat_exp = Categorical(["a", "b", "a"], categories=["a", "b", np.nan])
....................../Users/jreback/pandas/pandas/indexes/category.py:130: FutureWarning: 
Setting NaNs in `categories` is deprecated and will be removed in a future version of pandas.
  data = data.set_categories(categories)
.
----------------------------------------------------------------------
Ran 135 tests in 1.215s

OK
```

@jreback : probably something in the code would be the better fix in the future, but catching them makes sense FTTB.  If I have time later, I'll give it a shot.

thanks!
CLN: removed pandas.sandbox
State: closed

Deprecated back in `0.16.0` <a href="https://github.com/pydata/pandas/pull/9615">here</a>, and the module seems to be rarely, if at all, used according to @jorisvandenbossche .


Labels:
name: Deprecate
description: Functionality to remove in pandas
name: Clean

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13670?src=pr) is **84.51%**

> Merging [#13670](https://codecov.io/gh/pydata/pandas/pull/13670?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **0.13%**

``` diff
@@             master     #13670   diff @@
==========================================
  Files           142        141     -1   
  Lines         51223      51142    -81   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43224      43224          
+ Misses         7999       7918    -81   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [ada6bf3...5a397a2](https://codecov.io/gh/pydata/pandas/compare/ada6bf350f7fd4daaf2b80188ca165fb9543a252...5a397a229bbb480fae0e25b46c04860ae363ab7c?src=pr)

@sinhrks : made the requested doc comments (no need to run Travis tests again hence the `[ci skip]`), so ready to merge if there are no other concerns.

thank you sir!
CLN: removed the 'diff' method for Index
State: closed

Deprecated all the way back in `0.15.0` <a href="https://github.com/pydata/pandas/pull/8227">here</a>.


Labels:
name: Deprecate
description: Functionality to remove in pandas

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13669?src=pr) is **84.52%**

> Merging [#13669](https://codecov.io/gh/pydata/pandas/pull/13669?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13669   diff @@
==========================================
  Files           141        141          
  Lines         51145      51144     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43233      43232     -1   
  Misses         7912       7912          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [8acfad3...7dca659](https://codecov.io/gh/pydata/pandas/compare/8acfad343c88760a6d09fea221996dd50393fa8a...7dca65980f0245e4602e42393bdb9e715a6efe93?src=pr)

ty!
MAINT: Make pandasSQL_builder private
State: closed

Per discussion with @jorisvandenbossche <a href="https://github.com/pydata/pandas/pull/13611#discussion_r71048508">here</a>.


Labels:
name: API Design
name: IO SQL
description: to_sql, read_sql, read_sql_query

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13668?src=pr) is **84.38%**

> Merging [#13668](https://codecov.io/gh/pydata/pandas/pull/13668?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13668   diff @@
==========================================
  Files           142        142          
  Lines         51223      51223          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43223      43223          
  Misses         8000       8000          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [d7c028d...8183e04](https://codecov.io/gh/pydata/pandas/compare/d7c028d4965932160fa3b69f56c716b1454c42a5...8183e04d63319dd3c67a5b32ca2feeb9ebf98028?src=pr)

@sinhrks , @jorisvandenbossche , @jreback : any updates on this?  Seems relatively trivial to merge.

lgtm. @jorisvandenbossche 

Sorry for the delay. 
I did a quick search on github, and few people did actually use this in their code (and that were not copies of pandas), so not sure this is worth to change. 
I meant we should have made it internal when it was added in 0.14, but not sure if it is worth to change.

@jorisvandenbossche : Ah, that's a good point.  If the intention was internal, but people are actually using this function for their own `pandas` engines, I wonder if we should even make it internal at all.  It seems like it could be useful for people's own custom usages then.

Yep, then we just let it be :-)

Sorry for my inclarity triggering you to action

No worries.  Good that we at least investigated.
BUG: construction of Series with integers on windows not default to int64
State: closed

closes #13646


Labels:
name: Bug
name: Windows
description: Windows OS

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13661?src=pr) is **84.38%**

> Merging [#13661](https://codecov.io/gh/pydata/pandas/pull/13661?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13661   diff @@
==========================================
  Files           142        142          
  Lines         51235      51235          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43234      43233     -1   
- Misses         8001       8002     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [0a70b5f...e26f9bf](https://codecov.io/gh/pydata/pandas/compare/0a70b5fef3ae2363fea040ea47dd52247811c8c8...e26f9bfc20d8dce22680b6694d5e3d3b57dbb0c3?src=pr)
BUG: concat/append misc fixes
State: closed

closes #13626 
closes #7795


Labels:
name: Bug
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: API Design

Comments:
whoosh! you really cleaned this up!

had a quick look, but will look deeper later.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13660?src=pr) is 85.26% (diff: 97.05%)

> Merging [#13660](https://codecov.io/gh/pydata/pandas/pull/13660?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13660   diff @@
==========================================
  Files           139        139          
  Lines         50562      50506    -56   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43116      43066    -50   
+ Misses         7446       7440     -6   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [59524af...85f5d94](https://codecov.io/gh/pydata/pandas/compare/59524af1e90d3dda2d885e711f7258704a020b6d...85f5d9456ebd6c44d84b8def2a515cba62ecf51f?src=pr)

status?

you seem to fix a pivot name propogation issue. is there an issue?

you must have just rebased this!

will look tom.

Yeah let me work on this first, I'll include the cleanup for `CategoricalIndex` in #13767. 

Let you know once ready.

@jreback updated, and ready for review.

@sinhrks looks really nice. just some minor comments and guaranetees that should specify a bit more / use asserts. ping on green.
better error message for non-unique columns
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry

I ran into this error with my code and the error message didn't help me figure out I was dealing with duplicate columns that couldn't be handled. I think this is more helpful


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13656?src=pr) is **84.38%**

> Merging [#13656](https://codecov.io/gh/pydata/pandas/pull/13656?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

``` diff
@@             master     #13656   diff @@
==========================================
  Files           142        142          
  Lines         51235      51237     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43235      43236     +1   
- Misses         8000       8001     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [c9a27ed...fa5ecf1](https://codecov.io/gh/pydata/pandas/compare/c9a27ede0925ddbaa8d3ec9efd3c332a636505cf...fa5ecf1e9906715ab6628e575f1bedaab83fb0ce?src=pr)

can you rebase / update

can you rebase / update?

needs tests. pls reopen / comment if you can update.
DOC/BLD: pin IPython version to 4.2.0 (#13639)
State: closed

xref #13639


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13647?src=pr) is **84.38%**

> Merging [#13647](https://codecov.io/gh/pydata/pandas/pull/13647?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will not change coverage

``` diff
@@             master     #13647   diff @@
==========================================
  Files           142        142          
  Lines         51225      51225          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43225      43225          
  Misses         8000       8000          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [20de266...de50772](https://codecov.io/gh/pydata/pandas/compare/20de2661c8eff66e465248cbe28062eae0e0e3bb...de50772e050d3e860bd82d65cbb08edcf8538f4e?src=pr)

Now it works
CLN: Fix compile time warnings
State: closed

- [x] passes `git diff upstream/master | flake8 --diff`

This commit suppresses these warnings

warning: implicit conversion from enumeration type\
'NPY_DATETIMEUNIT' to different enumeration type\
'PANDAS_DATETIMEUNIT' [-Wenum-conversion]


Labels:
name: Build
description: Library building on various platforms
name: Clean

Comments:
will have to test on windows

Can I ask you to check on windows ? 😃 

cos we have appveyor.yml, u can run it on AppVeyor. though @jreback may have more comprehensive environment.

Can you rerun CI?

thanks!
BF(TST): allow AttributeError being raised (in addition to TypeError) from matplotlib
State: closed

Closes #13570
- [x] tests added / passed
- [x] passes `git diff upstream/master | flake8 --diff`
- [ ] whatsnew entry: imho not worth it?

origin:  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=827938


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Visualization
description: plotting
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
issue here: https://github.com/pydata/pandas/issues/13570
another PR here: https://github.com/pydata/pandas/pull/13573

@jorisvandenbossche shall we just go with @yarikoptic's?

ah, sorry for not searching , thanks @olebole ;) indeed, imho it is better to keep policing mpl to throw some known exception in case of misspecification

Yes, let's indeed go with this one. I will merge one travis passes.

Thanks @yarikoptic !
BUG: Add check for array lengths in from_arrays method (GH13599)
State: closed

- [x] closes #13599 
- [x] whatsnew entry


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: MultiIndex

Comments:
tests!

pls add a whatsnew note for 0.19.0

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13633?src=pr) is **84.38%**

> Merging [#13633](https://codecov.io/gh/pydata/pandas/pull/13633?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **0.04%**

``` diff
@@             master     #13633   diff @@
==========================================
  Files           138        142     +4   
  Lines         51095      51226   +131   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43093      43227   +134   
+ Misses         8002       7999     -3   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [7c357d2...91691de](https://codecov.io/gh/pydata/pandas/compare/7c357d20f6cd0f379790c200e91075a179ebab75...91691dedf1beb37427d1740682098a2a22488b48?src=pr)

Superceded by https://github.com/pydata/pandas/pull/13728
DOC: Add reference to frequency strings
State: closed

- [x] closes #13160 


Labels:
name: Docs
name: Datetime
description: Datetime data dtype

Comments:
lots of places where this can be added.

asfreq, resample, Period, do a search. Once we decide on the text you can update.

## [Current coverage](https://codecov.io/gh/pydata/pandas/pull/13632?src=pr) is **84.38%**

> Merging [#13632](https://codecov.io/gh/pydata/pandas/pull/13632?src=pr) into [master](https://codecov.io/gh/pydata/pandas/branch/master?src=pr) will increase coverage by **0.04%**

``` diff
@@             master     #13632   diff @@
==========================================
  Files           138        142     +4   
  Lines         51095      51223   +128   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43093      43224   +131   
+ Misses         8002       7999     -3   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [7c357d2...b45ae21](https://codecov.io/gh/pydata/pandas/compare/7c357d20f6cd0f379790c200e91075a179ebab75...b45ae21a354d0f9c90af787e84c44b09a64b8715?src=pr)

@jreback please confirm the text once so that I can find and add the same at other places as well.

@jorisvandenbossche lgtm.

@sahildua2305 Thanks a lot!