BrandonFors/pandas-github-issues huggingface dataset:
REGR: ensure numpy fixed-size binary/string arrays are converted to object dtype for Index creation
State: closed

- [X] closes #57645 
- [X] [Tests added and passed] if fixing a bug or adding a new feature
- [X] All [code checks passed].
- [ ] Added [type annotations] to new arguments/methods/functions.
- [X] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file if fixing a bug or adding a new feature.

While using the function set_index with parameter inplace=True, the function would try and create a new index where its dtype would be a FLS `S{value}` dtype, which was not recognized by the function `_dtype_to_subclass` and raised a NotImplementedError. That said , by adding a verification that recognizes FLS dtype , the index is created successfully and the function executes properly.


Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Regression
description: Functionality that used to work in a prior pandas version
name: Index
description: Related to the Index class or subclasses

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
@jorisvandenbossche Hi, sorry to bother you, but would it be possible to get some feedback on this? 
Thank you!
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DOC: Fix reference to rows in `read_csv(index_col)` error message
State: closed

**Description**
The user passes column numbers (not row numbers) as the `index_col` argument to specify an index when calling e.g. `read_csv()`.

**Checklist**
- [x] ~closes #xxxx (Replace xxxx with the GitHub issue number)~ (No Specific Issue)
- [x] ~[Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature~ (No change to functionality)
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [x] ~Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.~ (No new args/methods/functions).
- [x] ~Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.~ (No change to functionality)


Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
Thanks @sparshsah
DOC: ecosystem.md: add pygwalker, add seaborn code example
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
- https://github.com/Kanaries/pygwalker
Thanks @westurner 
Thanks!

On Wed, Mar 27, 2024 at 3:01 PM Matthew Roeschke ***@***.***>
wrote:

> Thanks @westurner <https://github.com/westurner>
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/pandas-dev/pandas/pull/57990#issuecomment-2023735516>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAMNSZZZZ2RPTAD2FXCQSLY2MJQBAVCNFSM6AAAAABFGGZON2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRTG4ZTKNJRGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
PERF: (partial) fix for np_datetime.c performance regression
State: closed

- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).

Fixes (part) of the performance regression seen mentioned in #57951. The main performance improvements are the ~~ ~~refactoring of the "days" parsing logic~~ and the simpler calculation of ifrac.

The days parsing refactoring needed to be reverted. I overlooked an issue that happens for td close to int64 bounds there.

Labels:
name: Performance
description: Memory or execution speed performance
name: Stale

Comments:
cc @WillAyd 
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
DEPR: 'epoch' date format in to_json
State: closed

- [x] closes #57063 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO JSON
description: read_json, to_json, json_normalize
name: Deprecate
description: Functionality to remove in pandas

Comments:
Thanks for taking a look at this!
@WillAyd now that I am warning for the usage of default `date_format`, some examples in the user guide are failing such as:
```python
dfj2 = dfj.copy()
dfj2["date"] = pd.Timestamp("20130101")
...
dfj2.to_json("test.json")
  ```
  What am I supposed to do in this case? Is there a way to suppress this warning without passing `date_format="iso"`? 
Thanks @Aloqeely
BUG: Fix error for `boxplot` when using a pre-grouped `DataFrame` with more than one grouping
State: closed

- [x] closes #14701 
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file if fixing a bug or adding a new feature.

The original bug shows an indexing error when using `boxplot` on a pre-grouped `DataFrame`. For example:

`df.groupby(['X', 'Y']).boxplot()`

This error occurs as multiple groupings are passed as a tuple into the index of a `Series`, which is not allowed. The fix converts the `tuple` to a `string`, which is acceptable as an index to a `Series`.

There are other comments on the bug thread that state "Groupby boxplot is not working even when a single 'by' is used", which is not the case.

I have included in the tests both a single `by` and multiple `by` covering three different methods of plotting a `boxplot` from a `DataFrame`:

1) `df.boxplot(by='X')`
2) `df.boxplot(by=['X','Y'])`
3) `df.plot.box(by='X')`
4) `df.plot.box(by=['X','Y'])`
5) `df.groupby('X').boxplot()`
6) **`df.groupby(['X','Y']).boxplot()`**

Of all of the above, only example 6 required the fix.

Labels:
name: Bug
name: Groupby
name: Visualization
description: plotting

Comments:
> Thanks for the PR! Looking good.

Thanks for the feedback.

I will make the necessary adjustments and update the PR accordingly.
Thanks @thetestspecimen - very nice!
> Thanks @thetestspecimen - very nice!

No Problem @rhshadrach. Thanks for the detailed input and guidance.
Fix `to_timedelta` `np.int32` casting bug with NumPy 2
State: closed

This PR proposes a fix for #56996.  I'd be happy to make adjustments as needed and eventually add a what's new entry to the appropriate file.

- [x] closes #56996
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.
CLN: Enforce deprecations for EA.fillna
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Ref: #53621

Ran into a little trouble here - `NDFrame.fillna` has a `limit` argument that wasn't deprecated and works, but `EA.fillna` has this deprecated and is currently ignored. Currently this PR keeps the `limit` argument in `EA.fillna` and removes the deprecation, but the implementation still ignores it. If we want to keep it, I plan on doing a followup implementing `limit` across all EAs (I think this should be straightforward except for maybe Sparse - not sure). 

As an alternative, we could also deprecate `limit` on `NDFrame.fillna` (not my preference), and then I can keep but not enforce the deprecation on `EA.fillna` here.

cc @jbrockmendel 

Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Clean
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
keeping the limit argument sounds good to me, feel free to merge when ready
Thanks @rhshadrach
DOC Add documentation for how pandas rounds values in Series.round and Dataframe.round methods
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Description: 
In the pandas documentation it is not documented how numbers are rounded if values are exactly halfway between rounded decimal values (they are rounded to the nearest even value). I added the documentation for this behaviour.

Labels:
name: Docs

Comments:
Thanks for the review @MarcoGorelli! Until next time! Bye! 
![Alt Text](https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExNTcxMjhtemtoMnowODNidGFhOGN1Zm5vZHQ0d3JrbmZtazM5MDI0cSZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/NqZn5kPN8VVrW/giphy.gif)
ENH: Add leftsemi merge
State: closed

- [ ] closes #42784 (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

I want to add anti joins as a follow up, which can be incorporated into the new class

Labels:
name: Enhancement
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Closing to clear the queue, but feel free to update and reopen anytime
ENH: set __module__ for pandas scalars (Timestamp/Timedelta/Period)
State: closed

Addresses part of #55178

Labels:
name: Output-Formatting
description: __repr__ of pandas objects, to_string
name: Sprints
description: Sprint Pull Requests

Comments:
Thanks for the PR!

Can you add those new cases to the existing test that was added here: https://github.com/pandas-dev/pandas/pull/55171/files#diff-f2ce09edfcd4e105695b327053c3d288fa9547b1b5cb6488da3f3213e5478870?
There is another failing test that needs to be updated:

https://github.com/pandas-dev/pandas/blob/4f145b3a04ac2e9167545a8a2a09d30856d9ce42/pandas/tests/tslibs/test_timezones.py#L144-L146

The expected `msg` needs to be updated now
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
BUG: Fixed ADBC to_sql creation of table when using public schema
State: closed

Problem: table on public schema being lost when tried to be created

Solution: used db_schema_name argument to specify schema name of adbc_ingest

- [x] closes #57539 (Replace xxxx with the GitHub issue number)
- [x] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Bug
name: IO SQL
description: to_sql, read_sql, read_sql_query
name: Arrow
description: pyarrow functionality
name: Sprints
description: Sprint Pull Requests

Comments:
Very nice PR. Can you also add a whatsnew note for version 2.2.2? Outside of that and @jorisvandenbossche comment this lgtm
Thanks @shabab477
Changed the strings to make code simpler
State: closed

Changed the strings to make code simpler

- [X] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [X] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).



Labels:
name: Benchmark
description: Performance (ASV) benchmarks

Comments:
Thanks @igeni
CLN: Enforce deprecation of argmin/max and idxmin/max with NA values
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.

Ref: #33941, #51276

This is complicated by #57745 - we still need a proper deprecation for groupby's idxmin/idxmax. For DataFrame with EAs and axis=1, we use groupby's implementation. So I'm leaving that deprecation in place for now, and we can enforce it after groupby's is deprecated and ready to be enforced.

Labels:
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Clean
name: Reduction Operations
description: sum, mean, min, max, etc.

Comments:
Thanks @rhshadrach
WEB: Updating active/inactive core devs
State: closed

I've checked with the devs who weren't active in pandas recently to see if they wished to become inactive, and few were happy to become inactive.

Besides to manage expectations of other core devs and the community, this is relevant for the decision making proposed in [PDEP-1](https://github.com/pandas-dev/pandas/pull/53576/files). With the current proposal, the number of maintainers to have a quorum is lowered from 12 to 11 after this PR, and it'll have an impact if more people become a maintainer.

@bashtage I couldn't get an answer from you via email (I sent two emails). If you'd like to remain active that's totally fine, just let me know.

Labels:
name: Admin
description: Administrative tasks related to the pandas project
name: Web
description: pandas website

Comments:
I'm updating the finance workgroup. Wes was the lead but he's becoming inactive, so I'm removing him from the workgroup. @mroeschke I'm adding you as leader of the workgroup, since I think you've been doing most of the work recently (at least approving expenses). If you want to have a discussion with the rest of the workgroup and there is a different outcome, please let me know:

CC: @jreback @jorisvandenbossche @TomAugspurger 
SGTM. If anyone else wants a spot on the finance group I'm more than happy to step aside.
sgtm 
@TomAugspurger I personally don't think it's needed to have many people in the workgroups. I think having a couple of people to have a backup is good, or maybe 3 depending on the workgroup. So, seems reasonable that you step aside even if nobody new takes your spot, we already got Matt, Jeff and Joris.

Also, in the responsibilities we've got for the finance workgroup now we only have "approve the expenses". Not sure if it'd make sense to include requesting the grants and organizing the funds. Maybe in that case it could make sense if @phofl joins it?
> Maybe in that case it could make sense if @phofl joins it?

sgtm
Thanks @datapythonista
BUG: #57954 encoding ignored for filelike
State: closed

- [x] closes #57954 
- [x] [Tests added and passed if fixing a bug or adding a new feature
- [x] All [code checks passed]

Labels:
name: Error Reporting
description: Incorrect or improved errors from pandas
name: IO CSV
description: read_csv, to_csv

Comments:
Thanks @dontgoto
CLN: Enforce verbose parameter deprecation in read_csv/read_table
State: closed

- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [ ] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: IO CSV
description: read_csv, to_csv
name: Clean

Comments:
Thanks @lithomas1 
I have noticed that there is a test in `pandas/tests/io/parser/test_unsupported.py` which still checks for the deprecation warning, will open a PR soon
BUG: Fix na_values dict not working on index column (#57547)
State: closed

- [x] closes #57547
- [x] [Tests added and passed]
- [x] All [code checks passed]
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [x] Added an entry in the latest `doc/source/whatsnew/v3.0.0.rst` file if fixing a bug or adding a new feature.

In the read_csv method, pandas allows having na_values set as a dict, which in such case lets you decide which values are null for each column. In the occurence of one of the columns being `None`, no null values are applied to the column and it remains as it was. This specific case is what is being tested in the issue #57547.

The problem was that in these particular conditions variables `col_na_values` and `col_na_fvalues` were not being set correctly causing a `TypeError`. All i had to do was correctly define these variables as empty sets in an `else` block.

On the python engine this same logic was not yet programmed. I implemented it, by adding an if statement, ensuring na_values are only applied if the column is not `None`.

Labels:
name: IO CSV
description: read_csv, to_csv

Comments:
@rhshadrach Would it be possible to ask someone to review this PR? Thank you
Thanks @tomhoq 
Thank you for the review
DOC: fix closing sq. bracket in pandas.read_fwf example (#57959)
State: closed

- change closing square bracket in colspecs description to correct "]"

- [x] closes #57959 
- [ ] [Tests added and passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#writing-tests) if fixing a bug or adding a new feature
- [x] All [code checks passed](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit).
- [ ] Added [type annotations](https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#type-hints) to new arguments/methods/functions.
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Docs

Comments:
thanks @danlsn
BUG: Inconsistent behavior while constructing a Series with large integers in a int64 masked array
State: closed

- [x] closes #56566 
- [x] [Tests added and passed]
- [x] All [code checks passed]
- [ ] Added [type annotations]
- [ ] Added an entry in the latest `doc/source/whatsnew/vX.X.X.rst` file if fixing a bug or adding a new feature.


Labels:
name: Stale

Comments:
This pull request is stale because it has been open for thirty days with no activity. Please [update](https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request) and respond to this comment if you're still interested in working on this.
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.