BrandonFors/pandas-github-issues huggingface dataset:
DOC: Contributing guide docker expansion
State: closed

Added instructions for creating development environment with docker on windows, mac os and unix.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Build
description: Library building on various platforms
name: Docs

Comments:
Sure, let me know how you’d like it to look. I can shorten it a bit if needed.
How much documentation do we want on installing Docker itself?

Isn't that something we should just link to in Docker's official docs?  Keep in mind that you would have to keep updating this as Docker itself evolves.
IMO just a link to https://docs.docker.com/get-docker/ should be enough, though I'd keep the "**Test your Docker installation**" section because if you don't get that right (e.g. because you still need `sudo` to run `docker run`) then the next part won't work
I'm no Docker expert either, but looks good to me, thanks @fdanieluk for your work on the docs, it really makes it accessible
I agree with @gfyoung here in that we really should just link to the external docs here
Hi @fdanieluk - is this still active?
Closing as stale, but please ping if you'd like to continue working on this
Plotting Tables x-axis labels display
State: closed

Added x-axis labels on top. Adjusted figure sizes in order to have the complete table visible in the user guide.

Labels:
name: Docs

Comments:
@marydmit you already have an open PR for this at https://github.com/pandas-dev/pandas/pull/34884 ?
Sorry, I may have done something wrong! I was working on another issue in the visualization rst, submitted a PR, then worked on the plotting tables part in the same doc. I am new to this, so not sure if this should be in the same PR or two different ones?
Yes, it seems that #34884 includes everything from this branch. If you intended to keep them separate, you should make sure to reset to `master` when you open a new branch - I usually do
```bash
git checkout -b <my new branch>
git fetch upstream master
git reset --hard upstream/master
```
just to be sure

For this time I think it's OK to carry on in the other PR :)
Closing as it's been taken forward in #34884
DOC: add mention of recommended dependencies in users guide
State: closed

First-time contributor here!

Ian Ozsvald mentioned installing the optional dependencies for pandas in his talk at PyData Amsterdam 2020. Although these are mentioned in the Getting Started section, I though they should be mentioned in the Users Guide, which is where I typically go for pandas information. It seems like many users aren't aware that these dependencies are available to increase performance.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
Sorry, I meant to make the second commit a separate pull request. Let me figure out how to fix that.
> Sorry, I meant to make the second commit a separate pull request. Let me figure out how to fix that.

fixed it!
Thanks!
I'm glad I could contribute!
TST: IntegerNA Support for DataFrame.diff()
State: closed

- [x] closes #24171
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

Test for IntegerNA support DataFrame.diff().
``` bash
pytest tests/frame/methods/test_diff.py::TestDataFrameDiff::test_diff_integer_na
```


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
looks good (will merge shortly, trying to get master to run first).
thanks @Marvzinc
DOC: document support for in-memory HDFStore GH33166
State: closed

I currently have added to the docstring that **kwargs passes its parameters to
PyTables. Maybe this is too much but I also added an example using **kwargs,
passing the driver paramter to create an in-memory HDFStore.

Furthermore, I have added HDFStore class to the reference api, as it was not
autogenerated and also made **kwargs more clear that it passes its parameters
to PyTables.

Added in the cookbook the method of creating in-memory HDFStores, including
an example.

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

closes #33166 

Labels:
name: Docs
name: IO HDF5
description: read_hdf, HDFStore

Comments:
@dennisbakhuis this looks good, I added the original original issue ref. this is failing the docs build, try to build this page to repro, here are the errors

```
/home/runner/miniconda3/envs/pandas-dev/lib/python3.8/site-packages/IPython/sphinxext/ipython_directive.py:1023: UserWarning: Code input with no code at /home/runner/work/pandas/pandas/doc/source/user_guide/computation.rst, line 624
  warnings.warn(message)
/home/runner/miniconda3/envs/pandas-dev/lib/python3.8/site-packages/IPython/sphinxext/ipython_directive.py:1023: UserWarning: Code input with no code at /home/runner/work/pandas/pandas/doc/source/user_guide/merging.rst, line 1554
  warnings.warn(message)
/home/runner/work/pandas/pandas/pandas/io/pytables.py:docstring of pandas.HDFStore:32: WARNING: Unexpected indentation.
looking for now-outdated files... none found
/home/runner/work/pandas/pandas/pandas/io/pytables.py:docstring of pandas.HDFStore:33: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/runner/work/pandas/pandas/pandas/io/pytables.py:docstring of pandas.HDFStore:62: WARNING: Inline strong start-string without end-string.
pickling environment... done
/home/runner/work/pandas/pandas/doc/source/reference/api/pandas.HDFStore.filename.rst: WARNING: document isn't included in any toctree
checking consistency... done
preparing documents... d
```
The error came from adding the base class to the api reference, so I removed that part.

Onky changes now are in the doc strings and the cookbook. 
thanks @dennisbakhuis
Deprecate `center` on `df.expanding`
State: closed

`df.expanding(center=True)` currently returns non-sensical results and it is unclear what results would be expected. It was previously removed in #7934 for that same reason,but was reintroduced for unclear reasons in a later refactoring

- [x] closes #20647
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Deprecate
description: Functionality to remove in pandas
name: Window
description: rolling, ewma, expanding

Comments:
you will either have to explicity set `center=None` for expanding tests, or use a `@pytest.mark.filterwarnings("...")` for this specific warning (this is ok to do)
Hello @MBrouns! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:











There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-07-07 14:22:09 UTC
@jreback If I understood correctly you mean the change I made in https://github.com/pandas-dev/pandas/pull/34887/commits/f47dedebac6b43c1678ba183305277423e5a24d9
> @jreback If I understood correctly you mean the change I made in [f47dede](https://github.com/pandas-dev/pandas/commit/f47dedebac6b43c1678ba183305277423e5a24d9)

yep
@jreback anything that still needs to happen here?
@MBrouns  pls rebase and resolve conflicts, and make CI green. otherwise, it's unlikely that @jreback will review this PR
@charlesdong1991 the test failures seem to be unrelated to this PR and also seem to happen on master
@MBrouns  hey, after a quick skim, i think the linting failure is indeed on master, which will be fixed by #35007 

but i think for this PR, still need to make changes for the test in `pandas/tests/window/test_expanding.py` or other test files in which the test uses `expanding` and raises the warning. 

you need to either catch or ignore the warnings for the test, see https://github.com/pandas-dev/pandas/pull/34887/checks?check_run_id=810672133
thanks @MBrouns very nice
TST: Ensure dtypes are set correctly for empty integer columns #24386
State: closed

- [x ] closes #24386
- [x ] tests added / passed
- [x ] passes `black pandas`
- [x ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x ] added tests to verify whether empty integer columns are loaded in as integer columns


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Constructors
description: Series/DataFrame/Index/pd.array Constructors

Comments:
Thanks. Can I add the test at the bottom of the `class TestDataFrameConstructors` in `tests/frame/test_constructors.py` or should I add it in a specific section of the class?
thanks @avinashpancham
DOC: Fixed table formatting in box plot section
State: closed

[DOC]fixed table formatting in the box plot section keeing simple rst table format

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Docs

Comments:
Also @pvanhauw can you update the title of the PR to `[DOC]fixed table formatting in the box plot section`?
> Also @pvanhauw can you update the title of the PR to `[DOC]fixed table formatting in the box plot section`?

I  just did 
@pvanhauw it seems the PR title rename didn't come through
thanks for helping me on my first PR !
DOC: fixed labels in "Plotting with error bars"
State: closed

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry

x-labels should now be visible in the plot.

Labels:
name: Docs

Comments:
Thanks!
TST: Feather RoundTrip Column Ordering
State: closed

Looks like this in fixed from pyarrow 0.17.1 -> Added a Test.

- [x] closes #https://github.com/pandas-dev/pandas/issues/33878
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO Parquet
description: parquet, feather

Comments:
thanks @alimcmaster1
DOC: Fix validation issues with Index.is_ docstring
State: closed

- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

Fix validation issues with the `Index.is_ docstring` and add `Index.identical` to see also section. Trying to finish what was started in #32357 

Labels:
name: Docs

Comments:
Yeah, the CI issues are from master branch. The issue that the original PR was hanging on is in "CI / Web and docs" which passed now.
TST: Add test to verify align behaviour on CategoricalIndex
State: closed

verify that aligning two dataframes with a `CategoricalIndex` does not change the type of the index.

- [x] closes #28397
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry (not applicable?)


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Categorical
description: Categorical Data Type

Comments:
@jorisvandenbossche anything that still needs to happen here?
Hello @MBrouns! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:



There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-07-06 14:58:43 UTC
@MBrouns can you merge master & push? Will hopefully fix the CI issue.
thanks @MBrouns very nice
TST: Add test to verify 'dropna' behaviour on SparseArray
State: closed

verify that calling `dropna` on a pd.SparseArray does not inadvertently drop non-na records on both DataFrames and the SparseArray itself.

- [x] closes #28287
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry (not applicable?)


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Sparse
description: Sparse Data Type

Comments:
Thanks, incorporated the feedback!
> The test you added looks good, but I think it would be nice to directly include a test for "invert" as well. See the comment from the original issues: [#28287 (comment)](https://github.com/pandas-dev/pandas/issues/28287#issuecomment-529657096)

Isn't that already covered by https://github.com/pandas-dev/pandas/blob/72aed3e3052ef92005408a40c34425cd1f09fadd/pandas/tests/arrays/sparse/test_arithmetics.py#L466-L480 ?

> Isn't that already covered by 

That indeed looks to be the case, thanks for checking!
(failures are all the html failures)
Thanks!
BUG: Fix replace for different dtype equal value
State: closed

Bug noticed when looking at a different issue https://github.com/pandas-dev/pandas/issues/34871#issuecomment-646664842

- [x] closes https://github.com/pandas-dev/pandas/issues/35376
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: DataFrame
description: DataFrame data structure
name: Series
description: Series data structure

Comments:
can u merge master and will look
@dsaxton can you move release note
marking as stale :wink:
Closing since the other PR looks like a better fix
BUG/TST: Read from Public s3 Bucket Without Creds
State: closed

- [x] Closes #34626

We should potentially merge this before https://github.com/pandas-dev/pandas/pull/34266 to confirm reading from s3 without credentials works.

Ref discussion here: https://github.com/pandas-dev/pandas/pull/34793#issuecomment-645023794

cc. @jorisvandenbossche 

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO CSV
description: read_csv, to_csv

Comments:
@alimcmaster1 https://github.com/pandas-dev/pandas/pull/34266 is merged now, so this can be refactored on top of that now
@alimcmaster1 I think you still need to carry over your original fix to latest master?
> @alimcmaster1 I think you still need to carry over your original fix to latest master?

s3.py was deleted with the fsspec refactor -> I’ll update my fix.
@alimcmaster1 do you have time to update this?
> @alimcmaster1 do you have time to update this?

Yes I’ll update on the next few days, apols for the delay. Think we need some try catch logic here: https://github.com/pandas-dev/pandas/pull/34266/files#diff-0d7b5a2c72b4dfc11d80afe159d45ff8R205. Agree with your comment https://github.com/pandas-dev/pandas/issues/34626#issuecomment-643399792 we should deprecate eventually. 
@TomAugspurger 
Happy to address that as a followup, since this is fixing the regrssion.
Thanks @alimcmaster1!
Cln 31942/replace appender with doc 6
State: closed

- [x] ref #31942
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- fixes issues with the introduction of the doc decorator


Labels:
name: Docs

Comments:
Hello @smartvinnetou! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:







There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-06-23 21:39:19 UTC
@smartvinnetou Are you still working on this? If so, mark as ready for review when ready or close.
Closing as this appears stale, but @smartvinnetou ping if you'd like to pick back up and can reopen
DF.__setitem__ creates extension column when given extension scalar
State: closed

This PR is in response to [Issue 34832]( https://github.com/pandas-dev/pandas/issues/34832).
These changes follow the suggestions from reviewers on the PR to fix an issue where `df['a']=pd.Period('2020-01')` would create an object column instead of a `period[M]` column.

One potential issue that I see with these changes is that this code requires the `shape` parameter passed into `cast_scalar_to_array` to be an int, even though the functions docstring claims that it accepts a tuple.

I'm happy to work on resolving that issue, but first wanted to clarify that it is necessary. Based on my perspective, there would be no reason to call this function to create a multi-dimensional array, but I surely don't understand the full interconnectivity of this package.

- [x] closes #xxxx
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: ExtensionArray
description: Extending pandas with custom dtypes or arrays.

Comments:
Hello @justinessert! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:









There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-07-10 22:53:42 UTC
Thanks @TomAugspurger for all your time in reviewing this PR and the original issue. Everything looks to be passing and I think I have addressed all your comments, please lmk if you would like to see any other changes!
@TomAugspurger @jorisvandenbossche @jreback Are there any outstanding requests that you have on this PR?
i will have a look soon as havent  reviewed 
@TomAugspurger @jreback I refactored this PR per your suggestions. In affect I am no longer changing the functionality of `cast_scalar_to_array` and everything is a lot more explicit. Please let me know what you think now.
Can someone help me understand what this recent test failure is? I could be wrong, but it doesn't seem to be a unit test or formatting error
I restarted the job that crashed.
@jreback all good?
ping on green.
thanks @justinessert 
Thanks a lot @justinessert ! (and sorry for the difficult back and forth discussion)
No problem!

@jorisvandenbossche @jreback @TomAugspurger Thanks for all your help in getting this PR through!
DOC: Move API breaking to appropriate sections
State: closed

As discussed in https://github.com/pandas-dev/pandas/issues/34801, this moves some items from our "API breaking changes" section to either bug fixes or enhancements. I've only moved the ones we can hopefully get consensus on as bug fix / enhancement. But let me know if any of these need further discussion on whether they're an API breaking change.


Labels:
name: Docs

Comments:
As requested in https://github.com/pandas-dev/pandas/pull/34865/files/a1130882c28ac17be013287fd5abef40841e1d8e#diff-e763086372257ed7ca944d8bc5042a04
Also cc @jorisvandenbossche for confirmation that this all look like bug fixes.
I need to close this for a while.
DEPR: to_perioddelta
State: closed

- [ ] closes #xxxx
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry

The only usage was in liboffsets and that has now been removed.

Labels:
name: Period
description: Period data type
name: Deprecate
description: Functionality to remove in pandas

Comments:
sure, pls add to the deprecation removal issue
> sure, pls add to the deprecation removal issue

done
CI: Fail on warning for 3.9
State: closed

This should fail till https://github.com/pandas-dev/pandas/pull/34835 is in.

Labels:
name: CI
description: Continuous Integration

Comments:
Just out of curiosity what are you trying to do specific to 3.9? I think great to do this, though obviously would require a good deal of work to get it to work across all builds
> Just out of curiosity what are you trying to do specific to 3.9?

The 3.9 job builds NumPy from source, and so it can be slightly ahead of the numpydev build (our only other build to error on warnings) which uses NumPy's nightly wheels. 

Agreed this would be nice to have. Just not sure if /when I'll have time to get to work through all of these. There are more failures than I expected :)
I'm not going to get to this any time soon.
WIP: TST: split up tests/plotting/test_frame.py into subdir & modules #34769
State: closed

Moved `tests/plotting/test_frame.py` to `tests/plotting/frame/test_frame.py`.

Worked towards #34769 but not closing it as this has not split the test suite.

- [ ] xref #34769
- [x] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Visualization
description: plotting
name: Clean
name: Stale

Comments:
/azp run
<samp>
Azure Pipelines successfully started running 1 pipeline(s).<br>

</samp>
can you merge master and ping on green.
hi @jreback I have merged master and all checks are green now
sorry can u merge master again and ping on green 

also remove WIP from title
@iahsanujunda can you fix the merge conflict?
GH is showing me an empty diff.  is this active?
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.
Can I continue working on this branch?
Or is it better to create a new request?
@Mikhaylov-yv pls create a new PR
Remove redundant lists in array.py
State: closed

As far as I know these lists do nothing but taking up memory.

Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: IO JSON
description: read_json, to_json, json_normalize
name: Clean

Comments:
Note that this is a dummy implementation only for tests, so there is not much need in making an effort  to optimize this
looks good to me - can you merge master and re-push to fix CI?
Looks like the CI failure is unrelated to my changes.
thanks @cool-RR
BUG: fix construction from read-only non-ns datetime64 numpy array
State: closed

Closes #34843

Labels:
name: Bug
name: Datetime
description: Datetime data dtype

Comments:
Travis failure are the numpy dev warnings
> we typically also call this klass 

There are several existing occurrences of a "constructor" fixture, already

> and don’t much care about dataframe-dict here

We actually do, as the test above has an xfail because `DataFrame(dict)` vs `DataFrame(array)` behaves differently (the sanitization of datetime64 values follows a different code path in both cases). 
In this case both work, but so I think it is good to test both.

> creating this fixture for a single use is not that great

Yeah, that is because I first wanted to share it with the other existing test. But because that has an xfail on one of the fixture parameters, making it difficult to share. Once that bug is fixed, it can be shared though.


> as the test above has an xfail because DataFrame(dict) vs DataFrame(array) behaves differently (the sanitization of datetime64 values follows a different code path in both cases).

Which is https://github.com/pandas-dev/pandas/issues/26919