BrandonFors/pandas-github-issues huggingface dataset:
Join result takes on the calling from index
State: closed

https://github.com/pandas-dev/pandas/issues/15582

Fixes indexing referenced in 15582. Tests appear to work on my end, we'll see...

Labels:

Comments:
really? https://travis-ci.org/pandas-dev/pandas/jobs/208041268
Apparently i don't know how to run tests properly -_-

Still gettin the hang of this :/
@sleepdeprivation you can push additional changes to this branch. Just make sure to reopen if you want to keep working on it.
Comment typo correction
State: closed

 - [ ] closes #xxxx
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [ ] whatsnew entry


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15577?src=pr&el=h1) Report
> Merging [#15577](https://codecov.io/gh/pandas-dev/pandas/pull/15577?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/84bbeae9f10d63fcd546c632649828621a80f64d?src=pr&el=desc) will **decrease** coverage by `-0.03%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15577      +/-   ##
==========================================
- Coverage   91.05%   91.03%   -0.03%     
==========================================
  Files         137      137              
  Lines       49290    49290              
==========================================
- Hits        44882    44872      -10     
- Misses       4408     4418      +10
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15577?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/types/dtypes.py](https://codecov.io/gh/pandas-dev/pandas/compare/84bbeae9f10d63fcd546c632649828621a80f64d...b258f200447153434d912b7a18ea2207d6c1aa7f?src=pr&el=tree#diff-cGFuZGFzL3R5cGVzL2R0eXBlcy5weQ==) | `95.33% <ø> (ø)` | :white_check_mark: |
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/84bbeae9f10d63fcd546c632649828621a80f64d...b258f200447153434d912b7a18ea2207d6c1aa7f?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :x: |
| [pandas/tools/merge.py](https://codecov.io/gh/pandas-dev/pandas/compare/84bbeae9f10d63fcd546c632649828621a80f64d...b258f200447153434d912b7a18ea2207d6c1aa7f?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL21lcmdlLnB5) | `91.78% <0%> (-0.35%)` | :x: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/84bbeae9f10d63fcd546c632649828621a80f64d...b258f200447153434d912b7a18ea2207d6c1aa7f?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.83% <0%> (-0.1%)` | :x: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/84bbeae9f10d63fcd546c632649828621a80f64d...b258f200447153434d912b7a18ea2207d6c1aa7f?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `91.36% <0%> (+0.33%)` | :white_check_mark: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15577?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15577?src=pr&el=footer). Last update [84bbeae...b258f20](https://codecov.io/gh/pandas-dev/pandas/compare/84bbeae9f10d63fcd546c632649828621a80f64d...b258f200447153434d912b7a18ea2207d6c1aa7f?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
thanks
Raising for invalid dtype issue #15520
State: closed

closes #15520 

- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes git diff upstream/master | flake8 --diff
- [ ] whatsnew entry

Labels:

Comments:
Are you saying I should raise within the pandas_dtype method?
yes ``pandas_dtype`` will raise if an invalid string is passed, but not an invalid object

```
In [1]: pandas.types.common.pandas_dtype(pd.Timestamp)
Out[1]: dtype('O')

In [2]: pandas.types.common.pandas_dtype('foo')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-2-07647ef910a7> in <module>()
----> 1 pandas.types.common.pandas_dtype('foo')

/Users/jreback/pandas/pandas/types/common.py in pandas_dtype(dtype)
    491         return dtype
    492 
--> 493     return np.dtype(dtype)

TypeError: data type "foo" not understood

```
if you want to add some tests ping and will reopen
ENH: Allow parameters method and min_periods in DataFrame.corrwith() 
State: closed

Added new keyword parameters for `DataFrame.corrwith()`, which allows methods other than Pearson to be used. See #9490.

 - [x] closes #9490
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry


Labels:
name: Enhancement
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
can you update
can you rebase, add some benchmarks to asv and show them.
can you rebase and update?
closing as stale
DOC: reset table_schema option after example
State: closed

@jreback I think this should fix the errors you noticed here https://github.com/pandas-dev/pandas/issues/15559#issuecomment-284166380 (let's see if travis agrees with me)

The table schema repr was activated due to the example (the ipython environment lives on between different documents; it would actually be a good idea to completely reset them for each rst file)

cc @TomAugspurger in any case an example that it's not yet ready to be default on True :-) 

Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15572?src=pr&el=h1) Report
> Merging [#15572](https://codecov.io/gh/pandas-dev/pandas/pull/15572?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/0b776806b78421e377bb6c305d1e3a752f24e358?src=pr&el=desc) will **decrease** coverage by `-0.03%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15572      +/-   ##
==========================================
- Coverage   91.05%   91.03%   -0.03%     
==========================================
  Files         137      137              
  Lines       49285    49285              
==========================================
- Hits        44878    44866      -12     
- Misses       4407     4419      +12
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15572?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/0b776806b78421e377bb6c305d1e3a752f24e358...9981ff0089ae9c4ea1fa388b1a6471ecc878fc1e?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :x: |
| [pandas/tools/merge.py](https://codecov.io/gh/pandas-dev/pandas/compare/0b776806b78421e377bb6c305d1e3a752f24e358...9981ff0089ae9c4ea1fa388b1a6471ecc878fc1e?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL21lcmdlLnB5) | `91.78% <0%> (-0.35%)` | :x: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/0b776806b78421e377bb6c305d1e3a752f24e358...9981ff0089ae9c4ea1fa388b1a6471ecc878fc1e?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `91.02% <0%> (-0.34%)` | :x: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/0b776806b78421e377bb6c305d1e3a752f24e358...9981ff0089ae9c4ea1fa388b1a6471ecc878fc1e?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.83% <0%> (-0.1%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15572?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15572?src=pr&el=footer). Last update [0b77680...9981ff0](https://codecov.io/gh/pandas-dev/pandas/compare/0b776806b78421e377bb6c305d1e3a752f24e358...9981ff0089ae9c4ea1fa388b1a6471ecc878fc1e?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
BUG: resample with tz-aware: Values falls after last bin
State: closed

 - [ ] closes https://github.com/pandas-dev/pandas/issues/15549
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [ ] whatsnew entry: resampling will now always produce bins alligned by UTC instead of custom time zone. so for example if you resampling by 12 hours frequency in UTC-5 timezone, you will get bins like
7:00 19:00 7:00 19:00
instead of 
00:00 12:00 00:00 12:00


Labels:
name: Bug
name: Resample
description: resample method

Comments:
jreback, would you like me to add tests for this change ?
tests!

*always*

and a whatsnew note please.
committed a test and wrote a whatsnew note.
please let me know if the format of whatsnew is correct, I'm not sure if there is any standard form I should follow.
I understand why the checks failed, I will commit a fix
@jreback is it ok to change already existing tests in order to make my change pass them ?
you need to prove that a current test is wrong in order to change it
I think you need to compute the range edges *with* the tz intact. I think it is mishandling when it has an ambiguous datetime.

Then constructing the tz should be ok.
got it, let me try to use your approach
@ahcub yeah this seemingly trivial change is actually hard. there have been lots of fixes (for various reasons) thru the years. good news is the test suite is quite comprehensive here :>
can you rebase / update
I will close it for now and restore it when I get back to it
@ahcub ok sure. though pls come back when you can! thanks!
TST: split tests/format/test_format.py
State: closed

closes #15531

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15546?src=pr&el=h1) Report
> Merging [#15546](https://codecov.io/gh/pandas-dev/pandas/pull/15546?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/29d81f3df81eb0a4d077ae1317df74d509cdc446?src=pr&el=desc) will **decrease** coverage by `-0.03%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15546      +/-   ##
==========================================
- Coverage   91.06%   91.04%   -0.03%     
==========================================
  Files         136      136              
  Lines       49104    49104              
==========================================
- Hits        44718    44706      -12     
- Misses       4386     4398      +12
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15546?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/compare/29d81f3df81eb0a4d077ae1317df74d509cdc446...4c5ef4cfa0556d1680a9c9163aa347a13a9d6590?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `40% <0%> (-46.67%)` | :x: |
| [pandas/util/decorators.py](https://codecov.io/gh/pandas-dev/pandas/compare/29d81f3df81eb0a4d077ae1317df74d509cdc446...4c5ef4cfa0556d1680a9c9163aa347a13a9d6590?src=pr&el=tree#diff-cGFuZGFzL3V0aWwvZGVjb3JhdG9ycy5weQ==) | `67.92% <0%> (-0.95%)` | :x: |
| [pandas/tools/merge.py](https://codecov.io/gh/pandas-dev/pandas/compare/29d81f3df81eb0a4d077ae1317df74d509cdc446...4c5ef4cfa0556d1680a9c9163aa347a13a9d6590?src=pr&el=tree#diff-cGFuZGFzL3Rvb2xzL21lcmdlLnB5) | `91.78% <0%> (-0.35%)` | :x: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/compare/29d81f3df81eb0a4d077ae1317df74d509cdc446...4c5ef4cfa0556d1680a9c9163aa347a13a9d6590?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.74% <0%> (-0.1%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15546?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15546?src=pr&el=footer). Last update [29d81f3...4c5ef4c](https://codecov.io/gh/pandas-dev/pandas/compare/29d81f3df81eb0a4d077ae1317df74d509cdc446...4c5ef4cfa0556d1680a9c9163aa347a13a9d6590?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
DOC: Styler.set_table_attributes docstring
State: closed

 - [x] tests not needed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew not needed

Fixes a copy-paste error.

Labels:
name: Docs
name: Output-Formatting
description: __repr__ of pandas objects, to_string

Comments:
lgtm.
thanks!
BLD: fix 2.7_LOCALE build
State: closed

simplify install_travis.sh, always using a clean miniconda install
bump matplotlib to 1.4.0 for _LOCALE, numpy to 1.8.2

So this removes our testing of mpl 1.2.1 with numpy 1.7.1. We *still* test
elsewhere 1.7.1, and mpl 1.3.1 (with 1.8.2), so I think this is sufficient.

something changed in conda meta data to make the installtion of numpy=1.7.1 / mpl=1.2.1 fail
https://travis-ci.org/jreback/pandas/jobs/206680630

The only question is to we want to 'officially' say that we require mpl >= 1.3.1 ?
Things will still work as long as the installation succeeds, but travis is being problematic.

cc @jorisvandenbossche 
cc @tacaswell 

Labels:
name: CI
description: Continuous Integration

Comments:
merging to avoid constant travis failures, but please comment on the question I raised above.
I have no problem with bumping the minimal matplotlib version from 1.2 to > 1.3.1 (1.3 dates from 2013 I think, so we might even go to 1.4? cc @TomAugspurger @sinhrks ). 

Should probably open a separate issue for that to remind of code clean-up and update of docs.
Ah, I see that in practice > 1.3.1 actually means >= 1.4 (1.4.0 dates from August 2014). But as I said, that sounds good to me to bump to that.
DOC: Update contributing for test_fast, fix doc Windows build
State: closed

- Add `test_fast.bat` for Windows developers.
- Update `contributing.rst` to refer to `pytest-xdist` and reference fast testing scripts
- Update `contributing.rst` to delete references to `pep8radius`
- Fix `doc\make.py` to not spit out error message about `rm` on Windows by using `os.remove()`

No code changes!


Labels:
name: Build
description: Library building on various platforms
name: Docs

Comments:
minor comment, otherwise lgtm.
thanks @Dr-Irv yeah I killed the appveyor/travis jobs (circleci does auto-killing itself :)


@jorisvandenbossche ?
@Dr-Irv Thanks!
TST: DataFrame.hist() does not get along with matplotlib.pyplot.tight_layout()
State: closed

 - [ ] closes #9351
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [ ] whatsnew entry


Labels:
name: Testing
description: pandas testing functions or related to the test suite
name: Visualization
description: plotting

Comments:
Note: in addition to the #9351 unit test this PR also adds a `_skip_if_mpl_1` method to the test utilities.
I rewrote the test using `mpl_ge_2_0_0` and removed the aux method. `pytest` isn't a name in `test_hist_method`, and I don't see a generic skip in `testing.py`, so I've just made the test conditional, e.g. there's no explicit skip. Let me know if that's OK or not.
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15515?src=pr&el=h1) Report
> Merging [#15515](https://codecov.io/gh/pandas-dev/pandas/pull/15515?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/b3ae4c7698de4623e1279d579b46192ef79250d1?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15515      +/-   ##
==========================================
+ Coverage   90.36%   90.36%   +<.01%     
==========================================
  Files         136      136              
  Lines       49553    49554       +1     
==========================================
+ Hits        44780    44781       +1     
  Misses       4773     4773
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15515?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/generic.py](https://codecov.io/gh/pandas-dev/pandas/compare/b3ae4c7698de4623e1279d579b46192ef79250d1...809d8473677bce11dd780ecb332b130c3b523c9a?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZ2VuZXJpYy5weQ==) | `96.31% <0%> (ø)` | :white_check_mark: |
| [pandas/types/cast.py](https://codecov.io/gh/pandas-dev/pandas/compare/b3ae4c7698de4623e1279d579b46192ef79250d1...809d8473677bce11dd780ecb332b130c3b523c9a?src=pr&el=tree#diff-cGFuZGFzL3R5cGVzL2Nhc3QucHk=) | `85.45% <0%> (+0.02%)` | :white_check_mark: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15515?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15515?src=pr&el=footer). Last update [b3ae4c7...809d847](https://codecov.io/gh/pandas-dev/pandas/compare/b3ae4c7698de4623e1279d579b46192ef79250d1...809d8473677bce11dd780ecb332b130c3b523c9a?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lgtm. ping on green.
actually, pls add a whatsnew note as well (I guess in Bug Fixes). This is really a mpl compat issue, and there isn't much we can do about it with < 2.0.0, so best just to note this in the whatsnew as well so readers can react to this.
lgtm. thanks.
thanks!
DOC: Fix versionadded for cond in .where
State: closed

Per discussion in <a href="https://github.com/pandas-dev/pandas/pull/15414#discussion_r103089692">#15414 (comment) </a>.

@jorisvandenbossche 

Labels:
name: Docs

Comments:
The 'other' keyword below that has the same issue.
> The 'other' keyword below that has the same issue.

Done.
@gfyoung Thanks!
DOC: Fix to docstrings of is_type_factory and is_instance_factory
State: closed


 - [X] closes #15485
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [ ] whatsnew entry


Labels:
name: Docs

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15499?src=pr&el=h1) Report
> Merging [#15499](https://codecov.io/gh/pandas-dev/pandas/pull/15499?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/81c57e20da278494dfebc2f1043f5ff361a234f3?src=pr&el=desc) will **decrease** coverage by `-0.01%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15499      +/-   ##
==========================================
- Coverage   90.36%   90.36%   -0.01%     
==========================================
  Files         136      136              
  Lines       49532    49532              
==========================================
- Hits        44760    44759       -1     
- Misses       4772     4773       +1
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15499?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/config.py](https://codecov.io/gh/pandas-dev/pandas/compare/81c57e20da278494dfebc2f1043f5ff361a234f3...678195f1c78e56ec173884b2f0706ab422b94fb5?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29uZmlnLnB5) | `88.09% <ø> (ø)` | :white_check_mark: |
| [pandas/core/common.py](https://codecov.io/gh/pandas-dev/pandas/compare/81c57e20da278494dfebc2f1043f5ff361a234f3...678195f1c78e56ec173884b2f0706ab422b94fb5?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29tbW9uLnB5) | `91.02% <ø> (-0.34%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15499?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15499?src=pr&el=footer). Last update [81c57e2...678195f](https://codecov.io/gh/pandas-dev/pandas/compare/81c57e20da278494dfebc2f1043f5ff361a234f3...678195f1c78e56ec173884b2f0706ab422b94fb5?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
thanks!
msgpack supports CategoricalIndex 
State: closed

 - [x] closes #15487
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry

This allows `read_msgpack`  to read DataFrames with a categorical index. I'd assume that my testcase needs some improvement. Where can I find some information where and how to add the "whatsnew entry"?



Labels:
name: Compat
description: pandas objects compatability with Numpy or Python functions
name: Categorical
description: Categorical Data Type

Comments:
thanks!
BUG: repr SparseDataFrame after setting a value
State: closed

 - [x] closes #15488
 - [x] tests added / passed
 - [X] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry


Labels:
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Sparse
description: Sparse Data Type

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15489?src=pr&el=h1) Report
> Merging [#15489](https://codecov.io/gh/pandas-dev/pandas/pull/15489?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/d80275dfaa6a8ad50bc49dbaef9eacd5509008dc?src=pr&el=desc) will **decrease** coverage by `-0.01%`.
> The diff coverage is `n/a`.


```diff
@@            Coverage Diff             @@
##           master   #15489      +/-   ##
==========================================
- Coverage   90.36%   90.36%   -0.01%     
==========================================
  Files         136      136              
  Lines       49553    49551       -2     
==========================================
- Hits        44781    44779       -2     
  Misses       4772     4772
```


| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/15489?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/formats/format.py](https://codecov.io/gh/pandas-dev/pandas/compare/d80275dfaa6a8ad50bc49dbaef9eacd5509008dc...2dc145c9ccc46ab5335baf53ffc5950b92a47a17?src=pr&el=tree#diff-cGFuZGFzL2Zvcm1hdHMvZm9ybWF0LnB5) | `95.31% <ø> (-0.01%)` | :x: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15489?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/15489?src=pr&el=footer). Last update [d80275d...2dc145c](https://codecov.io/gh/pandas-dev/pandas/compare/d80275dfaa6a8ad50bc49dbaef9eacd5509008dc...2dc145c9ccc46ab5335baf53ffc5950b92a47a17?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
ok, lgtm. ping on green.
It's green.
thanks @kernc 

keep em coming!
GH6322, Bug on reset_index for a MultiIndex of all NaNs
State: closed

The reset_index function fails for a MultiIndex if at
least one column of the index is all NaN.

 - [x] closes #6322 
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry

As per the comment in the issue, I tried other solutions such as putting the `take` under an `if len(values)` call, unfortunately that broke other issues downstream.
I started to investigate and it seems like a `MultiIndex` makes a category that ignores `NaN`, so the `values` in the `reset_index` is empty. After trying a few options, the `if mask.all()` seemed like the simplest change.

Labels:
name: Bug
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: MultiIndex

Comments:
thanks @tzinckgraf (you had a couple of flake issues, but I fixed on merge)
@jreback thank you. I ran `git diff master | flake8 --diff`, but I must have missed something.