str_extract should work for timeseries, (GH6348)
State: closed

closes https://github.com/pydata/pandas/issues/6348


Labels:
name: Bug
name: Strings
description: String extension data type and string data

Comments:
pls also add a release not in the Bugs Fixed section of 0.14.0

@andrewkittredge this is fine...pls add a release note in the BUgs fixed section of 0.14.0 (reffing the closed issue)

Cool, sorry about the confusion I'm new to git(hub).

On Sun, Feb 16, 2014 at 4:49 PM, jreback notifications@github.com wrote:

> @andrewkittredge https://github.com/andrewkittredge this is fine...pls
> add a release note in the BUgs fixed section of 0.14.0 (reffing the closed
> issue)
> 
> ## 
> 
> Reply to this email directly or view it on GitHubhttps://github.com/pydata/pandas/pull/6349#issuecomment-35215170
> .

fixed.

did you force push your branch?

Not intentionally, should I?

On Sun, Feb 16, 2014 at 5:25 PM, jreback notifications@github.com wrote:

> did you force push your branch?
> 
> ## 
> 
> Reply to this email directly or view it on GitHubhttps://github.com/pydata/pandas/pull/6349#issuecomment-35218246
> .

yep that's how you replace the commits with new ones

see #6309 

can you validate this for all index types as well (I think your change will make it work correctly).

something like this. make the test so it loops thru all the index types and validate that they work correctly:
https://github.com/pydata/pandas/blob/master/pandas/tests/test_indexing.py#L2895

I've made those changes and update my commit @
https://github.com/andrewkittredge/pandas/commit/7aeab9adeae65c7a229fe6c424820e29d54d297a.
  It looks like the original pull request did not update.  Do you want me
to make another pull request?

Andrew

On Mon, Feb 17, 2014 at 9:16 AM, jreback notifications@github.com wrote:

> see #6309 https://github.com/pydata/pandas/issues/6309
> 
> can you validate this for all index types as well (I think your change
> will make it work correctly).
> 
> something like this. make the test so it loops thru all the index types
> and validate that they work correctly:
> 
> https://github.com/pydata/pandas/blob/master/pandas/tests/test_indexing.py#L2895
> 
> ## 
> 
> Reply to this email directly or view it on GitHubhttps://github.com/pydata/pandas/pull/6349#issuecomment-35284970
> .

did u 

git push yourforkname thisbranch -f

?

I did-

git push andrew str_extract_time_series_bug --force.

my git config is below-

[core]

```
    repositoryformatversion = 0

    filemode = true

    bare = false

    logallrefupdates = true

    ignorecase = true

    precomposeunicode = false
```

[remote "origin"]

```
    url = https://github.com/pydata/pandas.git

    fetch = +refs/heads/*:refs/remotes/origin/*
```

[remote "andrew"]

```
    url = https://github.com/andrewkittredge/pandas.git

    fetch = +refs/heads/*:refs/remotes/origin/*
```

[branch "master"]

```
    remote = origin

    merge = refs/heads/master
```

On Sun, Feb 23, 2014 at 12:46 PM, jreback notifications@github.com wrote:

> did u
> 
> git push yourforkname thisbranch -f
> 
> ?
> 
> ## 
> 
> Reply to this email directly or view it on GitHubhttps://github.com/pydata/pandas/pull/6349#issuecomment-35837631
> .

I thnk you created this on a new branch (the original was on your master branch).

no matter...I'll pull it in. thanks!

merged via https://github.com/pydata/pandas/commit/8efa4ac0d9789f34ff550a14f2b7ff54bbce728d

Ah, thanks, apologies again for my poor git skills.

Pandas is wonderful, keep up the good work.

On Sun, Feb 23, 2014 at 5:03 PM, jreback notifications@github.com wrote:

> I thnk you created this on a new branch (the original was on your master
> branch).
> 
> no matter...I'll pull it in. thanks!
> 
> ## 
> 
> Reply to this email directly or view it on GitHubhttps://github.com/pydata/pandas/pull/6349#issuecomment-35845269
> .

no thank you!

and pls feel free to submit issues and more pull requests!

git gets easier the more you use it!