BrandonFors/pandas-github-issues huggingface dataset:
MAINT: Refactor logic in maybe_convert_*
State: closed

Creates a Seen class to abstract objects encountered when doing type conversions.

Follow-up to #15005.

Labels:
name: Dtype Conversions
description: Unexpected or buggy dtype conversions
name: Clean

Comments:
you need to pass the structure to the functions themselves

but i think a class is better here actually
@jreback : Good catch regarding classes.  Fixed.
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/15018?src=pr) is 84.77% (diff: 100%)
> Merging [#15018](https://codecov.io/gh/pandas-dev/pandas/pull/15018?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

```diff
@@             master     #15018   diff @@
==========================================
  Files           145        145          
  Lines         51129      51129          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43344      43344          
  Misses         7785       7785          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [9947a99...531a361](https://codecov.io/gh/pandas-dev/pandas/compare/9947a99d04b87e7441f062d6b5eca281ef15deb7...531a361d79e4b3ef0f08ce59a8976fdaf729c4c3?src=pr)
@jreback : Addressed all comments, and everything is green still.
@jreback : Made the requested changes, and everything is green.
Small question (and sorry that you already changed all those once before), but can you name it `seen.int`, `seen.null`, etc instead of `see.sint`, `seen.snull`, .. ? 
IMO that reads easier (and sint and snull actually mean other things, or at least in Dutch :-))
@jorisvandenbossche : Fair enough (what do they mean, just curious?).  With underscores (as @jreback suggested) or none?  I'm inclined to go with no underscores since not declaring them public makes it pretty clear I think that they are private but want to double check.
underscores are not needed here I think (if we add an underscore, I would make the class `_Seen` (the instantation can still be `seen`)

(sint -> saint, snul(l) -> nitwit/squib (don't know the exact translation))
@jorisvandenbossche : Very well.  Can rename without underscores.
i don't think u can name a struct member the same as its type e.g.

int int

is not valid code (python or c)
i see the renaming - that is ok

lgtm then
@gfyoung my last 2 comments are meant, not really to simplify the code much, but more to make it a bit easier to read w/o having to think thru all of the possible cases.
@jreback : Certainly.  There was another similar refactoring that I did for `is_bool` too.
lgtm. just give a quick perf test (locally) and ping on green.
@jreback : No major perf impact, and everything is green.  Ready to merge if there are no other concerns.
thanks!
TST: Series Division with zeros numpy array (#8674)
State: closed

 - [x] closes #8674
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``

This issue operates normally on master and relates to Python's 2.x division. Doesn't appear that any PRs in 0.20 addressed this issue. 

Labels:
name: Bug
name: Testing
description: pandas testing functions or related to the test suite
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/15013?src=pr) is 84.78% (diff: 100%)
> Merging [#15013](https://codecov.io/gh/pandas-dev/pandas/pull/15013?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #15013   diff @@
==========================================
  Files           145        145          
  Lines         51090      51090          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43315      43316     +1   
+ Misses         7775       7774     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [0d3ecfa...7a614c4](https://codecov.io/gh/pandas-dev/pandas/compare/0d3ecfa8ba3930b688a6781c7f84138bc80da41a...7a614c4da363db900fbf1b1122908eecff013498?src=pr)
@mroeschke Thanks!
DOC/BLD: doc building with python 3
State: closed

Makes our doc building machinery (specific accessor stuff) python 3 compat + switches travis doc building to python 3.5 + preventing some other warnings (see individual commits)

Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/15012?src=pr) is 84.78% (diff: 100%)
> Merging [#15012](https://codecov.io/gh/pandas-dev/pandas/pull/15012?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #15012   diff @@
==========================================
  Files           145        145          
  Lines         51090      51090          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43315      43316     +1   
+ Misses         7775       7774     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [d097b0f...a932919](https://codecov.io/gh/pandas-dev/pandas/compare/d097b0f0ed79a2305bc5970f45f01e768ac0c00a...a9329199477cc8ae8bf425f238e72d7f3b3822c3?src=pr)
I only get errors installing the packages on travis:

```
UnsatisfiableError: The following specifications were found to be in conflict:
  - ipython
  - python 3.5*
```

anybody knows what the reason of this could be?
It's beatiful-soup -> beautifulsoup4 apparently
DOC: python 3 compatibility in code examples
State: closed

Some changes to our code examples needed to make them all run with python 3.

(there are still problems with our accessor extensions to have doc building on py3 fully working)

Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/15011?src=pr) is 84.78% (diff: 100%)
> Merging [#15011](https://codecov.io/gh/pandas-dev/pandas/pull/15011?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

```diff
@@             master     #15011   diff @@
==========================================
  Files           145        145          
  Lines         51090      51090          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43315      43315          
  Misses         7775       7775          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [e27b296...5583c98](https://codecov.io/gh/pandas-dev/pandas/compare/e27b29697f0dcf9359f01a19edb2f20c6d728b6c...5583c983f0811fe91af97e5389c51b3ac2f49546?src=pr)
Fix gbq integration tests so that unique datasets/table names are used
State: closed

This PR will resolve an issue where a gbq integration test was failing. The same dataset/table name was used twice in `test_gbq.py` which could result in a schema conflict if the previous table schema is cached and the new schema has not successfully propagated through Google's backend. 

See https://github.com/pandas-dev/pandas/commit/45910ae646eba417120dd2bd4ada68a018c97b32

All gbq units tests passed on Travis on my fork : https://travis-ci.org/parthea/pandas/builds/187463043

Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/15009?src=pr) is 84.78% (diff: 100%)
> Merging [#15009](https://codecov.io/gh/pandas-dev/pandas/pull/15009?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

```diff
@@             master     #15009   diff @@
==========================================
  Files           145        145          
  Lines         51090      51090          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43315      43315          
  Misses         7775       7775          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [e27b296...46cb245](https://codecov.io/gh/pandas-dev/pandas/compare/e27b29697f0dcf9359f01a19edb2f20c6d728b6c...46cb24509182f9e21f9d21ff4efba99e612b305c?src=pr)
thanks @parthea !
TST: fix tests catching unorderable errors for python 3.6
State: closed

See also https://github.com/MacPython/pandas-wheels/pull/8, seems that the order of int and str is switched in some cases (eg https://travis-ci.org/MacPython/pandas-wheels/jobs/187223139). Therefore making the test here more robust.

Related to https://github.com/pandas-dev/pandas/pull/14684


Labels:
name: Testing
description: pandas testing functions or related to the test suite

Comments:
@jreback not sure if this should be changes in `_is_unorderable_exception` (https://github.com/pandas-dev/pandas/pull/14684/files#diff-779e809bc7bd6d23787580ee9be98729R199) as well. In any case, did not see failing tests related to that in the wheels building for mac.
yeah py 3.6. changed the error message, so maybe *should* change ``_is_unorderable_exception`` as well (to make it less strict), not sure though
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/15007?src=pr) is 84.78% (diff: 100%)
> Merging [#15007](https://codecov.io/gh/pandas-dev/pandas/pull/15007?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #15007   diff @@
==========================================
  Files           145        145          
  Lines         51090      51090          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43315      43316     +1   
+ Misses         7775       7774     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [e27b296...da8f8c9](https://codecov.io/gh/pandas-dev/pandas/compare/e27b29697f0dcf9359f01a19edb2f20c6d728b6c...da8f8c984a44d70fdac2ce75d7b4e93c4463a692?src=pr)
DOC: Fix df.resample docstring example
State: closed

 - [x] passes ``git diff upstream/master | flake8 --diff``


Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/15004?src=pr) is 84.78% (diff: 100%)
> Merging [#15004](https://codecov.io/gh/pandas-dev/pandas/pull/15004?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will not change coverage

```diff
@@             master     #15004   diff @@
==========================================
  Files           145        145          
  Lines         51090      51090          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43315      43315          
  Misses         7775       7775          
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [3e3434b...1df8f80](https://codecov.io/gh/pandas-dev/pandas/compare/3e3434b21e3c135c3bd7649689d488380ea1ebc1...1df8f80393eb81ad6e025a6ae777f57b8c675ce5?src=pr)
@petehuang Thanks!
ERR: qcut uniquess checking (try 2)
State: closed

 - [x] closes #7751
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry

Add option to drop non-unique bins.

Labels:
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode
name: Error Reporting
description: Incorrect or improved errors from pandas

Comments:
My second try on https://github.com/pandas-dev/pandas/pull/14455 -- I wasn't able to rebase this one.
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/15000?src=pr) is 84.78% (diff: 87.50%)
> Merging [#15000](https://codecov.io/gh/pandas-dev/pandas/pull/15000?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #15000   diff @@
==========================================
  Files           145        145          
  Lines         51090      51095     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43315      43319     +4   
- Misses         7775       7776     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [7f0eefc...698b4ec](https://codecov.io/gh/pandas-dev/pandas/compare/7f0eefc2f81d6b34f252a5da38d31e515c295106...698b4ecf284283604673ee393bf006de9d38983d?src=pr)
pls add a whatsnew in 0.20.0 (other enhancements)
@ashishsingal1 For future reference, it is not needed to start a new PR, you can always clean up locally and just force push to the same branch in your fork, and this PR will be updated automatically. In fact, we rather much prefer that instead of opening a new PR, to keep discussions gathered at one place. If you need help with those git aspects, don't hesitate to ask!
@jreback @jorisvandenbossche anything left for this PR on my side?
thanks!
BUG: Fixed to_html with index=False and max_rows
State: closed

closes https://github.com/pandas-dev/pandas/issues/14998

Previously raised an IndexError by assuming that
`len(fmt_values)` was always the same length as `len(self.data)`.

Labels:
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14999?src=pr) is 84.78% (diff: 100%)
> Merging [#14999](https://codecov.io/gh/pandas-dev/pandas/pull/14999?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14999   diff @@
==========================================
  Files           145        145          
  Lines         51090      51090          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43315      43316     +1   
+ Misses         7775       7774     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [7f0eefc...2bd8629](https://codecov.io/gh/pandas-dev/pandas/compare/7f0eefc2f81d6b34f252a5da38d31e515c295106...2bd86299ae11e069eab702d5b2775dc71b1b072c?src=pr)
You now tested with `max_rows=1`, but am I correct that with `max_rows=2` you would not get the `...` row? Or if so maybe include that in the test?
> but am I correct that with max_rows=2 you would not get the ... row?

Looks like we have some issues with the interaction between index and max_rows

![screen shot 2016-12-28 at 7 44 04 am](https://cloud.githubusercontent.com/assets/1312546/21523197/7d147144-ccd1-11e6-9bfa-d4ff9ed5dbbd.png)

I think the third one is buggy, index=False should not affect whether or not the `...` is drawn. Do that as a followup?

I can as a follow-up, but possibly you can also solve it at once here. If you use the `_write_regular_rows` whether index is false or not, but let `_write_regular_rows` adapt based on that: eg extend values with index er not: https://github.com/pandas-dev/pandas/pull/14999/files#diff-893f461e63cbb3ced9ab2c53328416a0L1216 and then pass an argument to `self.write_tr` to specify there should be a th or not (https://github.com/pandas-dev/pandas/pull/14999/files#diff-893f461e63cbb3ced9ab2c53328416a0L1222). 
But not sure how many side effects this would have that makes it more complicated. So as a follow-up is fine as well.
thanks @TomAugspurger 
Opened #15019 for the remaining issue with the truncation
DOC: consistent import timedeltas docs
State: closed

Added consistent import for timedeltas docs, i.e.: `import pandas as pd`, `import datetime`.
See: https://github.com/pandas-dev/pandas/issues/9886

Didn't touch the `pandas.tseries.offsets` since no consensus has been made how to import those.

Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14997?src=pr) is 84.78% (diff: 100%)
> Merging [#14997](https://codecov.io/gh/pandas-dev/pandas/pull/14997?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **<.01%**

```diff
@@             master     #14997   diff @@
==========================================
  Files           145        145          
  Lines         51090      51090          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43316      43315     -1   
- Misses         7774       7775     +1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [eecfa88...f5bd961](https://codecov.io/gh/pandas-dev/pandas/compare/eecfa8843a0c90b5424e9e0e4d353bbb3b78a671...f5bd96190809e6493e373e57fbb1228972ef9255?src=pr)
@jackieleng Thanks a lot! 
If you want to do the same for other files, very welcome! (not all have been cleaned up yet)
BUG: fixed index power operation
State: closed

* The power operation on a range of indexes was fixed. See issue #14973

 - [ ] closes #14973
 - [ ] tests added / passed
 - [ ] passes ``git diff upstream/master | flake8 --diff``
 - [ ] whatsnew entry


Labels:
name: Bug
name: Numeric Operations
description: Arithmetic, Comparison, and Logical operations

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14996?src=pr) is 84.78% (diff: 100%)
> Merging [#14996](https://codecov.io/gh/pandas-dev/pandas/pull/14996?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **<.01%**

```diff
@@             master     #14996   diff @@
==========================================
  Files           145        145          
  Lines         51090      51091     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43315      43317     +2   
+ Misses         7775       7774     -1   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [7f0eefc...66c2338](https://codecov.io/gh/pandas-dev/pandas/compare/7f0eefc2f81d6b34f252a5da38d31e515c295106...66c23384c657047308b9c4eac4f593309216d84e?src=pr)
@jreback  anything more I can do to have it accepted?
thanks!
DOC: Clarified and expanded describe documentation
State: closed

 - [x] passes ``git diff upstream/master | flake8 --diff``

As discussed in #14483.

Labels:
name: Docs

Comments:
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14995?src=pr) is 84.77% (diff: 100%)
> Merging [#14995](https://codecov.io/gh/pandas-dev/pandas/pull/14995?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will decrease coverage by **0.01%**

```diff
@@             master     #14995   diff @@
==========================================
  Files           145        145          
  Lines         51090      51129    +39   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43316      43343    +27   
- Misses         7774       7786    +12   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [eecfa88...8880a89](https://codecov.io/gh/pandas-dev/pandas/compare/eecfa8843a0c90b5424e9e0e4d353bbb3b78a671...8880a89889e16ced7c0b6201f40981b7e8b51b68?src=pr)
I've just pushed an update that tried to address your requests, @jorisvandenbossche. Please let me know if there's more I can do.
@jorisvandenbossche, I have just pushed a number of new changes to try to conform with your second round of requests. Please let me know if there is more I can do. Thank you for your thorough review. 
@palewire Looks good! You only have a few PEP8 issues (which causes travis to fail):

```
pandas/core/generic.py:5222:80: E501 line too long (85 > 79 characters)
pandas/core/generic.py:5239:80: E501 line too long (81 > 79 characters)
pandas/core/generic.py:5320:80: E501 line too long (80 > 79 characters)
pandas/core/generic.py:5353:80: E501 line too long (81 > 79 characters)
```

If those are fixed this can be merged!
I am ok with this as the docs for series are so close to dataframe its fine to combine.

@jorisvandenbossche I have just now made and pushed the PEP8 corrections you requested. 
@palewire Thanks!
BUG: Reindex with columns and method
State: closed

 - [x] closes #14992
 - [x] tests added / passed
 - [x] passes ``git diff upstream/master | flake8 --diff``
 - [x] whatsnew entry


Labels:
name: Bug
name: Indexing
description: Related to indexing on series/frames, not to indexes themselves
name: Missing-data
description: np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
name: Reshaping
description: Concat, Merge/Join, Stack/Unstack, Explode

Comments:
tests please 
## [Current coverage](https://codecov.io/gh/pandas-dev/pandas/pull/14993?src=pr) is 84.78% (diff: 100%)
> Merging [#14993](https://codecov.io/gh/pandas-dev/pandas/pull/14993?src=pr) into [master](https://codecov.io/gh/pandas-dev/pandas/branch/master?src=pr) will increase coverage by **0.12%**

```diff
@@             master     #14993   diff @@
==========================================
  Files           144        145     +1   
  Lines         51056      51091    +35   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43225      43316    +91   
+ Misses         7831       7775    -56   
  Partials          0          0          
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update [72786cc...9c9ad95](https://codecov.io/gh/pandas-dev/pandas/compare/72786cc8038943cc7ed11affa35fc98734c5a86c...9c9ad956be81193bf5178e622178fc07a2b1976c?src=pr)
thanks!
BLD: move + update build script
State: closed

Only one source dist format to upload since https://www.python.org/dev/peps/pep-0527/

Labels:
name: Build
description: Library building on various platforms

Comments:
Release wiki is also updated
side note

the wiki dupes pandas website updating (prob take the 2nd section)
@jreback yep, indeed. Should also check those descriptions for which one is still working, as I did it a bit differently last time.