CLN: display.notebook_repr_html -> display.html.notebook (GH11784)
State: closed

Deprecate display.notebook_repr_html option and move it to
display.html.notebook

- [X] closes #11784
- [X] tests added / passed
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry

Labels:
name: IO HTML
description: read_html, to_html, Styler.apply, Styler.applymap
name: Compat
description: pandas objects compatability with Numpy or Python functions
name: Deprecate
description: Functionality to remove in pandas

Comments:
# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20396?src=pr&el=h1) Report
> Merging [#20396](https://codecov.io/gh/pandas-dev/pandas/pull/20396?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/670c2e437e90c08105b2d83df868fc8c6c668a3b?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/20396/graphs/tree.svg?height=150&width=650&token=eZ4WkYLtcO&src=pr)](https://codecov.io/gh/pandas-dev/pandas/pull/20396?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master   #20396      +/-   ##
==========================================
+ Coverage   91.79%   91.79%   +<.01%     
==========================================
  Files         152      152              
  Lines       49205    49208       +3     
==========================================
+ Hits        45169    45172       +3     
  Misses       4036     4036
```

| Flag | Coverage Δ | |
|---|---|---|
| #multiple | `90.18% <100%> (ø)` | :arrow_up: |
| #single | `41.85% <83.33%> (ø)` | :arrow_up: |

| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/20396?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pandas/core/config\_init.py](https://codecov.io/gh/pandas-dev/pandas/pull/20396/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvY29uZmlnX2luaXQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/20396/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.18% <100%> (ø)` | :arrow_up: |
| [pandas/core/indexes/base.py](https://codecov.io/gh/pandas-dev/pandas/pull/20396/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9iYXNlLnB5) | `96.68% <0%> (ø)` | :arrow_up: |
| [pandas/core/internals.py](https://codecov.io/gh/pandas-dev/pandas/pull/20396/diff?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW50ZXJuYWxzLnB5) | `95.53% <0%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20396?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/20396?src=pr&el=footer). Last update [670c2e4...0ee1367](https://codecov.io/gh/pandas-dev/pandas/pull/20396?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

I personally have some doubts about this deprecation. 1) a lot of people use this, just changing it for cosmetic reasons can be annoying, 2) I actually find the current name much more self-explanatory.
closing, @jorisvandenbossche logic is compelling